[jira] [Resolved] (KAFKA-12795) Create kafka connector use chinese character failed

2021-07-13 Thread pengWei Dou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] pengWei Dou resolved KAFKA-12795. - Resolution: Won't Fix > Create kafka connector use chinese character failed > --

[GitHub] [kafka] cadonna commented on pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

2021-07-13 Thread GitBox
cadonna commented on pull request #10953: URL: https://github.com/apache/kafka/pull/10953#issuecomment-878835507 > I don't see how there could be data loss? There could be data loss, because locally the windowed state store would store records for a longer period of time than in the chan

[GitHub] [kafka] cadonna edited a comment on pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

2021-07-13 Thread GitBox
cadonna edited a comment on pull request #10953: URL: https://github.com/apache/kafka/pull/10953#issuecomment-878835507 > I don't see how there could be data loss? There could be data loss, because locally the windowed state store would store records for a longer period of time than

[jira] [Commented] (KAFKA-8549) Kafka Windows start up fail due to cannot be performed on a file with a user-mapped section open

2021-07-13 Thread DEBENDRA DHINDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379665#comment-17379665 ] DEBENDRA DHINDA commented on KAFKA-8549: Is it resolved ? > Kafka Windows start

[jira] [Created] (KAFKA-13076) cannot consumer

2021-07-13 Thread label (Jira)
label created KAFKA-13076: - Summary: cannot consumer Key: KAFKA-13076 URL: https://issues.apache.org/jira/browse/KAFKA-13076 Project: Kafka Issue Type: Bug Components: consumer Affects

[jira] [Updated] (KAFKA-13076) cannot consumer

2021-07-13 Thread label (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] label updated KAFKA-13076: -- Attachment: zookeeper.properties server.properties > cannot consumer > --- > >

[jira] [Updated] (KAFKA-13076) cannot consumer

2021-07-13 Thread label (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] label updated KAFKA-13076: -- Issue Type: Improvement (was: Bug) > cannot consumer > --- > > Key: KAFKA-13076 >

[jira] [Updated] (KAFKA-13076) cannot consumer

2021-07-13 Thread label (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] label updated KAFKA-13076: -- Priority: Blocker (was: Major) > cannot consumer > --- > > Key: KAFKA-13076 >

[jira] [Updated] (KAFKA-13076) cannot consumer

2021-07-13 Thread label (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] label updated KAFKA-13076: -- Issue Type: Bug (was: Improvement) > cannot consumer > --- > > Key: KAFKA-13076 >

[GitHub] [kafka] showuon commented on a change in pull request #10985: KAFKA-12984: make AbstractStickyAssignor resilient to invalid input, utilize generation in cooperative, and fix assignment bug

2021-07-13 Thread GitBox
showuon commented on a change in pull request #10985: URL: https://github.com/apache/kafka/pull/10985#discussion_r668510115 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -205,6 +237,9 @@ private boolean allSub

[GitHub] [kafka] jlprat commented on a change in pull request #10987: MINOR: improve the partitioner.class doc

2021-07-13 Thread GitBox
jlprat commented on a change in pull request #10987: URL: https://github.com/apache/kafka/pull/10987#discussion_r668507450 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -234,7 +234,24 @@ /** partitioner.class */ pub

[GitHub] [kafka] showuon commented on a change in pull request #10985: KAFKA-12984: make AbstractStickyAssignor resilient to invalid input, utilize generation in cooperative, and fix assignment bug

2021-07-13 Thread GitBox
showuon commented on a change in pull request #10985: URL: https://github.com/apache/kafka/pull/10985#discussion_r668514017 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -205,6 +237,9 @@ private boolean allSub

[GitHub] [kafka] showuon commented on a change in pull request #10985: KAFKA-12984: make AbstractStickyAssignor resilient to invalid input, utilize generation in cooperative, and fix assignment bug

2021-07-13 Thread GitBox
showuon commented on a change in pull request #10985: URL: https://github.com/apache/kafka/pull/10985#discussion_r668516397 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -218,70 +253,87 @@ private boolean allS

[jira] [Updated] (KAFKA-13058) `AlterConsumerGroupOffsetsHandler` does not handle partition errors correctly.

2021-07-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-13058: Fix Version/s: 3.0.0 > `AlterConsumerGroupOffsetsHandler` does not handle partition errors correct

[GitHub] [kafka] showuon opened a new pull request #11035: KAFKA-13072: refactor RemoveMembersFromConsumerGroupHandler and tests

2021-07-13 Thread GitBox
showuon opened a new pull request #11035: URL: https://github.com/apache/kafka/pull/11035 Some issues found in the RemoveMembersFromConsumerGroupHandler: 1. if coordinator errors is put in the member, we don't do retry. Fix it and add tests This is the old handle response logic. F

[GitHub] [kafka] showuon commented on pull request #11035: KAFKA-13072: refactor RemoveMembersFromConsumerGroupHandler and tests

2021-07-13 Thread GitBox
showuon commented on pull request #11035: URL: https://github.com/apache/kafka/pull/11035#issuecomment-878939627 @dajac , please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] showuon commented on pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

2021-07-13 Thread GitBox
showuon commented on pull request #10973: URL: https://github.com/apache/kafka/pull/10973#issuecomment-878942169 I've split this PR into 5 sub-PRs: https://github.com/apache/kafka/pull/11019 for DeleteConsumerGroupOffsetsHandler https://github.com/apache/kafka/pull/11021 for Delet

[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2

2021-07-13 Thread GitBox
showuon commented on pull request #10884: URL: https://github.com/apache/kafka/pull/10884#issuecomment-878942836 Interesting. I'll take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] cadonna edited a comment on pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

2021-07-13 Thread GitBox
cadonna edited a comment on pull request #10953: URL: https://github.com/apache/kafka/pull/10953#issuecomment-878835507 > I don't see how there could be data loss? There could be data loss, because locally the windowed state store would store records for a longer period of time than

[GitHub] [kafka] cadonna commented on pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

2021-07-13 Thread GitBox
cadonna commented on pull request #10953: URL: https://github.com/apache/kafka/pull/10953#issuecomment-878965687 > However, looking into the code I am a little bit confused about maintainMs() in TimeWindows: > ``` public long maintainMs() { return Math.max(maintainDurationM

[GitHub] [kafka] tombentley commented on pull request #10945: KAFKA-13017: Remove excessive logging for sink task deserialization errors

2021-07-13 Thread GitBox
tombentley commented on pull request #10945: URL: https://github.com/apache/kafka/pull/10945#issuecomment-878974936 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [kafka] cadonna commented on a change in pull request #10944: MINOR: Loose verification of startup in EOS system tests

2021-07-13 Thread GitBox
cadonna commented on a change in pull request #10944: URL: https://github.com/apache/kafka/pull/10944#discussion_r668643843 ## File path: tests/kafkatest/tests/streams/streams_eos_test.py ## @@ -128,45 +128,61 @@ def run_failure_and_recovery(self, processor1, processor2, proce

[GitHub] [kafka] cadonna edited a comment on pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

2021-07-13 Thread GitBox
cadonna edited a comment on pull request #10953: URL: https://github.com/apache/kafka/pull/10953#issuecomment-878965687 > However, looking into the code I am a little bit confused about maintainMs() in TimeWindows: > ``` public long maintainMs() { return Math.max(maintainDu

[GitHub] [kafka] cadonna commented on pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

2021-07-13 Thread GitBox
cadonna commented on pull request #10953: URL: https://github.com/apache/kafka/pull/10953#issuecomment-878999564 I think we had a bug in the `SessionWindows` because we have never considered a user set grace period when we computed the retention time. That should be fixed with the new API,

[jira] [Updated] (KAFKA-13055) Security without JAAS configuration

2021-07-13 Thread Alexey Kashavkin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kashavkin updated KAFKA-13055: - Description: I think that this isn't a bug, but I don't know what type to choose for thi

[jira] [Issue Comment Deleted] (KAFKA-13055) Security without JAAS configuration

2021-07-13 Thread Alexey Kashavkin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kashavkin updated KAFKA-13055: - Comment: was deleted (was: {code:bash} listener.name.clients.scram-sha-256.sasl.jaas.con

[GitHub] [kafka] OmniaGM commented on pull request #11007: KAFKA-10589 Rename kafka-replica-verification CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
OmniaGM commented on pull request #11007: URL: https://github.com/apache/kafka/pull/11007#issuecomment-879026189 @gwenshap (or any other committer) can you please have a look into this? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] showuon commented on pull request #10559: MINOR: diable RaftClusterTest first

2021-07-13 Thread GitBox
showuon commented on pull request #10559: URL: https://github.com/apache/kafka/pull/10559#issuecomment-879029730 close this PR since the root cause is fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] showuon closed pull request #10559: MINOR: diable RaftClusterTest first

2021-07-13 Thread GitBox
showuon closed pull request #10559: URL: https://github.com/apache/kafka/pull/10559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] cadonna commented on pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-07-13 Thread GitBox
cadonna commented on pull request #10851: URL: https://github.com/apache/kafka/pull/10851#issuecomment-879032262 @lkokhreidze Sorry for the long silence! Some other tasks got in my way. I plan to review this PR tomorrow. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-07-13 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-879046873 @emveee Thank you so much for being so interested. 2.8.0 backport preview will be released this week. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] showuon commented on pull request #11009: MINOR: update doc for default assignor change

2021-07-13 Thread GitBox
showuon commented on pull request #11009: URL: https://github.com/apache/kafka/pull/11009#issuecomment-879049924 Previous build has one test group timeout. Re-trigger it again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] dajac commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
dajac commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668716740 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -191,9 +191,15 @@ object ConsoleConsumer extends Logging { .withRequiredArg

[GitHub] [kafka] dajac commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-13 Thread GitBox
dajac commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r668728522 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandler.java ## @@ -100,51 +100,115 @@ public String

[GitHub] [kafka] dongjinleekr commented on a change in pull request #11007: KAFKA-10589 Rename kafka-replica-verification CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
dongjinleekr commented on a change in pull request #11007: URL: https://github.com/apache/kafka/pull/11007#discussion_r668731566 ## File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala ## @@ -89,11 +89,16 @@ object ReplicaVerificationTool extends Logging {

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668733381 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -191,9 +191,15 @@ object ConsoleConsumer extends Logging { .withRequiredA

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668733930 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging { formatter.con

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668733930 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging { formatter.con

[jira] [Commented] (KAFKA-12656) JMX exporter is leaking a lot of file descriptors

2021-07-13 Thread Angelos Kaltsikis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379871#comment-17379871 ] Angelos Kaltsikis commented on KAFKA-12656: --- Hey [~liangx], Thanks for opening

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668733930 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging { formatter.con

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668752416 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging { formatter.con

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668752416 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging { formatter.con

[GitHub] [kafka] dongjinleekr commented on pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

2021-07-13 Thread GitBox
dongjinleekr commented on pull request #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-879085051 @kkonstantine It would be really great for me if this PR is included in 3.0, but it still needs one more binding +1. (It is also why it is prefixed with '[WIP]'.) Could you

[jira] [Commented] (KAFKA-12954) Add Support for Scala 3 in 4.0.0

2021-07-13 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379887#comment-17379887 ] Josep Prat commented on KAFKA-12954: Forgot to mention, this is the PR where Scala 3

[GitHub] [kafka] dajac commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
dajac commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668766346 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging { formatter.confi

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668733930 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging { formatter.con

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668733930 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging { formatter.con

[GitHub] [kafka] dajac commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
dajac commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668772378 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging { formatter.confi

[GitHub] [kafka] ijuma commented on a change in pull request #11025: Scala 3 Compilation with 2.12 support

2021-07-13 Thread GitBox
ijuma commented on a change in pull request #11025: URL: https://github.com/apache/kafka/pull/11025#discussion_r668774185 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/KStream.scala ## @@ -790,7 +790,7 @@ class KStream[K, V](val inne

[GitHub] [kafka] ijuma commented on a change in pull request #11025: Scala 3 Compilation with 2.12 support

2021-07-13 Thread GitBox
ijuma commented on a change in pull request #11025: URL: https://github.com/apache/kafka/pull/11025#discussion_r668774761 ## File path: Jenkinsfile ## @@ -181,6 +181,25 @@ pipeline { } } +stage('JDK 11 and Scala 3.0') { Review comment: We w

[GitHub] [kafka] ijuma commented on pull request #11025: Scala 3 Compilation with 2.12 support

2021-07-13 Thread GitBox
ijuma commented on pull request #11025: URL: https://github.com/apache/kafka/pull/11025#issuecomment-879100667 Thanks for the PR. Are we sure everything works correctly at the zinc level? Someone mentioned a zinc upgrade here https://github.com/gradle/gradle/issues/16527. The 3.1 release i

[GitHub] [kafka] jlprat commented on a change in pull request #11025: Scala 3 Compilation with 2.12 support

2021-07-13 Thread GitBox
jlprat commented on a change in pull request #11025: URL: https://github.com/apache/kafka/pull/11025#discussion_r668778973 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/KStream.scala ## @@ -790,7 +790,7 @@ class KStream[K, V](val inn

[GitHub] [kafka] jlprat commented on a change in pull request #11025: Scala 3 Compilation with 2.12 support

2021-07-13 Thread GitBox
jlprat commented on a change in pull request #11025: URL: https://github.com/apache/kafka/pull/11025#discussion_r668779835 ## File path: Jenkinsfile ## @@ -181,6 +181,25 @@ pipeline { } } +stage('JDK 11 and Scala 3.0') { Review comment: Mak

[GitHub] [kafka] showuon commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-13 Thread GitBox
showuon commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r668780259 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandler.java ## @@ -100,51 +100,115 @@ public Stri

[GitHub] [kafka] dajac commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-13 Thread GitBox
dajac commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r668781007 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandler.java ## @@ -100,51 +100,115 @@ public String

[GitHub] [kafka] ijuma commented on a change in pull request #11025: Scala 3 Compilation with 2.12 support

2021-07-13 Thread GitBox
ijuma commented on a change in pull request #11025: URL: https://github.com/apache/kafka/pull/11025#discussion_r668782203 ## File path: Jenkinsfile ## @@ -181,6 +181,25 @@ pipeline { } } +stage('JDK 11 and Scala 3.0') { Review comment: For

[GitHub] [kafka] jlprat commented on pull request #11025: Scala 3 Compilation with 2.12 support

2021-07-13 Thread GitBox
jlprat commented on pull request #11025: URL: https://github.com/apache/kafka/pull/11025#issuecomment-879106262 I agree with you, this can still wait a bit. I just wanted to check if it was a low effort task or a high one. Regarding if we are sure that everything works correctly, I can s

[GitHub] [kafka] jlprat closed pull request #11025: Scala 3 Compilation with 2.12 support

2021-07-13 Thread GitBox
jlprat closed pull request #11025: URL: https://github.com/apache/kafka/pull/11025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] jlprat commented on pull request #11025: Scala 3 Compilation with 2.12 support

2021-07-13 Thread GitBox
jlprat commented on pull request #11025: URL: https://github.com/apache/kafka/pull/11025#issuecomment-879108009 Closing this in favour of https://github.com/apache/kafka/pull/11025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] jlprat removed a comment on pull request #11025: Scala 3 Compilation with 2.12 support

2021-07-13 Thread GitBox
jlprat removed a comment on pull request #11025: URL: https://github.com/apache/kafka/pull/11025#issuecomment-879108009 Closing this in favour of https://github.com/apache/kafka/pull/11025 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] jlprat commented on pull request #10934: [DO NOT MERGE] Scala3 test

2021-07-13 Thread GitBox
jlprat commented on pull request #10934: URL: https://github.com/apache/kafka/pull/10934#issuecomment-879108529 Closing in favor of https://github.com/apache/kafka/pull/11025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] jlprat closed pull request #10934: [DO NOT MERGE] Scala3 test

2021-07-13 Thread GitBox
jlprat closed pull request #10934: URL: https://github.com/apache/kafka/pull/10934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] showuon commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-13 Thread GitBox
showuon commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r668787834 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandler.java ## @@ -100,51 +100,115 @@ public Stri

[GitHub] [kafka] jlprat commented on a change in pull request #11025: Scala 3 Compilation with 2.12 support

2021-07-13 Thread GitBox
jlprat commented on a change in pull request #11025: URL: https://github.com/apache/kafka/pull/11025#discussion_r668788605 ## File path: Jenkinsfile ## @@ -181,6 +181,25 @@ pipeline { } } +stage('JDK 11 and Scala 3.0') { Review comment: Mak

[jira] [Assigned] (KAFKA-12767) Properly set Streams system test runtime classpath

2021-07-13 Thread Manasvi Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manasvi Gupta reassigned KAFKA-12767: - Assignee: Manasvi Gupta > Properly set Streams system test runtime classpath >

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668793973 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging { formatter.con

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668793973 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging { formatter.con

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668793973 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging { formatter.con

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668796809 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging { formatter.con

[GitHub] [kafka] dajac commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

2021-07-13 Thread GitBox
dajac commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r668799671 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandler.java ## @@ -100,51 +100,115 @@ public String

[GitHub] [kafka] jlprat commented on a change in pull request #11025: Scala 3 Compilation with 2.12 support

2021-07-13 Thread GitBox
jlprat commented on a change in pull request #11025: URL: https://github.com/apache/kafka/pull/11025#discussion_r668804824 ## File path: gradlewAll ## @@ -15,5 +15,5 @@ # Convenient way to invoke a gradle command with all Scala versions supported # by default -./gradlew "$@

[GitHub] [kafka] dajac commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
dajac commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668805752 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging { formatter.confi

[GitHub] [kafka] vvcephei commented on a change in pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-13 Thread GitBox
vvcephei commented on a change in pull request #10994: URL: https://github.com/apache/kafka/pull/10994#discussion_r668838008 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -119,45 +157,42 @@ Overviewprocess() method, upon each received record, split the va

[GitHub] [kafka] vvcephei commented on a change in pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-13 Thread GitBox
vvcephei commented on a change in pull request #10994: URL: https://github.com/apache/kafka/pull/10994#discussion_r668839336 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -86,12 +86,48 @@ Overviewclose() method. Note that Kafka Streams may re-use a single

[GitHub] [kafka] vvcephei commented on a change in pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-13 Thread GitBox
vvcephei commented on a change in pull request #10994: URL: https://github.com/apache/kafka/pull/10994#discussion_r668841230 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -86,12 +86,48 @@ Overviewclose() method. Note that Kafka Streams may re-use a single

[GitHub] [kafka] vvcephei commented on a change in pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-13 Thread GitBox
vvcephei commented on a change in pull request #10994: URL: https://github.com/apache/kafka/pull/10994#discussion_r668841380 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -86,12 +86,48 @@ Overviewclose() method. Note that Kafka Streams may re-use a single

[GitHub] [kafka] vvcephei commented on a change in pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-13 Thread GitBox
vvcephei commented on a change in pull request #10994: URL: https://github.com/apache/kafka/pull/10994#discussion_r668842117 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -86,12 +86,48 @@ Overviewclose() method. Note that Kafka Streams may re-use a single

[GitHub] [kafka] ijuma opened a new pull request #11036: KAFKA-12944: Always write record batches with v2 (KIP-724)

2021-07-13 Thread GitBox
ijuma opened a new pull request #11036: URL: https://github.com/apache/kafka/pull/11036 TBD ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[GitHub] [kafka] vvcephei commented on a change in pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-13 Thread GitBox
vvcephei commented on a change in pull request #10994: URL: https://github.com/apache/kafka/pull/10994#discussion_r668842244 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -86,12 +86,48 @@ Overviewclose() method. Note that Kafka Streams may re-use a single

[GitHub] [kafka] vvcephei commented on a change in pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-13 Thread GitBox
vvcephei commented on a change in pull request #10994: URL: https://github.com/apache/kafka/pull/10994#discussion_r668849485 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -86,12 +86,48 @@ Overviewclose() method. Note that Kafka Streams may re-use a single

[GitHub] [kafka] vvcephei commented on a change in pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-13 Thread GitBox
vvcephei commented on a change in pull request #10994: URL: https://github.com/apache/kafka/pull/10994#discussion_r668848827 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -86,12 +86,48 @@ Overviewclose() method. Note that Kafka Streams may re-use a single

[jira] [Assigned] (KAFKA-13070) LogManager shutdown races with periodic work scheduled by the instance

2021-07-13 Thread Manasvi Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manasvi Gupta reassigned KAFKA-13070: - Assignee: Manasvi Gupta > LogManager shutdown races with periodic work scheduled by the

[jira] [Created] (KAFKA-13077) Replication failing after unclean shutdown of ZK and all brokers

2021-07-13 Thread Christopher Auston (Jira)
Christopher Auston created KAFKA-13077: -- Summary: Replication failing after unclean shutdown of ZK and all brokers Key: KAFKA-13077 URL: https://issues.apache.org/jira/browse/KAFKA-13077 Project:

[GitHub] [kafka] vvcephei commented on a change in pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-13 Thread GitBox
vvcephei commented on a change in pull request #10994: URL: https://github.com/apache/kafka/pull/10994#discussion_r668856588 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -108,8 +144,10 @@ Overviewinit() method. Attention -

[GitHub] [kafka] vvcephei commented on a change in pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-13 Thread GitBox
vvcephei commented on a change in pull request #10994: URL: https://github.com/apache/kafka/pull/10994#discussion_r668856588 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -108,8 +144,10 @@ Overviewinit() method. Attention -

[GitHub] [kafka] vvcephei commented on a change in pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-13 Thread GitBox
vvcephei commented on a change in pull request #10994: URL: https://github.com/apache/kafka/pull/10994#discussion_r668857339 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -119,45 +157,42 @@ Overviewprocess() method, upon each received record, split the va

[GitHub] [kafka] chia7712 commented on a change in pull request #11006: KAFKA-13049: Name the threads used for log recovery

2021-07-13 Thread GitBox
chia7712 commented on a change in pull request #11006: URL: https://github.com/apache/kafka/pull/11006#discussion_r668859528 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -406,6 +398,18 @@ class LogManager(logDirs: Seq[File], info(s"Loaded $numTotalLog

[GitHub] [kafka] dajac commented on a change in pull request #11026: KAFKA-13064: refactor ListConsumerGroupOffsetsHandler and tests

2021-07-13 Thread GitBox
dajac commented on a change in pull request #11026: URL: https://github.com/apache/kafka/pull/11026#discussion_r668864349 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java ## @@ -110,41 +112,97 @@ public String ap

[GitHub] [kafka] xvrl commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
xvrl commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668869858 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,18 @@ object ConsoleConsumer extends Logging { formatter.config

[GitHub] [kafka] vvcephei merged pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-13 Thread GitBox
vvcephei merged pull request #10994: URL: https://github.com/apache/kafka/pull/10994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[GitHub] [kafka] xvrl commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
xvrl commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668872338 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging { formatter.config

[GitHub] [kafka] xvrl commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
xvrl commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668872810 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -191,9 +191,15 @@ object ConsoleConsumer extends Logging { .withRequiredArg

[GitHub] [kafka] vvcephei commented on pull request #10994: KAFKA-8410: Update the docs to reference the new PAPI

2021-07-13 Thread GitBox
vvcephei commented on pull request #10994: URL: https://github.com/apache/kafka/pull/10994#issuecomment-879184656 Thanks so much for the reviews, everyone! I've merged and cherry-picked to 3.0 (cc @kkonstantine ) -- This is an automated message from the Apache Git Service. To respo

[GitHub] [kafka] tombentley commented on a change in pull request #11006: KAFKA-13049: Name the threads used for log recovery

2021-07-13 Thread GitBox
tombentley commented on a change in pull request #11006: URL: https://github.com/apache/kafka/pull/11006#discussion_r66179 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -406,6 +398,18 @@ class LogManager(logDirs: Seq[File], info(s"Loaded $numTotalL

[GitHub] [kafka] tombentley commented on pull request #11006: KAFKA-13049: Name the threads used for log recovery

2021-07-13 Thread GitBox
tombentley commented on pull request #11006: URL: https://github.com/apache/kafka/pull/11006#issuecomment-879198054 Will merge on green CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668901219 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,18 @@ object ConsoleConsumer extends Logging { formatter.con

[GitHub] [kafka] tang7526 opened a new pull request #11037: MINOR: Replace unused variable with underscore

2021-07-13 Thread GitBox
tang7526 opened a new pull request #11037: URL: https://github.com/apache/kafka/pull/11037 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] xvrl commented on a change in pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
xvrl commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r668913284 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,18 @@ object ConsoleConsumer extends Logging { formatter.config

[GitHub] [kafka] dajac commented on pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
dajac commented on pull request #11008: URL: https://github.com/apache/kafka/pull/11008#issuecomment-879222701 @xvrl Have we already discussed with @kkonstantine to still include this in 3.0? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] xvrl commented on pull request #11008: KAFKA-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

2021-07-13 Thread GitBox
xvrl commented on pull request #11008: URL: https://github.com/apache/kafka/pull/11008#issuecomment-879223444 @dajac yes, we want to include this in 3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

  1   2   3   >