[jira] [Updated] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-08-05 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13128: --- Fix Version/s: (was: 2.8.1) (was: 3.0.0) > Flaky

[jira] [Reopened] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-08-05 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reopened KAFKA-13128: Assignee: (was: A. Sophie Blee-Goldman) Failed again for a different

[GitHub] [kafka] dielhennr commented on a change in pull request #11179: KAFKA-13165: Validate node id, process role and quorum voters

2021-08-05 Thread GitBox
dielhennr commented on a change in pull request #11179: URL: https://github.com/apache/kafka/pull/11179#discussion_r683960767 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -214,6 +220,12 @@ class KafkaRaftManager[T]( KafkaRaftManager.createLogDirecto

[GitHub] [kafka] guozhangwang commented on pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-05 Thread GitBox
guozhangwang commented on pull request #10788: URL: https://github.com/apache/kafka/pull/10788#issuecomment-893993452 LGTM! Please feel free to merge after green builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] guozhangwang commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-05 Thread GitBox
guozhangwang commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r683938654 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java ## @@ -67,13 +72,31 @@ public class Name

[GitHub] [kafka] guozhangwang commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-05 Thread GitBox
guozhangwang commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r683938587 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -53,44 +56,162 @@ private static f

[GitHub] [kafka] showuon commented on a change in pull request #11175: MINOR: Fix getting started documentation

2021-08-05 Thread GitBox
showuon commented on a change in pull request #11175: URL: https://github.com/apache/kafka/pull/11175#discussion_r683905633 ## File path: config/kraft/README.md ## @@ -26,7 +27,7 @@ xtzWWN4bTjitpL3kfd9s5g ## Format Storage Directories -The next step is to format your s

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-05 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r683902306 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -517,9 +526,9 @@ void handleRevocation(final

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-05 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r683902306 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -517,9 +526,9 @@ void handleRevocation(final

[GitHub] [kafka] showuon commented on a change in pull request #11184: KAFKA-13172: Add downgrade guidance note for 3.0

2021-08-05 Thread GitBox
showuon commented on a change in pull request #11184: URL: https://github.com/apache/kafka/pull/11184#discussion_r683900989 ## File path: docs/streams/upgrade-guide.html ## @@ -52,6 +52,15 @@ Upgrade Guide and API Changes restart all new ({{fullDotVersion}}) applicati

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-05 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r683901855 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -775,26 +806,16 @@ private void completeTask

[GitHub] [kafka] dielhennr commented on a change in pull request #11179: KAFKA-13165: Validate node id, process role and quorum voters

2021-08-05 Thread GitBox
dielhennr commented on a change in pull request #11179: URL: https://github.com/apache/kafka/pull/11179#discussion_r683894514 ## File path: core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala ## @@ -262,6 +262,8 @@ class KafkaConfigTest { props.put(KafkaConfig.Proc

[GitHub] [kafka] zhaohaidao commented on pull request #11182: KAFKA-13074: Implement mayClean for MockLog

2021-08-05 Thread GitBox
zhaohaidao commented on pull request #11182: URL: https://github.com/apache/kafka/pull/11182#issuecomment-893935065 @jsancio Could you please review this pr if you have time, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] dielhennr commented on a change in pull request #11179: KAFKA-13165: Validate node id, process role and quorum voters

2021-08-05 Thread GitBox
dielhennr commented on a change in pull request #11179: URL: https://github.com/apache/kafka/pull/11179#discussion_r683880423 ## File path: core/src/test/scala/unit/kafka/raft/RaftManagerTest.scala ## @@ -34,21 +34,30 @@ import org.mockito.Mockito._ class RaftManagerTest {

[jira] [Resolved] (KAFKA-13132) Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-08-05 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13132. - Resolution: Fixed > Upgrading to topic IDs in LISR requests has gaps introduced in 3.0 >

[GitHub] [kafka] dielhennr commented on a change in pull request #11179: KAFKA-13165: Validate node id, process role and quorum voters

2021-08-05 Thread GitBox
dielhennr commented on a change in pull request #11179: URL: https://github.com/apache/kafka/pull/11179#discussion_r683879932 ## File path: core/src/test/scala/unit/kafka/raft/RaftManagerTest.scala ## @@ -34,21 +34,30 @@ import org.mockito.Mockito._ class RaftManagerTest {

[GitHub] [kafka] hachikuji merged pull request #11171: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0 (part 2)

2021-08-05 Thread GitBox
hachikuji merged pull request #11171: URL: https://github.com/apache/kafka/pull/11171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] ableegoldman commented on a change in pull request #11184: KAFKA-13172: Add downgrade guidance note for 3.0

2021-08-05 Thread GitBox
ableegoldman commented on a change in pull request #11184: URL: https://github.com/apache/kafka/pull/11184#discussion_r683876709 ## File path: docs/streams/upgrade-guide.html ## @@ -52,6 +52,15 @@ Upgrade Guide and API Changes restart all new ({{fullDotVersion}}) appl

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-05 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r683874039 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -719,6 +723,8 @@ void runOnce() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-05 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r683872205 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -53,44 +56,162 @@ private static f

[jira] [Created] (KAFKA-13174) Log Compaction Blocked Forever by Unstable Offset/Unclosed Transaction

2021-08-05 Thread Michael Jaschob (Jira)
Michael Jaschob created KAFKA-13174: --- Summary: Log Compaction Blocked Forever by Unstable Offset/Unclosed Transaction Key: KAFKA-13174 URL: https://issues.apache.org/jira/browse/KAFKA-13174 Project:

[GitHub] [kafka] jsancio commented on a change in pull request #11179: KAFKA-13165: Validate node id, process role and quorum voters

2021-08-05 Thread GitBox
jsancio commented on a change in pull request #11179: URL: https://github.com/apache/kafka/pull/11179#discussion_r683859800 ## File path: core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala ## @@ -262,6 +262,8 @@ class KafkaConfigTest { props.put(KafkaConfig.Proces

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-05 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r683851998 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -1193,6 +1189,18 @@ public void updateTaskEn

[GitHub] [kafka] guozhangwang commented on pull request #11184: KAFKA-13172: Add downgrade guidance note for 3.0

2021-08-05 Thread GitBox
guozhangwang commented on pull request #11184: URL: https://github.com/apache/kafka/pull/11184#issuecomment-893876355 ping @ableegoldman @cadonna for reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] guozhangwang opened a new pull request #11184: KAFKA-13172: Add downgrade guidance note for 3.0

2021-08-05 Thread GitBox
guozhangwang opened a new pull request #11184: URL: https://github.com/apache/kafka/pull/11184 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[jira] [Commented] (KAFKA-13170) Flaky Test InternalTopicManagerTest.shouldRetryDeleteTopicWhenTopicUnknown

2021-08-05 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394358#comment-17394358 ] Guozhang Wang commented on KAFKA-13170: --- I think I know the reason of this flaky t

[GitHub] [kafka] guozhangwang commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-05 Thread GitBox
guozhangwang commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r683823753 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -53,44 +56,162 @@ private static f

[GitHub] [kafka] ableegoldman commented on pull request #11183: MINOR: Increase the Kafka shutdown timeout to 120

2021-08-05 Thread GitBox
ableegoldman commented on pull request #11183: URL: https://github.com/apache/kafka/pull/11183#issuecomment-893863088 Merged to trunk and cherrypicked to 3.0 to help stabilize system tests (cc @kkonstantine) -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] ableegoldman merged pull request #11183: MINOR: Increase the Kafka shutdown timeout to 120

2021-08-05 Thread GitBox
ableegoldman merged pull request #11183: URL: https://github.com/apache/kafka/pull/11183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] ableegoldman commented on pull request #11183: MINOR: Increase the Kafka shutdown timeout to 120

2021-08-05 Thread GitBox
ableegoldman commented on pull request #11183: URL: https://github.com/apache/kafka/pull/11183#issuecomment-893861008 One unrelated flaky test failure in ` kafka.api.PlaintextConsumerTest.testListTopics()` -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (KAFKA-13173) KRaft controller does not handle simultaneous broker expirations correctly

2021-08-05 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394319#comment-17394319 ] Jason Gustafson commented on KAFKA-13173: - I upgraded this bug to a blocker beca

[jira] [Updated] (KAFKA-13173) KRaft controller does not handle simultaneous broker expirations correctly

2021-08-05 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13173: Description: In `ReplicationControlManager.fenceStaleBrokers`, we find all of the current

[GitHub] [kafka] vvcephei merged pull request #11153: MINOR: Port fix to other StoreQueryIntegrationTests

2021-08-05 Thread GitBox
vvcephei merged pull request #11153: URL: https://github.com/apache/kafka/pull/11153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[jira] [Commented] (KAFKA-13172) Document in Streams 3.0 that due to rocksDB footer version in-filght downgrade is not supported

2021-08-05 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394313#comment-17394313 ] Guozhang Wang commented on KAFKA-13172: --- Yes, that's correct. > Document in Strea

[jira] [Assigned] (KAFKA-13173) KRaft controller does not handle simultaneous broker expirations correctly

2021-08-05 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel reassigned KAFKA-13173: -- Assignee: Niket Goel > KRaft controller does not handle simultaneous broker expirations corre

[jira] [Updated] (KAFKA-13173) KRaft controller does not handle simultaneous broker expirations correctly

2021-08-05 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13173: Fix Version/s: 3.0.0 > KRaft controller does not handle simultaneous broker expirations co

[jira] [Updated] (KAFKA-13173) KRaft controller does not handle simultaneous broker expirations correctly

2021-08-05 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13173: Priority: Blocker (was: Major) > KRaft controller does not handle simultaneous broker exp

[GitHub] [kafka] guozhangwang merged pull request #11151: MINOR: Should commit a task if the consumer position advanced as well

2021-08-05 Thread GitBox
guozhangwang merged pull request #11151: URL: https://github.com/apache/kafka/pull/11151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[jira] [Created] (KAFKA-13173) KRaft controller does not handle simultaneous broker expirations correctly

2021-08-05 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13173: --- Summary: KRaft controller does not handle simultaneous broker expirations correctly Key: KAFKA-13173 URL: https://issues.apache.org/jira/browse/KAFKA-13173 Proj

[GitHub] [kafka] ableegoldman merged pull request #11156: KAFKA-13046: add test coverage for AbstractStickyAssignorTest

2021-08-05 Thread GitBox
ableegoldman merged pull request #11156: URL: https://github.com/apache/kafka/pull/11156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] ableegoldman commented on a change in pull request #11156: KAFKA-13046: add test coverage for AbstractStickyAssignorTest

2021-08-05 Thread GitBox
ableegoldman commented on a change in pull request #11156: URL: https://github.com/apache/kafka/pull/11156#discussion_r683763243 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -142,12 +142,11 @@ private boolean

[jira] [Commented] (KAFKA-13172) Document in Streams 3.0 that due to rocksDB footer version in-filght downgrade is not supported

2021-08-05 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394279#comment-17394279 ] A. Sophie Blee-Goldman commented on KAFKA-13172: Just to clarify, a roll

[GitHub] [kafka] jzaralim opened a new pull request #11183: MINOR: Increase the Kafka shutdown timeout to 120

2021-08-05 Thread GitBox
jzaralim opened a new pull request #11183: URL: https://github.com/apache/kafka/pull/11183 The streams static membership test has failed several times due to hitting the Kafka shutdown timeout, but the logs were showing that the shutdown did actually succeed after the 60 second timeout.

[jira] [Created] (KAFKA-13172) Document in Streams 3.0 that due to rocksDB footer version in-filght downgrade is not supported

2021-08-05 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-13172: - Summary: Document in Streams 3.0 that due to rocksDB footer version in-filght downgrade is not supported Key: KAFKA-13172 URL: https://issues.apache.org/jira/browse/KAFKA-13172

[GitHub] [kafka] mjsax commented on pull request #11172: MINOR: update stream-stream join docs

2021-08-05 Thread GitBox
mjsax commented on pull request #11172: URL: https://github.com/apache/kafka/pull/11172#issuecomment-893689864 Merged to `trunk` and cherry-picked to `3.0` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] mjsax merged pull request #11172: MINOR: update stream-stream join docs

2021-08-05 Thread GitBox
mjsax merged pull request #11172: URL: https://github.com/apache/kafka/pull/11172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] dielhennr commented on a change in pull request #11179: KAFKA-13165: Validate node id, process role and quorum voters

2021-08-05 Thread GitBox
dielhennr commented on a change in pull request #11179: URL: https://github.com/apache/kafka/pull/11179#discussion_r683690243 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1949,6 +1951,17 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Boo

[GitHub] [kafka] hachikuji commented on a change in pull request #11171: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0 (part 2)

2021-08-05 Thread GitBox
hachikuji commented on a change in pull request #11171: URL: https://github.com/apache/kafka/pull/11171#discussion_r683680618 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -553,6 +553,17 @@ class Log(@volatile var logStartOffset: Long, /** Only used for ZK cl

[GitHub] [kafka] junrao commented on a change in pull request #11154: KAFKA-13068: Rename Log to UnifiedLog

2021-08-05 Thread GitBox
junrao commented on a change in pull request #11154: URL: https://github.com/apache/kafka/pull/11154#discussion_r683680502 ## File path: core/src/main/scala/kafka/log/UnifiedLog.scala ## @@ -1738,12 +1747,12 @@ object Log extends Logging { logDirFailureChannel: Log

[jira] [Updated] (KAFKA-12616) Convert integration tests to use ClusterTest

2021-08-05 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12616: --- Fix Version/s: 3.1.0 > Convert integration tests to use ClusterTest

[GitHub] [kafka] mumrah commented on a change in pull request #11179: KAFKA-13165: Validate node id, process role and quorum voters

2021-08-05 Thread GitBox
mumrah commented on a change in pull request #11179: URL: https://github.com/apache/kafka/pull/11179#discussion_r68365 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1949,6 +1951,17 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Boolea

[jira] [Updated] (KAFKA-13168) KRaft observers should not have a replica id

2021-08-05 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-13168: - Fix Version/s: 3.1.0 > KRaft observers should not have a replica id > --

[jira] [Resolved] (KAFKA-13168) KRaft observers should not have a replica id

2021-08-05 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-13168. -- Resolution: Fixed > KRaft observers should not have a replica id > ---

[jira] [Resolved] (KAFKA-13167) KRaft broker should heartbeat immediately during controlled shutdown

2021-08-05 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13167. - Fix Version/s: 3.0.0 Resolution: Fixed > KRaft broker should heartbeat immediatel

[GitHub] [kafka] dielhennr commented on a change in pull request #11179: KAFKA-13165: Validate node id, process role and quorum voters

2021-08-05 Thread GitBox
dielhennr commented on a change in pull request #11179: URL: https://github.com/apache/kafka/pull/11179#discussion_r683626287 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1949,6 +1951,17 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Boo

[GitHub] [kafka] kowshik commented on a change in pull request #11154: KAFKA-13068: Rename Log to UnifiedLog

2021-08-05 Thread GitBox
kowshik commented on a change in pull request #11154: URL: https://github.com/apache/kafka/pull/11154#discussion_r683616272 ## File path: core/src/main/scala/kafka/log/UnifiedLog.scala ## @@ -248,16 +250,16 @@ case object SnapshotGenerated extends LogStartOffsetIncrementReason

[GitHub] [kafka] wcarlson5 edited a comment on pull request #11153: MINOR: Port fix to other StoreQueryIntegrationTests

2021-08-05 Thread GitBox
wcarlson5 edited a comment on pull request #11153: URL: https://github.com/apache/kafka/pull/11153#issuecomment-893137087 @vvcephei looks like it is working now EDIT: nvm odd failure, I don't think that should be a failure. Trying to reproduce locally `java.lang.AssertionError

[GitHub] [kafka] wcarlson5 edited a comment on pull request #11153: MINOR: Port fix to other StoreQueryIntegrationTests

2021-08-05 Thread GitBox
wcarlson5 edited a comment on pull request #11153: URL: https://github.com/apache/kafka/pull/11153#issuecomment-893137087 @vvcephei looks like it is working now EDIT: nvm odd failure `java.lang.AssertionError: Unexpected exception thrown while getting the value from store.

[GitHub] [kafka] wcarlson5 edited a comment on pull request #11153: MINOR: Port fix to other StoreQueryIntegrationTests

2021-08-05 Thread GitBox
wcarlson5 edited a comment on pull request #11153: URL: https://github.com/apache/kafka/pull/11153#issuecomment-893137087 @vvcephei looks like it is working now EDIT: nvm odd failure -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ccding commented on a change in pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-08-05 Thread GitBox
ccding commented on a change in pull request #0: URL: https://github.com/apache/kafka/pull/0#discussion_r683573626 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java ## @@ -253,9 +253,9 @@ public RemoteLogManagerC

[GitHub] [kafka] ccding commented on a change in pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-08-05 Thread GitBox
ccding commented on a change in pull request #0: URL: https://github.com/apache/kafka/pull/0#discussion_r683573626 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java ## @@ -253,9 +253,9 @@ public RemoteLogManagerC

[GitHub] [kafka] ccding commented on a change in pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-08-05 Thread GitBox
ccding commented on a change in pull request #0: URL: https://github.com/apache/kafka/pull/0#discussion_r683573626 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java ## @@ -253,9 +253,9 @@ public RemoteLogManagerC

[GitHub] [kafka] ccding commented on a change in pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-08-05 Thread GitBox
ccding commented on a change in pull request #0: URL: https://github.com/apache/kafka/pull/0#discussion_r683573626 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java ## @@ -253,9 +253,9 @@ public RemoteLogManagerC

[GitHub] [kafka] zhaohaidao opened a new pull request #11182: KAFKA-13074: Implement mayClean for MockLog

2021-08-05 Thread GitBox
zhaohaidao opened a new pull request #11182: URL: https://github.com/apache/kafka/pull/11182 The current implement of MockLog doesn't implement maybeClean. It is expected that MockLog has the same semantic as KafkaMetadataLog. This is assumed to be true for a few of the tests suite like th

[GitHub] [kafka] mumrah commented on pull request #11178: KAFKA-13168: KRaft observers should not have a replica id

2021-08-05 Thread GitBox
mumrah commented on pull request #11178: URL: https://github.com/apache/kafka/pull/11178#issuecomment-893549648 cherry-picked to 3.0 as 765d2006a32d7a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] mumrah merged pull request #11178: KAFKA-13168: KRaft observers should not have a replica id

2021-08-05 Thread GitBox
mumrah merged pull request #11178: URL: https://github.com/apache/kafka/pull/11178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] mumrah commented on a change in pull request #11179: KAFKA-13165: Validate node id, process role and quorum voters

2021-08-05 Thread GitBox
mumrah commented on a change in pull request #11179: URL: https://github.com/apache/kafka/pull/11179#discussion_r683552057 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1949,6 +1951,17 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Boolea

[GitHub] [kafka] satishd commented on pull request #11058: KAFKA-12802 Added a file based cache for consumed remote log metadata for each partition to avoid consuming again incase of broker restarts.

2021-08-05 Thread GitBox
satishd commented on pull request #11058: URL: https://github.com/apache/kafka/pull/11058#issuecomment-893543468 @junrao: Please review this PR once https://github.com/apache/kafka/pull/11060 is reviewed and merged. -- This is an automated message from the Apache Git Service. To respond

[jira] [Closed] (KAFKA-12935) Flaky Test RestoreIntegrationTest.shouldRecycleStateFromStandbyTaskPromotedToActiveTaskAndNotRestore

2021-08-05 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson closed KAFKA-12935. -- > Flaky Test > RestoreIntegrationTest.shouldRecycleStateFromStandbyTaskPromotedToActiveTaskAndNot

[jira] [Updated] (KAFKA-13171) KIP-500 Setup and named docker volumes

2021-08-05 Thread Claudio Carcaci (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claudio Carcaci updated KAFKA-13171: Priority: Trivial (was: Major) > KIP-500 Setup and named docker volumes > ---

[jira] [Updated] (KAFKA-13171) KIP-500 Setup and named docker volumes

2021-08-05 Thread Claudio Carcaci (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claudio Carcaci updated KAFKA-13171: Priority: Major (was: Trivial) > KIP-500 Setup and named docker volumes > ---

[jira] [Created] (KAFKA-13171) KIP-500 Setup and named docker volumes

2021-08-05 Thread Claudio Carcaci (Jira)
Claudio Carcaci created KAFKA-13171: --- Summary: KIP-500 Setup and named docker volumes Key: KAFKA-13171 URL: https://issues.apache.org/jira/browse/KAFKA-13171 Project: Kafka Issue Type: Impr

[GitHub] [kafka] mimaison commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely

2021-08-05 Thread GitBox
mimaison commented on pull request #11174: URL: https://github.com/apache/kafka/pull/11174#issuecomment-893504255 Thanks for the PR, it looks good. Is it possible to add a test for it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] tombentley commented on a change in pull request #10807: KAFKA-12797: Log the evictor of fetch sessions

2021-08-05 Thread GitBox
tombentley commented on a change in pull request #10807: URL: https://github.com/apache/kafka/pull/10807#discussion_r683481734 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -692,6 +692,7 @@ class KafkaApis(val requestChannel: RequestChannel, fetchR

[GitHub] [kafka] mimaison commented on a change in pull request #10277: KAFKA-9914: Fix replication cycle detection

2021-08-05 Thread GitBox
mimaison commented on a change in pull request #10277: URL: https://github.com/apache/kafka/pull/10277#discussion_r683463480 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java ## @@ -489,7 +489,17 @@ boolean isCycle(String top

[jira] [Assigned] (KAFKA-5966) Support ByteBuffer serialization in Kafka Streams

2021-08-05 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-5966: Assignee: Luke Chen > Support ByteBuffer serialization in Kafka Streams >

[GitHub] [kafka] ijuma commented on pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-08-05 Thread GitBox
ijuma commented on pull request #0: URL: https://github.com/apache/kafka/pull/0#issuecomment-893407158 Thanks for explaining the motivation @ccding. In my opinion, this is a bit confusing. What makes remote log configs special when compared to local log configs? The same arguments

[GitHub] [kafka] mimaison commented on a change in pull request #10807: KAFKA-12797: Log the evictor of fetch sessions

2021-08-05 Thread GitBox
mimaison commented on a change in pull request #10807: URL: https://github.com/apache/kafka/pull/10807#discussion_r683367337 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -692,6 +692,7 @@ class KafkaApis(val requestChannel: RequestChannel, fetchReq

[GitHub] [kafka] satishd commented on a change in pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-08-05 Thread GitBox
satishd commented on a change in pull request #0: URL: https://github.com/apache/kafka/pull/0#discussion_r683370891 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java ## @@ -253,9 +253,9 @@ public RemoteLogManager

[GitHub] [kafka] junrao commented on a change in pull request #11154: KAFKA-13068: Rename Log to UnifiedLog

2021-08-05 Thread GitBox
junrao commented on a change in pull request #11154: URL: https://github.com/apache/kafka/pull/11154#discussion_r682801773 ## File path: core/src/main/scala/kafka/log/UnifiedLog.scala ## @@ -248,16 +250,16 @@ case object SnapshotGenerated extends LogStartOffsetIncrementReason

[GitHub] [kafka] joel-hamill commented on pull request #11163: MINOR: doc change for minisr to clarify replicas in Kafka Config

2021-08-05 Thread GitBox
joel-hamill commented on pull request #11163: URL: https://github.com/apache/kafka/pull/11163#issuecomment-892895687 LGTM, had one comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [kafka] ableegoldman commented on pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-05 Thread GitBox
ableegoldman commented on pull request #10788: URL: https://github.com/apache/kafka/pull/10788#issuecomment-893124886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [kafka] mumrah merged pull request #11166: KAFKA-13159 Enable additional transaction system tests in KRaft

2021-08-05 Thread GitBox
mumrah merged pull request #11166: URL: https://github.com/apache/kafka/pull/11166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] axrj commented on pull request #8906: KAFKA-10190: To set replication throttling configs at broker entity-default

2021-08-05 Thread GitBox
axrj commented on pull request #8906: URL: https://github.com/apache/kafka/pull/8906#issuecomment-892663172 Hey, Is there any plan to merge this? It would be great to have this patch backported too if possible. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] cmccabe merged pull request #11130: KAFKA-13138: FileConfigProvider#get should keep failure exception

2021-08-05 Thread GitBox
cmccabe merged pull request #11130: URL: https://github.com/apache/kafka/pull/11130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] cmccabe merged pull request #11168: KAFKA-13160: Fix BrokerMetadataPublisher to pass the correct resource name to the config handler when processing config updates

2021-08-05 Thread GitBox
cmccabe merged pull request #11168: URL: https://github.com/apache/kafka/pull/11168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] ijuma merged pull request #11150: MINOR: Fix missing word in LogLoader logged warning

2021-08-05 Thread GitBox
ijuma merged pull request #11150: URL: https://github.com/apache/kafka/pull/11150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] vvcephei commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-08-05 Thread GitBox
vvcephei commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r682637061 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -25,15 +25,17 @@ from kafkatest.services.zookeeper import ZookeeperService fr

[GitHub] [kafka] hachikuji merged pull request #11177: KAFKA-13167; KRaft broker should send heartbeat immediately after starting controlled shutdown

2021-08-05 Thread GitBox
hachikuji merged pull request #11177: URL: https://github.com/apache/kafka/pull/11177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] rondagostino commented on a change in pull request #11175: MINOR: Fix getting started documentation

2021-08-05 Thread GitBox
rondagostino commented on a change in pull request #11175: URL: https://github.com/apache/kafka/pull/11175#discussion_r682834005 ## File path: config/kraft/README.md ## @@ -14,8 +14,9 @@ Most important of all, KRaft mode is more scalable. We expect to be able to [su # Quicks

[GitHub] [kafka] cmccabe commented on a change in pull request #11168: KAFKA-13160: Fix BrokerMetadataPublisher to pass the correct resource name to the config handler when processing config updates

2021-08-05 Thread GitBox
cmccabe commented on a change in pull request #11168: URL: https://github.com/apache/kafka/pull/11168#discussion_r682803659 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala ## @@ -203,7 +203,15 @@ class BrokerMetadataPublisher(conf: KafkaCo

[GitHub] [kafka] hachikuji commented on a change in pull request #11171: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0 (part 2)

2021-08-05 Thread GitBox
hachikuji commented on a change in pull request #11171: URL: https://github.com/apache/kafka/pull/11171#discussion_r683019148 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -553,6 +553,14 @@ class Log(@volatile var logStartOffset: Long, /** Only used for ZK cl

[GitHub] [kafka] kowshik commented on a change in pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-08-05 Thread GitBox
kowshik commented on a change in pull request #0: URL: https://github.com/apache/kafka/pull/0#discussion_r683184053 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java ## @@ -253,9 +253,9 @@ public RemoteLogManager

[GitHub] [kafka] mumrah edited a comment on pull request #11166: KAFKA-13159 Enable additional transaction system tests in KRaft

2021-08-05 Thread GitBox
mumrah edited a comment on pull request #11166: URL: https://github.com/apache/kafka/pull/11166#issuecomment-892067696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [kafka] dielhennr closed pull request #11159: MINOR: Change default node id in kraft broker properties

2021-08-05 Thread GitBox
dielhennr closed pull request #11159: URL: https://github.com/apache/kafka/pull/11159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] ccding commented on a change in pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-08-05 Thread GitBox
ccding commented on a change in pull request #0: URL: https://github.com/apache/kafka/pull/0#discussion_r683068699 ## File path: core/src/main/scala/kafka/log/LogConfig.scala ## @@ -107,46 +107,52 @@ case class LogConfig(props: java.util.Map[_, _], overriddenConfigs: S

[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes

2021-08-05 Thread GitBox
jlprat commented on pull request #10784: URL: https://github.com/apache/kafka/pull/10784#issuecomment-892521275 Pinging @vvcephei Would you be able to merger this before more commits get in the way and we need another rebase? Thanks a ton! -- This is an automated message from the A

[GitHub] [kafka] mumrah commented on pull request #11166: KAFKA-13159 Enable additional transaction system tests in KRaft

2021-08-05 Thread GitBox
mumrah commented on pull request #11166: URL: https://github.com/apache/kafka/pull/11166#issuecomment-892891735 Spoke with @vvcephei about the streams smoke test and it is a known flaky. We are good-to-go with enabling KRaft for this test. -- This is an automated message from the Apache

[GitHub] [kafka] junrao commented on a change in pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-08-05 Thread GitBox
junrao commented on a change in pull request #0: URL: https://github.com/apache/kafka/pull/0#discussion_r682820398 ## File path: core/src/main/scala/kafka/log/LogConfig.scala ## @@ -107,46 +107,52 @@ case class LogConfig(props: java.util.Map[_, _], overriddenConfigs: S

[GitHub] [kafka] jolshan commented on pull request #11171: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0 (part 2)

2021-08-05 Thread GitBox
jolshan commented on pull request #11171: URL: https://github.com/apache/kafka/pull/11171#issuecomment-893066311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

  1   2   >