Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1455667030
Took a look at the authorizer tests (`AuthorizerIntegrationTests`). It seems
that authorization with topic and group `READ` permissions and unknown topic
name is not currently being tes
[
https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
fujian updated KAFKA-14768:
---
Description:
Hi, Team:
Nice to meet you!
In our business, we found two types of issue which need to
satishd commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1125990307
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
[
https://issues.apache.org/jira/browse/KAFKA-14764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696779#comment-17696779
]
Alexandre Dupriez commented on KAFKA-14764:
---
One problem currently is that top
jiafu1115 commented on PR #13320:
URL: https://github.com/apache/kafka/pull/13320#issuecomment-1455730126
@divijvaidya KIP
https://cwiki.apache.org/confluence/display/KAFKA/KIP-913%3A+add+new+method+to+provide+possibility+for+accelerate+first+record%27s+sending
created.
thanks
--
This
[
https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696794#comment-17696794
]
fujian commented on KAFKA-14768:
Hi [~showuon]:
I summary the two issues/solutions and
Vinoth Rengarajan created KAFKA-14778:
-
Summary: Kafka Streams 2.7.1 to 3.3.1 rolling upgrade with static
membership triggers a rebalance
Key: KAFKA-14778
URL: https://issues.apache.org/jira/browse/KAFKA-14778
rajinisivaram opened a new pull request, #13346:
URL: https://github.com/apache/kafka/pull/13346
To avoid mistakes during dynamic broker config updates that could
potentially affect clients, we restrict changes that can be performed
dynamically without broker restart. For broker keystore up
lucasbru opened a new pull request, #13347:
URL: https://github.com/apache/kafka/pull/13347
Commit 32b1c23 disabled strict stubbing for the
`RocksDBMetricsRecorderTest`.
To re-enable the behavior in JUnit-5, we need to pull in a new dependency in
the
`streams` Gradle project.
lucasbru commented on code in PR #13336:
URL: https://github.com/apache/kafka/pull/13336#discussion_r1126203147
##
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java:
##
@@ -52,7 +52,6 @@
import static org.mockito.Mockito.veri
lucasbru commented on PR #13347:
URL: https://github.com/apache/kafka/pull/13347#issuecomment-1455858009
@guozhangwang Could you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
Alexandre Dupriez created KAFKA-14779:
-
Summary: Add ACL Authorizer integration test for authorized
OffsetCommits with an unknown topic
Key: KAFKA-14779
URL: https://issues.apache.org/jira/browse/KAFKA-14779
[
https://issues.apache.org/jira/browse/KAFKA-14779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez reassigned KAFKA-14779:
-
Assignee: Alexandre Dupriez
> Add ACL Authorizer integration test for authorize
Alexandre Dupriez created KAFKA-14780:
-
Summary: Make
RefreshingHttpsJwksTest#testSecondaryRefreshAfterElapsedDelay deterministic
Key: KAFKA-14780
URL: https://issues.apache.org/jira/browse/KAFKA-14780
[
https://issues.apache.org/jira/browse/KAFKA-14780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696882#comment-17696882
]
Alexandre Dupriez commented on KAFKA-14780:
---
[~kirktrue], would you agree with
[
https://issues.apache.org/jira/browse/KAFKA-14780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez updated KAFKA-14780:
--
Description:
The test {{RefreshingHttpsJwksTest#testSecondaryRefreshAfterElapsedDelay}
[
https://issues.apache.org/jira/browse/KAFKA-14780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez updated KAFKA-14780:
--
Issue Type: Improvement (was: Test)
> Make RefreshingHttpsJwksTest#testSecondaryRefre
[
https://issues.apache.org/jira/browse/KAFKA-14780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez updated KAFKA-14780:
--
Description:
The test {{RefreshingHttpsJwksTest#testSecondaryRefreshAfterElapsedDelay}
[
https://issues.apache.org/jira/browse/KAFKA-14780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez reassigned KAFKA-14780:
-
Assignee: Alexandre Dupriez
> Make RefreshingHttpsJwksTest#testSecondaryRefresh
urbandan commented on PR #10566:
URL: https://github.com/apache/kafka/pull/10566#issuecomment-1456046804
@C0urante sorry for the mixup in the exaple code, I did miss those setter
calls.
Thank you for the info and the code, I will check your solution. This
problem does sound like somethin
[
https://issues.apache.org/jira/browse/KAFKA-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696923#comment-17696923
]
Sagar Rao commented on KAFKA-14091:
---
hi [~ChrisEgerton] , I started working on this. H
[
https://issues.apache.org/jira/browse/KAFKA-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696923#comment-17696923
]
Sagar Rao edited comment on KAFKA-14091 at 3/6/23 12:40 PM:
hudeqi opened a new pull request, #13348:
URL: https://github.com/apache/kafka/pull/13348
When using ProducerPerformance, I found that when the sending fails, it is
still counted as successfully sent by stat and the metrics are printed. For
example, when there is no write permission and can
Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1126511918
##
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java:
##
@@ -167,8 +213,24 @@ public Builder addPartitions(
}
publ
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1126570518
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1126571253
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -497,51 +501,59 @@ object RequestMetrics {
val ErrorsPerSec = "ErrorsPerSec"
}
-class RequestMetri
[
https://issues.apache.org/jira/browse/KAFKA-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696923#comment-17696923
]
Sagar Rao edited comment on KAFKA-14091 at 3/6/23 3:36 PM:
---
hi
vamossagar12 commented on PR #13127:
URL: https://github.com/apache/kafka/pull/13127#issuecomment-1456365306
@cadonna , bumping this one again :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Chris Egerton created KAFKA-14781:
-
Summary: MM2 logs misleading error during topic ACL sync when
broker does not have authorizer configured
Key: KAFKA-14781
URL: https://issues.apache.org/jira/browse/KAFKA-14781
jangho kwon created KAFKA-14782:
---
Summary: Implementation Details Different from Documentation
(delivery.timeout.ms)
Key: KAFKA-14782
URL: https://issues.apache.org/jira/browse/KAFKA-14782
Project: Kafk
[
https://issues.apache.org/jira/browse/KAFKA-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jangho kwon updated KAFKA-14782:
Description:
Hello,
I was checking the value related to {{{}delivery.timeout.ms{}}}, and I found
rajinisivaram opened a new pull request, #13349:
URL: https://github.com/apache/kafka/pull/13349
This PR refactors AbstractStickyAssignor without changing any logic to make
it easier to add rack-awareness. The class currently consists of a lot of
collections that are passed around various m
[
https://issues.apache.org/jira/browse/KAFKA-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-14781:
-
Assignee: Chris Egerton
> MM2 logs misleading error during topic ACL sync when broker d
rajinisivaram opened a new pull request, #13350:
URL: https://github.com/apache/kafka/pull/13350
Best-effort rack alignment for sticky assignors when both consumer racks and
partition racks are available with the protocol changes introduced in KIP-881.
Rack-aware assignment is enabled by co
mimaison merged PR #13215:
URL: https://github.com/apache/kafka/pull/13215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mimaison merged PR #13212:
URL: https://github.com/apache/kafka/pull/13212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
C0urante opened a new pull request, #13351:
URL: https://github.com/apache/kafka/pull/13351
[Jira](https://issues.apache.org/jira/browse/KAFKA-14781)
Instead of logging an `ERROR`-level message when topic syncing is enabled
(which it is by default) and no ACL authorizer is configured
C0urante commented on PR #13351:
URL: https://github.com/apache/kafka/pull/13351#issuecomment-1456617781
@mimaison would you mind taking a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697070#comment-17697070
]
ASF GitHub Bot commented on KAFKA-13882:
mimaison commented on PR #410:
URL: htt
mimaison commented on PR #13157:
URL: https://github.com/apache/kafka/pull/13157#issuecomment-1456709095
Sorry for the delay. I _think_ you technically don't necessarily need to
have transitive dependencies in the classpath to compile a class. For example,
it is possible to build a custom `
rondagostino commented on code in PR #13331:
URL: https://github.com/apache/kafka/pull/13331#discussion_r1126859142
##
core/src/main/scala/kafka/server/SharedServer.scala:
##
@@ -170,6 +170,17 @@ class SharedServer(
snapshotsDiabledReason.compareAndSet(null, "metadata loa
Hangleton opened a new pull request, #13352:
URL: https://github.com/apache/kafka/pull/13352
WIP.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697103#comment-17697103
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on PR #410:
URL: ht
jolshan commented on code in PR #13329:
URL: https://github.com/apache/kafka/pull/13329#discussion_r1126919357
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -62,6 +63,15 @@ private[group] class GroupCoordinatorAdapter(
private val time: T
dajac commented on code in PR #13329:
URL: https://github.com/apache/kafka/pull/13329#discussion_r1126920827
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3573,9 +3573,27 @@ class KafkaApis(val requestChannel: RequestChannel,
def handleConsumerGroupHeartbeat(r
jolshan commented on code in PR #13329:
URL: https://github.com/apache/kafka/pull/13329#discussion_r1126921525
##
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##
@@ -54,6 +54,20 @@ class ConsumerGroupHeartbeatRequestTest(cluster:
ClusterInstanc
dajac commented on code in PR #13329:
URL: https://github.com/apache/kafka/pull/13329#discussion_r1126922151
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -62,6 +63,15 @@ private[group] class GroupCoordinatorAdapter(
private val time: Tim
cmccabe merged PR #13331:
URL: https://github.com/apache/kafka/pull/13331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan commented on code in PR #13329:
URL: https://github.com/apache/kafka/pull/13329#discussion_r1126927374
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -62,6 +63,15 @@ private[group] class GroupCoordinatorAdapter(
private val time: T
jolshan commented on PR #13352:
URL: https://github.com/apache/kafka/pull/13352#issuecomment-1456837604
Let me know if you have any topic ID questions @Hangleton
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jolshan commented on code in PR #13323:
URL: https://github.com/apache/kafka/pull/13323#discussion_r1126944890
##
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java:
##
@@ -337,8 +362,27 @@ public AbstractResponse getErrorResponse(int
throttleTimeMs, Throw
rajinisivaram commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1126983650
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -83,12 +92,23 @@
private final Metrics metrics;
philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1127043244
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -226,11 +246,20 @@ public void commitAsync(OffsetCommitCallbac
philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1127046532
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -83,12 +92,23 @@
private final Metrics metrics;
priv
philipnee commented on PR #13303:
URL: https://github.com/apache/kafka/pull/13303#issuecomment-1457022169
Thanks for reviewing this, @rajinisivaram - fixes are on the way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
philipnee opened a new pull request, #13353:
URL: https://github.com/apache/kafka/pull/13353
The changes include:
1. Documentation changes
2. Closing mechanism
3. Adding a rebalance listener (to print partition changes when rebalance is
happening)
4. Fixing a few errors
cc @sh
philipnee commented on PR #13353:
URL: https://github.com/apache/kafka/pull/13353#issuecomment-1457033568
This is the snippet of the log:
```
Subscribe to:topic1
...
Assigning partitions:[topic1-0]
...
DemoConsumer finished reading 1 messages
Revoking partitions:[topi
philipnee opened a new pull request, #13354:
URL: https://github.com/apache/kafka/pull/13354
The current kafka producer example needs a bit of improvement, in particular:
1. documentation is lacking
2. it is not closing correctly
3. Code can be cleaner
--
This is an automated mess
[
https://issues.apache.org/jira/browse/KAFKA-14368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14368:
--
Parent: KAFKA-4107
Issue Type: Sub-task (was: New Feature)
> Add an offset write REST
[
https://issues.apache.org/jira/browse/KAFKA-14783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14783:
--
Parent: KAFKA-4107
Issue Type: Sub-task (was: Task)
> Implement new STOPPED state for
Chris Egerton created KAFKA-14783:
-
Summary: Implement new STOPPED state for connectors
Key: KAFKA-14783
URL: https://issues.apache.org/jira/browse/KAFKA-14783
Project: Kafka
Issue Type: Task
[
https://issues.apache.org/jira/browse/KAFKA-14368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14368:
--
Description: Implement the {{PATCH /connectors/name/offsets}} endpoint
[described in
KIP-875|
[
https://issues.apache.org/jira/browse/KAFKA-14368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14368:
--
Labels: (was: kip-required)
> Add an offset write REST API to Kafka Connect
> --
[
https://issues.apache.org/jira/browse/KAFKA-14368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697157#comment-17697157
]
Chris Egerton commented on KAFKA-14368:
---
[~yash.mayya] Given the updates to KIP-87
[
https://issues.apache.org/jira/browse/KAFKA-14368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14368:
--
Summary: Implement connector offset write REST API (was: Add an offset
write REST API to Kafk
[
https://issues.apache.org/jira/browse/KAFKA-14368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14368:
--
Component/s: KafkaConnect
> Implement connector offset write REST API
> --
Chris Egerton created KAFKA-14785:
-
Summary: Implement connector offset read REST API
Key: KAFKA-14785
URL: https://issues.apache.org/jira/browse/KAFKA-14785
Project: Kafka
Issue Type: Sub-ta
Chris Egerton created KAFKA-14784:
-
Summary: Implement connector offset reset REST API
Key: KAFKA-14784
URL: https://issues.apache.org/jira/browse/KAFKA-14784
Project: Kafka
Issue Type: Sub-t
Chris Egerton created KAFKA-14786:
-
Summary: Implement connector offset write/reset internal logic
Key: KAFKA-14786
URL: https://issues.apache.org/jira/browse/KAFKA-14786
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697160#comment-17697160
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on PR #410:
URL: ht
jsancio commented on PR #13102:
URL: https://github.com/apache/kafka/pull/13102#issuecomment-1457138403
I was thinking about this change today and realized that this change is not
backwards compatible. For example, the user upgrades the cluster and then they
downgrade the cluster, it will s
jsancio opened a new pull request, #13355:
URL: https://github.com/apache/kafka/pull/13355
This reverts commit 0927049a617fa2937a211aab895f6590403130fb.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and C
jsancio commented on PR #13355:
URL: https://github.com/apache/kafka/pull/13355#issuecomment-1457165155
This PR reverts https://github.com/apache/kafka/pull/13102
Reason for the revert is documented here:
https://github.com/apache/kafka/pull/13102#issuecomment-1457138403
--
This is
[
https://issues.apache.org/jira/browse/KAFKA-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14371:
---
Labels: needs-kip (was: )
> quorum-state file contains empty/unused
[
https://issues.apache.org/jira/browse/KAFKA-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697165#comment-17697165
]
José Armando García Sancio commented on KAFKA-14371:
Even though the
[
https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697167#comment-17697167
]
Guozhang Wang commented on KAFKA-14748:
---
Cool! We are on the same page for the fir
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697175#comment-17697175
]
ASF GitHub Bot commented on KAFKA-13882:
mjsax commented on PR #410:
URL: https:
[
https://issues.apache.org/jira/browse/KAFKA-12446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12446:
Labels: kip (was: )
> Define KGroupedTable#aggregate subtractor + adder order of executio
[
https://issues.apache.org/jira/browse/KAFKA-12446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12446:
Description:
KIP-904:
[https://cwiki.apache.org/confluence/display/KAFKA/KIP-904%3A+Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14722:
Labels: beginner kip newbie (was: beginner need-kip newbie)
> Make BooleanSerde public
>
[
https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14722:
Description:
KIP-907:
[https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+B
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127176224
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -730,6 +744,45 @@ class DynamicThreadPool(server: KafkaBroker) extends
BrokerReconfigurable {
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127176972
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -911,7 +954,22 @@ object DynamicListenerConfig {
)
}
-class DynamicClientQuotaCallback(server
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127179616
##
core/src/test/java/kafka/test/MockController.java:
##
@@ -181,10 +194,16 @@ public CompletableFuture unregisterBroker(
static class MockTopic {
private
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127176972
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -911,7 +954,22 @@ object DynamicListenerConfig {
)
}
-class DynamicClientQuotaCallback(server
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127176224
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -730,6 +744,45 @@ class DynamicThreadPool(server: KafkaBroker) extends
BrokerReconfigurable {
[
https://issues.apache.org/jira/browse/KAFKA-14778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697181#comment-17697181
]
Matthias J. Sax commented on KAFKA-14778:
-
Thanks for reporting this. – I believ
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127182652
##
core/src/main/scala/kafka/server/metadata/DynamicClientQuotaPublisher.scala:
##
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127186242
##
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##
@@ -479,6 +489,42 @@ class DynamicBrokerConfigTest {
assertEquals("User:admin", authoriz
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127186242
##
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##
@@ -479,6 +489,42 @@ class DynamicBrokerConfigTest {
assertEquals("User:admin", authoriz
guozhangwang commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1127185285
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##
@@ -213,7 +215,7 @@ public UnsentRequest(
Objects.
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127191300
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -378,6 +378,118 @@ object TestUtils extends Logging {
props
}
+ def createCombinedControllerCo
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127191300
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -378,6 +378,118 @@ object TestUtils extends Logging {
props
}
+ def createCombinedControllerCo
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127191979
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -378,6 +378,118 @@ object TestUtils extends Logging {
props
}
+ def createCombinedControllerCo
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127197623
##
metadata/src/main/java/org/apache/kafka/controller/ControllerRequestContext.java:
##
@@ -42,19 +45,39 @@ public static OptionalLong requestTimeoutMsToDeadlineNs(
kirktrue commented on code in PR #12813:
URL: https://github.com/apache/kafka/pull/12813#discussion_r1127204081
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
@@ -324,11 +324,14 @@ public void disconnect(String nodeId) {
log.info("Client reques
cmccabe commented on PR #13116:
URL: https://github.com/apache/kafka/pull/13116#issuecomment-1457277048
Thanks for the PR, @rondagostino . You've been very patient here and I'm
sorry that the review wasn't quicker. We did a major pivot from implementing
the quota in `ControllerApis` like I
cmccabe commented on code in PR #13355:
URL: https://github.com/apache/kafka/pull/13355#discussion_r1127208396
##
raft/src/main/resources/common/message/QuorumStateData.json:
##
@@ -16,10 +16,10 @@
{
"type": "data",
"name": "QuorumStateData",
- // Version 1 removes clust
cmccabe commented on code in PR #13355:
URL: https://github.com/apache/kafka/pull/13355#discussion_r1127208396
##
raft/src/main/resources/common/message/QuorumStateData.json:
##
@@ -16,10 +16,10 @@
{
"type": "data",
"name": "QuorumStateData",
- // Version 1 removes clust
ijuma commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127213105
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -378,6 +378,118 @@ object TestUtils extends Logging {
props
}
+ def createCombinedControllerConf
1 - 100 of 131 matches
Mail list logo
