showuon merged PR #13779:
URL: https://github.com/apache/kafka/pull/13779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon merged PR #13775:
URL: https://github.com/apache/kafka/pull/13775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1217619263
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1217620168
##
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java:
##
@@ -131,6 +131,7 @@ public Map errorCounts() {
public static final class Partition
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1217632767
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -666,7 +667,8 @@ class ReplicaManager(val config: KafkaConfig,
recordConversionStatsC
urbandan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1217640626
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -609,14 +686,15 @@ public synchronized void
handleCompletedBatch(P
urbandan commented on PR #13796:
URL: https://github.com/apache/kafka/pull/13796#issuecomment-1576211511
> > Instead, the producer should wait for the preceding, retried batches to
complete before resetting the sequence number. This ensures that the sequence
numbers can only get reset after
dajac commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1217658117
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -0,0 +1,959 @@
+/*
+ * Licensed to the Apache Software Founda
dajac commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1217658963
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -0,0 +1,959 @@
+/*
+ * Licensed to the Apache Software Founda
dajac commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1217659281
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -0,0 +1,959 @@
+/*
+ * Licensed to the Apache Software Founda
dajac commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1217663057
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -0,0 +1,959 @@
+/*
+ * Licensed to the Apache Software Founda
Nayana-ibm commented on PR #11899:
URL: https://github.com/apache/kafka/pull/11899#issuecomment-1576250936
Keeping this PR open for any new updates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
dajac commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1217666174
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -0,0 +1,959 @@
+/*
+ * Licensed to the Apache Software Founda
dajac commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1217668324
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -0,0 +1,959 @@
+/*
+ * Licensed to the Apache Software Founda
Jeff created KAFKA-15056:
Summary: Kafka producer still fails with
ClusterAuthorizationException after permission granted
Key: KAFKA-15056
URL: https://issues.apache.org/jira/browse/KAFKA-15056
Project: Kafka
cadonna commented on PR #13711:
URL: https://github.com/apache/kafka/pull/13711#issuecomment-1576388176
@clolov Could you please do the mentioned rebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cadonna commented on PR #13711:
URL: https://github.com/apache/kafka/pull/13711#issuecomment-1576391236
Could you also please add some more info to the PR description instead of
only referencing other PRs. One or two sentences followed by the references is
totally fine.
--
This is an aut
cadonna commented on code in PR #13711:
URL: https://github.com/apache/kafka/pull/13711#discussion_r1217778982
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1854,6 +1855,8 @@ public void
shouldCloseActiveUnassignedSuspendedTa
[
https://issues.apache.org/jira/browse/KAFKA-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729263#comment-17729263
]
Divij Vaidya commented on KAFKA-14632:
--
Fixed as part of https://issues.apache.org/
showuon opened a new pull request, #13807:
URL: https://github.com/apache/kafka/pull/13807
When received LeaderAndIsr request, we'll notify remoteLogManager about this
leadership changed to trigger the following workflow. But LeaderAndIsr won't be
sent in KRaft mode, instead, the topicDelta
showuon commented on PR #13807:
URL: https://github.com/apache/kafka/pull/13807#issuecomment-1576529899
@satishd , call for review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
Divij Vaidya created KAFKA-15057:
Summary: Use new interface
ZstdBufferDecompressingStreamNoFinalizer from zstd-jni
Key: KAFKA-15057
URL: https://issues.apache.org/jira/browse/KAFKA-15057
Project: Kaf
[
https://issues.apache.org/jira/browse/KAFKA-15057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15057:
-
Description:
h1. Background
In Kafka's code, every batch of records is stored in a in-memory by
satishd commented on PR #13561:
URL: https://github.com/apache/kafka/pull/13561#issuecomment-1576564925
Pulled the latest trunk, resolved the conflicts, and pushed the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
yashmayya opened a new pull request, #13808:
URL: https://github.com/apache/kafka/pull/13808
- The `TransformationChain` Javadoc has a reference to the `Transformation`
class
- The import was removed (likely accidentally) in
https://github.com/apache/kafka/pull/13184/files#diff-be87d8114
dajac merged PR #13680:
URL: https://github.com/apache/kafka/pull/13680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
urbandan commented on code in PR #13433:
URL: https://github.com/apache/kafka/pull/13433#discussion_r1217952882
##
connect/api/src/test/java/org/apache/kafka/connect/data/SchemaBuilderTest.java:
##
@@ -36,6 +38,255 @@ public class SchemaBuilderTest {
private static final St
singhnama opened a new pull request, #13809:
URL: https://github.com/apache/kafka/pull/13809
AclAuthorizer#acls returns Set[AclBinding], so returned ACLs don't preserve
order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
yashmayya opened a new pull request, #13810:
URL: https://github.com/apache/kafka/pull/13810
- The `KafkaBasedLog` abstraction is used by Kafka Connect's three metadata
topics - offsets, configs, and statuses.
- This generic `KafkaBasedLog` was split off from the
`KafkaOffsetBackingStore
tamama commented on PR #12447:
URL: https://github.com/apache/kafka/pull/12447#issuecomment-1576691582
Hi @showuon , any chance of Kafka-3.5.0 release any time near?
Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
[
https://issues.apache.org/jira/browse/KAFKA-15053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729323#comment-17729323
]
Chris Egerton commented on KAFKA-15053:
---
Thanks [~dlgaobo]. I agree that this is a
[
https://issues.apache.org/jira/browse/KAFKA-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-15051:
-
Assignee: Jorge Esteban Quilcate Otoya
> docs: add missing connector plugin endpoint to
C0urante commented on code in PR #13803:
URL: https://github.com/apache/kafka/pull/13803#discussion_r1218083798
##
docs/connect.html:
##
@@ -320,6 +320,7 @@ REST
API
GET /connector-plugins- return a list of connector
plugins installed in the Kafka Connect clus
jsancio commented on code in PR #13765:
URL: https://github.com/apache/kafka/pull/13765#discussion_r1218084219
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1091,8 +1091,10 @@ class Partition(val topicPartition: TopicPartition,
// Note here we are using the
jsancio commented on code in PR #13765:
URL: https://github.com/apache/kafka/pull/13765#discussion_r1218084219
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1091,8 +1091,10 @@ class Partition(val topicPartition: TopicPartition,
// Note here we are using the
jsancio commented on code in PR #13765:
URL: https://github.com/apache/kafka/pull/13765#discussion_r1218088303
##
core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala:
##
@@ -357,6 +363,51 @@ abstract class BaseProducerSendTest extends
KafkaServerTestHarness {
C0urante merged PR #13808:
URL: https://github.com/apache/kafka/pull/13808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
jsancio commented on code in PR #13765:
URL: https://github.com/apache/kafka/pull/13765#discussion_r1218098813
##
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##
@@ -260,11 +265,17 @@ private void tryElection(PartitionChangeRecord record) {
jsancio commented on code in PR #13765:
URL: https://github.com/apache/kafka/pull/13765#discussion_r1218084219
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1091,8 +1091,10 @@ class Partition(val topicPartition: TopicPartition,
// Note here we are using the
jsancio commented on code in PR #13765:
URL: https://github.com/apache/kafka/pull/13765#discussion_r1218103438
##
core/src/test/scala/unit/kafka/cluster/PartitionTest.scala:
##
@@ -1456,6 +1456,105 @@ class PartitionTest extends AbstractPartitionTest {
assertEquals(alterPar
yashmayya commented on PR #13808:
URL: https://github.com/apache/kafka/pull/13808#issuecomment-1576846060
Thanks Chris! Yeah, the Jenkins thing is odd - no build has been triggered
for this merged commit on `trunk` either. Do we need to raise an [Apache INFRA
Jira](https://issues.apache.org
lucasbru opened a new pull request, #13811:
URL: https://github.com/apache/kafka/pull/13811
This PR fixes three issues:
* `InvalidProducerEpochException` was not handled consistently.
`InvalidProducerEpochException` used to be able to be return via both
transactional response and pro
C0urante commented on PR #13810:
URL: https://github.com/apache/kafka/pull/13810#issuecomment-1576871102
Similar to
https://github.com/apache/kafka/pull/13808#issuecomment-1576833452, I've
verified locally that this builds correctly and, given the extremely limited
scope of the change, fee
C0urante merged PR #13810:
URL: https://github.com/apache/kafka/pull/13810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
C0urante commented on code in PR #13806:
URL: https://github.com/apache/kafka/pull/13806#discussion_r1218133111
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -2212,6 +2212,13 @@ DistributedHerderRequest addRequest(Cal
clolov commented on PR #13711:
URL: https://github.com/apache/kafka/pull/13711#issuecomment-1576886607
Yup, I will address all comments today, thank you for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
C0urante commented on PR #13806:
URL: https://github.com/apache/kafka/pull/13806#issuecomment-1576887637
@mimaison @showuon would appreciate a review if you have time, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
C0urante commented on PR #13771:
URL: https://github.com/apache/kafka/pull/13771#issuecomment-1576891229
@gharris1727 there are test failures in the latest CI run. Can you look into
those? Feel free to just rebase on the latest trunk if that's all that's
required.
--
This is an automated
mumrah commented on PR #12447:
URL: https://github.com/apache/kafka/pull/12447#issuecomment-1576895941
@tamama you can subscribe to the kafka-users mailing list for updates on
releases. https://kafka.apache.org/contact
--
This is an automated message from the Apache Git Service.
T
dajac opened a new pull request, #13812:
URL: https://github.com/apache/kafka/pull/13812
This patch includes https://github.com/apache/kafka/pull/13795 for now.
This patch introduces the GroupCoordinatorService. This is the new
implementation of the group coordinator based on the coor
clolov commented on code in PR #13711:
URL: https://github.com/apache/kafka/pull/13711#discussion_r1218169011
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1740,13 +1740,14 @@ public void
shouldComputeOffsetSumFromCheckpointF
[
https://issues.apache.org/jira/browse/KAFKA-13756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Urban reassigned KAFKA-13756:
Assignee: Daniel Urban
> Connect validate endpoint should return proper response for inva
urbandan opened a new pull request, #13813:
URL: https://github.com/apache/kafka/pull/13813
…n response when the connector.class is missing or invalid
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a
clolov commented on code in PR #13711:
URL: https://github.com/apache/kafka/pull/13711#discussion_r1218178041
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1740,13 +1740,14 @@ public void
shouldComputeOffsetSumFromCheckpointF
vamossagar12 commented on code in PR #13726:
URL: https://github.com/apache/kafka/pull/13726#discussion_r1218188816
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java:
##
@@ -458,13 +458,8 @@ boolean sendRecords() {
}
prot
vamossagar12 commented on code in PR #13726:
URL: https://github.com/apache/kafka/pull/13726#discussion_r1218190316
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java:
##
@@ -458,13 +458,8 @@ boolean sendRecords() {
}
prot
mimaison commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1576955162
Thanks @clolov for the PR. I think some system tests do upgrades from
previous versions to the latest. Have you checked these system tests still work
with this change?
--
This is an a
C0urante commented on PR #13530:
URL: https://github.com/apache/kafka/pull/13530#issuecomment-1576963027
Hmm... I think the significant divergence in behavior between the two modes
is whether we retry or not. Modifying the status parts of the REST API seems
less like introducing further div
vamossagar12 commented on code in PR #13726:
URL: https://github.com/apache/kafka/pull/13726#discussion_r1218190316
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java:
##
@@ -458,13 +458,8 @@ boolean sendRecords() {
}
prot
C0urante commented on code in PR #13750:
URL: https://github.com/apache/kafka/pull/13750#discussion_r1218206159
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1104,7 +1104,9 @@ public void stopConnector(final String c
C0urante commented on code in PR #13750:
URL: https://github.com/apache/kafka/pull/13750#discussion_r1218206159
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1104,7 +1104,9 @@ public void stopConnector(final String c
vamossagar12 commented on code in PR #13726:
URL: https://github.com/apache/kafka/pull/13726#discussion_r1218211612
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java:
##
@@ -458,13 +458,8 @@ boolean sendRecords() {
}
prot
vamossagar12 commented on code in PR #13726:
URL: https://github.com/apache/kafka/pull/13726#discussion_r1218214268
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTaskTest.java:
##
@@ -483,6 +494,37 @@ public void testFailureInPoll() thr
vamossagar12 commented on code in PR #13726:
URL: https://github.com/apache/kafka/pull/13726#discussion_r1218215790
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java:
##
@@ -458,13 +458,8 @@ boolean sendRecords() {
}
prot
C0urante commented on PR #13750:
URL: https://github.com/apache/kafka/pull/13750#issuecomment-1576987913
Similar to
https://github.com/apache/kafka/pull/13808#issuecomment-1576833452 and
https://github.com/apache/kafka/pull/13810#issuecomment-1576871102, I've
verified locally that this bui
C0urante merged PR #13750:
URL: https://github.com/apache/kafka/pull/13750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
vamossagar12 commented on code in PR #13726:
URL: https://github.com/apache/kafka/pull/13726#discussion_r1218215790
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java:
##
@@ -458,13 +458,8 @@ boolean sendRecords() {
}
prot
vamossagar12 commented on code in PR #13726:
URL: https://github.com/apache/kafka/pull/13726#discussion_r1218215790
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java:
##
@@ -458,13 +458,8 @@ boolean sendRecords() {
}
prot
vamossagar12 commented on PR #13158:
URL: https://github.com/apache/kafka/pull/13158#issuecomment-1577001257
In that case, would it make sense to close this PR @fvaleri ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
C0urante commented on code in PR #13383:
URL: https://github.com/apache/kafka/pull/13383#discussion_r1218244232
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java:
##
@@ -474,129 +451,113 @@ public void testFailureInPollAfterStop() throws
C0urante commented on PR #13806:
URL: https://github.com/apache/kafka/pull/13806#issuecomment-1577037550
Thanks Mickael! 🚀
Will merge pending CI build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
fvaleri commented on PR #13158:
URL: https://github.com/apache/kafka/pull/13158#issuecomment-1577037815
> In that case, would it make sense to close this PR @fvaleri ?
Why? We can discuss where to place these interfaces, but I would keep the
work that has been done. It's just another
mimaison commented on code in PR #13473:
URL: https://github.com/apache/kafka/pull/13473#discussion_r1218269590
##
core/src/test/scala/unit/kafka/controller/KafkaControllerTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
gharris1727 commented on PR #13313:
URL: https://github.com/apache/kafka/pull/13313#issuecomment-1577137346
@ijuma Can you review this project layering change? You reviewed the last
time it was attempted.
Thanks!
--
This is an automated message from the Apache Git Service.
To respo
[
https://issues.apache.org/jira/browse/KAFKA-14627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729381#comment-17729381
]
Greg Harris commented on KAFKA-14627:
-
[~cmukka20] I expect that this feature will b
jolshan commented on PR #13675:
URL: https://github.com/apache/kafka/pull/13675#issuecomment-1577150595
These connect tests are a little concerning. They seem unrelated but maybe
we should file a jira.
--
This is an automated message from the Apache Git Service.
To respond to the message,
divijvaidya opened a new pull request, #13814:
URL: https://github.com/apache/kafka/pull/13814
## Background
In Kafka's code, every batch of records is stored in an in-memory byte
buffer. For compressed workload, this buffer contains data in compressed form.
Before writing it to the
jolshan commented on PR #13811:
URL: https://github.com/apache/kafka/pull/13811#issuecomment-1577188413
Hey Lucas -- thanks for the PR. Just wanted to confirm -- these changes are
in line with what is proposed as part of KIP-691? It looks to me that is the
case, but wanted to confirm.
--
jolshan commented on code in PR #13811:
URL: https://github.com/apache/kafka/pull/13811#discussion_r1218377141
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -1661,6 +1663,10 @@ public void handleResponse(AbstractResponse resp
Jun Rao created KAFKA-15058:
---
Summary: Improve the accuracy of Histogram in client metric
Key: KAFKA-15058
URL: https://issues.apache.org/jira/browse/KAFKA-15058
Project: Kafka
Issue Type: Improvem
gharris1727 commented on code in PR #13813:
URL: https://github.com/apache/kafka/pull/13813#discussion_r1218424942
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -464,10 +465,22 @@ ConfigInfos validateConnectorConfig(Map
connectorPr
jolshan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1218431394
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -977,18 +1058,20 @@ void handleCoordinatorReady() {
jolshan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1218434336
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -471,9 +547,9 @@ synchronized void
requestEpochBumpForPartition(Top
lianetm opened a new pull request, #13815:
URL: https://github.com/apache/kafka/pull/13815
The OffsetFetcher is internally used by the KafkaConsumer to fetch offsets,
validate and reset positions. For the new KafkaConsumer with a refactored
threading model, similar functionality will be nee
rondagostino commented on code in PR #13703:
URL: https://github.com/apache/kafka/pull/13703#discussion_r1218423667
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -377,7 +377,19 @@ private ReplicationControlManager(
}
publ
jeffkbkim commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1218276954
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1218511238
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1218512680
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1218514447
##
core/src/test/scala/unit/kafka/coordinator/group/CoordinatorPartitionWriterTest.scala:
##
@@ -0,0 +1,227 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1218515694
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1218516577
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordSerializerTest.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (A
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1218516113
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerializer.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1218517345
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/PartitionWriter.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation
C0urante commented on PR #13806:
URL: https://github.com/apache/kafka/pull/13806#issuecomment-1577380453
Test failures appear unrelated. Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
C0urante merged PR #13806:
URL: https://github.com/apache/kafka/pull/13806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
jsancio commented on code in PR #13788:
URL: https://github.com/apache/kafka/pull/13788#discussion_r1218527800
##
core/src/test/scala/unit/kafka/zk/migration/ZkMigrationClientTest.scala:
##
@@ -371,17 +371,17 @@ class ZkMigrationClientTest extends
ZkMigrationTestHarness {
jolshan commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1218533754
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -0,0 +1,1009 @@
+/*
+ * Licensed to the Apache Software Fou
jolshan commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1218537640
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -0,0 +1,1009 @@
+/*
+ * Licensed to the Apache Software Fou
andymg3 commented on code in PR #13788:
URL: https://github.com/apache/kafka/pull/13788#discussion_r1218539167
##
core/src/test/scala/unit/kafka/zk/migration/ZkMigrationClientTest.scala:
##
@@ -371,17 +371,17 @@ class ZkMigrationClientTest extends
ZkMigrationTestHarness {
jolshan commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1218547896
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -0,0 +1,1009 @@
+/*
+ * Licensed to the Apache Software Fou
1 - 100 of 134 matches
Mail list logo