Owen-CH-Leung commented on PR #13773:
URL: https://github.com/apache/kafka/pull/13773#issuecomment-1592447477
> b4dd894
@showuon Thanks a lot for your feedback. I've added tests to test the
`handleLoss` function. The issue as described in KAFKA-14712 should go away now.
--
This is
sudeshwasnik commented on PR #13646:
URL: https://github.com/apache/kafka/pull/13646#issuecomment-1592302321
hi @sagarrao12 , small correction in my comment earlier -
```
Since assumption 1 is incorrect, we should change the test where it doesn't
expect every record that decrements r
showuon commented on PR #13773:
URL: https://github.com/apache/kafka/pull/13773#issuecomment-1592269594
@Owen-CH-Leung , thanks for the patch, could you add tests for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
showuon commented on code in PR #13665:
URL: https://github.com/apache/kafka/pull/13665#discussion_r1230345113
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -127,6 +127,8 @@ public final class ConsumerCoordinator extends
Ab
[
https://issues.apache.org/jira/browse/KAFKA-15085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732824#comment-17732824
]
Owen C.H. Leung commented on KAFKA-15085:
-
Hi [~divijvaidya] , can you assign th
[
https://issues.apache.org/jira/browse/KAFKA-14709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-14709.
---
Fix Version/s: 3.6.0
Resolution: Fixed
> Move content in connect/mirror/README.md to the docs
showuon merged PR #13650:
URL: https://github.com/apache/kafka/pull/13650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #13650:
URL: https://github.com/apache/kafka/pull/13650#issuecomment-1592238006
Failed tests are unrelated:
```
Build / JDK 11 and Scala 2.13 /
org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testSyncTopicConfigs()
Build
showuon commented on code in PR #13782:
URL: https://github.com/apache/kafka/pull/13782#discussion_r1230335416
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1007,6 +1007,30 @@ public static void flushDir(Path path) throws
IOException {
}
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1230295895
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Fou
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1230294539
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/ReplicatedGroupCoordinatorTest.java:
##
@@ -0,0 +1,308 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1230293541
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Fou
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1230281526
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software Foundat
wcarlson5 commented on PR #13855:
URL: https://github.com/apache/kafka/pull/13855#issuecomment-1592137217
@cadonna could you give this a look? @vcrfxia has looked at
[this](https://github.com/wcarlson5/kafka/pull/1) and there is a check of the
table's history retention that I am missing but
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1230246630
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software Foundat
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1230243216
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software Foundat
cmccabe commented on code in PR #13826:
URL: https://github.com/apache/kafka/pull/13826#discussion_r1230241309
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -441,23 +441,14 @@ class ControllerApis(val requestChannel: RequestChannel,
if (apiVersionRequest.h
[
https://issues.apache.org/jira/browse/KAFKA-13988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732778#comment-17732778
]
Ravindranath Kakarla commented on KAFKA-13988:
--
Does the issue have anythin
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1230229603
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software Foundat
dimitarndimitrov opened a new pull request, #13856:
URL: https://github.com/apache/kafka/pull/13856
The Java rewrite is kept relatively close to the Scala original to minimize
potential newly introduced bugs and to make reviewing simpler. The following
details might be of note:
- The `Lo
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1230195090
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundati
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1230193218
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/ReplicatedGroupCoordinator.java:
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foun
wcarlson5 opened a new pull request, #13855:
URL: https://github.com/apache/kafka/pull/13855
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testi
Gary Russell created KAFKA-15092:
Summary: KafkaClusterTestKit in test jar depends on
MockFaultHandler
Key: KAFKA-15092
URL: https://issues.apache.org/jira/browse/KAFKA-15092
Project: Kafka
wcarlson5 merged PR #13756:
URL: https://github.com/apache/kafka/pull/13756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
wcarlson5 commented on PR #13756:
URL: https://github.com/apache/kafka/pull/13756#issuecomment-1591908695
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-13756/19/tests/
Test failures are unrelated
--
This is an automated message from the Apache
mumrah commented on code in PR #13724:
URL: https://github.com/apache/kafka/pull/13724#discussion_r1230101055
##
metadata/src/test/java/org/apache/kafka/metadata/RecordTestUtils.java:
##
@@ -95,6 +95,60 @@ public static void replayOne(
replayAll(target, Collections.sing
kirktrue commented on PR #6420:
URL: https://github.com/apache/kafka/pull/6420#issuecomment-1591846803
@dbrinegar @tombentley @guozhangwang @junrao Can this PR be resurrected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
[
https://issues.apache.org/jira/browse/KAFKA-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732694#comment-17732694
]
Kirk True commented on KAFKA-3881:
--
Two questions:
# Is there any reason the PR wasn't
[
https://issues.apache.org/jira/browse/KAFKA-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732693#comment-17732693
]
Kirk True commented on KAFKA-3881:
--
We have a user running into this issue. It appears t
novosibman commented on code in PR #13782:
URL: https://github.com/apache/kafka/pull/13782#discussion_r1230002264
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -976,6 +976,30 @@ public static void flushDir(Path path) throws IOException {
}
[
https://issues.apache.org/jira/browse/KAFKA-15091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732666#comment-17732666
]
Yash Mayya commented on KAFKA-15091:
{quote}{{it does not have anything to do with t
gharris1727 commented on PR #13838:
URL: https://github.com/apache/kafka/pull/13838#issuecomment-1591734588
Yep, I was able to reproduce some flaky failures in testReplication, and
they appear to have a lot of failures in CI. I'll debug those further and
remediate them.
--
This is an aut
jlprat commented on PR #13839:
URL: https://github.com/apache/kafka/pull/13839#issuecomment-1591700252
Thanks for the PR @hudeqi. I think it's always good to improve JavaDocs or
ScalaDocs.
I was looking at the `LogCleaner.scala` file and I saw there are plenty of
methods that are pub
rondagostino commented on PR #13724:
URL: https://github.com/apache/kafka/pull/13724#issuecomment-1591687192
4 test failures on latest build are unrelated. This PR just changes tests,
and all of the affected tests passed.
--
This is an automated message from the Apache Git Service.
To re
wcarlson5 commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1229930816
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software
wcarlson5 commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1229930160
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software
gharris1727 commented on PR #13838:
URL: https://github.com/apache/kafka/pull/13838#issuecomment-1591647109
> This change seems to help with MirrorCheckpoint failing to start. I now
get a lot of failures due to MirrorHeartbeat.
I'll try to reproduce this locally, I hadn't noticed that
gharris1727 commented on code in PR #13838:
URL: https://github.com/apache/kafka/pull/13838#discussion_r1229900453
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java:
##
@@ -1183,17 +1187,31 @@ private void create
vamossagar12 commented on PR #13646:
URL: https://github.com/apache/kafka/pull/13646#issuecomment-1591623006
Thanks @sudeshwasnik , for the assessment. Continuing the line of thought,
if you check the `MonitorableSourceConnector#poll` method, it appears to me
that we decrement the `recordsR
Chris Egerton created KAFKA-15091:
-
Summary: Javadocs for SourceTask::commit are incorrect
Key: KAFKA-15091
URL: https://issues.apache.org/jira/browse/KAFKA-15091
Project: Kafka
Issue Type: B
divijvaidya closed pull request #13778: Feature/shuai add comment
URL: https://github.com/apache/kafka/pull/13778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
divijvaidya commented on PR #13778:
URL: https://github.com/apache/kafka/pull/13778#issuecomment-1591600444
I am closing this PR. Please refer to the comment above for the reason -
https://github.com/apache/kafka/pull/13778#issuecomment-1567994161
--
This is an automated message from the
dajac merged PR #13820:
URL: https://github.com/apache/kafka/pull/13820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
cadonna commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1229867769
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java:
##
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the Apache Softwar
divijvaidya commented on code in PR #13850:
URL: https://github.com/apache/kafka/pull/13850#discussion_r1229867810
##
core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala:
##
@@ -266,13 +309,21 @@ class RemoteIndexCache(maxSize: Int = 1024,
remoteStorageManager: RemoteSt
divijvaidya commented on code in PR #13850:
URL: https://github.com/apache/kafka/pull/13850#discussion_r1229867810
##
core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala:
##
@@ -266,13 +309,21 @@ class RemoteIndexCache(maxSize: Int = 1024,
remoteStorageManager: RemoteSt
ben-manes commented on code in PR #13850:
URL: https://github.com/apache/kafka/pull/13850#discussion_r1229867001
##
core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala:
##
@@ -266,13 +309,21 @@ class RemoteIndexCache(maxSize: Int = 1024,
remoteStorageManager: RemoteStor
ben-manes commented on code in PR #13850:
URL: https://github.com/apache/kafka/pull/13850#discussion_r1229867001
##
core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala:
##
@@ -266,13 +309,21 @@ class RemoteIndexCache(maxSize: Int = 1024,
remoteStorageManager: RemoteStor
divijvaidya commented on code in PR #13850:
URL: https://github.com/apache/kafka/pull/13850#discussion_r1229862041
##
core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala:
##
@@ -266,13 +309,21 @@ class RemoteIndexCache(maxSize: Int = 1024,
remoteStorageManager: RemoteSt
Chris Egerton created KAFKA-15090:
-
Summary: Source tasks are no longer stopped on a separate thread
Key: KAFKA-15090
URL: https://issues.apache.org/jira/browse/KAFKA-15090
Project: Kafka
Iss
divijvaidya commented on PR #13705:
URL: https://github.com/apache/kafka/pull/13705#issuecomment-1591550112
I triggered the CI tests again since last run wasn't complete. Will merge
this in after they are successful.
--
This is an automated message from the Apache Git Service.
To respond
wcarlson5 commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1229836485
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software
wcarlson5 commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1229836485
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software
wcarlson5 commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1229824269
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java:
##
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Software
wcarlson5 commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1229732758
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDbTimeOrderedKeyValueBytesStoreSupplier.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apach
dajac commented on PR #13820:
URL: https://github.com/apache/kafka/pull/13820#issuecomment-1591401484
Failed tests seem unrelated:
```
Build / JDK 11 and Scala 2.13 / testReplication() –
org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest
1m 45s
Build /
dajac opened a new pull request, #13854:
URL: https://github.com/apache/kafka/pull/13854
This fix the following issue that we occasionally see in
[builds](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-13848/4/pipeline/13/).
```
[2023-06-14T11:41
dajac commented on PR #13854:
URL: https://github.com/apache/kafka/pull/13854#issuecomment-1591397811
Similar to https://github.com/apache/kafka/pull/13316.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
hudeqi commented on PR #13705:
URL: https://github.com/apache/kafka/pull/13705#issuecomment-1591356625
> Looks good to me. One minor thing is to update the PR name (since we use
the same for commit messages). As I understand, we are not really optimizing
anything here. We are refactoring th
mimaison commented on code in PR #13838:
URL: https://github.com/apache/kafka/pull/13838#discussion_r1229669181
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java:
##
@@ -1183,17 +1187,31 @@ private void createTop
C0urante commented on PR #13819:
URL: https://github.com/apache/kafka/pull/13819#issuecomment-1591326215
@mimaison @viktorsomogyi sorry for the extra ping--this issue is actually a
regression and is leading to increased failure rates on Jenkins; would it be
possible to take a look sometime
divijvaidya commented on PR #13782:
URL: https://github.com/apache/kafka/pull/13782#issuecomment-1591281777
Hey @novosibman could you please respond to rest of the comments at
https://github.com/apache/kafka/pull/13782#pullrequestreview-1461194326 and
https://github.com/apache/kafka/pull/13
machi1990 commented on PR #13700:
URL: https://github.com/apache/kafka/pull/13700#issuecomment-1591262415
@divijvaidya since you worked on https://github.com/apache/kafka/pull/13623,
would you be open to give this PR a review? Thanks
--
This is an automated message from the Apache Git Ser
machi1990 commented on PR #13624:
URL: https://github.com/apache/kafka/pull/13624#issuecomment-1591235123
Thank you @divijvaidya for the review and merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
divijvaidya commented on PR #13831:
URL: https://github.com/apache/kafka/pull/13831#issuecomment-1591232505
> Also, what's the common process to update the documentation?
As part of this PR, please modify the documentation at:
https://github.com/apache/kafka/blob/044d058e03bde8179e
hudeqi commented on code in PR #13719:
URL: https://github.com/apache/kafka/pull/13719#discussion_r1229633097
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -680,12 +680,16 @@ abstract class AbstractFetcherThread(name: String,
*/
val offset
[
https://issues.apache.org/jira/browse/KAFKA-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732540#comment-17732540
]
Lubos Hozzan commented on KAFKA-7802:
-
Hello.
The problem is still persistent. We us
divijvaidya merged PR #13624:
URL: https://github.com/apache/kafka/pull/13624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
[
https://issues.apache.org/jira/browse/KAFKA-12458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732539#comment-17732539
]
Ivan Yurchenko commented on KAFKA-12458:
FYI: I've been working on a {{RemoteSto
[
https://issues.apache.org/jira/browse/KAFKA-9565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732536#comment-17732536
]
Ivan Yurchenko commented on KAFKA-9565:
---
AFAIU, concrete {{RemoteStorageManager}} i
dajac commented on code in PR #13719:
URL: https://github.com/apache/kafka/pull/13719#discussion_r1229581401
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -680,12 +680,16 @@ abstract class AbstractFetcherThread(name: String,
*/
val offsetA
[
https://issues.apache.org/jira/browse/KAFKA-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lubos Hozzan updated KAFKA-7802:
Attachment: BytesInput.png
> Connection to Broker Disconnected Taking Down the Whole Cluster
>
dajac commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1229600983
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation
David Jacot created KAFKA-15089:
---
Summary: Consolidate all the group coordinator configs
Key: KAFKA-15089
URL: https://issues.apache.org/jira/browse/KAFKA-15089
Project: Kafka
Issue Type: Sub-t
hudeqi commented on code in PR #13719:
URL: https://github.com/apache/kafka/pull/13719#discussion_r1229575083
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String,
*/
val offset
hudeqi commented on code in PR #13719:
URL: https://github.com/apache/kafka/pull/13719#discussion_r1229573502
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String,
*/
val offset
dajac commented on code in PR #13719:
URL: https://github.com/apache/kafka/pull/13719#discussion_r1229555487
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String,
*/
val offsetA
hudeqi commented on PR #13839:
URL: https://github.com/apache/kafka/pull/13839#issuecomment-159368
Hello, could you help to review this PR? @jlprat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
hudeqi commented on PR #13705:
URL: https://github.com/apache/kafka/pull/13705#issuecomment-1591092269
Hi, @divijvaidya, it has been updated according to your comment, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
showuon commented on code in PR #13650:
URL: https://github.com/apache/kafka/pull/13650#discussion_r1229514718
##
connect/mirror/README.md:
##
@@ -1,297 +0,0 @@
-
-# MirrorMaker 2.0
-
-MM2 leverages the Connect framework to replicate topics between Kafka
-clusters. MM2 includes
[
https://issues.apache.org/jira/browse/KAFKA-15083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-15083:
-
Assignee: Satish Duggana
> Passing "remote.log.metadata.*" configs into RLMM
>
showuon commented on PR #13828:
URL: https://github.com/apache/kafka/pull/13828#issuecomment-1591076070
> > I think we don't have this implemented. We should pass
remote.log.metadata.* into RLMM based on KIP-405. Created
[KAFKA-15083](https://issues.apache.org/jira/browse/KAFKA-15083) for t
vamossagar12 commented on PR #13853:
URL: https://github.com/apache/kafka/pull/13853#issuecomment-1591072071
@daehokimm ,nice catch, thanks for the PR. LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
daehokimm opened a new pull request, #13853:
URL: https://github.com/apache/kafka/pull/13853
Currently, in the AbstractHerder class, the behavior of state changes for
Connectors and Tasks is handled by implementing Listener using the
ConnectorStatus and TaskStatus classes, which inherit fro
Daeho Kim created KAFKA-15088:
-
Summary: Fixing Incorrect Reference Usage in Connector State
Changes
Key: KAFKA-15088
URL: https://issues.apache.org/jira/browse/KAFKA-15088
Project: Kafka
Issue
KarboniteKream commented on PR #13762:
URL: https://github.com/apache/kafka/pull/13762#issuecomment-1591027643
Sure, it's no problem for me to wait. I just wanted to confirm what you had
in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
vamossagar12 commented on PR #13762:
URL: https://github.com/apache/kafka/pull/13762#issuecomment-1591024476
> Sure, I understand the concerns.
>
> > you might want to align your PR with that PR?
>
> Do you mean waiting for that PR to get merged, then rebase my changes? Or
add
hudeqi commented on PR #13719:
URL: https://github.com/apache/kafka/pull/13719#issuecomment-1591024699
Hi, is there any suggestion and must do for this PR now? @dajac @satishd
@divijvaidya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dajac commented on code in PR #13820:
URL: https://github.com/apache/kafka/pull/13820#discussion_r1229446218
##
server-common/src/main/java/org/apache/kafka/server/util/timer/TimerTask.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
hudeqi opened a new pull request, #13852:
URL: https://github.com/apache/kafka/pull/13852
### Activation
As the config 'segment.bytes' for topics related MM2(such as
offset.storage.topic, config.storage.topic,status.storage.topic), if following
the default configuration of the broker or
daehokimm closed pull request #9259: KAFKA-10466: Allow regex for MaskField SMT
to replacement
URL: https://github.com/apache/kafka/pull/9259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
cadonna commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1229370444
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java:
##
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Softwar
Dimitar Dimitrov created KAFKA-15087:
Summary: Move InterBrokerSendThread to server-commons module
Key: KAFKA-15087
URL: https://issues.apache.org/jira/browse/KAFKA-15087
Project: Kafka
I
vamossagar12 commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1229411879
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,10 +284,61 @@ public Future set(Map
values, Callbac
dajac commented on code in PR #13820:
URL: https://github.com/apache/kafka/pull/13820#discussion_r1229407264
##
server-common/src/main/java/org/apache/kafka/server/util/timer/TimerTaskEntry.java:
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
vamossagar12 commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1229405980
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,10 +280,33 @@ public Future set(Map
values, Callbac
vamossagar12 commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1229405593
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -302,7 +326,12 @@ public Future set(Map
values, Callback
vamossagar12 commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1229404145
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java:
##
@@ -192,6 +197,220 @@ public void testCancelAfterAwaitFlush() th
vamossagar12 commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1229402835
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,10 +280,33 @@ public Future set(Map
values, Callbac
1 - 100 of 138 matches
Mail list logo
