yashmayya commented on PR #14278:
URL: https://github.com/apache/kafka/pull/14278#issuecomment-1689327007
The runtime for `:connect:mirror:test` seems to have halved on my machine
too with this change!
--
This is an automated message from the Apache Git Service.
To respond to the
kamalcph commented on PR #14238:
URL: https://github.com/apache/kafka/pull/14238#issuecomment-1689306154
Integration test for this patch was covered in
kamalcph commented on PR #14238:
URL: https://github.com/apache/kafka/pull/14238#issuecomment-1689302657
@clolov @divijvaidya @showuon @satishd
Call for review. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
junrao merged PR #14218:
URL: https://github.com/apache/kafka/pull/14218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757792#comment-17757792
]
Haruki Okada commented on KAFKA-15391:
--
May I take this ticket?
I'm interested since this issue
github-actions[bot] commented on PR #13746:
URL: https://github.com/apache/kafka/pull/13746#issuecomment-1689229303
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
showuon commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1302442110
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -870,12 +870,14 @@ class LogManager(logDirs: Seq[File],
* Update the configuration of the provided topic.
gharris1727 opened a new pull request, #14278:
URL: https://github.com/apache/kafka/pull/14278
The MirrorConnectorsIntegrationBaseTest and derived tests delete all of the
topics after the test is complete, but before the EmbeddedConnectCluster (and
EmbeddedKafkaCluster) are stopped. If a
Greg Harris created KAFKA-15393:
---
Summary: MirrorMaker2 integration tests are shutting down uncleanly
Key: KAFKA-15393
URL: https://issues.apache.org/jira/browse/KAFKA-15393
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757734#comment-17757734
]
Greg Harris commented on KAFKA-15292:
-
The listed exception is shadowing the real exception, which
gharris1727 opened a new pull request, #14277:
URL: https://github.com/apache/kafka/pull/14277
The ServletContextHandlers which are initialized and started in
`initializeResources()` are never stopped, causing Jetty's Server#destroy()
call to always throw an exception. When another
[
https://issues.apache.org/jira/browse/KAFKA-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-15392:
Description:
Due to the initialization order of the connect RestServer and Herder, the jetty
Greg Harris created KAFKA-15392:
---
Summary: RestServer starts but does not stop ServletContextHandler
Key: KAFKA-15392
URL: https://issues.apache.org/jira/browse/KAFKA-15392
Project: Kafka
dajac commented on code in PR #14271:
URL: https://github.com/apache/kafka/pull/14271#discussion_r1302279096
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -426,9 +429,43 @@ public CompletableFuture
listGroups(
dajac commented on PR #14271:
URL: https://github.com/apache/kafka/pull/14271#issuecomment-1689042864
> @dajac hi, could you pls help me see the check error log. I don't quite
understand the root cause and what should be fixed myself. The check error log
is as followed
>
> >
dajac commented on PR #14120:
URL: https://github.com/apache/kafka/pull/14120#issuecomment-1689037270
@jolshan Thanks for your review. I have addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
cmccabe closed pull request #14276: get test run for MINOR: Move delegation
token support to Metadata Version 3.6-IV2 #14270
URL: https://github.com/apache/kafka/pull/14276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
cmccabe merged PR #14270:
URL: https://github.com/apache/kafka/pull/14270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1302271854
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -1040,6 +1089,342 @@ public void
dajac commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1302270931
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -498,9 +526,35 @@ public
CompletableFuture
return
dajac commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1302269825
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -595,4 +599,98 @@ public void
dajac commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1302269584
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -543,6 +543,14 @@ public void validateOffsetCommit(
}
jolshan commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1302269425
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -480,9 +482,35 @@ public
CompletableFuture
dajac commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1302268054
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -480,9 +482,35 @@ public
CompletableFuture
return
lianetm commented on PR #14218:
URL: https://github.com/apache/kafka/pull/14218#issuecomment-1689001635
Thanks @junrao. All clients test passed. Unrelated test failures:
Build / JDK 20 and Scala 2.13 / testThreadPoolResize() –
kafka.server.DynamicBrokerReconfigurationTest
Build /
cmccabe commented on PR #14270:
URL: https://github.com/apache/kafka/pull/14270#issuecomment-1688741825
I'll try to get a test run here https://github.com/apache/kafka/pull/14276
since jenkins had an issue on this one.
--
This is an automated message from the Apache Git Service.
To
cmccabe opened a new pull request, #14276:
URL: https://github.com/apache/kafka/pull/14276
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
[
https://issues.apache.org/jira/browse/KAFKA-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe reassigned KAFKA-15213:
Assignee: Colin McCabe
> Provide the exact offset to QuorumController.replay
>
[
https://issues.apache.org/jira/browse/KAFKA-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-15213.
--
Fix Version/s: 3.6.0
Resolution: Fixed
> Provide the exact offset to
mimaison commented on code in PR #14211:
URL: https://github.com/apache/kafka/pull/14211#discussion_r1301958711
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -541,6 +541,8 @@ private static int configureDeliveryTimeout(ProducerConfig
mimaison commented on PR #13860:
URL: https://github.com/apache/kafka/pull/13860#issuecomment-1688603919
I rebased on top of trunk and reran the system tests in our CI. Many of the
Streams upgrade system tests are flaky but I've seen all of them pass at least
once apart from
cmccabe commented on code in PR #14160:
URL: https://github.com/apache/kafka/pull/14160#discussion_r1301949782
##
docs/ops.html:
##
@@ -3615,7 +3615,7 @@ The following features are not yet supported for ZK to KRaft
migrations:
-Downgrading to ZooKeeper mode during or
mimaison merged PR #14267:
URL: https://github.com/apache/kafka/pull/14267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on code in PR #12637:
URL: https://github.com/apache/kafka/pull/12637#discussion_r1300517797
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##
@@ -0,0 +1,500 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757549#comment-17757549
]
Pere Urbon-Bayes commented on KAFKA-4169:
-
Hi,
I hope to provide some help around this
mimaison opened a new pull request, #14275:
URL: https://github.com/apache/kafka/pull/14275
Currently this produces log lines like:
```
INFO [ProducerStateManager partition=connect-status-1]Wrote producer
snapshot at offset 2 with 0 producer ids in 19 ms.
[
https://issues.apache.org/jira/browse/KAFKA-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pere Urbon-Bayes reassigned KAFKA-4169:
---
Assignee: Pere Urbon-Bayes
> Calculation of message size is too conservative for
clolov commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1301857857
##
core/src/test/scala/unit/kafka/server/TieredStorageSystemWideConfigTest.scala:
##
@@ -0,0 +1,100 @@
+package unit.kafka.server
+
+import
clolov commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1301856757
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -500,22 +500,27 @@ public static void validateBrokerLogConfigValues(Map props,
kamalcph commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1301852957
##
core/src/test/scala/unit/kafka/server/TieredStorageSystemWideConfigTest.scala:
##
@@ -0,0 +1,100 @@
+package unit.kafka.server
+
+import
yashmayya opened a new pull request, #14274:
URL: https://github.com/apache/kafka/pull/14274
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
gharris1727 closed pull request #14245: KAFKA-15372: Add MirrorMaker2 connector
config forwarding on startup
URL: https://github.com/apache/kafka/pull/14245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gharris1727 commented on PR #14245:
URL: https://github.com/apache/kafka/pull/14245#issuecomment-1688463790
This fix adds an endpoint that is unsecured by default to an environment
where all other endpoints are secured. This is subject to some larger
discussion and is not eligible for a
[
https://issues.apache.org/jira/browse/KAFKA-15372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757542#comment-17757542
]
Greg Harris commented on KAFKA-15372:
-
Reading through the KIP-710 thread, it appears that the
kamalcph commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1301834895
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -500,22 +500,27 @@ public static void validateBrokerLogConfigValues(Map props,
kun98-liu closed pull request #14248: MINOR: Add libs.slf4jlog4j to
dependencies in project(':core')
URL: https://github.com/apache/kafka/pull/14248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mimaison commented on PR #13204:
URL: https://github.com/apache/kafka/pull/13204#issuecomment-1688394680
To be honest, I'm not sure. Try rebasing on trunk. Maybe there's a conflict
with a recent commit.
--
This is an automated message from the Apache Git Service.
To respond to the
clolov commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1301785987
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,
clolov commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1301784967
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,
clolov commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1301784533
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -870,12 +870,14 @@ class LogManager(logDirs: Seq[File],
* Update the configuration of the provided topic.
olalamichelle commented on PR #14255:
URL: https://github.com/apache/kafka/pull/14255#issuecomment-1688355924
@bachmanity1 Thank you! @clolov could you please assign my name to
StreamsProducerTest? Seems that I do not have edit permission for
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757487#comment-17757487
]
Christo Lolov commented on KAFKA-15388:
---
I would like to contribute to this ticket once the above
[
https://issues.apache.org/jira/browse/KAFKA-15353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757372#comment-17757372
]
Mickael Maison edited comment on KAFKA-15353 at 8/22/23 1:55 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pere Urbon-Bayes reassigned KAFKA-4169:
---
Assignee: (was: Pere Urbon-Bayes)
> Calculation of message size is too
[
https://issues.apache.org/jira/browse/KAFKA-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pere Urbon-Bayes reassigned KAFKA-4169:
---
Assignee: Pere Urbon-Bayes
> Calculation of message size is too conservative for
tinaselenge commented on PR #14266:
URL: https://github.com/apache/kafka/pull/14266#issuecomment-1688206105
@divijvaidya @clolov thank you for the feedback. I believe I have addressed
the comments and as discussed, the remote log manager configs are left as
internal until the required
tinaselenge commented on code in PR #14266:
URL: https://github.com/apache/kafka/pull/14266#discussion_r1301651698
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -146,111 +146,111 @@ public final class
[
https://issues.apache.org/jira/browse/KAFKA-15391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757442#comment-17757442
]
Haruki Okada commented on KAFKA-15391:
--
I see, understood. Thanks
> Delete topic may lead to
divijvaidya commented on code in PR #14266:
URL: https://github.com/apache/kafka/pull/14266#discussion_r1301603620
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -146,111 +146,111 @@ public final class
divijvaidya commented on PR #11438:
URL: https://github.com/apache/kafka/pull/11438#issuecomment-1688113407
Hey @arunmathew88
I know it has been a while but I was wondering if you would like to update
this PR again? We have multiple bugs which are fixed by it.
--
This is an
clolov commented on code in PR #14223:
URL: https://github.com/apache/kafka/pull/14223#discussion_r1301586778
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/AbstractStreamTest.java:
##
@@ -36,40 +36,39 @@
import
[
https://issues.apache.org/jira/browse/KAFKA-15391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757413#comment-17757413
]
Divij Vaidya commented on KAFKA-15391:
--
[~ocadaruma] It is a bit different from the perspective
[
https://issues.apache.org/jira/browse/KAFKA-15391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757388#comment-17757388
]
Haruki Okada edited comment on KAFKA-15391 at 8/22/23 11:57 AM:
[
https://issues.apache.org/jira/browse/KAFKA-15391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757388#comment-17757388
]
Haruki Okada commented on KAFKA-15391:
--
Related? https://issues.apache.org/jira/browse/KAFKA-13403
[
https://issues.apache.org/jira/browse/KAFKA-15391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15391:
-
Description:
This is an edge case where the entire log directory is marked offline when we
Divij Vaidya created KAFKA-15391:
Summary: Delete topic may lead to directory offline
Key: KAFKA-15391
URL: https://issues.apache.org/jira/browse/KAFKA-15391
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757383#comment-17757383
]
François Rosière commented on KAFKA-7699:
-
Would be great to have such kind of support into Kafka
[
https://issues.apache.org/jira/browse/KAFKA-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757383#comment-17757383
]
François Rosière edited comment on KAFKA-7699 at 8/22/23 11:16 AM:
---
[
https://issues.apache.org/jira/browse/KAFKA-15353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757372#comment-17757372
]
Mickael Maison commented on KAFKA-15353:
[~calvinliu] Thanks for the quick PR!
I'm trying to
[
https://issues.apache.org/jira/browse/KAFKA-9926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757323#comment-17757323
]
Divij Vaidya commented on KAFKA-9926:
-
I added a PR to fix this since the previous assignee wasn't
[
https://issues.apache.org/jira/browse/KAFKA-9926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-9926:
Fix Version/s: 3.6.0
> Flaky test PlaintextAdminIntegrationTest.testCreatePartitions
>
divijvaidya opened a new pull request, #14273:
URL: https://github.com/apache/kafka/pull/14273
## Exception stack trace
```
org.opentest4j.AssertionFailedError: expected: <3> but was: <1>
at
[
https://issues.apache.org/jira/browse/KAFKA-9926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya reassigned KAFKA-9926:
---
Assignee: Divij Vaidya (was: GeordieMai)
> Flaky test
OmniaGM commented on PR #13204:
URL: https://github.com/apache/kafka/pull/13204#issuecomment-1687836451
@mimaison I can't reproduce the problem locally. I ran `./gradlew
-PscalaVersion=2.13 test --profile --continue -PkeepAliveMode=session
-PtestLoggingEvents=started,passed,skipped,failed
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1301361619
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1096,6 +1493,43 @@ public void close() {
}
}
+// Visible for testing
+
tinaselenge commented on code in PR #14266:
URL: https://github.com/apache/kafka/pull/14266#discussion_r1301308504
##
docs/configuration.html:
##
@@ -286,7 +286,12 @@
- 3.9 System
Properties
+ 3.9 Tier Storage
Configs
+ Below is the configuration of Tier Storage.
tinaselenge commented on code in PR #14266:
URL: https://github.com/apache/kafka/pull/14266#discussion_r1301326223
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -146,111 +146,111 @@ public final class
tinaselenge commented on code in PR #14266:
URL: https://github.com/apache/kafka/pull/14266#discussion_r1301308504
##
docs/configuration.html:
##
@@ -286,7 +286,12 @@
- 3.9 System
Properties
+ 3.9 Tier Storage
Configs
+ Below is the configuration of Tier Storage.
zhaohaidao commented on PR #14271:
URL: https://github.com/apache/kafka/pull/14271#issuecomment-1687779192
@dajac hi, could you pls help me see the check error log. I don't quite
understand the root cause and what should be fixed myself.
The check error log is as followed
>
divijvaidya commented on code in PR #14266:
URL: https://github.com/apache/kafka/pull/14266#discussion_r1301294921
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -146,111 +146,111 @@ public final class
divijvaidya commented on PR #14266:
URL: https://github.com/apache/kafka/pull/14266#issuecomment-1687769802
> I think we have always referred to the functionality as Tiered Storage
rather than Tier Storage
Across Kafka code base including the config we refer to it as "remote
divijvaidya merged PR #14204:
URL: https://github.com/apache/kafka/pull/14204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
clolov commented on code in PR #14266:
URL: https://github.com/apache/kafka/pull/14266#discussion_r1301284451
##
docs/toc.html:
##
@@ -52,7 +52,8 @@
3.6 Kafka Streams Configs
3.7 AdminClient Configs
3.8 MirrorMaker Configs
-
divijvaidya commented on PR #14204:
URL: https://github.com/apache/kafka/pull/14204#issuecomment-1687763866
Verified that all 3 tests modified in this PR are successful:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14204/2/testReport/org.apache.kafka.streams.kstream.internals/
[
https://issues.apache.org/jira/browse/KAFKA-14813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757252#comment-17757252
]
Nicola Stringari commented on KAFKA-14813:
--
Sure, here is a couple of logs.
Thank you in
[
https://issues.apache.org/jira/browse/KAFKA-15219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757246#comment-17757246
]
Viktor Somogyi-Vass commented on KAFKA-15219:
-
[~pprovenzano] thanks a lot for your work!
[
https://issues.apache.org/jira/browse/KAFKA-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-15344:
--
Assignee: Lucas Brutschy
> Kafka Streams should include the message leader epoch
see-quick commented on code in PR #14211:
URL: https://github.com/apache/kafka/pull/14211#discussion_r1301064046
##
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##
@@ -2399,4 +2400,39 @@ public KafkaProducer newKafkaProducer() {
}
see-quick commented on code in PR #14211:
URL: https://github.com/apache/kafka/pull/14211#discussion_r1301064046
##
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##
@@ -2399,4 +2400,39 @@ public KafkaProducer newKafkaProducer() {
}
89 matches
Mail list logo
