[ https://issues.apache.org/jira/browse/KAFKA-3700 ]
Igor Shipenkov deleted comment on KAFKA-3700:
---
was (Author: JIRAUSER280700):
For people, looking for OCSP support.
Use Oracle Java documentation "[Security Developer’s Guide - OCSP Stapling
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1386171452
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesVersion.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1386172972
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesVersion.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1386175030
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesEnsemble.java:
##
@@ -0,0 +1,575 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1386175030
##
metadata/src/main/java/org/apache/kafka/metadata/properties/MetaPropertiesEnsemble.java:
##
@@ -0,0 +1,575 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
[
https://issues.apache.org/jira/browse/KAFKA-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783924#comment-17783924
]
Mikael commented on KAFKA-14419:
[~mjsax] The reduced session.timeout.ms is because we w
[
https://issues.apache.org/jira/browse/KAFKA-15707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783927#comment-17783927
]
Zihao Lin commented on KAFKA-15707:
---
The description is not clear. The test need to be
[
https://issues.apache.org/jira/browse/KAFKA-15707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zihao Lin updated KAFKA-15707:
--
Summary: KRaft support in TopicBasedRemoteLogMetadataManagerTest (was:
KRaft support in TopicBasedRem
[
https://issues.apache.org/jira/browse/KAFKA-15707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783927#comment-17783927
]
Zihao Lin edited comment on KAFKA-15707 at 11/8/23 8:41 AM:
[
https://issues.apache.org/jira/browse/KAFKA-15707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zihao Lin updated KAFKA-15707:
--
Description:
The following tests in TopicBasedRemoteLogMetadataManagerTest in
storage/src/test/java/o
[
https://issues.apache.org/jira/browse/KAFKA-15750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zihao Lin updated KAFKA-15750:
--
Fix Version/s: (was: 4.0.0)
> KRaft support in KafkaMetricReporterExceptionHandlingTest
>
[
https://issues.apache.org/jira/browse/KAFKA-15739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zihao Lin updated KAFKA-15739:
--
Fix Version/s: (was: 4.0.0)
> KRaft support in ResetConsumerGroupOffsetTest
>
dajac commented on PR #14670:
URL: https://github.com/apache/kafka/pull/14670#issuecomment-1801359691
Thanks for the explanation, @kirktrue. I agree with you that we should not
block this PR on fixing all those tests. We can continue to fix them in
subsequent PRs. For the tests only applica
dajac commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1386231835
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerDelegate.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
yashmayya commented on code in PR #14704:
URL: https://github.com/apache/kafka/pull/14704#discussion_r1386195297
##
docs/connect.html:
##
@@ -41,7 +41,7 @@ Running
Kafka ConnectIn standalone mode all work is performed in a single process. This
configuration is simpler to setup
dajac commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1386232830
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -247,12 +247,10 @@ private void closeInternal(final Duration timeou
dajac commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1386239113
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -222,42 +214,74 @@ public void cleanup() {
}
}
-@Test
-pu
dajac commented on PR #14670:
URL: https://github.com/apache/kafka/pull/14670#issuecomment-1801373056
@kirktrue The build is red. Could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
[
https://issues.apache.org/jira/browse/KAFKA-15708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zihao Lin reassigned KAFKA-15708:
-
Assignee: Zihao Lin
> KRaft support in FetchRequestDownConversionConfigTest
> -
linzihao1999 opened a new pull request, #14715:
URL: https://github.com/apache/kafka/pull/14715
The tests in FetchRequestDownConversionConfigTest in
core/src/test/scala/unit/kafka/server/FetchRequestDownConversionConfigTest.scala
updated to support KRaft.
### Committer Checklist (exc
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1801718171
@C0urante So I can confirm the following things
* No methods are directly called on mocks (I checked both mocks defined by
the `@Mock` annotation or local mocks created with `moc
clolov opened a new pull request, #14716:
URL: https://github.com/apache/kafka/pull/14716
This pull requests migrates mocks from StreamTaskTest to Mockito.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
clolov commented on PR #14716:
URL: https://github.com/apache/kafka/pull/14716#issuecomment-1801761375
I will circle back a bit later to provide reasoning about why some seemingly
needed things were removed.
--
This is an automated message from the Apache Git Service.
To respond to the me
vamossagar12 commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1801765565
@JimmyWang6 , Did you get a chance to go through the comments above? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
soarez commented on PR #14392:
URL: https://github.com/apache/kafka/pull/14392#issuecomment-1801863864
I don't think I understand your comment/suggestion. The broker can only know
UUIDs for directories that are online. If they are offline the directory ID
cannot be read. What should be done
soarez commented on code in PR #14369:
URL: https://github.com/apache/kafka/pull/14369#discussion_r1386609951
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2296,13 +2298,41 @@ class ReplicaManager(val config: KafkaConfig,
if (sendZkNotification)
jlprat commented on PR #14692:
URL: https://github.com/apache/kafka/pull/14692#issuecomment-1801887255
Hi @ex172000
These methods might be indeed not used within the Kafka codebase. However,
they are part of the public APIs and removing these methods might break
source/binary compatibili
mimaison commented on PR #10826:
URL: https://github.com/apache/kafka/pull/10826#issuecomment-1801941525
Yes it would be good to get this over the line. @dongjinleekr Do you think
you'll have time to update it? or would you need some help?
--
This is an automated message from the Apache G
ex172000 commented on PR #14692:
URL: https://github.com/apache/kafka/pull/14692#issuecomment-1802087614
> Hi @ex172000 thanks for the PR. These methods might be indeed not used
within the Kafka codebase. However, they are part of the public APIs and
removing these methods might break sourc
pprovenzano commented on code in PR #14369:
URL: https://github.com/apache/kafka/pull/14369#discussion_r1386788917
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2296,13 +2298,41 @@ class ReplicaManager(val config: KafkaConfig,
if (sendZkNotification)
pprovenzano commented on PR #14392:
URL: https://github.com/apache/kafka/pull/14392#issuecomment-1802108456
> I don't think I understand your comment/suggestion. The broker can only
know UUIDs for directories that are online. If they are offline the directory
ID cannot be read. What should
jlprat commented on PR #14692:
URL: https://github.com/apache/kafka/pull/14692#issuecomment-1802117942
Correct, deprecated methods and classes can be removed in `4.0.0` (but we
are not yet preparing this release) as long as they have been deprecated for a
year (if my memory serves right the
pprovenzano commented on PR #14392:
URL: https://github.com/apache/kafka/pull/14392#issuecomment-1802120042
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
soarez commented on code in PR #14369:
URL: https://github.com/apache/kafka/pull/14369#discussion_r1386805266
##
core/src/main/java/kafka/server/AssignmentsManager.java:
##
@@ -0,0 +1,386 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contribut
soarez commented on code in PR #14369:
URL: https://github.com/apache/kafka/pull/14369#discussion_r1386810622
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2296,13 +2298,41 @@ class ReplicaManager(val config: KafkaConfig,
if (sendZkNotification)
mimaison commented on PR #14663:
URL: https://github.com/apache/kafka/pull/14663#issuecomment-1802170828
It's such a big file that doing it incrementally may make the reviews
easier. That said a lot of changes should be mechanical and similar across all
tests so we probably don't want to do
[
https://issues.apache.org/jira/browse/KAFKA-14589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784106#comment-17784106
]
Nikolay Izhikov commented on KAFKA-14589:
-
PR https://github.com/apache/kafka/pu
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1802193860
Hello, @mimaison @jolshan
Can, you, please, take a look?
I think we have to merge PR to don't lost test utility.
--
This is an automated message from the Apache Git Service.
To
lucasbru merged PR #14709:
URL: https://github.com/apache/kafka/pull/14709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1802230356
Thanks for the updates! Can we switch to jdk_21_latest? as it's the newest
java version we use in the other stages
--
This is an automated message from the Apache Git Service.
To respo
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1386903370
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -321,20 +320,6 @@ public class ConsumerConfig extends AbstractConfig {
*/
kirktrue commented on PR #14670:
URL: https://github.com/apache/kafka/pull/14670#issuecomment-1802247627
An update on the `KafkaConsumerTest`—
Of the 100 tests, 39 successfully pass using both group protocols. 61 have
failures when using the `CONSUMER` group protocol, so they have bee
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1386903933
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerUtils.java:
##
@@ -211,4 +226,17 @@ else if (t instanceof KafkaException)
thr
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1386907003
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerDelegate.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1386910396
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -222,42 +214,74 @@ public void cleanup() {
}
}
-@Test
-
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1386912274
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -881,24 +967,26 @@ public void testResetUsingAutoResetPolicy() {
asse
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1386911536
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -721,16 +802,17 @@ public void
verifyNoCoordinatorLookupForManualAssignmentWi
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1386911868
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -835,16 +919,17 @@ public void testMissingOffsetNoResetPolicy() {
ass
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1386913209
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -1893,8 +2014,9 @@ private void consumerCloseTest(final long closeTimeoutMs,
aliehsaeedii commented on PR #14626:
URL: https://github.com/apache/kafka/pull/14626#issuecomment-1802270514
@cadonna
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
mimaison opened a new pull request, #14717:
URL: https://github.com/apache/kafka/pull/14717
Changes in Jenkinsfile are only tested if the PR is from a committer. So
opening this temp PR to check if the changes from
https://github.com/apache/kafka/pull/13817 work.
### Committer Checkl
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1802275265
So obvious reasons, changes in Jenkinsfile are only tested if the PR is from
a committer. So I opened https://github.com/apache/kafka/pull/14717 to run your
changes.
You can see
kirktrue commented on PR #14670:
URL: https://github.com/apache/kafka/pull/14670#issuecomment-1802288411
> @kirktrue The build is red. Could you please take a look?
The build failures are due to the recent "Dodgy code Warnings" that SpotBugs
is suddenly issuing.
SpotBugs report
mimaison commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1386949236
##
tools/src/test/resources/log4j-off.properties:
##
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
Do we r
jolshan commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1386957752
##
tools/src/test/resources/log4j-off.properties:
##
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
+1
--
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1386960816
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1386961908
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1386961908
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
David Arthur created KAFKA-15799:
Summary: ZK brokers incorrectly handle KRaft metadata snapshots
Key: KAFKA-15799
URL: https://issues.apache.org/jira/browse/KAFKA-15799
Project: Kafka
Issue
aliehsaeedii commented on PR #14596:
URL: https://github.com/apache/kafka/pull/14596#issuecomment-1802337074
@mjsax maybe needs approval;-)
cc: @cadonna
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1386970135
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1386974229
##
tools/src/test/resources/log4j-off.properties:
##
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
Without
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1802353727
Raised a JIRA ticket to have jdk_21_latest installed on shared power nodes
https://issues.apache.org/jira/browse/INFRA-25149
--
This is an automated message from the Apache Git
cmccabe commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1386983421
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -270,10 +271,31 @@ class KafkaServer(
logDirFailureChannel = new LogDirFailureChannel(config.log
Greg Harris created KAFKA-15800:
---
Summary: Malformed connect source offsets corrupt other partitions
with DataException
Key: KAFKA-15800
URL: https://issues.apache.org/jira/browse/KAFKA-15800
Project: K
philipnee commented on PR #14680:
URL: https://github.com/apache/kafka/pull/14680#issuecomment-1802364240
Hi @kirktrue Thanks for taking time reviewing the PR: Just to quickly
respond to your comment.
The BackgroundEventProcessor is already invoked inside poll() and if the
event is a
philipnee commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1386995116
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java:
##
@@ -168,6 +200,45 @@ public void testCommitted_ExceptionThrow
gharris1727 opened a new pull request, #14718:
URL: https://github.com/apache/kafka/pull/14718
https://issues.apache.org/jira/browse/KAFKA-15800
The JsonConverter may throw DataException when encountering malformed data.
This causes part or all of the batch of ConsumerRecords from the
mumrah opened a new pull request, #14719:
URL: https://github.com/apache/kafka/pull/14719
TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-
dajac commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1387013819
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -222,42 +214,74 @@ public void cleanup() {
}
}
-@Test
-pu
junrao commented on code in PR #14712:
URL: https://github.com/apache/kafka/pull/14712#discussion_r1387012471
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -54,23 +54,29 @@ object KafkaRequestHandler {
}
/**
- * Wrap callback to schedule it on a
dajac commented on PR #14670:
URL: https://github.com/apache/kafka/pull/14670#issuecomment-1802394898
> 3 reference the enforceRebalance() that the CONSUMER group protocol
intentionally doesn't implement
Should we add a small comment to those to explain that this is not supported
in
jolshan commented on code in PR #14712:
URL: https://github.com/apache/kafka/pull/14712#discussion_r1387025174
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -54,23 +54,29 @@ object KafkaRequestHandler {
}
/**
- * Wrap callback to schedule it on a
jolshan commented on PR #14712:
URL: https://github.com/apache/kafka/pull/14712#issuecomment-1802409370
I also see a test failure so I will fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
junrao commented on code in PR #14712:
URL: https://github.com/apache/kafka/pull/14712#discussion_r1387049371
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -54,23 +54,29 @@ object KafkaRequestHandler {
}
/**
- * Wrap callback to schedule it on a
jolshan commented on code in PR #14702:
URL: https://github.com/apache/kafka/pull/14702#discussion_r1387054947
##
core/src/test/scala/integration/kafka/api/TransactionsTest.scala:
##
@@ -69,6 +70,8 @@ class TransactionsTest extends IntegrationTestHarness {
props.put(KafkaCo
michaldo opened a new pull request, #14720:
URL: https://github.com/apache/kafka/pull/14720
ConsumerCoordinator should first call invokePartitionsAssigned and then save
the subscription state.
Otherwise the following scenario is possible:
1. ConsumerCoordinator is notified that par
agavra commented on code in PR #14708:
URL: https://github.com/apache/kafka/pull/14708#discussion_r1387070971
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/TimeWindowStoreMaterializer.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Founda
apoorvmittal10 commented on code in PR #14632:
URL: https://github.com/apache/kafka/pull/14632#discussion_r1387072536
##
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##
@@ -536,6 +552,8 @@ object ConfigCommand extends Logging {
adminClient.listTopics(new
List
junrao commented on code in PR #14712:
URL: https://github.com/apache/kafka/pull/14712#discussion_r1387075522
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -54,23 +54,27 @@ object KafkaRequestHandler {
}
/**
- * Wrap callback to schedule it on a
apoorvmittal10 commented on code in PR #14632:
URL: https://github.com/apache/kafka/pull/14632#discussion_r1387077385
##
core/src/main/scala/kafka/server/DynamicConfig.scala:
##
@@ -111,6 +112,16 @@ object DynamicConfig {
}
}
+ object ClientMetrics {
+private val
apoorvmittal10 commented on code in PR #14632:
URL: https://github.com/apache/kafka/pull/14632#discussion_r1387099016
##
core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala:
##
@@ -1628,6 +1628,122 @@ class ConfigCommandTest extends Logging {
Seq("/clients/clie
apoorvmittal10 commented on code in PR #14632:
URL: https://github.com/apache/kafka/pull/14632#discussion_r1387101615
##
core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala:
##
@@ -1628,6 +1628,122 @@ class ConfigCommandTest extends Logging {
Seq("/clients/clie
apoorvmittal10 commented on PR #14632:
URL: https://github.com/apache/kafka/pull/14632#issuecomment-1802514338
> @apoorvmittal10 : Thanks for the PR. Left a few comments.
Thanks for the feedback @junrao. I have addressed the comments.
--
This is an automated message from the Apache
splett2 commented on PR #14713:
URL: https://github.com/apache/kafka/pull/14713#issuecomment-1802533050
updates to TopicCommandIntegrationTest lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jolshan commented on code in PR #14702:
URL: https://github.com/apache/kafka/pull/14702#discussion_r1387139976
##
core/src/test/scala/integration/kafka/api/TransactionsTest.scala:
##
@@ -94,8 +97,8 @@ class TransactionsTest extends IntegrationTestHarness {
createTopic(topic
mjsax commented on code in PR #14708:
URL: https://github.com/apache/kafka/pull/14708#discussion_r1387169903
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -217,8 +217,19 @@ public TopologyConfig(final String topologyName, final
StreamsConfig globa
mjsax commented on code in PR #14708:
URL: https://github.com/apache/kafka/pull/14708#discussion_r1387182591
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/TimeWindowStoreMaterializer.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundat
agavra commented on code in PR #14708:
URL: https://github.com/apache/kafka/pull/14708#discussion_r1387215167
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -217,8 +217,19 @@ public TopologyConfig(final String topologyName, final
StreamsConfig glob
jolshan commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1387217781
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2610,6 +2610,73 @@ class KafkaApisTest {
}
}
+ @Test
+ def testProduceResponseMetadataL
jolshan commented on code in PR #14702:
URL: https://github.com/apache/kafka/pull/14702#discussion_r1387221735
##
core/src/test/scala/integration/kafka/api/TransactionsTest.scala:
##
@@ -69,6 +70,8 @@ class TransactionsTest extends IntegrationTestHarness {
props.put(KafkaCo
junrao commented on code in PR #14705:
URL: https://github.com/apache/kafka/pull/14705#discussion_r1387227928
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -659,9 +660,21 @@ public TopicPartition key() {
*/
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1387236588
##
tools/src/test/resources/log4j-off.properties:
##
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
I remov
soarez commented on code in PR #14369:
URL: https://github.com/apache/kafka/pull/14369#discussion_r1386805266
##
core/src/main/java/kafka/server/AssignmentsManager.java:
##
@@ -0,0 +1,386 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contribut
jolshan commented on PR #14387:
URL: https://github.com/apache/kafka/pull/14387#issuecomment-1802757018
Something very strange is up with this build. I will try again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1387252814
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2610,6 +2610,73 @@ class KafkaApisTest {
}
}
+ @Test
+ def testProduceResponseMetadataLo
chb2ab commented on PR #1:
URL: https://github.com/apache/kafka/pull/1#issuecomment-1802764239
Updated to not include the node if it wasn't found in metadata lookup based
on offline chat with @jolshan
--
This is an automated message from the Apache Git Service.
To respond to the
junrao commented on code in PR #14632:
URL: https://github.com/apache/kafka/pull/14632#discussion_r1387265452
##
core/src/main/scala/kafka/server/DynamicConfig.scala:
##
@@ -111,6 +112,16 @@ object DynamicConfig {
}
}
+ object ClientMetrics {
+private val clientCo
soarez commented on code in PR #14369:
URL: https://github.com/apache/kafka/pull/14369#discussion_r1386805266
##
core/src/main/java/kafka/server/AssignmentsManager.java:
##
@@ -0,0 +1,386 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contribut
soarez commented on code in PR #14369:
URL: https://github.com/apache/kafka/pull/14369#discussion_r1386805266
##
core/src/main/java/kafka/server/AssignmentsManager.java:
##
@@ -0,0 +1,386 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contribut
1 - 100 of 146 matches
Mail list logo
