lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1412391352
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -198,11 +202,13 @@ private void processSubscriptionCha
hachikuji merged PR #14890:
URL: https://github.com/apache/kafka/pull/14890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
[
https://issues.apache.org/jira/browse/KAFKA-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal reopened KAFKA-9545:
--
Assignee: (was: Boyang Chen)
> Flaky Test `RegexSourceIntegrationTest.testRegexMatchesTop
[
https://issues.apache.org/jira/browse/KAFKA-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792158#comment-17792158
]
Apoorv Mittal commented on KAFKA-9545:
--
Reoccurred the failure:
https://ci-builds.a
apoorvmittal10 commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1836538541
Build is yellow with unrelated tests failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lucasbru merged PR #14869:
URL: https://github.com/apache/kafka/pull/14869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
hanyuzheng7 opened a new pull request, #14898:
URL: https://github.com/apache/kafka/pull/14898
Update upgrade-guide.html for TimestampedKeyQuery and TimestampedRangeQuery
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify t
OmniaGM commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1412422869
##
server/src/main/java/org/apache/kafka/server/AssignmentsManager.java:
##
@@ -95,7 +96,10 @@ public void close() throws InterruptedException {
}
public vo
OmniaGM commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1412423207
##
server/src/main/java/org/apache/kafka/server/AssignmentsManager.java:
##
@@ -391,4 +402,4 @@ static AssignReplicasToDirsRequestData buildRequestData(int
brokerId, l
lucasbru commented on PR #14895:
URL: https://github.com/apache/kafka/pull/14895#issuecomment-1836550893
@mjsax could you merge this later today if CI passes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1412428498
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -181,11 +183,13 @@ private void process(final ListOff
cadonna commented on PR #14895:
URL: https://github.com/apache/kafka/pull/14895#issuecomment-1836560772
FYI, the following tests also fails consistently on trunk:
```
org.apache.kafka.common.requests.BrokerRegistrationRequestTest.[1] 0
org.apache.kafka.common.requests.BrokerRegistrat
OmniaGM commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1412455807
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -613,7 +613,16 @@ class Partition(val topicPartition: TopicPartition,
// Only ReplicaAlterDirThread will
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412482284
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
mjsax commented on PR #14895:
URL: https://github.com/apache/kafka/pull/14895#issuecomment-1836641789
`:generator:checkstyleTest` failure -- could not reproduce locally. Will
retrigger Jenkins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412484071
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412491930
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryProvider.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Founda
lianetm commented on code in PR #14878:
URL: https://github.com/apache/kafka/pull/14878#discussion_r1412491852
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -783,6 +774,7 @@ void markReconciliationCompleted() {
*
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412500117
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412506519
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412507867
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software Founda
mjsax merged PR #14889:
URL: https://github.com/apache/kafka/pull/14889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412522319
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412522622
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Software Fo
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412530561
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Software Fo
mjsax commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r1412530967
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java:
##
@@ -266,75 +269,28 @@ public VersionedRecord get(final Bytes key, final
mjsax commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r1412530967
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java:
##
@@ -266,75 +269,28 @@ public VersionedRecord get(final Bytes key, final
mjsax commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r1412530967
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java:
##
@@ -266,75 +269,28 @@ public VersionedRecord get(final Bytes key, final
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412542727
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Software Fo
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412506519
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software Founda
mjsax commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r1412552909
##
streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412554632
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Software Fo
philipnee commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1836749674
Hi @apoorvmittal10 Thanks for the time to address my comments - I made
another pass and added some more comments, mostly nit-picking. After this I
think we are good to go.
--
This i
mjsax commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r1412552909
##
streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
jeffkbkim commented on code in PR #14885:
URL: https://github.com/apache/kafka/pull/14885#discussion_r1412575325
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -66,6 +65,10 @@ class CoordinatorPartitionWriter[T](
compressionType: Compre
jeffkbkim commented on code in PR #14870:
URL: https://github.com/apache/kafka/pull/14870#discussion_r1412583010
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorTimer.java:
##
@@ -52,6 +52,20 @@ interface TimeoutOperation {
*/
mumrah commented on PR #14850:
URL: https://github.com/apache/kafka/pull/14850#issuecomment-1836803801
I tried this in IntelliJ and I see the test name included in the individual
test variation output. Looks great!
https://github.com/apache/kafka/assets/55116/fac807f0-06f8-4237-be95-3
AndrewJSchofield closed pull request #14894: KAFKA-15831: KIP-1000 protocol and
admin client
URL: https://github.com/apache/kafka/pull/14894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
jolshan commented on code in PR #14888:
URL: https://github.com/apache/kafka/pull/14888#discussion_r1412620108
##
clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java:
##
@@ -62,14 +62,14 @@ public class RefreshingHttp
ableegoldman commented on code in PR #14853:
URL: https://github.com/apache/kafka/pull/14853#discussion_r1412620201
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##
@@ -572,13 +574,19 @@ public synchronized void flush() {
@Override
jolshan commented on code in PR #14888:
URL: https://github.com/apache/kafka/pull/14888#discussion_r141264
##
clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java:
##
@@ -134,6 +136,20 @@ public void testSecondaryR
jeffkbkim commented on code in PR #14849:
URL: https://github.com/apache/kafka/pull/14849#discussion_r1412622265
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/ContextStateMachine.java:
##
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software F
jeffkbkim commented on code in PR #14849:
URL: https://github.com/apache/kafka/pull/14849#discussion_r1412622438
##
core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala:
##
@@ -153,6 +154,15 @@ class CoordinatorLoaderImpl[T](
}
jolshan commented on PR #14896:
URL: https://github.com/apache/kafka/pull/14896#issuecomment-1836861158
Hmmm -- are we concerned with introducing these new test failures? I agree a
timeout is good, but I'm wondering if there is a way we could suppress these
failures for PR builds.
--
Thi
ableegoldman commented on code in PR #14852:
URL: https://github.com/apache/kafka/pull/14852#discussion_r1412625873
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java:
##
@@ -64,31 +62,14 @@ public RocksDBTimestampedStore(final String
jolshan commented on PR #14896:
URL: https://github.com/apache/kafka/pull/14896#issuecomment-1836863361
I've also been seeing more failed builds --
```
* What went wrong:
Execution failed for task ':streams:upgrade-system-tests-25:test'.
> Process 'Gradle Test Executor
jeffkbkim commented on code in PR #14849:
URL: https://github.com/apache/kafka/pull/14849#discussion_r1412627530
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/ContextStateMachine.java:
##
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software F
Colin McCabe created KAFKA-15956:
Summary: MetadataShell must take the directory lock when reading
Key: KAFKA-15956
URL: https://issues.apache.org/jira/browse/KAFKA-15956
Project: Kafka
Issue
fvaleri commented on PR #14106:
URL: https://github.com/apache/kafka/pull/14106#issuecomment-1836870533
@muralibasani should you also close this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ableegoldman commented on code in PR #14735:
URL: https://github.com/apache/kafka/pull/14735#discussion_r1412638885
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -580,6 +582,23 @@ public void setGlobalStateRestoreListener(final
StateRestoreListener
cmccabe opened a new pull request, #14899:
URL: https://github.com/apache/kafka/pull/14899
MetadataShell should take an advisory lock on the .lock file of the
directory it is reading from. Add an integration test of this functionality in
MetadataShellIntegrationTest.java.
Note: in bu
jsancio commented on code in PR #14899:
URL: https://github.com/apache/kafka/pull/14899#discussion_r1412657561
##
shell/src/main/java/org/apache/kafka/shell/MetadataShell.java:
##
@@ -81,6 +85,21 @@ public MetadataShell build() {
}
}
+static FileLock takeFile
Justine Olshan created KAFKA-15957:
--
Summary:
ConsistencyVectorIntegrationTest.shouldHaveSamePositionBoundActiveAndStandBy
broken
Key: KAFKA-15957
URL: https://issues.apache.org/jira/browse/KAFKA-15957
ableegoldman commented on code in PR #14735:
URL: https://github.com/apache/kafka/pull/14735#discussion_r1412648726
##
streams/src/main/java/org/apache/kafka/streams/processor/StandbyUpdateListener.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
[
https://issues.apache.org/jira/browse/KAFKA-15957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792268#comment-17792268
]
Justine Olshan commented on KAFKA-15957:
[https://github.com/apache/kafka/pull/1
jolshan commented on PR #14895:
URL: https://github.com/apache/kafka/pull/14895#issuecomment-1836934042
fyi -- I filed https://issues.apache.org/jira/browse/KAFKA-15957 but looks
like you folks are on it.
--
This is an automated message from the Apache Git Service.
To respond to the messa
cmccabe commented on code in PR #14899:
URL: https://github.com/apache/kafka/pull/14899#discussion_r1412672706
##
shell/src/main/java/org/apache/kafka/shell/MetadataShell.java:
##
@@ -81,6 +85,21 @@ public MetadataShell build() {
}
}
+static FileLock takeFile
cmccabe commented on code in PR #14899:
URL: https://github.com/apache/kafka/pull/14899#discussion_r1412672706
##
shell/src/main/java/org/apache/kafka/shell/MetadataShell.java:
##
@@ -81,6 +85,21 @@ public MetadataShell build() {
}
}
+static FileLock takeFile
kirktrue commented on code in PR #14888:
URL: https://github.com/apache/kafka/pull/14888#discussion_r1412678216
##
clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java:
##
@@ -134,6 +136,20 @@ public void testSecondary
[
https://issues.apache.org/jira/browse/KAFKA-15957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-15957:
---
Assignee: Lucas Brutschy
> ConsistencyVectorIntegrationTest.shouldHaveSamePositionB
kirktrue commented on code in PR #14879:
URL: https://github.com/apache/kafka/pull/14879#discussion_r1412683354
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -398,6 +466,38 @@ public class AsyncKafkaConsumer implements
Consu
kirktrue commented on code in PR #14879:
URL: https://github.com/apache/kafka/pull/14879#discussion_r1412683183
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -849,9 +953,22 @@ public OptionalLong currentLag(TopicPartition
to
cmccabe commented on code in PR #14899:
URL: https://github.com/apache/kafka/pull/14899#discussion_r1412689568
##
shell/src/main/java/org/apache/kafka/shell/MetadataShell.java:
##
@@ -119,6 +141,7 @@ private void initializeWithRaftManager() {
}
private void initializ
cmccabe commented on PR #14899:
URL: https://github.com/apache/kafka/pull/14899#issuecomment-1836970040
In addition to the junit tests, I also tested this manually and it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
rayalatrinadh closed pull request #14900: errorHandling
URL: https://github.com/apache/kafka/pull/14900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rayalatrinadh opened a new pull request, #14900:
URL: https://github.com/apache/kafka/pull/14900
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of t
rayalatrinadh commented on PR #14900:
URL: https://github.com/apache/kafka/pull/14900#issuecomment-1836981169
no conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
wcarlson5 commented on code in PR #14864:
URL: https://github.com/apache/kafka/pull/14864#discussion_r1412696799
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -713,6 +735,97 @@ boolean runLoop() {
return true;
}
+
jeffkbkim commented on code in PR #14849:
URL: https://github.com/apache/kafka/pull/14849#discussion_r1412700208
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -322,7 +335,7 @@ public void testScheduleLoading() {
jeffkbkim commented on code in PR #14849:
URL: https://github.com/apache/kafka/pull/14849#discussion_r1412701656
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -1659,4 +1680,117 @@ public void testPartitionLoadSen
rayalatrinadh opened a new pull request, #14901:
URL: https://github.com/apache/kafka/pull/14901
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of t
rayalatrinadh commented on PR #14901:
URL: https://github.com/apache/kafka/pull/14901#issuecomment-1836995567
improve logging around broker/NetworkClient connectivity Committed Checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wcarlson5 commented on code in PR #14107:
URL: https://github.com/apache/kafka/pull/14107#discussion_r1412698954
##
docs/streams/upgrade-guide.html:
##
@@ -198,6 +184,21 @@ Streams API
+
Review Comment:
Thanks for remembering the docs update!
##
kirktrue closed pull request #14768: KAFKA-14438: Throw error when consumer
configured with empty/whitespace-only group.id for AsyncKafkaConsumer
URL: https://github.com/apache/kafka/pull/14768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/KAFKA-15932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15932:
-
Assignee: Andrew Schofield
> Flaky test - PlaintextConsumerTest.testSeek("kraft+kip-848","consu
vamossagar12 commented on PR #13283:
URL: https://github.com/apache/kafka/pull/13283#issuecomment-1837036580
@ableegoldman , just checking if you got a chance to look at my comment
above? Don't mean to be pushy on this but since 3.7 release is approaching, I
thought I would want to have the
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412721690
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412722252
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryProvider.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software F
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412723432
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software F
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412723727
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software F
splett2 commented on code in PR #14888:
URL: https://github.com/apache/kafka/pull/14888#discussion_r1412729044
##
clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java:
##
@@ -134,6 +136,20 @@ public void testSecondaryR
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412729556
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software F
splett2 commented on code in PR #14888:
URL: https://github.com/apache/kafka/pull/14888#discussion_r1412729044
##
clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java:
##
@@ -134,6 +136,20 @@ public void testSecondaryR
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412729589
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Softwa
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412729783
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Softwa
Apoorv Mittal created KAFKA-15958:
-
Summary: Add tests to validate telemetry requests with different
version
Key: KAFKA-15958
URL: https://issues.apache.org/jira/browse/KAFKA-15958
Project: Kafka
splett2 commented on code in PR #14888:
URL: https://github.com/apache/kafka/pull/14888#discussion_r1412729044
##
clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java:
##
@@ -134,6 +136,20 @@ public void testSecondaryR
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412729920
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Softwa
splett2 commented on PR #14891:
URL: https://github.com/apache/kafka/pull/14891#issuecomment-1837054475
I don't think we want to directly call `TestUtils.createTopicWithAdmin` in
this test for most cases. I didn't read through all of the tests, but I would
imagine that most of these integra
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412733949
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Softwa
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412734130
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software F
apoorvmittal10 commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1837060946
> Hi @apoorvmittal10 Thanks for the time to address my comments - I made
another pass and added some more comments, mostly nit-picking. After this I
think we are good to go.
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
101 - 193 of 193 matches
Mail list logo
