apoorvmittal10 commented on PR #14924:
URL: https://github.com/apache/kafka/pull/14924#issuecomment-1840678823
Build passed with flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
apoorvmittal10 commented on code in PR #14926:
URL: https://github.com/apache/kafka/pull/14926#discussion_r1415398373
##
tools/src/main/java/org/apache/kafka/tools/ClientMetricsCommand.java:
##
@@ -0,0 +1,379 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
AndrewJSchofield commented on code in PR #14916:
URL: https://github.com/apache/kafka/pull/14916#discussion_r1415479462
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3496,53 +3501,52 @@ public void
showuon opened a new pull request, #14927:
URL: https://github.com/apache/kafka/pull/14927
zookeeper_migration_test in 3.5 branch failed with:
1. "Kafka server didn't finish startup in 60 seconds" : This is because we
added a constraint to ZK migrating to KRaft that we don't support
soarez commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1415473599
##
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##
@@ -121,8 +122,38 @@ public static Map createAssignmentMap(int[]
replicas, Uuid[] dire
ijuma commented on PR #14663:
URL: https://github.com/apache/kafka/pull/14663#issuecomment-1840644028
I think 7-8 tests at a time (4-5 PRs overall) is probably a reasonable
balance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ijuma commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1840638490
@mdedetrich looks like this is really close - can you address the last set
of comments so we can merge?
--
This is an automated message from the Apache Git Service.
To respond to the
msn-tldr commented on PR #14916:
URL: https://github.com/apache/kafka/pull/14916#issuecomment-1840609832
@AndrewJSchofield I have update the comments in the test to make it more
readable, hope it helps.
Also i have made same changes to FetcherTest where these tests were
originally
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1840593068
Thanks all for review and merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cadonna commented on code in PR #14879:
URL: https://github.com/apache/kafka/pull/14879#discussion_r1415421728
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -232,6 +235,16 @@ private void onResponse(final
soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1415408700
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -166,6 +166,19 @@ class BrokerLifecycleManager(
*/
private var registered = false
+
cadonna commented on code in PR #14873:
URL: https://github.com/apache/kafka/pull/14873#discussion_r1415377837
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -121,11 +127,13 @@ public HeartbeatRequestManager(
borisssmidtCET commented on PR #14597:
URL: https://github.com/apache/kafka/pull/14597#issuecomment-1840520823
> Thanks for the PR. There are a number of changes in this PR - which ones
actually made a difference to the numbers? Some of them are a bit questionable.
1. The main
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415344533
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -409,9 +411,13 @@ class AclAuthorizer extends Authorizer with Logging {
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415317427
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -61,18 +60,18 @@ object AclAuthorizer {
val AllowEveryoneIfNoAclIsFoundProp =
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415349250
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -563,15 +570,20 @@ class AclAuthorizer extends Authorizer with Logging {
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415344533
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -409,9 +411,13 @@ class AclAuthorizer extends Authorizer with Logging {
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415342634
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -331,12 +330,15 @@ class AclAuthorizer extends Authorizer with Logging {
}
lucasbru commented on code in PR #14879:
URL: https://github.com/apache/kafka/pull/14879#discussion_r1415340659
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -232,6 +233,12 @@ private void onResponse(final
AndrewJSchofield opened a new pull request, #14926:
URL: https://github.com/apache/kafka/pull/14926
Initial implementation of `kafka-client-metrics.sh` tools for KIP-714 and
KIP-1000.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415341068
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -61,18 +60,18 @@ object AclAuthorizer {
val AllowEveryoneIfNoAclIsFoundProp =
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415341068
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -61,18 +60,18 @@ object AclAuthorizer {
val AllowEveryoneIfNoAclIsFoundProp =
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415317427
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -61,18 +60,18 @@ object AclAuthorizer {
val AllowEveryoneIfNoAclIsFoundProp =
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415317427
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -61,18 +60,18 @@ object AclAuthorizer {
val AllowEveryoneIfNoAclIsFoundProp =
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415314693
##
clients/src/main/java/org/apache/kafka/common/security/auth/KafkaPrincipal.java:
##
@@ -53,7 +53,12 @@ public KafkaPrincipal(String principalType, String
dajac commented on PR #14845:
URL: https://github.com/apache/kafka/pull/14845#issuecomment-1840467329
@jolshan Thanks for your comments. I have addressed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415317427
##
core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala:
##
@@ -61,18 +60,18 @@ object AclAuthorizer {
val AllowEveryoneIfNoAclIsFoundProp =
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415306650
##
clients/src/main/java/org/apache/kafka/common/security/auth/KafkaPrincipal.java:
##
@@ -68,9 +73,15 @@ public boolean equals(Object o) {
if (this ==
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415314693
##
clients/src/main/java/org/apache/kafka/common/security/auth/KafkaPrincipal.java:
##
@@ -53,7 +53,12 @@ public KafkaPrincipal(String principalType, String
dajac commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1415313002
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -187,8 +190,6 @@ public CoordinatorResult
commitOffset(
dajac commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1415313002
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -187,8 +190,6 @@ public CoordinatorResult
commitOffset(
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415312775
##
clients/src/main/java/org/apache/kafka/common/resource/ResourceType.java:
##
@@ -104,17 +104,18 @@ public static ResourceType fromCode(byte code) {
dajac commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1415310830
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -675,25 +675,25 @@ public void testValidateOffsetCommit() {
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415306650
##
clients/src/main/java/org/apache/kafka/common/security/auth/KafkaPrincipal.java:
##
@@ -68,9 +73,15 @@ public boolean equals(Object o) {
if (this ==
borisssmidtCET commented on code in PR #14597:
URL: https://github.com/apache/kafka/pull/14597#discussion_r1415306650
##
clients/src/main/java/org/apache/kafka/common/security/auth/KafkaPrincipal.java:
##
@@ -68,9 +73,15 @@ public boolean equals(Object o) {
if (this ==
AndrewJSchofield opened a new pull request, #14925:
URL: https://github.com/apache/kafka/pull/14925
The consumer integration tests were experimentally disabled for the new
`AsyncKafkaConsumer` variant with the aim of improving build stability. Several
improvements have been made to the
dajac commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1415305714
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorShardTest.java:
##
@@ -293,7 +326,11 @@ public void testReplayOffsetCommit() {
lucasbru commented on code in PR #14878:
URL: https://github.com/apache/kafka/pull/14878#discussion_r1415302167
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestManagers.java:
##
@@ -157,6 +157,7 @@ protected RequestManagers create() {
dajac commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1415299461
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -1615,4 +1618,127 @@ public void
dajac commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1415298403
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -833,13 +835,15 @@ public void validateOffsetCommit(
dajac commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1415287012
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -180,7 +185,78 @@ public OffsetMetadataManager build() {
/**
cadonna commented on code in PR #14687:
URL: https://github.com/apache/kafka/pull/14687#discussion_r1415253303
##
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java:
##
@@ -239,10 +240,14 @@ public static String safeUniqueTestName(final
[
https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-14595:
---
Fix Version/s: 3.7.0
> Move ReassignPartitionsCommand to tools
>
[
https://issues.apache.org/jira/browse/KAFKA-15645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-15645.
Fix Version/s: 3.7.0
Resolution: Fixed
> Move ReplicationQuotasTestRig to tools
>
mimaison merged PR #14588:
URL: https://github.com/apache/kafka/pull/14588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna merged PR #14852:
URL: https://github.com/apache/kafka/pull/14852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
philipnee commented on PR #14920:
URL: https://github.com/apache/kafka/pull/14920#issuecomment-1840284323
Hi @lucasbru - I intended to open this for review however, I'm having a hard
time to get testCommitAsyncLeaderEpochUpdate because it somehow seems to try to
send a commit request with
[
https://issues.apache.org/jira/browse/KAFKA-14245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Quang Nguyen updated KAFKA-14245:
-
Priority: Blocker (was: Major)
> Topic deleted during reassignment
>
[
https://issues.apache.org/jira/browse/KAFKA-14245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Quang Nguyen updated KAFKA-14245:
-
Priority: Major (was: Blocker)
> Topic deleted during reassignment
>
dajac merged PR #14826:
URL: https://github.com/apache/kafka/pull/14826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #14687:
URL: https://github.com/apache/kafka/pull/14687#discussion_r1415122463
##
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java:
##
@@ -239,10 +240,14 @@ public static String safeUniqueTestName(final
dajac merged PR #14870:
URL: https://github.com/apache/kafka/pull/14870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
201 - 253 of 253 matches
Mail list logo
