[jira] [Commented] (KAFKA-13607) Cannot use PEM certificate coding when parent defined file-based

2024-01-18 Thread Sergey Ivanov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808526#comment-17808526 ] Sergey Ivanov commented on KAFKA-13607: --- Hello, We also faced an issue with

Re: [PR] KAFKA-14505; [7/N] Always materialize the most recent committed offset [kafka]

2024-01-18 Thread via GitHub
dajac commented on PR #15183: URL: https://github.com/apache/kafka/pull/15183#issuecomment-1899919345 For the reference, I was thinking about an alternative approach. Instead of keeping track of the offset of the record in the log for every committed offsets, we could delete all the

Re: [PR] KAFKA-14505; [7/N] Always materialize the most recent committed offset [kafka]

2024-01-18 Thread via GitHub
dajac commented on code in PR #15183: URL: https://github.com/apache/kafka/pull/15183#discussion_r1458508459 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -712,13 +712,14 @@ public void run() {

Re: [PR] KAFKA-14505; [7/N] Always materialize the most recent committed offset [kafka]

2024-01-18 Thread via GitHub
dajac commented on code in PR #15183: URL: https://github.com/apache/kafka/pull/15183#discussion_r1458504559 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -918,7 +920,7 @@ public void replay(

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-18 Thread via GitHub
CalvinConfluent commented on PR #14612: URL: https://github.com/apache/kafka/pull/14612#issuecomment-1899907260 Verified the following tests locally testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress also fails in other PR

Re: [PR] KAFKA-14505; [7/N] Always materialize the most recent committed offset [kafka]

2024-01-18 Thread via GitHub
dajac commented on code in PR #15183: URL: https://github.com/apache/kafka/pull/15183#discussion_r1458501802 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java: ## @@ -92,30 +117,34 @@ public boolean equals(Object o) {

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-18 Thread via GitHub
showuon commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1458455522 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the

Re: [PR] KAFKA-16113: Add committed and commit sensor to record metrics [kafka]

2024-01-18 Thread via GitHub
philipnee commented on PR #15210: URL: https://github.com/apache/kafka/pull/15210#issuecomment-1899847833 Hey @lucasbru - Thanks for your time reviewing this PR. I've made changes according to your suggestion. Let me know what do you think of the PR. -- This is an automated message from

Re: [PR] KAFKA-15717: KRaft support in LeaderEpochIntegrationTest [kafka]

2024-01-18 Thread via GitHub
appchemist commented on code in PR #15225: URL: https://github.com/apache/kafka/pull/15225#discussion_r1458326771 ## core/src/test/scala/unit/kafka/server/epoch/LeaderEpochIntegrationTest.scala: ## @@ -277,6 +283,22 @@ class LeaderEpochIntegrationTest extends QuorumTestHarness

Re: [PR] KAFKA-15717: KRaft support in LeaderEpochIntegrationTest [kafka]

2024-01-18 Thread via GitHub
appchemist commented on code in PR #15225: URL: https://github.com/apache/kafka/pull/15225#discussion_r1458315848 ## core/src/test/scala/unit/kafka/server/epoch/LeaderEpochIntegrationTest.scala: ## @@ -277,6 +283,22 @@ class LeaderEpochIntegrationTest extends QuorumTestHarness

Re: [PR] KAFKA-16144: skip checkQuorum for only 1 voter case [kafka]

2024-01-18 Thread via GitHub
showuon commented on PR #15235: URL: https://github.com/apache/kafka/pull/15235#issuecomment-1899645426 @mimaison , please help review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-16144: skip checkQuorum for only 1 voter case [kafka]

2024-01-18 Thread via GitHub
showuon commented on code in PR #15235: URL: https://github.com/apache/kafka/pull/15235#discussion_r1458256739 ## raft/src/main/java/org/apache/kafka/raft/LeaderState.java: ## @@ -101,6 +101,10 @@ protected LeaderState( * @return the remainingMs before the

[PR] KAFKA-16144: skip checkQuorum for only 1 voter case [kafka]

2024-01-18 Thread via GitHub
showuon opened a new pull request, #15235: URL: https://github.com/apache/kafka/pull/15235 When there's only 1 voter, there will be no fetch request from other voters. In this case, we should still not expire the checkQuorum timer because there's just 1 voter. ### Committer

Re: [PR] KAFKA-15610: Fix `CoreUtils.swallow()` test gaps [kafka]

2024-01-18 Thread via GitHub
github-actions[bot] commented on PR #14583: URL: https://github.com/apache/kafka/pull/14583#issuecomment-1899638097 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[jira] [Assigned] (KAFKA-16144) Controller leader checkQuorum timer should skip only 1 controller case

2024-01-18 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-16144: - Assignee: Luke Chen > Controller leader checkQuorum timer should skip only 1 controller case >

[jira] [Resolved] (KAFKA-16163) Constant resignation/reelection of controller when starting a single node in combined mode

2024-01-18 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-16163. --- Resolution: Duplicate > Constant resignation/reelection of controller when starting a single node

[jira] [Updated] (KAFKA-16111) Implement tests for tricky rebalance callback scenarios

2024-01-18 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16111: -- Description: There is justified concern that the new threading model may not play well with "tricky"

Re: [PR] KAFKA-16141: Fix StreamsStandbyTask system test [kafka]

2024-01-18 Thread via GitHub
mjsax commented on PR #15217: URL: https://github.com/apache/kafka/pull/15217#issuecomment-1899524211 Jenkins looks good, but previous system tests run did not start to run the test (I assume also because of the compilation error). Retriggered:

Re: [PR] KAFKA-16159: MINOR - Correcting logs to debug telemetry reporter [kafka]

2024-01-18 Thread via GitHub
mjsax commented on PR #15228: URL: https://github.com/apache/kafka/pull/15228#issuecomment-1899520079 Thanks @apoorvmittal10! Merged to `trunk` and cherry-picked to `3.7` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-16159: MINOR - Correcting logs to debug telemetry reporter [kafka]

2024-01-18 Thread via GitHub
mjsax merged PR #15228: URL: https://github.com/apache/kafka/pull/15228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (KAFKA-16111) Implement tests for tricky rebalance callback scenarios

2024-01-18 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16111: - Assignee: Lucas Brutschy (was: Kirk True) > Implement tests for tricky rebalance callback

Re: [PR] KAFKA-15987: Refactor ReplicaManager code for transaction verification [kafka]

2024-01-18 Thread via GitHub
jolshan commented on code in PR #15087: URL: https://github.com/apache/kafka/pull/15087#discussion_r1458144631 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2560,41 +2562,6 @@ class ReplicaManagerTest { } } - @ParameterizedTest -

Re: [PR] KAFKA-15987: Refactor ReplicaManager code for transaction verification [kafka]

2024-01-18 Thread via GitHub
jolshan commented on code in PR #15087: URL: https://github.com/apache/kafka/pull/15087#discussion_r1458144452 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2560,41 +2562,6 @@ class ReplicaManagerTest { } } - @ParameterizedTest -

Re: [PR] KAFKA-15987: Refactor ReplicaManager code for transaction verification [kafka]

2024-01-18 Thread via GitHub
jolshan commented on code in PR #15087: URL: https://github.com/apache/kafka/pull/15087#discussion_r1458143981 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1188,18 +1073,7 @@ class ReplicaManager(val config: KafkaConfig, requestLocal: RequestLocal,

Re: [PR] KAFKA-15987: Refactor ReplicaManager code for transaction verification [kafka]

2024-01-18 Thread via GitHub
jolshan commented on code in PR #15087: URL: https://github.com/apache/kafka/pull/15087#discussion_r1458143630 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1188,18 +1073,7 @@ class ReplicaManager(val config: KafkaConfig, requestLocal: RequestLocal,

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-18 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1458141964 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -64,28 +64,89 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest { val

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-18 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1458133607 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -64,28 +64,89 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest { val

Re: [PR] KAFKA-16029: Fix "Unable to find FetchSessionHandler for node X" bug [kafka]

2024-01-18 Thread via GitHub
kirktrue commented on code in PR #15186: URL: https://github.com/apache/kafka/pull/15186#discussion_r1458125932 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -376,25 +376,21 @@ protected Map prepareCloseFetchSessi final

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-18 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1458121585 ## core/src/test/scala/unit/kafka/admin/ConsumerGroupCommandTest.scala: ## @@ -116,6 +123,18 @@ class ConsumerGroupCommandTest extends KafkaServerTestHarness { }

[jira] [Created] (KAFKA-16167) Fix PlaintextConsumerTest.testAutoCommitOnCloseAfterWakeup

2024-01-18 Thread Kirk True (Jira)
Kirk True created KAFKA-16167: - Summary: Fix PlaintextConsumerTest.testAutoCommitOnCloseAfterWakeup Key: KAFKA-16167 URL: https://issues.apache.org/jira/browse/KAFKA-16167 Project: Kafka Issue

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-18 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1458105856 ## core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala: ## @@ -102,6 +103,15 @@ object ConsumerGroupCommand extends Logging { parsedStates } + def

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-18 Thread via GitHub
lzyLuke commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1458081035 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

2024-01-18 Thread via GitHub
dongnuo123 commented on code in PR #15221: URL: https://github.com/apache/kafka/pull/15221#discussion_r1458085202 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -856,7 +899,8 @@ public boolean cleanupExpiredOffsets(String

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-18 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1458083463 ## clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupsOptions.java: ## @@ -34,13 +34,25 @@ public class ListConsumerGroupsOptions extends

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-18 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1458079066 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2229,7 +2229,7 @@ void handleResponse(AbstractResponse abstractResponse) {

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-18 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1458077276 ## clients/src/main/java/org/apache/kafka/clients/admin/ConsumerGroupListing.java: ## @@ -21,95 +21,111 @@ import java.util.Optional; Review Comment: Ohh hmm

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-18 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1458069279 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -104,9 +165,27 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest {

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-18 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1458068041 ## clients/src/main/java/org/apache/kafka/common/ConsumerGroupType.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-18 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1458067667 ## clients/src/main/java/org/apache/kafka/common/ConsumerGroupType.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15987: Refactor ReplicaManager code for transaction verification [kafka]

2024-01-18 Thread via GitHub
jolshan commented on code in PR #15087: URL: https://github.com/apache/kafka/pull/15087#discussion_r1458066834 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -717,17 +717,16 @@ class KafkaApis(val requestChannel: RequestChannel, val internalTopicsAllowed =

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

2024-01-18 Thread via GitHub
jolshan commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1457917435 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -875,30 +875,43 @@ private void maybeRemovePartitionEpoch(

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

2024-01-18 Thread via GitHub
jolshan commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1457917435 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -875,30 +875,43 @@ private void maybeRemovePartitionEpoch(

Re: [PR] KAFKA-14505; [7/N] Always materialize the most recent committed offset [kafka]

2024-01-18 Thread via GitHub
jolshan commented on code in PR #15183: URL: https://github.com/apache/kafka/pull/15183#discussion_r1458064289 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java: ## @@ -92,30 +117,34 @@ public boolean equals(Object o) {

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-18 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1458061363 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -9616,47 +9618,76 @@ public void testListGroups() {

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-18 Thread via GitHub
rreddy-22 commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1458058459 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,19 +453,36 @@ public Group group(String groupId, long

Re: [PR] KAFKA-15811: Enhance request context with client socket port information (KIP-714) [kafka]

2024-01-18 Thread via GitHub
apoorvmittal10 commented on PR #15190: URL: https://github.com/apache/kafka/pull/15190#issuecomment-1899343398 > @apoorvmittal10 : Thanks for the PR. A couple of minor comments. Thanks for reviewing @junrao. I have addressed and replied to the comment. -- This is an automated

Re: [PR] KAFKA-15811: Enhance request context with client socket port information (KIP-714) [kafka]

2024-01-18 Thread via GitHub
apoorvmittal10 commented on code in PR #15190: URL: https://github.com/apache/kafka/pull/15190#discussion_r1458055273 ## server/src/test/java/org/apache/kafka/server/metrics/ClientMetricsTestUtils.java: ## @@ -59,6 +60,7 @@ public static RequestContext requestContext() throws

[PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-18 Thread via GitHub
apoorvmittal10 opened a new pull request, #15234: URL: https://github.com/apache/kafka/pull/15234 KIP-714 requires client instance cache in broker which should also have a time-based eviction policy where client instances which are not actively sending metrics should be evicted. KIP

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-18 Thread via GitHub
CalvinConfluent commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1458050364 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -140,6 +142,73 @@ class KRaftMetadataCache(val brokerId: Int) extends

[jira] [Commented] (KAFKA-16162) New created topics are unavailable after upgrading to 3.7

2024-01-18 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808378#comment-17808378 ] Proven Provenzano commented on KAFKA-16162: --- I have a PR [GitHub Pull Request

[jira] [Updated] (KAFKA-16162) New created topics are unavailable after upgrading to 3.7

2024-01-18 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Proven Provenzano updated KAFKA-16162: -- Affects Version/s: 3.7.0 > New created topics are unavailable after upgrading to 3.7

[jira] [Updated] (KAFKA-16162) New created topics are unavailable after upgrading to 3.7

2024-01-18 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Proven Provenzano updated KAFKA-16162: -- Priority: Blocker (was: Major) > New created topics are unavailable after upgrading

[PR] KAFKA-16166: Generify RetryWithToleranceOperator and ErrorReporter classes [kafka]

2024-01-18 Thread via GitHub
gharris1727 opened a new pull request, #15233: URL: https://github.com/apache/kafka/pull/15233 This is a follow-up to #15154 which propagates the generic type for ProcessingContext upward through all its call-sites. I decided to avoid generifying the WorkerTask and instead separate

[PR] KAFKA-16162: [WIP] [kafka]

2024-01-18 Thread via GitHub
pprovenzano opened a new pull request, #15232: URL: https://github.com/apache/kafka/pull/15232 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-18 Thread via GitHub
cmccabe commented on PR #15193: URL: https://github.com/apache/kafka/pull/15193#issuecomment-1899239682 I put this into a table in hopes that it will make it clearer. cc @mumrah -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (KAFKA-16166) Generify RetryWithToleranceOperator and ErrorReporter

2024-01-18 Thread Greg Harris (Jira)
Greg Harris created KAFKA-16166: --- Summary: Generify RetryWithToleranceOperator and ErrorReporter Key: KAFKA-16166 URL: https://issues.apache.org/jira/browse/KAFKA-16166 Project: Kafka Issue

[jira] [Resolved] (KAFKA-16087) Tasks dropping incorrect records when errors.tolerance=all and errors reported asynchronously due to data race

2024-01-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-16087. - Fix Version/s: 3.8.0 Resolution: Fixed > Tasks dropping incorrect records when

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-18 Thread via GitHub
gharris1727 merged PR #15154: URL: https://github.com/apache/kafka/pull/15154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-18 Thread via GitHub
gharris1727 commented on PR #15154: URL: https://github.com/apache/kafka/pull/15154#issuecomment-1899225769 Test failures appear unrelated, and connect:runtime passes for me locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-16159: MINOR - Correcting logs to debug telemetry reporter [kafka]

2024-01-18 Thread via GitHub
apoorvmittal10 commented on code in PR #15228: URL: https://github.com/apache/kafka/pull/15228#discussion_r1457965643 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -362,7 +362,7 @@ public long timeToNextUpdate(long

Re: [PR] KAFKA-16159: MINOR - Correcting logs to debug telemetry reporter [kafka]

2024-01-18 Thread via GitHub
apoorvmittal10 commented on code in PR #15228: URL: https://github.com/apache/kafka/pull/15228#discussion_r1457964560 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -379,6 +379,7 @@ public Optional> createRequest() {

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

2024-01-18 Thread via GitHub
jeffkbkim commented on code in PR #15221: URL: https://github.com/apache/kafka/pull/15221#discussion_r1457909168 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -685,6 +712,20 @@ private boolean

[jira] [Updated] (KAFKA-15843) Review consumer onPartitionsAssigned called with empty partitions

2024-01-18 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15843: --- Description: Legacy coordinator triggers onPartitionsAssigned with empty assignment (which

Re: [PR] KAFKA-16159: MINOR - Correcting logs to debug telemetry reporter [kafka]

2024-01-18 Thread via GitHub
philipnee commented on code in PR #15228: URL: https://github.com/apache/kafka/pull/15228#discussion_r1457945378 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -362,7 +362,7 @@ public long timeToNextUpdate(long

Re: [PR] KAFKA-16159: MINOR - Correcting logs to debug telemetry reporter [kafka]

2024-01-18 Thread via GitHub
philipnee commented on code in PR #15228: URL: https://github.com/apache/kafka/pull/15228#discussion_r1457944304 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -362,7 +362,7 @@ public long timeToNextUpdate(long

Re: [PR] KAFKA-16159: MINOR - Correcting logs to debug telemetry reporter [kafka]

2024-01-18 Thread via GitHub
philipnee commented on code in PR #15228: URL: https://github.com/apache/kafka/pull/15228#discussion_r1457941137 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -379,6 +379,7 @@ public Optional> createRequest() {

Re: [PR] KAFKA-15770: IQv2 must return immutable position [kafka]

2024-01-18 Thread via GitHub
mjsax commented on code in PR #15219: URL: https://github.com/apache/kafka/pull/15219#discussion_r1457939699 ## streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java: ## @@ -146,7 +146,7 @@ public static QueryResult handleBasicQueries(

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-18 Thread via GitHub
artemlivshits commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1457923250 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -140,6 +142,73 @@ class KRaftMetadataCache(val brokerId: Int) extends MetadataCache

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

2024-01-18 Thread via GitHub
jolshan commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1457917435 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -875,30 +875,43 @@ private void maybeRemovePartitionEpoch(

[PR] KAFKA-16164: Pre-Vote RPCs [part 1] [kafka]

2024-01-18 Thread via GitHub
ahuang98 opened a new pull request, #15231: URL: https://github.com/apache/kafka/pull/15231 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

2024-01-18 Thread via GitHub
jolshan commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1457913561 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -861,19 +861,9 @@ private void maybeUpdatePartitionEpoch(

Re: [PR] KAFKA-16085: Add metric value consolidated for topics on a broker for tiered storage. [kafka]

2024-01-18 Thread via GitHub
divijvaidya commented on PR #15133: URL: https://github.com/apache/kafka/pull/15133#issuecomment-1899108113 > @divijvaidya , since Satish is busy, could you help review this PR? We'd like to get it into v3.7.0 for the completion of KIP-963. Thanks. Sorry I have been busy with work

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-18 Thread via GitHub
mumrah commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1457908869 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -140,6 +142,73 @@ class KRaftMetadataCache(val brokerId: Int) extends MetadataCache with

[jira] [Resolved] (KAFKA-15807) Add support for compression/decompression of metrics

2024-01-18 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-15807. --- Resolution: Done > Add support for compression/decompression of metrics >

[jira] [Updated] (KAFKA-5863) Potential null dereference in DistributedHerder#reconfigureConnector()

2024-01-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-5863: --- Fix Version/s: 3.8.0 > Potential null dereference in DistributedHerder#reconfigureConnector() >

Re: [PR] KAFKA-5863: Avoid NPE when RestClient calls expecting no-content receive content. [kafka]

2024-01-18 Thread via GitHub
gharris1727 merged PR #13294: URL: https://github.com/apache/kafka/pull/13294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15811: Enhance request context with client socket port information (KIP-714) [kafka]

2024-01-18 Thread via GitHub
apoorvmittal10 commented on code in PR #15190: URL: https://github.com/apache/kafka/pull/15190#discussion_r145796 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -1140,9 +1141,9 @@ private[kafka] class Processor(

Re: [PR] KAFKA-15770: IQv2 must return immutable position [kafka]

2024-01-18 Thread via GitHub
vvcephei commented on code in PR #15219: URL: https://github.com/apache/kafka/pull/15219#discussion_r1457894664 ## streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java: ## @@ -146,7 +146,7 @@ public static QueryResult handleBasicQueries(

Re: [PR] KAFKA-5863: Avoid NPE when RestClient calls expecting no-content receive content. [kafka]

2024-01-18 Thread via GitHub
gharris1727 commented on PR #13294: URL: https://github.com/apache/kafka/pull/13294#issuecomment-1899079016 Test failures appear unrelated, and the connect and mirror tests pass locally for me. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-16159: MINOR - Removed debug log [kafka]

2024-01-18 Thread via GitHub
apoorvmittal10 commented on PR #15228: URL: https://github.com/apache/kafka/pull/15228#issuecomment-1899066505 > Thanks @apoorvmittal10 - Could you elaborate on the purpose of this log line? how important is it for the user to know about the "next update time"? I wonder if we could just

[jira] [Created] (KAFKA-16165) Consumer invalid transition on expired poll interval

2024-01-18 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-16165: -- Summary: Consumer invalid transition on expired poll interval Key: KAFKA-16165 URL: https://issues.apache.org/jira/browse/KAFKA-16165 Project: Kafka

Re: [PR] KAFKA-16159: MINOR - Removed debug log [kafka]

2024-01-18 Thread via GitHub
apoorvmittal10 commented on code in PR #15228: URL: https://github.com/apache/kafka/pull/15228#discussion_r1457875345 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -362,7 +362,6 @@ public long timeToNextUpdate(long

[PR] KAFKA-14616: Fix stray replica of recreated topics in KRaft mode [kafka]

2024-01-18 Thread via GitHub
cmccabe opened a new pull request, #15230: URL: https://github.com/apache/kafka/pull/15230 When a broker is down, and a topic is deleted, this will result in that broker seeing "stray replicas" the next time it starts up. These replicas contain data that used to be important, but which now

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-18 Thread via GitHub
OmniaGM commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1457856799 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-14505; [7/N] Always materialize the most recent committed offset [kafka]

2024-01-18 Thread via GitHub
jolshan commented on code in PR #15183: URL: https://github.com/apache/kafka/pull/15183#discussion_r1457832081 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -712,13 +712,14 @@ public void run() {

Re: [PR] KAFKA-14505; [7/N] Always materialize the most recent committed offset [kafka]

2024-01-18 Thread via GitHub
jolshan commented on code in PR #15183: URL: https://github.com/apache/kafka/pull/15183#discussion_r1457831330 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -918,7 +920,7 @@ public void replay(

Re: [PR] KAFKA-15594: Add version 3.6 to Kafka Streams system tests [kafka]

2024-01-18 Thread via GitHub
mjsax commented on PR #15151: URL: https://github.com/apache/kafka/pull/15151#issuecomment-1898982326 `trunk` was broken -- rebased. Also re-triggered system tests just to be sure: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/6038/ -- This is an automated message

[jira] [Commented] (KAFKA-16163) Constant resignation/reelection of controller when starting a single node in combined mode

2024-01-18 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808336#comment-17808336 ] Mickael Maison commented on KAFKA-16163: It looks like this behavior was introduced in

[jira] [Created] (KAFKA-16164) Pre-Vote

2024-01-18 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-16164: Summary: Pre-Vote Key: KAFKA-16164 URL: https://issues.apache.org/jira/browse/KAFKA-16164 Project: Kafka Issue Type: Improvement Reporter:

[jira] [Created] (KAFKA-16163) Constant resignation/reelection of controller when starting a single node in combined mode

2024-01-18 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-16163: -- Summary: Constant resignation/reelection of controller when starting a single node in combined mode Key: KAFKA-16163 URL: https://issues.apache.org/jira/browse/KAFKA-16163

Re: [PR] KAFKA-16131: Only update directoryIds if the metadata version supports DirectoryAssignment [kafka]

2024-01-18 Thread via GitHub
mjsax commented on PR #15197: URL: https://github.com/apache/kafka/pull/15197#issuecomment-1898958611 Thanks. The fix was pushed after I left my comment. Glad it's resolved. Yeah, I did expect that two overlapping PR got merged simultaneously. -- This is an automated message from

[jira] [Updated] (KAFKA-16092) Queues for Kafka

2024-01-18 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-16092: - Labels: queues-for-kafka (was: ) > Queues for Kafka > > >

Re: [PR] KAFKA-15727: Added KRaft support in AlterUserScramCredentialsRequestNotAuthorizedTest [kafka]

2024-01-18 Thread via GitHub
adixitconfluent commented on PR #15224: URL: https://github.com/apache/kafka/pull/15224#issuecomment-1898856832 As represented by the CLI screenshot in the PR description, the tests that have been changed are passing. However the build is failing. Adding a screenshot of no new test

Re: [PR] KAFKA-16113: Add committed and commit sensor to record metrics [kafka]

2024-01-18 Thread via GitHub
philipnee commented on code in PR #15210: URL: https://github.com/apache/kafka/pull/15210#discussion_r1457711259 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1547,6 +1553,29 @@ public String toString() { } }

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-18 Thread via GitHub
nizhikov commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1457709089 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-18 Thread via GitHub
nizhikov commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1457704867 ## checkstyle/import-control.xml: ## @@ -261,6 +261,10 @@ + + Review Comment: Do we really need this empty block? -- This is an

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-18 Thread via GitHub
nizhikov commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1457704365 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,6 +20,7 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-16107: Stop fetching while onPartitionsAssign completes [kafka]

2024-01-18 Thread via GitHub
C0urante commented on PR #15218: URL: https://github.com/apache/kafka/pull/15218#issuecomment-1898819047 @anurag-harness This looks like an accidentally-opened PR and it copies the title from https://github.com/apache/kafka/pull/15215, which may lead to some confusion. I've closed it for

Re: [PR] KAFKA-16107: Stop fetching while onPartitionsAssign completes [kafka]

2024-01-18 Thread via GitHub
C0urante closed pull request #15218: KAFKA-16107: Stop fetching while onPartitionsAssign completes URL: https://github.com/apache/kafka/pull/15218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] DO NOT MERGE: Isolate Connect OffsetsApiIntegrationTest [kafka]

2024-01-18 Thread via GitHub
C0urante commented on PR #15226: URL: https://github.com/apache/kafka/pull/15226#issuecomment-1898810463 Looks like isolating a single test suite removes the conditions that lead to flakiness. Closing in favor of https://github.com/apache/kafka/pull/15229 -- This is an automated message

  1   2   >