[jira] [Commented] (KAFKA-15929) Flaky test - testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress - TopicCommandIntegrationTest

2024-01-26 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811283#comment-17811283 ] Josep Prat commented on KAFKA-15929: I've seen another instance here:

Re: [PR] KAFKA-16032: Fixes for commit/fetch error handling [kafka]

2024-01-26 Thread via GitHub
dajac merged PR #15202: URL: https://github.com/apache/kafka/pull/15202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Re-add Uniform assignor to the default ones [kafka]

2024-01-26 Thread via GitHub
dajac commented on PR #15269: URL: https://github.com/apache/kafka/pull/15269#issuecomment-1912086537 @OmniaGM Thanks and no worries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: Uniformize error handling/transformation in GroupCoordinatorService [kafka]

2024-01-26 Thread via GitHub
dajac commented on code in PR #15196: URL: https://github.com/apache/kafka/pull/15196#discussion_r1467666272 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1098,30 +1054,36 @@ private static boolean

Re: [PR] MINOR: Uniformize error handling/transformation in GroupCoordinatorService [kafka]

2024-01-26 Thread via GitHub
dajac commented on code in PR #15196: URL: https://github.com/apache/kafka/pull/15196#discussion_r1467665236 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1099,29 +1055,48 @@ private static boolean

Re: [PR] MINOR: Uniformize error handling/transformation in GroupCoordinatorService [kafka]

2024-01-26 Thread via GitHub
dajac commented on code in PR #15196: URL: https://github.com/apache/kafka/pull/15196#discussion_r1467661730 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -524,37 +495,39 @@ public CompletableFuture listGroups(

Re: [PR] KAFKA-16196: Handle invalid whole value casts in the Cast transform gracefully [kafka]

2024-01-26 Thread via GitHub
yashmayya commented on PR #15267: URL: https://github.com/apache/kafka/pull/15267#issuecomment-1912078149 Merging to `trunk`, as the test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MINOR: Uniformize error handling/transformation in GroupCoordinatorService [kafka]

2024-01-26 Thread via GitHub
dajac commented on code in PR #15196: URL: https://github.com/apache/kafka/pull/15196#discussion_r1467662146 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -595,27 +568,17 @@ public CompletableFuture>

[jira] [Updated] (KAFKA-16196) Cast transform doesn't handle invalid whole value casts gracefully

2024-01-26 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya updated KAFKA-16196: --- Fix Version/s: 3.8.0 > Cast transform doesn't handle invalid whole value casts gracefully >

Re: [PR] KAFKA-16196: Handle invalid whole value casts in the Cast transform gracefully [kafka]

2024-01-26 Thread via GitHub
yashmayya merged PR #15267: URL: https://github.com/apache/kafka/pull/15267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Uniformize error handling/transformation in GroupCoordinatorService [kafka]

2024-01-26 Thread via GitHub
dajac commented on code in PR #15196: URL: https://github.com/apache/kafka/pull/15196#discussion_r1467658035 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -524,37 +495,39 @@ public CompletableFuture listGroups(

Re: [PR] MINOR: Uniformize error handling/transformation in GroupCoordinatorService [kafka]

2024-01-26 Thread via GitHub
dajac commented on code in PR #15196: URL: https://github.com/apache/kafka/pull/15196#discussion_r1467652655 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -444,21 +416,21 @@ public CompletableFuture heartbeat(

Re: [PR] MINOR: Uniformize error handling/transformation in GroupCoordinatorService [kafka]

2024-01-26 Thread via GitHub
dajac commented on code in PR #15196: URL: https://github.com/apache/kafka/pull/15196#discussion_r1467651194 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -360,14 +334,13 @@ public CompletableFuture joinGroup(

[jira] [Resolved] (KAFKA-14505) Implement TnxOffsetCommit API

2024-01-26 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14505. - Fix Version/s: 3.8.0 Resolution: Fixed > Implement TnxOffsetCommit API >

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

2024-01-26 Thread via GitHub
dajac merged PR #15221: URL: https://github.com/apache/kafka/pull/15221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

2024-01-26 Thread via GitHub
dajac commented on PR #15221: URL: https://github.com/apache/kafka/pull/15221#issuecomment-1912050490 Thanks, @jolshan! The last build looks good. I will merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] MINOR: Re-add Uniform assignor to the default ones [kafka]

2024-01-26 Thread via GitHub
dajac opened a new pull request, #15269: URL: https://github.com/apache/kafka/pull/15269 The uniform assignor got accidentally removed by https://github.com/apache/kafka/pull/15158. This patch adds it back. ### Committer Checklist (excluded from commit message) - [ ] Verify design

Re: [PR] MINOR: Re-add Uniform assignor to the default ones [kafka]

2024-01-26 Thread via GitHub
dajac commented on PR #15269: URL: https://github.com/apache/kafka/pull/15269#issuecomment-1912046377 @mimaison @OmniaGM Could you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-16157: fix topic recreation handling with offline disks [kafka]

2024-01-26 Thread via GitHub
gaurav-narula commented on code in PR #15263: URL: https://github.com/apache/kafka/pull/15263#discussion_r1467590251 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -874,7 +874,13 @@ class Partition(val topicPartition: TopicPartition, private def

Re: [PR] KAFKA-14589 [1/3] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-01-26 Thread via GitHub
showuon commented on PR #15256: URL: https://github.com/apache/kafka/pull/15256#issuecomment-1911978274 Will take a look next week. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16157: fix topic recreation handling with offline disks [kafka]

2024-01-26 Thread via GitHub
showuon commented on code in PR #15263: URL: https://github.com/apache/kafka/pull/15263#discussion_r1467584667 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -874,7 +874,13 @@ class Partition(val topicPartition: TopicPartition, private def

Re: [PR] KAFKA-16195: ignore metadata.log.dir failure in ZK mode [kafka]

2024-01-26 Thread via GitHub
gaurav-narula commented on PR #15262: URL: https://github.com/apache/kafka/pull/15262#issuecomment-1911962461 > I think the impact of this bug is that if there are more than 1 log dirs in ZK broker, and when the 1st of them is failed, we will shutdown the broker unexpectedly. But if

[jira] [Comment Edited] (KAFKA-16162) New created topics are unavailable after upgrading to 3.7

2024-01-26 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811236#comment-17811236 ] Gaurav Narula edited comment on KAFKA-16162 at 1/26/24 11:58 AM: -

[jira] [Commented] (KAFKA-16162) New created topics are unavailable after upgrading to 3.7

2024-01-26 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811236#comment-17811236 ] Gaurav Narula commented on KAFKA-16162: --- [~showuon] The controller's view of the logDirs is used

[jira] [Commented] (KAFKA-16162) New created topics are unavailable after upgrading to 3.7

2024-01-26 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811230#comment-17811230 ] Luke Chen commented on KAFKA-16162: --- You are right [~gnarula]. I agree the best fix should be

[jira] [Commented] (KAFKA-15776) Update delay timeout for DelayedRemoteFetch request

2024-01-26 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17811229#comment-17811229 ] Luke Chen commented on KAFKA-15776: --- Interesting thoughts. But I think if we allow multiple threads

[jira] [Updated] (KAFKA-16198) Reconciliation may lose partitions when topic metadata is delayed

2024-01-26 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-16198: --- Description: The current reconciliation code in `AsyncKafkaConsumer`s `MembershipManager`

[jira] [Created] (KAFKA-16198) Reconciliation may lose partitions when topic metadata is delayed

2024-01-26 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-16198: -- Summary: Reconciliation may lose partitions when topic metadata is delayed Key: KAFKA-16198 URL: https://issues.apache.org/jira/browse/KAFKA-16198 Project: Kafka

[jira] [Updated] (KAFKA-16197) Connect Worker poll timeout prints Consumer poll timeout specific warnings.

2024-01-26 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao updated KAFKA-16197: -- Description: When a Connect worker's poll timeout expires in Connect, the log lines that we see are:

[jira] [Updated] (KAFKA-16197) Connect Worker poll timeout prints Consumer poll timeout specific warnings.

2024-01-26 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao updated KAFKA-16197: -- Component/s: connect > Connect Worker poll timeout prints Consumer poll timeout specific warnings. >

[jira] [Created] (KAFKA-16197) Connect Worker poll timeout prints Consumer poll timeout specific warnings.

2024-01-26 Thread Sagar Rao (Jira)
Sagar Rao created KAFKA-16197: - Summary: Connect Worker poll timeout prints Consumer poll timeout specific warnings. Key: KAFKA-16197 URL: https://issues.apache.org/jira/browse/KAFKA-16197 Project: Kafka

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-01-26 Thread via GitHub
appchemist commented on PR #15225: URL: https://github.com/apache/kafka/pull/15225#issuecomment-1911631296 @benstopford Please if you can review and provide the feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

<    1   2