[jira] [Updated] (KAFKA-15143) MockFixedKeyProcessorContext is missing from test-utils

[ https://issues.apache.org/jira/browse/KAFKA-15143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15143: Labels: needs-kip (was: ) > MockFixedKeyProcessorContext is missing from test-utils >

[jira] [Assigned] (KAFKA-15143) MockFixedKeyProcessorContext is missing from test-utils

[ https://issues.apache.org/jira/browse/KAFKA-15143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-15143: --- Assignee: Shashwat Pandey > MockFixedKeyProcessorContext is missing from

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

florin-akermann commented on code in PR #15189: URL: https://github.com/apache/kafka/pull/15189#discussion_r1493075382 ## streams/src/test/java/org/apache/kafka/streams/integration/RelaxedNullKeyRequirementJoinTest.java: ## @@ -71,11 +71,21 @@ void afterEach() { @Test

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

florin-akermann commented on PR #15189: URL: https://github.com/apache/kafka/pull/15189#issuecomment-1949473525 > Thanks for the fix! Overall LGTM. Couple of comments. @mjsax Thank you for all the good points. I agree with all of them. However, first I would like to align on whether

Re: [PR] MINOR: Improve ListConsumerGroupTest.testListGroupCommand [kafka]

jolshan commented on code in PR #15382: URL: https://github.com/apache/kafka/pull/15382#discussion_r1492801866 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java: ## @@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum)

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

florin-akermann commented on code in PR #15189: URL: https://github.com/apache/kafka/pull/15189#discussion_r1493064669 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java: ## @@ -816,10 +816,12 @@ public void testWindowing() {

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

florin-akermann commented on code in PR #15189: URL: https://github.com/apache/kafka/pull/15189#discussion_r1493064669 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java: ## @@ -816,10 +816,12 @@ public void testWindowing() {

Re: [PR] KAFKA-16265: KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]

jolshan commented on code in PR #15384: URL: https://github.com/apache/kafka/pull/15384#discussion_r1493062297 ## clients/src/main/java/org/apache/kafka/clients/admin/ListTransactionsOptions.java: ## @@ -61,6 +62,11 @@ public ListTransactionsOptions

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

florin-akermann commented on code in PR #15189: URL: https://github.com/apache/kafka/pull/15189#discussion_r1493061626 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java: ## @@ -1363,6 +1365,16 @@ public void testWindowing() {

Re: [PR] KAFKA-16265: KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]

yyu1993 commented on code in PR #15384: URL: https://github.com/apache/kafka/pull/15384#discussion_r1493050657 ## clients/src/main/resources/common/message/ListTransactionsResponse.json: ## @@ -17,7 +17,8 @@ "apiKey": 66, "type": "response", "name":

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1493044453 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java: ## @@ -20,78 +20,225 @@ import kafka.admin.ConsumerGroupCommand; import

Re: [PR] KAFKA-16265: KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]

yyu1993 commented on code in PR #15384: URL: https://github.com/apache/kafka/pull/15384#discussion_r1493041438 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -1633,7 +1633,8 @@ default ListTransactionsResult listTransactions() { * coordinators

Re: [PR] KAFKA-16265: KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]

jolshan commented on code in PR #15384: URL: https://github.com/apache/kafka/pull/15384#discussion_r1493039266 ## clients/src/main/resources/common/message/ListTransactionsRequest.json: ## @@ -18,14 +18,18 @@ "type": "request", "listeners": ["zkBroker", "broker"],

Re: [PR] KAFKA-16265: KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]

jolshan commented on code in PR #15384: URL: https://github.com/apache/kafka/pull/15384#discussion_r1493024798 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -1633,7 +1633,8 @@ default ListTransactionsResult listTransactions() { * coordinators

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

florin-akermann commented on code in PR #15189: URL: https://github.com/apache/kafka/pull/15189#discussion_r1493006495 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java: ## @@ -816,10 +816,12 @@ public void testWindowing() {

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

florin-akermann commented on code in PR #15189: URL: https://github.com/apache/kafka/pull/15189#discussion_r1493006495 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java: ## @@ -816,10 +816,12 @@ public void testWindowing() {

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

florin-akermann commented on code in PR #15189: URL: https://github.com/apache/kafka/pull/15189#discussion_r1493006495 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java: ## @@ -816,10 +816,12 @@ public void testWindowing() {

Re: [PR] KAFKA-16202: Extra dot in error message in producer [kafka]

infantlikesprogramming commented on code in PR #15296: URL: https://github.com/apache/kafka/pull/15296#discussion_r1492998071 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -704,7 +704,7 @@ private void completeBatch(ProducerBatch batch,

Re: [PR] MINOR: Improve ListConsumerGroupTest.testListGroupCommand [kafka]

dajac commented on code in PR #15382: URL: https://github.com/apache/kafka/pull/15382#discussion_r1492992453 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java: ## @@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum) throws

Re: [PR] KAFKA-15770: IQv2 must return immutable position [kafka]

mjsax commented on PR #15219: URL: https://github.com/apache/kafka/pull/15219#issuecomment-1949323481 @lucasbru Updates this PR. -- When I started to work on this PR, I thought that using `synchronized` would not work, because locking/unlocking would not always be method-local. But you are

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

florin-akermann commented on code in PR #15189: URL: https://github.com/apache/kafka/pull/15189#discussion_r1492958285 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java: ## @@ -191,6 +191,10 @@ public void process(final Record record) {

Re: [PR] [Draft] KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]

jolshan closed pull request #14731: [Draft] KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest URL: https://github.com/apache/kafka/pull/14731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [Draft] KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]

jolshan commented on PR #14731: URL: https://github.com/apache/kafka/pull/14731#issuecomment-1949185760 Closing in favor of https://github.com/apache/kafka/pull/15384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-16265: KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]

yyu1993 commented on code in PR #15384: URL: https://github.com/apache/kafka/pull/15384#discussion_r1492876179 ## tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java: ## @@ -436,16 +436,25 @@ public String name() { @Override public void

Re: [PR] KAFKA-16265: KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]

yyu1993 commented on code in PR #15384: URL: https://github.com/apache/kafka/pull/15384#discussion_r1492875733 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -278,12 +278,13 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-16265: KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]

yyu1993 commented on code in PR #15384: URL: https://github.com/apache/kafka/pull/15384#discussion_r1492874583 ## clients/src/main/java/org/apache/kafka/clients/admin/ListTransactionsOptions.java: ## @@ -35,6 +35,7 @@ public class ListTransactionsOptions extends

Re: [PR] KAFKA-16265: KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]

jolshan commented on code in PR #15384: URL: https://github.com/apache/kafka/pull/15384#discussion_r1492849366 ## tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java: ## @@ -436,16 +436,25 @@ public String name() { @Override public void

Re: [PR] MINOR: Improve ListConsumerGroupTest.testListGroupCommand [kafka]

rreddy-22 commented on code in PR #15382: URL: https://github.com/apache/kafka/pull/15382#discussion_r1492848158 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java: ## @@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum)

Re: [PR] KAFKA-16265: KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]

jolshan commented on code in PR #15384: URL: https://github.com/apache/kafka/pull/15384#discussion_r1492847691 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -278,12 +278,13 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

msn-tldr commented on PR #15323: URL: https://github.com/apache/kafka/pull/15323#issuecomment-1949077518 @ijuma thanks for flagging https://github.com/apache/kafka/pull/15376. @hachikuji Looks like this was going to add a test that tested the concurrent update of `Metadata`, and

Re: [PR] KAFKA-16265: KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]

jolshan commented on code in PR #15384: URL: https://github.com/apache/kafka/pull/15384#discussion_r1492846127 ## clients/src/main/java/org/apache/kafka/clients/admin/ListTransactionsOptions.java: ## @@ -35,6 +35,7 @@ public class ListTransactionsOptions extends

Re: [PR] MINOR: Improve ListConsumerGroupTest.testListGroupCommand [kafka]

rreddy-22 commented on code in PR #15382: URL: https://github.com/apache/kafka/pull/15382#discussion_r1492844519 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java: ## @@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum)

[PR] KAFKA-16226 Add test for concurrently updatingMetadata and fetching snapshot/cluster [kafka]

msn-tldr opened a new pull request, #15385: URL: https://github.com/apache/kafka/pull/15385 This is a follow-up to https://github.com/apache/kafka/pull/15323. Metadata is typically updated concurrently in the background thread, and the MetadataSnapshot/Cluster are fetched & used in

Re: [PR] KAFKA-15665: Enforce partition reassignment should complete when all target replicas are in ISR [kafka]

jolshan merged PR #15359: URL: https://github.com/apache/kafka/pull/15359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] KAFKA-16265: KIP-994 (Part 1) Minor Enhancements to ListTransactionsRequest [kafka]

yyu1993 opened a new pull request, #15384: URL: https://github.com/apache/kafka/pull/15384 Introduces a new filter in ListTransactionsRequest API. This enables caller to filter on transactions that have been running for longer than a certain duration of time. This PR includes the

[jira] [Commented] (KAFKA-16264) Expose `producer.id.expiration.check.interval.ms` as dynamic broker configuration

[ https://issues.apache.org/jira/browse/KAFKA-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818064#comment-17818064 ] Justine Olshan commented on KAFKA-16264: Hey [~jeqo] thanks for filing. I was also thinking

Re: [PR] MINOR: WakeupTrigger cleanup [kafka]

kirktrue closed pull request #14752: MINOR: WakeupTrigger cleanup URL: https://github.com/apache/kafka/pull/14752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] MINOR: Improve ListConsumerGroupTest.testListGroupCommand [kafka]

rreddy-22 commented on code in PR #15382: URL: https://github.com/apache/kafka/pull/15382#discussion_r1492799701 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java: ## @@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum)

Re: [PR] MINOR: Improve ListConsumerGroupTest.testListGroupCommand [kafka]

jolshan commented on code in PR #15382: URL: https://github.com/apache/kafka/pull/15382#discussion_r1492801866 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java: ## @@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum)

Re: [PR] MINOR: Improve ListConsumerGroupTest.testListGroupCommand [kafka]

rreddy-22 commented on code in PR #15382: URL: https://github.com/apache/kafka/pull/15382#discussion_r1492799701 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java: ## @@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum)

Re: [PR] MINOR: Improve ListConsumerGroupTest.testListGroupCommand [kafka]

jolshan commented on code in PR #15382: URL: https://github.com/apache/kafka/pull/15382#discussion_r1492798225 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java: ## @@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum)

Re: [PR] MINOR: Improve ListConsumerGroupTest.testListGroupCommand [kafka]

rreddy-22 commented on code in PR #15382: URL: https://github.com/apache/kafka/pull/15382#discussion_r1492788275 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java: ## @@ -123,42 +128,89 @@ public void testListGroupCommand(String quorum)

Re: [PR] KAFKA-14588 ZK configuration moved to ZkConfig [kafka]

nizhikov commented on PR #15075: URL: https://github.com/apache/kafka/pull/15075#issuecomment-1948922545 Hello @mimaison @ijuma This PR is ready for review. Please, take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Created] (KAFKA-16265) Add durationFilter to ListTransactionsRequest

Yang Yu created KAFKA-16265: --- Summary: Add durationFilter to ListTransactionsRequest Key: KAFKA-16265 URL: https://issues.apache.org/jira/browse/KAFKA-16265 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-16266) Introduce TransactionLastUpdateTimeMs tagged field to DescribeTransactionsResponse

Yang Yu created KAFKA-16266: --- Summary: Introduce TransactionLastUpdateTimeMs tagged field to DescribeTransactionsResponse Key: KAFKA-16266 URL: https://issues.apache.org/jira/browse/KAFKA-16266 Project:

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

mjsax commented on code in PR #14426: URL: https://github.com/apache/kafka/pull/14426#discussion_r1492754199 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java: ## @@ -609,17 +842,18 @@ public void testOrdering() {

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

mjsax commented on code in PR #14426: URL: https://github.com/apache/kafka/pull/14426#discussion_r1492754199 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java: ## @@ -609,17 +842,18 @@ public void testOrdering() {

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

mjsax commented on code in PR #14426: URL: https://github.com/apache/kafka/pull/14426#discussion_r1492754199 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java: ## @@ -609,17 +842,18 @@ public void testOrdering() {

Re: [PR] MINOR: add note about Kafka Streams feature for 3.7 release [kafka]

mjsax merged PR #15380: URL: https://github.com/apache/kafka/pull/15380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

lucasbru commented on PR #15372: URL: https://github.com/apache/kafka/pull/15372#issuecomment-1948876670 Hey @mjsax . This PR is right now waiting for @cadonna's review. If you have time, you could take a look to get into the 848 work. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

lucasbru commented on PR #15383: URL: https://github.com/apache/kafka/pull/15383#issuecomment-1948876369 Hey @mjsax . This PR is right now waiting for @cadonna's review. If you have time, you could take a look to get into the 848 work. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1492719703 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java: ## @@ -143,22 +312,134 @@ public void testListGroupCommand(String quorum)

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

dajac commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1492698285 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java: ## @@ -20,78 +20,225 @@ import kafka.admin.ConsumerGroupCommand; import

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1492695529 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java: ## @@ -20,78 +20,225 @@ import kafka.admin.ConsumerGroupCommand; import

Re: [PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

lianetm commented on PR #15372: URL: https://github.com/apache/kafka/pull/15372#issuecomment-1948611367 I like the last commit msg :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

lucasbru commented on code in PR #15383: URL: https://github.com/apache/kafka/pull/15383#discussion_r1492621621 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -419,6 +422,35 @@ public void testWakeupAfterNonEmptyFetch() {

Re: [PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

lianetm commented on code in PR #15383: URL: https://github.com/apache/kafka/pull/15383#discussion_r1492613876 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -419,6 +422,35 @@ public void testWakeupAfterNonEmptyFetch() {

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on PR #15364: URL: https://github.com/apache/kafka/pull/15364#issuecomment-1948535272 @jeffkbkim Thanks for your comments. I have addressed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492587334 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -251,195 +255,51 @@ private ConsumerGroupMember

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492585893 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -251,195 +255,51 @@ private ConsumerGroupMember

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492583068 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -170,72 +127,119 @@ public CurrentAssignmentBuilder

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492574501 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -779,7 +779,7 @@ private void maybeUpdateGroupState() {

[jira] [Assigned] (KAFKA-16009) Fix PlaintextConsumerTest.testMaxPollIntervalMsDelayInRevocation

[ https://issues.apache.org/jira/browse/KAFKA-16009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-16009: -- Assignee: Lucas Brutschy (was: Kirk True) > Fix

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492567552 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -346,10 +346,9 @@ public static Record newCurrentAssignmentRecord(

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492563558 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492559984 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492557819 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

dajac commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1492554402 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

lucasbru commented on code in PR #15383: URL: https://github.com/apache/kafka/pull/15383#discussion_r1492547506 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -384,7 +387,7 @@ public void testWakeupAfterEmptyFetch() {

Re: [PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

lucasbru commented on PR #15383: URL: https://github.com/apache/kafka/pull/15383#issuecomment-1948483411 @cadonna Could you please have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

lucasbru opened a new pull request, #15383: URL: https://github.com/apache/kafka/pull/15383 The wake-up mechanism in the new consumer is preventing from committing within a rebalance listener callback. The reason is that we are trying to register two wake-uppable actions at the same time.

Re: [PR] KAFKA-15561: Client support for new SubscriptionPattern based subscription [kafka]

Phuc-Hong-Tran commented on code in PR #15188: URL: https://github.com/apache/kafka/pull/15188#discussion_r1492453933 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json: ## @@ -35,6 +35,8 @@ "about": "-1 if it didn't change since the last

Re: [PR] KAFKA-15561: Client support for new SubscriptionPattern based subscription [kafka]

dajac commented on PR #15188: URL: https://github.com/apache/kafka/pull/15188#issuecomment-1948347606 I was wondering whether we should introduce a new error code to signal to the user that the regular expression is invalid. Otherwise, we would have to use the invalid request exception and

Re: [PR] KAFKA-15561: Client support for new SubscriptionPattern based subscription [kafka]

dajac commented on code in PR #15188: URL: https://github.com/apache/kafka/pull/15188#discussion_r1492422212 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json: ## @@ -35,6 +35,8 @@ "about": "-1 if it didn't change since the last heartbeat;

Re: [PR] KAFKA-15561: Client support for new SubscriptionPattern based subscription [kafka]

dajac commented on PR #15188: URL: https://github.com/apache/kafka/pull/15188#issuecomment-1948333168 > > @cadonna @lianetm, since we're supporting for both subscribe method using java.util.regex.Pattern and SubscriptionPattern, I think we should throw a illegal heartbeat exeption when

[jira] [Assigned] (KAFKA-6579) Consolidate window store and session store unit tests into a single class

[ https://issues.apache.org/jira/browse/KAFKA-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Sobeh reassigned KAFKA-6579: -- Assignee: (was: Ahmed Sobeh) > Consolidate window store and session store unit tests into

Re: [PR] KAFKA-15770: IQv2 must return immutable position [kafka]

lucasbru commented on code in PR #15219: URL: https://github.com/apache/kafka/pull/15219#discussion_r1492366369 ## streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStore.java: ## @@ -193,17 +194,22 @@ public void put(final

Re: [PR] MINOR: Improve ListConsumerGroupTest.testListGroupCommand [kafka]

nizhikov commented on PR #15382: URL: https://github.com/apache/kafka/pull/15382#issuecomment-1948181817 Hello, @dajac I will take a look, shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINOR: Added ACLs authorizer change during migration [kafka]

showuon merged PR #15333: URL: https://github.com/apache/kafka/pull/15333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15670: add "inter.broker.listener.name" config in KRaft controller config [kafka]

showuon merged PR #14631: URL: https://github.com/apache/kafka/pull/14631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

dajac commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1492178089 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java: ## @@ -20,78 +20,225 @@ import kafka.admin.ConsumerGroupCommand; import

Re: [PR] KAFKA-16230: Update verifiable_consumer.py to support KIP-848’s group protocol config [kafka]

lucasbru merged PR #15328: URL: https://github.com/apache/kafka/pull/15328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] MINOR: Improve ListConsumerGroupTest.testListGroupCommand [kafka]

dajac opened a new pull request, #15382: URL: https://github.com/apache/kafka/pull/15382 While reviewing https://github.com/apache/kafka/pull/15150, I found that our tests verifying the console output are really hard to read. Here is my proposal to make it better. ### Committer

Re: [PR] MINOR: Improve ListConsumerGroupTest.testListGroupCommand [kafka]

dajac commented on PR #15382: URL: https://github.com/apache/kafka/pull/15382#issuecomment-1948168236 @mimaison @nizhikov @rreddy-22 @jolshan Could you take a look when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

msn-tldr commented on PR #15323: URL: https://github.com/apache/kafka/pull/15323#issuecomment-1948142511 @hachikuji thanks for merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16165: Fix invalid transition on poll timer expiration [kafka]

lucasbru merged PR #15375: URL: https://github.com/apache/kafka/pull/15375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

lucasbru commented on code in PR #15372: URL: https://github.com/apache/kafka/pull/15372#discussion_r1492266247 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -265,6 +265,32 @@ class PlaintextConsumerTest extends BaseConsumerTest {

[jira] [Commented] (KAFKA-16264) Expose `producer.id.expiration.check.interval.ms` as dynamic broker configuration

[ https://issues.apache.org/jira/browse/KAFKA-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817867#comment-17817867 ] Jorge Esteban Quilcate Otoya commented on KAFKA-16264: -- cc [~jolshan] – as related

[jira] [Created] (KAFKA-16264) Expose `producer.id.expiration.check.interval.ms` as dynamic broker configuration

Jorge Esteban Quilcate Otoya created KAFKA-16264: Summary: Expose `producer.id.expiration.check.interval.ms` as dynamic broker configuration Key: KAFKA-16264 URL:

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

VictorvandenHoven commented on code in PR #14426: URL: https://github.com/apache/kafka/pull/14426#discussion_r1492090658 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java: ## @@ -609,17 +842,18 @@ public void testOrdering() {

Re: [PR] KAFKA-16167: re-enable PlaintextConsumerTest.testAutoCommitOnCloseAfterWakeup [kafka]

lucasbru merged PR #15358: URL: https://github.com/apache/kafka/pull/15358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: