chia7712 commented on PR #16049:
URL: https://github.com/apache/kafka/pull/16049#issuecomment-2128711390
> I rebased the PR!
I guess other PRs will encounter same failed tests, so please rebase code
for others too, thanks!
--
This is an automated message from the Apache Git Service
sjhajharia commented on PR #16049:
URL: https://github.com/apache/kafka/pull/16049#issuecomment-2128709392
Thanks for pointing out @chia7712
I rebased the PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-16826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar resolved KAFKA-16826.
---
Fix Version/s: 3.8.0
Resolution: Fixed
> Integrate Native Kafka Docker Image with github Acti
chia7712 commented on PR #16049:
URL: https://github.com/apache/kafka/pull/16049#issuecomment-2128703246
@sjhajharia Could you please rebase code to include #16044? It fixes a lot
of failed tests :)
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
omkreddy merged PR #16045:
URL: https://github.com/apache/kafka/pull/16045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
Manjunath created KAFKA-16835:
-
Summary: Add Support for consumer to read in commit order.
Key: KAFKA-16835
URL: https://issues.apache.org/jira/browse/KAFKA-16835
Project: Kafka
Issue Type: New F
kagarwal06 commented on code in PR #16045:
URL: https://github.com/apache/kafka/pull/16045#discussion_r1612932172
##
.github/workflows/docker_promote.yml:
##
@@ -19,10 +19,10 @@ on:
workflow_dispatch:
inputs:
rc_docker_image:
-description: RC docker image
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1612931258
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
sjhajharia commented on PR #16021:
URL: https://github.com/apache/kafka/pull/16021#issuecomment-2128693543
Hey @chia7712
I have created 5 sub-PRs to address the cleanup module-by-module.
- https://github.com/apache/kafka/pull/16049: Clients Module
- https://github.com/apache/kafka/
sjhajharia opened a new pull request, #16067:
URL: https://github.com/apache/kafka/pull/16067
## What
Code Cleanup in Misc Modules
## Changes
Some common changes include
- Replace the Arrays.asList() with Collections.singletonList() wherever
possible
- Cleaning up some
appchemist commented on PR #16043:
URL: https://github.com/apache/kafka/pull/16043#issuecomment-2128669455
> i really want to keep the network client delegate to just interfacing with
the network client, so i wonder if it would be a better design to handle the
metadata error in a separated
appchemist commented on PR #16043:
URL: https://github.com/apache/kafka/pull/16043#issuecomment-2128663846
Hi @philipnee, Thank you for review!
> do you think we can put the metadata error in the ConsumerNetworkThread
and have an exception handler to relay the error back to the user v
chia7712 commented on PR #15863:
URL: https://github.com/apache/kafka/pull/15863#issuecomment-2128658669
@gaurav-narula this PR adopt your solution
(https://github.com/apache/kafka/pull/15863#discussion_r1590313031) now, so it
would be great to have your reviews before merging. thanks
--
chia7712 commented on PR #15863:
URL: https://github.com/apache/kafka/pull/15863#issuecomment-2128654632
@chiacyu Could you please rebase PR to run QA with newest code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
chia7712 commented on code in PR #16010:
URL: https://github.com/apache/kafka/pull/16010#discussion_r1612892755
##
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##
@@ -206,12 +206,20 @@ Found problem:
@Test
def testFormatSucceedsIfAllDirectoriesAreAvailable
artemlivshits commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1612863802
##
server-common/src/main/java/org/apache/kafka/server/common/TestFeatureVersion.java:
##
@@ -21,16 +21,17 @@
public enum TestFeatureVersion implements Feature
sjhajharia opened a new pull request, #16066:
URL: https://github.com/apache/kafka/pull/16066
## What
Code Cleanup in Connect Module
## Changes
Some common changes include
- Replace the Arrays.asList() with Collections.singletonList() wherever
possible
- Cleaning up so
sjhajharia opened a new pull request, #16065:
URL: https://github.com/apache/kafka/pull/16065
## What
Code Cleanup in metadata Module
## Changes
Some common changes include
- Replace the Arrays.asList() with Collections.singletonList() wherever
possible
- Cleaning up s
ableegoldman commented on code in PR #16052:
URL: https://github.com/apache/kafka/pull/16052#discussion_r1612714758
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java:
##
@@ -0,0 +1,478 @@
+/*
+ * Licensed to the Apache Softw
chia7712 commented on code in PR #16064:
URL: https://github.com/apache/kafka/pull/16064#discussion_r1612751256
##
core/src/main/scala/kafka/tools/DumpLogSegments.scala:
##
@@ -651,4 +651,17 @@ object DumpLogSegments {
def checkArgs(): Unit = CommandLineUtils.checkRequiredA
FrankYang0529 opened a new pull request, #16064:
URL: https://github.com/apache/kafka/pull/16064
We need a replacement in order to complete
https://issues.apache.org/jira/browse/KAFKA-14579 in kafak 4.0
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
[
https://issues.apache.org/jira/browse/KAFKA-16834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jianbin Chen updated KAFKA-16834:
-
Description:
Transform it into the following output, which is easier for users to understand
an
funky-eyes opened a new pull request, #16063:
URL: https://github.com/apache/kafka/pull/16063
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
[
https://issues.apache.org/jira/browse/KAFKA-16834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jianbin Chen updated KAFKA-16834:
-
Summary: add the reason for the failure of PartitionRegistration#toRecord
(was: add PartitionRe
Jianbin Chen created KAFKA-16834:
Summary: add PartitionRegistration#toRecord loss info
Key: KAFKA-16834
URL: https://issues.apache.org/jira/browse/KAFKA-16834
Project: Kafka
Issue Type: Wish
[
https://issues.apache.org/jira/browse/KAFKA-16583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16583:
--
Fix Version/s: 3.8.0
3.7.1
> Update from 3.4.0 to 3.7.0 image write failed in Kraft
[
https://issues.apache.org/jira/browse/KAFKA-16583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16583:
--
Priority: Blocker (was: Major)
> Update from 3.4.0 to 3.7.0 image write failed in Kraft mode
> --
showuon commented on PR #15751:
URL: https://github.com/apache/kafka/pull/15751#issuecomment-2128463581
Thanks for fixing this issue. I'll take a look this week or next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on PR #15428:
URL: https://github.com/apache/kafka/pull/15428#issuecomment-2128459494
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
[
https://issues.apache.org/jira/browse/KAFKA-16583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849145#comment-17849145
]
Jianbin Chen commented on KAFKA-16583:
--
I want to know when this PR can be merged,
ahuang98 opened a new pull request, #16062:
URL: https://github.com/apache/kafka/pull/16062
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testin
jeqo commented on code in PR #15893:
URL: https://github.com/apache/kafka/pull/15893#discussion_r1612459168
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##
@@ -202,6 +204,225 @@ public Object valueFrom(Map map) {
re
jeqo commented on code in PR #15893:
URL: https://github.com/apache/kafka/pull/15893#discussion_r1612458345
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##
@@ -202,6 +204,225 @@ public Object valueFrom(Map map) {
re
cmccabe opened a new pull request, #16061:
URL: https://github.com/apache/kafka/pull/16061
commit db118aba6fbddfc607c6ef653f9965a5a73c778a (HEAD -> return-to-monkey,
cmccabe/return-to-monkey, trunk)
Author: Colin P. McCabe
Date: Thu May 23 16:11:24 2024 -0700
return to co
gharris1727 commented on PR #16051:
URL: https://github.com/apache/kafka/pull/16051#issuecomment-2128174644
> > Something is wrong with the build of this commit
>
> There still seems to be some issue with builds 🤔
> [2024-05-23T21:45:16.078Z] Could not stop
org.gradle.internal.a
junrao commented on code in PR #15993:
URL: https://github.com/apache/kafka/pull/15993#discussion_r1612451041
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -55,16 +61,40 @@ public class LeaderEpochFileCache {
/**
*
[
https://issues.apache.org/jira/browse/KAFKA-16833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alyssa Huang updated KAFKA-16833:
-
Summary: Cluster missing topicIds from equals and hashCode, PartitionInfo
missing equals and has
jolshan commented on PR #16051:
URL: https://github.com/apache/kafka/pull/16051#issuecomment-2128160293
Any ideas about
```
[2024-05-23T21:45:16.078Z] > Task :connect:runtime:test
[2024-05-23T21:45:16.078Z] Could not stop
org.gradle.internal.actor.internal.DefaultActorFacto
jolshan commented on PR #16051:
URL: https://github.com/apache/kafka/pull/16051#issuecomment-2128158835
> Something is wrong with the build of this commit
There still seems to be some issue with builds 🤔
--
This is an automated message from the Apache Git Service.
To respond to the mes
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1612404062
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -109,6 +111,52 @@ object StorageTool extends Logging {
}
}
+ private def validateMetadataVersion(
ableegoldman commented on code in PR #16052:
URL: https://github.com/apache/kafka/pull/16052#discussion_r1612405084
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java:
##
@@ -0,0 +1,478 @@
+/*
+ * Licensed to the Apache Softw
ableegoldman commented on code in PR #16052:
URL: https://github.com/apache/kafka/pull/16052#discussion_r1612403956
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java:
##
@@ -0,0 +1,478 @@
+/*
+ * Licensed to the Apache Softw
mjsax commented on code in PR #16041:
URL: https://github.com/apache/kafka/pull/16041#discussion_r1612395523
##
streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/StateStoreMetrics.java:
##
@@ -451,6 +455,23 @@ public static void addNumOpenIteratorsGauge(fina
Alyssa Huang created KAFKA-16833:
Summary: PartitionInfo missing equals and hashCode methods
Key: KAFKA-16833
URL: https://issues.apache.org/jira/browse/KAFKA-16833
Project: Kafka
Issue Type
apourchet closed pull request #16056: KAFKA-15045: Fix RackAwareTaskAssignorTest
URL: https://github.com/apache/kafka/pull/16056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
gharris1727 commented on code in PR #16051:
URL: https://github.com/apache/kafka/pull/16051#discussion_r1612358604
##
Jenkinsfile:
##
@@ -36,6 +36,12 @@ def doTest(env, target = "test") {
junit '**/build/test-results/**/TEST-*.xml'
}
+def runTestOnDevBranch(env) {
+ if (!
gharris1727 commented on PR #16051:
URL: https://github.com/apache/kafka/pull/16051#issuecomment-2128068313
Looking at the latest CI run, the 11 build took ~15 minutes, the 17 build
took 11 minutes, and the 8 and 21 builds are continuing as normal.
In the last 28 days, Kafka has run:
ijuma commented on code in PR #16051:
URL: https://github.com/apache/kafka/pull/16051#discussion_r1612342902
##
Jenkinsfile:
##
@@ -36,6 +36,12 @@ def doTest(env, target = "test") {
junit '**/build/test-results/**/TEST-*.xml'
}
+def runTestOnDevBranch(env) {
+ if (!isChan
ijuma commented on code in PR #16051:
URL: https://github.com/apache/kafka/pull/16051#discussion_r1612341398
##
Jenkinsfile:
##
@@ -36,6 +36,12 @@ def doTest(env, target = "test") {
junit '**/build/test-results/**/TEST-*.xml'
}
+def runTestOnDevBranch(env) {
+ if (!isChan
gharris1727 commented on code in PR #16051:
URL: https://github.com/apache/kafka/pull/16051#discussion_r1612327285
##
Jenkinsfile:
##
@@ -36,6 +36,12 @@ def doTest(env, target = "test") {
junit '**/build/test-results/**/TEST-*.xml'
}
+def runTestOnDevBranch(env) {
+ if (!
chia7712 commented on PR #16056:
URL: https://github.com/apache/kafka/pull/16056#issuecomment-2128047643
@apourchet Thanks for your contribution. The failed test is already fixed by
#16044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
[
https://issues.apache.org/jira/browse/KAFKA-16828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16828.
Fix Version/s: 3.8.0
Resolution: Fixed
> RackAwareTaskAssignorTest failed
> ---
chia7712 merged PR #16044:
URL: https://github.com/apache/kafka/pull/16044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1612321070
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -109,6 +111,52 @@ object StorageTool extends Logging {
}
}
+ private def validateMetadataVersion(
[
https://issues.apache.org/jira/browse/KAFKA-15630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Sadanala reassigned KAFKA-15630:
---
Assignee: Ganesh Sadanala
> Improve documentation of offset.lag.max
> -
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1612319940
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -109,6 +111,52 @@ object StorageTool extends Logging {
}
}
+ private def validateMetadataVersion(
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1612319940
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -109,6 +111,52 @@ object StorageTool extends Logging {
}
}
+ private def validateMetadataVersion(
gharris1727 commented on PR #16051:
URL: https://github.com/apache/kafka/pull/16051#issuecomment-2128037835
> It's rare that there is an issue with only java 11/17 and not 8 or 21.
I've most frequently seen issues with scala 2.12 and that's on the java 8
build.
I agree, and that was
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1612314478
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -141,6 +189,9 @@ object StorageTool extends Logging {
formatParser.addArgument("--release-version", "-r
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1612314269
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -109,6 +105,51 @@ object StorageTool extends Logging {
}
}
+ private def validateMetadataVersion(
jeffkbkim opened a new pull request, #16060:
URL: https://github.com/apache/kafka/pull/16060
We don't log any error logs when a coordinator event fails to execute to
completion. This patch adds some logging
### Committer Checklist (excluded from commit message)
- [ ] Verify design
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1612314113
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -156,16 +200,27 @@ object StorageTool extends Logging {
def getMetadataVersion(
namespace: Namespa
jolshan commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1612313415
##
core/src/main/scala/kafka/server/BrokerFeatures.scala:
##
@@ -75,16 +76,19 @@ object BrokerFeatures extends Logging {
}
def defaultSupportedFeatures(unstable
jolshan commented on PR #16051:
URL: https://github.com/apache/kafka/pull/16051#issuecomment-2128028213
> I think it would be worth running the compile steps for these older
versions (i.e., "doValidation"). As far as I know, those steps only fail if
there's actually a problem.
It's r
[
https://issues.apache.org/jira/browse/KAFKA-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849121#comment-17849121
]
Alyssa Huang commented on KAFKA-16530:
--
In the case the leader is removed from the
junrao commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1602305075
##
server-common/src/main/java/org/apache/kafka/server/common/TestFeatureVersion.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ijuma commented on code in PR #16051:
URL: https://github.com/apache/kafka/pull/16051#discussion_r1612302312
##
Jenkinsfile:
##
@@ -36,6 +36,12 @@ def doTest(env, target = "test") {
junit '**/build/test-results/**/TEST-*.xml'
}
+def runTestOnDevBranch(env) {
+ if (!isChan
dongnuo123 commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1612296899
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4424,14 +4441,113 @@ private ConsumerGroupMember
validateCon
[
https://issues.apache.org/jira/browse/KAFKA-16516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe reassigned KAFKA-16516:
Assignee: Colin McCabe (was: José Armando GarcÃa Sancio)
> Fix the controller node provi
jeffkbkim opened a new pull request, #16059:
URL: https://github.com/apache/kafka/pull/16059
Otherwise, we default the write limit to the min buffer size of 16384 for
the write limit. This causes the coordinator to threw RecordTooLargeException
even when it's under the 1MB max batch size li
dongnuo123 opened a new pull request, #16057:
URL: https://github.com/apache/kafka/pull/16057
This patch implements the LeaveGroup api to the consumer groups that are in
the mixed mode.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
Dongnuo Lyu created KAFKA-16832:
---
Summary: LeaveGroup API for upgrading ConsumerGroup
Key: KAFKA-16832
URL: https://issues.apache.org/jira/browse/KAFKA-16832
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-16832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongnuo Lyu reassigned KAFKA-16832:
---
Assignee: Dongnuo Lyu
> LeaveGroup API for upgrading ConsumerGroup
> --
highbolder closed pull request #16039: Update dependencies
URL: https://github.com/apache/kafka/pull/16039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
apourchet opened a new pull request, #16056:
URL: https://github.com/apache/kafka/pull/16056
Some unnecessary changes to RackAwareTaskAssignor broke the tests, this PR
reverts those changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
gharris1727 merged PR #15469:
URL: https://github.com/apache/kafka/pull/15469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
gharris1727 commented on PR #15469:
URL: https://github.com/apache/kafka/pull/15469#issuecomment-2127953424
Here's the final performance changes:
Benchmark | Before | Before Error | After | After Error | Speedup
-- | -- | -- | -- | -- | --
ValuesBenchmark.testConvertToBoolean | 1
ableegoldman closed pull request #16055: Revert "KAFKA-15045: (KIP-924 pt. 10)
Topic partition rack annotation simplified (#16034)"
URL: https://github.com/apache/kafka/pull/16055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ableegoldman commented on PR #16055:
URL: https://github.com/apache/kafka/pull/16055#issuecomment-2127922285
It's actually https://github.com/apache/kafka/pull/15972 that broke this
test, closing this
--
This is an automated message from the Apache Git Service.
To respond to the message,
ableegoldman commented on PR #15972:
URL: https://github.com/apache/kafka/pull/15972#issuecomment-2127918475
Yep, just noticed this. Sorry about that. We're taking a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dajac commented on PR #15883:
URL: https://github.com/apache/kafka/pull/15883#issuecomment-2127912971
We will use a different approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
dajac closed pull request #15883: MINOR: Rewrite
OptimizedUniformAssignmentBuilder#assignStickyPartitions to improve performance
URL: https://github.com/apache/kafka/pull/15883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dajac commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-2127911871
We will start this work from scratch. Closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dajac closed pull request #14327: KAFKA-14517: Implement regex subscriptions
URL: https://github.com/apache/kafka/pull/14327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dajac commented on PR #15286:
URL: https://github.com/apache/kafka/pull/15286#issuecomment-2127911151
This does not seem necessary any more. Closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dajac closed pull request #15286: MINOR: KIP-848 Uniform Assignor Bugs
URL: https://github.com/apache/kafka/pull/15286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
ableegoldman opened a new pull request, #16055:
URL: https://github.com/apache/kafka/pull/16055
This reverts commit 93238ae312ef7bea79160e59bb7a06623cc94a1b.
[This PR](https://github.com/apache/kafka/pull/16034) broke the
RackAwareAssignorTest, so I am reverting it while we figure out
ableegoldman commented on PR #16034:
URL: https://github.com/apache/kafka/pull/16034#issuecomment-2127905750
Ah shoot, I was looking at the wrong test results, this is actually breaking
RackAwareTaskAssignorTest. I'll revert this and we can fix the failing test in
the resubmitted PR
--
T
ableegoldman merged PR #16034:
URL: https://github.com/apache/kafka/pull/16034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
Jeff Kim created KAFKA-16831:
Summary: CoordinatorRuntime should initialize MemoryRecordsBuilder
with max batch size write limit
Key: KAFKA-16831
URL: https://issues.apache.org/jira/browse/KAFKA-16831
Pro
apoorvmittal10 commented on PR #16054:
URL: https://github.com/apache/kafka/pull/16054#issuecomment-2127858693
@dajac @omkreddy @AndrewJSchofield Please review, we can merge post 3.8
branch cut.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
apoorvmittal10 opened a new pull request, #16054:
URL: https://github.com/apache/kafka/pull/16054
Abstracted code for 2 classes `ConsumerGroup` and `ConsumerGroupMember` to
`AbstractGroup` and `GroupMember` respectively. The new abstract classes are
created to share common functionality wit
junrao commented on code in PR #15825:
URL: https://github.com/apache/kafka/pull/15825#discussion_r1612186225
##
core/src/main/scala/kafka/server/DelayedFetch.scala:
##
@@ -103,7 +103,7 @@ class DelayedFetch(
// We will not force complete the fetch request if a
C0urante commented on code in PR #16001:
URL: https://github.com/apache/kafka/pull/16001#discussion_r1612176138
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -1039,21 +1039,42 @@ public static List>
reverseTransform(String connName
C0urante opened a new pull request, #16053:
URL: https://github.com/apache/kafka/pull/16053
[Jira](https://issues.apache.org/jira/browse/KAFKA-9228)
This uses a much simpler approach than the one pursued in
https://github.com/apache/kafka/pull/16001. Once task configs are detected for
chia7712 commented on PR #16020:
URL: https://github.com/apache/kafka/pull/16020#issuecomment-2127829943
@brandboat Thanks for your contribution. Those supports should be removed
from 4.0.0. I have filed ticket
(https://issues.apache.org/jira/browse/KAFKA-16830) for you. Please feel free
Chia-Ping Tsai created KAFKA-16830:
--
Summary: Remove the scala version formatters support
Key: KAFKA-16830
URL: https://issues.apache.org/jira/browse/KAFKA-16830
Project: Kafka
Issue Type: I
[
https://issues.apache.org/jira/browse/KAFKA-16795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16795.
Resolution: Fixed
> Fix broken compatibility in kafka.tools.NoOpMessageFormatter,
> kafka
chia7712 merged PR #16020:
URL: https://github.com/apache/kafka/pull/16020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mumrah commented on PR #16051:
URL: https://github.com/apache/kafka/pull/16051#issuecomment-2127820090
I think it would be worth running the compile steps for these older versions
(i.e., "doValidation"). As far as I know, those steps only fail if there's
actually a problem.
--
This is an
1 - 100 of 260 matches
Mail list logo
