mcmmining commented on PR #14881:
URL: https://github.com/apache/kafka/pull/14881#issuecomment-2030156545
> - Extended `LogManager.getOrCreateLog` to accept the target directory's
ID. At this level, we assume that the directory id is online to keep
`getOrCreateLog` simple.
> - Fixed `Lo
rondagostino merged PR #14881:
URL: https://github.com/apache/kafka/pull/14881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1422522894
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,25 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def createLog
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1421567480
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -123,7 +123,9 @@ class LogManager(logDirs: Seq[File],
}
private val dirLocks = lockLogDirs(liveLogDirs)
pprovenzano commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1421489097
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -123,7 +123,9 @@ class LogManager(logDirs: Seq[File],
}
private val dirLocks = lockLogDirs(liveLogD
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1421190145
##
metadata/src/main/java/org/apache/kafka/image/TopicDelta.java:
##
@@ -147,7 +149,7 @@ public LocalReplicaChanges localChanges(int brokerId) {
);
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1421189818
##
metadata/src/main/java/org/apache/kafka/image/TopicDelta.java:
##
@@ -158,11 +160,21 @@ public LocalReplicaChanges localChanges(int brokerId) {
OmniaGM commented on PR #14881:
URL: https://github.com/apache/kafka/pull/14881#issuecomment-1848035026
> Checkstyle failed: Here is the diff to fix
>
> ```
> diff --git a/metadata/src/main/java/org/apache/kafka/image/TopicDelta.java
b/metadata/src/main/java/org/apache/kafka/image/
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420887859
##
metadata/src/main/java/org/apache/kafka/image/TopicDelta.java:
##
@@ -147,7 +149,7 @@ public LocalReplicaChanges localChanges(int brokerId) {
);
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420879420
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2626,8 +2601,16 @@ class ReplicaManager(val config: KafkaConfig,
localLeaders.forKeyValue { (tp, i
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420878757
##
metadata/src/main/java/org/apache/kafka/image/TopicDelta.java:
##
@@ -158,11 +160,21 @@ public LocalReplicaChanges localChanges(int brokerId) {
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420878519
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2626,8 +2601,16 @@ class ReplicaManager(val config: KafkaConfig,
localLeaders.forKeyValue { (tp, i
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420873183
##
metadata/src/main/java/org/apache/kafka/image/TopicDelta.java:
##
@@ -158,11 +160,21 @@ public LocalReplicaChanges localChanges(int brokerId) {
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420866994
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2626,8 +2601,16 @@ class ReplicaManager(val config: KafkaConfig,
localLeaders.forKeyValue { (tp, in
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420746154
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2626,8 +2601,16 @@ class ReplicaManager(val config: KafkaConfig,
localLeaders.forKeyValue { (tp, i
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420734792
##
metadata/src/main/java/org/apache/kafka/image/TopicDelta.java:
##
@@ -158,11 +160,21 @@ public LocalReplicaChanges localChanges(int brokerId) {
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420691621
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2626,8 +2601,12 @@ class ReplicaManager(val config: KafkaConfig,
localLeaders.forKeyValue { (tp, in
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420732241
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2626,8 +2601,12 @@ class ReplicaManager(val config: KafkaConfig,
localLeaders.forKeyValue { (tp, i
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420729137
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2666,8 +2648,8 @@ class ReplicaManager(val config: KafkaConfig,
// is unavailable. This is
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420691621
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2626,8 +2601,12 @@ class ReplicaManager(val config: KafkaConfig,
localLeaders.forKeyValue { (tp, in
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420675158
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2666,8 +2648,8 @@ class ReplicaManager(val config: KafkaConfig,
// is unavailable. This is
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420552612
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2666,8 +2648,8 @@ class ReplicaManager(val config: KafkaConfig,
// is unavailable. This is
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420552612
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2666,8 +2648,8 @@ class ReplicaManager(val config: KafkaConfig,
// is unavailable. This is
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1420503147
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2666,8 +2648,8 @@ class ReplicaManager(val config: KafkaConfig,
// is unavailable. This is
OmniaGM commented on PR #14881:
URL: https://github.com/apache/kafka/pull/14881#issuecomment-1846975734
> @OmniaGM can you resolve the conflicts here?
resolved now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rondagostino commented on PR #14881:
URL: https://github.com/apache/kafka/pull/14881#issuecomment-1846430171
@OmniaGM can you resolve the conflicts here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1418966437
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,26 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def createLog
soarez commented on PR #14881:
URL: https://github.com/apache/kafka/pull/14881#issuecomment-1841561078
@rondagostino @cmccabe @pprovenzano PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1416239117
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -93,6 +93,54 @@ class LogManagerTest {
log.appendAsLeader(TestUtils.singletonRecords("test".getByt
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1416236550
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -991,18 +997,29 @@ class LogManager(logDirs: Seq[File],
* @param isNew Whether the replica should have exist
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1416235526
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,26 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def createLogI
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415898460
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,26 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def createLog
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415898460
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,26 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def createLog
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415748253
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,26 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def createLogI
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415655849
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,25 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def createLogI
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415618371
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2643,6 +2645,17 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ private def getAssign
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415612624
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2741,6 +2755,18 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ private def mayUpdate
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415612007
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2741,6 +2755,18 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ private def mayUpdate
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415611267
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -123,14 +123,19 @@ class LogManager(logDirs: Seq[File],
}
private val dirLocks = lockLogDirs(liveLogDir
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415609251
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,25 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def createLog
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415609251
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,25 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def createLog
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415604987
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,25 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def createLog
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1413201855
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,25 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def createLogI
OmniaGM opened a new pull request, #14881:
URL: https://github.com/apache/kafka/pull/14881
- Extended `LogManager.getOrCreateLog` to accept the target directory's ID.
At this level, we assume that the directory id is online to keep
`getOrCreateLog` simple.
- Fixed `LogManager.handleLogD
OmniaGM closed pull request #14880: KAFKA-15365: Broker-side replica management
changes
URL: https://github.com/apache/kafka/pull/14880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
OmniaGM opened a new pull request, #14880:
URL: https://github.com/apache/kafka/pull/14880
- Extended `LogManager.getOrCreateLog` to accept the target directory's ID.
At this level, we assume that the directory id is online to keep
`getOrCreateLog` simple.
- Fixed `LogManager.handleLogD
46 matches
Mail list logo
