jlprat commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1718131899
##
raft/src/main/java/org/apache/kafka/raft/internals/RequestSender.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
cmccabe commented on PR #16626:
URL: https://github.com/apache/kafka/pull/16626#issuecomment-2243727360
committed, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
cmccabe closed pull request #16626: KAFKA-16535; Implement KRaft add voter
handling
URL: https://github.com/apache/kafka/pull/16626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
cmccabe commented on PR #16626:
URL: https://github.com/apache/kafka/pull/16626#issuecomment-2243717429
@jsancio
`./raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java.orig`
still seems to be part of the PR. Can you remove it?
--
This is an automated message from th
jsancio commented on PR #16626:
URL: https://github.com/apache/kafka/pull/16626#issuecomment-2243468267
The test failures look unrelated to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jsancio commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1685046009
##
raft/src/main/java/org/apache/kafka/raft/internals/AddVoterHandler.java:
##
@@ -0,0 +1,383 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
cmccabe commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1685009137
##
raft/src/main/java/org/apache/kafka/raft/internals/AddVoterHandler.java:
##
@@ -0,0 +1,383 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
cmccabe commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1685007655
##
raft/src/main/java/org/apache/kafka/raft/Endpoints.java:
##
@@ -101,6 +102,21 @@ public
BeginQuorumEpochRequestData.LeaderEndpointCollection toBeginQuorumEpochRe
cmccabe commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1685007319
##
raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java:
##
@@ -65,7 +65,7 @@ public final class KRaftControlRecordStateMachine {
jsancio commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684708856
##
raft/src/main/java/org/apache/kafka/raft/Endpoints.java:
##
@@ -101,6 +102,21 @@ public
BeginQuorumEpochRequestData.LeaderEndpointCollection toBeginQuorumEpochRe
jsancio commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684706132
##
raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java:
##
@@ -221,7 +230,7 @@ private void maybeLoadLog() {
}
private vo
jsancio commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684705773
##
raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java:
##
@@ -65,7 +65,7 @@ public final class KRaftControlRecordStateMachine {
jsancio commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684696258
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -273,10 +292,29 @@ public void
appendLeaderChangeMessageAndBootstrapRecords(long currentTimeMs) {
jsancio commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684686209
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -3154,14 +3279,15 @@ private static Registration
unregister(Listener listener) {
}
jsancio commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684684173
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -348,22 +360,29 @@ private void onUpdateLeaderHighWatermark(
private void updateListenersPr
jsancio commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684658784
##
raft/src/main/java/org/apache/kafka/raft/internals/AddVoterHandler.java:
##
@@ -0,0 +1,383 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
cmccabe commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684612120
##
raft/src/main/java/org/apache/kafka/raft/Endpoints.java:
##
@@ -101,6 +102,21 @@ public
BeginQuorumEpochRequestData.LeaderEndpointCollection toBeginQuorumEpochRe
cmccabe commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684609938
##
raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java:
##
@@ -221,7 +230,7 @@ private void maybeLoadLog() {
}
private vo
cmccabe commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684609661
##
raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java:
##
@@ -65,7 +65,7 @@ public final class KRaftControlRecordStateMachine {
cmccabe commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684608021
##
raft/src/main/java/org/apache/kafka/raft/internals/AddVoterHandler.java.orig:
##
@@ -0,0 +1,379 @@
+/*
Review Comment:
I do not think you intended to submit this
cmccabe commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684606840
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -273,10 +292,29 @@ public void
appendLeaderChangeMessageAndBootstrapRecords(long currentTimeMs) {
cmccabe commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684606280
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -3154,14 +3279,15 @@ private static Registration
unregister(Listener listener) {
}
cmccabe commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684605221
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -348,22 +360,29 @@ private void onUpdateLeaderHighWatermark(
private void updateListenersPr
cmccabe commented on code in PR #16626:
URL: https://github.com/apache/kafka/pull/16626#discussion_r1684601533
##
raft/src/main/java/org/apache/kafka/raft/internals/AddVoterHandler.java:
##
@@ -0,0 +1,383 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
jsancio closed pull request #16606: KAFKA-16535; Implement KRaft add voter
handling
URL: https://github.com/apache/kafka/pull/16606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
jsancio commented on PR #16606:
URL: https://github.com/apache/kafka/pull/16606#issuecomment-2236891621
Closing in favor of this PR: https://github.com/apache/kafka/pull/16626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
jsancio opened a new pull request, #16626:
URL: https://github.com/apache/kafka/pull/16626
This change implements the AddVoter RPC. The high-level algorithm is as
follow:
1. Check that the leader has fenced the previous leader(s) by checking that
the HWM is known, otherwise return th
cmccabe commented on PR #16606:
URL: https://github.com/apache/kafka/pull/16606#issuecomment-2231670235
Posting this for @jsancio since he had some network issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cmccabe opened a new pull request, #16606:
URL: https://github.com/apache/kafka/pull/16606
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
29 matches
Mail list logo
