Re: [JPP-Devel] Feature collections modified by default

2010-08-18 Thread Andreas Schmitz
Michaël Michaud wrote: Hi, I can commit your patch next week, if you did not do it before. ok, I've committed the patch, including the T\: language strings as suggested. Thanks, Andreas -- l a t / l o n GmbH Aennchenstrasse 19 53177 Bonn, Germany phone ++49 +228 18496-0 fax

Re: [JPP-Devel] Feature collections modified by default

2010-08-18 Thread Stefan Steiniger
Thanks Andreas Andreas Schmitz wrote: Michaël Michaud wrote: Hi, I can commit your patch next week, if you did not do it before. ok, I've committed the patch, including the T\: language strings as suggested. Thanks, Andreas

Re: [JPP-Devel] Feature collections modified by default

2010-08-18 Thread Michaël Michaud
Hi Andreas, Thanks a lot. Your patch seems to work like a charm. Michaël Andreas Schmitz a écrit : Michaël Michaud wrote: Hi, I can commit your patch next week, if you did not do it before. ok, I've committed the patch, including the T\: language strings as suggested.

Re: [JPP-Devel] Feature collections modified by default

2010-08-12 Thread Michaël Michaud
Andreas Schmitz a écrit : key ;-) By the way, do I need to insert the keys into all the language files, or are the ones I know a translation for sufficient? To facilitate translation work, we usually put the key with the english default in all language files, preceded by T\: for those

Re: [JPP-Devel] Feature collections modified by default

2010-08-10 Thread Andreas Schmitz
Michaël Michaud wrote: Hi, ok. I've attached patch which changes the following: * new feature collections are again unmodified by default * PlugInContext has an added addLayer method taking a featureCollectionModified parameter for convenience * when OpenJUMP is closed, and no

Re: [JPP-Devel] Feature collections modified by default

2010-08-09 Thread Andreas Schmitz
Stefan Steiniger wrote: Hi, finally I'm getting back to this. playing save is what we should do. For creating new layers I am most often using context.addLayer() - so why not adding the flagging there instead of changing all plugins? An option would be to create a second addLayer() method

Re: [JPP-Devel] Feature collections modified by default

2010-08-09 Thread Michaël Michaud
Hi, ok. I've attached patch which changes the following: * new feature collections are again unmodified by default * PlugInContext has an added addLayer method taking a featureCollectionModified parameter for convenience * when OpenJUMP is closed, and no layers have been modified, it

Re: [JPP-Devel] Feature collections modified by default

2010-08-09 Thread Stefan Steiniger
Hei Michael, Side note : in both cases, the solution is added at the Layer level and does not take raster into account. I wonder if modification status and dataSource should be shared by all AbstractLayerable ? But this is another question... mhm.. interesting did not think about this

Re: [JPP-Devel] Feature collections modified by default

2010-07-09 Thread Andreas Schmitz
Michaël Michaud wrote: Hi, I've noticed that (for quite some time now) newly loaded feature collections/layers are now considered modified by default. I've been using that check in the WFS plugin to enable the update button only if the layer is actually modified. I've added a workaround

Re: [JPP-Devel] Feature collections modified by default

2010-07-09 Thread Larry Becker
I'm not sure it helps, and I haven't tried it on WFS layers, but theoretically my select all modified features plugin distinguishes between newly created features and features loaded from a dataset. Larry On Fri, Jul 9, 2010 at 3:11 AM, Andreas Schmitz schm...@lat-lon.de wrote: Michaël Michaud

Re: [JPP-Devel] Feature collections modified by default

2010-07-09 Thread Stefan Steiniger
Hei Andreas and Michael, playing save is what we should do. For creating new layers I am most often using context.addLayer() - so why not adding the flagging there instead of changing all plugins? An option would be to create a second addLayer() method with a boolean parameter for flagging if

[JPP-Devel] Feature collections modified by default

2010-07-08 Thread Andreas Schmitz
Hi all, Michaël, I've noticed that (for quite some time now) newly loaded feature collections/layers are now considered modified by default. I've been using that check in the WFS plugin to enable the update button only if the layer is actually modified. I've added a workaround to set the layer

Re: [JPP-Devel] Feature collections modified by default

2010-07-08 Thread Giuseppe Aruta
Hi Andreas I'd like to propose to have a check when closing, and show a different message if no layers have been modified, asking just that, and only show the modified warning if something has actually been modified. I've already changed this experimentally (locally), and if

Re: [JPP-Devel] Feature collections modified by default

2010-07-08 Thread Sunburned Surveyor
Andreas, Your comments make sense to me, but lets wait a couple more days for Michael to comment before we commit a patch. Thanks, The Sunburned Surveyor On Thu, Jul 8, 2010 at 3:57 AM, Giuseppe Aruta giuseppe_ar...@yahoo.it wrote: Hi Andreas  I'd like to propose to have a check when

Re: [JPP-Devel] Feature collections modified by default

2010-07-08 Thread Michaël Michaud
Hi Andreas, I've noticed that (for quite some time now) newly loaded feature collections/layers are now considered modified by default. I've been using that check in the WFS plugin to enable the update button only if the layer is actually modified. I've added a workaround to set the layer