[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-05-28 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284499#comment-13284499 ] Prashanth Menon commented on KAFKA-49: -- Excellent, committed this to 0.8.

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-05-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270038#comment-13270038 ] Jun Rao commented on KAFKA-49: -- Prashanth, Now that kafka-48 is committed to 0.8, we can

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-04-05 Thread Jun Rao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247458#comment-13247458 ] Jun Rao commented on KAFKA-49: -- Prashanth, Thanks for the patch. It seems that kafka-48 is

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-28 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240512#comment-13240512 ] Neha Narkhede commented on KAFKA-49: Prashanth, thanks for resolving KAFKA-305 ! Would

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-15 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230156#comment-13230156 ] Prashanth Menon commented on KAFKA-49: -- Better late than never. A second review is

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-14 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229905#comment-13229905 ] Neha Narkhede commented on KAFKA-49: Sorry for visiting this late. I have a few

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-13 Thread Jun Rao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228845#comment-13228845 ] Jun Rao commented on KAFKA-49: -- Prashanth, I am ready to commit your patch. A couple things:

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-13 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228875#comment-13228875 ] Prashanth Menon commented on KAFKA-49: -- Hi Jun, I've attached a new patch. 1. Yes,

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-12 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228111#comment-13228111 ] Prashanth Menon commented on KAFKA-49: -- I've attached an updated patch. 1.

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-11 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227277#comment-13227277 ] Prashanth Menon commented on KAFKA-49: -- A few more concerns popped up as a result of

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-08 Thread Jun Rao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225321#comment-13225321 ] Jun Rao commented on KAFKA-49: -- Prashanth, Thanks for the patch. Overall, it looks pretty

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-08 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225801#comment-13225801 ] Prashanth Menon commented on KAFKA-49: -- Thanks for the pointers! 1. Hmmm, do you

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-08 Thread Jun Rao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225845#comment-13225845 ] Jun Rao commented on KAFKA-49: -- 1. Or we can just treat noacks the same as act=1 for now.

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-06 Thread Jun Rao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13223407#comment-13223407 ] Jun Rao commented on KAFKA-49: -- Prashanth, Yes, that's actually a real bug. Instead of

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-06 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13223609#comment-13223609 ] Prashanth Menon commented on KAFKA-49: -- Done, created KAFKA-295. Expect patch for this

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-06 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13223944#comment-13223944 ] Prashanth Menon commented on KAFKA-49: -- I've attached a patch for this. A few

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-05 Thread Jun Rao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13222700#comment-13222700 ] Jun Rao commented on KAFKA-49: -- Prashanth, That's a good question. Initially, I was just

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-05 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13222752#comment-13222752 ] Prashanth Menon commented on KAFKA-49: -- If I remember right, HornetQ allows you to

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-05 Thread Jun Rao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13222779#comment-13222779 ] Jun Rao commented on KAFKA-49: -- The current defaulteventhandler already refreshes topic

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-04 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13222156#comment-13222156 ] Prashanth Menon commented on KAFKA-49: -- Hey all. Getting the acknowledgements done was

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-01 Thread Neha Narkhede (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13220436#comment-13220436 ] Neha Narkhede commented on KAFKA-49: KAFKA-239 is complete and KAFKA-240 is almost

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2011-11-23 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156494#comment-13156494 ] Prashanth Menon commented on KAFKA-49: -- Agreed, we need to change the wire protocol to

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2011-11-22 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155158#comment-13155158 ] Prashanth Menon commented on KAFKA-49: -- So I've started a little work on this. Looks

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2011-11-22 Thread Jun Rao (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155240#comment-13155240 ] Jun Rao commented on KAFKA-49: -- Prshanth, thanks for getting started on this. I agree with your

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2011-11-22 Thread Jay Kreps (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155331#comment-13155331 ] Jay Kreps commented on KAFKA-49: Hi Taylor, as you say the request id was meant to be the

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2011-11-22 Thread Taylor Gautier (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155348#comment-13155348 ] Taylor Gautier commented on KAFKA-49: - Well, how many versions do you think you want?

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2011-11-15 Thread Jay Kreps (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151039#comment-13151039 ] Jay Kreps commented on KAFKA-49: If there are any other producer-related changes coming we