[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284499#comment-13284499
]
Prashanth Menon commented on KAFKA-49:
--
Excellent, committed this to 0.8.
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270038#comment-13270038
]
Jun Rao commented on KAFKA-49:
--
Prashanth,
Now that kafka-48 is committed to 0.8, we can
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247458#comment-13247458
]
Jun Rao commented on KAFKA-49:
--
Prashanth,
Thanks for the patch. It seems that kafka-48 is
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240512#comment-13240512
]
Neha Narkhede commented on KAFKA-49:
Prashanth, thanks for resolving KAFKA-305 ! Would
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230156#comment-13230156
]
Prashanth Menon commented on KAFKA-49:
--
Better late than never. A second review is
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13229905#comment-13229905
]
Neha Narkhede commented on KAFKA-49:
Sorry for visiting this late. I have a few
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228845#comment-13228845
]
Jun Rao commented on KAFKA-49:
--
Prashanth,
I am ready to commit your patch. A couple things:
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228875#comment-13228875
]
Prashanth Menon commented on KAFKA-49:
--
Hi Jun, I've attached a new patch.
1. Yes,
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13228111#comment-13228111
]
Prashanth Menon commented on KAFKA-49:
--
I've attached an updated patch.
1.
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13227277#comment-13227277
]
Prashanth Menon commented on KAFKA-49:
--
A few more concerns popped up as a result of
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225321#comment-13225321
]
Jun Rao commented on KAFKA-49:
--
Prashanth,
Thanks for the patch. Overall, it looks pretty
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225801#comment-13225801
]
Prashanth Menon commented on KAFKA-49:
--
Thanks for the pointers!
1. Hmmm, do you
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225845#comment-13225845
]
Jun Rao commented on KAFKA-49:
--
1. Or we can just treat noacks the same as act=1 for now.
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13223407#comment-13223407
]
Jun Rao commented on KAFKA-49:
--
Prashanth,
Yes, that's actually a real bug. Instead of
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13223609#comment-13223609
]
Prashanth Menon commented on KAFKA-49:
--
Done, created KAFKA-295. Expect patch for this
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13223944#comment-13223944
]
Prashanth Menon commented on KAFKA-49:
--
I've attached a patch for this. A few
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13222700#comment-13222700
]
Jun Rao commented on KAFKA-49:
--
Prashanth,
That's a good question. Initially, I was just
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13222752#comment-13222752
]
Prashanth Menon commented on KAFKA-49:
--
If I remember right, HornetQ allows you to
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13222779#comment-13222779
]
Jun Rao commented on KAFKA-49:
--
The current defaulteventhandler already refreshes topic
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13222156#comment-13222156
]
Prashanth Menon commented on KAFKA-49:
--
Hey all. Getting the acknowledgements done was
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13220436#comment-13220436
]
Neha Narkhede commented on KAFKA-49:
KAFKA-239 is complete and KAFKA-240 is almost
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13156494#comment-13156494
]
Prashanth Menon commented on KAFKA-49:
--
Agreed, we need to change the wire protocol to
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155158#comment-13155158
]
Prashanth Menon commented on KAFKA-49:
--
So I've started a little work on this. Looks
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155240#comment-13155240
]
Jun Rao commented on KAFKA-49:
--
Prshanth, thanks for getting started on this. I agree with your
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155331#comment-13155331
]
Jay Kreps commented on KAFKA-49:
Hi Taylor, as you say the request id was meant to be the
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155348#comment-13155348
]
Taylor Gautier commented on KAFKA-49:
-
Well, how many versions do you think you want?
[
https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151039#comment-13151039
]
Jay Kreps commented on KAFKA-49:
If there are any other producer-related changes coming we
27 matches
Mail list logo