Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/#review46109 --- Much better, but... :) kio/bookmarks/kbookmarkdialog.h

Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Vishesh Handa
Hey guys I would like to move Baloo and Baloo-widgets into KDE SC soon. It would be nice if someone could review the code. Both the projects are in kdereview. Baloo is a metadata and search framework which is a successor to the Nepomuk project. It primarily provides - * An API for searching *

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Christoph Feck
On Tuesday 24 December 2013 11:28:11 Vishesh Handa wrote: Hey guys I would like to move Baloo and Baloo-widgets into KDE SC soon. It would be nice if someone could review the code. Both the projects are in kdereview. Baloo is a metadata and search framework which is a successor to the

Re: Review Request 114455: kjs: Implement ES6 Math.imul

2013-12-24 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114455/#review46131 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On

Re: Review Request 114623: kjs: Implement es6 Math.fround

2013-12-24 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114623/#review46132 --- Ship it! what a silly function, but looks okay to me. -

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/ --- (Updated Dec. 24, 2013, 2:26 p.m.) Review request for kdelibs and David

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread Dawit Alemayehu
On Dec. 24, 2013, 8:14 a.m., David Faure wrote: kio/bookmarks/kbookmarkdialog.cc, line 350 https://git.reviewboard.kde.org/r/114479/diff/3/?file=227047#file227047line350 this method could now call the other one with an empty selectGroup, to remove the code duplication, right?

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/#review46134 --- Ship it! Ship It! - David Faure On Dec. 24, 2013, 2:26

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/ --- (Updated Dec. 24, 2013, 2:50 p.m.) Status -- This change has been

Re: Review Request 114479: Select the newly created bookmark folder as the current item

2013-12-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114479/#review46135 --- This review has been submitted with commit

Re: Review Request 114436: Set WindowModality of all KIO message box to Qt::WindowModal

2013-12-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114436/#review46137 --- This review has been submitted with commit

Re: Review Request 114436: Set WindowModality of all KIO message box to Qt::WindowModal

2013-12-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114436/ --- (Updated Dec. 24, 2013, 3:01 p.m.) Status -- This change has been

KF5 Update Meeting Minutes 2013-w52

2013-12-24 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 52 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: alexmerry, apol and myself. Announcement: * I lined up that one to see who would show up, merry christmas! * alexmerry has been working on getting jenkins

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Vishesh Handa
On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote: How does Baloo cooperate with Nepomuk? Note that we have ABI guarantees, so if the metadata is not shared between running instances of two services, but applications would have to be ported to the new ABI, then you cannot introduce Baloo in

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Thomas Lübking
On Dienstag, 24. Dezember 2013 19:29:11 CEST, Vishesh Handa wrote: On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote: How does Baloo cooperate with Nepomuk? Note that we have ABI guarantees, so if the metadata is not shared between running instances of two services, but applications would

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread David Edmundson
On 24 Dec 2013 18:57, Thomas Lübking thomas.luebk...@gmail.com wrote: On Dienstag, 24. Dezember 2013 19:29:11 CEST, Vishesh Handa wrote: On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote: How does Baloo cooperate with Nepomuk? Note that we have ABI guarantees, so if the metadata is not

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Àlex Fiestas
On Tuesday 24 December 2013 21:25:37 Ivan Čukić wrote: As I understand it there are no plans to remove the nepomuk-core or nepomuk-widget libraries. If you switch to Baloo, anything compiled against nepomuk will still run but will act as if nepomuk is disabled. This is something clients

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Àlex Fiestas
On Tuesday 24 December 2013 19:57:17 Thomas Lübking wrote: On Dienstag, 24. Dezember 2013 19:29:11 CEST, Vishesh Handa wrote: On Tuesday 24 Dec 2013 13:06:55 Christoph Feck wrote: How does Baloo cooperate with Nepomuk? Note that we have ABI guarantees, so if the metadata is not shared

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Thomas Lübking
On Dienstag, 24. Dezember 2013 22:03:28 CEST, Àlex Fiestas wrote: On Tuesday 24 December 2013 21:25:37 Ivan Čukić wrote: I would like baloo to be available in 4.x, with no API stability guarantees, ... As I see it, the nepomuk maintainer says it works better than Nepomuk for all cases

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-24 Thread Ivan Čukić
On Tuesday, 24. December 2013. 22.03.28 Àlex Fiestas wrote: As I see it, the nepomuk maintainer says it works better than Nepomuk for all cases covered by SC. I don't see any reason not to move forward then. The truthfulness of Vishesh's claim does not enter into it. If we believe it (and I