/122812/diff/
Testing
---
Thanks,
Andrea Iacovitti
this patch that reinstate old
DOMString::trimSpaces() and mark it as deprecated.
Diffs
-
khtml/dom/dom_string.h 087f697
khtml/dom/dom_string.cpp a3c4abd
Diff: https://git.reviewboard.kde.org/r/122812/diff/
Testing
---
Thanks,
Andrea Iacovitti
---
On Mar. 4, 2015, 5:26 p.m., Andrea Iacovitti wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122812
Il giorno Sun, 30 Nov 2014 14:02:13 +0100
Thomas Lübking thomas.luebk...@gmail.com ha scritto:
On Sonntag, 30. November 2014 06:26:19 CEST, Ian Wadham wrote:
Lastly, how and when is a new KDE 4 kde-runtime patch likely to be
released?
Wednesday, December 10, 2014: KDE Applications 14.12
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120975/#review69919
---
Tested and works as expected. Ship it from my part.
- Andrea
url.toDisplayString() should be equivalent to call
url.toString(QUrl::RemovePassword)
Andrea
url.toDisplayString() should be equivalent to call
url.toString(QUrl::RemovePassword)
Andrea
from the one committed
if (m_asMethod || !fileInfo.exists()) {
vs
if (m_asMethod !fileInfo.exists()) {
- Andrea Iacovitti
On Set. 19, 2014, 11:25 a.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply
On July 9, 2014, 8:26 a.m., Andrea Iacovitti wrote:
If there are no objections or other suggestions it would be good to have
the bug fixed in 4.11.11 release :)
Christoph Feck wrote:
Thanks Andrea. Could you please check if this also affects bug 244857,
bug 325868, or bug 326971
be good to have the
bug fixed in 4.11.11 release :)
- Andrea Iacovitti
On Lug. 6, 2014, 10:28 a.m., Andrea Iacovitti wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117957
to antialias setting
Diffs (updated)
-
kcontrol/fonts/fonts.cpp cf21cb1
Diff: https://git.reviewboard.kde.org/r/117957/diff/
Testing
---
Tested it compiles and works as expected
Thanks,
Andrea Iacovitti
setting
Diffs
-
kcontrol/fonts/fonts.cpp cf21cb1
Diff: https://git.reviewboard.kde.org/r/117957/diff/
Testing
---
Tested it compiles and works as expected
Thanks,
Andrea Iacovitti
. To reply, visit:
https://git.reviewboard.kde.org/r/117957/#review58136
---
On Mag. 18, 2014, 12:38 a.m., Andrea Iacovitti wrote:
---
This is an automatically generated e-mail
not be risk of regression.
- Andrea Iacovitti
On June 2, 2014, 2:22 p.m., Michael Reeves wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118407
not that be PPC-Intel instead?
- Andrea Iacovitti
On May 29, 2014, 6:26 p.m., Michael Reeves wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118407
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117957/#review58092
---
ping
- Andrea Iacovitti
On May 2, 2014, 7:59 p.m., Andrea
checkbox
- Enable/Disable Configure... button accordingly to antialias setting
Diffs (updated)
-
kcontrol/fonts/fonts.cpp cf21cb1
Diff: https://git.reviewboard.kde.org/r/117957/diff/
Testing
---
Tested it compiles and works as expected
Thanks,
Andrea Iacovitti
://git.reviewboard.kde.org/r/117957/diff/
Testing
---
Tested it compiles and works as expected
Thanks,
Andrea Iacovitti
/116602/diff/
Testing
---
Thanks,
Andrea Iacovitti
---
On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116602
== KMessageBox::No) {
+shouldRedirect = false;
+}
+}
+
+if (shouldRedirect)
{
KUrl u(m_request.url, locationStr);
if(!u.isValid())
- Andrea Iacovitti
On March 7, 2014, 6:07 a.m., Dawit Alemayehu wrote
about the third patch in this review (Diff r3) it seems it works as
expected. That is if a server redirects a collection DELETE operation to a new
Location with trailing slash added, redirection is correctly followed.
From my part it is a ship for this one (Diff r3).
- Andrea Iacovitti
On March
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116122/#review52410
---
Ship it!
Ah, yes. That is the fix.
- Andrea Iacovitti
the request refers to a
collection or resource (as it was before commit 58294ac).
- Andrea Iacovitti
On March 5, 2014, 2:01 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On March 6, 2014, 9:10 p.m., Andrea Iacovitti wrote:
I tested your patch, no trailing slash is added whether the request refers
to a collection or resource (as it was before commit 58294ac).
Dawit Alemayehu wrote:
Right, but now the webdav server should redirect to the right
), can't delete file.
isFile is always false whether you try to delete a file or folder so a
trailing slash is always added.
- Andrea Iacovitti
On March 3, 2014, 3:50 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e
value in
outgoingMetaData map.
This patch aims to avoid this situation by looking up the key using
queryMetadata().
Diffs
-
kio/kio/job.cpp edc5fed
Diff: https://git.reviewboard.kde.org/r/116602/diff/
Testing
---
Thanks,
Andrea Iacovitti
On March 4, 2014, 2:51 p.m., Andrea Iacovitti wrote:
Still broken for webdav protocol (tested using konq/dolphin), can't delete
file.
isFile is always false whether you try to delete a file or folder so a
trailing slash is always added.
Dawit Alemayehu wrote:
Well it works
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116122/#review51064
---
What patch? ;)
- Andrea Iacovitti
On Feb. 27, 2014, 2:28
/#comment35803
This seems to have no effect in the next GET request, shouldn't be added to
the outgoing metadata?
- Andrea Iacovitti
On Feb. 27, 2014, 1:41 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail
doesn't need modifications, except
removing the m_request.method = HTTP_GET; // FORCE a GET parts that, yes,
seem not needed.
- Andrea Iacovitti
On Feb. 26, 2014, 8:34 a.m., Dawit Alemayehu wrote:
---
This is an automatically generated e
by showing code, see
http://paste.kde.org/pvzj0ppio
I did many tests and didn't found issues so far
- Andrea Iacovitti
On Feb. 26, 2014, 8:34 a.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
: https://git.reviewboard.kde.org/r/116048/diff/
Testing
---
various
Thanks,
Andrea Iacovitti
, you
may want to rebase it if this goes in).
Diffs
-
kio/kio/job.cpp 9cf2b57
Diff: https://git.reviewboard.kde.org/r/116048/diff/
Testing
---
various
Thanks,
Andrea Iacovitti
.
As for these page
http://greenbytes.de/tech/tc/httpredirects/t307methods.html
http://greenbytes.de/tech/tc/httpredirects/t308methods.html
they can't be used for testing as they do make XHR requests with no body data.
- Andrea Iacovitti
On Feb. 24, 2014, 2:07 p.m., Dawit Alemayehu wrote
-
kioslave/http/http.h 076ad2b
kioslave/http/http.cpp 68b5247
kioslave/http/httpauthentication.cpp 80d7995
Diff: https://git.reviewboard.kde.org/r/115864/diff/
Testing
---
Thanks,
Andrea Iacovitti
. To reply, visit:
https://git.reviewboard.kde.org/r/115864/#review50189
---
On Feb. 18, 2014, 9:36 a.m., Andrea Iacovitti wrote:
---
This is an automatically generated e-mail. To reply
/http.h 076ad2b
kioslave/http/http.cpp 68b5247
kioslave/http/httpauthentication.cpp 80d7995
Diff: https://git.reviewboard.kde.org/r/115864/diff/
Testing
---
Thanks,
Andrea Iacovitti
/
Testing
---
Thanks,
Andrea Iacovitti
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115689/#review49994
---
Ship it!
- Andrea Iacovitti
On Feb. 16, 2014, 7:10 p.m
));
}
- Andrea Iacovitti
On Feb. 14, 2014, 4 p.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115689
if (m_request.method != HTTP_HEAD) {
m_request.method = HTTP_GET; // FORCE a GET
setMetaData(QLatin1String(redirect-to-get),
QLatin1String(true));
}
}
}
...or something like that.
- Andrea Iacovitti
On Feb. 11, 2014, 10:28 a.m
in https://git.reviewboard.kde.org/r/115651 about
http.cpp's changes.
- Andrea Iacovitti
On Feb. 12, 2014, 9:56 a.m., Dawit Alemayehu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
/114907/#comment33529
typo: if if - if it
- Andrea Iacovitti
On Jan. 7, 2014, 10:36 p.m., Albert Astals Cid wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114907
On Oct. 10, 2013, 11:59 a.m., Bernd Buschinski wrote:
This is a bit confussing...
lets sum up the background story:
- kjs(/wtf) loves gcc features
- kjs-cmake filters out (gcc) pedantic
now comes the problem... whats with other compilers?
if you look at the commit message
---
On Nov. 27, 2013, 9:22 p.m., Andrea Iacovitti wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114105
and not no_proxy
Thanks,
Andrea Iacovitti
proxy is required, that is
when not using socks proxy or tunneling SSL.
Also warn the user about collected bad proxies url, if any.
Diffs
-
kioslave/http/http.cpp 417569a
Diff: http://git.reviewboard.kde.org/r/113492/diff/
Testing
---
Thanks,
Andrea Iacovitti
---
Thanks,
Andrea Iacovitti
.
Diffs (updated)
-
kioslave/http/http.cpp 417569a
Diff: http://git.reviewboard.kde.org/r/113492/diff/
Testing
---
Thanks,
Andrea Iacovitti
about collected bad proxies url, if any.
Diffs
-
kioslave/http/http.cpp 417569a
Diff: http://git.reviewboard.kde.org/r/113492/diff/
Testing
---
Thanks,
Andrea Iacovitti
is required, that is
when not using socks proxy or tunneling SSL.
Also warn the user about collected bad proxies url, if any.
Diffs (updated)
-
kioslave/http/http.cpp 417569a
Diff: http://git.reviewboard.kde.org/r/113492/diff/
Testing
---
Thanks,
Andrea Iacovitti
, 2013, 1:41 p.m., Andrea Iacovitti wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113364/
---
(Updated Oct. 21, 2013, 1:41 p.m
as m_request.proxyUrls will be empty.
Thanks,
Andrea Iacovitti
or responseCode == 304) none of the
nine conditions in the subsequent if..else if.. can be true.
Diffs
-
kioslave/http/http.cpp 81182eb
Diff: http://git.reviewboard.kde.org/r/113366/diff/
Testing
---
Thanks,
Andrea Iacovitti
Description
---
Diffs
-
kioslave/http/http.cpp 81182eb
Diff: http://git.reviewboard.kde.org/r/113364/diff/
Testing
---
Thanks,
Andrea Iacovitti
is not executed
as m_request.proxyUrls will be empty.
Thanks,
Andrea Iacovitti
== 200 or responseCode == 304) none of the
nine conditions in the subsequent if..else if.. can be true.
Diffs
-
kioslave/http/http.cpp 81182eb
Diff: http://git.reviewboard.kde.org/r/113366/diff/
Testing
---
Thanks,
Andrea Iacovitti
of environment variables to use in case of System Proxy
Configuration. (See getSystemProxyFor() in kprotocolmanager.cpp)
Diffs
-
konqueror/settings/kio/kproxydlg.cpp 7c777d3
Diff: http://git.reviewboard.kde.org/r/113129/diff/
Testing
---
Thanks,
Andrea Iacovitti
://git.reviewboard.kde.org/r/113129/diff/
Testing
---
Thanks,
Andrea Iacovitti
://git.reviewboard.kde.org/r/108929/#comment20578
Is this include really necessary or just an accident? (Noticed because a
compilation error)
- Andrea Iacovitti
On Feb. 12, 2013, 10:51 p.m., Bernd Buschinski wrote:
---
This is an automatically generated
: oxygen, qtcurve, available qt styles
(plastique, qcleanlooks ...)
. tested against Qt 4.7.4, Qt 4.8.1
. daily browsing
Screenshots
---
shoot of a bko page before/after the patch
http://git.reviewboard.kde.org/r/104983/s/573/
Thanks,
Andrea Iacovitti
to the server
Content-Type:application/x-www-form-urlencoded
(so i suppose the bug reporter was using WebKit engine)
The problem doesn't affect KHTML engine that sets content-type metadaData to
Content-type: application/x-www-form-urlencoded
Thanks,
Andrea Iacovitti
Thanks,
Andrea Iacovitti
against following keep-alive header
variants:
Keep-Alive: timeout=5, max=99
Keep-Alive: Timeout=5, max=99 (uppercase 'T')
Keep-Alive: Timeout=5 , max=99(extra space before comma)
Thanks,
Andrea Iacovitti
---
On Oct. 10, 2011, 10:35 p.m., Andrea Iacovitti wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102822
Testing
---
-Patched code compiles
-Hacked a web server and made tests against following keep-alive header
variants:
Keep-Alive: timeout=5, max=99
Keep-Alive: Timeout=5, max=99 (uppercase 'T')
Keep-Alive: Timeout=5 , max=99(extra space before comma)
Thanks,
Andrea Iacovitti
67 matches
Mail list logo
