BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/57/
Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 22 Nov 2017 06:48:59 +
Build duration:
1 hr 5 min and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20WindowsMSVCQt5.9/27/
Project:
Frameworks kdelibs4support kf5-qt5 WindowsMSVCQt5.9
Date of build:
Wed, 22 Nov 2017 06:48:59 +
Build duration:
43 min and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/2/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
Date of build:
Wed, 22 Nov 2017 06:48:59 +
Build duration:
15 min and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/2/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.7
Date of build:
Wed, 22 Nov 2017 06:48:59 +
Build duration:
10 min and counting
JUnit Tests
ngraham added a comment.
@dfaure, does this look sane and sensible to you?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8791
To: cryptodude, dfaure, cfeck, ngraham
Cc: ngraham, #frameworks
smithjd marked 2 inline comments as done.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure
Cc: dfaure, nicolasfella, ngraham
smithjd updated this revision to Diff 22712.
smithjd added a comment.
Make work with kioclient.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8098?vs=22107=22712
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
smithjd retitled this revision from "Strip down and re-write the tags KIO
slave." to "Strip down and re-write the baloo tags KIO slave".
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure
Cc: dfaure,
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.9/48/
Project:
Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9
Date of build:
Tue, 21 Nov 2017 18:35:12 +
Build duration:
4 hr 3 min and counting
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesmodel.cpp:913
>
> +bool KFilePlacesModel::movePlace(int row, int before)
> +{
This should get its own unittest, especially since there are lots
dfaure added a comment.
This seems to be bundling several unrelated additions into the same commit?
Please have one commit per feature / change / addition.
I know that phabricator makes it difficult to have one review per commit, but
at least the commits should be separate.
INLINE
dfaure added a comment.
Relative completions in KUrlCompletion defaults to $HOME but that can be
configured with KUrlCompletion::setDir.
Maybe KUrlNavigator should get a setter too, so that apps can set a base
directory that makes sense to them?
They have more context for setting a
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20WindowsMSVCQt5.9/17/
Project:
Frameworks krunner kf5-qt5 WindowsMSVCQt5.9
Date of build:
Tue, 21 Nov 2017 17:51:24 +
Build duration:
3 hr 58 min and counting
JUnit
cullmann added a comment.
If I don't misread the current diff, all things got done.
Can you commit or shall I do so for you?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7660
To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann, mwolff
Cc: mwolff,
cullmann accepted this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7660
To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann, mwolff, cullmann
Cc: mwolff, ngraham, anthonyfieroni, cullmann, jgrulich, dhaumann, hein,
kwrite-devel, #frameworks
renatoo updated this revision to Diff 22703.
renatoo added a comment.
Created a public function 'moveItem' to be used by external apps
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8862?vs=22673=22703
REVISION DETAIL
https://phabricator.kde.org/D8862
On Tuesday, 21 November 2017 14:24:04 CET Felix Miata wrote:
> Sven Brauch composed on 2017-11-21 12:25 (UTC+0100):
> > Felix Miata wrote:
> >> Case sensitive filesystems are one of the most annoying things about
> >> FOSS.
> >
> > I'd count that as a win.
>
> InsaniTY
> INSaniTy
> InSAnItY
>
emateli updated this revision to Diff 22702.
emateli added a comment.
- remove QDir::homePath + minor code style
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8920?vs=22671=22702
BRANCH
relative-files
REVISION DETAIL
https://phabricator.kde.org/D8920
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.9/47/
Project:
Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9
Date of build:
Tue, 21 Nov 2017 13:09:37 +
Build duration:
5 hr 25 min and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20WindowsMSVCQt5.9/16/
Project:
Frameworks krunner kf5-qt5 WindowsMSVCQt5.9
Date of build:
Tue, 21 Nov 2017 13:01:42 +
Build duration:
4 hr 48 min and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20WindowsMSVCQt5.9/30/
Project:
Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.9
Date of build:
Tue, 21 Nov 2017 12:06:41 +
Build duration:
5 hr 32 min and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/101/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 21 Nov 2017 13:09:37 +
Build duration:
24 min and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:9eb778022c36: Dont do unnecessary QString
allocations to convert parts of it into strings (authored by apol).
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE LAST UPDATE
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/2/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
Date of build:
Tue, 21 Nov 2017 13:09:37 +
Build duration:
15 min and counting
JUnit Tests
Sven Brauch composed on 2017-11-21 12:25 (UTC+0100):
> Felix Miata wrote:
>> Case sensitive filesystems are one of the most annoying things about FOSS.
> I'd count that as a win.
InsaniTY
INSaniTy
InSAnItY
inSANity
INsANItY
INSANiTY
iNSaNiTy
InsAnItY
Boss: Worker, please get me the insanity
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/2/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
Date of build:
Tue, 21 Nov 2017 13:09:37 +
Build duration:
7 min 26 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/2/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
Date of build:
Tue, 21 Nov 2017 13:01:42 +
Build duration:
6 min 7 sec and counting
JUnit Tests
Name:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/35/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 21 Nov 2017 13:01:42 +
Build duration:
3 min 46 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/2/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.7
Date of build:
Tue, 21 Nov 2017 13:01:42 +
Build duration:
1 min 43 sec and counting
JUnit Tests
Name:
jgrulich accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R282 NetworkManagerQt
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8925
To: apol, #frameworks, jgrulich
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:fcecbc5c67f7: use a single QML engine (authored by mart).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8436?vs=21224=22693
REVISION DETAIL
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
arcpatch-D8436
REVISION DETAIL
https://phabricator.kde.org/D8436
To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot,
kfunk added inline comments.
INLINE COMMENTS
> apol wrote in kjobwidgets.cpp:67
> Note I didn't change any code, I just moved it around.
>
> Removing the cast still seems to work, so I'll do that.
> Note I didn't change any code, I just moved it around.
Whoops, sorry. Didn't notice.
apol created this revision.
apol added reviewers: Frameworks, jgrulich.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Don't pass unnecessary variable to lambda
REPOSITORY
R282 NetworkManagerQt
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8925
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:5491f35c32c2: Set enable_blur_behind hint on demand.
(authored by davidedmundson).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8851?vs=22475=22690
On Dienstag, 21. November 2017 12:25:56 CET Sven Brauch wrote:
> On 21/11/17 03:53, Felix Miata wrote:
> > Case sensitive filesystems are one of the most annoying things about FOSS.
>
> I'd count that as a win.
+1, and they existed long before FOSS was around.
p.s. The footer below is selected
On 21/11/17 03:53, Felix Miata wrote:
> Case sensitive filesystems are one of the most annoying things about FOSS.
I'd count that as a win.
signature.asc
Description: OpenPGP digital signature
apol marked an inline comment as done.
apol added inline comments.
INLINE COMMENTS
> kfunk wrote in kjobwidgets.cpp:67
> `WId` is a `quintptr`: `src/gui/kernel/qwindowdefs.h:99:typedef
> QT_PREPEND_NAMESPACE(quintptr) WId;`
>
> Besides: `QVariant::fromValue(window->winId())` should work just
apol updated this revision to Diff 22686.
apol marked an inline comment as done.
apol added a comment.
Remove cast
REPOSITORY
R288 KJobWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8923?vs=22685=22686
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8923
kfunk added inline comments.
INLINE COMMENTS
> kjobwidgets.cpp:67
> +if (window) {
> +job->setProperty("window-id",
> QVariant::fromValue(qptrdiff(window->winId(;
> +}
`WId` is a `quintptr`: `src/gui/kernel/qwindowdefs.h:99:typedef
QT_PREPEND_NAMESPACE(quintptr) WId;`
apol updated this revision to Diff 22685.
apol added a comment.
Better API
REPOSITORY
R288 KJobWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8923?vs=22684=22685
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8923
AFFECTED FILES
src/kjobwidgets.cpp
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This way we can do the same with non-widget windows
REPOSITORY
R288 KJobWidgets
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8923
AFFECTED
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
I like the use of the 3-args QUrl::fromUserInput, I added it to Qt for such
purposes.
I don't like the hardcoded QDir::homePath(), this has to be done better...
In
elvisangelaccio added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8920
To: emateli, #frameworks, dfaure
Cc: #frameworks
44 matches
Mail list logo
