> On Dec. 26, 2016, 1:24 a.m., Aleix Pol Gonzalez wrote:
> > src/file/extractor/app.cpp, line 85
> > <https://git.reviewboard.kde.org/r/129703/diff/1/?file=488118#file488118line85>
> >
> > FWIW, something looks incorrect here, as it seems be using Urls as
check?
- Aleix Pol Gonzalez
On Dec. 25, 2016, 2:27 p.m., Anthony Fieroni wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git
tps://git.reviewboard.kde.org/r/129349/#comment67893>
Use `split(QLatin1Char('/'),...)`
Also this can be changed into splitRef?
- Aleix Pol Gonzalez
On Dec. 12, 2016, 7:48 p.m., Christian Ehrlicher wrote:
>
> --
tps://git.reviewboard.kde.org/r/129349/#comment67874>
You need to duplicate the API documentation.
src/file/fileindexerconfig.cpp (line 188)
<https://git.reviewboard.kde.org/r/129349/#comment67875>
Make this one call the `QStringRef` variant, not to duplicate code?
- Aleix Pol Gonza
org/r/129549/#comment67760>
Variables in cmake are case-sensitive. It should be the same as what you
pass to find_package: `${Inotify_FOUND}`.
(if that's not what the Find*.cmake file is doing, I'd consider it a bug)
- Aleix Pol Gonzalez
On Nov. 23, 2016, 3:06 p.m.,
uctor should be taking
care of it.
http://en.cppreference.com/w/cpp/language/move_constructor
- Aleix Pol Gonzalez
On Nov. 11, 2016, 5:58 p.m., Christian Ehrlicher wrote:
>
> ---
> This is an automatically generated e-mail. T
y wants to take responsibility
though. I'd say that if you plan to maintain it you can commit it.
- Aleix Pol Gonzalez
On Nov. 6, 2016, 12:39 a.m., Christian Ehrlicher wrote:
>
> ---
> This is an automatically generated e-mail.
458)
<https://git.reviewboard.kde.org/r/129182/#comment67173>
no space before the coma
- Aleix Pol Gonzalez
On Oct. 14, 2016, 11:11 p.m., Christian Ehrlicher wrote:
>
> ---
> This is an automatically generated e-mail.
tps://git.reviewboard.kde.org/r/129185/#comment67172>
You can use QBENCHMARK_ONCE and QBENCHMARK for some of this.
- Aleix Pol Gonzalez
On Oct. 14, 2016, 10:57 p.m., Christian Ehrlicher wrote:
>
> ---
> This is an automatica
tps://git.reviewboard.kde.org/r/129183/#comment67170>
That doesn't look right. It's not exported, we can have BIC changes.
- Aleix Pol Gonzalez
On Oct. 14, 2016, 10:58 p.m., Christian Ehrlicher wrote:
>
> ---
> This is an
tps://git.reviewboard.kde.org/r/129182/#comment67169>
add const
- Aleix Pol Gonzalez
On Oct. 14, 2016, 10:10 p.m., Christian Ehrlicher wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.rev
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127821/#review95134
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On May 3, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126644/#review90724
---
You changed a colon sign for an equal sign?
- Aleix Pol
Aleix Pol Gonzalez
On Nov. 9, 2015, 1:13 p.m., Jan Issac wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125496/#review86258
---
Ship it!
- Aleix Pol Gonzalez
On Oct. 2, 2015, 11:29 p.m
Pol Gonzalez
On Aug. 2, 2015, 11:29 p.m., David Faure wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
sprint, I think we
should move this into the kde:kwidgetsaddons repository, in an examples
subdirectory.
- Aleix Pol Gonzalez
On Aug. 12, 2014, 9:33 a.m., Laurent Navet wrote:
>
> ---
> This is an automatically generated e-mail.
662/#comment44726>
No need to check if it exists
src/file/main.cpp
<https://git.reviewboard.kde.org/r/119662/#comment44727>
Use qWarning
- Aleix Pol Gonzalez
On ago. 8, 2014, 11:49 a.m., Rohan Garg wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114933/#review63870
---
Is it meant to go to master? isn't it KDE4?
- Alei
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114933/#review63469
---
bump!
- Aleix Pol Gonzalez
On Jan. 16, 2014, 7:30 p.m
> On July 18, 2014, 10:33 a.m., Vishesh Handa wrote:
> > I'm fine with this change. Baloo will eventually become a framework, we may
> > as well get the process started.
Sure, but this is not the way to get the process started.
- Aleix
---
one first?
http://api.kde.org/frameworks-api/frameworks5-apidocs/
- Aleix Pol Gonzalez
On July 16, 2014, 12:41 p.m., Dan Vrátil wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewb
ou're doubting I'd suggest you to take a
look at another framework, such as KParts.
- Aleix Pol Gonzalez
On June 12, 2014, 5:47 p.m., Bernd Steinhauser wrote:
>
> ---
> This is an automatically generated e-mail.
CMakeLists.txt
<https://git.reviewboard.kde.org/r/118670/#comment41713>
Should be KF5FileMetaDataConfigVersion
- Aleix Pol Gonzalez
On June 12, 2014, 2:30 p.m., Bernd Steinhauser wrote:
>
> ---
> This is an automati
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117187/#review54598
---
Ship it!
looks ok
- Aleix Pol Gonzalez
On March 30, 2014
tps://git.reviewboard.kde.org/r/114933/#comment33589>
This should be QIcon::fromTheme()
- Aleix Pol Gonzalez
On Jan. 9, 2014, 9:17 p.m., Laurent Navet wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
26 matches
Mail list logo
