Re: Review Request 120078: workaround QTBUG-40584

2014-09-07 Thread Thomas Lübking
-showAboutApplication(); break; ^ make[2]: *** [src/CMakeFiles/KF5XmlGui.dir/kmainwindow.cpp.o] Error 1 make[1]: *** [src/CMakeFiles/KF5XmlGui.dir/all] Error 2 make: *** [all] Error 2 Thomas Lübking wrote: gah... blast. you can't trust anybody

Re: Review Request 120078: workaround QTBUG-40584

2014-09-07 Thread Thomas Lübking
-showAboutApplication(); break; ^ make[2]: *** [src/CMakeFiles/KF5XmlGui.dir/kmainwindow.cpp.o] Error 1 make[1]: *** [src/CMakeFiles/KF5XmlGui.dir/all] Error 2 make: *** [all] Error 2 Thomas Lübking wrote: gah... blast. you can't trust anybody

Re: Review Request 120078: workaround QTBUG-40584

2014-09-06 Thread Thomas Lübking
size to the QWidget size also see https://git.reviewboard.kde.org/r/119594/ Diffs (updated) - src/kmainwindow.cpp e273a76 Diff: https://git.reviewboard.kde.org/r/120078/diff/ Testing --- Hrvoje, see bug - not tested myself. Thanks, Thomas Lübking

Review Request 120078: workaround QTBUG-40584

2014-09-06 Thread Thomas Lübking
/kmainwindow.cpp e273a76 Diff: https://git.reviewboard.kde.org/r/120078/diff/ Testing --- Hrvoje, see bug - not tested myself. Thanks, Thomas Lübking

Re: Review Request 120078: workaround QTBUG-40584

2014-09-06 Thread Thomas Lübking
. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120078/#review65899 --- On Sept. 6, 2014, 9:09 vorm., Thomas Lübking wrote

Re: Review Request 120078: workaround QTBUG-40584

2014-09-06 Thread Thomas Lübking
size to the QWidget size also see https://git.reviewboard.kde.org/r/119594/ Diffs (updated) - src/kmainwindow.cpp e273a76 Diff: https://git.reviewboard.kde.org/r/120078/diff/ Testing --- Hrvoje, see bug - not tested myself. Thanks, Thomas Lübking

Re: Review Request 119594: fix FileDialog size restorage

2014-09-05 Thread Thomas Lübking
://git.reviewboard.kde.org/r/119594/diff/ Testing --- See https://git.reviewboard.kde.org/r/119512/ Thanks, Thomas Lübking ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119594: fix FileDialog size restorage

2014-09-05 Thread Thomas Lübking
://git.reviewboard.kde.org/r/119594/diff/ Testing --- See https://git.reviewboard.kde.org/r/119512/ Thanks, Thomas Lübking

Re: Review Request 119594: fix FileDialog size restorage

2014-09-04 Thread Thomas Lübking
/119594/#review63770 --- On Aug. 4, 2014, 11:57 vorm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594

Re: Review Request 119892: [Dolphin] Implement Add to archive option when dragging and dropping onto an archive file in dolphin

2014-09-04 Thread Thomas Lübking
On Aug. 29, 2014, 9:30 vorm., Frank Reininghaus wrote: Thanks for your work on this feature - I think that many users would really appreciate this. I think that Emmanuel's idea to add write support to the kioslave might be worth considering. However, implementing the drop on an

Re: Review Request 119594: fix FileDialog size restorage

2014-09-04 Thread Thomas Lübking
/119594/#review63770 --- On Aug. 4, 2014, 11:57 vorm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594

Re: OpenGL ES on project neon

2014-08-21 Thread Thomas Lübking
On Donnerstag, 21. August 2014 07:24:33 CEST, Martin Gräßlin wrote: btw, is there a way to run qdbus correctly from SSH? If I run it inside X11 konsole, I get all the stuff, if I run it from SSH, even with xhost and DISPLAY set, I don't get anything about kde: Sorry, no idea how to do that.

Re: Is Konqueror still a live project?

2014-08-17 Thread Thomas Lübking
On Sonntag, 17. August 2014 18:38:29 CEST, Thiago Macieira wrote: Konqueror and rekonq use the same engine. So what one renders, so does the other. The may ship with different defaults for khtml or webkit as backend. (Actually rekonq might even be linked to a newer version of QtWebkit in his

Re: Killing kdelibs master branch

2014-08-12 Thread Thomas Lübking
On Dienstag, 12. August 2014 14:41:31 CEST, Sebastian Kügler wrote: Reason, if I'm building kdelibs from git, my autopilot way would be cloning (which gives you the master branch, dunno what'd happen if there's no remote master in the origin), see master, and assume that I now have latest

Re: Killing kdelibs master branch

2014-08-12 Thread Thomas Lübking
On Dienstag, 12. August 2014 21:20:41 CEST, Albert Astals Cid wrote: Is git symbolic-ref refs/heads/master refs/heads/KDE/4.14 an option? Maybe, what does it do? Create a symbolic ref master that like the symbolic ref HEAD would (then) point KDE/4.14 Locally this just works fine -

Re: Review Request 119701: Fix bug #334271 : bad display of Dolphin status bar wdgets when a high DPI resolution is used

2014-08-11 Thread Thomas Lübking
On Aug. 11, 2014, 12:17 vorm., Christoph Feck wrote: dolphin/src/statusbar/dolphinstatusbar.cpp, line 120 https://git.reviewboard.kde.org/r/119701/diff/1/?file=303675#file303675line120 Where does the text for the spaceInfo come from? If it is possible to compute the widest string

Re: Review Request 119663: libkscreensaver: blank mouse cursor in startup code

2014-08-11 Thread Thomas Lübking
On Aug. 8, 2014, 3:35 nachm., Thomas Lübking wrote: Would it be sufficient to set the cursor on target instead of an application wide override? setOverrideCursor has this nasty stack behavior which could be troublesome in a library and I could eg. think of screensavers

Re: Review Request 119663: libkscreensaver: blank mouse cursor in startup code

2014-08-08 Thread Thomas Lübking
(or using an override on top ...) - Thomas Lübking On Aug. 8, 2014, 12:37 nachm., Wolfgang Bauer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119663

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList activities) method

2014-08-07 Thread Thomas Lübking
On Aug. 6, 2014, 5:04 nachm., Thomas Lübking wrote: src/netwm.cpp, line 4779 https://git.reviewboard.kde.org/r/119267/diff/3/?file=296945#file296945line4779 - qstrdup? (also new code issue) Ivan Čukić wrote: nstrdup is used all over the file, qstrdup not. Would

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList activities) method

2014-08-06 Thread Thomas Lübking
don't mind that at all (and it's used in the file anyway) there are objections against it and Martin might disapprove adding more. Like that much better, thanks =) Two of tehm comments are more to trigger a comment from Martin, but the issue one is I believe a copy 'n paste bug. - Thomas Lübking

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Thomas Lübking
/kdeplatformfiledialoghelper.h 406a4f1 src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 Diff: https://git.reviewboard.kde.org/r/119594/diff/ Testing --- See https://git.reviewboard.kde.org/r/119512/ Thanks, Thomas Lübking ___ Kde-frameworks-devel

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Thomas Lübking
On Aug. 3, 2014, 11:13 nachm., Lukáš Tinkl wrote: No change here, ie. it doesn't restore the file dialog geometry. Thomas Lübking wrote: what is your precise testcase? a bit remote because of your other patches: did you check that the correct platformtheme lib is used? (ran

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Thomas Lübking
, visit: https://git.reviewboard.kde.org/r/119594/#review63765 --- On Aug. 4, 2014, 11:57 vorm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 119593: Ensure there's a platform window before restoring the window geometry and then process the resize

2014-08-04 Thread Thomas Lübking
/119593/diff/ Testing --- See https://git.reviewboard.kde.org/r/119512/ Thanks, Thomas Lübking ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

2014-08-04 Thread Thomas Lübking
/#review63726 --- On Aug. 3, 2014, 7:16 nachm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Thomas Lübking
/kdeplatformfiledialoghelper.h 406a4f1 src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 Diff: https://git.reviewboard.kde.org/r/119594/diff/ Testing --- See https://git.reviewboard.kde.org/r/119512/ Thanks, Thomas Lübking

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Thomas Lübking
, visit: https://git.reviewboard.kde.org/r/119594/#review63765 --- On Aug. 4, 2014, 11:57 vorm., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 119593: Ensure there's a platform window before restoring the window geometry and then process the resize

2014-08-04 Thread Thomas Lübking
/119593/diff/ Testing --- See https://git.reviewboard.kde.org/r/119512/ Thanks, Thomas Lübking

Review Request 119593: Ensure there's a plastform window before restoring the window geometry

2014-08-03 Thread Thomas Lübking
Tinkl, and Martin Klapetek. Repository: kconfig Description --- summarized Diffs - src/gui/kwindowconfig.cpp c3cefb7 Diff: https://git.reviewboard.kde.org/r/119593/diff/ Testing --- See https://git.reviewboard.kde.org/r/119512/ Thanks, Thomas Lübking

Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

2014-08-03 Thread Thomas Lübking
, Thomas Lübking ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-03 Thread Thomas Lübking
be less elegant. In either case I don't see why bringing your own config re/storage. Lukáš Tinkl wrote: The trick with winId() unfortunately doesn't work, the dialog gets restored to the default size, not the saved one... :/ Any other ideas? Thomas Lübking wrote: I'm not gonna

Review Request 119593: Ensure there's a plastform window before restoring the window geometry

2014-08-03 Thread Thomas Lübking
Tinkl, and Martin Klapetek. Repository: kconfig Description --- summarized Diffs - src/gui/kwindowconfig.cpp c3cefb7 Diff: https://git.reviewboard.kde.org/r/119593/diff/ Testing --- See https://git.reviewboard.kde.org/r/119512/ Thanks, Thomas Lübking

Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

2014-08-03 Thread Thomas Lübking
, Thomas Lübking

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-03 Thread Thomas Lübking
be less elegant. In either case I don't see why bringing your own config re/storage. Lukáš Tinkl wrote: The trick with winId() unfortunately doesn't work, the dialog gets restored to the default size, not the saved one... :/ Any other ideas? Thomas Lübking wrote: I'm not gonna

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-02 Thread Thomas Lübking
be less elegant. In either case I don't see why bringing your own config re/storage. Lukáš Tinkl wrote: The trick with winId() unfortunately doesn't work, the dialog gets restored to the default size, not the saved one... :/ Any other ideas? Thomas Lübking wrote: I'm not gonna

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-02 Thread Thomas Lübking
be less elegant. In either case I don't see why bringing your own config re/storage. Lukáš Tinkl wrote: The trick with winId() unfortunately doesn't work, the dialog gets restored to the default size, not the saved one... :/ Any other ideas? Thomas Lübking wrote: I'm not gonna

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-02 Thread Thomas Lübking
be less elegant. In either case I don't see why bringing your own config re/storage. Lukáš Tinkl wrote: The trick with winId() unfortunately doesn't work, the dialog gets restored to the default size, not the saved one... :/ Any other ideas? Thomas Lübking wrote: I'm not gonna

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-01 Thread Thomas Lübking
be less elegant. In either case I don't see why bringing your own config re/storage. Lukáš Tinkl wrote: The trick with winId() unfortunately doesn't work, the dialog gets restored to the default size, not the saved one... :/ Any other ideas? Thomas Lübking wrote: I'm not gonna

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-01 Thread Thomas Lübking
be less elegant. In either case I don't see why bringing your own config re/storage. Lukáš Tinkl wrote: The trick with winId() unfortunately doesn't work, the dialog gets restored to the default size, not the saved one... :/ Any other ideas? Thomas Lübking wrote: I'm not gonna

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-01 Thread Thomas Lübking
be less elegant. In either case I don't see why bringing your own config re/storage. Lukáš Tinkl wrote: The trick with winId() unfortunately doesn't work, the dialog gets restored to the default size, not the saved one... :/ Any other ideas? Thomas Lübking wrote: I'm not gonna

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-01 Thread Thomas Lübking
be less elegant. In either case I don't see why bringing your own config re/storage. Lukáš Tinkl wrote: The trick with winId() unfortunately doesn't work, the dialog gets restored to the default size, not the saved one... :/ Any other ideas? Thomas Lübking wrote: I'm not gonna

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList activities) method

2014-07-31 Thread Thomas Lübking
/119267/#comment44293 Any chance we can make this a function return in netwm.h to be used by the lib, kactivities and kwin and plasma and whoever else? NETWM::allActivityUUID() or so? - Thomas Lübking On Juli 31, 2014, 10:09 vorm., Ivan Čukić wrote

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList activities) method

2014-07-31 Thread Thomas Lübking
On Juli 31, 2014, 12:03 nachm., Thomas Lübking wrote: src/kwindowinfo_x11.cpp, line 305 https://git.reviewboard.kde.org/r/119267/diff/2/?file=292848#file292848line305 Any chance we can make this a function return in netwm.h to be used by the lib, kactivities and kwin and plasma

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-31 Thread Thomas Lübking
be less elegant. In either case I don't see why bringing your own config re/storage. Lukáš Tinkl wrote: The trick with winId() unfortunately doesn't work, the dialog gets restored to the default size, not the saved one... :/ Any other ideas? Thomas Lübking wrote: I'm not gonna

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-07-31 Thread Thomas Lübking
On Juli 27, 2014, 11:17 vorm., Thomas Lübking wrote: drkonqi/gdbhighlighter.cpp, line 74 https://git.reviewboard.kde.org/r/119498/diff/1/?file=293510#file293510line74 an abort is not a crash ;-) If you hit this assert, the looked up (lineNr - 1) is somehow out

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-31 Thread Thomas Lübking
be less elegant. In either case I don't see why bringing your own config re/storage. Lukáš Tinkl wrote: The trick with winId() unfortunately doesn't work, the dialog gets restored to the default size, not the saved one... :/ Any other ideas? Thomas Lübking wrote: I'm not gonna

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-31 Thread Thomas Lübking
On Juli 30, 2014, 8:54 vorm., Vishesh Handa wrote: src/tagwidget.cpp, line 180 https://git.reviewboard.kde.org/r/119543/diff/1/?file=294417#file294417line180 Any reason you've combined the too functions? I don't remember why, but there was a point when it split up.

Re: Review Request 119543: Removed all KDialogs from balooWidgets

2014-07-31 Thread Thomas Lübking
wrote: You're right, QPointer it has to be. Thomas Lübking wrote: I don't wanna be a spoil spot, but if you delete a qobject while one of its (heaped) children is in a nested eventloop (ie. you're most likely deleting it from that eventloop), you'll usually hit a segfault just

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-07-30 Thread Thomas Lübking
On Juli 27, 2014, 11:17 vorm., Thomas Lübking wrote: drkonqi/gdbhighlighter.cpp, line 74 https://git.reviewboard.kde.org/r/119498/diff/1/?file=293510#file293510line74 an abort is not a crash ;-) If you hit this assert, the looked up (lineNr - 1) is somehow out

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-07-30 Thread Thomas Lübking
On Juli 27, 2014, 11:17 vorm., Thomas Lübking wrote: drkonqi/gdbhighlighter.cpp, line 74 https://git.reviewboard.kde.org/r/119498/diff/1/?file=293510#file293510line74 an abort is not a crash ;-) If you hit this assert, the looked up (lineNr - 1) is somehow out

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-07-29 Thread Thomas Lübking
On Juli 27, 2014, 11:17 vorm., Thomas Lübking wrote: drkonqi/main.cpp, line 111 https://git.reviewboard.kde.org/r/119498/diff/1/?file=293511#file293511line111 This can go unconditionally. Show really only shows the window. Becoming active and then raise

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-07-29 Thread Thomas Lübking
On Juli 27, 2014, 11:17 vorm., Thomas Lübking wrote: drkonqi/gdbhighlighter.cpp, line 74 https://git.reviewboard.kde.org/r/119498/diff/1/?file=293510#file293510line74 an abort is not a crash ;-) If you hit this assert, the looked up (lineNr - 1) is somehow out

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: If the only issue is the open ::exec() TODO, you might trick it by calling ::winId(), then restore the size and ultimately ::exec() Otherwise you could open an own nested eventloop instead of relying on the dialogs exec, but that'd

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Thomas Lübking
nested eventloop instead of relying on the dialogs exec, but that'd be less elegant. In either case I don't see why bringing your own config re/storage. - Thomas Lübking On Juli 28, 2014, 9:35 vorm., Lukáš Tinkl wrote

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: If the only issue is the open ::exec() TODO, you might trick it by calling ::winId(), then restore the size and ultimately ::exec() Otherwise you could open an own nested eventloop instead of relying on the dialogs exec, but that'd

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-07-27 Thread Thomas Lübking
. if the test is pointless altogether (i do not know. no idea. no record on drkonqui) just remove it with the comment in the commit message, but ifdeffing a void statement makes us look silly ;-) - Thomas Lübking On Juli 27, 2014, 9:16 vorm., Ian Wadham wrote

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread Thomas Lübking
anyway) kinit/kinit.cpp https://git.reviewboard.kde.org/r/119497/#comment44049 this and line 1504 look like debug leftovers? or are they needed for extra logging? - Thomas Lübking On Juli 27, 2014, 9:15 vorm., Ian Wadham wrote

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread Thomas Lübking
On Juli 27, 2014, 11:32 vorm., Thomas Lübking wrote: kinit/kinit.cpp, line 118 https://git.reviewboard.kde.org/r/119497/diff/1/?file=293442#file293442line118 this looks fishy, because this should be related to the Window System, not the OS (ie. if you're running X11 on Darwin

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread Thomas Lübking
On Juli 27, 2014, 11:32 vorm., Thomas Lübking wrote: kinit/kinit.cpp, line 118 https://git.reviewboard.kde.org/r/119497/diff/1/?file=293442#file293442line118 this looks fishy, because this should be related to the Window System, not the OS (ie. if you're running X11 on Darwin

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-27 Thread Thomas Lübking
On Juli 27, 2014, 11:32 vorm., Thomas Lübking wrote: kinit/kinit.cpp, line 118 https://git.reviewboard.kde.org/r/119497/diff/1/?file=293442#file293442line118 this looks fishy, because this should be related to the Window System, not the OS (ie. if you're running X11 on Darwin

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

2014-07-21 Thread Thomas Lübking
On Juli 20, 2014, 9:21 vorm., Thomas Lübking wrote: lib/konq/konq_operations.cpp, line 479 https://git.reviewboard.kde.org/r/119372/diff/2/?file=291313#file291313line479 is there any guarantee that all urls in lst are in the same directory? Arjun Ak wrote: what? you're

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-21 Thread Thomas Lübking
On Juli 21, 2014, 5:16 vorm., Ian Wadham wrote: So where are we leaving this? Any conclusions? Any solutions or further patches? Should we report the inconsistent handling of Native file dialogs as a bug on bugs.kde.org (without a patch this time)? If so, against what product

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

2014-07-21 Thread Thomas Lübking
((*it).path()); ... } This allows you to re-use the QFileInfo object w/o useless overhead and also removes a branch level. - Thomas Lübking On Juli 21, 2014, 2:12 nachm., Arjun Ak wrote: --- This is an automatically

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

2014-07-20 Thread Thomas Lübking
is at least a behavioral change and assumingly wrong) - Thomas Lübking On Juli 20, 2014, 8 vorm., Arjun Ak wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119372

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

2014-07-19 Thread Thomas Lübking
/r/119372/#comment43474 this looks while it applies to directories AND FILES. While moving a -w directory isn't possible, moving a -w file is, so this case needs to be catched? - Thomas Lübking On Juli 19, 2014, 4:44 nachm., Arjun Ak wrote

Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

2014-07-19 Thread Thomas Lübking
On Juli 19, 2014, 7:39 nachm., Thomas Lübking wrote: lib/konq/konq_operations.cpp, line 474 https://git.reviewboard.kde.org/r/119372/diff/1/?file=291253#file291253line474 this looks while it applies to directories AND FILES. While moving a -w directory isn't possible

[kde-promo] Re: The name of Applications 4.14 + 1

2014-07-17 Thread Thomas Lübking
On Donnerstag, 17. Juli 2014 20:54:57 CEST, Albert Astals Cid wrote: e.g., 2014.07 My problem with that is that it's too long to write +1 looks worse (we're looking for something relative nice looking and catchy here, not for something totally obvious) 0xe.c =) Cheers, Thomas Visit

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-15 Thread Thomas Lübking
at reviewing this patch, now that I have tested it on Apple OS X with a few different file-open and save situations. Thomas Lübking wrote: You'd need to request addition of the group to groups (just a formality to add the entry, ask sysadmin æt kde döt org), otherwise you've to add rene

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

2014-07-14 Thread Thomas Lübking
On Juli 12, 2014, 2:11 nachm., Aleix Pol Gonzalez wrote: kio/kfile/kfiledialog.cpp, line 316 https://git.reviewboard.kde.org/r/119243/diff/1/?file=289740#file289740line316 I don't know why you did that, but it doesn't look good. Marko Käning wrote: Actually, when submitting

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

2014-07-06 Thread Thomas Lübking
On Juli 5, 2014, 11:36 vorm., Arjun Ak wrote: dolphin/src/dolphinrecenttabsmenu.cpp, line 102 https://git.reviewboard.kde.org/r/118994/diff/5/?file=287351#file287351line102 Is it safe to 'delete' a QObject? shouldnt we be using deleteLater() There's no general rule. Deleting a

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Thomas Lübking
On June 30, 2014, 9:01 a.m., Martin Gräßlin wrote: src/kwindowinfo_x11.cpp, line 301 https://git.reviewboard.kde.org/r/119008/diff/2/?file=285388#file285388line301 are you sure it's Latin1? Normally string properties are utf8. Ivan Čukić wrote: Well, since those are UUIDs,

Re: Review Request 118946: Adding property _GTK_SHOW_WINDOW_MENU to NET::Properties2

2014-06-26 Thread Thomas Lübking
one *could* wait for some specified NETWM hint (to not cruft the lib with the gtk+ prop symbol: removing it from the enum is oc. not API stable, thus not possible) and be introduced even with KWin 5.0.3 or whatever the final name scheme will be ;-) - Thomas Lübking On June 26, 2014, 7:22 a.m

Re: Review Request 118928: Add support for showing window menu in NETRootInfo

2014-06-25 Thread Thomas Lübking
position. from their patch: the gobject device-id (so i assume we're supposed to link gdk, yes?) - Thomas Lübking On June 25, 2014, 6:17 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 118909: Imply SkipTaskbar and SkipPager depending on Window Type

2014-06-23 Thread Thomas Lübking
would not set floating dock override to bring its own titlebar)? While kwin (iirc by default) hides them for inactive windows, that's rather a feature. - By their nature, they should not be in the taskbar. But should they not appear in pagers? - Thomas Lübking On June 23, 2014, 6:50 p.m., Martin

Re: Date/Time related widgets crashing plasma-desktop

2014-06-23 Thread Thomas Lübking
On Montag, 23. Juni 2014 14:22:46 CEST, Lindsay Mathieson wrote: installed, kde-runtime-dbg kde-workspace-dbg kdelibs5-dbg Unfortunately, still no debug info You mean no Dr. Konqui? - run plasma-* in gdb gdb --args plasma-desktop 21 | tee plasma-desktop.dbg (gdb) run Program

Re: Date/Time related widgets crashing plasma-desktop

2014-06-23 Thread Thomas Lübking
On Montag, 23. Juni 2014 14:46:45 CEST, Lindsay Mathieson wrote: On Mon, 23 Jun 2014 02:35:31 PM Thomas Lübking wrote: Unfortunately, still no debug info You mean no Dr. Konqui? Nope, I mean gdb reports not debug info. gdb plasmoidviewer --nofork (not sure whether plasmoidviewer does

Re: Date/Time related widgets crashing plasma-desktop

2014-06-23 Thread Thomas Lübking
On Montag, 23. Juni 2014 22:55:47 CEST, Lindsay Mathieson wrote: On Mon, 23 Jun 2014 03:00:26 PM Thomas Lübking wrote: On Montag, 23. Juni 2014 14:46:45 CEST, Lindsay Mathieson wrote: ... I tried plasmoidviewer and plasma-desktop with --nofork, but no debug info for either. You get

Re: Review Request 118816: Don't crash konsole when a container destructs

2014-06-18 Thread Thomas Lübking
/118816/#comment42172 shouldn't the call to removeViewWidget() just be omitted from viewDestroyed(QObject* object) - I assume removing the widget from the stack is still required on dragging a tab out of the window? - Thomas Lübking On June 18, 2014, 7:24 p.m., Jeremy Whiting wrote

Re: Review Request 118750: Prevent use after free

2014-06-15 Thread Thomas Lübking
section. You've certainly my vote, since the present code is clearly wrong and this patch implies no behavioral change, but please wait whether somebody has to raise a veto (next few workdays) before pushing (though i doubt so) - Thomas Lübking On June 15, 2014, 8:18 a.m., Fabian Kosmale wrote

Re: Review Request 118750: Prevent use after free

2014-06-14 Thread Thomas Lübking
) - Thomas Lübking On June 14, 2014, 10:09 p.m., Fabian Kosmale wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118750

Re: PolicyKit1-KDE AuthDialog could not shown as TOP_LEVEL

2014-06-01 Thread Thomas Lübking
On Sonntag, 1. Juni 2014 09:16:46 CEST, Leslie Zhai wrote: so there is NO Apper assoicate WID for AuthDialog constructor. 2. KWindowSystem::forceActiveWindow sometimes worked BUT ... Sometimes it FAILED to force active window to act like modal one The window is not modal, since it's not

Re: PolicyKit1-KDE AuthDialog could not shown as TOP_LEVEL

2014-05-30 Thread Thomas Lübking
On Freitag, 30. Mai 2014 05:09:58 CEST, Leslie Zhai wrote: Hi KDE developers, My colleage reported a bug to me, it is about PolicyKit1-KDE AuthDialog UI behavior issue, the AuthDialog could not show as TOP_LEVEL That's called _NET_WM_STATE_ABOVE - toplevel usually refers to a window with the

Re: Review Request 112258: ksysguard process list: better keyboard navigation

2014-05-27 Thread Thomas Lübking
://git.reviewboard.kde.org/r/112258/#comment40757 ctrl+a will generate two key events, the second is not empty (though not printable string either) - (!(keyEvent-modifiers() (Qt::ControlModifier|Qt::AltModifier|Qt::MetaModifier) ... - Thomas Lübking On Nov. 6, 2013, 7:07 p.m

Re: kdesu does not work: Can not run kde applications as root

2014-05-25 Thread Thomas Lübking
On Sonntag, 25. Mai 2014 20:07:31 CEST, vedant agarwala wrote: I am unable to reproduce on my Kubuntu 14.04. For me there is no command `kdesu`. I use `kdesudo`. kdesu != kdesudo - completely different application. @Magnus either you try to run kdesu as root (or any other user that is not the

Re: Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB

2014-05-22 Thread Thomas Lübking
on this? - Thomas Lübking On May 22, 2014, 6:53 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118252

Re: Review Request 118217: Deprecate the animation argument for KWindowSystem::minimizeWindow and unminimize

2014-05-20 Thread Thomas Lübking
the taskbar (iirc) imo should only make sense in the showing desktop case (which is more or less detectable by the kwin core/effects) - and the animating effects completely ignored it anyway. - Thomas Lübking On May 20, 2014, 11:55 a.m., Martin Gräßlin wrote

Re: Review Request 118197: Fix regression in NETRootInfo::sendPing

2014-05-19 Thread Thomas Lübking
as well. - Thomas Lübking On May 19, 2014, 7:52 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118197

Re: Review Request 117044: Avoid unnecessary automounting in KDiskFreeSpaceInfo::freeSpaceInfo

2014-05-19 Thread Thomas Lübking
On May 19, 2014, 12:05 p.m., Frank Reininghaus wrote: We are seeing quite a few bug reports about a severe regression between KDE SC 4.13.0 and KDE SC 4.13.1: https://bugs.kde.org/show_bug.cgi?id=334776 According to the reporter of https://bugs.kde.org/show_bug.cgi?id=334988

Re: Review Request 117957: kcm_fonts: correctly restore default configuration values

2014-05-17 Thread Thomas Lübking
but certainly should whenever the entry changes for whatever reason (config value re-read, defaults applied, whatever) - Thomas Lübking On May 2, 2014, 7:59 p.m., Andrea Iacovitti wrote: --- This is an automatically generated e-mail

Re: Review Request 118167: Flush xcb connection after preparing KSelectionOwner::claim

2014-05-16 Thread Thomas Lübking
(); owner-claim(m_replace, true); +Xcb::sync(); Sufficient? (though it warns about a QPA crash later) b) Qt bug (should flush once per eventcycle) or feature (keeps dirty flag and only flushes on internal need)? - can such flag be set explicitly? - Thomas Lübking On May 16, 2014, 1 p.m., Martin

Re: Review Request 118167: Flush xcb connection after preparing KSelectionOwner::claim

2014-05-16 Thread Thomas Lübking
On May 16, 2014, 1:38 p.m., Thomas Lübking wrote: a) main.cpp, void Application::start() -Xcb::sync(); owner-claim(m_replace, true); +Xcb::sync(); Sufficient? (though it warns about a QPA crash later) b) Qt bug (should flush once per eventcycle) or feature (keeps

Re: Review Request 103478: Fix crash with --waitforwm

2014-05-13 Thread Thomas Lübking
-remove -root _NET_SUPPORTED; sleep 1; klipper --waitforwm sleep 30; kwin Assuming it would be relevant, you got a shipIt! from at least here - sorry for not reviewing before. - Thomas Lübking On May 12, 2014, 10:25 p.m., Christoph Feck wrote

Re: Compatibility problems with latest GTK+ applications

2014-05-09 Thread Thomas Lübking
On Freitag, 9. Mai 2014 14:42:50 CEST, Daniel Nicoletti wrote: does clicking on the shadow drawn by the window also prevents you from say focusing the window below (when no windeco is in place)? Afaics the entire shadow area is used for window resizing (you get the gtk+ cursor for that) It

Re: Compatibility problems with latest GTK+ applications

2014-05-09 Thread Thomas Lübking
On Freitag, 9. Mai 2014 13:44:18 CEST, John Layt wrote: Thanks for that link, it explains things very nicely. Between their lack of resources and the GnomeOS philosophy it will be interesting to see how they respond to our approaches: in the article they clearly state only a mass rebellion

Re: Compatibility problems with latest GTK+ applications

2014-05-07 Thread Thomas Lübking
On Mittwoch, 7. Mai 2014 12:08:19 CEST, Aleix Pol wrote: Personally, I don't think we want to even try to convince them against. They're introducing interaction within the decoration space so they are committed to the idea. That's actually not the point. The correct way would have been to say

Re: Re-initialize KCM on device hotplug

2014-05-07 Thread Thomas Lübking
On Mittwoch, 7. Mai 2014 13:13:33 CEST, Alexander Mezin wrote: Hi Is there any way to invoke kcminit function again when some hardware is plugged in? I can implement this in KDED module or make udev rule, but isn't there any built-in solution (key in kcm's desktop file, etc)? What's the

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Thomas Lübking
On May 6, 2014, 1:30 p.m., Kevin Ottens wrote: AFAICT it is BIC but no SIC, no brainer. Martin Gräßlin wrote: it's a SIC change as one could have used the variant specifying just NET::Properties and screen. This would now have to be changed to use NET::Properties2 before screen

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Thomas Lübking
argument. Thomas Lübking wrote: It's SIC. NETRootInfo(connection, properties, 1); would now cause an error, but since it's been buggy anyway (enums are indeed not polymorphic, but for int,... though gcc could have known better) that should hardly matter. @Marco got

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Thomas Lübking
argument. Thomas Lübking wrote: It's SIC. NETRootInfo(connection, properties, 1); would now cause an error, but since it's been buggy anyway (enums are indeed not polymorphic, but for int,... though gcc could have known better) that should hardly matter. @Marco got

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Thomas Lübking
argument. Thomas Lübking wrote: It's SIC. NETRootInfo(connection, properties, 1); would now cause an error, but since it's been buggy anyway (enums are indeed not polymorphic, but for int,... though gcc could have known better) that should hardly matter. @Marco got

<    1   2   3   4   5   6   7   8   9   10   >