Re: CI system maintainability

Hi, On Thu, 28 Mar 2019 at 15:21, Kevin Ottens wrote: > Hello, > > On Thursday, 28 March 2019 14:33:59 CET laurent Montel wrote: > > I am against to force mandatory review, as it will create a lot of lose > of > > time, > > As I said, unpopular. > I don't get why mandatory code reviews are so u

Re: libkcompactdisc test (testkcd) finds no tracks - wrong initialiser sent to the Phonon backend?

libkcompactdisc doesn't work and should either be deprecated or rewritten by someone who has access to an audio cd and a drive. Nothing actually uses libkcompactdisc. Freundliche Grüße Boudhayan Gupta KDE e.V. - Community Working Group +49 151 71032970 On 18 August 2017 at 09:24, Ren

Re: RE : Re: Send Email with attachment with my Qt Application

Hi Charles-Elie, On 17 November 2016 at 12:08, Charles-Élie G wrote: > Hi, > > In fact I think that KService must be built with CMake and after be used > with QMake or CMake. No ? Yes, that is correct. It must be built with CMake. We generate PRI files that enable it to be used by QMake based pr

Re: Send Email with attachment with my Qt Application

his helps. Thanks, Boudhayan Gupta On 16 November 2016 at 23:01, Charles-Elie Gentil wrote: > In fact I did not understand how to build KService, but I think I have > found: I probably have to create the .pro file myself. > > For the direct use of invokMailer, I have already tried but I ca

Re: Scrap Baloo Thread Feedback

Hi, Unfortunately I've been hit my multiple pretty severe health scares in the last month, and have no idea when I'm going to be at 100% again. For the time being I'd rather not hold up any development, so don't hold back anything on my account. -- Boudhayan On 16 October 2016 at 17:46, Christo

Re: Scrap baloo?

Hi, On 28 September 2016 at 20:33, Christoph Cullmann wrote: > Hi, > >> Hi, >> >> On 28 September 2016 at 02:36, Christoph Cullmann >> wrote: >>> any update? >> >> Yep. In all the happennings of the week I just forgot to write this email. >> >> If Baloo is going to be an integral part of the Pl

Re: Scrap baloo?

Hi, On 28 September 2016 at 02:36, Christoph Cullmann wrote: > any update? Yep. In all the happennings of the week I just forgot to write this email. If Baloo is going to be an integral part of the Plasma experience, do we really want to depend on an external project where we don't have control

Re: Scrap baloo?

Hi, On 16 September 2016 at 01:04, Christoph Cullmann wrote: >>> => Opinions? >> >> It would be nice to hear what Vishesh, Pinak and Boudhayan think about >> this. I prefer getting familiar with the code as well as having a mile-high view of what does what before I start laying down code, hence

Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

like a gigantic patch and I'm not sure I understand all of it right now. - Boudhayan Gupta On Sept. 12, 2016, 12:42 a.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 128891: Transaction not created => don't try to abort them

> On Sept. 12, 2016, 12:25 a.m., Boudhayan Gupta wrote: > > LGTM. > > > > Long term I plan to replace all of this with liblmdb++, but that may or may > > not happen soon-ish. > > Christoph Cullmann wrote: > Hi, lmdb++ is IMHO no good idea, look at the

Re: Review Request 128891: Transaction not created => don't try to abort them

with liblmdb++, but that may or may not happen soon-ish. - Boudhayan Gupta On Sept. 12, 2016, 12:21 a.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128890/#review99101 --- Ship it! Ship It! - Boudhayan Gupta On Sept. 11, 2016

Re: Taking over maintainership of Baloo

Hi, On 11 September 2016 at 22:59, Christoph Cullmann wrote: > I think the main issue is: There is no need to reproduce them, it is clear, > that baloo will crash > on any problem with lmdb, as "no" errors are handled (or lets say 99% of the > errors are not handled). > > The code is full of Q_

Re: Taking over maintainership of Baloo

ling list, or the frameworks bugs list if there is one? > Greetings > Christoph -- Boudhayan > > - Am 11. Sep 2016 um 19:08 schrieb Boudhayan Gupta bgu...@kde.org: > >> Hi all, >> >> Since Vishesh effectively stopped maintaining Baloo full-time, mostly >

Re: Review Request 128888: Improve epub extractor, less segfaults

ssume you tested things and nothing obvious regressed, and give you the ship-it. I'm also very interested in knowing how we have come about having a variable called `tit` ;-) - Boudhayan Gupta On Sept. 11, 2016, 10:32 p.m., Christoph Cull

Taking over maintainership of Baloo

Hi all, Since Vishesh effectively stopped maintaining Baloo full-time, mostly Pinak and to some extent I have been looking over bugs and reviewing RRs pertaining to Baloo. If there are no objections to the same (including if Pinak declines to either co-maintain it or would rather maintain it alone

Re: Review Request 128885: Increase size limit of baloo index for 64-bit machines

> On Sept. 11, 2016, 10:20 p.m., Boudhayan Gupta wrote: > > src/engine/database.cpp, line 107 > > <https://git.reviewboard.kde.org/r/128885/diff/1/?file=476712#file476712line107> > > > > This is clever, but I had to read it thrice to figure out what exa

Re: Review Request 128885: Increase size limit of baloo index for 64-bit machines

- the significant digits of the size followed by the multiplier. If there's a performance or strictness issue I'm not seeing, please tell me. - Boudhayan Gupta On Sept. 11, 2016, 4:27 p.m., Christoph Cullmann wrote: > > --

baloo + out-of-memory in file extractor

Hi Christoph, On 10 September 2016 at 23:46, Christoph Cullmann wrote: >>> Would it be a good idea to restrict the file extractor process to some >> fixed amount of memory >>> to use via setrlimit? (or more fancy stuff?) >> >> That would probably just make Baloo crash, so fixing the bug is probab

Re: baloo + out-of-memory in file extractor

obably just make Baloo crash, so fixing the bug is probably the better option. > > Greetings > Christoph -- Boudhayan Gupta > > -- > - Dr.-Ing. Christoph Cullmann - > AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com >

Re: KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it useless

Just a naive question (sorry if I miss the point). If the use of the > don't-show-again pluggin is critical to your app, can't you also add a > strong dependency on frameworkintegration to your app ? The point here is, "Don't show me again" is a core feature, from an

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On May 17, 2016, 8:07 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

Re: Review Request 125762: External extractor plugin support for KFileMetaData

-ef966a6339d4__kfilemetadata_extractor_executable Thanks, Boudhayan Gupta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127179: Add external extractor plugin support

-- On Feb. 26, 2016, 12:02 a.m., Varun Joshi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127179/ > --- > > (Updated Feb. 26, 2016, 12:

Re: Review Request 127179: Add external extractor plugin support

torcollection.cpp (line 4) <https://git.reviewboard.kde.org/r/127179/#comment63204> Copyright who? src/extractorcollection.cpp (line 81) <https://git.reviewboard.kde.org/r/127179/#comment63205> Cat-on-keyboard? ;-) src/extractors/externalextractors/pdfextractor/main.py (line 40) <htt

Re: Review Request 127158: Adds writer and external (extractor and writer) plugin support

tures, you'll have to commit them in three different commits anyway. - Boudhayan Gupta On Feb. 24, 2016, 3:33 a.m., Varun Joshi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: building everything with a set of specific preprocessor token(s)/definition(s)?

ake it less trivial to rely on settings passed > through the environment. Hence my idea of using CC/CXX rather than the *FLAGS env-vars. -- Boudhayan Gupta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: building everything with a set of specific preprocessor token(s)/definition(s)?

On 14 February 2016 at 19:31, René J.V. wrote: > Hi, > > I'd like to investigate something Qt-related that would require me to build > all frameworks with a specific set of preprocessor tokens defined. Rather > than patching all toplevel CMake files I'm hoping for way to define those > tokens i

Re: Review Request 126949: Remove Air and Oxygen themes

> On Feb. 2, 2016, 1:42 a.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "unma

Re: Review Request 126949: Remove Air and Oxygen themes

only two themes - the default one and a high-contrast counterpart. In fact all other themes should reside elsewhere. If we still want to "officially" provide Air and Oxygen, maybe we should move them to an extra-themes package instead instead of kde-look? - Boudhayan Gupta On Feb.

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

saves and restores just that, but I guess you'd want > me to include maximised state and what else?) > > Boudhayan Gupta wrote: > Don't just lift code. See what it does and then implement it your own > way. Licensing between Qt and KDE are incompatible (quote: code may not be

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 14, 2015, 5:17 p.m., Marco Martin wrote: > > src/gui/CMakeLists.txt, line 22 > > > > > > we really can't add a dependency to QWidgets here. > > depending on qwidgets will make many potential interest

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

y; they're a reflection of > application interface state (@). Maybe a subtle difference (and maybe a > debate that was already held a long time ago), but doesn't this rather (or > better) belong in KWindowSystem? > > @) Off-topic, but like other state variables sa

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 14, 2015, 12:23 p.m., Martin Gräßlin wrote: > > src/gui/CMakeLists.txt, line 2 > > > > > > this introduces a QtWidgets dependency and thus changes the integration > > level of the framework. I highly rec

Re: Moving KWayland to frameworks

On 10 December 2015 at 12:32, Martin Graesslin wrote: > yes, that's the annoying one which is lots of work and lots of possible > regressions. I'm not sure whether I'm willing to do that work which I consider > a useless exercise. In my opinion this discussion is an useless exercise, because: >

Re: Review Request 125762: External extractor plugin support for KFileMetaData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/#review89174 --- On Oct. 24, 2015, 5:49 p.m., Boudhayan Gupta wrote: > > -

Re: Purpose as a KDE Framework

Hi Aleix, On 3 December 2015 at 23:51, Aleix Pol wrote: > On Tue, Dec 1, 2015 at 5:10 PM, Boudhayan Gupta wrote: >> On 1 December 2015 at 20:42, Aleix Pol wrote: >>>> 1. I'd like to be able to load the list of plugins available per >>>> mimetype a prior

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 3:15 p.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > <https://git.reviewboard.kde.org/r/126198/diff/3/?file=420466#file420466line39> > > > > This makes me very nervous. > > > > Using

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 3:15 p.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > <https://git.reviewboard.kde.org/r/126198/diff/3/?file=420466#file420466line39> > > > > This makes me very nervous. > > > > Using

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 3:15 p.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > <https://git.reviewboard.kde.org/r/126198/diff/3/?file=420466#file420466line39> > > > > This makes me very nervous. > > > > Using

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

ck code and interact with it to get the cursor released. Giant hack, but at least no private API usage. Private API is **private** for a reason. - Boudhayan Gupta On Dec. 2, 2015, 1:59 a.m., René J.V. Bertin wrote: > > ---

Re: Purpose as a KDE Framework

On 1 December 2015 at 20:42, Aleix Pol wrote: >> 1. I'd like to be able to load the list of plugins available per >> mimetype a priori before the filename to share becomes available. > You can pass { "mimetype": "image/png", "urls": [] }. > > That should work. > I'm not sure why you'd want to list

Re: Purpose as a KDE Framework

On 1 December 2015 at 19:31, Aleix Pol wrote: > Hi, > I've been working on Purpose since some months now, with the intention > of becoming a framework some day. +1. I intend to port Spectacle to use it instead of KIPI for uploading images to online sites, and I love the API's simplicity. I only

Re: Scope of framework integration plugin?

On 30 November 2015 at 17:32, Aleix Pol wrote: > On Mon, Nov 30, 2015 at 12:48 PM, Martin Graesslin wrote: >> Opinions? > > Hi, > I agree with you, I've proposed the same thing as you in the past, > although there's some issues that would then need to be sorted. > > What you actually want is, IMH

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

it: https://git.reviewboard.kde.org/r/126091/#review88757 --- On Nov. 24, 2015, 5:23 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

marked as submitted. Review request for KDE Frameworks, Plasma and David Edmundson. Changes --- Submitted with commit a8c177911dea1e099bfb499f199ee7039c756cde by Boudhayan Gupta to branch master. Repository: khotkeys Description --- After moving KSnapshot to Extragear I&#x

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

-packagers mailing list posting (in fact, no comments at all), I'm committing this to Plasma/5.5 and merging to master. Reference to posting: https://mail.kde.org/pipermail/kde-distro-packagers/2015-November/000107.html - Boudhayan Gupta On Nov. 16, 2015, 10:36 p.m., Boudhayan Gupta

Re: Review Request 126110: Clean up and armour Baloo::Database::open()

marked as submitted. Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa. Changes --- Submitted with commit 22ade345757b7c080597f5f062b7ebb6e45a2c3d by Boudhayan Gupta to branch master. Bugs: 353757 http://bugs.kde.org/show_bug.cgi?id=353757 Repository: baloo

Re: Review Request 126110: Clean up and armour Baloo::Database::open()

ted e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126110/#review88751 ------- On Nov. 19, 2015, 5:09 p.m., Boudhayan Gupta wrote: > > --- > This is an

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

> On Nov. 16, 2015, 10:46 p.m., Hrvoje Senjan wrote: > > >assuming, that is, distros push out the updates together > > > > don't assume this ;-) at least send a mail to kde-distro-packagers about > > the sideeffects if those 3 are pushed asynchronously >

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 18, 2015, 12:52 p.m., Martin Gräßlin wrote: > > src/plugins/osx/macpoller.cpp, lines 222-227 > > > > > > seriously? You care about idle timeouts below 5 msec? This is a > > framework to tell the applic

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

Hi all, On 19 November 2015 at 15:06, René J.V. wrote: > On Thursday November 19 2015 08:10:08 Martin Graesslin wrote: >> the code else where, but because the issues pointed out would be unresolved >> giving users of your code a bad framework and thus harming both your users as >> well as the fra

Re: Review Request 126110: Clean up and armour Baloo::Database::open()

an up m_env after failure, not just set it to 0 Diffs - src/engine/database.cpp e39eb86 Diff: https://git.reviewboard.kde.org/r/126110/diff/ Testing --- Builds, runs, does not crash. make test succeeds at 100% Thanks, Boudhayan

Review Request 126110: Clean up and armour Baloo::Database::open()

/diff/ Testing --- Builds, runs, does not crash. make test succeeds at 100% Thanks, Boudhayan Gupta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

marked as submitted. Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa. Changes --- Submitted with commit 1e880e29883561c8330cb81c03b48716ea68616c by Boudhayan Gupta to branch master. Repository: baloo Description --- Add a check in Baloo::Database::open() to

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

> On Nov. 19, 2015, 1:36 a.m., Thomas Lübking wrote: > > Errr... you intend to crash applications depending on whether some file is > > present?? > > Please fix the actual bug instead of such workaround, got a backtrace? > > Boudhayan Gupta wrote: > Err... it

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

/git.reviewboard.kde.org/r/126105/#review88556 --- On Nov. 19, 2015, 1:10 a.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

------- On Nov. 19, 2015, 1:10 a.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126105/ > -

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

> On Nov. 19, 2015, 1:36 a.m., Thomas Lübking wrote: > > Errr... you intend to crash applications depending on whether some file is > > present?? > > Please fix the actual bug instead of such workaround, got a backtrace? > > Boudhayan Gupta wrote: > Err... it

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

il. To reply, visit: https://git.reviewboard.kde.org/r/126105/#review88544 --- On Nov. 19, 2015, 1:10 a.m., Boudhayan Gupta wrote: > > --- > This is an automatically generat

Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

-- Builds, runs, doesn't crash anymore, the works. Thanks, Boudhayan Gupta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

Boudhayan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88456 --- On Nov. 16, 2015, 10:36 p.m., Boudhayan Gu

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

sit: https://git.reviewboard.kde.org/r/126091/#review88438 ------- On Nov. 16, 2015, 10:36 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

.txt f3bcb57 data/printscreen.khotkeys e583311 Diff: https://git.reviewboard.kde.org/r/126091/diff/ Testing --- Doesn't install the printscreen.khotkeys file anymore Thanks, Boudhayan Gupta ___ Kde-frameworks-devel mailing list Kde-frame

Re: Review Request 125762: External extractor plugin support for KFileMetaData

> On Oct. 30, 2015, 12:43 p.m., Boudhayan Gupta wrote: > > Ping? :-) Err, ship it or drop it? It's been about two weeks sitting, so I was hoping to get some feedback now, either way. - Boudhayan --- This is an automatic

Re: Failure while executing KTar::open while using KCompressionDevice as the device

I'd first ascertain whether the file is corrupt. Why don't you dump the tar to a QFile and manually use tar -xvf to extract it, just to test whether the download is working? On 2 November 2015 at 23:23, Luiz Romário Santana Rios wrote: > Hello, > > I'm trying to decompress a XZ archive downloaded

Re: Review Request 125762: External extractor plugin support for KFileMetaData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/#review87719 --- Ping? :-) - Boudhayan Gupta On Oct. 24, 2015, 5:49 p.m

Re: Review Request 125762: External extractor plugin support for KFileMetaData

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/#review87334 --- On Oct. 24, 2015, 5:49 p.m., Boudhayan Gupta wrote: > >

Re: Review Request 125762: External extractor plugin support for KFileMetaData

) with the dump manual test in KFileMetaData. Works. File Attachments kfilemetadata_extractor_executable https://git.reviewboard.kde.org/media/uploaded/files/2015/10/23/146b657f-31d9-4117-a82f-ef966a6339d4__kfilemetadata_extractor_executable Thanks, Boudhayan Gupta

Re: Review Request 125641: Allow PAM unlocking of a running wallet

tps://git.reviewboard.kde.org/r/125641/#comment59969> Is this necessary? Shouldn't KWallet::Wallet::isOpen() fail nicely if the wallet isn't running? - Boudhayan Gupta On Oct. 16, 2015, 10:22 p.m., Martin Klapetek wrote: > > --

Re: Review Request 125641: Allow PAM unlocking of a running wallet

allet is unlocked, why are you trying to unlock it? +1 on the use-cases; I don't know much about kwallet's or PAM's internals to thoroughly review the code. This is important - needs a review. - Boudhayan Gupta On Oct

Re: Review Request 125762: External extractor plugin support for KFileMetaData

/146b657f-31d9-4117-a82f-ef966a6339d4__kfilemetadata_extractor_executable Thanks, Boudhayan Gupta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125762: External extractor plugin support for KFileMetaData

kfilemetadata_extractor_executable https://git.reviewboard.kde.org/media/uploaded/files/2015/10/23/146b657f-31d9-4117-a82f-ef966a6339d4__kfilemetadata_extractor_executable Thanks, Boudhayan Gupta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 125763: Add Skip Close Animation to NET::Property2

st a fixed patch tomorrow. - Boudhayan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125763/#review87302 --- On Oct. 23, 2015, 4:11 p.

Re: Review Request 125762: External extractor plugin support for KFileMetaData

://git.reviewboard.kde.org/media/uploaded/files/2015/10/23/146b657f-31d9-4117-a82f-ef966a6339d4__kfilemetadata_extractor_executable Thanks, Boudhayan Gupta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Review Request 125763: Add Skip Close Animation to NET::Property2

/125763/diff/ Testing --- Only build-tested. Thanks, Boudhayan Gupta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125762: External extractor plugin support for KFileMetaData

test in KFileMetaData. Works. File Attachments kfilemetadata_extractor_executable https://git.reviewboard.kde.org/media/uploaded/files/2015/10/23/146b657f-31d9-4117-a82f-ef966a6339d4__kfilemetadata_extractor_executable Thanks, Boudhayan Gupta

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

CREATION > src/platforms/xcb/atoms_p.h b5a6e7e > src/platforms/xcb/kwindoweffects.cpp c8da6d2 > src/platforms/xcb/kwindoweffects_x11.h c240ddf > > Diff: https://git.reviewboard.kde.org/r/125736/diff/ > > > Testing > --- > > * make test succeeds w

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

> On Oct. 21, 2015, 8:08 p.m., Martin Gräßlin wrote: > > src/kwindoweffects.h, line 172 > > <https://git.reviewboard.kde.org/r/125736/diff/3/?file=412098#file412098line172> > > > > looks like you removed an empty line > > Boudhayan Gupta wrote: >

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

skipCloseAnimation unit with the old plugin installed. skipCloseAnimation segfaults. Thanks, Boudhayan Gupta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

. Removed an empty line? - Boudhayan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125736/#review87206 --- On Oct. 21,

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

> On Oct. 21, 2015, 8:19 p.m., Boudhayan Gupta wrote: > > src/platforms/xcb/kwindoweffects_x11.h, line 26 > > <https://git.reviewboard.kde.org/r/125736/diff/3/?file=412105#file412105line26> > > > > This was my idea, which sitter also liked and is used in Ph

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

> On Oct. 21, 2015, 8:19 p.m., Boudhayan Gupta wrote: > > src/platforms/xcb/kwindoweffects_x11.h, line 26 > > <https://git.reviewboard.kde.org/r/125736/diff/3/?file=412105#file412105line26> > > > > This was my idea, which sitter also liked and is used in Ph

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

class, that way plugins can choose to implement only the extra features they want. For example if I add feature A in class 1, then feature B in class 2, but a plugin only wants to implement feature B without implementing feature A, they can't if you do what you're asking. - Bo

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

plugin installed. skipCloseAnimation segfaults. Thanks, Boudhayan Gupta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

Hi Friedrich, On 27 September 2015 at 20:55, Friedrich W. H. Kossebau wrote: > Some bummer here: > a) not all libraries are in repositories of their own > b) not all libraries are released on the same cycle > > E.g. a) happens because the libs could be shared libs for sharing between > multiple e

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

On 27 September 2015 at 22:51, Sune Vuorela wrote: > On 2015-09-27, Boudhayan Gupta wrote: >> What I propose is that all libraries which want to manage their own >> release cycles and their own namespaces, be moved to Extragear Libs >> and release from there. All the librari

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

On 27 September 2015 at 04:09, Albert Astals Cid wrote: > El Diumenge, 27 de setembre de 2015, a les 04:01:26, Boudhayan Gupta va > escriure: >> On 27 September 2015 at 03:36, Albert Astals Cid wrote: >> > El Dissabte, 26 de setembre de 2015, a les 16:27:22, Sune Vuorela va

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

On 27 September 2015 at 15:29, Sune Vuorela wrote: > On 2015-09-26, Boudhayan Gupta wrote: >> We could kill two birds with one stone here, creating a new KDE module >> just for libraries (say, KDE Companion Libraries or something) and put >> everything in the KC5 (

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

On 27 September 2015 at 10:29, Alexander Potashev wrote: > 2015-09-27 1:39 GMT+03:00 Albert Astals Cid : >> El Diumenge, 27 de setembre de 2015, a les 04:01:26, Boudhayan Gupta va >> escriure: >>> On 27 September 2015 at 03:36, Albert Astals Cid wrote: >>> >

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

On 27 September 2015 at 03:36, Albert Astals Cid wrote: > El Dissabte, 26 de setembre de 2015, a les 16:27:22, Sune Vuorela va escriure: >> On 2015-09-26, Alexander Potashev wrote: >> > 1. Many people prefer a "KF5" prefix, e.g. libKF5Screen.so). >> > 2. Another way of naming is a -qt5 suffix, e.