Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

started using KDevelop on Windows. Awesome! Thanks for this. - Kevin Funk On Aug. 24, 2015, 11:35 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

On Monday 24 August 2015 10:00:43 Martin Gräßlin wrote: > Am 2015-08-24 01:03, schrieb Kevin Funk: > > Right now whenever I start kdevelop I get the following daemons up and > > running > > on Windows: > > - dbus-daemon > > - kded5 > > - kglob

Re: Review Request 124896: Fix bad behavior / running OOM on Windows

27; to 'unsigned long', possible loss of data BUG: 345860 Diffs - src/kzoneallocator.cpp 2ab9bb021ff09445f291f69ecc3f6facde7eed22 Diff: https://git.reviewboard.kde.org/r/124896/diff/ Testing --- Thanks, Kevin Funk ___ Kde-fr

Review Request 124896: Fix bad behavior / running OOM on Windows

ator.cpp 2ab9bb021ff09445f291f69ecc3f6facde7eed22 Diff: https://git.reviewboard.kde.org/r/124896/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

p and running on Windows: - dbus-daemon - kded5 - kglobalaccel5 - kioslave - klauncher For the one-app use-case: Which ones do I need? How to stop them from being started? (Sorry, but I never really looked into that matter either, so any help welcome here). Given that KIO slaves can be invoked vi

Re: Review Request 124879: Optimization readEntryGui

marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Changes --- Submitted with commit a21e85d97f809870de94c84d2ca767260477f988 by Kevin Funk to branch master. Repository: kconfig Description --- Don't attempt to build error string in any case

Re: Review Request 124879: Optimization readEntryGui

, visit: https://git.reviewboard.kde.org/r/124879/#review84189 --- On Aug. 22, 2015, 5:11 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Review Request 124879: Optimization readEntryGui

: kconfig Description --- Don't attempt to build error string in any case Diffs - src/gui/kconfiggroupgui.cpp e2eb950fb93d40abec0988c9af58c1ae14cb2011 Diff: https://git.reviewboard.kde.org/r/124879/diff/ Testing --- Thanks, Kevin

Re: Minimum supported version of MSVC for frameworks

version to MSVC2013? I feel like people don't really want to revert the C++11 portions of code they've written until now anyway... Cheers, Kevin > Alex > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org

Minimum supported version of MSVC for frameworks

still broken) C++11 support anyway) Opinions? If you want, I can make sure KF5 builds on MSVC2013, at least, in irregular intervals. Cheers [1] https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11 [2] https://paste.kde.org/pspfos96w -- Kevin Funk

Re: Review Request 124696: Fix (worrying) MSVC warning

marked as submitted. Review request for KDE Frameworks and Mirko Boehm. Changes --- Submitted with commit ea52fb68bad35c91ed2cb39dc8cd0aeeea2f4f48 by Kevin Funk to branch master. Repository: threadweaver Description --- Warning: Z:\kderoot\download\git\threadweaver\src

Review Request 124696: Fix (worrying) MSVC warning

2671a02f330cd3022e0692a0343fe4 Diff: https://git.reviewboard.kde.org/r/124696/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124542: CMake fixes for Windows build

marked as submitted. Review request for Documentation, KDE Frameworks and Luigi Toscano. Changes --- Submitted with commit 38265304276e6305f72a7e1a68aa1b4193657820 by Kevin Funk to branch master. Bugs: 348061 https://bugs.kde.org/show_bug.cgi?id=348061 Repository: kdoctools

Re: Review Request 124542: CMake fixes for Windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83574 --- @Luigi: Bump? - Kevin Funk On Aug. 6, 2015, 6:37 a.m

Re: Review Request 124542: CMake fixes for Windows build

://git.reviewboard.kde.org/r/124542/diff/ Testing --- Adding ':' to the list of escaped characters is probably not an ideal solution, but let me hear your ideas. Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-dev

Re: Review Request 124542: CMake fixes for Windows build

Diff: https://git.reviewboard.kde.org/r/124542/diff/ Testing --- Adding ':' to the list of escaped characters is probably not an ideal solution, but let me hear your ideas. Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-

Re: Review Request 124577: Fix Windows build

marked as submitted. Review request for KDE Frameworks and Martin Klapetek. Changes --- Submitted with commit a0fcb7d7ab14f379fabf440491ce40298ec0b540 by Kevin Funk to branch master. Repository: kwallet Description --- Fix Windows build Diffs - src/runtime/kwalletd/main.cpp

Review Request 124577: Fix Windows build

: kwallet Description --- Fix Windows build Diffs - src/runtime/kwalletd/main.cpp 3e98befadb99dc81e65c7d0586f13bd1b375ad42 Diff: https://git.reviewboard.kde.org/r/124577/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel

Re: Review Request 124542: CMake fixes for Windows build

e3868fc4f22324d25f680c13609bfb92b8b7c41d Diff: https://git.reviewboard.kde.org/r/124542/diff/ Testing --- Adding ':' to the list of escaped characters is probably not an ideal solution, but let me hear your ideas. Thanks, Kevin Funk ___ Kde-

Re: Review Request 124542: CMake fixes for Windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83249 --- On July 31, 2015, 7:34 a.m., Kevin Funk wrote: > >

Re: Review Request 124542: CMake fixes for Windows build

ules", but CMake did not find one. ``` (I can also push this separately) - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83214 -------

Review Request 124542: CMake fixes for Windows build

he list of escaped characters is probably not an ideal solution, but let me hear your ideas. Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

> On May 13, 2015, 6:45 a.m., Kevin Funk wrote: > > I'd reorder the code: > > > > ``` > > ... > > > > include(FeatureSummary) > > > > find_package(ECM ...) > > set_target_properties(ECM ...) > > feature_summary(...) > &g

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

mmary) find_package(ECM ...) set_target_properties(ECM ...) feature_summary(...) ... ``` I know that it is a bit harder to script this way , but helps code readability :D - Kevin Funk On May 13, 2015, 12:28 a.m., Jeremy Whiting

Re: Install location of myframework_version.h headers

On Monday 04 May 2015 14:11:14 Kevin Funk wrote: > On Monday 04 May 2015 13:11:05 David Faure wrote: > > On Monday 04 May 2015 12:29:39 David Faure wrote: > > > On Monday 04 May 2015 12:23:32 Kevin Funk wrote: > > > > The issue could be easily fixed by moving the myfr

Re: Install location of myframework_version.h headers

On Monday 04 May 2015 13:11:05 David Faure wrote: > On Monday 04 May 2015 12:29:39 David Faure wrote: > > On Monday 04 May 2015 12:23:32 Kevin Funk wrote: > > > The issue could be easily fixed by moving the myframework_version.h into > > > $PREFIX/include/KF5/$FRAME

Re: Install location of myframework_version.h headers

On Monday, May 04, 2015 12:23:32 Kevin Funk wrote: > Heya, > > I'm wondering why, for instance, ktexteditor_version.h is installed to > $PREFIX/include/KF5 instead of $PREFIX/include/KF5/KTextEditor. > > This currently leads to confusing behavior when trying to inclu

Install location of myframework_version.h headers

it? The issue could be easily fixed by moving the myframework_version.h into $PREFIX/include/KF5/$FRAMEWORK/, no? Greets -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part. ___ Kde-fram

Re: Versioning of Frameworks

On Wednesday, April 29, 2015 21:43:20 David Faure wrote: > On Wednesday 29 April 2015 11:24:48 Kevin Funk wrote: > > Use-case: Potential contributor working on KDevelop: > > - Has KF5 installed from distro packages > > - KDevelop/KDevPlatform compiled from Git > > - T

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On April 24, 2015, 3:49 p.m., Kevin Funk wrote: > > modules/ECMGeneratePriFile.cmake, line 180 > > <https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line180> > > > > Just tested the patch myself on sonnet. > > > >

Re: Versioning of Frameworks

's currently larger, but we should be > able to get it down to that): > > * PIM (not yet part of frameworks) > ** KCalendarCore > ** KCalendarUtils > ** KMIME > ** KIMAP > ** KContacts > > * Current Frameworks > ** ECM > ** KCoreAddons > ** KConfig &g

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

> On April 24, 2015, 3:49 p.m., Kevin Funk wrote: > > modules/ECMGeneratePriFile.cmake, line 180 > > <https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line180> > > > > Just tested the patch myself on sonnet. > > > >

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

g the right `QMAKEPATH` set during the test run imposes another burden on the user, however. What about adding: ``` set_tests_properties(... PROPERTIES ENVIRONMENT QMAKEPATH=${qt_host_data_dir} ``` - Kevin Funk On April 24, 2015, 3:26 p.m., Albert Astal

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

just spotted that the .pri file for SonnetUi doesn't have SonnetCore in its dependency list... => Bug? :) - Kevin Funk On April 24, 2015, 2:53 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

tps://git.reviewboard.kde.org/r/123491/#comment54298> Rather: `${PRI_TARGET_BASENAME}_test.pro`? (Uses the correct suffix) - Kevin Funk On April 24, 2015, 2:53 p.m., Albert Astals Cid wrote: > > --- > This is a

Re: Review Request 123452: Expose KJob::capabilities property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123452/#review79421 --- Ship it! Ship It! - Kevin Funk On April 21, 2015, 4:24

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

tps://git.reviewboard.kde.org/r/123229/#comment53832> You could use http://doc.qt.io/qt-5/qcoreapplication.html#Q_COREAPP_STARTUP_FUNCTION + a queued method invocation to make sure `QApplication` was fully constructed. - Kevin Funk On April 7, 2015, 1:46 p.m., Aleix Pol Gonzalez

Re: Review Request 122910: Introduce KMoreTools

> On March 15, 2015, 10:31 a.m., Dominik Haumann wrote: > > src/kmoretools/kmoretools.h, line 412 > > > > > > Qt API never returns a this pointer when settings some properties. > > > > While not explicit

Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)

boxtest.cpp <https://git.reviewboard.kde.org/r/122613/#comment52572> Just create on the stack? - Kevin Funk On Feb. 17, 2015, 10:29 p.m., Àlex Fiestas wrote: > > --- > This is an automatically generated

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

eworks-add-override.patch Without 'virtual' https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/8c42d21f-6a7b-496f-addf-757cb45dbc77__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: OSX/CI: kde-baseapps fails to build for branch-group "stable-kf5-qt5"

On Friday 13 February 2015 21:56:42 Ben Cooksley wrote: > On Fri, Feb 13, 2015 at 9:52 PM, Kevin Funk wrote: > > On Friday 13 February 2015 08:49:10 Marko Käning wrote: > >> Hi Albert, > >> > >> I just realised that kde-baseapps fails on OSX/CI when being bui

Re: OSX/CI: kde-baseapps fails to build for branch-group "stable-kf5-qt5"

quot;/Users/marko/WC/KDECI-builds/stable-kf5-qt5/kde-baseapps/build/CMakeFiles/ > CMakeOutput.log". > > KDE Continuous Integration Build > == Building Project: kde-baseapps - Branch Applications/14.12 > --- > > > Any idea what goes wrong? > > Regards, > Marko > ___

Re: Review Request 122551: New feature: Open all recent files

) has session management which probably solves your issue? It saves the session when you close it, and re-opens all the files that had been opened. - Kevin Funk On Feb. 12, 2015, 11:56 p.m., Thomas Murach wrote: > > --- > This is an

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

--- On Feb. 12, 2015, 3:47 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122542/ > --

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

6393__frameworks-add-override.patch Without 'virtual' https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/8c42d21f-6a7b-496f-addf-757cb45dbc77__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-frameworks-devel mai

Re: Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122542/#review75924 --- On Feb. 12, 2015, 2:43 p.m., Kevin Funk wrote: > > --- > This is an aut

Review Request 122542: All frameworks: Add Q_DECL_OVERRIDE where needed

fine on my machine. File Attachments frameworks-add-override.patch https://git.reviewboard.kde.org/media/uploaded/files/2015/02/12/97a4c658-1517-4ab8-88ee-f76c09146393__frameworks-add-override.patch Thanks, Kevin Funk ___ Kde-framew

Re: Review Request 122539: Use Q_DECL_OVERRIDE where possible

/kconfigloader.h aadb19a5b266f4c1ccd07d4b05af0dcbd2686bd9 src/gui/kconfigloaderhandler_p.h 1c7c5a1d3c79a7e98a53245d1037be0b253dc135 src/gui/kconfigskeleton.h 4cd8d140535bb550af8b934a746e2a8ffc0ec008 Diff: https://git.reviewboard.kde.org/r/122539/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 122539: Use Q_DECL_OVERRIDE where possible

. Please tell me if it's desired and I'll go ahead. - Kevin Funk On Feb. 11, 2015, 11:19 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Review Request 122539: Use Q_DECL_OVERRIDE where possible

1c7c5a1d3c79a7e98a53245d1037be0b253dc135 src/gui/kconfigskeleton.h 4cd8d140535bb550af8b934a746e2a8ffc0ec008 Diff: https://git.reviewboard.kde.org/r/122539/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122514/#review75879 --- Ship it! LGTM. - Kevin Funk On Feb. 11, 2015, 5:45 p.m

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

* good, though. src/services/kplugininfo.cpp <https://git.reviewboard.kde.org/r/122514/#comment52373> Style: Space after keyword, more below. - Kevin Funk On Feb. 10, 2015, 5:18 p.m., Aleix Pol Gonzalez wrote: > > ---

Re: Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

> On Feb. 11, 2015, 3:35 p.m., Kevin Funk wrote: > > src/services/kplugininfo.cpp, line 574 > > <https://git.reviewboard.kde.org/r/122514/diff/1/?file=348194#file348194line574> > > > > Style: Space after keyword, more below. Wrong line, sorry. But

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

> On Feb. 9, 2015, 12:59 a.m., Mark Gaiser wrote: > > -1 > > > > You use C-Style casts. Oke, the frameworks coding style doesn't seem to > > explicitly forbid it (casts are not mentioned), but if i recall correctly > > we use the Qt style + some of our own which means we should obey the Qt >

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/#review75646 --- `qRound`? - Kevin Funk On Feb. 8, 2015, 11:12 p.m., Jeremy

Re: Review Request 122481: Fix use of environ for OS X

/qprocessenvironment.html#systemEnvironment` instead? Looks like you could get rid off the string conversion/parsing here. - Kevin Funk On Feb. 8, 2015, 10:06 p.m., Jeremy Whiting wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 122359: Create an uninstall target by default in KDE projects.

thers giving their +1, too modules/ecm_uninstall.cmake.in <https://git.reviewboard.kde.org/r/122359/#comment52112> I'd remove the text inside the condition of `elseif`, `endif` and `endforeach` (I know it is copied code, but still ...) - Kevin Funk On Feb. 3, 2015, 8:19 p.m.,

Re: Review Request 122204: Mark results as required.

> On Jan. 22, 2015, 11:11 p.m., Aleix Pol Gonzalez wrote: > > +1 > > > > This change is not source-compatible though... 8-) or is it? > > Milian Wolff wrote: > It's _meant_ to be source-incompatible. All places where it doesn't > compile are "doing it wrong"™. > > If you mean abi-

Re: Review Request 122105: Fix KgDifficulty saving on app close

onfig()` in order to make sure people don't do that? - Kevin Funk On Jan. 17, 2015, 9:48 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

ch as '#include ".moc"' from cpp files where it can, and includes '#include "moc_.cpp"' as fallback. More information inside the documentation of the script Diffs - kf5/convert-to-cmake-automoc.pl PRE-CREATION Diff: https://git.reviewboard.kde.org/r/12

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

here it can, and includes '#include "moc_.cpp"' as fallback. More information inside the documentation of the script Diffs - kf5/convert-to-cmake-automoc.pl PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121991/diff/ Testing --- Thanks, Kevin Funk __

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

N Diff: https://git.reviewboard.kde.org/r/121991/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

27; as fallback. More information inside the documentation of the script Diffs - kf5/convert-to-cmake-automoc.pl PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121991/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-de

Re: Review Request 121931: Unbreak KRecursiveFilterProxyModel for Qt 5.5.0+.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121931/#review73523 --- Ship it! Ship It! - Kevin Funk On Jan. 8, 2015, 6:10 p.m

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

ongg: > > CMake Error at CMakeLists.txt:64 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "KF5KMahjongglib". > > CMake Error at CMakeLists.txt:67 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "KF5KMahjongglib". > --- > > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Replacement for KMimeType::isBinaryData?

u have more knowledge about mimetypes than us. Can we maybe just check > > whether the mimetype of sourceFile inherits text/plain? > > Excellent idea. This would go a long way indeed. > > I tried to find if this wouldn't work for some mimetypes, but I can't find > an exa

FYI: KF5Plasma fails to build under MSVC

tant expr'). Note: Rest builds fine. -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

ettings/viewmodes/viewsett > ingstab.cpp.o 2 errors generated. > [ 50%] make[2]: *** > [dolphin/src/tests/CMakeFiles/kfileitemlistviewtest.dir/kfileitemlistviewte > st.cpp.o] Error 1 make[1]: *** > [dolphin/src/tests/CMakeFiles/kfileitemlistviewtest.dir/all] Error 2 -- Kevin Funk |

Re: Where are my systray icons cont'd

On Thursday 27 November 2014 21:10:10 Kevin Funk wrote: > Heya, > > I'm still missing my beloved systray icons for a few applications in Plasma > 5 on Ubuntu 14.10 (using distro provided packages). > > I have every package installed according to [1] (sni-qt, libindicator*

Where are my systray icons cont'd

my-systray-icons/ [2] https://developer.pidgin.im/ticket/16456 -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121276: KPluginInfo::category() instead of property("X-KDE-PluginInfo-Category")

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121276/#review71029 --- Ship it! Ship It! - Kevin Funk On Nov. 27, 2014, 6:07 p.m

Re: Review Request 121172: Move libgit2-related macro defs into config.h

e1c9f34cf24eb516c540db3288c93ad5bd093df3 src/document/katedocument.cpp aac17c719cbabf78c2135062fe566671713cea02 src/utils/kateglobal.cpp 473240514eaeb7f108a5bc0a06e182d4aacc7a80 Diff: https://git.reviewboard.kde.org/r/121172/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Re: Review Request 121173: Use correct version in kbuildsycoca5 executable

/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121173: Use correct version in kbuildsycoca5 executable

--- Use correct version in kbuildsycoca5 executable Diffs - src/kbuildsycoca/kbuildsycoca.cpp 69b142745863218169d7da5a048293d6ab6b1978 Diff: https://git.reviewboard.kde.org/r/121173/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Review Request 121172: Move libgit2-related macro defs into config.h

/utils/kateglobal.cpp 473240514eaeb7f108a5bc0a06e182d4aacc7a80 Diff: https://git.reviewboard.kde.org/r/121172/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 121160: Add libgit2 compile-time check for threads support

src/utils/kateglobal.cpp 6e3362802c213c914430a4775ab15e3515729474 Diff: https://git.reviewboard.kde.org/r/121160/diff/ Testing --- Should fix the CI failure. Compiles fine for me (with threads support) Thanks, Kevin Funk ___ Kde-frameworks

Review Request 121160: Add libgit2 compile-time check for threads support

://git.reviewboard.kde.org/r/121160/diff/ Testing --- Should fix the CI failure. Compiles fine for me (with threads support) Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: How to port KTabBar::mouseMiddleClick?

indow *subWindow = subWindowFromIndex(tabAt(event->pos())); 590-if (!subWindow) { 591-event->ignore(); 592-return; 593-} 594- 595-subWindow->close(); 596-} Worth trying to patch this into QTabBar right away, I think. Cheers -- Kevin Funk | kf...@kde.org | htt

Re: Review Request 121082: Add TODO for private signals in KJob

sting --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121082: Add TODO for private signals in KJob

--- Can't change that now because it would be BIC. Diffs - src/lib/jobs/kjob.h d4b7abd3774626f450aadb4e43185ed5bb654792 Diff: https://git.reviewboard.kde.org/r/121082/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-

Re: Review Request 121007: Fix warning when using newer upower backend.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/#review69967 --- Ship it! Finally! - Kevin Funk On Nov. 6, 2014, 1:05 a.m

Replacement for KMimeType::isBinaryData?

Heya, I didn't find a suitable replacement for KMimeType::isBinaryData in KF5. Is there some? http://lxr.kde.org/ident?v=kf5-qt5&_i=isBinaryData&_remember=1 shows exactly two users of this function. Worth considering upstreaming to Qt? -- Kevin Funk | kf...@kde.org | htt

Re: Review Request 120435: Declare InheritanceChecker before actual use

-- src/lib/plugin/kpluginfactory.h 70ffade3e071b839245b9b0d6468f7b804478178 Diff: https://git.reviewboard.kde.org/r/120435/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://

Re: Review Request 120435: Declare InheritanceChecker before actual use

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120435/#review67849 --- Bump. This is a super trivial patch. :) - Kevin Funk On

Review Request 120435: Declare InheritanceChecker before actual use

478178 Diff: https://git.reviewboard.kde.org/r/120435/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Build error with frameworkintegration

t; > > > cc1plus: some warnings being treated as errors > > > > I even tried a clean rebuild of all kde frameworks master, and qt 5.4 > > > > How do I turn off werror? > > > > Thanks. > > ___ > > Kde-

Re: OSX/CI: plasmate fails to build on branch frameworks

https://mail.kde.org/mailman/listinfo/kde-frameworks-devel Note: Plasmate needs to be fixed to work on the current kdevplatform. We've done the invasive KUrl->QUrl port there which of course broke source compatibility. Greets -- Kevin Funk | kf...@kde.org | http://kfunk.org

Re: Porting uses of 'accuracy' in KMimeType API

On Friday 12 September 2014 10:50:36 David Faure wrote: > On Friday 12 September 2014 09:39:42 Kevin Funk wrote: > > Heya, > > > > Context: Forward-porting some patches in KDevelop involving KMimeType API. > > > > I've just noticed that in Qt5, QMime

Porting uses of 'accuracy' in KMimeType API

public API) Thanks [1] http://api.kde.org/frameworks-api/frameworks5-apidocs/kdelibs4support/html/classKMimeType.html#a3417e83a30cff614a01a29ca2a615443 -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-fram

Re: kio_trash

x27;trash'. " (We're using KIO::trash, but the CI doesn't provide this particular slave because it's part of different module) Greets [1] http://build.kde.org/view/kdevelop/job/kdevplatform_frameworks_qt5/154/testReport/(root)/TestSuite/test_kdevgit/ -- Kevin Funk | kf..

Re: Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

ault] Is there any reason for it to be there? Diffs - cmake/modules/ECMQt4To5Porting.cmake 4204fa541790aa38c74b9d6f0b2111af2157b2bc Diff: https://git.reviewboard.kde.org/r/119152/diff/ Testing --- Thanks, Kevin Funk ___ Kde-framework

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

ettings. > > Sune Vuorela wrote: > agreed. > > Kevin Funk wrote: > Yep. I'm also *strongly* in favor of adjusting the code instead of > enabling the define. > > In fact, I thought I've fixed all of KF5. (It isn't?). > There are so

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

> On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: > > I would rather change the code. The Qt behaviour was changed for a reason, > > to prevent accidental use of dangerous behaviour, and I'm not too keen on > > undoing that move for all software that uses KDECompilerSettings. > > Sune Vuorela wr

Re: Review Request 119242: Fix QExplicitlySharedDataPointer usage

-with-qexplicitlyshareddatapointer-ksharedptr-successor/ Diffs - src/widgets/kopenwithdialog.cpp 8cb659fde2028892de82bad64e0ea3ff285b5e3a Diff: https://git.reviewboard.kde.org/r/119242/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

://git.reviewboard.kde.org/r/119241/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

visit: https://git.reviewboard.kde.org/r/119241/#review62182 ------- On July 12, 2014, 9:41 a.m., Kevin Funk wrote: > > --- > This is an automatically generate

Review Request 119242: Fix QExplicitlySharedDataPointer usage

/kopenwithdialog.cpp 8cb659fde2028892de82bad64e0ea3ff285b5e3a Diff: https://git.reviewboard.kde.org/r/119242/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 119241: Fix QExplicitlySharedDataPointer usage

7599c4c73220b2aca366f41ac5cd7d05abfa8afc src/sycoca/ksycocadict.cpp a584f933bff10f44bc257ab996aaee3ad38cc79c tests/ksycocatest.cpp d51d80a691427fa4295dd06802de2fb87112f0ff Diff: https://git.reviewboard.kde.org/r/119241/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

(5, 0, 0) (qglobal.h). That means basic functions such as QString::fromAscii are disabled because they're marked as deprecated since 5.0. Question is: Do we really want to override the default value for QT_DISABLE_DEPRECATED_BEFORE? - Kevin Funk On July 6, 2014, 10:17 p.m., Kevin Funk

Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

o5Porting.cmake 4204fa541790aa38c74b9d6f0b2111af2157b2bc Diff: https://git.reviewboard.kde.org/r/119152/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

<    1   2   3   4   5   6   >