Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to incor

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 11, 2015, 2:55 p.m., Thomas Lübking wrote: > > src/kdeui/kdialogbuttonbox.cpp, line 36 > > > > > > unrelated and not required Not required indeed, but related in the sense that it removes any ambiguity

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 11, 2015, 2:55 p.m., Thomas Lübking wrote: > > src/kdeui/kdialogbuttonbox.cpp, line 61 > > > > > > unrelated and it won't leak, since the cleanup is done by the > > parent/child relation ("this" passed

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- (Updated Dec. 11, 2015, 5:26 p.m.) Review request for KDE Software on Mac

kdebugdialog5 crashing on exit (FYI)

Hi, I mentioned having crashes on exit with kdebugdialog5 a couple of days ago, deep in Qt territory. At first I thought the culprit was my implementation of a "KdeMacPlatformTheme" that inherits from the regular KdePlatformTheme. Then I noticed that kdebugdialog5 also crashes on exit on Linux

Re: system tray test?

Sebastian Kügler wrote: > Not sure what exactly you mean with "putting up and controlling an icon in the > system tray", but we do have a status notifier test app, you can find it in: > plasma-workspace/applets/systemtray/tests/statusnotifier Heh, that must be because I asked the question in one

kwidgetsaddons on OS X: menus become menu items

Hi, After building kate I'm seeing repeating messages like the ones below on the calling terminal, using either Kate or KWrite. This also happens with Christoph's bundle(d) build. (I've patched my Qt build to be more informative though). void QCocoaMenu::insertNative(QCocoaMenuItem *, QCocoaMe

Re: kwidgetsaddons on OS X: menus become menu items

On Friday December 11 2015 23:55:35 René J.V. Bertin wrote: KActionMenu being derived from QWidgetAction I wonder if the following blurb from the QWidgetAction documentation is relevant here: OS X: If you add a widget to a menu in the application's menu bar on OS X, the widget will be added and

Re: kwidgetsaddons on OS X: menus become menu items

René J.V. Bertin wrote: > The widget is reparented away from the QMenu to the native menu view. If you > show the menu in some other place (e.g. as a popup menu), the widget will not > be there. Actually I think this part *is* related: I noticed that the Bookmarks menu is supposed to appear also

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

On Saturday December 12 2015 11:46:06 David Faure wrote: > > kiod5 is started, but doesn't post a dialog. Doesn't raise/return an error > > either. > > If there a debug category to activate in order to get more output I haven't > > found it. > > Did you try this on linux with Qt 5.4 or 5.5, to

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 7, 2015, 5:41 p.m., René J.V. Bertin wrote: > > So with the current implementation that uses inheritance, there are 2 > > classes that have a `delayedDBusConnects` method which uses > > `QDBusConnection::sessionBus().connect()` to register things on the DBus. > > Both invoke that met

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 12, 2015, 7:08 p.m.) Review request for KDE Software on Mac

Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126324/ --- Review request for KDE Software on Mac OS X and KDE Frameworks. Repositor

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126324/ --- (Updated Dec. 12, 2015, 10:19 p.m.) Review request for KDE Software on Ma

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126324/ --- (Updated Dec. 13, 2015, 2:54 p.m.) Review request for KDE Software on Mac

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 11, 2015, 2:55 p.m., Thomas Lübking wrote: > > For the record: I've raised a few interrogations that are preventing me from following up and addressing the open issues raised by Thomas. - René J.V. --- This is an automaticall

"Buttons have icons", round N+1

Hi, There has been some discussion around one of my RRs concerning how to respect KDE's ShowIconsOnPushButtons and Qt's SH_DialogButtonBox_ButtonsHaveIcons style hint. The ultimate way would be in the style that does the actual drawing, but that is probably not the one with the smallest overhe

Re: "Buttons have icons", round N+1

On Sunday December 13 2015 17:14:17 Thomas Lübking wrote: > I object the overhead concern. The global solution is easily applied by the > style (the icon isn't loaded from disk or rendered until you/the style > requires a pixmap from painting - until then there's just a string that hints > whic

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 11, 2015, 2:55 p.m., Thomas Lübking wrote: > > src/kdeui/kdialogbuttonbox.cpp, line 39 > > > > > > QDialogButtonBox::addButton should do correctly anyway, so please don't > > workaround things that are

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 14, 2015, 7:53 a.m., Martin Gräßlin wrote: > > src/gui/CMakeLists.txt, line 2 > > > > > > this introduces a QtWidgets dependency and thus changes the integration > > level of the framework. I highly reco

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 14, 2015, 7:56 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.cpp, line 45 > > > > > > this looks like a not needed debug statement, same in dtor and > > loadSettings and KFontSettin

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 14, 2015, 7:53 a.m., Martin Gräßlin wrote: > > src/gui/CMakeLists.txt, line 2 > > > > > > this introduces a QtWidgets dependency and thus changes the integration > > level of the framework. I highly reco

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 14, 2015, 12:47 p.m., Marco Martin wrote: > > src/gui/CMakeLists.txt, line 22 > > > > > > we really can't add a dependency to QWidgets here. > > depending on qwidgets will make many potential interes

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126324/ --- (Updated Dec. 14, 2015, 5:04 p.m.) Review request for KDE Software on Mac

Re: system tray test?

Sebastian Kügler wrote: >> >> I'd suggest replacing the line above with a sequence "m->addAction, m- >> >> >addSeparator" on OS X, or do you have other suggestions? > > Seems to make sense to me. Could you file a review request for this? Ok, will put that on my todo list :) Cheers, R. __

about ki18n/locales: installing only a subset?

Hi, The KDE4 approach to internationalisation (sic :)) had the huge advantage that it was rather trivial to provide installer packages for individual languages so users could install only those few languages they would actually use. It seems that with KF5 we have gotten back in the situation whe

lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

Out of curiosity: is it intended that KFileMetaData sets the library compatibility version to 3, leading to /opt/local/lib/x86_64-linux-gnu/libKF5FileMetaData.so /opt/local/lib/x86_64-linux-gnu/libKF5FileMetaData.so.3 /opt/local/lib/x86_64-linux-gnu/libKF5FileMetaData.so.5.17.0 and on OS X %> o

Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

On Tuesday December 15 2015 18:55:52 René J.V. Bertin wrote: > for packaging purposes it would be preferable if all libraries (symlinks) > that are recorded in dependents' dependency lists are of the form > libKF5*.5.dylib or libKF5*.so.5 (KFileMetadata is the only deviant one). PS : KDE4's kfil

Re: system tray test?

René J. V. Bertin wrote: > Sebastian Kügler wrote: >> Seems to make sense to me. Could you file a review request for this? > > Ok, will put that on my todo list :) https://git.reviewboard.kde.org/r/126369/ :) R. ___ Kde-framework

Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- Review request for KDE Software on Mac OS X and KDE Frameworks. Repositor

Re: about ki18n/locales: installing only a subset?

On Wednesday December 16 2015 09:03:53 David Faure wrote: > Yep, remove them if you don't want them, but then your users are going to > complain, unless you provide them separately. I think I implied in my original message that I consider providing them separately the ideal solution ;) Sadly su

Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

On Wednesday December 16 2015 09:08:03 David Faure wrote: > Fixed, it was an oversight when converting the lib into a KF5 framework. Hah, you're welcome O:-) I had already taken the liberty to apply it myself (setting SOVERSION to 5); good to know it'll be part of the next release. > ../bluez-qt

Re: about ki18n/locales: installing only a subset?

On Wednesday December 16 2015 11:48:58 David Faure wrote: > They are copied into the frameworks at release time. So you can also grab > them from > svn://anonsvn.kde.org/home/kde/trunk/l10n-kf5 directly (warning, this is huge) Ah, good! Svn is a bit of a hog indeed, but IIRC it does make it easi

Re: about ki18n/locales: installing only a subset?

On Wednesday December 16 2015 13:46:08 Chusslove Illich wrote: > It has a use in every situation where multiple-language users work in a > centrally administered network. Like in... an office. My personal experience How many offices do you know that require all known languages to be installed? Th

Re: about ki18n/locales: installing only a subset?

On Wednesday December 16 2015 14:18:33 Jaroslaw Staniek wrote: > How about bundling the files in qrc containers, one per language to address > the issue of many tiny files? Agreed (and a priori already raised in a previous message). > That reminds me similar case of icon files. Indeed. And the d

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Dec. 16, 2015, 5:40 p.m., Martin Klapetek wrote: > > src/kstatusnotifieritem.cpp, line 710 > > > > > > Why is it reasonable if the platform guidelines speak against it? The platform guidelines apply to regu

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 16, 2015, 10:24 p.m.) Review request for KDE Software on Ma

Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

šumski wrote: >> Fixed, it was an oversight when converting the lib into a KF5 framework. > > But this is a BiC change... Yes, bug fixes can do that ;) R ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/l

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to incor

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 17, 2015, 12:40 p.m.) Review request for KDE Software on Ma

Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

šumski wrote: >> Yes, bug fixes can do that ;) > Yes, but frameworks are under BC guarantee. So how are bugs supposed to be fixed if they break ABI compatibility? If I'm not mistaken Linux will not check beyond shared library file names. If that's correct, the build system can install a libKF5F

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review89652 --- Well, it isn't exactly easy, but I remembered that KMail can b

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 17, 2015, 3 p.m.) Review request for KDE Software on Mac OS

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 17, 2015, 5:26 p.m.) Review request for KDE Software on Mac

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly unexpecte

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly unexpecte

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 11, 2015, 2:55 p.m., Thomas Lübking wrote: > > > > René J.V. Bertin wrote: > For the record: I've raised a few interrogations that are preventing me > from following up and addressing the open issues raised by Thomas. I'm stepping out, patching icons out of buttons elsewhere but

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 17, 2015, 7:40 p.m.) Review request for KDE Software on Mac

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly unexpecte

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 18, 2015, 8:11 a.m., Martin Gräßlin wrote: > > I still want to see other OSX devs comment on that this is really the > > wanted approach. Also I need to point out that the split out of QPT to > > plasma-integration is prepared. I suggest to introduce a comparable > > osx-integration

Re: about ki18n/locales: installing only a subset?

On Friday December 18 2015 10:53:35 Chusslove Illich wrote: >I'm not talking about offices requiring it. I'm talking about coming to a >random office in the world and finding my language already available, >without trifling anyone about it. Out of curiosity: do you expect to use your language whe

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 18, 2015, 8:11 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.cpp, lines 45-46 > > > > > > Q_NULLPTR > > René J.V. Bertin wrote: > I recall a relatively recent discussion on a Q

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 18, 2015, 5:53 p.m.) Review request for KDE Software on Mac

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Dec. 18, 2015, 11:27 p.m., Martin Klapetek wrote: > > src/kstatusnotifieritem.cpp, lines 279-281 > > > > > > This has a strange indentation > > > > Also I think those bools are not entirely useful,

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Dec. 18, 2015, 11:27 p.m., Martin Klapetek wrote: > > src/kstatusnotifieritem.cpp, line 909 > > > > > > I really think this should be handled/mapped > > by the OS X native systray thing. But I guess > >

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On Dec. 18, 2015, 11:07 p.m., Martin Klapetek wrote: > > > is it to be expected (in kstatusnotifieritemtest.cpp) that > > > tray->iconPixmap() returns a null QIcon immediately after calling > > > tray->setIconByName() > > > > I believe so, it's "either-or", either you set the icon by name or

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 19, 2015, 10:56 a.m.) Review request for KDE Software on Ma

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 11:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the style

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly unexpecte

application icon on OS X, MS Windows and other non-X11 platforms

Hello, I'm not sure if this is the most appropriate ML for this kind of question, but here goes: With KDE4, many applications obtained a runtime application icon (visible in app switcher, dock, Finder, Explorer, on windows etc) through some equivalent of QApplication::setWindowIcon(). This wor

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly unexpecte

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 11:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the style

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 11:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the style

building KHtml and KJs with LTO?

Hi, Quick question: I'm getting unspecified linker failures when I try to build KHtml and KJs with link-time optimisation on Linux, using gcc 5.3.0 . I know that certain KDE libs (kdelibs4...) wouldn't build with LTO, but these are the first KF5 frameworks that show this failure for me; all othe

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 11:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the style

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 11:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the style

Re: klauncher & .desktop Execs

On Friday December 25 2015 09:57:05 David Faure wrote: > On Tuesday 22 December 2015 11:33:53 René J.V. Bertin Bouncing this to the list. > > Looking at `ps` output klauncher shows up as kcmshell5's parent process, > > does that mean we're looking at KLauncher::requestStart using > > QProcess:

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly unexpecte

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > > > Jaime Torres Amate wrote: > Hello, > > This is just a warning to know if this patch has been tested in a two > monitor environment in a laptop. > In a pyqt application I save and restore the size and position of t

Re: Review Request 126161: OS X housekeeping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/#review90098 --- src/kdeinit/kinit_mac.mm (lines 662 - 666)

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > > > Jaime Torres Amate wrote: > Hello, > > This is just a warning to know if this patch has been tested in a two > monitor environment in a laptop. > In a pyqt application I save and restore the size and position of t

Re: klauncher & .desktop Execs

On Friday December 25 2015 12:34:08 René J.V. Bertin wrote: > With the proper changes (still assessing them) that should work on OS X too, > no? With the USE_KPROCESS_FOR_KIOSLAVES/QProcess::start I had to jump to a > number of hoops and resort to calling the commandline AppleScript interpreter

Re: klauncher & .desktop Execs

On Friday December 25 2015 18:03:47 René J.V. Bertin wrote: >So what I'd like to do as a last test is this: >- leave the mechanism by which klauncher is started alone, as well as a few >others (to be defined) >- for everything else, use the fact that /usr/bin/open will spawn in the >background,

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

> On Dec. 2, 2015, 8:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showing GUI elements now > > and then, then no problem

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126170/ --- (Updated Dec. 25, 2015, 10:14 p.m.) Review request for KDE Software on Ma

Review Request 126520: [OS X] try to [k]launch the requested application in the foreground [showcase]

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126520/ --- Review request for KDE Software on Mac OS X and KDE Frameworks. Repositor

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

> On Dec. 2, 2015, 8:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showing GUI elements now > > and then, then no problem

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > > > Jaime Torres Amate wrote: > Hello, > > This is just a warning to know if this patch has been tested in a two > monitor environment in a laptop. > In a pyqt application I save and restore the size and position of t

new year's resolution: opening files "the Mac way" (TM)

Hi, Best wishes for 2016! As hinted in the subject, I've dusted off a resolution from last year: finding a way to support opening files "the Mac way". Some of you probably know that OS X doesn't hand off the documents to be opened in the standard argc,argv way when an application is started thr

Re: Review Request 126309: backtrace and demangle for OS X, FreeBSD and Solaris/OpenIndiana

> On Jan. 1, 2016, 4:04 p.m., David Faure wrote: > > This is kdelibs4support, this code is doomed to disappear and apps are > > using kDebug less and less. Is it worth risking compilation breakages on > > some systems? > > > > Also I found kBacktrace less and less useful over the years because

Re: Review Request 126309: backtrace and demangle for OS X, FreeBSD and Solaris/OpenIndiana

> On Jan. 1, 2016, 4:04 p.m., David Faure wrote: > > This is kdelibs4support, this code is doomed to disappear and apps are > > using kDebug less and less. Is it worth risking compilation breakages on > > some systems? > > > > Also I found kBacktrace less and less useful over the years because

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

On Friday January 01 2016 17:47:17 Christoph Cullmann wrote: Hi, Apparently you already looked into this? > I can tell you that this needs to be done at the application level, not at > kpart level. Can you explain why? Does that mean it won't be possible to encapsulate the functionality in a

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

On Friday January 01 2016 20:24:59 Christoph Cullmann wrote: >I think the Qt support is already ok enough, the application just needs to >handle it. >That should just be a few lines of code, not sure if any more wrapping will >make this less work. You're probably right. Would be nice though if

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

On Friday January 01 2016 20:24:59 Christoph Cullmann wrote: Hi, > Guess I should add the handling to Kate/KWrite ;=) I just made a quick attempt, not very successful. From what I understand, you either have to subclass QApplication in order to provide a dedicated ::event() method, or maybe yo

closest equivalent to KApplicationPrivate::init() ?

Morning! Is there anything like a closest equivalent to KApplicationPrivate::init() in KF5 Frameworks? I added a "bring application to the foreground" call (to a KWindowSystem helper function) in there, which alleviated the issue of applications remaining somewhere in the background on OS X. I

Re: Review Request 126161: OS X housekeeping

> On Dec. 25, 2015, 3:42 p.m., René J.V. Bertin wrote: > > src/kdeinit/kinit_mac.mm, lines 662-666 > > > > > > I'd love to add `[NSApp activateIgnoringOtherApps:YES]` and/or `[NSApp > > unhide]` here, preceded b

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

> On Dec. 2, 2015, 8:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showing GUI elements now > > and then, then no problem

Re: closest equivalent to KApplicationPrivate::init() ?

On Saturday January 02 2016 12:50:59 David Faure wrote: > > I added a "bring application to the foreground" call (to a KWindowSystem > > helper function) in there, which alleviated the issue of applications > > remaining somewhere in the background on OS X. > > I'm still keeping an eye out for

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

> On Dec. 2, 2015, 8:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showing GUI elements now > > and then, then no problem

Re: closest equivalent to KApplicationPrivate::init() ?

On Saturday January 02 2016 14:14:19 David Faure wrote: >Sounds to me like you're saying "better bring all apps to front than none". Yes, but also that I think that practice should be more subtle than that if we manage to use LaunchServices consistently where it's appropriate. Disregarding of c

Re: closest equivalent to KApplicationPrivate::init() ?

On Saturday January 02 2016 17:14:07 David Faure wrote: > While I like the general approach of reading source code, what I meant here > was *testing*. > If it behaves like you want it to behave, that's perfect, no need to > understand every line of its code to assess that. OK, hard *empirical*

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

Hi, I have gotten a bit further. As I thought it is critical to have a correct Info.plist (or else the event is never sent), and it isn't trivial to edit that file "in place" and have the system recognise its new content (easiest way is to copy the entire app bundle in the Finder). You also n

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

On Saturday January 02 2016 19:56:28 Christoph Cullmann wrote: Hi, > I have added this now just to KateApp. > > https://quickgit.kde.org/?p=kate.git&a=commit&h=cd6ec201725cf627a336015d472c39f5ff73b2a7 Hmm, thanks for the hint with the Info.plist? You mean you already knew about the rest? :)

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

On Saturday January 02 2016 20:24:25 Christoph Cullmann wrote: > Besides: No need for ifdefs, QFileOpenEvent is there on all platforms, just > without function. True, but there's no point in installing an event filter for it on platforms where the event never occurs. > But you are aware that

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

On Saturday January 02 2016 20:24:25 Christoph Cullmann wrote: Hi, Something else: is the KateApp supposed to be subclassable? In that case you may want to put the FileOpen event back into the queue rather than eating it (i.e. return false instead of true from the event filter), so that the de

Re: [KDE/Mac] "offending" menu items

Hi again, Remember those 2 menu items that caused repeating error messages on the terminal? Turns out that whatever it is that causes it exactly can in fact make the application crash (I saw that with Konsole), but I also found a workaround. Someone could have told me that this kind of action is

Re: closest equivalent to KApplicationPrivate::init() ?

On Sunday January 03 2016 10:22:27 David Faure wrote: >> You saw I said "wait for QProcess to be improved", right? I don't expect a >> patch for QProcess to be incorporated before 5.7.x ... > >Patience is a virtue :-) Oh indeed it is ... and getting a [real] life waiting for something this cent

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly unexpecte

Re: Review Request 126304: (re)enable building with -DQTC_QT5_ENABLE_KDE

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126304/ --- (Updated Jan. 4, 2016, 4:04 p.m.) Status -- This change has been mar

Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126624/ --- Review request for KDE Software on Mac OS X, KDE Frameworks and Yichao Yu.

<    1   2   3   4   5   6   7   8   9   10   >