Re: New picture_viewer.py plugin in devel

2021-10-22 Thread Edward K. Ream
On Fri, Oct 22, 2021 at 8:34 PM tbp1...@gmail.com wrote: > Here's my stab at it. Replace all the current text in the docstring ahead > of the binding and API information with the following: Done at rev 2f65d83

Re: New picture_viewer.py plugin in devel

2021-10-22 Thread Edward K. Ream
On Fri, Oct 22, 2021 at 8:47 PM tbp1...@gmail.com wrote: > This is very nice, and one of the nice things about it is how it > automatically ignores non-image files without the user having to do > anything. > > A suggestion for better usability - after you zoom or shrink a slide, the > new zoom fa

Re: New picture_viewer.py plugin in devel

2021-10-22 Thread Edward K. Ream
On Fri, Oct 22, 2021 at 10:52 PM tbp1...@gmail.com wrote: > In get_files(), there is > > os.path.splitext(str(z))[1].lower() in self.extensions > > I'm just wondering why it isn't g.os_path_splitext() instead. Are these > *g.os_path_** commands being phased out? (Actually, I never understood > w

Re: New picture_viewer.py plugin in devel

2021-10-22 Thread tbp1...@gmail.com
In get_files(), there is os.path.splitext(str(z))[1].lower() in self.extensions I'm just wondering why it isn't g.os_path_splitext() instead. Are these *g.os_path_** commands being phased out? (Actually, I never understood why we have them at all but given that we do, why not use it here?) On

Re: New picture_viewer.py plugin in devel

2021-10-22 Thread tbp1...@gmail.com
This is very nice, and one of the nice things about it is how it automatically ignores non-image files without the user having to do anything. A suggestion for better usability - after you zoom or shrink a slide, the new zoom factor should stay in effect for all other slides until you change i

Re: New picture_viewer.py plugin in devel

2021-10-22 Thread tbp1...@gmail.com
Here's my stab at it. Replace all the current text in the docstring ahead of the binding and API information with the following: Display image files in a directory tree as a slide show. This plugin will display all files in a directory tree that have image extensions. By default the recognized

Slides.run now requires a c argument

2021-10-22 Thread Edward K. Ream
Early testers take note. See PR #2285 . The docstring has been updated accordingly. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving em

Re: New picture_viewer.py plugin in devel

2021-10-22 Thread Edward K. Ream
On Fri, Oct 22, 2021 at 10:59 AM tbp1...@gmail.com wrote: And I see from the PixMap docs that it can actually support some other > formats. > > You may think it's the same thing, but I suggest spelling out just what > the viewer can do would be helpful. > Ah, the curse of knowledge. Please sugg

Re: New picture_viewer.py plugin in devel

2021-10-22 Thread Edward K. Ream
On Fri, Oct 22, 2021 at 10:45 AM tbp1...@gmail.com wrote: > picture_viewer.py is in the plugins directory but not in LeoPyRef. > Thanks for this report. Rev 2693456 in devel adds the missing @file node. Edward -- You received this message because you are subscribed to the Google Groups "leo

Re: New picture_viewer.py plugin in devel

2021-10-22 Thread tbp1...@gmail.com
Maybe the docstring said that at one time but it doesn't now : ). It says this: A plugin for displaying slides from a folder and its subfolders. And this: The following keyword arguments may be supplied to the run method: ... extensions = ['.jpeg', '.jpg', '.png'], # List of file extensions. An

Re: New picture_viewer.py plugin in devel

2021-10-22 Thread tbp1...@gmail.com
picture_viewer.py is in the plugins directory but not in LeoPyRef. On Friday, October 22, 2021 at 10:50:49 AM UTC-4 Edward K. Ream wrote: > On Fri, Oct 22, 2021 at 8:13 AM tbp1...@gmail.com > wrote: > >> What are the slides? Image files? HTML bullet files? >> > > Good question. As the docstri

Re: New picture_viewer.py plugin in devel

2021-10-22 Thread Edward K. Ream
On Fri, Oct 22, 2021 at 8:13 AM tbp1...@gmail.com wrote: > What are the slides? Image files? HTML bullet files? > Good question. As the docstrings says, by default the viewer will display all .jpeg, .jpg, and .png files in the root directory and all subdirectory. The *show_slide *method creates

Re: New picture_viewer.py plugin in devel

2021-10-22 Thread tbp1...@gmail.com
What are the slides? Image files? HTML bullet files? On Thursday, October 21, 2021 at 10:46:20 PM UTC-4 Edward K. Ream wrote: > On Thursday, October 21, 2021 at 9:42:16 PM UTC-5 Edward K. Ream wrote: > >> See PR #2280 , which >> contains the

Leo 6.5 released

2021-10-22 Thread Edward K. Ream
Leo 6.5 (final) is now available here , on GitHub. Many thanks to all who have contributed, and special thanks to those who have carefully tested Leo. *The highlights of 6.5* - Add python-to-typescript and view-recent-commands. Note: #2275