Re: Proposed change to setup.py

2020-03-30 Thread Thomas Passin
On Sunday, March 29, 2020 at 10:29:36 PM UTC-4, Matt Wilkie wrote: > > > b) merge early, merge often: as in daily. This way any given upstream > change can (usually) be inspected and accepted/changed in small easy to > understand pieces. Use an interactice tool like WinMerge or Kmeld to do the

Re: Proposed change to setup.py

2020-03-29 Thread Matt Wilkie
> > With the confusions I've had using github forks, I think I'd like to work > in my own Mercurial repo, where I would only need my own code and not the > entire Leo distro, and copy the results to my Github fork of Leo. For that > to work, the most convenient way would be for Leo to load

Re: Proposed change to setup.py

2020-03-29 Thread Thomas Passin
On Sunday, March 29, 2020 at 2:01:53 PM UTC-4, Matt Wilkie wrote: > > > >> Then you could keep your development code entirely out of the repo until >> you got it to the point it was worth adding it in. I'd like that. >> > > A fork would accomplish this and then be easier to add to the main

Re: Proposed change to setup.py

2020-03-29 Thread Matt Wilkie
> Then you could keep your development code entirely out of the repo until > you got it to the point it was worth adding it in. I'd like that. > A fork would accomplish this and then be easier to add to the main repo later. I think so anyway, but there might be things I'm not considering

Re: Proposed change to setup.py

2020-03-29 Thread Thomas Passin
On Sunday, March 29, 2020 at 12:34:56 AM UTC-4, Matt Wilkie wrote: > > So if I had a clone at d:\leo-clone, I'd use the following? >> >> python -m pip install --editable d:\leo-clone >> > > Yes. > > I have been setting PYTHONPATH to d:\leo-clone. This has always seemed >> to work well, as

Re: Proposed change to setup.py

2020-03-28 Thread Matt Wilkie
> > So if I had a clone at d:\leo-clone, I'd use the following? > > python -m pip install --editable d:\leo-clone > Yes. I have been setting PYTHONPATH to d:\leo-clone. This has always seemed to > work well, as long as the dependencies have been installed in my main > Python install

Re: Proposed change to setup.py

2020-03-28 Thread Thomas Passin
On Saturday, March 28, 2020 at 4:45:01 PM UTC-4, Matt Wilkie wrote: > > > I've always installed Leo using pip. I still don't understand what >> "--editable" accomplishes, so I've never used it. >> > > *Pip install* puts the package and all the files it says it needs under >

Re: Proposed change to setup.py

2020-03-28 Thread Matt Wilkie
> I've always installed Leo using pip. I still don't understand what > "--editable" accomplishes, so I've never used it. > *Pip install* puts the package and all the files it says it needs under PYTHONHOME/Lib/site-packages and creates a launch wrapper in PYTHONHOME/Scripts. Pip install

Re: Proposed change to setup.py

2020-03-28 Thread Matt Wilkie
> Anyway, I expanded the docstring of setup.py and put in a guard to prevent >> anyone from using it naively like I did. I've attached below. >> > > Looks good to me. Matt, any comments? > Thank you tfer. In all this time it never occured to me to add a message to guide people to usng pip

Re: Proposed change to setup.py

2020-03-26 Thread Thomas Passin
I still don't understand what "--editable" accomplishes, so I've never used it. What I do, when I want to run from a git clone, is to set PYTHONPATH to the top directory of the clone. Then Python will use, say, the Leo clone but it find all its other packages from the regular installed

Re: Proposed change to setup.py

2020-03-26 Thread Edward K. Ream
On Thu, Mar 26, 2020 at 1:00 AM 'tfer' via leo-editor < leo-editor@googlegroups.com> wrote: > I've been making a mistake in setting up Leo and using it for years! > Yeah, setup.py has confused a lot of people. Anyway, I expanded the docstring of setup.py and put in a guard to prevent > anyone

Proposed change to setup.py

2020-03-26 Thread 'tfer' via leo-editor
I've been making a mistake in setting up Leo and using it for years! I've always run Leo from my local git clone of it, (usually the develop branch), never realizing I should have been using setup.py to make sure the python it is running under is fully ready to support it. I just used