Re: [libav-devel] [PATCH 3/7] mpeg4videodec: Fix low_delay error message

2014-08-29 Thread Timothy Gu
On Aug 29, 2014 7:45 PM, "Gabriel Dume" wrote: > > --- > libavcodec/mpeg4videodec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c > index effbf6d..3adf0cf 100644 > --- a/libavcodec/mpeg4videodec.c > +++ b/libavcode

[libav-devel] [PATCH 7/7] wmv2: cosmetics: Fix coding style inconsistencies

2014-08-29 Thread Gabriel Dume
--- libavcodec/wmv2.c| 95 +++-- libavcodec/wmv2.h| 6 +- libavcodec/wmv2dec.c | 394 ++- libavcodec/wmv2enc.c | 114 --- 4 files changed, 319 insertions(+), 290 deletions(-) diff --git a/libavcodec/wmv2.c b/libavcodec

Re: [libav-devel] [PATCH 7/7] wmv2: cosmetics: Fix coding style inconsistencies

2014-08-29 Thread Gabriel Dume
On Fri, Aug 29, 2014 at 10:43 PM, Gabriel Dume wrote: > --- > libavcodec/wmv2.c| 95 ++-- > libavcodec/wmv2.h| 6 +- > libavcodec/wmv2dec.c | 396 > +++ > libavcodec/wmv2enc.c | 114 --- > 4 files changed, 321 inserti

[libav-devel] [PATCH 7/7] wmv2: cosmetics: Fix coding style inconsistencies

2014-08-29 Thread Gabriel Dume
--- libavcodec/wmv2.c| 95 ++-- libavcodec/wmv2.h| 6 +- libavcodec/wmv2dec.c | 396 +++ libavcodec/wmv2enc.c | 114 --- 4 files changed, 321 insertions(+), 290 deletions(-) diff --git a/libavcodec/wmv2.c b/libavcodec/

[libav-devel] [PATCH 6/7] asv: cosmetics: Fix coding style inconsistencies

2014-08-29 Thread Gabriel Dume
--- libavcodec/asv.c| 45 +- libavcodec/asvdec.c | 12 +-- libavcodec/asvenc.c | 230 ++-- 3 files changed, 162 insertions(+), 125 deletions(-) diff --git a/libavcodec/asv.c b/libavcodec/asv.c index 71c5e5f..8efa0e1 100644 --- a/libavc

[libav-devel] [PATCH 4/7] wma: cosmetics: Fix coding style inconsistencies

2014-08-29 Thread Gabriel Dume
--- libavcodec/wma.h | 8 +-- libavcodec/wmadata.h | 12 ++-- libavcodec/wmadec.c | 180 ++- libavcodec/wmaenc.c | 172 ++-- 4 files changed, 195 insertions(+), 177 deletions(-) diff --git a/libav

[libav-devel] [PATCH 2/7] aac_adtstoasc_bsf: Return proper error code

2014-08-29 Thread Gabriel Dume
--- libavcodec/aac_adtstoasc_bsf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aac_adtstoasc_bsf.c b/libavcodec/aac_adtstoasc_bsf.c index bec6e7f..733b08d 100644 --- a/libavcodec/aac_adtstoasc_bsf.c +++ b/libavcodec/aac_adtstoasc_bsf.c @@ -57,7 +57,7 @@ static in

[libav-devel] [PATCH 3/7] mpeg4videodec: Fix low_delay error message

2014-08-29 Thread Gabriel Dume
--- libavcodec/mpeg4videodec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index effbf6d..3adf0cf 100644 --- a/libavcodec/mpeg4videodec.c +++ b/libavcodec/mpeg4videodec.c @@ -2081,7 +2081,7 @@ static int decode_vop_hea

[libav-devel] [PATCH 5/7] flvenc: cosmetics: Fix coding style inconsistencies

2014-08-29 Thread Gabriel Dume
--- libavcodec/flvenc.c | 41 + 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/libavcodec/flvenc.c b/libavcodec/flvenc.c index 4d5eb1d..daa6d8c 100644 --- a/libavcodec/flvenc.c +++ b/libavcodec/flvenc.c @@ -21,7 +21,7 @@ #include "h263.h"

[libav-devel] [PATCH 1/7] 8svx: Return proper error code

2014-08-29 Thread Gabriel Dume
--- libavcodec/8svx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/8svx.c b/libavcodec/8svx.c index 11fbf19..74753be 100644 --- a/libavcodec/8svx.c +++ b/libavcodec/8svx.c @@ -179,7 +179,7 @@ static av_cold int eightsvx_decode_init(AVCodecContext *avctx)

[libav-devel] [PATCH 2/2] xcbgrab: XCB-based screen capture

2014-08-29 Thread Luca Barbato
Matches the x11grab screen capture by features. --- Now with optional shm and mouse rendering. I assume the shm system header does exist if xcb-shm is present, I can readd the test if we want to be sure. Changelog| 1 + configure| 38 ++- libavdevice/Makefile

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Jean-Baptiste Kempf
On 29 Aug, Ronald S. Bultje wrote : > Remember JBs pains to get pieces of VideoLan relicensed under LGPL? Let's > prevent that, it's easy. Well, to be honest, the habitude of FFmpeg of merging code from anonymous persons or multiple persons under various license is extremely bad on this, and worse

[libav-devel] [PATCH 1/2] configure: Add check_pkg_config2

2014-08-29 Thread Luca Barbato
Useful when checking for optional components set to auto. --- I use it in the second patch. configure | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure b/configure index 22b699f..65da7b0 100755 --- a/configure +++ b/configure @@ -950,6 +950,13 @@ check_pkg_config(){ s

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Jean-Baptiste Kempf
On 29 Aug, Timothy Gu wrote : > There are no insults, but there are reviews from FFmpeg developers > that are ignored here, which are even worse IMO. reviews ignored is worse than insults??? Seriously? -- Jean-Baptiste Kempf http://www.jbkempf.com/ - +33 672 704 734 Sent from my Electronic Devi

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Luca Barbato
On 30/08/14 01:18, Derek Buitenhuis wrote: > On 8/30/2014 12:16 AM, Luca Barbato wrote: >> In case I'm wrong and importing code against the will of the first >> originator is against some law I'll see how to fix this issue, possibly >> amicably. > > The problem was not importing against someone's

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Derek Buitenhuis
On 8/30/2014 12:16 AM, Luca Barbato wrote: > In case I'm wrong and importing code against the will of the first > originator is against some law I'll see how to fix this issue, possibly > amicably. The problem was not importing against someone's will, but squashing in changes they did not write, u

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Luca Barbato
On 29/08/14 18:40, Kieran Kunhya wrote: >> The remark you mention there was not a review, but rather a complaint that >> the submitted patch was not easy enough to diff against the FFmpeg version. >> Cleanup by other contributors from libav was squashed in order to have a >> clean version in the hi

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Diego Biurrun
Am 29.08.2014 21:57 schrieb "Ronald S. Bultje" : > On Fri, Aug 29, 2014 at 3:51 PM, Diego Biurrun wrote: > > > > > Am 29.08.2014 20:03 schrieb "Ronald S. Bultje" : > > > On Fri, Aug 29, 2014 at 1:30 PM, Kieran Kunhya wrote: > > > > "You're throwing a blob at me without individual author's >

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Ronald S. Bultje
Hi, On Fri, Aug 29, 2014 at 3:51 PM, Diego Biurrun wrote: > > Am 29.08.2014 20:03 schrieb "Ronald S. Bultje" : > > On Fri, Aug 29, 2014 at 1:30 PM, Kieran Kunhya wrote: > > > "You're throwing a blob at me without individual author's > > > contribution, I don't think that's > > > appropriate." >

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Diego Biurrun
Am 29.08.2014 20:03 schrieb "Ronald S. Bultje" : > On Fri, Aug 29, 2014 at 1:30 PM, Kieran Kunhya wrote: > > "You're throwing a blob at me without individual author's > > contribution, I don't think that's > > appropriate." > > > > You've decided to selectively ignore the second part of the

Re: [libav-devel] So Long and Thanks for All the Fish

2014-08-29 Thread Compn
Kostya Shishkov writes: > P.S. It was still fun working on multimedia and helping other peoples. > And I value the fact I could met at least some Libav developers and spend some > time with them, maybe we'll meet again somewhere. Bye Kostya, it was fun working with you on the projects and m

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Ronald S. Bultje
Hi, On Fri, Aug 29, 2014 at 1:30 PM, Kieran Kunhya wrote: > "You're throwing a blob at me without individual author's > contribution, I don't think that's > appropriate." > > You've decided to selectively ignore the second part of the message. > As I read that it says he is not happy with those

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Kieran Kunhya
"You're throwing a blob at me without individual author's contribution, I don't think that's appropriate." You've decided to selectively ignore the second part of the message. As I read that it says he is not happy with those changes being attributed to him. > Speaking of incorrect attribution, y

[libav-devel] So Long and Thanks for All the Fish

2014-08-29 Thread Kostya Shishkov
I've been first FFmpeg then Libav contributor for ten years and mostly it was fun experience but in the last three years it became less and less so. I don't want to talk about the reasons why, you know them well enough. It was my intent to bid farewell to the project maybe this autumn, but tod

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Diego Biurrun
On Fri, Aug 29, 2014 at 06:48:14PM +0200, Diego Biurrun wrote: > On Fri, Aug 29, 2014 at 05:40:29PM +0100, Kieran Kunhya wrote: > > > The remark you mention there was not a review, but rather a complaint that > > > the submitted patch was not easy enough to diff against the FFmpeg > > > version. >

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Diego Biurrun
On Fri, Aug 29, 2014 at 09:20:59AM -0700, Timothy Gu wrote: > On Fri, Aug 29, 2014 at 9:06 AM, Diego Biurrun wrote: > > On Fri, Aug 29, 2014 at 05:26:32PM +0200, Diego Biurrun wrote: > >> On Fri, Aug 29, 2014 at 08:19:55AM -0700, Timothy Gu wrote: > >> > > >> > http://lists.libav.org/pipermail/lib

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Diego Biurrun
On Fri, Aug 29, 2014 at 05:40:29PM +0100, Kieran Kunhya wrote: > > The remark you mention there was not a review, but rather a complaint that > > the submitted patch was not easy enough to diff against the FFmpeg version. > > Cleanup by other contributors from libav was squashed in order to have a

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Vittorio Giovara
On Fri, Aug 29, 2014 at 12:25 PM, Timothy Gu wrote: > On Fri, Aug 29, 2014 at 8:55 AM, Vittorio Giovara > wrote: >> >> Timothy, if throwing out of context links at each other is your >> definition of sane communication, maybe it's better to end this >> straight away. > > If you think pointing out

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Kieran Kunhya
> The remark you mention there was not a review, but rather a complaint that > the submitted patch was not easy enough to diff against the FFmpeg version. > Cleanup by other contributors from libav was squashed in order to have a > clean version in the history and for review on the ml. I and other

Re: [libav-devel] [PATCH 6/6] x11grab: Refactor pixel format parsing

2014-08-29 Thread Luca Barbato
On 29/08/14 18:08, Diego Biurrun wrote: > On Fri, Aug 29, 2014 at 04:28:00PM +0200, Luca Barbato wrote: >> On 28/08/14 15:59, Diego Biurrun wrote: >>> On Wed, Aug 27, 2014 at 04:43:52AM +0200, Luca Barbato wrote: --- a/libavdevice/x11grab.c +++ b/libavdevice/x11grab.c @@ -170,6 +170,

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Timothy Gu
On Fri, Aug 29, 2014 at 8:55 AM, Vittorio Giovara wrote: > > Timothy, if throwing out of context links at each other is your > definition of sane communication, maybe it's better to end this > straight away. If you think pointing out some points of improvement is not sane communication I can and

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Timothy Gu
On Fri, Aug 29, 2014 at 9:06 AM, Diego Biurrun wrote: > On Fri, Aug 29, 2014 at 05:26:32PM +0200, Diego Biurrun wrote: >> On Fri, Aug 29, 2014 at 08:19:55AM -0700, Timothy Gu wrote: >> > >> > http://lists.libav.org/pipermail/libav-devel/2014-August/062391.html: >> > the first more important point

Re: [libav-devel] [PATCH 6/6] x11grab: Refactor pixel format parsing

2014-08-29 Thread Diego Biurrun
On Fri, Aug 29, 2014 at 04:28:00PM +0200, Luca Barbato wrote: > On 28/08/14 15:59, Diego Biurrun wrote: > > On Wed, Aug 27, 2014 at 04:43:52AM +0200, Luca Barbato wrote: > >> --- a/libavdevice/x11grab.c > >> +++ b/libavdevice/x11grab.c > >> @@ -170,6 +170,59 @@ static int setup_shm(AVFormatContext

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Diego Biurrun
On Fri, Aug 29, 2014 at 05:26:32PM +0200, Diego Biurrun wrote: > On Fri, Aug 29, 2014 at 08:19:55AM -0700, Timothy Gu wrote: > > On Fri, Aug 29, 2014 at 7:43 AM, Diego Biurrun wrote: > > > On Fri, Aug 29, 2014 at 11:33:19AM +0200, wm4 wrote: > > >> On Fri, 29 Aug 2014 01:00:45 +0200 > > >> Diego B

[libav-devel] [PATCH] ffmpeg: Clarify wording of ffmpeg --> avconv deprecation message

2014-08-29 Thread Diego Biurrun
--- Now featuring JEEB's wording suggestion. Also killed the typo in the log message. ffmpeg.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index f61de33..4e65269 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -4376,9 +4376,11 @@ int main(int argc, cha

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Vittorio Giovara
On Fri, Aug 29, 2014 at 11:19 AM, Timothy Gu wrote: > There are no insults, but there are reviews from FFmpeg developers > that are ignored here, which are even worse IMO. > > Latest cases I have spotted: > > http://lists.libav.org/pipermail/libav-devel/2014-August/062391.html: > the first more im

[libav-devel] [PATCH] Add release notes for 11.

2014-08-29 Thread Diego Biurrun
From: Anton Khirnov Signed-off-by: Diego Biurrun --- Fixed some minor wording issues and added more info about dsputil. doc/RELEASE_NOTES | 109 +- 1 file changed, 50 insertions(+), 59 deletions(-) diff --git a/doc/RELEASE_NOTES b/doc/RELEA

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Diego Biurrun
On Fri, Aug 29, 2014 at 08:19:55AM -0700, Timothy Gu wrote: > On Fri, Aug 29, 2014 at 7:43 AM, Diego Biurrun wrote: > > On Fri, Aug 29, 2014 at 11:33:19AM +0200, wm4 wrote: > >> On Fri, 29 Aug 2014 01:00:45 +0200 > >> Diego Biurrun wrote: > >> > On Sun, Aug 24, 2014 at 12:28:56AM +0200, Clément B

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Timothy Gu
On Fri, Aug 29, 2014 at 7:43 AM, Diego Biurrun wrote: > On Fri, Aug 29, 2014 at 11:33:19AM +0200, wm4 wrote: >> On Fri, 29 Aug 2014 01:00:45 +0200 >> Diego Biurrun wrote: >> > On Sun, Aug 24, 2014 at 12:28:56AM +0200, Clément Bœsch wrote: >> > > >> > > Kieran suggested tonight on #ffmpeg-devel to

Re: [libav-devel] [PATCH] [0.8] ffmpeg: Clarifiy wording of ffmpeg --> avconv deprecation message

2014-08-29 Thread Kieran Kunhya
On 25 August 2014 00:58, Derek Buitenhuis wrote: > On 8/24/2014 10:37 PM, Kieran Kunhya wrote: >> deprecated in the Libav project > > +1 to not pretending I will just repeat this... ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.

[libav-devel] [PATCH] ffmpeg: Clarifiy wording of ffmpeg --> avconv deprecation message

2014-08-29 Thread Diego Biurrun
--- Updated wording as suggested by JEEB and GabrielYYZ. For real this time ... ffmpeg.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index f61de33..e28d8f8 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -4376,9 +4376,11 @@ int main(int argc, char **ar

Re: [libav-devel] [PATCH] [0.8] ffmpeg: Clarifiy wording of ffmpeg --> avconv deprecation message

2014-08-29 Thread Diego Biurrun
On Fri, Aug 29, 2014 at 07:31:20AM -0700, Diego Biurrun wrote: > --- > > Updated wording as suggested by JEEB and GabrielYYZ. > > ffmpeg.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) WTF, I sent before amending, sorry, new version coming up in a moment. Diego __

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Diego Biurrun
On Fri, Aug 29, 2014 at 11:33:19AM +0200, wm4 wrote: > On Fri, 29 Aug 2014 01:00:45 +0200 > Diego Biurrun wrote: > > On Sun, Aug 24, 2014 at 12:28:56AM +0200, Clément Bœsch wrote: > > > > > > Kieran suggested tonight on #ffmpeg-devel to have a common mailing-list > > > between the two projects to

[libav-devel] [PATCH] [0.8] ffmpeg: Clarifiy wording of ffmpeg --> avconv deprecation message

2014-08-29 Thread Diego Biurrun
--- Updated wording as suggested by JEEB and GabrielYYZ. ffmpeg.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index f61de33..f579894 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -4376,9 +4376,11 @@ int main(int argc, char **argv) show_banner(

Re: [libav-devel] [PATCH 6/6] x11grab: Refactor pixel format parsing

2014-08-29 Thread Luca Barbato
On 28/08/14 15:59, Diego Biurrun wrote: > On Wed, Aug 27, 2014 at 04:43:52AM +0200, Luca Barbato wrote: >> --- a/libavdevice/x11grab.c >> +++ b/libavdevice/x11grab.c >> @@ -170,6 +170,59 @@ static int setup_shm(AVFormatContext *s, Display *dpy, >> XImage **image) >> >> +static int pixfmt_from_im

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread wm4
On Fri, 29 Aug 2014 01:00:45 +0200 Diego Biurrun wrote: > On Sun, Aug 24, 2014 at 12:28:56AM +0200, Clément Bœsch wrote: > > > > Kieran suggested tonight on #ffmpeg-devel to have a common mailing-list > > between the two projects to start communicating again in sane terms. > > > > The propositi