Re: git review

2012-08-09 Thread Jan Holesovsky
Hi David, David Tardon píše v Čt 09. 08. 2012 v 07:17 +0200: We will loose possible contributors that way. Not an option. Patch submittal has to work hasslefree and out of the box. This is really critical: there has to be no extra step at all for patch submittal otherwise we failed.

Re: git review

2012-08-09 Thread Bjoern Michaelsen
On Thu, Aug 09, 2012 at 09:15:48AM +0200, Jan Holesovsky wrote: David Tardon píše v Čt 09. 08. 2012 v 07:17 +0200: irony It has worked hasslefree and out of the box while we have been using email. /irony It was a precondition for the gerrit work that the email submission + direct push

Re: git review

2012-08-09 Thread Bjoern Michaelsen
be to do with git-review as we do with other external stuff: Downloading and installing a local copy in ./download. That would ensure it to be universally available and be up to date. Best, Bjoern ___ LibreOffice mailing list LibreOffice

Re: git review

2012-08-09 Thread Norbert Thiebaud
for patch submittal otherwise we failed. Thinking a bit about this, another possibility would be to do with git-review as we do with other external stuff: Downloading and installing a local copy in ./download. That would ensure it to be universally available and be up to date. I know that michael

Re: git review

2012-08-09 Thread Bjoern Michaelsen
On Thu, Aug 09, 2012 at 07:55:45AM -0500, Norbert Thiebaud wrote: I know that michael disagree with me on that, but I prefer dev-tools to be in ... dev-tools.git one can install it as he see fit. and you get the version you want/need regardless where you are in the source tree... Well,

Re: git review

2012-08-09 Thread d . ostrovsky
Quoting Norbert Thiebaud nthieb...@gmail.com: On Thu, Aug 9, 2012 at 7:04 AM, Bjoern Michaelsen Thinking a bit about this, another possibility would be to do with git-review as we do with other external stuff: Downloading and installing a local copy in ./download. That would ensure

Re: git review

2012-08-09 Thread Norbert Thiebaud
On Thu, Aug 9, 2012 at 8:11 AM, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: On Thu, Aug 09, 2012 at 07:55:45AM -0500, Norbert Thiebaud wrote: I know that michael disagree with me on that, but I prefer dev-tools to be in ... dev-tools.git one can install it as he see fit. and you

Re: git review

2012-08-09 Thread Bjoern Michaelsen
On Thu, Aug 09, 2012 at 08:57:01AM -0500, Norbert Thiebaud wrote: no it would not, because if I swith to branch 3-5... what version do I have then ? If you switch -- the same. ./download would install it into solenv/bin, which is not changed by git checkout. Also I would suggest to backport

Re: git review

2012-08-08 Thread David Ostrovsky
Hi Bjoern, On 02.08.2012 23:21, Bjoern Michaelsen wrote: http://wiki.documentfoundation.org/Development/GitReview so: - what are the experiences? - should we recommend it in general? I am really happy with git review. It has killer features that i don't want to miss anymore, in fact

Re: git review

2012-08-08 Thread Bjoern Michaelsen
On Wed, Aug 08, 2012 at 11:19:09PM +0200, David Ostrovsky wrote: But IMHO git-review MUST work out of the box then -- without any setup. No! You don't dump a copy of git, bash and binutils, don't you? Because they are install with ~all systems and are available on all system as a nicely

Re: git review

2012-08-08 Thread David Tardon
Hi, On Wed, Aug 08, 2012 at 11:52:03PM +0200, Bjoern Michaelsen wrote: On Wed, Aug 08, 2012 at 11:19:09PM +0200, David Ostrovsky wrote: Like described in link above, you have three options here: pypi-system-wide, pypi-user-local and distro package. No other options please. Most people

git review (was: [Libreoffice-qa] minutes of ESC call ...)

2012-08-02 Thread Bjoern Michaelsen
Python/Perl/Haskell/Brainfuck scripting in the end anyway). If the feedback by current users of git review is positive and deemed suitable for firsttime users, I would suggest, if possible, to dump a copy that can work standalone into the core repo root. Even if it might be outdated compared

Change in core[master]: git-review integration: .gitreview for core repository added

2012-07-05 Thread Gerrit
From David Ostrovsky david.ostrov...@gmx.de: David Ostrovsky has uploaded a new change for review. Change subject: git-review integration: .gitreview for core repository added .. git-review integration: .gitreview for core

Change in core[master]: git-review integration: .gitreview for core repository added

2012-07-05 Thread Gerrit
From James E. Blair cor...@gnu.org: James E. Blair has posted comments on this change. Change subject: git-review integration: .gitreview for core repository added .. Patch Set 1: (3 inline comments) Hi. Hope you don't mind

Change in core[master]: git-review integration: .gitreview for core repository added

2012-07-05 Thread Gerrit
From Björn Michaelsen bjoern.michael...@canonical.com: Björn Michaelsen has posted comments on this change. Change subject: git-review integration: .gitreview for core repository added .. Patch Set 1: Looks good to me