https://bugs.documentfoundation.org/show_bug.cgi?id=96888
Michael Stahl changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
Commit Notification changed:
What|Removed |Added
Whiteboard|
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #34 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
Michael Meeks changed:
What|Removed |Added
Keywords|
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #31 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #33 from Dipankar Niranjan ---
Hi,
> > In /core/vcl/source/window/winproc.cxx
> > In line 2001 before commit:
> > if ( pSVEvent->mbCall && !pSVEvent->maDelData.IsDead() )
> > I do not know how to
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #32 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #23 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #22 from Michael Meeks ---
Hi Dipankar:
> https://gerrit.libreoffice.org/21280 is a cleanup of
> https://gerrit.libreoffice.org/21215
Ah - this is a bit of a pain to manage =) Luckily gerrit has
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #25 from Michael Meeks ---
Hi Dipankar
I reviewed a number of those changes; really keeping the Change-Id: the same
would save a lot of effort. Also - please do not refer to gerrit URLs in your
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #24 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #27 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #26 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #29 from Michael Meeks ---
by "abandon" I mean click the 'abandon' button in the gerrit web-ui for any
patches that are obsolete - so they don't show up there anymore ? =)
--
You are receiving
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #28 from Michael Meeks ---
Nice to see you pushing updated with the same Change-Id: =)
Can you abandon any patches that are not current ? we're really starting to get
there ;-) I'm really looking
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #30 from Dipankar Niranjan ---
Hi,
I did not know that we could submit updates with the same Change-Id.
Made things a lot easier and cleaner..
Thanks for teaching that..!
Also I've abandoned the older
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #20 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #21 from Dipankar Niranjan ---
Hi,
Here are some cleanup patches.
https://gerrit.libreoffice.org/21280 is a cleanup of
https://gerrit.libreoffice.org/21215
https://gerrit.libreoffice.org/21275 is a
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #8 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #11 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #12 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #13 from Michael Meeks ---
Hi there,
> In /core/vcl/source/window/winproc.cxx
> In line 2001 before commit:
> if ( pSVEvent->mbCall && !pSVEvent->maDelData.IsDead() )
> I do not know how to
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
Commit Notification changed:
What|Removed |Added
Whiteboard|easyHack
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #7 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #9 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #10 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #14 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #15 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #16 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #19 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #17 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #18 from Commit Notification
---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #6 from Dipankar Niranjan ---
Hi,
Thanks for the really helpful Code Review..
I hope I've learned from it while I was resubmitting the patches.
So here they are:
dndevis.cxx
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #3 from Dipankar Niranjan ---
Hi,
I've submitted the first patch with four files modified.
https://gerrit.libreoffice.org/#/c/21170/
Build, unit tests and make check were fine.
Please review when free.
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #5 from Michael Meeks ---
Hi there - I did some review on your first patch; looks nice - can you do some
tweaks & re-submit it ? =) I'll review your 2nd patch as/when that's merged -
but please
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #4 from Dipankar Niranjan ---
The second patch has been uploaded with eight files modified.
https://gerrit.libreoffice.org/#/c/21174/
Build, unit tests and make check were fine.
Please review when free.
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #1 from Dipankar Niranjan ---
Hi,
This is a method where deletion listener was being used.
It has been replaced by a VclPtr reference.
Please verify if I'm on the right track.
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #2 from Michael Meeks ---
Hi there,
> This is a method where deletion listener was being used.
> It has been replaced by a VclPtr reference.
> Please verify if I'm on the right track.
>
https://bugs.documentfoundation.org/show_bug.cgi?id=96888
Michael Meeks changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
39 matches
Mail list logo