Sorry for the delay; Colin's away this week, and he asked me to
keep it rolling, but now that I'm in Canada I suddenly (and
unexpectedly!) have a social life, so I'm not keeping stuff
together all that well.
We still have a huge backlog of patches. Please be patient if
your patch(es) is not on
On Sat, Aug 06, 2011 at 11:17:24AM +0100, Phil Holmes wrote:
- Original Message - From: Graham Percival
On Thu, Aug 04, 2011 at 03:05:42PM +0100, Phil Holmes wrote:
I don't run LSR update: I'm an authoriser, but that's all.
Yes, it's almost as though there's no amour for LSR.
Not
On Sat, Aug 06, 2011 at 01:22:54PM +0100, Phil Holmes wrote:
Actually, I've just been looking at this, and your patch almost
solves the problem - *if I change the correct file*. I already have
texinfo installed on my system, and I noticed that when I run it,
part of the output is
On Sat, Aug 06, 2011 at 11:36:37PM +0200, Janek Warchoł wrote:
easier for me), but in order not to waste your answer, maybe let's add
it to CG/Programming work/miscellaney ? I attach a patch.
Thanks, pushed.
Cheers,
- Graham
___
lilypond-devel
After thinking and thinking, i think i know now what's the answer :)
2011/8/5 Janek Warchoł lemniskata.bernoull...@gmail.com:
2011/8/3 k-ohara5...@oco.net:
On 2011/08/02 21:29:24, Janek Warchol wrote:
note-head-chord [...] it's gone a bit too far in this case.
We could adjust the spacing
On 2011/08/05 10:07:46, Janek Warchol wrote:
2011/8/4 reinhold.kainho...@gmail.com:
I would definitely mention here that the automatic beaming
and the beam subdivisions are automatically derived from nbsp;the
\compound
meter.
Are the subdivisions really used?
...
I have removed the
New Draft.
Thanks
James
http://codereview.appspot.com/4837050/diff/9001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/4837050/diff/9001/Documentation/notation/rhythms.itely#newcode1554
2011/8/6 David Kastrup d...@gnu.org:
Going back to your colorful examples, here's what effects i'd expect:
\relative c' {
c4
\once\override Stem #'color = #red
\override Stem #'color = #blue
c4 c
\revert Stem #'color
c4
}
black blue blue black
That's a
a 'while you're there' nitpick.
http://codereview.appspot.com/4808074/diff/18/Documentation/notation/vocal.itely
File Documentation/notation/vocal.itely (right):
http://codereview.appspot.com/4808074/diff/18/Documentation/notation/vocal.itely#newcode612
Documentation/notation/vocal.itely:612:
- Original Message -
From: Keith OHara k-ohara5...@oco.net
To: lilypond-devel@gnu.org; Phil Holmes m...@philholmes.net
Sent: Saturday, August 06, 2011 9:31 PM
Subject: Re: GOP-PROP 5: build system output (final)
On Sat, 06 Aug 2011 03:13:33 -0700, Phil Holmes m...@philholmes.net
On Aug 6, 2011, at 10:56 PM, pkx1...@gmail.com wrote:
make fails.
--snip--
-DHAVE_CONFIG_H -DNDEBUG -I/home/jlowe/lilypond-git/lily/include
-I./out -I/home/jlowe/lilypond-git/flower/include -I../flower/./out
-I../flower/include -I/home/jlowe/lilypond-git/lily/out -O2
On Aug 7, 2011, at 1:35 AM, Keith OHara wrote:
mike at apollinemike.com mike at apollinemike.com writes:
I'm getting a lot of circular dependencies for
input/regression/beam-skip.ly from the current master.
I don't have time to do a full git bisect, but is this
standard behavior?
- Original Message -
From: Graham Percival gra...@percival-music.ca
To: Phil Holmes m...@philholmes.net
Cc: David Kastrup d...@gnu.org; lilypond-devel@gnu.org
Sent: Sunday, August 07, 2011 8:22 AM
Subject: Re: Ugliness in the Learning Manual
On Sat, Aug 06, 2011 at 01:22:54PM +0100,
2011/8/6 David Kastrup d...@gnu.org:
Jan Warchoł lemniskata.bernoulli...@gmail.com writes:
2011/8/6 James Lowe james.l...@datacore.com:
Users and new contributors will interpret priority as importance,
though, and will naturally want their favorites to be higher on the
list. That's why I
Le 07/08/2011 11:19, Phil Holmes disait :
- Original Message - From: Graham Percival
To: Phil Holmes m...@philholmes.net
Cc: David Kastrup d...@gnu.org; lilypond-devel@gnu.org
Subject: Re: Ugliness in the Learning Manual
On Sat, Aug 06, 2011 at 01:22:54PM +0100, Phil Holmes wrote:
2011/8/6 m...@apollinemike.com m...@apollinemike.com:
On Aug 6, 2011, at 11:09 AM, lemniskata.bernoull...@gmail.com wrote:
i tried writing a review, but i don't understand what's going on here.
Can you add some comments to the code?
The function fit_factor pushes up the height of a slur if
On Aug 7, 2011, at 11:33 AM, Janek Warchoł wrote:
2011/8/6 m...@apollinemike.com m...@apollinemike.com:
On Aug 6, 2011, at 11:09 AM, lemniskata.bernoull...@gmail.com wrote:
i tried writing a review, but i don't understand what's going on here.
Can you add some comments to the code?
The
- Original Message -
From: Jean-Charles Malahieude lily...@orange.fr
To: Phil Holmes m...@philholmes.net
Cc: Graham Percival gra...@percival-music.ca; David Kastrup
d...@gnu.org; lilypond-devel@gnu.org
Sent: Sunday, August 07, 2011 10:33 AM
Subject: Re: Ugliness in the Learning Manual
make/lilypond-vars.make:TEXINPUTS=$(top-src-dir)/tex/::
So we're setting the location of the texinfo.tex file explicitly
during make.
Think this makes the issue invalid, but the feature is probably
worth documenting with other make stuff - Graham?
Is TEXINPUTS properly set in the
overall LGTM
http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely#newcode1643
Documentation/notation/rhythms.itely:1643:
I've created tracker issue:
http://code.google.com/p/lilypond/issues/detail?id=1807
Could you upload some pngs showing before/after output? It would be
helpful for those who cannot build the patch themselves.
http://codereview.appspot.com/4808074/
- Original Message -
From: Werner LEMBERG w...@gnu.org
To: m...@philholmes.net
Cc: lily...@orange.fr; d...@gnu.org; lilypond-devel@gnu.org
Sent: Sunday, August 07, 2011 12:59 PM
Subject: Re: Ugliness in the Learning Manual
make/lilypond-vars.make:TEXINPUTS=$(top-src-dir)/tex/::
So
2011/8/7 m...@apollinemike.com m...@apollinemike.com:
On Aug 7, 2011, at 11:33 AM, Janek Warchoł wrote:
2011/8/6 m...@apollinemike.com m...@apollinemike.com:
On Aug 6, 2011, at 11:09 AM, lemniskata.bernoull...@gmail.com wrote:
i tried writing a review, but i don't understand what's going on
Hi James,
There's nothing wrong with the following:
However, the @code{tie-configuration} property of
@code{TieColumn} can be overridden to set start line and direction
of ties as required.
'tie-configuration *is* a property of TieColumn, but one that happens
not to be set by default (that's
On 2011/08/03 20:06:49, Graham Percival wrote:
LGTM, fantastic work as always.
Thanks!
Pushed: 33f71ee2c062b4e377e146920ef48ea8c41d6fe8
Cheers,
Neil
http://codereview.appspot.com/4794057/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Reviewers: ,
Message:
Hi,
This patch adds context modification identifiers for all supported
accidental styles. This should make it much easier for users to set a
style globally, since there's no need to work out what each style sets
internally.
I've followed Kieren's example here,
Reviewers: ,
Message:
Hi,
I've always been a bit annoyed by this, so I though it would be a nice
enhancement to allow scripts to work on full-bar rests just like
ordinary markup.
The syntax constructor already makes a half-hearted attempt to add
scripts, but fails in trying to set the 'text
Almost there - a couple of comments ...
http://codereview.appspot.com/4837050/diff/15001/Documentation/music-glossary.tely
File Documentation/music-glossary.tely (right):
http://codereview.appspot.com/4837050/diff/15001/Documentation/music-glossary.tely#newcode2114
Nice! LGTM.
Will need some doc changes too.
Should we deprecate \fermataMarkup?
http://codereview.appspot.com/4672059/diff/1/scm/ly-syntax-constructors.scm
File scm/ly-syntax-constructors.scm (right):
http://codereview.appspot.com/4672059/diff/1/scm/ly-syntax-constructors.scm#newcode157
On 7 August 2011 17:01, tdanielsmu...@googlemail.com wrote:
Nice! LGTM.
Thank you.
Will need some doc changes too.
Indeed. I'll sort that out later (+ a regression test to exercise the
code properly).
Should we deprecate \fermataMarkup?
I think so. A convert rule would be reliable
On 7 August 2011 17:24, n.putt...@gmail.com wrote:
Reviewers: ,
Message:
Hi,
I've always been a bit annoyed by this, so I though it would be a nice
enhancement to allow scripts to work on full-bar rests just like
ordinary markup.
The syntax constructor already makes a half-hearted
I've prepared some changes for the web search box in line with what I
suggested in http://code.google.com/p/lilypond/issues/detail?id=1806 -
screenshot attached. It requires changes to search-box.ihtml and
lilypond-website.css (to make room for the new box).
Problem is, I've currently got a
Phil Holmes m...@philholmes.net wrote Sunday, August 07, 2011
5:33 PM
Problem is, I've currently got a review going for the mozart horn
regtest.
I use lily-git.tcl for git. I'm presuming that I'm restricted to
a single
branch with this? If I try git from the command line to create a
new
On Sun, Aug 07, 2011 at 11:46:51AM +0200, m...@apollinemike.com wrote:
I'm certainly not against adding comments, but I think that when
the code does a good job of explaining stuff via variable names,
comments can clutter what's going on. For example, dz_unit to
me sounds like a unit vector
LGTM. I have always wondered why \fermataMarkup was necessary.
http://codereview.appspot.com/4672059/diff/1/ly/property-init.ly
File ly/property-init.ly (right):
http://codereview.appspot.com/4672059/diff/1/ly/property-init.ly#newcode189
ly/property-init.ly:189: fermataMarkup = \fermata
How
On 7 August 2011 20:21, reinhold.kainho...@gmail.com wrote:
http://codereview.appspot.com/4672059/diff/1/ly/property-init.ly
File ly/property-init.ly (right):
http://codereview.appspot.com/4672059/diff/1/ly/property-init.ly#newcode189
ly/property-init.ly:189: fermataMarkup = \fermata
How
Reinhold Kainhofer reinh...@kainhofer.com writes:
Am Tuesday, 2. August 2011, 23:14:46 schrieb Jan Warchoł:
Regardless of whether this applies to me or not, does using git pull
-r instead of plain git pull make this problem irrelevant, or am i
wrong?
I think so.
'git pull --rebase' is
Am Sunday, 7. August 2011, 21:41:42 schrieb Neil Puttock:
On 7 August 2011 20:21, reinhold.kainho...@gmail.com wrote:
http://codereview.appspot.com/4672059/diff/1/ly/property-init.ly
File ly/property-init.ly (right):
- Original Message -
From: Trevor Daniels t.dani...@treda.co.uk
Trevor
ps I wish you wouldn't send messages from newsgroups.
I have to mess about cutting and pasting To:, Cc:
and Subject: fields in order to reply. I probably
won't do it any more, sorry.
Sorry. My recollection is
New Draft.
Before I push this (and as Neil has just done an LSR update) do I still
need to run makelsr.py before applying this patch once it has been
approved?
I have removed one snippet from both dirs (snippets/new and snippets).
I'll get someone to remove the snippet from the LSR too.
On 7 August 2011 20:48, Reinhold Kainhofer reinh...@kainhofer.com wrote:
I wouldn't go that lowlevel. I rather thought about a scheme function that
prints a ly:warning and then returns the new definition (or calls the new
function).
How would you prevent the deprecation warning from being
Hello,
From: Neil Puttock [n.putt...@gmail.com]
Sent: 07 August 2011 15:16
To: James Lowe
Cc: Lily-Devel List
Subject: Doc: NR 5.5.4 - Modifying ties and slurs
Hi James,
There's nothing wrong with the following:
However, the @code{tie-configuration}
On 7 August 2011 21:58, James Lowe james.l...@datacore.com wrote:
I guess that opens a whole new vista of questions - i.e. along the lines of
how would I know that if its not documented in the IR
How is it not documented?
If I navigate to TieColumn,
Hello,
From: Neil Puttock [n.putt...@gmail.com]
Sent: 07 August 2011 22:13
To: James Lowe
Cc: Lily-Devel List
Subject: Re: NR 5.5.4 - Modifying ties and slurs
On 7 August 2011 21:58, James Lowe james.l...@datacore.com wrote:
I guess that opens a whole
David Kastrup wrote Sunday, August 07, 2011 8:41 PM
I just pushed an example of how not to do things a few hours ago.
Seems
like I should be the last person preaching...
No problem: we all forget and do it from time to time :)
(except maybe Neil)
Trevor
-
No virus found in this
On 7 August 2011 21:33, pkx1...@gmail.com wrote:
Before I push this (and as Neil has just done an LSR update) do I still
need to run makelsr.py before applying this patch once it has been
approved?
Nope.
I have removed one snippet from both dirs (snippets/new and snippets).
Don't forget
James Lowe wrote Sunday, August 07, 2011 10:24 PM
If I navigate to TieColumn,
http://lilypond.org/doc/v2.15/Documentation/internals/tiecolumn
there's a list of interfaces at the bottom, one of which is
tie-column-interface. If I follow this link, there's a
description of
Is TEXINPUTS properly set in the documentation build script posted
recently?
No. I wasn't aware it existed until about 2 hours ago.
:-) kpathsea, the library used by all TeX related programs to locate
files within a texmf tree, has an awfully lot of such environment
variables. A quick look
Not tested, but LGTM
http://codereview.appspot.com/4822046/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Sun, Aug 07, 2011 at 11:22:48AM +0100, Phil Holmes wrote:
- Original Message - From: Jean-Charles Malahieude
lily...@orange.fr
(./usage.texi (/home/jcharles/GIT/Mentors/tex/texinfo.tex
That looks good.
git grep TEXINPUTS gives:
LGTM. My comment is a tiny nitpick; I don't think it needs to hold up
pushing this.
http://codereview.appspot.com/4811066/diff/8003/input/regression/mozart-hrn-3.ly
File input/regression/mozart-hrn-3.ly (right):
On Sun, Aug 07, 2011 at 05:33:45PM +0100, Phil Holmes wrote:
I've prepared some changes for the web search box in line with what
I suggested in
http://code.google.com/p/lilypond/issues/detail?id=1806 - screenshot
attached.
I'd need to look at the effects of the patch to see how it behaves
in
On Sun, Aug 07, 2011 at 06:35:34PM +0100, Trevor Daniels wrote:
ps I wish you wouldn't send messages from newsgroups.
I have to mess about cutting and pasting To:, Cc:
and Subject: fields in order to reply.
really? I just hit reply to all and my mail client takes care
of it. Maybe there's
Grahamm you wrote Sunday, August 07, 2011 11:47 PM
On Sun, Aug 07, 2011 at 06:35:34PM +0100, Trevor Daniels wrote:
ps I wish you wouldn't send messages from newsgroups.
I have to mess about cutting and pasting To:, Cc:
and Subject: fields in order to reply.
really? I just hit reply to all
Hi everybody,
Back to the topic of adding support for East Slavic (aka Kievan) music notation.
I've rewritten our font for Kievan notation (called Suprasl) in
Metafont. Now, I am trying to figure out how to incorporate the new
glyphs into the Feta files.
I've created a new file, feta-kievan.mf
LGTM
http://codereview.appspot.com/4837050/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Sat, Aug 06, 2011 at 11:48:30PM +, Keith OHara wrote:
David Kastrup dak at gnu.org writes:
Looks like we associate differing meanings with one or several of the
words unless, somebody or objects.
If the test remains in input/regression, then anyone inspecting the tests
will think
On Thu, Aug 04, 2011 at 08:53:44PM +0200, Reinhold Kainhofer wrote:
Am Dienstag, 26. Juli 2011, 14:22:22 schrieb Reinhold Kainhofer:
Please review:
http://codereview.appspot.com/1659041/
I have now fixed all problems and adjusted the documentation, so the latest
patch at
On Wed, Aug 03, 2011 at 12:30:15PM -0700, Graham Percival wrote:
Get them here:
http://lilypond.org/~graham/
Hmm. Nobody cares about MacOS X 10.7 ? ok, no skin off my
nose...
I was thinking that it would be nice to announce that this was
working in the next release notes, but I guess I'll
On Sun, Aug 07, 2011 at 10:11:13AM +0100, Phil Holmes wrote:
- Original Message - From: Keith OHara
k-ohara5...@oco.net
To: lilypond-devel@gnu.org; Phil Holmes m...@philholmes.net
Sent: Saturday, August 06, 2011 9:31 PM
Subject: Re: GOP-PROP 5: build system output (final)
Make does
LGTM.
I had time to try it on several scores; it often helped and never hurt.
If any of the above is incorrect,
then maybe consider adding some
comment(s) where you define the variables,
Now, Mike created none of these variables, nor does his added code use
them. If he adds helpful
On Mon, Aug 08, 2011 at 03:52:52AM +, k-ohara5...@oco.net wrote:
If any of the above is incorrect,
then maybe consider adding some
comment(s) where you define the variables,
Now, Mike created none of these variables, nor does his added code use
them. If he adds helpful comments, great,
Thanks for the discussion so far! Based on that, I have a
radically different proposal.
http://lilypond.org/~graham/gop/gop_8.html
** Proposal summary
Let’s get rid of priorities. We will simply describe bugs in
neutral terms; each contributor can search and interpret the
results as he or she
So we'll probably have 2.16 out in the end of August or beginning
of September. Any chance of updating LSR to 2.14 before then?
And moving snippets from Documentation/snippets/new/ into LSR?
Is anybody willing to volunteer to organize this? remember, you
don't need to do anything yourself; you
64 matches
Mail list logo
