Re: beam.cc:pure-rest-collision-callback Place on staff lines; issue 2468 (issue 6035053)

2012-04-25 Thread Keith OHara
On Tue, 24 Apr 2012 23:29:02 -0700, wrote: http://codereview.appspot.com/6035053/diff/16001/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/6035053/diff/16001/lily/beam.cc#newcode1328 lily/beam.cc:1328: return scm_from_double (0.0); On 2012/04/25 06:21:29, Keith wrote: I

Re: announcing things like Mike's tour in News column?

2012-04-25 Thread Graham Percival
On Tue, Apr 24, 2012 at 09:33:03PM +0200, Janek Warchoł wrote: > On Fri, Apr 20, 2012 at 11:54 PM, Graham Percival > wrote: > Well then, let's have some important project news posted. I'll write a > note about GSoC, yes. > and i think we can make an announcement when Mike&Joe > finish new skyli

Re: what shall we do with GSOC subpage on the website?

2012-04-25 Thread Graham Percival
On Tue, Apr 24, 2012 at 10:14:24PM +, Carl Sorensen wrote: > On 4/24/12 2:31 PM, "Janek Warchoł" wrote: > > >I see two possibilities: > >- change it to "projects" or something like that. I think it would be > >useful to have such a list No. Such "projects" lists are a pain to maintain and

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-25 Thread dak
It would appear that you ignored , , the end of and

Re: announcing things like Mike's tour in News column?

2012-04-25 Thread m...@apollinemike.com
On 25 avr. 2012, at 11:53, Graham Percival wrote: > > If you really really want to have fluff pieces on the main > lilypond website, I could imagine us using the top right-hand > corner (Mike's "wasted space") for twitter-like announcements of > concerts and editions. Or maybe even using the enti

Re: Regarding LSR translation work

2012-04-25 Thread Graham Percival
On Tue, Apr 24, 2012 at 02:28:21PM +0200, Federico Bruni wrote: > 2012/4/24 Graham Percival : > >> 2) ask the LSR author to add the possibility to insert translated > >> titles and descriptions (the website itself could benefit from this, > >> since it may enable language negotiation). But managing

Re: announcing things like Mike's tour in News column?

2012-04-25 Thread David Kastrup
Graham Percival writes: > On Tue, Apr 24, 2012 at 09:33:03PM +0200, Janek Warchoł wrote: >> On Fri, Apr 20, 2012 at 11:54 PM, Graham Percival >> wrote: > >> Well then, let's have some important project news posted. I'll write a >> note about GSoC, > > yes. > >> and i think we can make an announc

Re: announcing things like Mike's tour in News column?

2012-04-25 Thread Graham Percival
On Wed, Apr 25, 2012 at 12:00:43PM +0200, m...@apollinemike.com wrote: > On 25 avr. 2012, at 11:53, Graham Percival wrote: > > > > If you really really want to have fluff pieces on the main > > lilypond website, I could imagine us using the top right-hand > > corner (Mike's "wasted space") for twi

Re: announcing things like Mike's tour in News column?

2012-04-25 Thread m...@apollinemike.com
On 25 avr. 2012, at 12:08, Graham Percival wrote: > On Wed, Apr 25, 2012 at 12:00:43PM +0200, m...@apollinemike.com wrote: >> On 25 avr. 2012, at 11:53, Graham Percival wrote: >>> >>> If you really really want to have fluff pieces on the main >>> lilypond website, I could imagine us using the top

Re: Brings beamed rest closer to cross staff beam. (issue 5908043)

2012-04-25 Thread milimetr88
http://codereview.appspot.com/5908043/diff/1/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/5908043/diff/1/lily/beam.cc#newcode1326 lily/beam.cc:1326: || beam->get_property_data ("direction") == ly_symbol2scm ("calculation-in-progress")) On 2012/04/25 06:29:14, mike7 wrote

Re: Brings beamed rest closer to cross staff beam. (issue 5908043)

2012-04-25 Thread mike
On 2012/04/25 11:10:40, Milimetr88 wrote: http://codereview.appspot.com/5908043/diff/1/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/5908043/diff/1/lily/beam.cc#newcode1326 lily/beam.cc:1326: || beam->get_property_data ("direction") == ly_symbol2scm ("calculation-in-p

Re: 30 day webathon for kickstarter support (issue 6068045)

2012-04-25 Thread graham
First, editing embedded javascript is not a general solution. Second, I'm not at all certain we want to have commercial announcements in that area. I'm sorry if I gave the impression that this was to be a green light for any kind of announcement. http://codereview.appspot.com/6068045/

Re: 30 day webathon for kickstarter support (issue 6068045)

2012-04-25 Thread mike
On 2012/04/25 11:25:02, Graham Percival wrote: First, editing embedded javascript is not a general solution. Second, I'm not at all certain we want to have commercial announcements in that area. I'm sorry if I gave the impression that this was to be a green light for any kind of announcem

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-25 Thread Łukasz Czerwiński
On 25 April 2012 11:57, wrote: > It would appear that you ignored > > >, >

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-25 Thread milimetr88
http://codereview.appspot.com/6109046/diff/9001/lily/ledger-line-spanner.cc File lily/ledger-line-spanner.cc (left): http://codereview.appspot.com/6109046/diff/9001/lily/ledger-line-spanner.cc#oldcode68 lily/ledger-line-spanner.cc:68: while (flip (&d) != DOWN); On 2012/04/25 11:47:07, Milimetr88

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-25 Thread David Kastrup
Łukasz Czerwiński writes: > On 25 April 2012 11:57, wrote: > > It would appear that you ignored > , > , > > > No - just look at dates - the comments are newer tha

Re: What's with the test-patches volunteers?

2012-04-25 Thread David Kastrup
Graham Percival writes: > On Wed, Apr 25, 2012 at 07:17:06AM +0200, David Kastrup wrote: >> David Kastrup writes: >> >> > It is close to two months that I have been the only person running >> > test-patches, even though several volunteers claimed they would do so. >> > It has been the main reas

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-25 Thread Graham Percival
On Wed, Apr 25, 2012 at 01:44:14PM +0200, Łukasz Czerwiński wrote: >As I understand, fixxcc.py will correct that automatically, so I don't >have to bother about that? Nevertheless I'll remember that for my >future patches. fixcc.py can correct those, but this adds "noise" to the git co

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-25 Thread Łukasz Czerwiński
> > I know that this is not a very positive message, but I am trying to save you yet more anguish. The lilypond project currently does > not even function smoothly between senior developers with more > than 100 commits each; there is very little chance for a new > contributor to have a smooth an

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-25 Thread Łukasz Czerwiński
On 25 April 2012 14:52, David Kastrup wrote: > (...) > To me, that does not look like you particularly value getting a review. > You have not fixed a single thing I pointed out. You have not checked > your submission yourself for the problems. > > I didn't notice that comment. I'm not used yet t

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-25 Thread David Kastrup
Łukasz Czerwiński writes: > I have never ever get an email from Google Code. I have just checked > that triple. That's the reason for ignoring your comments. I'm sorry > that my new patch made you run your tests twice to give me the same > list of errors... >   > Do you run tests for each patch u

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-25 Thread Łukasz Czerwiński
On 25 April 2012 17:06, David Kastrup wrote: > Łukasz Czerwiński writes: > > > I have never ever get an email from Google Code. I have just checked > > that triple. That's the reason for ignoring your comments. I'm sorry > > that my new patch made you run your tests twice to give me the same > >

Re: measure counter engraver

2012-04-25 Thread David Nalesnik
Hi, Unrelated issue: I notice that the original post with attached files hasn't > shown up on archive 2 on either -user or -devel, even though I sent that > post 13 hours ago. It appears on archive 1, but there the .ly file appears > as a binary data file, which I cannot open. Am I guilty of top

what should go into the website news? (was: announcing things like ...)

2012-04-25 Thread Janek Warchoł
On Wed, Apr 25, 2012 at 11:53 AM, Graham Percival wrote: > On Tue, Apr 24, 2012 at 09:33:03PM +0200, Janek Warchoł wrote: >> On Fri, Apr 20, 2012 at 11:54 PM, Graham Percival >> wrote: > >> Well then, let's have some important project news posted. I'll write a >> note about GSoC, > > yes. Done.

Re: what should go into the website news?

2012-04-25 Thread David Kastrup
Janek Warchoł writes: > On Wed, Apr 25, 2012 at 11:53 AM, Graham Percival > wrote: >> On Tue, Apr 24, 2012 at 09:33:03PM +0200, Janek Warchoł wrote: >>> On Fri, Apr 20, 2012 at 11:54 PM, Graham Percival >>> wrote: >> >>> Well then, let's have some important project news posted. I'll write a >>>

Re: hideNotes should hide also TabNoteHead (issue 2480). (issue 6105049)

2012-04-25 Thread fedelogy
Reviewers: Graham Percival, Keith, Neil Puttock, dak, Message: On 2012/04/23 12:20:36, Neil Puttock wrote: Nevertheless, the voicing should be fixed even if it means adding explicit \voiceOne commands at appropriate places. It looks bad with both voices stem-down. voiceOne and voiceTwo wer

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-25 Thread tdanielsmusic
Almost there, if the regtests run clean, but the added 'for' loops are still not in GNU style - they need a space after 'for'. This must be corrected before pushing. See http://permalink.gmane.org/gmane.comp.gnu.lilypond.devel/46312 where Keith explained this earlier. http://codereview.appspot.

Re: What's with the test-patches volunteers?

2012-04-25 Thread Graham Percival
On Wed, Apr 25, 2012 at 03:06:00PM +0200, David Kastrup wrote: > Graham Percival writes: > > > I agree. Given your limited computing power, you are the very > > last person who should be running Patchy. > > It is not just my computing resources that make me unsuitable. I was tactfully not ment

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-25 Thread Graham Percival
On Wed, Apr 25, 2012 at 03:14:33PM +0200, Łukasz Czerwiński wrote: > I know that this is not a very positive message, but I am trying > to save you yet more anguish. Â The lilypond project currently does > not even function smoothly between senior developers with more > than 100

Re: 30 day webathon for kickstarter support (issue 6068045)

2012-04-25 Thread Graham Percival
I like the content of the announcement. I still don't like the idea of manually editing index.html. I was expecting/hoping for something like Documentation/web/twits.txt: - The Ensemble 101 is going on a European tour where they'll sing music typeset using LilyPond. Click http://www.ensembl

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

2012-04-25 Thread m...@apollinemike.com
On 26 avr. 2012, at 07:28, Graham Percival wrote: > > Well, right now we have nobody running the automated tests to > check that new patches are ok. So there will be no patches > accepted to lilypond. > I have a meeting in mid-May w/ the University of Paris VIII. They're donating a computer