Re: Scrub priority, am I using it wrong?

Gareth Pye posted on Tue, 05 Apr 2016 13:45:11 +1000 as excerpted: > On Tue, Apr 5, 2016 at 12:37 PM, Duncan <1i5t5.dun...@cox.net> wrote: >> CPU bound, 0% IOWait even at idle IO priority, in addition to the >> hundreds of M/s values per thread/device, here. You OTOH are showing >> under 20 M/s

Re: Scrub priority, am I using it wrong?

Gareth Pye posted on Tue, 05 Apr 2016 13:44:05 +1000 as excerpted: > On Tue, Apr 5, 2016 at 12:37 PM, Duncan <1i5t5.dun...@cox.net> wrote: >> 1) It appears btrfs scrub start's -c option only takes numeric class, >> so try -c3 instead of -c idle. > > > Does it count as a bug if it silently

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

Alex Lyakas wrote on 2016/04/03 10:22 +0200: Hello Qu, Wang, On Wed, Mar 30, 2016 at 2:34 AM, Qu Wenruo wrote: Alex Lyakas wrote on 2016/03/29 19:22 +0200: Greetings Qu Wenruo, I have reviewed the dedup patchset found in the github account you mentioned. I have

Re: Scrub priority, am I using it wrong?

On Tue, Apr 5, 2016 at 12:37 PM, Duncan <1i5t5.dun...@cox.net> wrote: > CPU bound, 0% IOWait even at idle IO priority, in addition to the > hundreds of M/s values per thread/device, here. You OTOH are showing > under 20 M/s per thread/device on spinning rust, with an IOWait near 90%, > thus

Re: Scrub priority, am I using it wrong?

On Tue, Apr 5, 2016 at 12:37 PM, Duncan <1i5t5.dun...@cox.net> wrote: > 1) It appears btrfs scrub start's -c option only takes numeric class, so > try -c3 instead of -c idle. Does it count as a bug if it silently accepts the way I was doing it? I've switched to -c3 and at least now the idle

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

David Sterba wrote on 2016/04/04 18:55 +0200: On Fri, Mar 25, 2016 at 09:38:50AM +0800, Qu Wenruo wrote: Please use the newly added BTRFS_PERSISTENT_ITEM_KEY instead of a new key type. As this is the second user of that item, there's no precendent how to select the subtype. Right now 0 is for

Re: [PATCH 00/13 v3] Introduce device state 'failed', Hot spare and Auto replace

Kai Krakow posted on Mon, 04 Apr 2016 22:15:13 +0200 as excerpted: > Your argument would be less important if it did copy-back, tho... ;-) FWIW, I completely misunderstood your description of copy-back in my original reply, and didn't realize what you meant (and thus my mistaken understanding)

Re: Scrub priority, am I using it wrong?

Gareth Pye posted on Tue, 05 Apr 2016 09:36:48 +1000 as excerpted: > I've got a btrfs file system set up on 6 drbd disks running on 2Tb > spinning disks. The server is moderately loaded with various regular > tasks that use a fair bit of disk IO, but I've scheduled my weekly btrfs > scrub for the

Re: btrfsck: backpointer mismatch (and multiple other errors)

Kai Krakow posted on Mon, 04 Apr 2016 21:26:28 +0200 as excerpted: > I'll go test the soon-to-die SSD as soon as it replaced. I think it's > still far from failing with bitrot. It was overprovisioned by 30% most > of the time, with the spare space trimmed. Same here, FWIW. In fact, I had

Re: [PATCH v3 01/22] btrfs-progs: convert: Introduce functions to read used space

David Sterba wrote on 2016/04/04 15:35 +0200: On Fri, Jan 29, 2016 at 01:03:11PM +0800, Qu Wenruo wrote: Before we do real convert, we need to read and build up used space cache tree for later data/meta separate chunk layout. This patch will iterate all used blocks in ext2 filesystem and

Re: [PATCH] btrfs-progs: fsck: Fix a false metadata extent warning

David Sterba wrote on 2016/04/04 13:18 +0200: On Fri, Apr 01, 2016 at 04:50:06PM +0800, Qu Wenruo wrote: After another look, why don't we use nodesize directly? Or stripesize where applies. With max_size == 0 the test does not make sense, we ought to know the alignment. Yes, my first

Re: Qgroups wrong after snapshot create

Hi, Thanks for the report. Mark Fasheh wrote on 2016/04/04 16:06 -0700: Hi, Making a snapshot gets us the wrong qgroup numbers. This is very easy to reproduce. From a fresh btrfs filesystem, simply enable qgroups and create a snapshot. In this example we have mounted a newly created fresh

[PATCH] Btrfs: fix missing s_id setting

When fs_devices->latest_bdev is deleted or is replaced, sb->s_id has not been updated. As a result, the deleted device name is displayed by btrfs_printk. [before fix] # btrfs dev del /dev/sdc4 /mnt2 # btrfs dev add /dev/sdb6 /mnt2 [ 217.458249] BTRFS info (device sdc4): found 1 extents [

Scrub priority, am I using it wrong?

I've got a btrfs file system set up on 6 drbd disks running on 2Tb spinning disks. The server is moderately loaded with various regular tasks that use a fair bit of disk IO, but I've scheduled my weekly btrfs scrub for the best quiet time in the week. The command that is run is:

Re: btrfsck: backpointer mismatch (and multiple other errors)

On Mon, Apr 4, 2016 at 2:50 PM, Kai Krakow wrote: >> Anyway the 2nd 4 is not possible. The seed is ro by definition so you >> can't remove snapshots from the seed. If you remove them from the >> mounted rw sprout volume, they're removed from the sprout, not the >> seed. If

Qgroups wrong after snapshot create

Hi, Making a snapshot gets us the wrong qgroup numbers. This is very easy to reproduce. From a fresh btrfs filesystem, simply enable qgroups and create a snapshot. In this example we have mounted a newly created fresh filesystem and mounted it at /btrfs: # btrfs quota enable /btrfs # btrfs sub

Re: btrfsck: backpointer mismatch (and multiple other errors)

Am Mon, 4 Apr 2016 22:50:18 +0200 schrieb Kai Krakow : > Am Mon, 4 Apr 2016 13:57:50 -0600 > schrieb Chris Murphy : > > > On Mon, Apr 4, 2016 at 1:36 PM, Kai Krakow > > wrote: > > > > > > > [...] > [...] > > > >

Re: btrfsck: backpointer mismatch (and multiple other errors)

Am Mon, 4 Apr 2016 13:57:50 -0600 schrieb Chris Murphy : > On Mon, Apr 4, 2016 at 1:36 PM, Kai Krakow > wrote: > > > > [...] > >> > >> ? > > > > In the following sense: I should disable the automounter and backup > > job for the seed device

Re: csum failed on innexistent inode

Am Mon, 4 Apr 2016 03:50:54 -0400 schrieb Jérôme Poulin : > How is it possible to get rid of the referenced csum errors if they do > not exist? Also, the expected checksum looks suspiciously the same for > multiple errors. Could it be bad RAM in that case? Can I convince >

Re: [PATCH 00/13 v3] Introduce device state 'failed', Hot spare and Auto replace

Am Mon, 4 Apr 2016 04:45:16 + (UTC) schrieb Duncan <1i5t5.dun...@cox.net>: > Kai Krakow posted on Mon, 04 Apr 2016 02:00:43 +0200 as excerpted: > > > Does this also implement "copy-back" - thus, it returns the > > hot-spare device to global hot-spares when the failed device has > > been

Re: [PATCH] delete obsolete function btrfs_print_tree()

On Mon, Apr 04, 2016 at 05:02:38PM +0100, Filipe Manana wrote: > It's not serious if it doesn't have all the proper error handling > and etc, it's just something for debugging purposes. I'm slowly trying to remove static checker warnings so that we can detect real bugs. People sometimes leave

Re: [PATCH 00/13 v3] Introduce device state 'failed', Hot spare and Auto replace

Am Mon, 4 Apr 2016 14:19:23 +0800 schrieb Anand Jain : > > Otherwise, I find "hot spare" misleading and it should be renamed. > > I never thought hot spare would be narrowed to such a specifics. [...] > About the naming.. the progs called it 'global spare' (device),

Re: btrfsck: backpointer mismatch (and multiple other errors)

On Mon, Apr 4, 2016 at 1:36 PM, Kai Krakow wrote: > >> > I guess the >> > seed source cannot be mounted or modified... >> >> ? > > In the following sense: I should disable the automounter and backup job > for the seed device while I let my data migrate back to main storage

Re: btrfsck: backpointer mismatch (and multiple other errors)

Am Sun, 3 Apr 2016 18:51:07 -0600 schrieb Chris Murphy : > > BTW: Is it possible to use my backup drive (it's btrfs single-data > > dup-metadata, single device) as a seed device for my newly created > > btrfs pool (raid0-data, raid1-metadata, three devices)? > > Yes. >

Re: Global hotspare functionality

2016-04-01 18:15 GMT-07:00 Anand Jain : Issue 2. At start of autoreplacig drive by hotspare, kernel craches in transaction handling code (inside of btrfs_commit_transaction() called by autoreplace initiating routines). I 'fixed' this by removing

Re: btrfsck: backpointer mismatch (and multiple other errors)

Am Mon, 4 Apr 2016 04:34:54 + (UTC) schrieb Duncan <1i5t5.dun...@cox.net>: > Meanwhile, putting bcache into write-around mode, so it makes no > further changes to the ssd and only uses it for reads, is probably > wise, and should help limit further damage. Tho if in that mode > bcache still

Re: [PATCH v8 00/27][For 4.7] Btrfs: Add inband (write time) de-duplication framework

On Fri, Mar 25, 2016 at 09:38:50AM +0800, Qu Wenruo wrote: > > Please use the newly added BTRFS_PERSISTENT_ITEM_KEY instead of a new > > key type. As this is the second user of that item, there's no precendent > > how to select the subtype. Right now 0 is for the dev stats item, but > > I'd like

Re: [PATCH] delete obsolete function btrfs_print_tree()

On 04/04/16 18:02, Filipe Manana wrote: > I use this function frequently during development, and there's a good > reason to use it instead of the user space tool btrfs-debug-tree. Good to know, that's why I asked. Printing unwritten extents makes sense. -h -- To unsubscribe from this list: send

Re: [PATCH] delete obsolete function btrfs_print_tree()

On Mon, Apr 4, 2016 at 4:54 PM, Holger Hoffstätte wrote: > On 04/04/16 15:56, David Sterba wrote: >> On Fri, Mar 25, 2016 at 03:53:17PM +0100, Holger Hoffstätte wrote: >>> Dan Carpenter's static checker recently found missing IS_ERR handling >>> in

Re: [PATCH] delete obsolete function btrfs_print_tree()

On 04/04/16 15:56, David Sterba wrote: > On Fri, Mar 25, 2016 at 03:53:17PM +0100, Holger Hoffstätte wrote: >> Dan Carpenter's static checker recently found missing IS_ERR handling >> in print-tree.c:btrfs_print_tree(). While looking into this I found that >> this function is no longer called

[PULL] Misc fixes for 4.6, part 2

Hi, please pull the following patches to 4.6. They fix some user visible problems, improve error handling and there are two debugging enhancements. Thanks. The following changes since commit

Re: [PATCH v4] btrfs: fix typo in btrfs_statfs()

On 04/04/16 15:45, David Sterba wrote: > On Mon, Apr 04, 2016 at 03:31:22PM +0100, Luis de Bethencourt wrote: >> Correct a typo in the chunk_mutex name to make it grepable. >> >> Since it is better to fix several typos at once, fixing the 2 more in the >> same file. >> >> Signed-off-by: Luis de

Re: [PATCH v4] btrfs: fix typo in btrfs_statfs()

On Mon, Apr 04, 2016 at 03:31:22PM +0100, Luis de Bethencourt wrote: > Correct a typo in the chunk_mutex name to make it grepable. > > Since it is better to fix several typos at once, fixing the 2 more in the > same file. > > Signed-off-by: Luis de Bethencourt Now the

[PATCH v4] btrfs: fix typo in btrfs_statfs()

Correct a typo in the chunk_mutex name to make it grepable. Since it is better to fix several typos at once, fixing the 2 more in the same file. Signed-off-by: Luis de Bethencourt --- Hi, Sorry for sending again. Previous version had a line over 80 characters.

[PATCH v3] btrfs: fix typo in btrfs_statfs()

Correct a typo in the chunk_mutex name to make it grepable. Since it is better to fix several typos at once, fixing the 2 more in the same file. Signed-off-by: Luis de Bethencourt --- Hi, David recommended I look around the rest of the file for other typos to fix.

Re: [PATCH] delete obsolete function btrfs_print_tree()

On Fri, Mar 25, 2016 at 03:53:17PM +0100, Holger Hoffstätte wrote: > Dan Carpenter's static checker recently found missing IS_ERR handling > in print-tree.c:btrfs_print_tree(). While looking into this I found that > this function is no longer called anywhere and was moved to btrfs-progs > long

Re: [PATCH v3 01/22] btrfs-progs: convert: Introduce functions to read used space

On Fri, Jan 29, 2016 at 01:03:11PM +0800, Qu Wenruo wrote: > Before we do real convert, we need to read and build up used space cache > tree for later data/meta separate chunk layout. > > This patch will iterate all used blocks in ext2 filesystem and record it > into cctx->used cache tree, for

Re: [PATCH] btrfs: fix typo in btrfs_statfs()

On Mon, Apr 04, 2016 at 11:13:57AM +0100, Luis de Bethencourt wrote: > Correct a typo in the chunk_mutex name. > > Signed-off-by: Luis de Bethencourt > --- > > Hi, > > I noticed this typo while fixing bug 114281 [0]. If this type of fixes are > not welcomed I could

Re: [PATCH] btrfs-progs: fsck: Fix a false metadata extent warning

On Fri, Apr 01, 2016 at 04:50:06PM +0800, Qu Wenruo wrote: > > After another look, why don't we use nodesize directly? Or stripesize > > where applies. With max_size == 0 the test does not make sense, we ought > > to know the alignment. > > > > > Yes, my first though is also to use nodesize

[PATCH v2] btrfs: fix typo in btrfs_statfs()

Correct a typo in the chunk_mutex name. Signed-off-by: Luis de Bethencourt --- Hi, I noticed this typo while fixing bug 114281 [0]. Sending a second version because the first one didn't ammend cleanly after the latest changes in the 'for-next' branch. Thanks, Luis [0]

[PATCH] btrfs: fix typo in btrfs_statfs()

Correct a typo in the chunk_mutex name. Signed-off-by: Luis de Bethencourt --- Hi, I noticed this typo while fixing bug 114281 [0]. If this type of fixes are not welcomed I could squash it into the patch for that bug. Thanks, Luis [0]

Re: csum failed on innexistent inode

On Mon, Apr 4, 2016 at 9:50 AM, Jérôme Poulin wrote: > Hi all, > > I have a BTRFS on disks running in RAID10 meta+data, one of the disk > has been going bad and scrub was showing 18 uncorrectable errors > (which is weird in RAID10). I tried using --repair-sector with

csum failed on innexistent inode

Hi all, I have a BTRFS on disks running in RAID10 meta+data, one of the disk has been going bad and scrub was showing 18 uncorrectable errors (which is weird in RAID10). I tried using --repair-sector with hdparm even if it shouldn't be necessary since BTRFS would overwrite the sector. Repair

Re: [PATCH 00/13 v3] Introduce device state 'failed', Hot spare and Auto replace

On 04/04/2016 08:00 AM, Kai Krakow wrote: Am Sat, 2 Apr 2016 09:30:38 +0800 schrieb Anand Jain : Auto replace: Replace happens automatically, that is when there is any write failed or flush failed, the device will be marked as failed, which will stop any further

Re: [PATCH 00/13 v3] Introduce device state 'failed', Hot spare and Auto replace

Duncan posted on Mon, 04 Apr 2016 04:45:16 + as excerpted: > Kai Krakow posted on Mon, 04 Apr 2016 02:00:43 +0200 as excerpted: > >> Does this also implement "copy-back" - thus, it returns the hot-spare >> device to global hot-spares when the failed device has been replaced? > > I don't