Signed-off-by: Wang Shilong
---
fs/btrfs/ctree.h | 14 ++
fs/btrfs/super.c | 14 --
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index ad1a594..e7c9e1c 100644
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -2058,6 +
When running stress test(including snapshots,balance,fstress), we trigger
the following BUG_ON() which is because we fail to start inode caching task.
[ 181.131945] kernel BUG at fs/btrfs/inode-map.c:179!
[ 181.137963] invalid opcode: [#1] SMP
[ 181.217096] CPU: 11 PID: 2532 Comm: btrfs No
From: Miao Xie
Currently, with inode cache enabled, we will reuse its inode id immediately
after unlinking file, we may hit something like following:
|->iput inode
|->return inode id into inode cache
|->create dir,fsync
|->power off
An easy way to reproduce this problem is:
mkfs.btrfs -f /dev/
Fix possible memory leaks in the following error handling paths:
read_tree_block()
btrfs_recover_log_trees
btrfs_commit_super()
btrfs_find_orphan_roots()
btrfs_cleanup_fs_roots()
Signed-off-by: Wang Shilong
---
fs/btrfs/disk-io.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
On Tue, Apr 22, 2014 at 05:12:34PM +0200, Xavier Bassery wrote:
> > > Global_rsv or GlobalRsv or Globalrsv or something else?
> >
> >Personally, I'd probably go for the camel case GlobalRsv, or
> > possibly GlbReserve. (Assuming that it's going to be only a single
> > token without whitespace
From: Ajesh JS
This patch provides a mechanism to modify the permission of a subvolume in a
btrfs file system
This helps to apply a policy of having read-write subvolume inside a read-only
subvolume.
One use case is to have the whole root file system as a read-only subvolume and
have /etc as a
On 04/23/2014 09:30 AM, David Sterba wrote:
On Tue, Apr 22, 2014 at 05:12:34PM +0200, Xavier Bassery wrote:
Global_rsv or GlobalRsv or Globalrsv or something else?
Personally, I'd probably go for the camel case GlobalRsv, or
possibly GlbReserve. (Assuming that it's going to be only a sin
Ah. Thank you for the replies. I didn't get them as mails and spinics
didn't update the thread until yesterday.
So I take it that the recommended course of action is not to wait for
any more or less unlikely btrfs-progs fix, but to try --repair and be
ready to restore from backup, too. Darn, a
> I am not a "dev", but since BTRFS utilizes a COW (Copy On Write)
> architecture, it doesn't keep a journal or history of transactions
> that can be unwound.
Ok, thanks for making that clear, I wasn't aware of that.
But shouldn't the chain of recent root trees kinda allow similar
functionality?
>
Hello,
I have a desktop system with 2 disks, all btrfs, single partition. All of
these partitions had
space_cache,inode_cache enabled.
Linux 3.14 has broken resume on my desktop, hence I need to shutdown and
restart the
machine every time.
But even on clean reboot, inode_cache was constantl
Can anyone boot a system using btrfs root with linux 3.14 or newer?
Because I can't.
I'm trying to move some 3.13.x based systems to 3.14.x and the kernel panics
during boot. It says to append a correct root=sdaX partition, but the one
provided is correct, because if use 3.13.x with the same kern
Le mercredi 23 avril 2014 20:30:08 Пламен Петров a écrit :
> Can anyone boot a system using btrfs root with linux 3.14 or newer?
Yes I do.
$ grep /boot /proc/mounts
/dev/sda8 /boot btrfs rw,noatime,compress=lzo,space_cache,autodefrag 0 0
/dev/sda1 /boot/efi vfat
rw,relatime,fmask=0022,dmask=0022
On Wed, Apr 23, 2014 at 08:30:08PM +0300, Пламен Петров wrote:
> Can anyone boot a system using btrfs root with linux 3.14 or newer?
>
> Because I can't.
It works fine for me.
> I'm trying to move some 3.13.x based systems to 3.14.x and the kernel panics
> during boot. It says to append a correc
On Wed, Apr 23, 2014 at 11:54:13AM -0700, Marc MERLIN wrote:
> On Wed, Apr 23, 2014 at 08:30:08PM +0300, Пламен Петров wrote:
> > Can anyone boot a system using btrfs root with linux 3.14 or newer?
> >
> > Because I can't.
>
> It works fine for me.
>
> > I'm trying to move some 3.13.x based syst
On Wed, Apr 23, 2014 at 10:06:12PM +0300, Пламен Петров wrote:
> Just to clarify - I am using a monolithic kernel built from source, and it
> has all the stuff it needs to support built-in, and then some. And no modules.
> The sources I'm using are the vanilla kernels from Linus and Greg KH
> dow
Пламен Петров schrieb:
I'm going with the module suggestion from Marc, too.
> /dev/sda2 / btrfs relatime,compress=zlib 0 0
This line looks kinda useless to me. The compress=zlib option won't be
applied at boot and cannot be changed at runtime because AFAIR btrfs d
> -Original Message-
> From: Marc MERLIN [mailto:m...@merlins.org]
> Sent: Wednesday, April 23, 2014 10:16 PM
> To: Пламен Петров
> Cc: linux-btrfs@vger.kernel.org
> Subject: Re: Can anyone boot a system using btrfs root with linux 3.14 or
> newer?
>
> On Wed, Apr 23, 2014 at 10:06:12PM +0
Chris,
> OpenSUSE 12.3 is using kernel 3.7 which is also old for this sort of recovery
> attempt. Even openSUSE 13.1 is at 3.11.6 which might work in a bind, but if
> it doesn't, inevitably someone will suggest you use something even newer.
Thanks for your reply, I appreciate it a lot.
> Curr
On Wed, Apr 23, 2014 at 2:28 PM, J S, Ajesh wrote:
> From: Ajesh JS
>
> This patch provides a mechanism to modify the permission of a subvolume in a
> btrfs file system
> This helps to apply a policy of having read-write subvolume inside a
> read-only subvolume.
> One use case is to have the wh
On Wed, 2014-04-23 at 21:06 +0200, Kai Krakow wrote:
> Пламен Петров schrieb:
>
> I'm going with the module suggestion from Marc, too.
>
> > /dev/sda2 / btrfs relatime,compress=zlib 0 0
>
> This line looks kinda useless to me. The compress=zlib option won't be
> a
The first mount of a non-trivial file system after a btrfs_convert, or
an ongoing btrfs balance operation containing large files may lead to an
oops (and a pathologically damaged file system) if the hang check timer
(CONFIG_DETECT_HUNG_TASK=y) is compiled into the linux kernel and not
disabled.
On Wed, Apr 23, 2014 at 10:37:44PM +0300, Пламен Петров wrote:
> > So now, we're kind of guessing. To save us all time, could you capture a
> > serial
> > console boot from the running 3.13 and then the failing 3.14.
>
> Well, for the details - see for example here:
> https://bugzilla.kernel.org/
Hi,
I have a filesystem that I've converted to raid6 from raid1, on 4 drives (I
have another copy of the data):
Total devices 4 FS bytes used 924.64GiB
devid1 size 1.82TiB used 474.00GiB path /dev/sdd
devid2 size 465.76GiB used 465.76GiB path /dev/sda
devid
On Wed, Apr 23, 2014 at 01:44:21PM -0700, Robert White wrote:
> As it is, the two options are not happy together. Be sure to
>
> echo 0 > /proc/sys/kernel/hung_task_timeout_secs
>
> to disable the timer before doing a mount or balance after a
But this only removes the messages from syslog, it d
[CCing Vladimir]
On Wed 16-04-14 18:42:10, Richard Davies wrote:
> Hi all,
>
> I have a test case in which I can often crash an entire machine by running
> dd to a file with a memcg with relatively generous limits. This is
> simplified from real world problems with heavy disk i/o inside container
On Thu, Apr 24, 2014 at 12:54:57AM +0300, Пламен Петров wrote:
> > It may help to look up what error -38 translates into for that mount error.
>
> My searches so far failed to return anything useful to solving this problem.
Yeah, I searched before you :) this would require reading the kernel sou
> -Original Message-
> From: Marc MERLIN [mailto:m...@merlins.org]
> Sent: Thursday, April 24, 2014 1:03 AM
> To: Пламен Петров
> Cc: linux-btrfs@vger.kernel.org
> Subject: Re: Can anyone boot a system using btrfs root with linux 3.14 or
> newer?
>
> On Thu, Apr 24, 2014 at 12:54:57AM +030
So the backup/restore system described using snapshots is incomplete
because the final restore is a copy operation. As such, the act of
restoring from the backup will require restarting the entire backup
cycle because the copy operation will scramble the metadata consanguinity.
The real choice
On Apr 23, 2014, at 1:06 PM, Kai Krakow wrote:
> Пламен Петров schrieb:
>
> I'm going with the module suggestion from Marc, too.
>
>> /dev/sda2 / btrfs relatime,compress=zlib 0 0
>
> This line looks kinda useless to me. The compress=zlib option won't be
> appli
On Wed, Apr 23, 2014 at 03:03:12PM -0700, Marc MERLIN wrote:
> On Thu, Apr 24, 2014 at 12:54:57AM +0300, Пламен Петров wrote:
> > > It may help to look up what error -38 translates into for that mount
> > > error.
> >
> > My searches so far failed to return anything useful to solving this problem
The screen shot provided makes it clear that one of the following kernel
parameters is incorrect:
> root=/dev/mapper/cryptroot
> rootflags=subvol=root
So either the dmcrypt volume hasn't been opened, thus isn't available; or
rootfs isn't on a subvolume named root found at the top level of the
On Wed, Apr 23, 2014 at 04:40:33PM -0600, Chris Murphy wrote:
> The screen shot provided makes it clear that one of the following kernel
> parameters is incorrect:
>
> > root=/dev/mapper/cryptroot
>
> > rootflags=subvol=root
>
> So either the dmcrypt volume hasn't been opened, thus isn't availa
On Wed, Apr 23, 2014 at 11:43:03PM +0100, Hugo Mills wrote:
> On Wed, Apr 23, 2014 at 04:40:33PM -0600, Chris Murphy wrote:
> > The screen shot provided makes it clear that one of the following kernel
> > parameters is incorrect:
> >
> > > root=/dev/mapper/cryptroot
> >
> > > rootflags=subvol=ro
On Wed, Apr 23, 2014 at 05:04:10PM -0400, Sergey Ivanyuk wrote:
> Hi,
>
> I have a filesystem that I've converted to raid6 from raid1, on 4 drives (I
> have another copy of the data):
>
> Total devices 4 FS bytes used 924.64GiB
> devid1 size 1.82TiB used 474.00GiB path /dev/sd
On Wed, Apr 23, 2014 at 03:50:18PM -0700, Marc MERLIN wrote:
> On Wed, Apr 23, 2014 at 11:43:03PM +0100, Hugo Mills wrote:
> > On Wed, Apr 23, 2014 at 04:40:33PM -0600, Chris Murphy wrote:
> > > The screen shot provided makes it clear that one of the following kernel
> > > parameters is incorrect:
On 04/23/2014 02:12 PM, Marc MERLIN wrote:
On Wed, Apr 23, 2014 at 01:44:21PM -0700, Robert White wrote:
As it is, the two options are not happy together. Be sure to
echo 0 > /proc/sys/kernel/hung_task_timeout_secs
to disable the timer before doing a mount or balance after a
But this only re
Howdy,
I writing slides about btrfs for an upcoming talk (at linuxcon) and I was
trying to gather a list of companies that contribute code to btrfs.
What I came up with (sorted alphabetically)
Couchbase (CouchDB)
Facebook
Fujitsu
Fusion-IO
Oracle
SGI
Suse
Are there other companies I missed?
Th
Oh while we're at it, are there companies that can say they are using btrfs
in production?
Marc
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems
what McDonalds is to gourmet cooking
H
On 4/23/14, 8:18 PM, Marc MERLIN wrote:
> Howdy,
>
> I writing slides about btrfs for an upcoming talk (at linuxcon) and I was
> trying to gather a list of companies that contribute code to btrfs.
>
> What I came up with (sorted alphabetically)
> Couchbase (CouchDB)
> Facebook
> Fujitsu
> Fusion
On 4/23/14, 8:18 PM, Marc MERLIN wrote:
> Howdy,
>
> I writing slides about btrfs for an upcoming talk (at linuxcon) and I was
> trying to gather a list of companies that contribute code to btrfs.
Also...
> What I came up with (sorted alphabetically)
> Couchbase (CouchDB)
> Facebook
> Fujitsu
>
On Apr 23, 2014, at 12:33 PM, Martin Wilck wrote:
> Chris,
>
>> OpenSUSE 12.3 is using kernel 3.7 which is also old for this sort of
>> recovery attempt. Even openSUSE 13.1 is at 3.11.6 which might work in a
>> bind, but if it doesn't, inevitably someone will suggest you use something
>> eve
It sounds like either a grub.cfg misconfiguration, or a failure to correctly
build the initrd/initramfs. So I'd post the grub.cfg kernel command line for
the boot entry that works and the entry that fails, for comparison.
And then also check and see if whatever utility builds your initrd has bee
Repair mode will commit transaction which will make us
fail to load log tree anymore.
Give a warning to common users, if they really want to
coninue, we will clear out log tree.
Signed-off-by: Wang Shilong
---
cmds-check.c | 33 +
1 file changed, 33 insertions(+)
This can not only give some speedups but also avoid forever loop
with a really broken filesystem.
Signed-off-by: Wang Shilong
---
cmds-check.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/cmds-check.c b/cmds-check.c
index 15806a4..e6fb380 100644
--- a/cmds-check.c
+++ b/cmds-chec
When encountering system crash or balance enospc errors,
there maybe still some reloc roots left.
The way we store reloc root is different from fs root:
reloc root's root key(BTRFS_RELOC_TREE_OBJECTID, ROOT_ITEM, objectid)
fs root's root key(objectid, ROOT_ITEM, -1)
reloc data's root key(BTRFS_DA
Originally only if 'block_only' is specified, the 'fs_root == NULL'
will be checked. But if 'block_only' is not specified and close_root
will be called blindly without checking 'fs_root == NULL', which is
unsafe.
Signed-off-by: Gui Hecheng
---
btrfs-debug-tree.c | 9 +
1 file changed, 5
On Wed, Apr 23, 2014 at 09:30:24PM -0500, Eric Sandeen wrote:
> On 4/23/14, 8:18 PM, Marc MERLIN wrote:
> > Howdy,
> >
> > I writing slides about btrfs for an upcoming talk (at linuxcon) and I was
> > trying to gather a list of companies that contribute code to btrfs.
>
> Also...
>
> > What I ca
Replied inline:
On 2014/04/24 12:30 AM, Robert White wrote:
So the backup/restore system described using snapshots is incomplete
because the final restore is a copy operation. As such, the act of
restoring from the backup will require restarting the entire backup
cycle because the copy operati
If we fail to load a free space cache, we can rebuild it from the extent tree,
so it is not a serious error, we should not output a error message that
would make the users uncomfortable. This patch uses warning message instead
of it.
Signed-off-by: Miao Xie
---
Changelog v1 -> v2:
- New patch
---
When we mounted the filesystem after the crash, we got the following
message:
BTRFS error (device xxx): block group has wrong amount of free space
BTRFS error (device xxx): failed to load free space cache for block group xxx
It is because we didn't update the metadata of the allocated spa
On Apr 23, 2014, at 10:45 PM, Marc MERLIN wrote:
>
>> On Wed, Apr 23, 2014 at 09:30:24PM -0500, Eric Sandeen wrote:
>>> On 4/23/14, 8:18 PM, Marc MERLIN wrote:
>>> Howdy,
>>>
>>> I writing slides about btrfs for an upcoming talk (at linuxcon) and I was
>>> trying to gather a list of companies th
On Thu, Apr 24, 2014 at 10:23 AM, Chris Murphy wrote:
>
> It sounds like either a grub.cfg misconfiguration, or a failure to correctly
> build the initrd/initramfs. So I'd post the grub.cfg kernel command line for
> the boot entry that works and the entry that fails, for comparison.
>
> And then
Dear All,
I have a very slow deduplication going on on an external usb disk. I'm
using it for backups - I rsync the relevent files to the disk and then
take a snapshot. I then deduplicate with bedup dedup
What I am finding is that it is reporting a deduplication between the
data on the disk an
53 matches
Mail list logo