Re: Kernel 2.6.18 and above

2007-04-20 Thread Bartlomiej Zolnierkiewicz
On Friday 20 April 2007, Benjamin Herrenschmidt wrote: I'm CC'ing linux-ide... looks like the disk which you say is 20GB is misdetected by the IDE layer as being 2GB. Ok, so we have: Probing IDE interface ide0... hda: WDC WD800JB-00FMA0, ATA DISK drive hdb: IC35L020AVVN07-0, ATA

Re: Loud pop coming from hard drive on reboot

2007-04-18 Thread Bartlomiej Zolnierkiewicz
On Wednesday 18 April 2007, Chuck Ebbert wrote: Mark Lord wrote: Mark Lord wrote: With the patch applied, I don't see *any* new activity in those S.M.A.R.T. attributes over multiple hibernates (Linux suspend-to-disk). Scratch that -- operator failure. ;) The patch makes no

Re: Loud pop coming from hard drive on reboot

2007-04-18 Thread Bartlomiej Zolnierkiewicz
On Wednesday 18 April 2007, Tejun Heo wrote: Mark Lord wrote: Chuck Ebbert wrote: Mark Lord wrote: I'll patch it locally on my own machines, but what about the tens of thousands of other Seagate notebook drive owners out there? This is a problem with Seagate specifically, spinning

Re: Loud pop coming from hard drive on reboot

2007-04-13 Thread Bartlomiej Zolnierkiewicz
On Thursday 12 April 2007, Chuck Ebbert wrote: Jan Engelhardt wrote: On Apr 11 2007 17:35, Chuck Ebbert wrote: Jan Engelhardt wrote: On Apr 11 2007 17:07, Chuck Ebbert wrote: When I reboot my notebook, it powers off and powers back on. On poweroff a loud snapping noise seems to be

Re: Loud pop coming from hard drive on reboot

2007-04-13 Thread Bartlomiej Zolnierkiewicz
On 4/13/07, Chuck Ebbert [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: Now we're getting somewhere. There is some other OS on here because it's required for doing BIOS updates. I booted it and shut down. The power cycle count increased but the power off retract count did

[git patches] IDE fixes

2007-04-10 Thread Bartlomiej Zolnierkiewicz
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ide/ide-cd.c |9 + drivers/ide/ide-io.c |6 +- drivers/ide/ide-iops.c |2 ++ drivers/ide/ide.c |2 ++ include/linux/ide.h|2 ++

Re: [PATCH] Correctly prevent IDE timer expiry function to run if request was already handled

2007-04-06 Thread Bartlomiej Zolnierkiewicz
On Friday 06 April 2007, Suleiman Souhlal wrote: It is possible for the timer expiry function to run even though the request has already been handled: ide_timer_expiry() only checks that the handler is not NULL, but it is possible that we have handled a request (thus clearing the handler) and

Re: [PATCH] ugly messages trying to open CD drive with no media present

2007-04-06 Thread Bartlomiej Zolnierkiewicz
On Monday 02 April 2007, [EMAIL PROTECTED] wrote: I get the following error messages when trying to open a CD device (specifically, the Teac CD-ROM CD-224E) that has no media present: hda: packet command error: status=0x51 { DriveReady SeekComplete Error } hda: packet command error:

Re: [PATCH] Correctly prevent IDE timer expiry function to run if request was already handled

2007-04-06 Thread Bartlomiej Zolnierkiewicz
On Friday 06 April 2007, Sergei Shtylyov wrote: Hello. Suleiman Souhlal wrote: The reason the timer could have been active at that point, before applying this patch, is that we try to dispatch a new request after handling one. The new request will then have its own expiry timer, along

Re: [PATCH] add correct interrupt property for pegasos ide

2007-04-04 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 04 April 2007, Olaf Hering wrote: The firmware assigns irq 20/21 to the VIA IDE device on Pegasos. But the required interrupt is 14/15. Maybe someone confused decimal vs. hexadecimal values. Good to see Pegasos platform being fixed to do the quirk in the proper way.

Re: [PATCH] add correct interrupt property for pegasos ide

2007-04-04 Thread Bartlomiej Zolnierkiewicz
On Wednesday 04 April 2007, Olaf Hering wrote: On Wed, Apr 04, Bartlomiej Zolnierkiewicz wrote: ? You are right, I did not test the ide driver again. pata_via works with the change. I will test the ide driver tomorrow. Thanks. There might be also the another issue here - the chipset

Re: [PATCH pata-2.6] sl82c105: rework PIO support (take 2)

2007-04-04 Thread Bartlomiej Zolnierkiewicz
... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH pata-2.6] sl82c105: DMA support code cleanup (take 4)

2007-04-04 Thread Bartlomiej Zolnierkiewicz
printk() and comment in the latter one as well. While at it, cleanup style in several places. --- This patch has also been actually tested at last. :-) Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] I moved Signed-off-by-s

Re: [PATCH pata-2.6] sl82c105: add speedproc() method and MWDMA0/1 support

2007-04-04 Thread Bartlomiej Zolnierkiewicz
On Wednesday 28 March 2007, Sergei Shtylyov wrote: Add the speedproc() method for setting transfer modes, modify config_for_dma() to call it and use ide_max_dma_mode() to select the best DMA mode. Add support for the multiword DMA modes 0 and 1, using the upper half of the 'drive_data' field

Re: [PATCH 0/4] libata: Workaround/fixes for ATAPI devices (revised)

2007-03-31 Thread Bartlomiej Zolnierkiewicz
revised per Tejun's advice.) All four look good to me. Thanks a lot for tracking this down. Acked-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Special thanks for fixing implicit libata vs drivers/ide regressions (patch 2/4 and 3/4). Bart - To unsubscribe from this list: send the line

[git patches] IDE fixes for 2.6.21-rc5

2007-03-26 Thread Bartlomiej Zolnierkiewicz
/ide/ide.c | 37 ++--- drivers/ide/pci/pdc202xx_new.c |3 ++- include/linux/ide.h|1 + 6 files changed, 67 insertions(+), 23 deletions(-) Albert Lee (1): pdc202xx_new: Enable ATAPI DMA Bartlomiej Zolnierkiewicz (2): ide

Re: libata: CD and dvd devices not recognized

2007-03-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 19 March 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: It seems that the drive works just fine in PIO mode with pdc202xx_new IDE driver (it doesn't support ATAPI DMA at the moment) There used to be Albert's patch enabling ATAPIT DMA

Re: request_queue_t depends on CONFIG_BLOCK

2007-03-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 23 March 2007, Olaf Hering wrote: On Thu, Mar 22, Christoph Hellwig wrote: On Thu, Mar 22, 2007 at 10:52:34PM +0100, Olaf Hering wrote: How can this compile error be fixed properly? request_queue_t is inside CONFIG_BLOCK, ide_drive_s (and likely others) use it

Re: request_queue_t depends on CONFIG_BLOCK

2007-03-23 Thread Bartlomiej Zolnierkiewicz
On Friday 23 March 2007, Olaf Hering wrote: On Fri, Mar 23, Bartlomiej Zolnierkiewicz wrote: Because it is needed in a few places. Is there really any PPC64 specific code which needs linux/ide.h (ppc_ide_md is used only by PPC32)? I suspect that the answer to my question

Re: [PATCH 3/3] Use correct IDE error recovery

2007-03-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 08 March 2007, Suleiman Souhlal wrote: On Mar 7, 2007, at 1:16 PM, Bartlomiej Zolnierkiewicz wrote: Please respin the patch so I could merge it. Ok. Since I think that it's worth to have it in 2.6.21-final and respin didn't happen I did the required changes myself

[PATCH] ide: fix locking for manual DMA enable/disable (hdparm -d)

2007-03-21 Thread Bartlomiej Zolnierkiewicz
is changed (so it won't race against I/O commands in fly). I audited briefly all -ide_dma_check/-ide_dma_on/-tuneproc/-speedproc implementations and they all look OK wrt to this change. Cc: Sergei Shtylyov [EMAIL PROTECTED] Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH] ide: revert ide: fix drive side 80c cable check, take 2 for now

2007-03-20 Thread Bartlomiej Zolnierkiewicz
commit f31f0cc2f0b7527072d94d02da332d9bb8d7d94c. ] Thanks goes out to Fernando Mitio Yamada for reporting the problem and patiently testing patches. Cc: Tejun Heo [EMAIL PROTECTED] Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c

Re: libata: CD and dvd devices not recognized

2007-03-18 Thread Bartlomiej Zolnierkiewicz
On Sunday 18 March 2007, YUP wrote: Hello Bartek, Thanks, does reading from CD/DVD media also work fine now? Yes, drives can read all media cd and dvd I have. OK, thanks for testing. The conclusion here is that the problem experienced by Yarema is clearly some libata regression wrt

Re: libata: CD and dvd devices not recognized

2007-03-17 Thread Bartlomiej Zolnierkiewicz
On Saturday 17 March 2007, Albert Lee wrote: Bartlomiej Zolnierkiewicz wrote: Hi, Any news about this test? ide-cd driver is much more forgiving for quirky hardware than libata+sr so please give it a try... Hi Bart, Yarema did the run test, but the AOpen drive was connected

Re: libata: CD and dvd devices not recognized

2007-03-17 Thread Bartlomiej Zolnierkiewicz
disable ata_piix libata driver, enable piix IDE driver and retest. :-) Thanks, Bart 02:05.0 Ethernet controller: ADMtek NC100 Network Everywhere Fast Ethernet 10/100 (rev 11) Bartlomiej Zolnierkiewicz пише: On Saturday 17 March 2007, Albert Lee wrote: Bartlomiej Zolnierkiewicz wrote

Re: libata: CD and dvd devices not recognized

2007-03-17 Thread Bartlomiej Zolnierkiewicz
On Saturday 17 March 2007, YUP wrote: Just to check up can you recheck my config? Looks fine but please set CONFIG_ATA_PIIX to n (just in case). Bart - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] jmicron: make ide jmicron driver play nice with libata ones

2007-03-17 Thread Bartlomiej Zolnierkiewicz
PCI class code such that it doesn't attach itself to the SATA part preventing the proper ahci driver from attaching. This change is suggested by Bartlomiej. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] applied, thanks - To unsubscribe from

Re: [PATCH] jmicron: make ide jmicron driver play nice with libata ones

2007-03-17 Thread Bartlomiej Zolnierkiewicz
On Saturday 17 March 2007, Alan Cox wrote: PATA ports live in separate functions with different programming interfaces. pata_jmicron and ide jmicron drivers can drive only the PATA part. This isn't actually true. The IDE jmicron driver can drive both the PATA and the SATA parts in

Re: [PATCH 1/2] scc_pata: dependency fix

2007-03-17 Thread Bartlomiej Zolnierkiewicz
On Friday 16 March 2007, Akira Iguchi wrote: This patch fixes: * the dependency of scc_pata on BLK_DEV_IDEDMA_PCI * incorrect link to ide-core * move scc_pata from ide/ppc to ide/pci Signed-off-by: Kou Ishizaki [EMAIL PROTECTED] Signed-off-by: Akira Iguchi [EMAIL PROTECTED] I applied

Re: [git patches] IDE fixes

2007-03-17 Thread Bartlomiej Zolnierkiewicz
On Sunday 18 March 2007, Linus Torvalds wrote: On Sat, 17 Mar 2007, Bartlomiej Zolnierkiewicz wrote: to receive the following updates: b/drivers/ide/Kconfig | 48 - b/drivers/ide/Makefile |1 b/drivers/ide/arm/icside.c

Re: [PATCH] libata: add support for READ/WRITE LONG

2007-03-16 Thread Bartlomiej Zolnierkiewicz
On Friday 16 March 2007, Mark Lord wrote: Jeff Garzik wrote: Alan Cox wrote: I think it only requires the *host* to drop to PIO0 timings. In which case it should be achievable w/o libata modification -- if the driver has to snoop command and turn off prefetch, why not switch to

Re: regression: ide-floppy doesn't work with IOMEGA IDE ZIP drive

2007-03-15 Thread Bartlomiej Zolnierkiewicz
On Wednesday 14 March 2007, Stanislav Brabec wrote: Bartlomiej Zolnierkiewicz wrote: On Wednesday 14 March 2007, Stanislav Brabec wrote: Albert Lee wrote: Tejun Heo wrote: Hmmm... weird. Your drive bears the same model name as Stanislav's. I don't think the low

Re: [PATCH pata-2.6 fix queue] cmd64x: fix recovery time calculation (take 3)

2007-03-15 Thread Bartlomiej Zolnierkiewicz
... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- This patch has been changed in accordance to the pending reordering as DMA support removal and addition patches are going to be merged. In addition, I've put quantize_timing

[PATCH 1/2] ide: don't allow DMA to be enabled if CONFIG_IDEDMA_{ICS,PCI}_AUTO=n

2007-03-15 Thread Bartlomiej Zolnierkiewicz
and testing the fix. Also thanks to Sergei Shtylyov for help in debugging the problem. Cc: Patrick Horn [EMAIL PROTECTED] Cc: Sergei Shtylyov [EMAIL PROTECTED] Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c |2 +- 1

[PATCH 2/2] ide: remove CONFIG_IDEDMA_{ICS,PCI}_AUTO config options

2007-03-15 Thread Bartlomiej Zolnierkiewicz
loss because ide=nodma kernel option is still available. Cc: Patrick Horn [EMAIL PROTECTED] Cc: Sergei Shtylyov [EMAIL PROTECTED] Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig | 32

Re: [PATCH 10/13] sl82c105: add -speedproc support

2007-03-15 Thread Bartlomiej Zolnierkiewicz
On Wednesday 14 March 2007, Sergei Shtylyov wrote: Hello, I wrote: Bartlomiej Zolnierkiewicz wrote: [PATCH] sl82c105: add -speedproc support * add sl82c105_tunepio() wrapper for sl82c105_tune_drive() (just to get the error value) * add sl82c105_tune_chipset() (-speedproc

Re: regression: ide-floppy doesn't work with IOMEGA IDE ZIP drive

2007-03-14 Thread Bartlomiej Zolnierkiewicz
On Wednesday 14 March 2007, Stanislav Brabec wrote: Albert Lee wrote: Tejun Heo wrote: Hmmm... weird. Your drive bears the same model name as Stanislav's. I don't think the low level driver is causing the difference. They both use the standard libata HSM implementation. Any

Re: ide-layer troubles with cd burning devices in kernels 2.6.20 and 2.6.21 rc1 + rc2

2007-03-14 Thread Bartlomiej Zolnierkiewicz
Ok, thanks for reporting back - I'm crossing out this item from my TODO. :-) Bart On Wednesday 14 March 2007, Uwe Bugla wrote: Hi Linus, Bart, Andrew, Alan, all ide-layer bugs I reported in connection with reinitialization oopses using a TEAC CDRW54 are gone in 2.6.21-rc3-git4. This is a

Re: regression: ide-floppy doesn't work with IOMEGA IDE ZIP drive

2007-03-13 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 12 March 2007, Sergei Shtylyov wrote: Hello. Tejun Heo wrote: Stanislav Brabec reported that IOMEGA IDE ZIP drive doesn't work with recent kernels. Low level driver is via82cxxx. Relevant part of 2.6.20.1 boot message follows. VP_IDE: IDE controller at PCI slot

Re: Again problems with PDC20268 and vol_id

2007-03-10 Thread Bartlomiej Zolnierkiewicz
[ added Jens to cc: ] Hi, On Saturday 10 March 2007, Guido Diepen wrote: Hi Sergey, Is the partition table correct? Maybe the partition extends beyond the end of physical disk for some reason, and when the kernel tries to access last blocks of the partition, it actually tries to read

[PATCH 7/13] ide: use ide_tune_dma() part #2

2007-03-10 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: use ide_tune_dma() part #2 Use ide_tune_dma() in ide-cris/it821x/pdc202xx_old/serverworks drivers. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/cris/ide-cris.c| 14 +- drivers/ide/pci/it821x.c | 21

[PATCH 8/13] cs5530/sc1200: DMA support cleanup

2007-03-10 Thread Bartlomiej Zolnierkiewicz
of calling -dma_off_quietly before calling -ide_dma_check so there is no need to call it in -ide_dma_check methods * bump driver version Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cs5530.c |7 +-- drivers/ide/pci/sc1200.c | 27 --- 2

[PATCH 9/13] cs5530/sc1200: add -speedproc support

2007-03-10 Thread Bartlomiej Zolnierkiewicz
/drivers/ide/pci/sc1200.c Version 0.94Mar 10 2007 * * Copyright (C) 2000-2002 Mark Lord [EMAIL PROTECTED] * Copyright (C) 2007 Bartlomiej Zolnierkiewicz @@ -95,6 +95,20 @@ static const unsigned int sc1200_pio_tim */ //#define SC1200_BAD_PIO(timings

[PATCH 10/13] sl82c105: add -speedproc support

2007-03-10 Thread Bartlomiej Zolnierkiewicz
[PATCH] sl82c105: add -speedproc support * add sl82c105_tunepio() wrapper for sl82c105_tune_drive() (just to get the error value) * add sl82c105_tune_chipset() (-speedproc method) for setting transfer mode Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci

[PATCH 12/13] ide: add missing validity checks for identify words 62 and 63

2007-03-10 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: add missing validity checks for identify words 62 and 63 Check validity of identify words 62 and 63 before using them in ide_get_mode_mask(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c |6 -- 1 file changed, 4 insertions(+), 2

[PATCH 13/13] ide: remove ide_use_dma()

2007-03-10 Thread Bartlomiej Zolnierkiewicz
be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c | 42 +- include/linux/ide.h |2 -- 2 files changed, 5 insertions(+), 39 deletions(-) Index: b/drivers/ide/ide-dma.c

[PATCH 1/13] ide: fix PIO setup on resume for ATAPI devices

2007-03-10 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: fix PIO setup on resume for ATAPI devices PIO should be restored also for ATAPI devices during resume, fix it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) Index: b

[PATCH 2/13] it821x: PIO mode setup fixes

2007-03-10 Thread Bartlomiej Zolnierkiewicz
at it: * fix few comments * bump driver version Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/it821x.c | 126 +-- 1 file changed, 58 insertions(+), 68 deletions(-) Index: b/drivers/ide/pci/it821x.c

[PATCH 3/13] siimage: fix wrong -swdma_mask

2007-03-10 Thread Bartlomiej Zolnierkiewicz
() and if DMA is available config_siimage_chipset_for_pio() will be called by siimage_tune_chipset() * remove needless config_chipset_for_pio() wrapper * bump driver version Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/siimage.c | 12 ++-- 1 file changed

[PATCH 4/13] ide-cris: fix -speedproc and wrong -swdma_mask

2007-03-10 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide-cris: fix -speedproc and wrong -swdma_mask * fix -speedproc to set the drive speed * this driver doesn't support SWDMA so use the correct -swdma_mask * BUG() if an unsupported mode is passed to -speedproc Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide

[PATCH 5/13] ide: always disable DMA before tuning it

2007-03-10 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: always disable DMA before tuning it ide_start_power_step() and set_using_dma() were missing -dma_off_quietly call (comment in probe_hwif() states that DMA should be always cleared before tuning is attempted). Fix it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 6/13] cs5530/sc1200: add -udma_filter methods

2007-03-10 Thread Bartlomiej Zolnierkiewicz
()/ide_max_dma_mode() helpers. While at it bump version numbers. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cs5530.c | 120 +-- drivers/ide/pci/sc1200.c | 86

Re: [PATCH 10/13] sl82c105: add -speedproc support

2007-03-10 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 10 March 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] sl82c105: add -speedproc support * add sl82c105_tunepio() wrapper for sl82c105_tune_drive() (just to get the error value) * add sl82c105_tune_chipset() (-speedproc method

Re: [PATCH 3/13] siimage: fix wrong -swdma_mask

2007-03-10 Thread Bartlomiej Zolnierkiewicz
On Saturday 10 March 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] siimage: fix wrong -swdma_mask This driver doesn't support SWDMA so use the correct -swdma_mask. While at it: * no need to call config_chipset_for_pio() in config_chipset_for_dma

Re: IDE/ATAPI timeouts lost interrupts on alpha with 2.6.20.2

2007-03-10 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 10 March 2007, Russell Howe wrote: Evening all, I just built a 2.6.20.2 kernel for my alpha (a digital personal workstation 500AU), and on bootup noticed the messages below, which took a long time to print. There was no media in the CDROM, and there's nothing else hanging

Re: [PATCH 2.6.22] remove Intel combined mode quirk

2007-03-09 Thread Bartlomiej Zolnierkiewicz
hardware. In either case, you will get full performance from both SATA and PATA ports now, without having to pass a kernel command line parameter. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Acked-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Thanks for fixing this. Bart

Re: [PATCH 3/3] Use correct IDE error recovery

2007-03-08 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 08 March 2007, Suleiman Souhlal wrote: On Mar 7, 2007, at 1:16 PM, Bartlomiej Zolnierkiewicz wrote: Hi, (sorry for the long delay) On Wednesday 21 February 2007, Suleiman Souhlal wrote: IDE error recovery is using WIN_IDLEIMMEDIATE which was only valid

Re: [PATCH 3/3] Use correct IDE error recovery

2007-03-07 Thread Bartlomiej Zolnierkiewicz
Hi, (sorry for the long delay) On Wednesday 21 February 2007, Suleiman Souhlal wrote: IDE error recovery is using WIN_IDLEIMMEDIATE which was only valid for IDE V1 and IDE V2. Modern drives will not be able to recover using this error handling. The correct thing to do is issue a SRST

Re: [PATCH][pata-2.6 tree] pdc202xx_old: rewrite mode programming code

2007-03-05 Thread Bartlomiej Zolnierkiewicz
On Monday 05 March 2007, Sergei Shtylyov wrote: Hello, I wrote: official == same as in the docs and vendor driver :-) Erm, those look a bit doubtful... I believe that they are correct - please see explanations below. Yeah, sorry about that. Only SWDMA timings are

[PATCH] serverworks: PIO mode setup fixes

2007-03-04 Thread Bartlomiej Zolnierkiewicz
-current_speed * bump driver version Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/serverworks.c | 68 +- 1 file changed, 15 insertions(+), 53 deletions(-) Index: b/drivers/ide/pci/serverworks.c

[PATCH] sis5513: PIO mode setup fixes

2007-03-04 Thread Bartlomiej Zolnierkiewicz
() to sis5513_tuneproc() and config_chipset_for_pio() to sis5513_tune_driver() * bump driver version Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sis5513.c | 85 +++--- 1 file changed, 36 insertions(+), 49 deletions(-) Index

[git patches] IDE updates

2007-03-03 Thread Bartlomiej Zolnierkiewicz
Cox (2): siimage: DRAC4 note ide: remove a ton of pointless #undef REALLY_SLOW_IO Andrew Morton (1): ide: fix pmac breakage Bartlomiej Zolnierkiewicz (2): ide: remove some obsoleted kernel params (v2) ide: make legacy IDE VLB modules check for the probe kernel params

[PATCH][pata-2.6 tree] pdc202xx_old: rewrite mode programming code

2007-03-03 Thread Bartlomiej Zolnierkiewicz
) * add FIXME comment about missing locking for 66MHz clock register Also while at it: * remove unused defines * do a few cosmetic / CodingStyle fixes * bump driver version Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/pdc202xx_old.c | 176

[PATCH][libata] pata_pdc202xx_old: fix data corruption and other problems

2007-03-03 Thread Bartlomiej Zolnierkiewicz
programming PIO mode bits 0x18 weren't cleared so suboptimal timings were used for PIO1-4 if PIO0 was previously set (bit 0x10) and for PIO0/3/4 if PIO1/2 was previously set (bit 0x08) and finally bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ata

Re: [PATCH][libata] pata_pdc202xx_old: fix data corruption and other problems

2007-03-03 Thread Bartlomiej Zolnierkiewicz
(bit 0x08) and finally bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ata/pata_pdc202xx_old.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) Index: b/drivers/ata/pata_pdc202xx_old.c

Re: [PATCH] (pata-2.6 fix queue) cmd64x: add back MWDMA support

2007-03-02 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 28 February 2007, Sergei Shtylyov wrote: Add back the multiword DMA support (I think nobody will miss single-word DMA). In order to do it, a number of changes had to be done: - rename program_drive_counts() to program_cycle_times(), pass to it cycle's total/active times

Re: [PATCH] (pata-2.6 fix queue) cmd64x: fix recovery time calculation (take 2)

2007-03-02 Thread Bartlomiej Zolnierkiewicz
PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Just discovered a missed rename in this patch -- it's always a good idea to enable a debugging option when compiling. :-) The later patches should be still applying without issues... I replaced the old patch with this one

Re: [git patches] more IDE updates

2007-02-26 Thread Bartlomiej Zolnierkiewicz
On Monday 26 February 2007, Sergei Shtylyov wrote: Hello, I wrote: Contains: IRQ-ack fix for ICH chipsets (Albert Lee), ide-floppy unformatted media fix (Alan Cox), more fixes for IDE PCI drivers (Sergei Shtylyov), new driver for Toshiba Cell Reference Board (Kou Ishizaki kou.ishizaki

Re: Fwd: [LIBATA] drives not detected

2007-02-25 Thread Bartlomiej Zolnierkiewicz
On Sunday 25 February 2007, Patrick Ale wrote: On 2/24/07, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: Hoi and good afternoon :) Hey! Okay so... this is my dmesg with the legacy IDE drivers loaded. Please note that I still use libata for my boot drive but that the current vs

Re: [PATCH libata-dev#upstream-fixes] pata_amd: fix an obvious bug in cable detection

2007-02-25 Thread Bartlomiej Zolnierkiewicz
On Sunday 25 February 2007, Tejun Heo wrote: [cc'ing Mark, Bart and Sergei. Hi] Alan wrote: This makes unreliable cable detection even more unreliable. Please consider for -stable. Thanks. At minimum you also need to stop doing drive side detect for PATA_CBL_80 as many

Re: [PATCH libata-dev#upstream-fixes] pata_amd: fix an obvious bug in cable detection

2007-02-25 Thread Bartlomiej Zolnierkiewicz
On Sunday 25 February 2007, Tejun Heo wrote: Bartlomiej Zolnierkiewicz wrote: Why can't libata do the right thing and just send IDENTIFY command to the slave device first? That's my plan B. I'm just not sure whether it would do any good, would it? Probably it would but to know for sure

Re: Fwd: [LIBATA] drives not detected

2007-02-24 Thread Bartlomiej Zolnierkiewicz
On Saturday 24 February 2007, Patrick Ale wrote: Thanks, Hey, Being serious has never been one of my strongest sides ;-) Anyway, I will do the tests tomorrow, even tho I doubt if I'll run into the problems I had, cause really.. since i changed the cable this morning everything seems

Re: [PATCH] (pata-2.6 fix queue) cmd64x: use interrupt status from MRDMODE register

2007-02-23 Thread Bartlomiej Zolnierkiewicz
On Friday 16 February 2007, Sergei Shtylyov wrote: Fold the parts of the ide_dma_end() methods indetical to __ide_dma_end() into a mere call to it. Start using faster versions of the ide_dma_end() and ide_dma_test_irq() methods for the PCI0646U and newer chips that have the duplicate

Re: [PATCH] (pata-2.6 fix queue) cmd64x: add/fix enablebits

2007-02-23 Thread Bartlomiej Zolnierkiewicz
On Tuesday 20 February 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: The IDE core looks at the wrong bit when checking if the secondary channel is enabled on PCI0646 -- CFR bit 8 is read-ahead disable, bit 3 is the correct one. I guess that you meant CNTRL

Re: [PATCH] (pata-2.6 fix queue) sl82c105: DMA support code cleanup (take 3)

2007-02-23 Thread Bartlomiej Zolnierkiewicz
On Friday 23 February 2007, Sergei Shtylyov wrote: Fold the now equivalent code in the ide_dma_check() method into a mere call to ide_use_dma(). Make config_for_dma() return non-zero if DMA mode has been set and call it from the ide_dma_check() method instead of ide_dma_on(). Also, defer

Re: [PATCH 1/3] Make the IDE DMA timeout modifiable

2007-02-20 Thread Bartlomiej Zolnierkiewicz
On Wednesday 21 February 2007 02:19, Suleiman Souhlal wrote: It can be changed via /proc/ide/hd?/settings. Why do we need to change IDE DMA timeout dynamically? BTW /proc/ide/hd?/settings is obsoleted Signed-off-by:Ed Falk [EMAIL PROTECTED] --- drivers/ide/ide-dma.c |3 ++-

Re: [PATCH 2/3] Don't change transfer speed while requests are in flight

2007-02-20 Thread Bartlomiej Zolnierkiewicz
On Wednesday 21 February 2007 02:21, Suleiman Souhlal wrote: Use ide_wait_cmd() in ide_config_drive_speed() if the drive has been initialized and we're not in an interrupt, to avoid changing the xfer speed while requests are in flight. Many devices have problems with SETFEATURES_XFER if the

Re: [PATCH] (pata-2.6 fix queue) cmd64x: interrupt status fixes (resend)

2007-02-19 Thread Bartlomiej Zolnierkiewicz
On Thursday 15 February 2007 14:53, Sergei Shtylyov wrote: The driver's ide_dma_test_irq() method was reading the MRDMODE register even on PCI0643/6 where it was write-only -- fix this by always reading the backward- compatible interrupt bits, renaming dma_alt_stat to irq_stat as these

Re: [PATCH] (pata-2.6 fix queue) cmd64x: add/fix enablebits

2007-02-19 Thread Bartlomiej Zolnierkiewicz
On Wednesday 14 February 2007 23:35, Sergei Shtylyov wrote: The IDE core looks at the wrong bit when checking if the secondary channel is enabled on PCI0646 -- CFR bit 8 is read-ahead disable, bit 3 is the correct one. I guess that you meant CNTRL here? [ I corrected this in the applied

Re: [PATCH] (pata-2.6 fix queue) cmd64x: procfs code fixes/cleanups

2007-02-19 Thread Bartlomiej Zolnierkiewicz
On Thursday 15 February 2007 20:17, Sergei Shtylyov wrote: Fix several issues with the driver's procfs output: - when testing if channel is enabled, the code looks at the simplex bits, not at the real enable bits -- add #define for the primary channel enable bit; - UltraDMA modes 0,

Re: [PATCHSET] libata: PATA driver for Celleb

2007-02-19 Thread Bartlomiej Zolnierkiewicz
On Tuesday 20 February 2007 00:46, Alan wrote: into one in drivers/ide but really want splitting for libata with some kind of libata-pmac owning the shared stuff You meand driver/ide/ppc/pmac.c ? Yes moving them out of the macio_asic to a PCI device at one point, so yes, maybe

Re: [PATCH 12/15] ide: make ide_hwif_t.ide_dma_host_on void

2007-02-19 Thread Bartlomiej Zolnierkiewicz
On Monday 19 February 2007 23:20, Olaf Hering wrote: On Sat, Feb 03, Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: make ide_hwif_t.ide_dma_host_on void +++ b/drivers/ide/ppc/pmac.c @@ -1984,10 +1984,8 @@ static void pmac_ide_dma_host_off(ide_dr { } -static int

Re: [PATCH] ide-cs: Update device table

2007-02-19 Thread Bartlomiej Zolnierkiewicz
On Sunday 18 February 2007 09:49, Magnus Damm wrote: ide-cs: Update device table Add CFA devices from I-O Data, Mitsubishi and Viking. Add SanDisk comment. Signed-off-by: Magnus Damm [EMAIL PROTECTED] applied, thanks - To unsubscribe from this list: send the line unsubscribe linux-ide in

Re: [PATCH] (pata-2.6 fix queue) cmd64x: remove broken SW/MW DMA support

2007-02-16 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 16 February 2007 14:11, Sergei Shtylyov wrote: Mikael Pettersson wrote: On Thu, 8 Feb 2007 09:58:45 +0100 (MET), Mikael Pettersson wrote: On Thu, 8 Feb 2007 00:00:32 +0300, Sergei Shtylyov wrote: Remove the bogus code pretending to set SW/MW DMA timings -- I wonder

Re: [PATCH] (pata-2.6 fix queue) cmd64x: remove broken SW/MW DMA support

2007-02-16 Thread Bartlomiej Zolnierkiewicz
On Friday 16 February 2007 14:39, Sergei Shtylyov wrote: Hello. Sergei Shtylyov wrote: The intent of the patch was exactly to *remove* broken DMA support until it's fixed (which requires more work). It only worked by chance -- because MWDMA2 timings are the same as of PIO4. Have

Re: [PATCH] use winbond libata instead of ide driver for pseries CD drives

2007-02-16 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 16 February 2007 10:20, Olaf Hering wrote: Change the default for the built-in IDE on p610/p615/p630 from ide to libata. libata has better error handling and the drive can recover when hald does its CD media polling. Signed-off-by: Olaf Hering [EMAIL PROTECTED] Does IDE

Re: [PATCH] use winbond libata instead of ide driver for pseries CD drives

2007-02-16 Thread Bartlomiej Zolnierkiewicz
On Friday 16 February 2007 15:46, Bartlomiej Zolnierkiewicz wrote: Hi, On Friday 16 February 2007 10:20, Olaf Hering wrote: Change the default for the built-in IDE on p610/p615/p630 from ide to libata. libata has better error handling and the drive can recover when hald does its CD

Re: [PATCH] use winbond libata instead of ide driver for pseries CD drives

2007-02-16 Thread Bartlomiej Zolnierkiewicz
On Friday 16 February 2007 14:52, Sergei Shtylyov wrote: I'm sorry, how those 2 drivers can be equivalent?! The pata_winbond driver is for VLB only, sl81c105 was for PCI only -- you certainly want to use pata_sl82c105 (indeed better version of sl82c105 driver). I was under the

Re: [PATCH] use winbond libata instead of ide driver for pseries CD drives

2007-02-16 Thread Bartlomiej Zolnierkiewicz
On Friday 16 February 2007 15:55, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: I'm sorry, how those 2 drivers can be equivalent?! The pata_winbond driver is for VLB only, sl81c105 was for PCI only -- you certainly want to use pata_sl82c105 (indeed better

Re: [PATCH] (pata-2.6 fix queue) cmd64x: remove broken SW/MW DMA support

2007-02-16 Thread Bartlomiej Zolnierkiewicz
On Friday 16 February 2007 16:00, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: Mikael Pettersson wrote: Remove the bogus code pretending to set SW/MW DMA timings -- I wonder whether its author really thought that he could achieve that wrtiting to BMIDE status

Re: [PATCH] (pata-2.6 fix queue) cmd64x: remove broken SW/MW DMA support

2007-02-16 Thread Bartlomiej Zolnierkiewicz
On Friday 16 February 2007 16:34, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: Remove the bogus code pretending to set SW/MW DMA timings -- I wonder whether its author really thought that he could achieve that wrtiting to BMIDE status registers? Stop fiddling

[git patches] more IDE updates

2007-02-16 Thread Bartlomiej Zolnierkiewicz
controllers (revised #4) ide: remove clearing bmdma status from cdrom_decode_status() (rev #4) Bartlomiej Zolnierkiewicz (23): hpt34x: hpt34x_tune_chipset() (-speedproc) fix atiixp/jmicron/triflex: fix PIO fallback pdc202xx_old: remove dead code au1xxx-ide: remove dead

Re: [PATCH 7/8] ide: make legacy IDE VLB modules check for the probe kernel params

2007-02-14 Thread Bartlomiej Zolnierkiewicz
On Wednesday 14 February 2007 11:53, Alan wrote: On Wed, 14 Feb 2007 02:57:12 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: [PATCH] ide: make legacy IDE VLB modules check for the probe kernel params Legacy IDE VLB host drivers didn't check for probe options when compiled

Re: [PATCH 7/8] ide: make legacy IDE VLB modules check for the probe kernel params

2007-02-14 Thread Bartlomiej Zolnierkiewicz
On Wednesday 14 February 2007 12:17, Alan wrote: No point obsoleting the old ones. By the time being obsolete turns into being anything like gone, the hardware won't exist. It just causes We don't have stable rules for kernel parameters. We have fifteen years of traditional, common

Re: [PATCH] (pata-2.6 fix queue) sl82c105: DMA support code cleanup

2007-02-14 Thread Bartlomiej Zolnierkiewicz
On Tuesday 13 February 2007 22:43, Sergei Shtylyov wrote: Fold the now equivalent code in the ide_dma_check() method into a mere call to ide_use_dma(). Make config_for_dma() return non-zero if DMA mode has been set and call it from the ide_dma_check() method instead of ide_dma_on(). Also,

[PATCH 7/8] ide: make legacy IDE VLB modules check for the probe kernel params (v2)

2007-02-14 Thread Bartlomiej Zolnierkiewicz
it by adding probe module param to legacy IDE VLB host drivers. v2: * don't obsolete old ide0=dtc2278/ht6560b/qd65xx/ali14xx/umc8672 IDE driver options yet (per Alan Cox's request) and enhance documentation Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Documentation/ide.txt

Re: [PATCH] ide/pci/delkin_cb.c: pci_module_init to pci_register_driver

2007-02-14 Thread Bartlomiej Zolnierkiewicz
On Wednesday 14 February 2007 01:39, Richard Knutsson wrote: Convert pci_module_init() to pci_register_driver(). Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested with allyes, allmod allno on i386 applied, thanks - To unsubscribe from this list: send the line

[PATCH 1/8] alim15x3: PIO fallback fix

2007-02-13 Thread Bartlomiej Zolnierkiewicz
[PATCH] alim15x3: PIO fallback fix If DMA tuning fails always set the best PIO mode. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/alim15x3.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) Index: b/drivers/ide/pci/alim15x3.c

[PATCH 2/8] alim15x3: use ide_tune_dma()

2007-02-13 Thread Bartlomiej Zolnierkiewicz
is allowed and remove open coded ATAPI DMA check from ali15x3_config_drive_for_dma(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/alim15x3.c | 69 - 1 file

[PATCH 3/8] pdc202xx_new: use ide_tune_dma()

2007-02-13 Thread Bartlomiej Zolnierkiewicz
) * remove the check for drive-media != ide_disk from config_chipset_for_dma(), it is not needed because ide_max_dma_mode() returns 0 when -atapi_dma == 0 * use ide_tune_dma() in pdcnew_config_drive_xfer_rate() and remove no longer needed config_chipset_for_dma() Signed-off-by: Bartlomiej

<    7   8   9   10   11   12   13   14   >