Re: libata and PATA devices

2005-08-09 Thread Jeff Garzik
On Tue, Aug 09, 2005 at 07:05:33PM +0200, Erik Slagter wrote: On Tue, 2005-08-09 at 09:48 -0400, Mark Lord wrote: But there's also a fix for that, again floating around only in private repositories. Grmbl. Mark is just working off steam. The fix causes leaks, and does not really fix

[git patches] 2.6.x libata fixes

2005-08-10 Thread Jeff Garzik
in pdc20621_dma_prep(). This is incorrect as dma_map_sg() could have merged multiple sg's into one and, in such case, sg-length doesn't reflect true size of the entry. This patch makes it use sg_dma_len(sg). Signed-off-by: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Jeff

Re: [PATCH 1/2] sata: fix sata_sx4 dma_prep to not use sg-length

2005-08-10 Thread Jeff Garzik
Tejun Heo wrote: sata_sx4 directly references sg-length to calculate total_len in pdc20621_dma_prep(). This is incorrect as dma_map_sg() could have merged multiple sg's into one and, in such case, sg-length doesn't reflect true size of the entry. This patch makes it use sg_dma_len(sg).

Re: [PATCH 1/3] libata-dev: Convert pdc2027x from PIO to MMIO

2005-08-10 Thread Jeff Garzik
Brett Russ wrote: Albert Lee wrote: +cgcr = readl(port_mmio(ap, PDC_GLOBAL_CTL)); I've read that read[bwl]() and write[bwl]() are deprecated and discouraged in new code and instead ioread{8,16,32}() and iowrite{8,16,32}() should be used. Is this the case? ioread/write should only

Re: [PATCH 1/3] libata-dev: Convert pdc2027x from PIO to MMIO

2005-08-10 Thread Jeff Garzik
Albert Lee wrote: Jeff, Patch 1/3: Convert pdc2027x from PIO to MMIO Description: Indexed registers need two PIO accesses: one access writes to the index register and the other access reads/writes the indexed register. Using MMIO can access the register directly and simplify the code.

Re: [PATCH 2/3] libata-dev: pdc2027x mdelay() problem fix for power5 micro-partitioning

2005-08-10 Thread Jeff Garzik
Albert Lee wrote: Jeff, Patch 2/3: pdc2027x mdelay() problem fix for micro-partitioning Description: The mdelay(100) does not delay exactly 100 ms on IBM power5 machines when the power5 CPU micro-partitioning feature is turned on. Ex. If micro-partitioning is set to use 0.1 of the CPU time,

Re: [PATCH 3/3] libata-dev: Fix pdc2027x ATAPI DMA lost irq problem

2005-08-10 Thread Jeff Garzik
Albert Lee wrote: Jeff, Patch 3/3: Fix pdc2027x ATAPI DMA lost irq problem Description: Sometimes pdc2027x will lost irq after ATAPI DMA data transfer. With the previous rule (cmd-request_bufflen % 256), the ATAPI DMA irq lost problem still occurs during the test. Root cause for the

Re: [PATCH] Lay groundwork for ATA port multiplier support

2005-08-10 Thread Jeff Garzik
Edward Falk wrote: This patch adds a few constants related to port multipliers to libata.h, hdreg.h, and libata-core.c In addition to my previous comment (ata.h not hdreg.h), grep for ATA_DEV_ATA and ATA_DEV_ATAPI in the code. There are a few cases where you see code like if (class

Re: libata and PATA devices

2005-08-10 Thread Jeff Garzik
Mark Lord wrote: Erik Slagter wrote: Is there a possibility that dell attaches PATA harddisks using a SATA/PATA converter to the SATA connection of the ICH6M? That chipset is used in virtually all modern laptops, and includes a PATA interface as well as SATA. Most current laptops ship

Re: libata and PATA devices

2005-08-11 Thread Jeff Garzik
Mark Lord wrote: Jeff Garzik wrote: currently no one should be using libata for PATA support. We emailed back and forth extensively about how this has not been true since early this year. Modern laptops are using libata for the ICH6M support, simply because libata claims that chipset

Re: [PATCH 1/3] libata-dev: Convert pdc2027x from PIO to MMIO

2005-08-11 Thread Jeff Garzik
I'm getting confused with all the patches from you :/ It's my fault, but, would you be kind enough to resend the latest versions of -all- libata and pdc2027x patches? Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL

Re: [PATCH 2.6.12.3] PCI/libata INTx cleanup

2005-08-11 Thread Jeff Garzik
Brett Russ wrote: Simple cleanup to eliminate X copies of the same function in libata. Moved pci_enable_intx() to pci.c, added pci_disable_intx() as well, and use them throughout libata and msi.c. Signed-off-by: Brett Russ [EMAIL PROTECTED] Though there is nothing wrong with this patch, I

Re: [PATCH libata-dev-2.6:sil24 02/07] sil24: move error handling out of hot interrupt path

2005-08-11 Thread Jeff Garzik
Tejun Heo wrote: 02_sil24_separate-out-error-path.patch Move error handling from sil24_host_intr into separate function - sil24_error_intr. Jeff, I don't think this patch actually improves readability and/or performance. Is this what you wanted? Yes. It

Re: [PATCH libata-dev-2.6:sil24 03/07] sil24: add testing for PCI fault

2005-08-11 Thread Jeff Garzik
Tejun Heo wrote: 03_sil24_add-test-for-PCI-fault.patch On entry to interrupt handler, PORT_SLOT_STAT register is read first. Check if PCI fault or device removal has occurred by testing the value for 0x. Signed-off-by: Tejun Heo [EMAIL PROTECTED] ACK - To

Re: [PATCH libata-dev-2.6:sil24 04/07] sil24: remove irq disable code on spurious interrupt

2005-08-11 Thread Jeff Garzik
Tejun Heo wrote: 04_sil24_remove-irq-disable-on-spurious-interrupt.patch If interrupt occurs on a disabled port, the driver used to mask the port's interrupt, but we don't know if such action is necessary yet and that's not what other drives do. So, just do

Re: [PATCH libata-dev-2.6:sil24 05/07] sil24: use longer delay function and less iteration in reset_controller

2005-08-11 Thread Jeff Garzik
Tejun Heo wrote: 05_sil24_mdelay-instead-of-udelay.patch loop 100 times with mdelay(1) instead of 1000 times with udelay(100) in sil24_reset_controller. Jeff, is this what you wanted? If not, just ignore this patch. The following patches will apply without

Re: [PATCH libata-dev-2.6:sil24 07/07] sil24: add FIXME comment above ata_device_add

2005-08-11 Thread Jeff Garzik
Tejun Heo wrote: 07_sil24_add-FIXME-ata_device_add-return_value.patch Add FIXME comment above ata_device_add. Signed-off-by: Tejun Heo [EMAIL PROTECTED] ACK - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH libata-dev-2.6:sil24 00/07] sil24: misc fixes

2005-08-11 Thread Jeff Garzik
Tejun Heo wrote: Hello, Jeff Carlos. These patches are misc fixes suggested by Jeff for rewritten sil24 driver. The follwing issues are not fixed in this patchset. I need more info to work on these. * Device signature access on reset. * How to discern completion interrupts from error

Re: ATA Passthru unimplemented protocols

2005-08-11 Thread Jeff Garzik
Timothy Thelin wrote: Well it doesn't seem that nasty to adopt flagged access. From a userland API point of view how about adopting the IDE driver's taskfile mechanism, and simply translating that into the yet-to-be internal flagged mechanism? There is actually already an internal flagged

Re: libata total system lockup fix

2005-08-11 Thread Jeff Garzik
Tejun Heo wrote: And this is the combined patch against ncq head of libata-dev-2.6 tree. Commit d032ec9048ff82a704b96b93cfd6f2e8e3a06b19. Only ata_piix, sata_sil and ahci are converted and all other SATA drivers are broken. So, enable only those three SATA drivers when compiling with this

Re: libata and PATA devices

2005-08-11 Thread Jeff Garzik
Erik Slagter wrote: On Thu, 2005-08-11 at 13:19 -0400, Jeff Garzik wrote: Mark Lord wrote: Jeff Garzik wrote: currently no one should be using libata for PATA support. We emailed back and forth extensively about how this has not been true since early this year. Modern laptops are using

Re: libata and PATA devices

2005-08-11 Thread Jeff Garzik
Jeff Garzik wrote: The system is thus: 1) drivers/pci/quirks.c reserves SATA ports (only!) for libata 2) Legacy IDE driver claims the unreserved PATA port 3) libata loads and uses the ports reserved in #1 This requires a specific kernel configuration: (a) CONFIG_IDE_GENERIC be set, and (b) IDE

Re: [PATCH] IDE: don't offer IDE_GENERIC on ia64

2005-08-11 Thread Jeff Garzik
Bjorn Helgaas wrote: IA64 boxes only have PCI IDE devices, so there's no need to blindly poke around in I/O port space. Poking at things that don't exist causes MCAs on HP ia64 systems. Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work-vga/drivers/ide/Kconfig

libata PATA todo list

2005-08-11 Thread Jeff Garzik
Since there's been some recent interest in the subject, I thought I would post the PATA todo list for libata. Some of these items are from my memory, and some are from a list Alan was kind enough to create. The items verbatim from Alan are prefixed Alan: . 1) Locked device/host speed To

Re: [PATCH] IDE: don't offer IDE_GENERIC on ia64

2005-08-11 Thread Jeff Garzik
Bjorn Helgaas wrote: On Thursday 11 August 2005 2:36 pm, Jeff Garzik wrote: Bjorn Helgaas wrote: IA64 boxes only have PCI IDE devices, so there's no need to blindly poke around in I/O port space. Poking at things that don't exist causes MCAs on HP ia64 systems. Signed-off-by: Bjorn Helgaas

Re: [PATCH] IDE: don't offer IDE_GENERIC on ia64

2005-08-11 Thread Jeff Garzik
On Thu, Aug 11, 2005 at 03:42:07PM -0600, Bjorn Helgaas wrote: Tony, others, does this change give you any heartburn? On the 460GX and 870 boxes I have, IDE is a PCI device. (I have been told that the SGI ia64 simulator depends on IDE_GENERIC. But it really should make the IDE device

Re: [PATCH] IDE: don't offer IDE_GENERIC on ia64

2005-08-11 Thread Jeff Garzik
Jeff Garzik wrote: 00:1f.1 IDE interface: Intel Corporation 82801EB/ER (ICH5/ICH5R) IDE Controller (rev 02) (prog-if 8a [Master SecP PriP]) Subsystem: Hewlett-Packard Company d530 CMT (DG746A) Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step ping- SERR

Re: [PATCH] IDE: don't offer IDE_GENERIC on ia64

2005-08-11 Thread Jeff Garzik
Luck, Tony wrote: Tony, others, does this change give you any heartburn? On the 460GX and 870 boxes I have, IDE is a PCI device. No heartburn for me ... as you say IDE is built into one of the 870 chips. I don't know whether any non-Intel chipsets provide legacy IDE. The question is not

Re: [PATCH] IDE: don't offer IDE_GENERIC on ia64

2005-08-11 Thread Jeff Garzik
Bjorn Helgaas wrote: You deduce this by the absence of SecO and PriO? I wonder if lspci should be enhanced to notice this, too. I assume that the IRQ 169 doesn't correspond to anything in /proc/interrupts. Correct. So the scenario in question (correct me if I'm wrong) is that we have a

Re: [PATCH 0/3] libata-dev: pdc2027x fixes

2005-08-12 Thread Jeff Garzik
Albert Lee wrote: Jeff, pdc2027x driver fix: 1/3 pdc1.diff: - Convert pdc2027x from PIO to MMIO. 2/3 pdc2.diff: - use long for the counter data type instead of unsigned long 3/3 pdc3.diff: - pdc2027x ATAPI DMA irq lost problem workaround Applied all three patches to pdc2027x

Re: [PATCH 2.6.12.3] PCI/libata INTx cleanup

2005-08-12 Thread Jeff Garzik
Brett Russ wrote: Jeff Garzik wrote: Though there is nothing wrong with this patch, I would prefer a single function, pci_intx(), as found in drivers/scsi/ahci.c. Sounds like what I did, except for the naming change. I did away with pci_disable_intx() and changed the names. Look ok

Re: [PATCH 2.6.12.3] PCI/libata INTx cleanup

2005-08-12 Thread Jeff Garzik
Greg KH wrote: On Fri, Aug 12, 2005 at 01:10:43PM -0400, Brett Russ wrote: Jeff Garzik wrote: Brett Russ wrote: Simple cleanup to eliminate X copies of the same function in libata. Moved pci_enable_intx() to pci.c, added pci_disable_intx() as well, and use them throughout libata

Re: SATA status report updated

2005-08-12 Thread Jeff Garzik
Mogens Valentin wrote: Jeff Garzik wrote: Things in SATA-land have been moving along recently, so I updated the software status report: http://linux.yyz.us/sata/software-status.html Queueing support, NCQ: #3 will be supported by libata, for all hardware and devices

Re: [PATCH 2.6.13-rc6] PCI/libata INTx cleanup

2005-08-12 Thread Jeff Garzik
Brett Russ wrote: Simple cleanup to eliminate X copies of the pci_enable_intx() function in libata. Moved ahci.c's pci_intx() to pci.c and use it throughout libata and msi.c. Signed-off-by: Brett Russ [EMAIL PROTECTED] Looks good to me. Greg, do you want to queue this (since it touches

Re: libata and PATA devices

2005-08-13 Thread Jeff Garzik
Erik Slagter wrote: result: the pata harddisk is recognised by libata_piix and assigned /dev/sda, the dvd drive is found by the generic ide driver. (dmesg output attached) Great! That's precisely what's supposed to happen. Except, the hard drive appears to be SATA, not PATA: ata1: SATA

Re: libata and PATA devices

2005-08-13 Thread Jeff Garzik
Erik Slagter wrote: On Sat, 2005-08-13 at 11:33 -0400, Jeff Garzik wrote: Erik Slagter wrote: result: the pata harddisk is recognised by libata_piix and assigned /dev/sda, the dvd drive is found by the generic ide driver. (dmesg output attached) Great! That's precisely what's supposed

Re: libata and PATA devices

2005-08-13 Thread Jeff Garzik
Tyler wrote: Jeff, I think he stated in an earlier post to the list, the model number of the drive, and it is in fact a PATA drive... verified by checking fujitsu's website. Or are you just saying that it shows up as sata by coming up as /dev/sda since its connected to a PATA port on a sata

Re: [PATCH 2.6.13-rc6] PCI/libata INTx cleanup

2005-08-15 Thread Jeff Garzik
Greg KH wrote: On Fri, Aug 12, 2005 at 06:43:03PM -0400, Brett Russ wrote: Simple cleanup to eliminate X copies of the pci_enable_intx() function in libata. Moved ahci.c's pci_intx() to pci.c and use it throughout libata and msi.c. Signed-off-by: Brett Russ [EMAIL PROTECTED] It would have

Re: [PATCH libata-dev-2.6:sil24 01/08] sil24: add FIXME comment above ata_device_add

2005-08-16 Thread Jeff Garzik
applied patches 1-8 to 'sil24' branch of libata-dev.git - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Which controllers can support port multipliers?

2005-08-17 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: I realize the software support isn't there now, but I'm having trouble getting a lot of SATA drives into a cheap AMD64 computer. All controllers support port multipliers, but libata does not support them yet. Jeff - To unsubscribe from this list: send the

[git] libata-dev queue updated

2005-08-18 Thread Jeff Garzik
IDs Douglas Gilbert: [libata scsi] add START STOP UNIT translation Erik Benada: [libata sata_promise] support PATA ports on SATA controllers Jason Gaston: ahci: AHCI mode SATA patch for Intel ICH7-M DH Jeff Garzik: [libata] add new driver ata_adma [libata adma] enable PCI MWI during

Re: [git] libata-dev queue updated

2005-08-19 Thread Jeff Garzik
Brett Russ wrote: Jeff Garzik wrote: In such cases, patches are divided into branches by category: ncq (NCQ queueing support), chs-support (C/H/S support), adma (new ADMA driver), sil24 (new Silicon Image 312x driver), passthru (ATA passthrough/SMART support), etc. Jeff, The below doesn't

Re: [SUMMARY] libata EH

2005-08-20 Thread Jeff Garzik
Tejun Heo wrote: Jeff Garzik wrote: Simple stuff like command aborted (invalid command) can be handled immediately, no need to kick in the error handling. But as long as the right hardware interrupts are acknowledged, I don't mind if all error handling is moved to the thread. My

Re: [PATCH libata-dev-2.6:upstream 00/02] atapi: packet task vs. intr race fix

2005-08-21 Thread Jeff Garzik
Tejun Heo wrote: Have you received patches in the reverse order? #1 changes ata_irq_on() and #2 adds ata_qc_set_polling(). Hmmm, only a call to ata_chk_status() is added to ata_irq_on(), which I think is needed regardless of other changes, and ata_wait_idle() is removed. Does that make

Re: [PATCH libata-dev-2.6:upstream 02/02] libata: add host_set locking to ata_scsi_error()

2005-08-21 Thread Jeff Garzik
Tejun Heo wrote: 02_libata_add-locking-to-ata_scsi_error.patch SCSI EH can start before ata_qc_complete is completely complete. so, latter part of ata_qc_complete can run side-by-side with -eng_timeout(), interfering EH. This patch makes ata_scsi_error() to

Re: [PATCH linux-2.6.13-rc3] Mod15Write quirk against v2.6.13

2005-08-21 Thread Jeff Garzik
Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Also, Jeff, I know you're very busy, but what do you think about taking m15w workaround into ata tree? It's been around for a while now and I haven't received any complaints (except for this one) yet. The workaround is ugly but it surely

a word about ATA interrupts, and SATA (was Re: [PATCH libata-dev-2.6:upstream 00/02] libata: race fixes)

2005-08-21 Thread Jeff Garzik
BTW, here is food for thought: In first generation SATA controllers, the host controller silicon emulates a set of PATA taskfile registers. When you follow the ATA command protocols (host state machines), handling ATA commands in the specified manner, the host controller silicon is

Re: [PATCH libata-dev-2.6:upstream 00/02] atapi: packet task vs. intr race fix

2005-08-21 Thread Jeff Garzik
Tejun Heo wrote: Hello, Jeff. Jeff Garzik wrote: Tejun Heo wrote: Hello, Jeff and Albert. This patchset fixes the following race. (port A has ATA device and B ATAPI). port B: ata_issue_prot() (ATAPI_NODATA) port B: packet_task scheduled port A: ata_issue_prot() (DMA) intr

Re: [PATCH linux-2.6.13-rc3] Mod15Write quirk against v2.6.13

2005-08-21 Thread Jeff Garzik
Tejun Heo wrote: Hi, Jeff. Jeff Garzik wrote: Tejun Heo wrote: sata_sil Mod15Write workaround was broken by the following commit by Albert Lee. Commit: 21b1ed74ee3667dcabcba92e486988ea9119a085 [PATCH] libata: Prevent the interrupt handler from completing a command twice This commit

Re: [PATCH libata-dev-2.6:upstream 00/02] atapi: packet task vs. intr race fix

2005-08-21 Thread Jeff Garzik
Tejun Heo wrote: Hello, Jeff and Albert. This patchset fixes the following race. (port A has ATA device and B ATAPI). port B : ata_issue_prot() (ATAPI_NODATA) port B : packet_task scheduled port A : ata_issue_prot() (DMA) intr: ata_interrupt() port A : ata_host_intr - this is all

Re: [PATCH libata-dev-2.6:upstream 00/02] atapi: packet task vs. intr race fix

2005-08-21 Thread Jeff Garzik
Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Hello, Jeff. Jeff Garzik wrote: Tejun Heo wrote: Hello, Jeff and Albert. This patchset fixes the following race. (port A has ATA device and B ATAPI). port B: ata_issue_prot() (ATAPI_NODATA) port B: packet_task scheduled

Re: [PATCH linux-2.6.13-rc3] Mod15Write quirk against v2.6.13

2005-08-21 Thread Jeff Garzik
Tejun Heo wrote: sata_sil Mod15Write workaround was broken by the following commit by Albert Lee. Commit: 21b1ed74ee3667dcabcba92e486988ea9119a085 [PATCH] libata: Prevent the interrupt handler from completing a command twice This commit clears ATA_QCFLAG_ACTIVE in ata_qc_complete() and

Re: A note on libata passthru patch

2005-08-21 Thread Jeff Garzik
Mark Lord wrote: I'm certain there are lots of vendor-specific commands that might assume exclusive bus access, if not exclusive host access. All of this makes a reasonable case for having libata stop other host activity before/while performing any passthru command. We also have internal

Re: [PATCH libata-dev-2.6:upstream 00/02] atapi: packet task vs. intr race fix

2005-08-21 Thread Jeff Garzik
Tejun Heo wrote: Now I see what you're saying. We should be able to know/clear interrupt by reading ATA_STATUS. So, not having explicit interrupt pending bit can be compensated by following changes in ATA_STATUS (so the state machine), right? Thanks a lot for putting up with my ignorance.

Re: [PATCH libata:upstream] sil: apply M15W quirk selectively

2005-08-22 Thread Jeff Garzik
Tejun Heo wrote: Hello, Jeff Bartlomiej all. What about fixing 3114 for a start? :-) Yeap, why not? Here it is. -- This patch adds chipset mask to sil_blacklist such that quirks can be applied selectively depending on chipset. And add sil_3112_m15w chipset which is identical to

libata TODO: ioread/iowrite work (was Re: [PATCH libata:upstream] remove compiler warnings)

2005-08-22 Thread Jeff Garzik
Tejun Heo wrote: Hello, Jeff. This patch removes compiler warnings which are caused by using ioports values (unsigned long) for the address argument of read/write[bwl]() functions without casting. Signed-off-by: Tejun Heo [EMAIL PROTECTED] NAK... These warnings exist as a reminder of the

Re: [PATCH libata:upstream] sil: apply M15W quirk selectively

2005-08-22 Thread Jeff Garzik
Tejun Heo wrote: On Mon, Aug 22, 2005 at 03:36:57PM -0400, Jeff Garzik wrote: Tejun Heo wrote: 5) add SIL_FLAG_M15W to the list of host_flags in the new sil_3112_m15w entry created in step #4. Can we use host_flags for that? It seems that it's for ATA_FLAG_* flags, and we currently

Re: [PATCH libata:upstream] fix atapi_packet_task vs. intr race

2005-08-22 Thread Jeff Garzik
Tejun Heo wrote: Interrupts from devices sharing the same IRQ could cause ata_host_intr to finish commands being processed by atapi_packet_task if the commands are using ATA_PROT_ATAPI_NODATA or ATA_PROT_ATAPI_DMA protocol. This is because libata interrupt handler is unaware that interrupts

Re: [PATCH libata:upstream] fix atapi_packet_task vs. intr race (take 2)

2005-08-22 Thread Jeff Garzik
Tejun Heo wrote: Hello, Jeff. Here's the updated patch. Though I have a question. Why always use Looks OK to me. Have you tested it? :) spin_lock_irqsave()? To improve maintainability? Code is less fragile, since it works regardless of whether the code path even gets moved to a

Re: [PATCH libata-dev-2.6:upstream 00/02] atapi: packet task vs. intr race fix

2005-08-22 Thread Jeff Garzik
Tejun Heo wrote: Jeff Garzik wrote: (b) [a 'todo' item'] at that point in the HSM, there may actually be an expected interrupt, before which the CDB should not be sent, per ATA/ATAPI-4 This is deprecated since ATA/ATAPI-4. Will we see this on SATA ATAPI devices? Maybe for PATA ATAPI's

Re: [PATCH libata-dev-2.6:upstream 00/02] atapi: packet task vs. intr race fix

2005-08-22 Thread Jeff Garzik
Tejun Heo wrote: For example, ATA_PROT_NODATA is processed as follows. You mean ATA_PROT_ATAPI_NODATA, I presume. Driver Controller - 1. issue ATA_CMD_PACKET 2.

Re: [patch] libata passthrough - return register data from HDIO_* commands

2005-08-22 Thread Jeff Garzik
Jon Escombe wrote: Here is a first attempt at a patch to return register data from the libata passthrough HDIO ioctl handlers, I needed this as the ATA 'unload immediate' command returns the success in the lbal register. This patch applies on top of 2.6.12 and Jeffs

Re: [PATCH] Fix HD activity LED with ahci

2005-08-22 Thread Jeff Garzik
Martin Wilck wrote: All right, this looks like a pretty broad agreement on this issue. Jeff, would you please apply this patch? Regards, Martin Patch: fix wrong HD activity control by ahci driver Signed-off-by: [EMAIL

Re: [git] libata-dev queue updated

2005-08-22 Thread Jeff Garzik
Daniel Drake wrote: Hi Jeff, Jeff Garzik wrote: I finally got around to creating something that has been missing since BitKeeper disappeared, and something that Andrew has been wanting from me for a while: an amalgamation of all the libata-dev branches that I maintain internally. You

Re: [PATCH] libata: Clear ATA_QCFLAG_ACTIVE flag before calling the completion callback

2005-08-22 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sata_promise: Add PDC40718 id

2005-08-22 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sata_promise: Add PDC40519 id

2005-08-22 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH libata-dev-2.6:upstream 01/02] libata: implement ata_poll_qc_complete and use it in polling functions

2005-08-22 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH libata:upstream] sil: apply M15W quirk selectively (take 2)

2005-08-22 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fix HD activity LED with ahci

2005-08-22 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

libata-dev queue updated

2005-08-24 Thread Jeff Garzik
controllers Jason Gaston: ahci: AHCI mode SATA patch for Intel ICH7-M DH Jeff Garzik: [libata] add new driver ata_adma [libata adma] enable PCI MWI during controller initialization [libata] ATA passthru (arbitrary ATA command execution) [libata] ata_adma: update for recent -host_stop() API

Re: Another libata TODO item

2005-08-24 Thread Jeff Garzik
Christoph Hellwig wrote: On Wed, Aug 24, 2005 at 02:17:11AM -0400, Jeff Garzik wrote: To make libata debugging easier and more fine-grained, we should convert DPRINTK/VPRINTK calls in libata to code that looks like if (ata_msg_xxx(ap-msg_enable)) printk(...) Would

Re: Another libata TODO item

2005-08-24 Thread Jeff Garzik
Roland Dreier wrote: Jeff In any case, I also contine to be skeptical of in-kernel Jeff logging subsystems. Aren't you proposing a libata logging subsystem? Look at net drivers. Theres no real infrastructure beyond bit tests and printks. I wouldn't call that a subsystem, so, I

Re: Another libata TODO item

2005-08-24 Thread Jeff Garzik
Roland Dreier wrote: Jeff Look at net drivers. Theres no real infrastructure beyond Jeff bit tests and printks. I wouldn't call that a subsystem, Jeff so, I wouldn't call this one such either. Well, scsi_logging.h isn't much of a subsystem either. You obviously did not grep for

Re: #undef ATA_ENABLE_PATA

2005-08-25 Thread Jeff Garzik
Horms wrote: Hi Jeff, Hi All, In the cause of debuging a problem with a DVD burner[1] Brett Smith brought to my attention that there are several variables in ./include/linux/libata.h, that when changed from #undef to #define, enable features in the ATA subsystem. Is there any interest in a

Re: #undef ATA_ENABLE_PATA

2005-08-26 Thread Jeff Garzik
Erik Slagter wrote: On Fri, 2005-08-26 at 13:36 +0900, Horms wrote: #undef ATA_ENABLE_ATAPI /* define to enable ATAPI support */ #undef ATA_ENABLE_PATA /* define to enable PATA support in some These two would very interesting to me to be included in Kconfig. Neither of

[PATCH] siimage docs urls

2005-08-26 Thread Jeff Garzik
Signed-off-by: Jeff Garzik [EMAIL PROTECTED] diff --git a/drivers/ide/pci/siimage.c b/drivers/ide/pci/siimage.c --- a/drivers/ide/pci/siimage.c +++ b/drivers/ide/pci/siimage.c @@ -6,7 +6,13 @@ * * May be copied or modified under the terms of the GNU General Public License

Re: [PATCH] libata: error processing + rw 6 byte fix

2005-08-26 Thread Jeff Garzik
Does the attached look OK to everybody? Jeff diff --git a/drivers/scsi/libata-scsi.c b/drivers/scsi/libata-scsi.c --- a/drivers/scsi/libata-scsi.c +++ b/drivers/scsi/libata-scsi.c @@ -581,6 +581,12 @@ static unsigned int ata_scsi_rw_xlat(str if (scsicmd[0] == READ_6 ||

libata: clustering on or off?

2005-08-28 Thread Jeff Garzik
The constant ATA_SHT_USE_CLUSTERING in include/linux/libata.h controls the use of SCSI layer's use_clustering feature, for a great many libata drivers. The current setup has clustering disabled, which in theory causes the block layer to do less work, at the expense of a greater number of

Re: Promise SATAII150 TX4: strange disk ordering

2005-08-29 Thread Jeff Garzik
Eyal Lebedinsky wrote: I needed a 4-port SATA controller and this was was picked. It seems to work OK, however I find that Linux (2.6.12.5 and .13-rc7) see the disks in a different order than the labelled sockets (which do match what the BIOS detection lists at bootup). It is not even the

[git patches] 2.6.x libata updates

2005-08-28 Thread Jeff Garzik
] add START STOP UNIT translation Jason Gaston: ahci: AHCI mode SATA patch for Intel ICH7-M DH Jeff Garzik: libata: trim trailing whitespace. libata: fix EH locking [libata sata_sil] list documentation URL, since its public libata: fix a few alan-isms [libata scsi] fix read/write

Re: [RFC][PATCH 2.6.13] Marvell SATA support (PIO mode)

2005-08-30 Thread Jeff Garzik
Brett Russ wrote: This is the first public release of my libata compatible low level driver for the Marvell SATA family. Currently it successfully runs in PIO mode on a 6081 chip. EDMA support is in the works and should be done shortly. Review, testing (especially on other flavors of

[PATCH] libata: add ATAPI module option

2005-08-30 Thread Jeff Garzik
of ATAPI devices (0=off, 1=on)); + MODULE_AUTHOR(Jeff Garzik); MODULE_DESCRIPTION(Library module for ATA devices); MODULE_LICENSE(GPL); diff --git a/drivers/scsi/libata-scsi.c b/drivers/scsi/libata-scsi.c --- a/drivers/scsi/libata-scsi.c +++ b/drivers/scsi/libata-scsi.c @@ -1470,10 +1470,10

Re: [RFC] libata new EH document

2005-08-31 Thread Jeff Garzik
Tejun Heo wrote: IMHO, it's a good idea to maintain one qc to one ATA/ATAPI command mapping as long as possible. And, in the suggested framework, it's guaranteed that no other command can come inbetween CHECK_SENSE and REQUEST_SENSE. Requesting sense from EH, calling

Re: [RFC] libata new EH document

2005-08-31 Thread Jeff Garzik
BTW I still have three of your documents to review and comment on. Haven't forgotten about them. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode)

2005-09-01 Thread Jeff Garzik
Jeff Garzik wrote: As I said, the include does away simultaneously for all libata drivers. s/does/goes/ - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode)

2005-09-01 Thread Jeff Garzik
Christoph Hellwig wrote: On Thu, Sep 01, 2005 at 03:48:51PM -0400, Jeff Garzik wrote: Christoph Hellwig wrote: +#include linux/kernel.h +#include linux/module.h +#include linux/pci.h +#include linux/init.h +#include linux/blkdev.h +#include linux/delay.h +#include linux/interrupt.h +#include

Re: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode)

2005-09-01 Thread Jeff Garzik
Christoph Hellwig wrote: Stop that crap now please. Adding scsi.h includes is _not_ allowed for new drivers, period. There's no exceptions, not even for Jeff I'm part of the calal Garzik. There are solid technical reasons (a) why libata drivers include scsi.h, and (b) why all libata drivers

Re: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode)

2005-09-01 Thread Jeff Garzik
Christoph Hellwig wrote: +#include linux/kernel.h +#include linux/module.h +#include linux/pci.h +#include linux/init.h +#include linux/blkdev.h +#include linux/delay.h +#include linux/interrupt.h +#include linux/sched.h +#include linux/dma-mapping.h +#include scsi.h pleaese don't include

Re: [RFC] libata new EH document

2005-09-01 Thread Jeff Garzik
Luben Tuikov wrote: On 09/01/05 09:24, James Bottomley wrote: On Thu, 2005-09-01 at 01:54 -0400, Jeff Garzik wrote: The long term direction for the SCSI core seems to be that of requiring auto-sensing. No, I don't see the mid-layer error thread handling of this ever going away. libata

Re: [RFC] libata new EH document

2005-09-01 Thread Jeff Garzik
Luben Tuikov wrote: On 09/01/05 17:46, Jeff Garzik wrote: libata is simply being lazy: while the SCSI core continues to support kicking the EH thread when sense is missing, it's preferred for libata to reuse that infrastructure. That makes the most sense ;-) For libata it doesn't really

Re: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode)

2005-09-03 Thread Jeff Garzik
Tyler wrote: Brett Russ wrote: Some (non-functional) cleanup modifications since the version 0.10 driver I sent out 2005-08-30. Also adding signed-off-by for Jeff's upstream push. This is my libata compatible low level driver for the Marvell SATA family. Currently it successfully runs in

Re: libata total system lockup fix

2005-09-03 Thread Jeff Garzik
Mark Lord wrote: -- libata atapi DMA patch (needed for modern laptop) Which patch is this? DMA alignment? Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 2.6.13] libata: use common pci remove in ahci

2005-09-06 Thread Jeff Garzik
Brett Russ wrote: Jeff Garzik wrote: Brett Russ wrote: 2) Isn't it wrong for the IRQ disable at the chip to occur *after* free_irq() is called to disconnect the handler (independent of question 1...since this is the case currently)? Granted, all of the ports have gone through scsi_remove_host

Re: PROBLEM: Silicon Image 3112 Lockups

2005-09-06 Thread Jeff Garzik
Tejun Heo wrote: In the following mail, I've attached a patch which might alleviate errors during writes (as Alexander was reporting CRC errors with write commands), but it won't do any good if you're getting errors during reading.

Re: PROBLEM: Silicon Image 3112 Lockups

2005-09-07 Thread Jeff Garzik
Tejun Heo wrote: I don't know. If some specific configurations are required for the controller, they are usually done by BIOS (either mainboard BIOS or per-controller BIOS), so BIOS update could affect the problem. But these are still just wild speculations. Maybe we should contact ASUS

Re: [PATCH 2.6.13] libata: fix pio_mask values (take 2)

2005-09-06 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[git patches] libata updates

2005-09-07 Thread Jeff Garzik
| 843 drivers/scsi/sata_uli.c |4 5 files changed, 856 insertions(+), 3 deletions(-) commit ca20aa6954bcb4537064a1bf5e8f74af57da2a03 Author: Jeff Garzik [EMAIL PROTECTED] Date: Wed Sep 7 02:05:59 2005 -0400 [libata sata_mv] fix build

Re: [RFC] ATA/ATAPI exceptions doc

2005-09-07 Thread Jeff Garzik
be improved. Where 'current' represents ALL head of libata-dev-2.6 git tree as of 2005-08-26, commit ab9b494f6aeab24eda2e6462e2fe73789c288e73. References are made to SCSI EH document. Please read SCSI EH document first. A lot of EH ideas are from Jeff Garzik and others in the following and other

Re: [RFC] current libata eh doc

2005-09-07 Thread Jeff Garzik
Tejun Heo wrote: Hello, libata developers. This document describes current libata EH. (I have decided to keep ATA exceptions doc, this and yet-to-be-posted new EH doc separate.) I hope this can help EH discussion. It would be nice to add this to Documentation/DocBook/libata.tmpl, and

<    1   2   3   4   5   6   7   8   9   10   >