Re: 2.6.26-git0: IDE oops during boot

2008-02-10 Thread Kamalesh Babulal
Nish Aravamudan wrote: > On 2/7/08, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: >> On Thursday 07 February 2008, Kamalesh Babulal wrote: >>> Bartlomiej Zolnierkiewicz wrote: Hi, On Wednesday 06 February 2008, Pavel Machek wrote: > On Wed 2008-02-06 11:53:34, Pavel

Re: raw_pci_read in quirk_intel_irqbalance

2008-02-10 Thread Grant Grundler
On Sun, Feb 10, 2008 at 10:04:16PM -0700, Matthew Wilcox wrote: > > "A disabled or non-existent device's configuration register space is > > hidden. A disabled or non-existent device will return all ones for reads > > and will drop writes just as if the cycle terminated with a Master Abort > > on

Re: [PATCH] vmsplice exploit fix (was: splice: fix user pointer access in get_iovec_page_array)

2008-02-10 Thread Pekka Enberg
Hi Daniel, On Feb 11, 2008 9:29 AM, Daniel Phillips <[EMAIL PROTECTED]> wrote: > I think many users would first go to kernel.org on a day like today, as > I did. Nothing to see there. We could do a way better job of getting > the word out. Any suggestions what I could have done better here? As

Re: [stable] [PATCH] vmsplice exploit fix (was: splice: fix user pointer access in get_iovec_page_array)

2008-02-10 Thread Greg KH
On Sun, Feb 10, 2008 at 11:29:50PM -0800, Daniel Phillips wrote: > Kudos to all involved in the rapid response. But. > > Information on patching this vulnerability is not available front and > center in many of the places you would expect: kernel.org front page, > debian.org front page,

Re: Linux 2.6.22.18

2008-02-10 Thread Greg Kroah-Hartman
diff --git a/Makefile b/Makefile index 6a949eb..99c5e87 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 22 -EXTRAVERSION = .17 +EXTRAVERSION = .18 NAME = Holy Dancing Manatees, Batman! # *DOCUMENTATION* diff --git a/fs/splice.c b/fs/splice.c index

Linux 2.6.22.18

2008-02-10 Thread Greg Kroah-Hartman
We (the -stable team) are announcing the release of the 2.6.22.18 kernel. It fixes one thing, CVE-2008-0600. All users of the 2.6.22 series, with untrusted local users are strongly encouraged to upgrade. I'll also be replying to this message with a copy of the patch between 2.6.22.17 and

Re: [RFC PATCH] vfs: optimization to /proc//mountinfo patch

2008-02-10 Thread Ram Pai
On Mon, 2008-02-04 at 01:28 -0800, Andrew Morton wrote: > On Mon, 04 Feb 2008 01:15:05 -0800 Ram Pai <[EMAIL PROTECTED]> wrote: > > > 1) reports deleted inode in dentry_path() consistent with that in __d_path() > > 2) modified __d_path() to use prepend(), reducing the size of __d_path() > > 3)

[PATCH] vmsplice exploit fix (was: splice: fix user pointer access in get_iovec_page_array)

2008-02-10 Thread Daniel Phillips
Kudos to all involved in the rapid response. But. Information on patching this vulnerability is not available front and center in many of the places you would expect: kernel.org front page, debian.org front page, covered on planet.debian.org but without a pointer to the patch, and so on. So

[SCSI] ses: fix memory leaks

2008-02-10 Thread Yinghai Lu
please check it... --- From: Yinghai Lu <[EMAIL PROTECTED]> [SCSI] ses: fix memory leaks fix leaking with scomp leaking when failing. Also free page10 on driver removal  and remove one extra space. Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> Signed-off-by: James Bottomley <[EMAIL

Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'

2008-02-10 Thread Ray Lee
On Feb 10, 2008 5:47 PM, Mr. James W. Laferriere <[EMAIL PROTECTED]> wrote: > Hello All , grabbed using git just moments ago . > > make V=1 KBUILD_VERBOSE=1 INSTALL_PATH=/boot clean all install modules_install > > ...snip... > make -f scripts/Makefile.clean obj=sound/usb/usx2y > make -f

Re: Netfilter fixes to 2.6.24-git

2008-02-10 Thread Patrick McHardy
David Miller wrote: From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Sun, 10 Feb 2008 22:02:35 +0100 (CET) I have been unable to reach the netfilter and net maintainers the past week regarding inclusion of patches, but most importantly a group of fixes at [0]-[3]. I am kind of at a loss here

kvm: no hardware support

2008-02-10 Thread Yinghai Lu
I enable vmx and svm option for KVM in .config on amd SVM enable system vmx get tried at first and get kvm: no hardware support Calling initcall 0x80c2d465: vmx_init+0x0/0x119() kvm: no hardware support initcall 0x80c2d465: vmx_init+0x0/0x119() returned -95. initcall

Re: Linux 2.6.23.16

2008-02-10 Thread Greg Kroah-Hartman
diff --git a/Makefile b/Makefile index 8920cb8..3a932c7 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 23 -EXTRAVERSION = .15 +EXTRAVERSION = .16 NAME = Arr Matey! A Hairy Bilge Rat! # *DOCUMENTATION* diff --git a/fs/splice.c b/fs/splice.c index

Linux 2.6.23.16

2008-02-10 Thread Greg Kroah-Hartman
We (the -stable team) are announcing the release of the 2.6.23.16 kernel. It fixes one thing, CVE-2008-0600. All users of the 2.6.23 series, with untrusted local users are strongly encouraged to upgrade. I'll also be replying to this message with a copy of the patch between 2.6.23.15 and

Re: Linux 2.6.24.2

2008-02-10 Thread Greg Kroah-Hartman
diff --git a/Makefile b/Makefile index e6a6eec..6f79564 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 24 -EXTRAVERSION = .1 +EXTRAVERSION = .2 NAME = Err Metey! A Heury Beelge-a Ret! # *DOCUMENTATION* diff --git a/fs/splice.c b/fs/splice.c index

Linux 2.6.24.2

2008-02-10 Thread Greg Kroah-Hartman
We (the -stable team) are announcing the release of the 2.6.24.2 kernel. It fixes one thing, CVE-2008-0600. All users of the 2.6.24 series, with untrusted local users are strongly encouraged to upgrade. I'll also be replying to this message with a copy of the patch between 2.6.24.1 and 2.6.24.2

Re: [PATCH] splice: fix user pointer access in get_iovec_page_array()

2008-02-10 Thread Oliver Pinter
Linux pancs 2.6.22.17-opt2-cve2 #1 SMP Sun Feb 10 16:22:37 CET 2008 i686 GNU/Linux --- Linux vmsplice Local Root Exploit By qaaz --- [+] mmap: 0x0 .. 0x1000 [+] page: 0x0 [+] page: 0x20 [+] mmap: 0x4000 .. 0x5000 [+] page: 0x4000

2.6.25-rc1: Lguest build failure

2008-02-10 Thread Parag Warudkar
Hi Rusty Just got this build failure while building -rc1 - Root device is (254, 0) Setup is 12216 bytes (padded to 12288 bytes). System is 1915 kB Kernel: arch/x86/boot/bzImage is ready (#3) Building modules, stage 2. MODPOST 683 modules ERROR: "LGUEST_PAGES_guest_gdt_desc"

Re: [2.6.25-rc1 regression] Suspend to RAM (bisected)

2008-02-10 Thread Carlos R. Mafra
Arjan van de Ven wrote: > On Mon, 11 Feb 2008 03:25:33 -0200 > "Carlos R. Mafra" <[EMAIL PROTECTED]> wrote: > >> The problem with suspend to RAM is that right after typing (from >> inside X) 'echo mem > /sys/power/state' the screen becomes black and >> the laptop freezes. I have to use SysRq+b to

Re: [PATCH] Change pci_raw_ops to pci_raw_read/write

2008-02-10 Thread Yinghai Lu
On Feb 10, 2008 6:53 PM, Robert Hancock <[EMAIL PROTECTED]> wrote: > > Yinghai Lu wrote: > > On Feb 10, 2008 12:45 PM, Matthew Wilcox <[EMAIL PROTECTED]> wrote: .. > >> I've attached the two patches that I believe are the ones we want. We > >> can (and should) fix quirk_intel_irqbalance

Re: [PATCH] xfs: convert beX_add to beX_add_cpu (new common API)

2008-02-10 Thread David Chinner
On Sun, Feb 10, 2008 at 11:18:09AM +0100, Marcin Slusarz wrote: > This patch was in Andrew tree, but it was uncomplete. > Here is updated version. > > --- > remove beX_add functions and replace all uses with beX_add_cpu > > Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> > --- Looks good. You

Re: [2.6.25-rc1 regression] Suspend to RAM (bisected)

2008-02-10 Thread Calvin Walton
On Mon, 2008-02-11 at 03:25 -0200, Carlos R. Mafra wrote: > Hi, > > I want to report that suspend to RAM stopped working on my Sony Vaio > VGN-FZ240E in 2.6.25-rc1 and that I could bisect the problem down > to: > > commit bc71bec91f9875ef825d12104acf3bf4ca215fa4 > Author: [EMAIL PROTECTED]

Re: Oops report for the week upto Feb 10th 2008

2008-02-10 Thread Arjan van de Ven
Alexey Dobriyan wrote: On Sun, Feb 10, 2008 at 04:35:51PM -0800, Arjan van de Ven wrote: Rank 3: remove_proc_entry WARN_ON at fs/proc/generic.c:736 Reported 20 times (38 total reports) This WARN_ON is there if code tries to remove a non-empty /proc directory. Most

Re: [2.6.25-rc1 regression] Suspend to RAM (bisected)

2008-02-10 Thread Arjan van de Ven
On Mon, 11 Feb 2008 03:25:33 -0200 "Carlos R. Mafra" <[EMAIL PROTECTED]> wrote: > The problem with suspend to RAM is that right after typing (from > inside X) 'echo mem > /sys/power/state' the screen becomes black and > the laptop freezes. I have to use SysRq+b to reboot. > > I tried to revert

Re: Oops report for the week upto Feb 10th 2008

2008-02-10 Thread Alexey Dobriyan
On Sun, Feb 10, 2008 at 04:35:51PM -0800, Arjan van de Ven wrote: > Rank 3: remove_proc_entry > WARN_ON at fs/proc/generic.c:736 > Reported 20 times (38 total reports) > This WARN_ON is there if code tries to remove a non-empty /proc > directory. > Most reports are

Re: Netfilter fixes to 2.6.24-git

2008-02-10 Thread David Miller
From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Sun, 10 Feb 2008 22:02:35 +0100 (CET) > I have been unable to reach the netfilter and net maintainers the past > week regarding inclusion of patches, but most importantly a group of > fixes at [0]-[3]. I am kind of at a loss here but to turn up the

Re: Oops report for the week upto Feb 10th 2008

2008-02-10 Thread Nick Piggin
On Monday 11 February 2008 11:35, Arjan van de Ven wrote: > The http://www.kerneloops.org website collects kernel oops and > warning reports from various mailing lists and bugzillas as well as > with a client users can install to auto-submit oopses. > Below is a top 10 list of the

Re: m68knommu compile error

2008-02-10 Thread Greg Ungerer
Martin Schwidefsky wrote: On Sat, 2008-02-09 at 11:21 +0100, Martin Schwidefsky wrote: On Sat, 2008-02-09 at 00:25 +0200, Adrian Bunk wrote: Commit 2f569afd9ced9ebec9a6eb3dbf6f83429be0a7b4 breaks m68knommu: Does the patch below fixes the problem? I tried to cross compile for m68knommu but

Re: IO queuing and complete affinity with threads (was Re: [PATCH 0/8] IO queuing and complete affinity)

2008-02-10 Thread David Chinner
On Fri, Feb 08, 2008 at 08:59:55AM +0100, Jens Axboe wrote: > > > > At least they reported it to be the most efficient scheme in their > > > > testing, and Dave thought that migrating completions out to submitters > > > > might be a bottleneck in some cases. > > > > > > More so than migrating

[2.6.25-rc1 regression] Suspend to RAM (bisected)

2008-02-10 Thread Carlos R. Mafra
Hi, I want to report that suspend to RAM stopped working on my Sony Vaio VGN-FZ240E in 2.6.25-rc1 and that I could bisect the problem down to: commit bc71bec91f9875ef825d12104acf3bf4ca215fa4 Author: [EMAIL PROTECTED] <[EMAIL PROTECTED]> Date: Thu Jan 31 17:35:04 2008 -0800 ACPI: enable

Re: [PATCH] scsi: ses fix mem leaking when fail to add intf

2008-02-10 Thread Yinghai Lu
On Sunday 10 February 2008 08:28:38 pm James Bottomley wrote: > > On Sat, 2008-02-09 at 15:15 -0800, Yinghai Lu wrote: > > [PATCH] scsi: ses fix mem leaking when fail to add intf > > > > fix leaking with scomp leaking when failing. > > also remove one extra space. > > There are still a few

Re: raw_pci_read in quirk_intel_irqbalance

2008-02-10 Thread Matthew Wilcox
On Sun, Feb 10, 2008 at 04:02:04PM -0700, Matthew Wilcox wrote: > The line in question reads: > > /* read xTPR register */ > raw_pci_read(0, 0, 0x40, 0x4c, 2, ); > > That's domain 0, bus 0, device 8, function 0, address 0x4c, length 2. > > I've checked the public E7525 and E7520

Re: [PATCH] scsi: ses fix mem leaking when fail to add intf

2008-02-10 Thread James Bottomley
On Sat, 2008-02-09 at 15:15 -0800, Yinghai Lu wrote: > [PATCH] scsi: ses fix mem leaking when fail to add intf > > fix leaking with scomp leaking when failing. > also remove one extra space. There are still a few extraneous code moves in this one. This is about the correct minimal set, isn't

Re: [PATCH 1/4] cpufreq: change cpu freq tables to per_cpu variables

2008-02-10 Thread Dave Jones
On Fri, Feb 08, 2008 at 03:37:39PM -0800, Mike Travis wrote: > Change cpu frequency tables from arrays to per_cpu variables. > > Based on linux-2.6.git + x86.git Looks ok to me. Would you like me to push this though cpufreq.git, or do you want the series to go through all in one?

Oops with hostap_pci (?)

2008-02-10 Thread Ignacy Gawedzki
Hi, A few days back I started having strange lockups on a gateway machine so I started looking at things. Then I compiled the 2.6.24.1 kernel and started having oopses not long after upping the wlan0 (hostap_pci) interface. So I enabled netconsole and got a few logs. Now the sad point is that

Re: Linux 2.6.25-rc1

2008-02-10 Thread Gene Heskett
On Sunday 10 February 2008, Linus Torvalds wrote: >Ok, it's a bloody large -rc (as was 24-rc1, for that matter), probably >because the 2.6.24 release cycle dragged out, so people had a lot of >things pending. > >The full diff is something like 11MB and 1.4M lines of diffs, with the >bulk of the

[PATCH] [WATCHDOG] it8712f_wdt support for 16-bit timeout values, WDIOC_GETSTATUS

2008-02-10 Thread Andrew Paprocki
This patch adds support for 16-bit watchdog timeout values which are available in chip revisions >= 0x08. Values <= 65535 are seconds precision, otherwise minutes precision is used up to a maximum value of 3932100. Added implementation for WDIOC_GETSTATUS which checks the WDT status bit in the WDT

Re: [PATCH] Change pci_raw_ops to pci_raw_read/write

2008-02-10 Thread Robert Hancock
Yinghai Lu wrote: On Feb 10, 2008 12:45 PM, Matthew Wilcox <[EMAIL PROTECTED]> wrote: On Sun, Feb 10, 2008 at 12:24:18PM -0800, Linus Torvalds wrote: On Sun, 10 Feb 2008, Yinghai Lu wrote: I suggest Ivan's patch be merged ASAP as it actually fixes bugs. This patch is just cleanup (and takes

Re: [PATCH] libata: Forcing PIO0 mode on reset must not freeze system

2008-02-10 Thread Tejun Heo
Hello, Holger Macht wrote: > Calling ap->ops->set_piomode(ap, dev) on a device/controller which got > already removed, locks the system hard. Reproducibly on an X60 attached to > a dock station containing a cdrom device with doing > > $ echo 1 > /sys/devices/platform/dock.0/undock && echo 123

Re: [patch] kgdb light, v6

2008-02-10 Thread Yinghai Lu
On Feb 10, 2008 2:40 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Jan Kiszka <[EMAIL PROTECTED]> wrote: > > > Ingo, please keep the original annotations, they where correct and > > should have been optimal (under the given constraints or runtime > > reconfiguration). > > agreed. I've

Re: [Lksctp-developers] [PATCH 8/8] : Use FIELD_SIZEOF

2008-02-10 Thread Vlad Yasevich
Alexey Dobriyan wrote: On Sun, Feb 10, 2008 at 09:16:04PM +0100, Julia Lawall wrote: --- a/include/net/sctp/sctp.h +++ b/include/net/sctp/sctp.h @@ -618,7 +618,7 @@ static inline int param_type2af(__be16 t static inline int sctp_sanity_check(void) { SCTP_ASSERT(sizeof(struct

[PATCH] mlx4: fix build break

2008-02-10 Thread Olof Johansson
On Fri, Feb 08, 2008 at 03:16:53PM -0800, Roland Dreier wrote: > mlx4_core: For 64-bit systems, vmap() kernel queue buffers Hi, The above patch caused this to pop up on powerpc allyesconfig, looks like a missing include file: drivers/net/mlx4/alloc.c: In function 'mlx4_buf_alloc':

2.6.25-rc1-ext4-1 patchset released

2008-02-10 Thread Theodore Ts'o
This is a new ext4 patchset which is synchronized with the 2.6.25-rc1 release. No new patches were added, just patches removed because they have been accepted upstream. At this point, I do not anticipate any more patches to ext4 that will change the on-disk format. The focus is on the

Re: [RFC PATCH v2] x86: explicit call to mmiotrace in do_page_fault()

2008-02-10 Thread Pavel Roskin
On Sun, 2008-02-10 at 20:05 +0200, Pekka Paalanen wrote: > Sorry Jan and Pavel, I forgot to CC you in the first go of this > patch. If this makes it into mainline, I don't think it will be left > there for many kernel versions. I plan to make kmmio.h as the API towards > modules in the future,

Re: [PATCH] Change pci_raw_ops to pci_raw_read/write

2008-02-10 Thread Yinghai Lu
On Feb 10, 2008 12:45 PM, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > On Sun, Feb 10, 2008 at 12:24:18PM -0800, Linus Torvalds wrote: > > On Sun, 10 Feb 2008, Yinghai Lu wrote: > > > > > > > > I suggest Ivan's patch be merged ASAP as it actually fixes bugs. > > > > This patch is just cleanup

Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'

2008-02-10 Thread Mr. James W. Laferriere
Hello All , grabbed using git just moments ago . make V=1 KBUILD_VERBOSE=1 INSTALL_PATH=/boot clean all install modules_install ...snip... make -f scripts/Makefile.clean obj=sound/usb/usx2y make -f scripts/Makefile.clean obj=usr rm -rf .tmp_versions rm -f arch/x86/boot/fdimage

kgdb in git-x86#mm review

2008-02-10 Thread Andi Kleen
I sent Jan & Jason earlier a quick review of the kgdb code currently in git-x86#mm. The kgdb code in git-x86#mm is right now is totally broken of course because the CFI annotations in assembler code are gone now, but they are needed for gdb use. And the bogus fault handling code is still in

Re: [ANNOUNCE] Btrfs v0.12 released

2008-02-10 Thread David Miller
From: Chris Mason <[EMAIL PROTECTED]> Date: Wed, 6 Feb 2008 12:00:13 -0500 > So, here's v0.12. I couldn't even make a filesystem on sparc64 without the following patch. The first problem is that these SETGET macros lose typing information, and therefore can't see the 'packed' attribute and

Re: [PATCH] make /dev/kmem a config option

2008-02-10 Thread Arjan van de Ven
On Mon, 11 Feb 2008 01:13:09 +0100 (CET) Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > On Feb 10 2008 15:55, Arjan van de Ven wrote: > >+#ifdef CONFIG_DEVKMEM > > /* > > * This function reads the *virtual* memory as seen by the kernel. > > */ > >@@ -585,6 +588,11 @@ static ssize_t

Linux 2.6.25-rc1

2008-02-10 Thread Linus Torvalds
Ok, it's a bloody large -rc (as was 24-rc1, for that matter), probably because the 2.6.24 release cycle dragged out, so people had a lot of things pending. The full diff is something like 11MB and 1.4M lines of diffs, with the bulk of the stuff being in architecture updates and drivers. Just

[PATCH] [POWERPC] Wire up new timerfd syscalls

2008-02-10 Thread Stephen Rothwell
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- include/asm-powerpc/systbl.h |4 +++- include/asm-powerpc/unistd.h |6 -- 2 files changed, 7 insertions(+), 3 deletions(-) Kernel built for ppc64_defconfig, pseries_defconfig, iseries_defconfig, cell_defconfig and

Re: [PATCH] make /dev/kmem a config option

2008-02-10 Thread Arjan van de Ven
On Mon, 11 Feb 2008 01:13:09 +0100 (CET) Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > On Feb 10 2008 15:55, Arjan van de Ven wrote: > >+#ifdef CONFIG_DEVKMEM > > /* > > * This function reads the *virtual* memory as seen by the kernel. > > */ > >@@ -585,6 +588,11 @@ static ssize_t

Oops report for the week upto Feb 10th 2008

2008-02-10 Thread Arjan van de Ven
The http://www.kerneloops.org website collects kernel oops and warning reports from various mailing lists and bugzillas as well as with a client users can install to auto-submit oopses. Below is a top 10 list of the oopses/backtraces collected in the last 7 days. (Reports prior to 2.6.23 have

[PATCH] Prevent IDE boot ops on NUMA system in mainline

2008-02-10 Thread Andi Kleen
Without this patch a Opteron test system here oopses at boot with currentg git. Calling to_pci_dev() on a NULL pointer gives a negative value so the following NULL pointer check never triggers and then an illegal address is referenced. Check the unadjusted original device pointer for NULL

[patch 2.6.25-rc1 3/3] gpio: define gpio_is_valid()

2008-02-10 Thread David Brownell
From: Guennadi Liakhovetski <[EMAIL PROTECTED]> Introduce a gpio_is_valid() predicate; use it in gpiolib. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> [ use inline function; follow the gpio_* naming convention; work without gpiolib; all programming interfaces need docs ]

[patch 2.6.25-rc1 2/3] gpiolib: i2c/spi drivers handler rmmod better

2008-02-10 Thread David Brownell
From: Guennadi Liakhovetski <[EMAIL PROTECTED]> Use the newly introduced owner field in struct gpio_chip to protect the current (small) set of non-SOC GPIO drivers from being unloaded while any of their GPIOs are in use. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> [ add mcp23s08

Re: [PATCH 1/2] SH/Dreamcast - joystick (Control pad)

2008-02-10 Thread Mike Frysinger
On Sunday 10 February 2008, Adrian McMenamin wrote: > +static int dc_pad_connect(struct maple_device *mdev) > +{ > + ... > + if (data&(1<= 0) could use a few spaces in that first expression > +/* allow the controller to be used */ > +static int probe_maple_controller(struct device

[patch 2.6.25-rc1 1/3] gpiolib: better rmmod infrastructure

2008-02-10 Thread David Brownell
From: Guennadi Liakhovetski <[EMAIL PROTECTED]> As long as one or more GPIOs on a gpio chip are used its driver should not be unloaded. The existing mechanism (gpiochip_remove failure) doesn't address that, since rmmod can no longer be made to fail by having the cleanup code report errors.

Re: [PATCH] make /dev/kmem a config option

2008-02-10 Thread Jan Engelhardt
On Feb 10 2008 15:55, Arjan van de Ven wrote: >+#ifdef CONFIG_DEVKMEM > /* > * This function reads the *virtual* memory as seen by the kernel. > */ >@@ -585,6 +588,11 @@ static ssize_t write_kmem(struct file * file, const char >__user * buf, > *ppos = p; > return virtr + wrote; > }

2.6.24.x-stable request for 69f817b654d683265118188bbfb8bc0d8978cce6 and ece8edddf067d21c4e5abfe3f1205da1588edbb2

2008-02-10 Thread S.Çağlar Onur
Hi; On 2.6.24.1-stable kernel review cycle, i requested inclusions of commit 69f817b654d683265118188bbfb8bc0d8978cce6 (mac80211: Restore rx.fc before every invocation of ieee80211_invoke_rx_handlers) and ece8edddf067d21c4e5abfe3f1205da1588edbb2 (mac80211: hardware scan rework) into -stable

[PATCH] make /dev/kmem a config option

2008-02-10 Thread Arjan van de Ven
Subject: [PATCH] make /dev/kmem a config option From: Arjan van de Ven <[EMAIL PROTECTED]> This patch makes /dev/kmem a config option; /dev/kmem is VERY rarely used, and when used, it's generally for no good (rootkits tend to be the most common users). With this config option, users have the

[git patches] IDE fixes

2008-02-10 Thread Bartlomiej Zolnierkiewicz
Hi, We merged _a_lot_ of IDE patches for 2.6.25 so no wonder that a few bugs showed up (yes, mostly brown paper ones of mine :). This update should put it under control again (there are two more open regression bugreports left and they are going to be addressed as soon as we have more data). -

[PATCH] Documentation: prune redundant SubmitChecklist items

2008-02-10 Thread J. Bruce Fields
From: J. Bruce Fields <[EMAIL PROTECTED]> Kernel style is mentioned twice, and the git apply trick is a bit redundant given the checkpatch.pl recommendation (which also checks for bad whitespace). Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]> --- Documentation/SubmitChecklist | 16

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-10 Thread Matthew Wilcox
On Sat, Feb 09, 2008 at 01:50:20PM +, Alan Cox wrote: > On Fri, 08 Feb 2008 20:32:54 -0500 Douglas Gilbert <[EMAIL PROTECTED]> wrote: > > Alan Cox wrote: > > > The word "illegal" has a precise dictionary meaning of "prohibited by > > > law". > > > > Also "contrary to or forbidden by official

Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-10 Thread S.Çağlar Onur
Hi; 10 Şub 2008 Paz tarihinde, Jiri Slaby şunları yazmıştı: > I think this is not correct. You change the err which caused the failure. You > change it even to 0 if it doesn't fail and the whole function will seem like > non-failing. My bad, sorry for not looking carefully. Assuming a

Re: [PATCH] splice: fix user pointer access in get_iovec_page_array()

2008-02-10 Thread Willy Tarreau
On Sun, Feb 10, 2008 at 04:47:57PM +0200, Pekka J Enberg wrote: > From: Bastian Blank <[EMAIL PROTECTED]> > > The commit 8811930dc74a503415b35c4a79d14fb0b408a361 ("splice: missing user > pointer access verification") added access_ok() to copy_from_user_mmap_sem() > which only ensures we can copy

Re: I/O collisions w/ hwmon/it87.c and watchdog/it8712f_wdt.c? (Super I/O chips in general..)

2008-02-10 Thread Andrew Paprocki
Does it make sense to use the drivers/mfd directory for Super I/O chips then? Is there any problem with having other hwmon, watchdog, etc depend on drivers/mfd? Should this kind of setup for platform devices be documented in the driver-model? -Andrew On Feb 10, 2008 6:05 PM, Alan Cox <[EMAIL

[patch] sparc: fix build

2008-02-10 Thread David Rientjes
Fix build failures on sparc: In file included from include/linux/mm.h:39, from include/linux/memcontrol.h:24, from include/linux/swap.h:8, from include/linux/suspend.h:7, from

nfsd fixes for 2.6.25

2008-02-10 Thread J. Bruce Fields
The following changes are available from the for-linus branch of the git repository at: git://linux-nfs.org/~bfields/linux.git for-linus The four patches from Jeff Layton fix a bug that can allow an unresponsive client to hang lockd. The other two patches are minor compile fixes. --b. J.

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-10 Thread Douglas Gilbert
Alan Cox wrote: On Fri, 08 Feb 2008 20:32:54 -0500 Douglas Gilbert <[EMAIL PROTECTED]> wrote: Alan Cox wrote: The word "illegal" has a precise dictionary meaning of "prohibited by law". Also "contrary to or forbidden by official rules, regulations, etc". The OED I have here doesn't seem

[PATCH] ide: remove stale comment from ide-lib.c

2008-02-10 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-lib.c |9 - 1 file changed, 9 deletions(-) Index: b/drivers/ide/ide-lib.c === --- a/drivers/ide/ide-lib.c +++ b/drivers/ide/ide-lib.c @@

[PATCH] ide: fix comment in init_irq()

2008-02-10 Thread Bartlomiej Zolnierkiewicz
APUS support is gone... Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-probe.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/ide-probe.c === ---

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, Bartlomiej Zolnierkiewicz wrote: > On Sunday 10 February 2008, Atsushi Nemoto wrote: > > On Sun, 06 Jan 2008 18:03:10 +0100, Bartlomiej Zolnierkiewicz <[EMAIL > > PROTECTED]> wrote: > > > + /* reset DMA masks only for SFF-style DMA controllers */ > > > + if

Re: I/O collisions w/ hwmon/it87.c and watchdog/it8712f_wdt.c? (Super I/O chips in general..)

2008-02-10 Thread Alan Cox
> Since these chips touch many different parts of traditionally separate > driver areas, how should the drivers be structured so that they can > all talk to the chip? Should the low level communications routines for > the chip live in a library which all the drivers could use? Probably yes. And

Re: [git pull] x86 updates

2008-02-10 Thread Ingo Molnar
* Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Sun, 10 Feb 2008, Linus Torvalds wrote: > > On Sat, 9 Feb 2008, Randy Dunlap wrote: > > > > So Thomas, don't do this. I don't like it. The same way I didn't like > > seeing Ingo trying to mix in a kgdb pull into his x86 pull. Keep these > >

[PATCH 2/2] SH/Dreamcast - joystick (controlpad)

2008-02-10 Thread Adrian McMenamin
Changes to the Kconfig and Makefile needed to build the Maple controlpad code. Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> == diff --combined drivers/input/joystick/Kconfig index 7c662ee,7c662ee..3566fa2 --- a/drivers/input/joystick/Kconfig +++ b/drivers/input/joystick/Kconfig @@@

raw_pci_read in quirk_intel_irqbalance

2008-02-10 Thread Matthew Wilcox
On Sun, Feb 10, 2008 at 01:45:57PM -0700, Matthew Wilcox wrote: > I just looked at fixing that -- the reason seems to be that we don't > actually have the struct pci_dev at that point. I can fix it, but I > think it's actually buggy. I want to look at some chipset docs to > confirm that though.

[PATCH] x86: remove over noisy debug printk

2008-02-10 Thread Thomas Gleixner
pageattr-test.c contains a noisy debug printk that people reported. The condition under which it prints (randomly tapping into a mem_map[] hole and not being able to c_p_a() there) is valid behavior and not interesting to report. Remove it. Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]>

[PATCH 1/2] SH/Dreamcast - joystick (Control pad)

2008-02-10 Thread Adrian McMenamin
Adds support for the Dreamcast control pad. This is a port of the 2.4 driver (never in mainline) by Yaegashi Takeshi. Signed-off-by: Adrian McMenamin <[EMAIL PROTECTED]> == --- /dev/null 2007-10-16 19:02:41.0 +0100 +++ drivers/input/joystick/maplecontrol.c 2008-02-10

Re: scsi/arm/fas216.c compile error

2008-02-10 Thread James Bottomley
On Sun, 2008-02-10 at 22:02 +, Russell King wrote: > On Sun, Feb 10, 2008 at 08:20:24AM -0600, James Bottomley wrote: > > > > On Sun, 2008-02-10 at 13:58 +, Russell King wrote: > > > On Sun, Feb 10, 2008 at 03:07:09PM +0200, Boaz Harrosh wrote: > > > > It's in mainline

Re: [patch] kgdb light, v6

2008-02-10 Thread Jan Kiszka
Bartlomiej Zolnierkiewicz wrote: > On Sunday 10 February 2008, Jan Kiszka wrote: >> Ingo Molnar wrote: >>> * Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > +static int init_kgdboc(void) __init >>> done. >> Uuh, careful. We need this for runtime reconfiguration. > > it is used

Re: [patch] kgdb light, v6

2008-02-10 Thread Ingo Molnar
* Jan Kiszka <[EMAIL PROTECTED]> wrote: > Ingo Molnar wrote: > > * Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > >>> +static int init_kgdboc(void) > >> __init > > > > done. > > Uuh, careful. We need this for runtime reconfiguration. i think v7 is fine. worst-case we'll get a nice

[patch] move wakeup code to .c

2008-02-10 Thread Pavel Machek
I think .c wakeup code is ready for some more testing. HPA and Rafael did coding, so I added them as signed-off-by:. (Plus Rafael actually thinks its ready for -mm, I agree.) Pavel --- Move wakeup code to .c, so that video mode

Re: [PATCH 2/8] drivers/block: Use FIELD_SIZEOF

2008-02-10 Thread Stephen Rothwell
On Sun, 10 Feb 2008 21:08:49 +0100 (CET) Julia Lawall <[EMAIL PROTECTED]> wrote: > > From: Julia Lawall <[EMAIL PROTECTED]> > > Robert P.J. Day proposed to use the macro FIELD_SIZEOF in replace of code > that matches its definition. > > The modification was made using the following semantic

Re: [PATCH] SUNPRC: Fix printk format warning

2008-02-10 Thread J. Bruce Fields
On Fri, Feb 08, 2008 at 04:02:04PM -0800, Roland Dreier wrote: > net/sunrpc/xprtrdma/svc_rdma_sendto.c:160: warning: format '%llx' expects > type 'long long unsigned int', but argument 3 has type 'u64' OK, thanks. Applied (with the long line split). --b. > > Signed-off-by: Roland Dreier

Re: x86: Why have __copy_from_user_ll_nocache* been exported?

2008-02-10 Thread Adrian Bunk
> * Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > Sorry Andrew. > > > > I misunderstood the patch flow. > > > > And much more important, the tone of my email was not appropriate. > > > > Due to unrelated reasons I was Thursday evening in a mood in which I > > should not have left emails out of

Re: [patch] kgdb light, v6

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, Ingo Molnar wrote: [...] > > > +__setup("kgdboc=", kgdboc_option_setup); > > > > no need for obsolete __setup, we have module_param_call() below > > it's needed for bzImage kernels. I just tested it and without __setup() > no init sequence is run and KGDB is not

Re: [patch] kgdb light, v6

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, Jan Kiszka wrote: > Ingo Molnar wrote: > > * Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > >>> +static int init_kgdboc(void) > >> __init > > > > done. > > Uuh, careful. We need this for runtime reconfiguration. it is used only for 'module_init(init_kgdboc);'

[PATCH v2] Whine about suspicious return values from module's ->init() hook

2008-02-10 Thread Alexey Dobriyan
On Wed, Feb 06, 2008 at 05:55:26PM +1100, Rusty Russell wrote: > On Wednesday 06 February 2008 10:37:52 Andrew Morton wrote: > > On Wed, 6 Feb 2008 09:48:10 +1100 > > > > Rusty Russell <[EMAIL PROTECTED]> wrote: > > > > It's a no-brainer. > > > > > > For non-developers, WARN_ON is a noop. > > > >

Re: [PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)

2008-02-10 Thread S.Çağlar Onur
Hi; 10 Şub 2008 Paz tarihinde, Linus Torvalds şunları yazmıştı: > > On Sun, 10 Feb 2008, S.Çağlar Onur wrote: > > > > > > > > - while (dev = device_find_child(>dev, NULL, __match_tty)) { > > > > + while ((dev = device_find_child(>dev, NULL, __match_tty)) > > > > != NULL) { > > > >

Re: scsi/arm/fas216.c compile error

2008-02-10 Thread Russell King
On Sun, Feb 10, 2008 at 08:20:24AM -0600, James Bottomley wrote: > > On Sun, 2008-02-10 at 13:58 +, Russell King wrote: > > On Sun, Feb 10, 2008 at 03:07:09PM +0200, Boaz Harrosh wrote: > > > It's in mainline 84ac86ca8c6787f9efff28bc04b1b65fe0a5c310 > > > [SCSI] arm: convert to accessors

Re: sparc compile error

2008-02-10 Thread Robert Reif
David Rientjes wrote: Please try Linus' latest git that includes 60c12b12 (from yesterday) that fixes this issue. I get this with latest git: CC init/do_mounts.o In file included from include/linux/mm.h:39, from include/linux/memcontrol.h:24, from

2.6.24 oops

2008-02-10 Thread Lukas Hejtmanek
Hello, I encountered an oops while playing a movie with mplayer. (couple of hours before, I tried this exploit: http://www.securityfocus.com/data/vulnerabilities/exploits/27704.c so the oops may be induced by the exploit.) [12695.120141] Unable to handle kernel paging request at 1000

Re: [patch] kgdb light, v6

2008-02-10 Thread Jan Kiszka
Ingo Molnar wrote: > * Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: >>> +static int init_kgdboc(void) >> __init > > done. Uuh, careful. We need this for runtime reconfiguration. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: pata_sil680 regression 2.6.22->2.6.24

2008-02-10 Thread Robert Lowery
> Robert Lowery wrote: >> Hi Folks, >> >> Having recently upgaded my Ubuntu install from Gutsy to Hardy, my 750GB >> Seagate disk connected via a SiI680 PCI card is no longer detected. I >> suspect this is caused by the MMIO changes in 2.6.24. Strangely in >> 2.6.22 >> the drive appears as sda1,

Re: [0/6] kgdb light

2008-02-10 Thread Ingo Molnar
* Sam Ravnborg <[EMAIL PROTECTED]> wrote: > I promote the "select HAVE_*" style on all new stuff and expect that a > herd of janitors one day pick it up and convert most of the old-style > stuff. And if you look around then you will see that for this merge > window almost all new stuff used

Re: 2.6.26-git0: IDE oops during boot

2008-02-10 Thread Nish Aravamudan
On 2/7/08, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > On Thursday 07 February 2008, Kamalesh Babulal wrote: > > Bartlomiej Zolnierkiewicz wrote: > > > Hi, > > > > > > On Wednesday 06 February 2008, Pavel Machek wrote: > > >> On Wed 2008-02-06 11:53:34, Pavel Machek wrote: > > >>> Hi!

[patch] avoid kmemcheck warning in epoll

2008-02-10 Thread Davide Libenzi
Epoll calls rb_set_parent(n, n) to initialize the rb-tree node, but rb_set_parent() accesses node's pointer in its code. This creates a warning in kmemcheck (reported by Vegard Nossum) about an uninitialized memory access. The warning is harmless since the following rb-tree node insert is

Re: [patch] kgdb light, v6

2008-02-10 Thread Ingo Molnar
* Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > no. These are not DocBook comments, if you look carefully at the > > format [it's not a leading '/**' comment block]. But obviously > > documenting this in the include file is very useful, because that's > > where people look first,

Re: [0/6] kgdb light

2008-02-10 Thread Sam Ravnborg
> > btw., we should convert all those current: > > config ARCH_POPULATES_NODE_MAP > def_bool y > > config AUDIT_ARCH > bool > default X86_64 > > config ARCH_SUPPORTS_AOUT > def_bool y > > instances to select lines after config X86 / config X86_64. > >

  1   2   3   4   5   6   7   >