RE: [PATCH v8 16/18] NTB: tool: Enable the NTB/PCIe link on the local or remote side of bridge

2020-12-07 Thread Jiang, Dave
> -Original Message- > From: Kishon Vijay Abraham I > Sent: Wednesday, November 11, 2020 8:36 AM > To: Bjorn Helgaas ; Jonathan Corbet > ; Kishon Vijay Abraham I ; Lorenzo > Pieralisi ; Arnd Bergmann ; > Jon Mason ; Jiang, Dave ; > Allen Hubbe ; Tom Joseph ; > Rob Herring > Cc: Greg

Re: [PATCH 4.19 00/32] 4.19.162-rc1 review

2020-12-07 Thread Guenter Roeck
On Sun, Dec 06, 2020 at 12:17:00PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.162 release. > There are 32 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.14 00/20] 4.14.211-rc1 review

2020-12-07 Thread Guenter Roeck
On Sun, Dec 06, 2020 at 12:17:03PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.211 release. > There are 20 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

[PATCH] powerpc: fix spelling mistake in Kconfig "seleted" -> "selected"

2020-12-07 Thread Colin King
From: Colin Ian King There is a spelling mistake in the help text of the Kconfig. Fix it. Signed-off-by: Colin Ian King --- arch/powerpc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 8fb61a285c76..4010bae52351

Re: crypto: sun4i-ss: error with kmap

2020-12-07 Thread Thomas Gleixner
On Mon, Dec 07 2020 at 13:18, Corentin Labbe wrote: > On Mon, Dec 07, 2020 at 01:15:49AM +0100, Thomas Gleixner wrote: > So if I understand correctly, basicly I cannot have two atomic kmap at > the same time since it made unmapping them in the right order complex. You can, but the ordering has

Re: [PATCH][next] hwmon: ltc2992: fix less than zero comparisons with an unsigned integer

2020-12-07 Thread Guenter Roeck
On Mon, Dec 07, 2020 at 02:24:10PM +, Colin King wrote: > From: Colin Ian King > > There are several occurrances of a less than zero error check on > a u32 unsigned integer. These will never be true. Fix this by making > reg_value a plain int. > > Addresses-Coverity: ("Unsigned comparison

Re: [PATCH] clk: imx: Fix reparenting of UARTs not associated with sdout

2020-12-07 Thread Adam Ford
On Sun, Dec 6, 2020 at 11:24 PM Sascha Hauer wrote: > > Hi Adam, > > On Fri, Dec 04, 2020 at 12:31:54PM -0600, Adam Ford wrote: > > The default clock source on i.MX8M Mini and Nano boards use a 24MHz clock, > > but users who need to re-parent the clock source run into issues because > > all the

[PATCH] ixp4xx: fix spelling mistake in Kconfig "Devce" -> "Device"

2020-12-07 Thread Colin King
From: Colin Ian King There is spelling mistake in the prompt text in the Kconfig. Fix it. Signed-off-by: Colin Ian King --- arch/arm/mach-ixp4xx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-ixp4xx/Kconfig b/arch/arm/mach-ixp4xx/Kconfig index

Re: [RFC PATCH v5] sched/fair: select idle cpu from idle cpumask for task wakeup

2020-12-07 Thread Peter Zijlstra
On Wed, Nov 18, 2020 at 12:31:13PM +0800, Aubrey Li wrote: > Add idle cpumask to track idle cpus in sched domain. When a CPU > enters idle, if the idle driver indicates to stop tick, this CPU > is set in the idle cpumask to be a wakeup target. And if the CPU > is not in idle, the CPU is cleared in

Re: [PATCH v4 2/7] Input: use input_device_enabled()

2020-12-07 Thread Andrzej Pietrasiewicz
put.c:2230 input_device_enabled+0x68/0x6c Modules linked in: cmac bnep mwifiex_sdio mwifiex sha256_generic libsha256 sha256_arm cfg80211 btmrvl_sdio btmrvl bluetooth s5p_mfc exynos_gsc v4l2_mem2mem videob CPU: 0 PID: 1777 Comm: rtcwake Not tainted 5.10.0-rc6-next-20201207-1-g49a0dc04c46d-dirty #9902 Har

Re: [RFC PATCH v2] do_exit(): panic() recursion detected

2020-12-07 Thread Eric W. Biederman
Vladimir Kondratiev writes: > Please ignore version 1 of the patch - it was sent from wrong mail address. > > To clarify the reason: > > Situation where do_exit() re-entered, discovered by static code analysis. > For safety critical system, it is better to panic() when minimal chance of >

[PATCH] arch: fix spelling mistakes in Kconfig

2020-12-07 Thread Colin King
From: Colin Ian King There are a few spelling mistakes in the Kconfig comments and help text. Fix these. Signed-off-by: Colin Ian King --- arch/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/Kconfig b/arch/Kconfig index f7f246e68ff5..a52f8e8d16ad

Re: [RFC PATCH v5] sched/fair: select idle cpu from idle cpumask for task wakeup

2020-12-07 Thread Peter Zijlstra
On Wed, Nov 18, 2020 at 12:31:13PM +0800, Aubrey Li wrote: > diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c > index f324dc36fc43..6f5947673e66 100644 > --- a/kernel/sched/idle.c > +++ b/kernel/sched/idle.c > @@ -163,6 +163,7 @@ static void cpuidle_idle_call(void) >*/ > > if

Re: [PATCH bpf-next v3 13/14] bpf: Add tests for new BPF atomic operations

2020-12-07 Thread Brendan Jackman
On Fri, Dec 04, 2020 at 11:49:22AM -0800, Andrii Nakryiko wrote: > On Fri, Dec 4, 2020 at 7:29 AM Yonghong Song wrote: > > > > > > > > On 12/4/20 1:45 AM, Brendan Jackman wrote: > > > On Thu, Dec 03, 2020 at 11:06:31PM -0800, Yonghong Song wrote: > > >> On 12/3/20 8:02 AM, Brendan Jackman wrote:

Re: [PATCH] hwmon: pmbus: correct title underline length

2020-12-07 Thread Guenter Roeck
rns: > > Documentation/hwmon/q54sj108a2.rst:4: WARNING: Title underline too short. > > Adjust the title underline to the correct length. > > Signed-off-by: Lukas Bulwahn Applied. Thanks, Guenter > --- > applies on next-20201207 and the hwmon -next tree > > Guen

Re: [PATCH 0/4] USB: ftdio_sio: GPIO validity fixes

2020-12-07 Thread Johan Hovold
On Mon, Dec 07, 2020 at 03:34:23PM +, Marc Zyngier wrote: > On 2020-12-07 15:08, Johan Hovold wrote: > > On Mon, Dec 07, 2020 at 02:41:03PM +, Marc Zyngier wrote: > >> On 2020-12-07 14:01, Johan Hovold wrote: > >> > On Fri, Dec 04, 2020 at 04:47:35PM +, Marc Zyngier wrote: > >> >>

Re: [PATCH v5 0/2] MTE support for KVM guest

2020-12-07 Thread Steven Price
On 07/12/2020 15:27, Peter Maydell wrote: On Mon, 7 Dec 2020 at 14:48, Steven Price wrote: Sounds like you are making good progress - thanks for the update. Have you thought about how the PROT_MTE mappings might work if QEMU itself were to use MTE? My worry is that we end up with MTE in a

Re: [PATCH] s390/vfio-ap: Clean up vfio_ap resources when KVM pointer invalidated

2020-12-07 Thread Christian Borntraeger
On 07.12.20 16:24, Halil Pasic wrote: > On Fri, 4 Dec 2020 11:48:24 -0500 > Tony Krowiak wrote: > >> On 12/3/20 12:55 PM, Halil Pasic wrote: >>> On Wed, 2 Dec 2020 18:41:01 -0500 >>> Tony Krowiak wrote: >>> The vfio_ap device driver registers a group notifier with VFIO when the

Re: scheduling while atomic in z3fold

2020-12-07 Thread Mike Galbraith
On Mon, 2020-12-07 at 16:21 +0100, Vitaly Wool wrote: > On Mon, Dec 7, 2020 at 1:34 PM Mike Galbraith wrote: > > > > > Unfortunately, that made zero difference. > > Okay, I suggest that you submit the patch that changes read_lock() to > write_lock() in __release_z3fold_page() and I'll ack it

Re: [RFC PATCH 0/4] Reduce worst-case scanning of runqueues in select_idle_sibling

2020-12-07 Thread Mel Gorman
On Mon, Dec 07, 2020 at 04:04:41PM +0100, Vincent Guittot wrote: > On Mon, 7 Dec 2020 at 10:15, Mel Gorman wrote: > > > > This is a minimal series to reduce the amount of runqueue scanning in > > select_idle_sibling in the worst case. > > > > Patch 1 removes SIS_AVG_CPU because it's unused. > > >

Re: [PATCH] io_uring: fix file leak on creating io ctx

2020-12-07 Thread Jens Axboe
On 12/7/20 8:04 AM, Jens Axboe wrote: > On 12/7/20 1:15 AM, Hillf Danton wrote: >> Put file as part of error handling when setting up io ctx to fix >> memory leak like the following one. >> >>BUG: memory leak >>unreferenced object 0x888101ea2200 (size 256): >> comm

RE: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-07 Thread Limonciello, Mario
> First of all thank you for working on this. > > I must say though that I don't like the approach taken here very > much. > > This is not so much a criticism of this series as it is a criticism > of the earlier decision to simply disable s0ix on all devices > with the i219-LM + and active ME.

Re: scheduling while atomic in z3fold

2020-12-07 Thread Sebastian Andrzej Siewior
On 2020-12-07 16:21:20 [+0100], Vitaly Wool wrote: > On Mon, Dec 7, 2020 at 1:34 PM Mike Galbraith wrote: > > > > Unfortunately, that made zero difference. > > Okay, I suggest that you submit the patch that changes read_lock() to > write_lock() in __release_z3fold_page() and I'll ack it then. >

Re: [PATCH v2] drivers: gpio: put virtual gpio device into their own submenu

2020-12-07 Thread Andy Shevchenko
On Mon, Dec 7, 2020 at 1:29 PM Enrico Weigelt, metux IT consult wrote: > > Since we already have a few virtual GPIO drivers, and more to come, > this category deserves its own submenu. > > Signed-off-by: Enrico Weigelt, metux IT consult > --- You are not a first day contributor, where is the

Re: [patch V2 9/9] tasklets: Prevent kill/unlock_wait deadlock on RT

2020-12-07 Thread Sebastian Andrzej Siewior
On 2020-12-07 16:22:07 [+0100], Thomas Gleixner wrote: > On Mon, Dec 07 2020 at 15:00, Sebastian Andrzej Siewior wrote: > > So we keep the RT part as-is and replace the non-RT bits with this? > > No. It would work for both. So instead of boosting our way through we simply wait until the tasklet

[PATCH] arch: fix spelling mistakes in Kconfig

2020-12-07 Thread Colin King
From: Colin Ian King There are a few spelling mistakes in the Kconfig comments and help text. Fix these. Signed-off-by: Colin Ian King --- arch/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/Kconfig b/arch/Kconfig index f7f246e68ff5..a52f8e8d16ad

Re: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM

2020-12-07 Thread Steven Rostedt
On Mon, 7 Dec 2020 07:57:27 + Avri Altman wrote: > > > > TP_printk( > > - "%s: %s: HDR:%s, CDB:%s", > > + "%s: %s: HDR:%s, %s:%s", > > __get_str(str), __get_str(dev_name), > > __print_hex(__entry->hdr,

Re: [PATCH v7 0/8] rpmsg: Make RPMSG name service modular

2020-12-07 Thread Kishon Vijay Abraham I
+Lorenzo, Bjorn, Rob Hi Guennadi, On 04/12/20 11:21 pm, Mathieu Poirier wrote: > I am adding Vincent Whitchurch and the virtualization mailing list... > > On Thu, 3 Dec 2020 at 13:42, Guennadi Liakhovetski > wrote: >> >> (adding vhost maintainers and the author of [1]) >> >> Hi, >> >> I'm

Re: [PATCH] MIPS: KASLR: Fix sync_icache() trapped in loop when synci_step is zero

2020-12-07 Thread Maciej W. Rozycki
On Wed, 2 Dec 2020, Thomas Bogendoerfer wrote: > PS: Does anybody know a reason, why this code doesn't use an old fashioned > dache/icache flushing, which might be slower but would work also on > legecy cores ? Hmm, this was contributed by ImgTec in 2016 only, so I guess there was no reason as

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2020-12-07 Thread Ard Biesheuvel
On Mon, 7 Dec 2020 at 15:28, Jason A. Donenfeld wrote: > > Hi Ard, > > On Tue, Dec 1, 2020 at 1:24 PM Ard Biesheuvel wrote: > > > > > is implemented. In most cases, these are special instructions, but in > > > > > some cases, such as on ARM, we may want to back this using firmware > > > > >

Re: [PATCH 2/3] rwsem: Implement down_read_interruptible

2020-12-07 Thread Waiman Long
On 12/7/20 4:02 AM, Peter Zijlstra wrote: On Thu, Dec 03, 2020 at 08:59:13PM -0500, Waiman Long wrote: On 12/3/20 3:11 PM, Eric W. Biederman wrote: +static inline int __down_read_interruptible(struct rw_semaphore *sem) +{ + if (!rwsem_read_trylock(sem)) { + if

Re: [PATCH 0/4] USB: ftdio_sio: GPIO validity fixes

2020-12-07 Thread Marc Zyngier
On 2020-12-07 15:08, Johan Hovold wrote: On Mon, Dec 07, 2020 at 02:41:03PM +, Marc Zyngier wrote: On 2020-12-07 14:01, Johan Hovold wrote: > On Fri, Dec 04, 2020 at 04:47:35PM +, Marc Zyngier wrote: >> Having recently tried to use the CBUS GPIOs that come thanks to the >> ftdio_sio

Re: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM

2020-12-07 Thread Steven Rostedt
On Sun, 6 Dec 2020 17:42:26 +0100 Bean Huo wrote: > From: Bean Huo > > Transaction Specific Fields (TSF) in the UPIU package could be CDB > (SCSI/UFS Command Descriptor Block), OSF (Opcode Specific Field), and > TM I/O parameter (Task Management Input/Output Parameter). But, currently, > we

Re: [PATCH 1/7] soundwire: bus: use sdw_update_no_pm when initializing a device

2020-12-07 Thread Pierre-Louis Bossart
On 12/6/20 10:43 PM, Vinod Koul wrote: On 05-12-20, 08:59, Pierre-Louis Bossart wrote: Thanks for the review Vinod. On 12/5/20 1:45 AM, Vinod Koul wrote: On 03-12-20, 04:46, Bard Liao wrote: From: Pierre-Louis Bossart When a Slave device is resumed, it may resume the bus and restart the

Re: [PATCH v2 1/8] lib/find_bit.c: Add find_last_zero_bit

2020-12-07 Thread Andy Shevchenko
On Sun, Dec 06, 2020 at 03:46:24PM +0900, Levi Yun wrote: > Inspired find_next_*_bit and find_last_bit, add find_last_zero_bit > And add le support about find_last_bit and find_last_zero_bit. Use `git format-patch ...` tool. When create a series, be sure you run it: - with -v, where is a version

Re: [RFC PATCH v2 2/2] scheduler: add scheduler level for clusters

2020-12-07 Thread Vincent Guittot
On Mon, 7 Dec 2020 at 10:59, Song Bao Hua (Barry Song) wrote: > > > > > -Original Message- > > From: Vincent Guittot [mailto:vincent.guit...@linaro.org] > > Sent: Thursday, December 3, 2020 10:39 PM > > To: Song Bao Hua (Barry Song) > > Cc: Valentin Schneider ; Catalin Marinas > > ; Will

Re: [PATCH v2 2/2] modules: add scmversion field

2020-12-07 Thread Jessica Yu
+++ Will McVicker [25/11/20 01:05 +]: Add the modinfo field `scmversion` to include the SCM version of kernel modules, e.g. git sha1. This allows one to identify the exact source code version of a given kernel module. You can retrieve it in two ways, 1) By using modinfo > modinfo -F

Re: [PATCH v2] pwm: bcm2835: Support apply function for atomic configuration

2020-12-07 Thread Thierry Reding
On Mon, Dec 07, 2020 at 02:52:09PM +0100, Uwe Kleine-König wrote: > Hello Sean, > > On Mon, Dec 07, 2020 at 09:43:20AM +, Sean Young wrote: > > Thank you for taking the time to explain your thinking. > > I'm happy you have an open ear for it. With this I really enjoy spending > the time to

Re: WARNING in sk_stream_kill_queues (5)

2020-12-07 Thread Marco Elver
On Thu, Dec 03, 2020 at 07:01PM +0100, Eric Dumazet wrote: > On 12/3/20 6:41 PM, Marco Elver wrote: > > > One more experiment -- simply adding > > > > --- a/net/core/skbuff.c > > +++ b/net/core/skbuff.c > > @@ -207,7 +207,21 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t > > gfp_mask,

Re: [PATCH v5 0/2] MTE support for KVM guest

2020-12-07 Thread Peter Maydell
On Mon, 7 Dec 2020 at 14:48, Steven Price wrote: > Sounds like you are making good progress - thanks for the update. Have > you thought about how the PROT_MTE mappings might work if QEMU itself > were to use MTE? My worry is that we end up with MTE in a guest > preventing QEMU from using MTE

Re: [RESEND PATCH v13 0/6] add DFL bus support to MODULE_DEVICE_TABLE()

2020-12-07 Thread Tom Rix
> Main changes from v12: > - For patch #5, fix the wrong use of logical'||', should use '|' This set has not changed in a while, looks like it is just patch 5/6 that needs ack-ed. Tom > Xu Yilun (6): > fpga: dfl: fix the definitions of type & feature_id for dfl devices > fpga: dfl: move

Re: [PATCH] Add support for getting and setting SACLs

2020-12-07 Thread Boris Protopopov
Hello, Shyam, sorry for the delayed reply and thanks for looking at this patch. Yes, the testing was done using the extended versions of getcifsacl/setcifsacl (added setting owner and SACL support), the patch for that posted recently via samba-technical (message ID

[PATCH] hwmon: pmbus: correct title underline length

2020-12-07 Thread Lukas Bulwahn
the title underline to the correct length. Signed-off-by: Lukas Bulwahn --- applies on next-20201207 and the hwmon -next tree Guenter, Jean, please pick this minor doc fix on your -next tree. Documentation/hwmon/q54sj108a2.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: timers: Move clearing of base::timer_running under base::lock

2020-12-07 Thread Sebastian Andrzej Siewior
On 2020-12-07 15:29:50 [+0100], Thomas Gleixner wrote: > On Mon, Dec 07 2020 at 14:07, Sebastian Andrzej Siewior wrote: > > One thing I noticed while testing it is that the "corner" case in > > timer_sync_wait_running() is quite reliably hit by rcu_preempt > > rcu_gp_fqs_loop() ->

Re: [PATCH] s390/vfio-ap: Clean up vfio_ap resources when KVM pointer invalidated

2020-12-07 Thread Halil Pasic
On Fri, 4 Dec 2020 11:48:24 -0500 Tony Krowiak wrote: > On 12/3/20 12:55 PM, Halil Pasic wrote: > > On Wed, 2 Dec 2020 18:41:01 -0500 > > Tony Krowiak wrote: > > > >> The vfio_ap device driver registers a group notifier with VFIO when the > >> file descriptor for a VFIO mediated device for a

Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons

2020-12-07 Thread ron minnich
I pinged the person again. Hope to hear today. Sorry for delay. On Sun, Dec 6, 2020 at 11:52 PM Sven Eckelmann wrote: > > On Friday, 27 November 2020 19:54:30 CET ron minnich wrote: > > Thanks, Sven, for your patience, I will indeed try to test this next week. > > Any test results? > > Kind

Re: [patch V2 9/9] tasklets: Prevent kill/unlock_wait deadlock on RT

2020-12-07 Thread Thomas Gleixner
On Mon, Dec 07 2020 at 15:00, Sebastian Andrzej Siewior wrote: > On 2020-12-07 12:47:43 [+0100], Peter Zijlstra wrote: >> On Fri, Dec 04, 2020 at 06:02:00PM +0100, Thomas Gleixner wrote: >> > @@ -825,7 +848,20 @@ void tasklet_kill(struct tasklet_struct >> > >> >while

Re: scheduling while atomic in z3fold

2020-12-07 Thread Vitaly Wool
On Mon, Dec 7, 2020 at 1:34 PM Mike Galbraith wrote: > > On Mon, 2020-12-07 at 12:52 +0100, Vitaly Wool wrote: > > > > Thanks. This trace beats me because I don't quite get how this could > > have happened. > > I swear there's a mythical creature loose in there somewhere ;-) > Everything looks

Re: [PATCH v1 1/3] scsi: ufs: Distinguish between query REQ and query RSP in query trace

2020-12-07 Thread Steven Rostedt
On Sun, 6 Dec 2020 17:42:24 +0100 Bean Huo wrote: > From: Bean Huo > > Currently, in the query completion trace print, since we use > hba->lrb[tag].ucd_req_ptr and didn't differentiate UPIU between > request and response, thus header and transaction-specific field > in UPIU printed by query

Re: [patch V2 7/9] softirq: Replace barrier() with cpu_relax() in tasklet_unlock_wait()

2020-12-07 Thread Thomas Gleixner
On Mon, Dec 07 2020 at 12:39, Peter Zijlstra wrote: > On Fri, Dec 04, 2020 at 06:01:58PM +0100, Thomas Gleixner wrote: >> static inline void tasklet_unlock_wait(struct tasklet_struct *t) >> { >> -while (test_bit(TASKLET_STATE_RUN, &(t)->state)) { barrier(); } >> +while

Re: [External] Re: [PATCH] mm: memcontrol: optimize per-lruvec stats counter memory usage

2020-12-07 Thread Muchun Song
On Mon, Dec 7, 2020 at 11:09 PM Michal Hocko wrote: > > On Mon 07-12-20 20:56:58, Muchun Song wrote: > > On Mon, Dec 7, 2020 at 8:36 PM Michal Hocko wrote: > > > > > > On Sun 06-12-20 16:56:39, Muchun Song wrote: > > > > The vmstat threshold is 32 (MEMCG_CHARGE_BATCH), so the type of s32 > > > >

Re: [PATCH v2 2/3] scsi: ufs: Keep device active mode only fWriteBoosterBufferFlushDuringHibernate == 1

2020-12-07 Thread Stanley Chu
On Mon, 2020-12-07 at 13:36 +0800, Stanley Chu wrote: > On Sun, 2020-12-06 at 11:13 +0100, Bean Huo wrote: > > From: Bean Huo > > > > According to the JEDEC UFS 3.1 Spec, If > > fWriteBoosterBufferFlushDuringHibernate > > is set to one, the device flushes the WriteBooster Buffer data

Re: [PATCH 3/4] USB: serial: ftdi_sio: Log the CBUS GPIO validity

2020-12-07 Thread Johan Hovold
On Mon, Dec 07, 2020 at 03:00:37PM +, Marc Zyngier wrote: > On 2020-12-07 14:29, Johan Hovold wrote: > > On Fri, Dec 04, 2020 at 04:47:38PM +, Marc Zyngier wrote: > >> + if (!bitmap_full(valid_mask, ngpios)) > >> + dev_warn_once(>dev, "Consider using a tool such as > >>

Re: [RFC PATCH v1 07/12] efi: Replace strstarts() by str_has_prefix().

2020-12-07 Thread Steven Rostedt
On Sat, 05 Dec 2020 15:04:31 -0800 James Bottomley wrote: > Well, I think the pattern > > if (strstarts(option, )) { >... >option += strlen(); > > is a bad one because one day may get updated but not string>. And if is too far away in the code it might not > even show up in the

Re: [External] Re: [PATCH] mm: memcontrol: optimize per-lruvec stats counter memory usage

2020-12-07 Thread Michal Hocko
On Mon 07-12-20 20:56:58, Muchun Song wrote: > On Mon, Dec 7, 2020 at 8:36 PM Michal Hocko wrote: > > > > On Sun 06-12-20 16:56:39, Muchun Song wrote: > > > The vmstat threshold is 32 (MEMCG_CHARGE_BATCH), so the type of s32 > > > of lruvec_stat_cpu is enough. And introduce struct

Re: [patch V2 4/9] softirq: Make softirq control and processing RT aware

2020-12-07 Thread Thomas Gleixner
On Mon, Dec 07 2020 at 15:16, Frederic Weisbecker wrote: > On Fri, Dec 04, 2020 at 06:01:55PM +0100, Thomas Gleixner wrote: >> +void __local_bh_disable_ip(unsigned long ip, unsigned int cnt) >> +{ >> +unsigned long flags; >> +int newcnt; >> + >> +WARN_ON_ONCE(in_hardirq()); >> + >> +

[PATCH][next] drm/mediatek: avoid dereferencing a null hdmi_phy on an error message

2020-12-07 Thread Colin King
From: Colin Ian King Currently there is a null pointer check for hdmi_phy that implies it may be null, however a dev_err messages dereferences this potential null pointer. Avoid a null pointer dereference by only emitting the dev_err message if hdmi_phy is non-null. It is a moot point if the

Re: [PATCH 0/4] USB: ftdio_sio: GPIO validity fixes

2020-12-07 Thread Johan Hovold
On Mon, Dec 07, 2020 at 02:41:03PM +, Marc Zyngier wrote: > On 2020-12-07 14:01, Johan Hovold wrote: > > On Fri, Dec 04, 2020 at 04:47:35PM +, Marc Zyngier wrote: > >> Having recently tried to use the CBUS GPIOs that come thanks to the > >> ftdio_sio driver, it occurred to me that the

Re: [PATCH 3/4] sched/fair: Return an idle cpu if one is found after a failed search for an idle core

2020-12-07 Thread Vincent Guittot
On Mon, 7 Dec 2020 at 10:15, Mel Gorman wrote: > > select_idle_core is called when SMT is active and there is likely a free > core available. It may find idle CPUs but this information is simply > discarded and the scan starts over again with select_idle_cpu. > > This patch caches information on

Re: [PATCH 2/2] f2fs: don't check PAGE_SIZE again in sanity_check_raw_super()

2020-12-07 Thread Chao Yu
On 2020/12/7 18:59, liush wrote: From: Yangtao Li Many flash devices read and write a single IO based on a multiple of 4KB, and we support only 4KB page cache size now. Since we already check page size in init_f2fs_fs(), so remove page size check in sanity_check_raw_super(). Signed-off-by:

Re: [PATCH 1/4] sched/fair: Remove SIS_AVG_CPU

2020-12-07 Thread Vincent Guittot
On Mon, 7 Dec 2020 at 10:15, Mel Gorman wrote: > > SIS_AVG_CPU was introduced as a means of avoiding a search when the > average search cost indicated that the search would likely fail. It > was a blunt instrument and disabled by 4c77b18cf8b7 ("sched/fair: Make > select_idle_cpu() more

Re: Fair Pay: Some interesting observations of symboldevelopment, Uni / I-T

2020-12-07 Thread Ywe Cærlyn
Buas also, for related languages (for instance Czech). Updated this: https://youtu.be/7AJAHSoQJGc Den 07.12.2020 10:19, skrev Ywe Cærlyn: I'm sorry, SINU it may be. Having disassociated the christian god, we can clearly see it is mad, and in the way of correct commerciality. It is a

Re: [PATCH] dpaa2-mac: Add a missing of_node_put after of_device_is_available

2020-12-07 Thread Ioana Ciornei
On Sun, Dec 06, 2020 at 04:13:39PM +0100, Christophe JAILLET wrote: > Add an 'of_node_put()' call when a tested device node is not available. > > Fixes:94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module") > Signed-off-by: Christophe JAILLET Reviewed-by: Ioana Ciornei Thanks!

Re: [RFC PATCH 0/4] Reduce worst-case scanning of runqueues in select_idle_sibling

2020-12-07 Thread Vincent Guittot
On Mon, 7 Dec 2020 at 10:15, Mel Gorman wrote: > > This is a minimal series to reduce the amount of runqueue scanning in > select_idle_sibling in the worst case. > > Patch 1 removes SIS_AVG_CPU because it's unused. > > Patch 2 improves the hit rate of p->recent_used_cpu to reduce the amount >

Re: [PATCH] io_uring: fix file leak on creating io ctx

2020-12-07 Thread Jens Axboe
On 12/7/20 1:15 AM, Hillf Danton wrote: > Put file as part of error handling when setting up io ctx to fix > memory leak like the following one. > >BUG: memory leak >unreferenced object 0x888101ea2200 (size 256): > comm "syz-executor355", pid 8470, jiffies 4294953658 (age

Re: [PATCH 1/2] f2fs: convert to F2FS_*_INO macro

2020-12-07 Thread Chao Yu
On 2020/12/7 18:59, liush wrote: From: Yangtao Li Use F2FS_ROOT_INO, F2FS_NODE_INO and F2FS_META_INO macro for better code readability. Signed-off-by: Yangtao Li Signed-off-by: Shaohua Liu Reviewed-by: Chao Yu Thanks,

Re: [External] Re: [RESEND PATCH v2 00/12] Convert all vmstat counters to pages or bytes

2020-12-07 Thread Michal Hocko
On Mon 07-12-20 22:52:30, Muchun Song wrote: > On Mon, Dec 7, 2020 at 9:00 PM Michal Hocko wrote: > > > > On Sun 06-12-20 18:14:39, Muchun Song wrote: > > > Hi, > > > > > > This patch series is aimed to convert all THP vmstat counters to pages > > > and some KiB vmstat counters to bytes. > > > >

Re: [PATCH][next] block/rnbd: fix a null pointer dereference on dev->blk_symlink_name

2020-12-07 Thread Jinpu Wang
On Mon, Dec 7, 2020 at 4:01 PM Jens Axboe wrote: > > On 12/7/20 7:54 AM, Colin King wrote: > > From: Colin Ian King > > > > Currently in the case where dev->blk_symlink_name fails to be allocates > > the error return path attempts to set an end-of-string character to > > the unallocated

Re: [PATCH][next] block/rnbd: fix a null pointer dereference on dev->blk_symlink_name

2020-12-07 Thread Jens Axboe
On 12/7/20 7:54 AM, Colin King wrote: > From: Colin Ian King > > Currently in the case where dev->blk_symlink_name fails to be allocates > the error return path attempts to set an end-of-string character to > the unallocated dev->blk_symlink_name causing a null pointer dereference > error. Fix

Re: [PATCH 3/4] USB: serial: ftdi_sio: Log the CBUS GPIO validity

2020-12-07 Thread Marc Zyngier
On 2020-12-07 14:29, Johan Hovold wrote: On Fri, Dec 04, 2020 at 04:47:38PM +, Marc Zyngier wrote: The validity of the ftdi CBUS GPIO is pretty hidden so far, and finding out *why* some GPIOs don't work is sometimes hard to identify. So let's help the user by displaying the map of the CBUS

Re: [PATCH 1/4] gpiolib: cdev: Flag invalid GPIOs as used

2020-12-07 Thread Marc Zyngier
On 2020-12-07 14:16, Johan Hovold wrote: On Fri, Dec 04, 2020 at 04:47:36PM +, Marc Zyngier wrote: When reporting the state of a GPIO to userspace, we never check for the actual validity of the line, meaning we report invalid lines as being usable. A subsequent request will fail though,

Re: [PATCH v2 0/5] Some cleanups and improvements for blk-iocost

2020-12-07 Thread Jens Axboe
On 11/26/20 1:16 AM, Baolin Wang wrote: > Hi, > > This patch set did some cleanups and improvements for blk-iocost, and > no big functional changes. Please help to review. Thanks. > > Changes from v1: > - Add acked-by tag from Tejun. > - Drop 2 unnecessary patches. > - Move the related

Re: [PATCH v10 7/8] powerpc: Move arch_ima_add_kexec_buffer to ima

2020-12-07 Thread Mimi Zohar
On Sun, 2020-12-06 at 18:03 -0800, Lakshmi Ramasubramanian wrote: > On 12/5/20 1:36 PM, Thiago Jung Bauermann wrote: > > > > Lakshmi Ramasubramanian writes: > > >> diff --git a/security/integrity/ima/ima_kexec.c > >> b/security/integrity/ima/ima_kexec.c > >> index 4d354593aecf..5263dafe8f4d

Re: [PATCH v2 2/2] platform/x86/drivers/acerhdf: Check the interval value when it is set

2020-12-07 Thread Hans de Goede
Hi, On 12/4/20 12:43 PM, Daniel Lezcano wrote: > On 03/12/2020 22:22, Peter Kästle wrote: >> 3. Dezember 2020 08:17, "Daniel Lezcano" schrieb: >> >>> Currently the code checks the interval value when the temperature is >>> read which is bad for two reasons: >>> >>> - checking and setting the

Re: [RFC PATCH v2 0/2] add simple copy support

2020-12-07 Thread Hannes Reinecke
On 12/7/20 3:11 PM, Christoph Hellwig wrote: So, I'm really worried about: a) a good use case. GC in f2fs or btrfs seem like good use cases, as does accelating dm-kcopyd. I agree with Damien that lifting dm-kcopyd to common code would also be really nice. I'm not 100% sure it

[PATCH][next] block/rnbd: fix a null pointer dereference on dev->blk_symlink_name

2020-12-07 Thread Colin King
From: Colin Ian King Currently in the case where dev->blk_symlink_name fails to be allocates the error return path attempts to set an end-of-string character to the unallocated dev->blk_symlink_name causing a null pointer dereference error. Fix this by returning with an explicity ENOMEM error

Re: [External] Re: [RESEND PATCH v2 00/12] Convert all vmstat counters to pages or bytes

2020-12-07 Thread Muchun Song
On Mon, Dec 7, 2020 at 9:00 PM Michal Hocko wrote: > > On Sun 06-12-20 18:14:39, Muchun Song wrote: > > Hi, > > > > This patch series is aimed to convert all THP vmstat counters to pages > > and some KiB vmstat counters to bytes. > > > > The unit of some vmstat counters are pages, some are bytes,

[PATCH v1 2/6] drm/sprd: add Unisoc's drm kms master

2020-12-07 Thread Kevin Tang
Adds drm support for the Unisoc's display subsystem. This is drm kms driver, this driver provides support for the application framework in Android, Yocto and more. Application framework can access Unisoc's display internel peripherals through libdrm or libkms, it's test ok by modetest (DRM/KMS

Re: [PATCH][next] arm64: fix the mm build error in mm/kfence/core.c

2020-12-07 Thread Marco Elver
On Sun, 6 Dec 2020 at 23:08, Marco Elver wrote: > On Sun, 6 Dec 2020 at 22:23, Stephen Rothwell wrote: [...] > > > ../arch/arm64/include/asm/kfence.h:12:2: error: implicit declaration of > > > function ‘set_memory_valid’ [-Werror=implicit-function-declaration] > > >12 |

[PATCH v1 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2020-12-07 Thread Kevin Tang
Adds dsi host controller support for the Unisoc's display subsystem. Adds dsi phy support for the Unisoc's display subsystem. Only MIPI DSI Displays supported, DP/TV/HMDI will be support in the feature. v1: - Remove dphy and dsi graph binding, merge the dphy driver into the dsi. Cc: Orson Zhai

[PATCH v1 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2020-12-07 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Controller support for Unisoc's display subsystem. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../display/sprd/sprd,sharkl3-dsi-host.yaml| 107 + 1 file changed, 107 insertions(+) create mode 100644

[PATCH v1 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-12-07 Thread Kevin Tang
Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Kconfig| 1 + drivers/gpu/drm/sprd/Makefile | 6

[PATCH v1 3/6] dt-bindings: display: add Unisoc's dpu bindings

2020-12-07 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../bindings/display/sprd/sprd,sharkl3-dpu.yaml

[PATCH v1 0/6] Add Unisoc's drm kms module

2020-12-07 Thread Kevin Tang
ChangeList: RFC v1: 1. only upstream modeset and atomic at first commit. 2. remove some unused code; 3. use alpha and blend_mode properties; 3. add yaml support; 4. remove auto-adaptive panel driver; 5. bugfix RFC v2: 1. add sprd crtc and plane module for KMS, preparing for multi crtc 2. remove

[PATCH v1 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-12-07 Thread Kevin Tang
From: Kevin Tang The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem Unisoc's display pipeline have several components as below description, multi display controllers and corresponding physical

Re: [PATCH] PCI: dwc: exynos: add back MSI dependency

2020-12-07 Thread Arnd Bergmann
On Mon, Dec 7, 2020 at 3:23 PM Rob Herring wrote: > On Fri, Dec 4, 2020 at 10:58 AM Arnd Bergmann wrote: > > diff --git a/drivers/pci/controller/dwc/Kconfig > > b/drivers/pci/controller/dwc/Kconfig > > index 020101b58155..e403bb2eeb4c 100644 > > --- a/drivers/pci/controller/dwc/Kconfig > > +++

Re: [PATCH] vfio iommu type1: Bypass the vma permission check in vfio_pin_pages_remote()

2020-12-07 Thread Stefan Hajnoczi
On Thu, Dec 03, 2020 at 05:01:32PM +0100, David Hildenbrand wrote: > The real question is: do we even *need* DMA from vfio devices to > virtio-fs regions? If not (do guests rely on it? what does the spec > state?), just don't care about vfio at all and don't map anything. Can DMA to/from the

Re: [PATCH v5 0/2] MTE support for KVM guest

2020-12-07 Thread Steven Price
On 04/12/2020 08:25, Haibo Xu wrote: On Fri, 20 Nov 2020 at 17:51, Steven Price wrote: On 19/11/2020 19:11, Marc Zyngier wrote: On 2020-11-19 18:42, Andrew Jones wrote: On Thu, Nov 19, 2020 at 03:45:40PM +, Peter Maydell wrote: On Thu, 19 Nov 2020 at 15:39, Steven Price wrote: This

Re: [PATCH v14 09/10] arch, mm: wire up memfd_secret system call were relevant

2020-12-07 Thread Qian Cai
On Thu, 2020-12-03 at 08:29 +0200, Mike Rapoport wrote: > From: Mike Rapoport > > Wire up memfd_secret system call on architectures that define > ARCH_HAS_SET_DIRECT_MAP, namely arm64, risc-v and x86. > > Signed-off-by: Mike Rapoport > Acked-by: Palmer Dabbelt > Acked-by: Arnd Bergmann > ---

Re: [PATCH v6 1/2] arm64: kvm: Save/restore MTE registers

2020-12-07 Thread Steven Price
On 03/12/2020 17:07, Marc Zyngier wrote: diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h index e2ef4c2edf06..b6668ffa04d9 100644 --- a/arch/arm64/include/asm/sysreg.h +++ b/arch/arm64/include/asm/sysreg.h @@ -569,7 +569,8 @@  #define SCTLR_ELx_M    (BIT(0))  

[PATCH][next] seg6: fix unintentional integer overflow on left shift

2020-12-07 Thread Colin King
From: Colin Ian King Shifting the integer value 1 is evaluated using 32-bit arithmetic and then used in an expression that expects a unsigned long value leads to a potential integer overflow. Fix this by using the BIT macro to perform the shift to avoid the overflow. Addresses-Coverity:

Re: [patch V2 2/9] irqtime: Make accounting correct on RT

2020-12-07 Thread Thomas Gleixner
On Mon, Dec 07 2020 at 14:27, Frederic Weisbecker wrote: > On Fri, Dec 04, 2020 at 06:01:53PM +0100, Thomas Gleixner wrote: >> vtime_account_irq and irqtime_account_irq() base checks on preempt_count() >> which fails on RT because preempt_count() does not contain the softirq >> accounting which is

Re: [External] [PATCH] mm/page_alloc: simplify kmem cgroup charge/uncharge code

2020-12-07 Thread Muchun Song
On Mon, Dec 7, 2020 at 10:22 PM Hui Su wrote: > > Since the commit 60cd4bcd6238 ("memcg: localize memcg_kmem_enabled() > check"), we have supplied the api which users don't have to explicitly > check memcg_kmem_enabled(). > > Signed-off-by: Hui Su Reviewed-by: Muchun Song > --- >

Re: tick/sched: Make jiffies update quick check more robust

2020-12-07 Thread Thomas Gleixner
On Mon, Dec 07 2020 at 10:59, Peter Zijlstra wrote: >> +if (IS_ENABLED(CONFIG_64BIT)) { >> +if (ktime_before(now, smp_load_acquire(_next_period))) >> +return; > > Explicit ACQUIRE > >> +} else { >> +unsigned int seq; >> + >> +/* >> +

Re: KVM_SET_CPUID doesn't check supported bits (was Re: [PATCH 0/6] KVM: x86: KVM_SET_SREGS.CR4 bug fixes and cleanup)

2020-12-07 Thread stsp
07.12.2020 17:34, Paolo Bonzini пишет: > It is too late to change that aspect of the API, unfortunately. We > don't know how various userspaces would behave. Which means some sensible behaviour already exists if I don't call KVM_SET_CPUID2. So what is it, #UD on CPUID? I

[PATCH] mm/page_alloc: simplify kmem cgroup charge/uncharge code

2020-12-07 Thread Hui Su
Since the commit 60cd4bcd6238 ("memcg: localize memcg_kmem_enabled() check"), we have supplied the api which users don't have to explicitly check memcg_kmem_enabled(). Signed-off-by: Hui Su --- mm/page_alloc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [PATCH 0/4] USB: ftdio_sio: GPIO validity fixes

2020-12-07 Thread Marc Zyngier
On 2020-12-07 14:01, Johan Hovold wrote: On Fri, Dec 04, 2020 at 04:47:35PM +, Marc Zyngier wrote: Having recently tried to use the CBUS GPIOs that come thanks to the ftdio_sio driver, it occurred to me that the driver has a couple of usability issues: - it advertises potential GPIOs that

RE: [PATCH RESEND] misc/vmw_vmci: bail out earlier on too big queue allocation

2020-12-07 Thread Jorgen Hansen
From: Stefano Garzarella Sent: Wednesday, December 2, 2020 2:06 AM > > On Tue, Dec 1, 2020 at 9:21 PM Arnd Bergmann wrote: > > > > On Mon, Nov 23, 2020 at 10:01 PM Norbert Slusarek > wrote: > > > > > > From: Norbert Slusarek > > > Date: Mon, 23 Nov 2020 21:53:41 +0100 > > > Subject: [PATCH

[V9fs-developer][PATCH v2] 9p: create writeback fid on shared writable mmap

2020-12-07 Thread Chengguang Xu
If vma is shared and the file was opened for writing, we should also create writeback fid because vma may be mprotected writable even if now readonly. Signed-off-by: Chengguang Xu --- fs/9p/vfs_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/9p/vfs_file.c

[PATCH] arch: fix 'unexpected IRQ trap at vector' warnings

2020-12-07 Thread Enrico Weigelt, metux IT consult
All archs, except Alpha, print out the irq number in hex, but the message looks like it was a decimal number, which is quite confusing. Fixing this by adding "0x" prefix. Signed-off-by: Enrico Weigelt, metux IT consult --- arch/arm/include/asm/hw_irq.h | 2 +-

<    5   6   7   8   9   10   11   12   13   14   >