The clocks are configured by devm_clk_bulk_get_all() in this driver. In
case of any error the clocks freeing will be handled automatically.
There is no need to explicitly free the clocks. Fix the same.
Fixes: 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms")
Signed-off-by: Man
The kernel-doc run gave a warning for Xilinx DWC3 driver:
drivers/usb/dwc3/dwc3-xilinx.c:27: warning: expecting prototype for
dwc3(). Prototype was for XLNX_USB_PHY_RST_EN() instead
Basically it was due to an extra '*' in line:2. This patch fixes the same.
Signed-off-by: Manish Narani
Reported
This patch series resolves a kernel-doc warning and a clk freeing bug
that was causing a crash.
This patch series is on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/usb/dwc3?id=84770f028fabab4cb66188d583ed12652f30576b
Manish Narani (2):
usb: dwc3
Hi Laurent,
Thank you so much for the review.
> -Original Message-
> From: Laurent Pinchart
> Sent: Wednesday, March 24, 2021 8:38 AM
> To: Manish Narani
> Cc: kis...@ti.com; vk...@kernel.org; Michal Simek ;
> linux-kernel@vger.kernel.org; linux-arm-ker...@lists.
The current driver is not handling the clock enable/disable operations
properly. The clocks need to be handled correctly by enabling or
disabling at appropriate places. This patch adds code to handle the
same.
Signed-off-by: Manish Narani
Reviewed-by: Laurent Pinchart
---
drivers/phy/xilinx
The current driver is not handling the clock enable/disable operations
properly. The clocks need to be handled correctly by enabling or
disabling at appropriate places. This patch adds code to handle the
same.
Signed-off-by: Manish Narani
---
drivers/phy/xilinx/phy-zynqmp.c | 57
Gentle Ping!
> -Original Message-
> From: Manish Narani
> Sent: Tuesday, March 9, 2021 4:48 PM
> To: laurent.pinch...@ideasonboard.com; kis...@ti.com; vk...@kernel.org;
> Michal Simek
> Cc: linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; git
Add documentation for Versal DWC3 controller. Add required property
'reg' for the same. Also add optional properties for snps,dwc3.
Signed-off-by: Manish Narani
Reviewed-by: Rob Herring
---
.../devicetree/bindings/usb/dwc3-xilinx.txt| 28 --
1 file changed, 26
should be changed to PIPE clock in order to make the USB
controller work. There is a register added in Xilinx USB controller
register space for the same.
Signed-off-by: Manish Narani
---
drivers/usb/dwc3/Kconfig | 9 +
drivers/usb/dwc3/Makefile | 1 +
drivers/usb/dwc3/dwc3
for devm_phy_get
- Documented resets in dt-bindings
Manish Narani (2):
dt-bindings: usb: dwc3-xilinx: Add documentation for Versal DWC3
Controller
usb: dwc3: Add driver for Xilinx platforms
.../devicetree/bindings/usb/dwc3-xilinx.txt| 28 +-
drivers/usb/dwc3/Kconfig
The current driver is not handling the clock enable/disable operations
properly. The clocks need to be handled correctly by enabling or
disabling at appropriate places. This patch adds code to handle the
same.
Signed-off-by: Manish Narani
---
drivers/phy/xilinx/phy-zynqmp.c | 57
Hi Laurent,
Thank you for the review.
> -Original Message-
> From: Laurent Pinchart
> Sent: Tuesday, March 9, 2021 1:37 AM
> To: Manish Narani
> Cc: Anurag Kumar Vulisha ; kis...@ti.com;
> vk...@kernel.org; Michal Simek ; linux-
> ker...@vger.kern
The current driver is not handling the clock enable/disable operations
properly. The clocks need to be handled correctly by enabling or
disabling at appropriate places. This patch adds code to handle the
same.
Signed-off-by: Manish Narani
---
drivers/phy/xilinx/phy-zynqmp.c | 40
HI Michael,
> -Original Message-
> From: Michael Grzeschik
> Sent: Monday, February 22, 2021 9:01 PM
> To: Manish Narani
> Cc: gre...@linuxfoundation.org; robh...@kernel.org; Michal Simek
> ; ba...@kernel.org; p.za...@pengutronix.de;
> devicet...@v
Hi Michael,
> -Original Message-
> From: Michael Grzeschik
> Sent: Tuesday, February 9, 2021 5:26 AM
> To: Manish Narani
> Cc: devicet...@vger.kernel.org; p.za...@pengutronix.de; ba...@kernel.org;
> gre...@linuxfoundation.org; linux-...@vger.kernel.org; linux-
> k
Hi Michael,
> -Original Message-
> From: Michael Grzeschik
> Sent: Friday, January 22, 2021 1:39 PM
> To: Manish Narani
> Cc: devicet...@vger.kernel.org; ker...@pengutronix.de; ba...@kernel.org;
> gre...@linuxfoundation.org; linux-...@vger.kernel.org; Michal Sime
should be changed to PIPE clock in order to make the USB
controller work. There is a register added in Xilinx USB controller
register space for the same.
Signed-off-by: Manish Narani
---
drivers/usb/dwc3/Kconfig | 9 +
drivers/usb/dwc3/Makefile | 1 +
drivers/usb/dwc3/dwc3
Add documentation for Versal DWC3 controller. Add required property
'reg' for the same. Also add optional properties for snps,dwc3.
Signed-off-by: Manish Narani
Reviewed-by: Rob Herring
---
.../devicetree/bindings/usb/dwc3-xilinx.txt | 17 +++--
1 file changed, 15 insertions
- Improved description of some register operations to avoid
confusion
- Updated commit log for patch 2/2 for better clarity.
Changes in v3:
- Removed snps,enable-hibernation property from the devicetree
binding.
Manish Narani (2):
dt-bindings: usb: dwc3
Hi Uffe/Michal,
> -Original Message-
> From: Michal Simek
> Sent: Wednesday, November 18, 2020 11:54 PM
> To: Ulf Hansson ; Manish Narani
>
> Cc: Michal Simek ; Adrian Hunter
> ; Linux ARM ker...@lists.infradead.org>; linux-...@vger.kernel.org; Linux Ker
Driver should be able to handle optional pinctrl setting.
Signed-off-by: Michal Simek
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c
b/drivers/mmc/host/sdhci
. This patch fixes the issue where there is a check that RX packet
length must not be more than max packet length.
Fixes: bba787a860fa ("usb: gadget: ether: Allow jumbo frames")
Signed-off-by: Manish Narani
---
drivers/usb/gadget/function/u_ether.c | 9 +
1 file changed, 5 insert
Fix the SD DLL node reset issue where incorrect node is being referenced
instead of SD DLL node.
Fixes: 426c8d85df7a ("firmware: xilinx: Use APIs instead of IOCTLs")
Signed-off-by: Manish Narani
---
drivers/firmware/xilinx/zynqmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
Hi,
> -Original Message-
> From: Manish Narani
> Sent: Tuesday, November 10, 2020 11:12 PM
> To: Michal Simek ; adrian.hun...@intel.com;
> ulf.hans...@linaro.org
> Cc: linux-arm-ker...@lists.infradead.org; linux-...@vger.kernel.org; linux-
> ker...@vger.kernel.org
Mask the ITAP and OTAP delay bits before updating with the new
tap value for Versal platform.
Fixes: 1a470721c8f5 ("sdhci: arasan: Add support for Versal Tap Delays")
Signed-off-by: Sai Krishna Potthuri
Signed-off-by: Manish Narani
Acked-by: Michal Simek
---
drivers/mmc/host/sdhci-o
t;)
Signed-off-by: Sai Krishna Potthuri
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 40 ++
1 file changed, 8 insertions(+), 32 deletions(-)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c
b/drivers/mmc/host/sdhci-of-arasan.c
index 82
.
This patch update host driver to explicitly request for DLL reset
before ITAP (assert DLL) and after OTAP (release DLL) settings.
Fixes: a5c8b2ae2e51 ("mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap
Delays Setup")
Signed-off-by: Sai Krishna Potthuri
Signed-off-by: Manish Narani
--
- Merged https://lore.kernel.org/patchwork/patch/1336342/
with this series of patches
Manish Narani (3):
mmc: sdhci-of-arasan: Allow configuring zero tap values
mmc: sdhci-of-arasan: Use Mask writes for Tap delays
mmc: sdhci-of-arasan: Issue DLL reset explicitly
drivers/mmc/host/sdhci
Hi,
> -Original Message-
> From: Manish Narani
> Sent: Tuesday, November 10, 2020 11:12 PM
> To: Michal Simek ; adrian.hun...@intel.com;
> ulf.hans...@linaro.org
> Cc: linux-arm-ker...@lists.infradead.org; linux-...@vger.kernel.org; linux-
> ker...@vger.kernel.org
This patch set consists a couple of minor bug fixes for SDHCI Arasan
driver. The fixes are for tap delay programming where in some cases
tuning is failing for some of the SD cards.
Manish Narani (2):
mmc: sdhci-of-arasan: Use Mask writes for Tap delays
mmc: sdhci-of-arasan: Issue DLL reset
.
This patch update host driver to explicitly request for DLL reset
before ITAP (assert DLL) and after OTAP (release DLL) settings.
Fixes: a5c8b2ae2e51 ("mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap
Delays Setup")
Signed-off-by: Sai Krishna Potthuri
Signed-off-by: Manish Narani
--
Mask the ITAP and OTAP delay bits before updating with the new
tap value for Versal platform.
Fixes: 1a470721c8f5 ("sdhci: arasan: Add support for Versal Tap Delays")
Signed-off-by: Sai Krishna Potthuri
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 5 +++
Allow configuring the Output and Input tap values with zero to avoid
failures in some cases (one of them is SD boot mode) where the output
and input tap values may be already set to non-zero.
Signed-off-by: Sai Krishna Potthuri
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci
Ping!
> -Original Message-
> From: Manish Narani
> Sent: Thursday, October 8, 2020 6:37 PM
> To: gre...@linuxfoundation.org; robh...@kernel.org; Michal Simek
> ; ba...@kernel.org; p.za...@pengutronix.de
> Cc: linux-...@vger.kernel.org; devicet...@vger.kernel.org
should be changed to PIPE clock in order to make the USB
controller work. There is a register added in Xilinx USB controller
register space for the same.
Signed-off-by: Manish Narani
---
drivers/usb/dwc3/Kconfig | 9 +
drivers/usb/dwc3/Makefile | 1 +
drivers/usb/dwc3/dwc3
Add documentation for Versal DWC3 controller. Add required property
'reg' for the same. Also add optional properties for snps,dwc3.
Signed-off-by: Manish Narani
---
.../devicetree/bindings/usb/dwc3-xilinx.txt | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff
- Improved description of some register operations to avoid
confusion
- Updated commit log for patch 2/2 for better clarity.
Changes in v3:
- Removed snps,enable-hibernation property from the devicetree
binding.
Manish Narani (2):
dt-bindings: usb: dwc3
Hi Felipe,
Would you please review this patch? So that in v3, I can include the changes in
the driver if any, along with the binding corrections.
Thanks,
Manish
> -Original Message-
> From: Manish Narani
> Sent: Thursday, September 10, 2020 12:33 AM
> To: gre...@linuxfo
Hi Felipe,
> -Original Message-
> From: Felipe Balbi
> Sent: Friday, September 25, 2020 12:42 PM
> To: Manish Narani ; Rob Herring
> Cc: gre...@linuxfoundation.org; Michal Simek ;
> p.za...@pengutronix.de; linux-...@vger.kernel.org;
> devicet...@vger.kern
Hi Rob/Felipe,
Thanks for the review.
> -Original Message-
> From: Felipe Balbi
> Sent: Thursday, September 24, 2020 12:47 PM
> To: Rob Herring ; Manish Narani
> Cc: gre...@linuxfoundation.org; Michal Simek ;
> p.za...@pengutronix.de; linux-...@vger.ker
should be changed to PIPE clock in order to make the USB
controller work. There is a register added in Xilinx USB controller
register space for the same.
Signed-off-by: Manish Narani
---
drivers/usb/dwc3/Kconfig | 9 +
drivers/usb/dwc3/Makefile | 1 +
drivers/usb/dwc3/dwc3
- Improved description of some register operations to avoid
confusion
- Updated commit log for patch 2/2 for better clarity.
Manish Narani (2):
dt-bindings: usb: dwc3-xilinx: Add documentation for Versal DWC3
Controller
usb: dwc3: Add driver for Xilinx platforms
Add documentation for Versal DWC3 controller. Add required property
'reg' for the same. Also add optional properties for snps,dwc3.
Signed-off-by: Manish Narani
---
.../devicetree/bindings/usb/dwc3-xilinx.txt | 20 +--
1 file changed, 18 insertions(+), 2 deletions(-)
diff
Hi Rob,
Thanks for the review.
> -Original Message-
> From: Rob Herring
> Sent: Wednesday, September 9, 2020 4:35 AM
> To: Manish Narani
> Cc: gre...@linuxfoundation.org; Michal Simek ;
> ba...@kernel.org; p.za...@pengutronix.de; linux-...@vger.kernel.org;
> devic
Hi Felipe,
Thanks for the response.
> -Original Message-
> From: Felipe Balbi
> Sent: Tuesday, September 1, 2020 5:45 PM
>
> >> > +goto err;
> >> > +}
> >> > +
> >> > +ret = dwc3_xlnx_rst_assert(priv_data->apbrst);
> >> > +if (ret < 0) {
> >> > +
Hi Robin,
Thanks for the review. Please find my comment below inline.
> -Original Message-
> From: Robin Murphy
> Sent: Friday, August 28, 2020 12:17 AM
> To: Manish Narani ; gre...@linuxfoundation.org;
> robh...@kernel.org; Michal Simek ; ba...@kernel.org;
> p.za...@p
Hi Felipe,
Thanks for the review. Please find my comments below inline.
> -Original Message-
> From: Felipe Balbi
> Sent: Thursday, August 27, 2020 12:02 PM
> To: Manish Narani ; gre...@linuxfoundation.org;
> robh...@kernel.org; Michal Simek ;
> p.za...@pengutro
Add documentation for Versal DWC3 controller. Add required property
'reg' for the same. Also add optional properties for snps,dwc3.
Signed-off-by: Manish Narani
---
.../devicetree/bindings/usb/dwc3-xilinx.txt | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff
This patch series documents the Xilinx Versal DWC3 controller. This also
adds a new Xilinx specific driver for adding new features in the future.
Manish Narani (2):
dt-bindings: usb: dwc3-xilinx: Add documentation for Versal DWC3
Controller
usb: dwc3: Add driver for Xilinx platforms
Add a new driver for supporting Xilinx platforms. This driver handles
the USB 3.0 PHY initialization and PIPE control & reset operations for
ZynqMP platforms. This also handles the USB 2.0 PHY initialization and
reset operations for Versal platforms.
Signed-off-by: Manish Narani
---
drivers
> -Original Message-
> From: Michal Simek On Behalf Of Michal Simek
> Sent: Monday, August 24, 2020 1:55 PM
> To: linux-kernel@vger.kernel.org; mon...@monstr.eu; Michal Simek
> ; git ; Manish Narani
>
> Cc: Adrian Hunter ; Rob Herring
> ; Ulf Hansson ; Wan Ah
hase & oclk_phase variables.
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 25 ++---
1 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c
b/drivers/mmc/host/sdhci-of-arasan.c
index db9b544..90e42d
Hi Rob,
Thank you so much for the review.
Please find my comments inline below.
Thanks,
Manish
> -Original Message-
> From: Rob Herring
> Sent: Thursday, October 17, 2019 11:53 PM
> To: Manish Narani
> Cc: ulf.hans...@linaro.org; mark.rutl...@arm.com; adrian.hun...@inte
Add the new compatible string for ZynqMP SD Host Controller for its use
in the Arasan SDHCI driver for some of the ZynqMP specific operations.
Add required properties for the same.
Signed-off-by: Manish Narani
---
This patch depends on the below series of patches:
https://lkml.org/lkml/2019/10
dd documentation for 'xlnx,zynqmp-8.9a' SDHCI controller and optional
properties followed by example.
Signed-off-by: Manish Narani
Reviewed-by: Rob Herring
---
.../devicetree/bindings/mmc/arasan,sdhci.txt | 19 +++
1 file changed, 19 insertions(+)
diff --git a/Documentation
Add tap delay nodes for setting SDIO Tap Delays on ZynqMP platform.
Signed-off-by: Manish Narani
---
include/linux/firmware/xlnx-zynqmp.h | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/include/linux/firmware/xlnx-zynqmp.h
b/include/linux/firmware/xlnx
Add optional propeties for Arasan SDHCI which are used to set clk delays
for different speed modes in the controller.
Signed-off-by: Manish Narani
---
.../devicetree/bindings/mmc/arasan,sdhci.txt | 15 +++
1 file changed, 15 insertions(+)
diff --git a/Documentation/devicetree
Add documentation for an optional input clock which is essentially used
in sampling the input data coming from the card.
Signed-off-by: Manish Narani
---
Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
There are some operations like setting the clock delays may need to have
two clocks, one for output path and one for input path. Adding input
path clock for some phys to use.
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 151 +
1 file changed
To improve the code readability, use two different structs, one for
clock provider data and one for mmc platform data.
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 31 --
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/drivers
Apart from taps set by auto tuning, ZynqMP platform has feature to set
the tap values manually. Add support to set tap delay values in HW via
ZynqMP SoC framework.
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 206 -
1 file changed, 204
of the same.
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 91 ++
1 file changed, 91 insertions(+)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c
b/drivers/mmc/host/sdhci-of-arasan.c
index f77f884f44a4..9b2b7b6399b3 100644
--- a/drivers/mmc/host
readable
Changes in v3:
- Reverted "Replaced the deprecated calls to clock framework APIs"
- Removed devm_clk_get() call which was added in v2
Manish Narani (8):
mmc: sdhci-of-arasan: Separate out clk related data to another
structure
dt-bindings: mmc: aras
Hi Heiko/Uffe,
> -Original Message-
> From: Heiko Stuebner
> Sent: Thursday, August 22, 2019 11:53 PM
> To: Ulf Hansson ; linux-...@vger.kernel.org
> Cc: Manish Narani ; Rob Herring ;
> mark.rutl...@arm.com; Michal Simek ;
> adrian.hun...@intel.com; christo
Hi Uffe,
> -Original Message-
> From: Ulf Hansson
> Sent: Thursday, July 25, 2019 6:31 PM
> To: Manish Narani
> Cc: Rob Herring ; mark.rutl...@arm.com;
> he...@sntech.de; Michal Simek ;
> adrian.hun...@intel.com; christoph.muell...@theobroma-systems.com;
> p
Hi Rob,
Thanks a lot for the review!
> -Original Message-
> From: Rob Herring
> Sent: Tuesday, July 23, 2019 3:24 AM
> To: Manish Narani
> Cc: ulf.hans...@linaro.org; mark.rutl...@arm.com; he...@sntech.de; Michal
> Simek ; adrian.hun...@intel.com;
> christo
Gentle Ping!
> -Original Message-
> From: Manish Narani
> Sent: Monday, July 15, 2019 12:46 PM
> To: Manish Narani ; ulf.hans...@linaro.org;
> robh...@kernel.org; mark.rutl...@arm.com; he...@sntech.de; Michal Simek
> ; adrian.hun...@intel.com;
> christoph.muell...@
Ping!
> -Original Message-
> From: Manish Narani
> Sent: Monday, July 1, 2019 11:00 AM
> To: ulf.hans...@linaro.org; robh...@kernel.org; mark.rutl...@arm.com;
> he...@sntech.de; Michal Simek ;
> adrian.hun...@intel.com; christoph.muell...@theobroma-systems.c
Hi Jolly,
> -Original Message-
> From: Jolly Shah
> Sent: Monday, July 1, 2019 11:36 PM
> To: Manish Narani ; ulf.hans...@linaro.org;
> robh...@kernel.org; mark.rutl...@arm.com; he...@sntech.de; Michal Simek
> ; adrian.hun...@intel.com;
> christoph.muell...@
Add the new compatible string for ZynqMP SD Host Controller for its use
in the Arasan SDHCI driver for some of the ZynqMP specific operations.
Add required properties for the same.
Signed-off-by: Manish Narani
---
This patch depends on the below series of patches:
https://lkml.org/lkml/2019/7/1
Add optional propeties for Arasan SDHCI which are used to set clk delays
for different speed modes in the controller.
Signed-off-by: Manish Narani
---
Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 15 +++
1 file changed, 15 insertions(+)
diff --git a/Documentation
Add documentation for an optional input clock which is essentially used
in sampling the input data coming from the card.
Signed-off-by: Manish Narani
---
Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
There are some operations like setting the clock delays may need to have
two clocks, one for output path and one for input path. Adding input
path clock for some phys to use.
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 118 ++---
1 file
readable
This patch series contains a DT patch, which I think should be there to
maintain the order of commits.
Manish Narani (11):
dt-bindings: mmc: arasan: Update documentation for SD Card Clock
arm64: dts: rockchip: Add optional clock property indicating sdcard
clock
mmc: sdhci-of-arasan
.
Signed-off-by: Manish Narani
---
Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
index 1edbb04
of the same.
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 91 ++
1 file changed, 91 insertions(+)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c
b/drivers/mmc/host/sdhci-of-arasan.c
index 9513813..a545221 100644
--- a/drivers/mmc/host/sdhci
Apart from taps set by auto tuning, ZynqMP platform has feature to set
the tap values manually. Add support to set tap delay values in HW via
ZynqMP SoC framework.
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 200 -
1 file changed
As devm_clk_register() is deprecated in the clock framework, it is
mandatory to use devm_clk_get() for getting the clock. This patch adds
sdcard clock which will be used for the same.
Signed-off-by: Manish Narani
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
1 file changed, 2
Add APIs for setting SDIO Tap Delays on ZynqMP platform.
Signed-off-by: Manish Narani
---
drivers/firmware/xilinx/zynqmp.c | 48
include/linux/firmware/xlnx-zynqmp.h | 15 ++-
2 files changed, 62 insertions(+), 1 deletion(-)
diff --git a/drivers
The clk framework APIs devm_clk_register and of_clk_add_provider, which
are used here, are deprecated. Replace the calls with the new API calls.
Also add an API call devm_clk_get() to get the clock from DT.
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 21
Add documentation for 'xlnx,zynqmp-8.9a' SDHCI controller and optional
properties followed by example.
Signed-off-by: Manish Narani
---
.../devicetree/bindings/mmc/arasan,sdhci.txt | 19 +++
1 file changed, 19 insertions(+)
diff --git a/Documentation/devicetree
To improve the code readability, use two different structs, one for
clock provider data and one for mmc platform data.
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 35 +++
1 file changed, 23 insertions(+), 12 deletions(-)
diff --git
Hi Uffe,
> -Original Message-
> From: Ulf Hansson
> Sent: Wednesday, June 19, 2019 8:11 PM
> To: Manish Narani
> Cc: Michal Simek ; Rob Herring ;
> Mark Rutland ; Adrian Hunter
> ; Rajan Vaja ; Jolly Shah
> ; Nava kishore Manne ; Olof
> Johansson ; linu
Hi Uffe,
> -Original Message-
> From: Ulf Hansson
> Sent: Wednesday, June 19, 2019 7:09 PM
> To: Manish Narani
> Cc: Michal Simek ; Rob Herring ;
> Mark Rutland ; Adrian Hunter
> ; Rajan Vaja ; Jolly Shah
> ; Nava kishore Manne ; Olof
> Johansson ; linu
Hi Uffe,
> -Original Message-
> From: Ulf Hansson
> Sent: Monday, June 17, 2019 5:51 PM
[...]
>
> The "const struct zynqmp_eemi_ops *eemi_ops; should then be moved into
> a clock provider specific struct, which is assigned when calling
> sdhci_arasan_register_sdclk. I understand that
Hi Uffe,
Thanks for the review. Please find my comments below.
> -Original Message-
> From: Ulf Hansson
> Sent: Monday, June 17, 2019 8:29 PM
> To: Michal Simek
> Cc: Manish Narani ; Rob Herring
> ; Mark Rutland ; Adrian
> Hunter ; Rajan Vaja ; Jolly
> Shah ; N
Add the new compatible string for ZynqMP SD Host Controller for its use
in the Arasan SDHCI driver for some of the ZynqMP specific operations.
Add required properties for the same.
Signed-off-by: Manish Narani
---
This patch depends on the below series of patches:
https://lkml.org/lkml/2019/6/11
This patch series adds support to configure SD tap delays on ZynqMP platforms
using Xilinx firmware driver and clock framework APIs.
Manish Narani (3):
firmware: xilinx: Add SDIO Tap Delay API
dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller
mmc: sdhci-of-arasan: Add support
-defined Tap Delay Values.
Signed-off-by: Manish Narani
---
drivers/mmc/host/sdhci-of-arasan.c | 173 -
1 file changed, 172 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c
b/drivers/mmc/host/sdhci-of-arasan.c
index b12abf9..7af6cec
Add documentation for 'xlnx,zynqmp-8.9a' SDHCI controller and optional
properties followed by example.
Signed-off-by: Manish Narani
---
.../devicetree/bindings/mmc/arasan,sdhci.txt | 32 ++
1 file changed, 32 insertions(+)
diff --git a/Documentation/devicetree
Add API for setting SDIO Tap Delays on ZynqMP platforms.
Signed-off-by: Manish Narani
---
drivers/firmware/xilinx/zynqmp.c | 32
include/linux/firmware/xlnx-zynqmp.h | 17 -
2 files changed, 48 insertions(+), 1 deletion(-)
diff --git
Xilinx AMS have several ADC channels that can be used for measurement of
different voltages and temperatures. Document the same in the bindings.
Signed-off-by: Manish Narani
---
.../devicetree/bindings/iio/adc/xilinx-ams.txt | 183 +
1 file changed, 183 insertions
channels for measuring
external voltages.
The voltage and temperature monitoring channels also have event
capability which allows to generate an interrupt when their value falls
below or raises above a set threshold.
Signed-off-by: Manish Narani
---
drivers/iio/adc/Kconfig | 10 +
drivers
The Xilinx AMS includes an ADC as well as on-chip sensors that can be
used to sample external and monitor on-die operating conditions, such as
temperature and supply voltage levels.
Signed-off-by: Manish Narani
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 26 ++
1 file
NULL arguments as suggested in v3 patch review
- Addressed comments on Device Tree property naming
Manish Narani (3):
dt-bindings: iio: adc: Add Xilinx AMS binding documentation
iio: adc: Add Xilinx AMS driver
arm64: zynqmp: DT: Add Xilinx AMS node
.../devicetree/bindings/iio/adc/xi
Hi Boris,
> -Original Message-
> From: Borislav Petkov [mailto:b...@alien8.de]
> Sent: Tuesday, November 6, 2018 3:34 PM
> To: Manish Narani
> Cc: robh...@kernel.org; mark.rutl...@arm.com; Michal Simek
> ; mche...@kernel.org; amit.kuche...@linaro.org;
> sudeep.h
Hi Boris,
> -Original Message-
> From: Borislav Petkov [mailto:b...@alien8.de]
> Sent: Tuesday, November 6, 2018 3:34 PM
> To: Manish Narani
> Cc: robh...@kernel.org; mark.rutl...@arm.com; Michal Simek
> ; mche...@kernel.org; amit.kuche...@linaro.org;
> sudeep.h
Ping!
> -Original Message-
> From: Manish Narani [mailto:manish.nar...@xilinx.com]
> Sent: Thursday, October 25, 2018 11:37 AM
> To: robh...@kernel.org; mark.rutl...@arm.com; Michal Simek
> ; b...@alien8.de; mche...@kernel.org; Manish Narani
> ; amit.kuche...@lin
Ping!
> -Original Message-
> From: Manish Narani [mailto:manish.nar...@xilinx.com]
> Sent: Thursday, October 25, 2018 11:37 AM
> To: robh...@kernel.org; mark.rutl...@arm.com; Michal Simek
> ; b...@alien8.de; mche...@kernel.org; Manish Narani
> ; amit.kuche...@lin
Add macro defines for ZynqMP DDR controller. These macros will be used
for ZynqMP ECC operations.
Signed-off-by: Manish Narani
---
drivers/edac/synopsys_edac.c | 168 +++
1 file changed, 168 insertions(+)
diff --git a/drivers/edac/synopsys_edac.c b
1 - 100 of 413 matches
Mail list logo
