Re: [RFC PATCH 08/13] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-08 Thread Richard Genoud
2013/7/8 Bo Shen : > Hi Richard, > > > On 7/5/2013 23:15, Richard Genoud wrote: >>>> >>>> + card->dev = &pdev->dev; >>>> >>+ card->owner = THIS_MODULE; >>>> >>+ card->dai_link = dai; >

Re: [RFC PATCH 08/13] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-05 Thread Richard Genoud
2013/7/5 Mark Brown : > On Fri, Jul 05, 2013 at 05:15:05PM +0200, Richard Genoud wrote: >> 2013/7/2 Bo Shen : > >> >> From: Nicolas Ferre >> >> >> >> Description of the Asoc machine driver for an at91sam9x5 based board >> >> with a wm

Re: [RFC PATCH 03/13] ARM: at91: DTS: sam9x5: add clock for SSC DT entry

2013-07-05 Thread Richard Genoud
2013/7/2 Bo Shen : > Hi Richard, > > > On 7/1/2013 16:39, Richard Genoud wrote: >> >> Signed-off-by: Richard Genoud >> --- >> arch/arm/mach-at91/at91sam9x5.c |1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/mach-

Re: [RFC PATCH 02/13] misc: atmel_ssc: keep the count of pdev->id

2013-07-05 Thread Richard Genoud
2013/7/2 Bo Shen : > Hi Richard, > > > On 7/1/2013 16:39, Richard Genoud wrote: >> >> With device tree, pdev->id is always -1, so we introduce a local >> counter. >> >> Signed-off-by: Richard Genoud >> --- >> drivers/misc/atm

Re: [RFC PATCH 08/13] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-05 Thread Richard Genoud
2013/7/2 Bo Shen : > Hi Richard, > > Will move this patch before 5, 6, 7? yes, you're right. > > > On 7/1/2013 16:39, Richard Genoud wrote: >> >> From: Nicolas Ferre >> >> Description of the Asoc machine driver for an at91sam9x5 based board >

Re: [RFC PATCH 01/13] misc: atmel_ssc: add device tree DMA support

2013-07-05 Thread Richard Genoud
2013/7/5 Bo Shen : > Yes, I aware this issue. > Actually the system not hang, the resource all are occupied by the > interrupt. This because, we enable the interrupt, when once interrupt occur, > I try many methods to clear it, however we can not clear it. So, it > generates the interrupt all the t

Re: [RFC PATCH 01/13] misc: atmel_ssc: add device tree DMA support

2013-07-04 Thread Richard Genoud
2013/7/4 Bo Shen : > Hi Richard, > > > On 7/3/2013 23:51, Richard Genoud wrote: >>> >>> >but there's a violent hang (kernel stops, no trace) when I try the >>> > record : >>> >arecord -v -V stereo -Dplug:default -f cd -t wav -c

Re: [RFC PATCH 01/13] misc: atmel_ssc: add device tree DMA support

2013-07-03 Thread Richard Genoud
2013/7/3 Richard Genoud : > 2013/7/2 Bo Shen : >> Hi Richard, >> >> >> On 7/2/2013 16:13, Richard Genoud wrote: >>>> >>>> Please hold on of this, as to the ASoC dmaengine will deal with this. So, >>>> we >>>> >not ne

Re: [RFC PATCH 01/13] misc: atmel_ssc: add device tree DMA support

2013-07-03 Thread Richard Genoud
2013/7/2 Bo Shen : > Hi Richard, > > > On 7/2/2013 16:13, Richard Genoud wrote: >>> >>> Please hold on of this, as to the ASoC dmaengine will deal with this. So, >>> we >>> >not need do it manually. >>> > >>> >Now,

Re: [RFC PATCH 01/13] misc: atmel_ssc: add device tree DMA support

2013-07-02 Thread Richard Genoud
2013/7/2 Bo Shen : > Hi Richard, > > > On 7/1/2013 16:39, Richard Genoud wrote: >> >> The ssc device has to fill the at_dma_slave structure with the >> device tree informations. >> Doing a of_dma_request_slave_channel()+dma_release_channel() for that >&g

[RFC PATCH 00/13] audio support for at91sam9x5ek board

2013-07-01 Thread Richard Genoud
t;originaly-signed-off-by" since the code has been changed.] Best regards, Richard. Nicolas Ferre (3): sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards sound: atmel_ssc_dai: PM: actually stopping clock on suspend/resume sound: wm8731: rework power management Rich

[RFC PATCH 01/13] misc: atmel_ssc: add device tree DMA support

2013-07-01 Thread Richard Genoud
The ssc device has to fill the at_dma_slave structure with the device tree informations. Doing a of_dma_request_slave_channel()+dma_release_channel() for that seems wrong (or at least not very clean). Signed-off-by: Richard Genoud --- drivers/misc/atmel-ssc.c| 56

[RFC PATCH 02/13] misc: atmel_ssc: keep the count of pdev->id

2013-07-01 Thread Richard Genoud
With device tree, pdev->id is always -1, so we introduce a local counter. Signed-off-by: Richard Genoud --- drivers/misc/atmel-ssc.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c index 3afbd82..d1ec5ab 100644 --- a/drivers/m

[RFC PATCH 04/13] ARM: at91: DTS: sam9x5: add SSC DMA parameters

2013-07-01 Thread Richard Genoud
Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5.dtsi |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi index 57d45f5..cf78ac0 100644 --- a/arch/arm/boot/dts/at91sam9x5.dtsi +++ b/arch/arm/boot/dts

[RFC PATCH 07/13] ARM: AT91: DTS: sam9x5ek: enable SSC

2013-07-01 Thread Richard Genoud
Enable the SSC needed for the WM8731 codec Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index 77e4073..4f3584c 100644 --- a/arch/arm

[RFC PATCH 06/13] ARM: AT91: DTS: sam9x5ek: add sound configuration

2013-07-01 Thread Richard Genoud
The sam9x5ek board has 2 jacks: headphone wired on RHPOUT/LHPOUT of the wm8731 line in wired on LLINEIN/RLINEIN of the wm8731 Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts

[RFC PATCH 12/13] sound: wm8731: rework power management

2013-07-01 Thread Richard Genoud
From: Nicolas Ferre - preserve crystal oscillator across suspend/resume sequence: enabled by default,it should be kept enabled on resume. - if codec is in active state: set the active bit at resume time. Signed-off-by: Nicolas Ferre Signed-off-by: Uwe Kleine-König --- sound/soc/codecs/wm873

[RFC PATCH 09/13] sound: atmel-pcm: don't return ok if pcm-dma is not implemented

2013-07-01 Thread Richard Genoud
If DMA is not selected, atmel_pcm_dma_platform_register() should fail. Like that, the driver knows it can't use it. Signed-off-by: Richard Genoud --- sound/soc/atmel/atmel-pcm.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/atmel/atmel-pcm.h b/sound/soc/

[RFC PATCH 05/13] ARM: AT91: DTS: sam9x5ek: add WM8731 codec

2013-07-01 Thread Richard Genoud
The WM8731 codec on sam9x5ek board is on i2c, address 1A Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/at91sam9x5ek.dtsi b/arch/arm/boot/dts/at91sam9x5ek.dtsi index b753855..a81a1a6 100644

[RFC PATCH 08/13] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-01 Thread Richard Genoud
from Nicolas that I forward ported and reworked to use only device tree] Signed-off-by: Nicolas Ferre Signed-off-by: Uwe Kleine-König Signed-off-by: Richard Genoud --- sound/soc/atmel/Kconfig | 12 ++ sound/soc/atmel/Makefile|2 + sound/soc/atmel/sam9x5_wm8731.c | 232

[RFC PATCH 03/13] ARM: at91: DTS: sam9x5: add clock for SSC DT entry

2013-07-01 Thread Richard Genoud
Signed-off-by: Richard Genoud --- arch/arm/mach-at91/at91sam9x5.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-at91/at91sam9x5.c b/arch/arm/mach-at91/at91sam9x5.c index 2abee66..191eb4b 100644 --- a/arch/arm/mach-at91/at91sam9x5.c +++ b/arch/arm/mach-at91/at91sam9x5.c

[RFC PATCH 10/13] sound: atmel_ssc_dai: PM: actually stopping clock on suspend/resume

2013-07-01 Thread Richard Genoud
From: Nicolas Ferre Stop SSC clock on suspend/resume cycle checking if the controller is actually initialized. This will save power while sleeping. Signed-off-by: Nicolas Ferre Signed-off-by: Uwe Kleine-König --- sound/soc/atmel/atmel_ssc_dai.c | 20 +--- 1 file changed, 13

[RFC PATCH 13/13] sound: codec: wm8371: correct capture line/mic

2013-07-01 Thread Richard Genoud
With the "switch" text, we can't enable the line and mic capture in alsamixer. Signed-off-by: Richard Genoud --- sound/soc/codecs/wm8731.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c index 3

[RFC PATCH 11/13] sound: atmel-pcm-dma: check pointer before dereference

2013-07-01 Thread Richard Genoud
If platform_data is NULL, filter() is called with a NULL slave parameter. Signed-off-by: Richard Genoud --- sound/soc/atmel/atmel-pcm-dma.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/atmel/atmel-pcm-dma.c b/sound/soc/atmel/atmel-pcm-dma.c index 1d38fd0..b20dbba 100644

Re: rtl8192cu: slow path warning

2013-06-28 Thread Richard GENOUD
On [jeu., 27.06.2013 13:20:52], Larry Finger wrote: > On 06/27/2013 02:33 AM, Richard Genoud wrote: > >Yes, of course, you can add my > >Reported-by: Richard Genoud > > > >But the patch doesn't compile on my platform ( since I'm on ARM, I > >haven't

Re: RTL8192CU on ARM not working

2013-06-27 Thread Richard Genoud
2013/6/27 Maxime Ripard : > Hi everyone, > > I'm currently trying to use a RTL8192CU on an ARM (Freescale imx28, > armv5) platform, using 3.10-rc3. > > Trouble is, while the chip is correctly detected and you can use iw on it > without any problem it seems, once you start an association to an acces

Re: rtl8192cu: slow path warning

2013-06-27 Thread Richard Genoud
2013/6/26 Larry Finger : > On 06/26/2013 09:22 AM, Richard GENOUD wrote: >> >> Using 3.10-rc7, I'm still seeing the warning, BUT ONLY on the first >> connection. >> >> [ 40.312500] usb 2-2: default language 0x0409 >> [ 40.312500] usb 2-2: udev 2, bus

rtl8192cu: slow path warning

2013-06-26 Thread Richard GENOUD
On [mar., 11.06.2013 14:38:15], Richard GENOUD wrote: > Hi, > > I've got an usb wireless adapter TP-Link TL-WN725N > http://www.tp-link.com/ca/products/details/?categoryid=241&model=TL-WN725N > It is based on the rtl8192cu chip. > I'm running a recent kernel

Re: rtl8192cu: slow path warning and connection problem v3.10-rc5

2013-06-11 Thread Richard Genoud
2013/6/11 Richard GENOUD : > Hi, > > I've got an usb wireless adapter TP-Link TL-WN725N > http://www.tp-link.com/ca/products/details/?categoryid=241&model=TL-WN725N > It is based on the rtl8192cu chip. > I'm running a recent kernel (3.10-rc5) on a arm-based board (a

rtl8192cu: slow path warning and connection problem v3.10-rc5

2013-06-11 Thread Richard GENOUD
Hi, I've got an usb wireless adapter TP-Link TL-WN725N http://www.tp-link.com/ca/products/details/?categoryid=241&model=TL-WN725N It is based on the rtl8192cu chip. I'm running a recent kernel (3.10-rc5) on a arm-based board (at91sam9g35-ek). and last linux-firmwares (2892af0) The problem I've go

Re: [PATCH 1/2] spi: atmel: convert to dma_request_slave_channel_compat()

2013-06-03 Thread Richard Genoud
2013/6/3 Ludovic Desroches : > On Fri, May 31, 2013 at 05:01:59PM +0200, Richard Genoud wrote: >> Use generic DMA DT helper. >> Platforms booting with or without DT populated are both supported. >> >> Based on Ludovic Desroches patchset >> "ARM: at91: m

[PATCHv2 2/2] atmel_lcdfb: blank the backlight on remove

2013-05-31 Thread Richard Genoud
When removing atmel_lcdfb module, the backlight is unregistered but not blanked. (only for CONFIG_BACKLIGHT_ATMEL_LCDC case). This can result in the screen going full white depending on how the PWM is wired. Signed-off-by: Richard Genoud --- drivers/video/atmel_lcdfb.c | 10 -- 1 file

Re: [PATCH 2/2] atmel_lcdfb: blank the backlight on remove

2013-05-31 Thread Richard Genoud
2013/5/31 Jean-Christophe PLAGNIOL-VILLARD : > On 16:28 Fri 31 May , Richard Genoud wrote: >> When removing atmel_lcdfb module, the backlight is unregistered but not >> blanked. (only for CONFIG_BACKLIGHT_ATMEL_LCDC case). >> This can result in the screen going full white

[PATCH 2/2] ARM: at91: dt: at91sam9x5: add SPI DMA client infos

2013-05-31 Thread Richard Genoud
Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5.dtsi |6 ++ 1 file changed, 6 insertions(+) rebased on linux-next next-20130531 plus Ludovic Desroches' patch "ARM: at91: dt: add header to define at_hdmac configuration" to get the AT91_DMA_CFG_PER_ID() macr

[PATCH 1/2] spi: atmel: convert to dma_request_slave_channel_compat()

2013-05-31 Thread Richard Genoud
Use generic DMA DT helper. Platforms booting with or without DT populated are both supported. Based on Ludovic Desroches patchset "ARM: at91: move to generic DMA device tree binding" Signed-off-by: Richard Genoud --- drivers/spi/spi-atmel.c | 42 +++

[PATCH] MTD: atmel_nand: using a stronger ECC is not dangerous

2013-05-31 Thread Richard Genoud
We don't have to issue a warning when a stronger error correting capability is chosen. Signed-off-by: Richard Genoud --- drivers/mtd/nand/atmel_nand.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c

[PATCH 2/2] atmel_lcdfb: blank the backlight on remove

2013-05-31 Thread Richard Genoud
When removing atmel_lcdfb module, the backlight is unregistered but not blanked. (only for CONFIG_BACKLIGHT_ATMEL_LCDC case). This can result in the screen going full white depending on how the PWM is wired. Signed-off-by: Richard Genoud --- drivers/video/atmel_lcdfb.c |7 ++- 1 file

[PATCH 1/2] trivial: atmel_lcdfb: add missing error message

2013-05-31 Thread Richard Genoud
When a too small framebuffer is given, the atmel_lcdfb_check_var silently fails. Adding an error message will save some head scratching. Signed-off-by: Richard Genoud --- drivers/video/atmel_lcdfb.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/video

Re: [PATCH 0/2] ARM: dts: add watchdog device tree node in at91 dts files

2013-05-31 Thread Richard Genoud
7 files changed, 32 insertions(+) > > -- > 1.7.9.5 > Those patches haven been floating around from quite some time. Let's merge them ! Tested on sam9g35, v3.10-rc2 Tested-by: Richard Genoud -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCHv3 RESEND 0/6] ARM: sunxi: Add support for A10 Ethernet controller

2013-05-30 Thread Richard Genoud
2013/5/30 Maxime Ripard : > > Did you look at the load while iperf was running? I guess we can expect > it to be pretty high since it runs without DMA. I just did the test. cpu is at 55%-60% root@debian:~# date ; iperf -c 192.168.1.10 -t 300 ; cat /proc/loadavg Thu May 30 17:43:13 UTC 2013 --

Re: [PATCHv3 RESEND 0/6] ARM: sunxi: Add support for A10 Ethernet controller

2013-05-29 Thread Richard Genoud
Bandwidth [ 4] 0.0-10.0 sec 112 MBytes 94.1 Mbits/sec That's great ! with this patchset, we can now run a server with a vanilla kernel ( who needs more that a serial port and ethernet, really ? ;) ) Tested-by: Richard Genoud -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH net, 1/2] hyperv: Fix a kernel warning from netvsc_linkstatus_callback()

2013-05-23 Thread Richard Genoud
ls > local_bh_enable() which displays warning if in irq. > > The fix is to remove the unnecessary netif_tx_disable & wake_queue() in the > netvsc_linkstatus_callback(). > > Reported-by: Richard Genoud > Tested-by: Long Li > Tested-by: Richard Genoud > Signed-off

Re: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after xfer->speed_hz set

2013-05-02 Thread Richard Genoud
2013/5/2 Yang, Wenyou : > Hi, Joachim, > >> -Original Message- >> From: Joachim Eastwood [mailto:manab...@gmail.com] >> Sent: 2013年3月7日 20:31 >> To: Yang, Wenyou >> Cc: linux-arm-ker...@lists.infradead.org; grant.lik...@secretlab.ca; Ferre, >> Nicolas; plagn...@jcrosoft.com; richard.gen...@

Re: linux-next: manual merge of the arm-soc tree with the spi-mb tree

2013-04-26 Thread Richard Genoud
2013/4/26 Stephen Rothwell : > Hi all, > > Today's linux-next merge of the arm-soc tree got a conflict in > arch/arm/boot/dts/at91sam9x5.dtsi between commits d50f88a0c304 ("ARM: > dts: add spi nodes for atmel SoC") and a68b728f7a21 ("ARM: dts: add > pinctrl property for spi node for atmel SoC") fro

Re: [PATCH v8 3/8] spi/spi-atmel: add dmaengine support

2013-04-24 Thread Richard Genoud
2013/4/23 Mark Brown : > On Wed, Apr 03, 2013 at 12:23:35PM +0200, Richard GENOUD wrote: > > Richard, delete irrelevant context from your mails - it makes it much > easier to find the content you added. > >> On [mer., 03.04.2013 13:59:19], Wenyou Yang wrote: > >>

Re: [PATCH RFC] ARM: don't allow to register the early_console twice

2013-04-18 Thread Richard GENOUD
d on ARMv7 > architecture (Armada XP and Armada 370), and on a ARMv5 one > (AT91SAMG35 thanks to Richard Genoud), with and with CONFIG_SMP > selected. > > This patch simply doesn't allow to call twice register_console() with > the early_console. > > Signed-off-by: Grego

Re: hv_netvsc: WARNING in softirq.c

2013-04-05 Thread Richard Genoud
2013/3/19 Richard Genoud : > 2013/3/7 Richard Genoud : >> 2013/3/6 Haiyang Zhang : >>> I have found a simple way to reproduce this kind of warning: >>> 1) reboot the VM (because this warning can be displayed only once.) >>> 2) login to the host and open the VM

Re: [PATCH 3/4] pinctrl: disable and free setting in select_state in case of error

2013-04-03 Thread Richard Genoud
2013/4/3 Linus Walleij : > On Thu, Mar 28, 2013 at 4:47 PM, Richard Genoud > wrote: >> 2013/3/28 Stephen Warren : > >>> Again, pinconf_free_setting() is all about freeing any dynamically >>> allocated storage required to represent the setting itself; it&#x

Re: [PATCH v8 8/8] ARM: dts: add pinctrl property for spi node for atmel SoC

2013-04-03 Thread Richard GENOUD
21 0x2 0x0 /* PA21 > periph B SPI1_MISO pin */ > + 0 22 0x2 0x0 /* PA22 > periph B SPI1_MOSI pin */ > + 0 23 0x2 0x0>; /* PA23 > periph B SPI1_SPCK pin */ > +

Re: [PATCH v8 3/8] spi/spi-atmel: add dmaengine support

2013-04-03 Thread Richard GENOUD
is patch is based on the original patch from Nicolas > - add dmaengine support > and squash the below patches from Richard Genoud > - update with dmaengine interface > - fix __init/__devinit sections mismatch > - fix spi-atmel driver to adapt to slave_conf

Re: [PATCH v8 2/8] spi/spi-atmel: add flag to controller data for lock operations

2013-04-03 Thread Richard GENOUD
atmel_spi_cleanup(struct spi_device *spi) > struct atmel_spi*as = spi_master_get_devdata(spi->master); > struct atmel_spi_device *asd = spi->controller_state; > unsignedgpio = (unsigned) spi->controller_data; > - unsigned long

Re: [PATCH v8 1/8] spi/spi-atmel: add physical base address

2013-04-03 Thread Richard GENOUD
*clk; > @@ -996,6 +997,7 @@ static int atmel_spi_probe(struct platform_device *pdev) > as->regs = ioremap(regs->start, resource_size(regs)); > if (!as->regs) > goto out_free_buffer; > + as->phybase = regs->start; > as->irq =

[PATCH 1/2] pinctrl: select_state: don't call pinctrl_free_setting on error

2013-03-29 Thread Richard Genoud
uxing (the closest thing I can think about for "unmuxing" a pin is muxing it as GPIO input). Signed-off-by: Richard Genoud --- This commit is on top of: [PATCH 3/3] pinctrl: pinctrl_select_state: set the old_state back on error drivers/pinctrl/core.c | 10 +- 1 files change

[PATCH 2/2] pinctrl: simplify the re-enable old state code in pinctrl_select_state

2013-03-29 Thread Richard Genoud
Instead of just enabling the settings that were disabled in the 1st loop, it's simpler to recall pinctrl_select_state with the old state. Signed-off-by: Richard Genoud --- drivers/pinctrl/core.c | 22 +++--- 1 files changed, 3 insertions(+), 19 deletions(-) diff --

Re: [PATCH 4/4] pinctrl: re-enable old state in case of error in pinctrl_select_state

2013-03-28 Thread Richard GENOUD
On [jeu., 28.03.2013 11:38:23], Stephen Warren wrote: > On 03/28/2013 11:34 AM, Richard GENOUD wrote: > > On [mer., 27.03.2013 17:55:45], Stephen Warren wrote: > >> On 03/25/2013 08:47 AM, Richard Genoud wrote: > >>> If a new state is applied, the groups configured

Re: [PATCH 4/4] pinctrl: re-enable old state in case of error in pinctrl_select_state

2013-03-28 Thread Richard GENOUD
On [mer., 27.03.2013 17:55:45], Stephen Warren wrote: > On 03/25/2013 08:47 AM, Richard Genoud wrote: > > If a new state is applied, the groups configured in the old state but > > not in the new state are disabled. > > If something goes wrong and the new state can't be

Re: [PATCH 3/4] pinctrl: disable and free setting in select_state in case of error

2013-03-28 Thread Richard Genoud
2013/3/28 Stephen Warren : > On 03/28/2013 04:55 AM, Richard Genoud wrote: >> 2013/3/28 Stephen Warren : >>> On 03/25/2013 08:47 AM, Richard Genoud wrote: >>>> If enabling a pin fails in pinctrl_select_state_locked(), all the >>>> previous enabled p

[PATCH 3/3] pinctrl: pinctrl_select_state: set the old_state back on error

2013-03-28 Thread Richard Genoud
In unapply_new_state, the old state is re-applied, but p->state is not set back as it should. Signed-off-by: Richard Genoud --- This one can be squshed with commit: 50cf7c8ab324de348990bb028ad9ed10872d527a pinctrl: re-enable old state in case of error in pinctrl_select_state If needed. driv

[PATCH 1/3] pinctrl: use dev_info instead of pr_info in pinctrl_select_state_locked

2013-03-28 Thread Richard Genoud
And remove superfluous brackets. Signed-off-by: Richard Genoud --- If it's not too late, it can be squashed with commit: 3102a76cfbf9ac4ae0cf54c7452f7ba4292a4760 "pinctrl: disable and free setting in select_state in case of error" drivers/pinctrl/core.c |5 ++--- 1 f

[PATCH 2/3] pinctrl: remove superfluous optimization in pinctrl_select_state_locked

2013-03-28 Thread Richard Genoud
As Stephen Warren suggested, checking first if the setting->node entry is the first in the list or not is superfluous, as it is checked again in the list_for_each_entry bellow. So, remove it, the code will be simpler and lighter ! Signed-off-by: Richard Genoud --- If can also be squashed w

Re: [PATCH 4/4] pinctrl: re-enable old state in case of error in pinctrl_select_state

2013-03-28 Thread Richard Genoud
2013/3/28 Stephen Warren : > On 03/25/2013 08:47 AM, Richard Genoud wrote: >> If a new state is applied, the groups configured in the old state but >> not in the new state are disabled. >> If something goes wrong and the new state can't be applied, we have to >> re-

Re: [PATCH 3/4] pinctrl: disable and free setting in select_state in case of error

2013-03-28 Thread Richard Genoud
2013/3/28 Stephen Warren : > On 03/25/2013 08:47 AM, Richard Genoud wrote: >> If enabling a pin fails in pinctrl_select_state_locked(), all the >> previous enabled pins have to be disabled to get back to the previous >> state. > >> diff --git a/drivers/pinctrl/c

Re: [RESEND PATCH 1/6] acpi: Remove the leading space of "unlock" label in acpi_memory_device_notify().

2013-03-26 Thread Richard Genoud
2013/3/26 Rafael J. Wysocki : > On Wednesday, March 06, 2013 04:30:06 PM Tang Chen wrote: >> There is a leading space in front of "unlock" label in >> acpi_memory_device_notify(). Remove it. >> >> Signed-off-by: Tang Chen >> --- >> drivers/acpi/acpi_memhotplug.c |2 +- >> 1 files changed, 1

[PATCH 2/4] pinctrl: create pinctrl_free_setting function

2013-03-25 Thread Richard Genoud
This prepares the implementation of pinctrl_select_state_locked() free code. No functionnal change. Signed-off-by: Richard Genoud --- drivers/pinctrl/core.c | 32 +++- 1 files changed, 19 insertions(+), 13 deletions(-) diff --git a/drivers/pinctrl/core.c b

[PATCH 4/4] pinctrl: re-enable old state in case of error in pinctrl_select_state

2013-03-25 Thread Richard Genoud
If a new state is applied, the groups configured in the old state but not in the new state are disabled. If something goes wrong and the new state can't be applied, we have to re-enable those groups. Signed-off-by: Richard Genoud --- drivers/pinctrl/core.c | 20 +++- 1

[PATCH 3/4] pinctrl: disable and free setting in select_state in case of error

2013-03-25 Thread Richard Genoud
If enabling a pin fails in pinctrl_select_state_locked(), all the previous enabled pins have to be disabled to get back to the previous state. Signed-off-by: Richard Genoud --- drivers/pinctrl/core.c | 28 +--- 1 files changed, 25 insertions(+), 3 deletions(-) diff

[PATCH 1/4] pinctrl: fix typo in header

2013-03-25 Thread Richard Genoud
Clearly, "node" was meant instead of "not" Signed-off-by: Richard Genoud --- drivers/pinctrl/core.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h index ee72f1f..6d3d400 100644 --- a/drivers/pinctrl/

[PATCH 0/4] pintrcl: restore old state when pinctrl_select_state fails

2013-03-25 Thread Richard Genoud
The third patch undoes what have been done to enable the new state. The last patch re-applies the old state. Richard Genoud (4): pinctrl: fix typo in header pinctrl: create pinctrl_free_setting function pinctrl: disable and free setting in select_state in case of error pinctrl: re-enable ol

Re: [PATCH] BUG: [RFC] pinctrl: pins are freed 2 times in pinctrl_bind_pins

2013-03-21 Thread Richard Genoud
2013/3/20 Stephen Warren : > On 03/20/2013 05:31 AM, Richard Genoud wrote: >> If the function pinctrl_select_state() fails because one pin is already >> taken elsewhere, pinmux_enable_setting makes all the necessary pin_free >> calls (and not more than necessary). >&g

[PATCH] BUG: pinmux: forbid mux_usecount to be set at UINT_MAX

2013-03-21 Thread Richard Genoud
If pin_free is called on a pin already freed, mux_usecount is set to UINT_MAX which is really a bad idea. This will issue a warning, so that we can correct the code responsible for the double free. Signed-off-by: Richard Genoud --- Ok Stephen, your idea (and code) seems better. I signed-off it

Re: [PATCH] BUG: pinmux: forbid mux_usecount to be set at UINT_MAX

2013-03-20 Thread Richard Genoud
2013/3/20 Stephen Warren : > On 03/20/2013 05:31 AM, Richard Genoud wrote: >> If pin_free is called on a pin already freed, mux_usecount is set to >> UINT_MAX which is really a bad idea. >> This will silently ignore a double call to pin_free > > Shouldn't we WARN_O

Re: [PATCH] BUG: pinmux: release only taken pins on error

2013-03-20 Thread Richard Genoud
2013/3/20 Axel Lin : > 2013/3/20 Richard Genoud : >> commit e38d457de7be63e6ced1ea254aa51466deb1fef0 >> pinctrl: pinmux: Release all taken pins in pinmux_enable_setting >> >> Introduced a bug in the release pin mechanism. >> All the pins (taken or not) where re

[PATCH] BUG: [RFC] pinctrl: pins are freed 2 times in pinctrl_bind_pins

2013-03-20 Thread Richard Genoud
x27;s the right thing to do. Signed-off-by: Richard Genoud --- drivers/base/pinctrl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/base/pinctrl.c b/drivers/base/pinctrl.c index 67a274e..537406d 100644 --- a/drivers/base/pinctrl.c +++ b/drivers/base/pinctrl.c

[PATCH] BUG: pinmux: release only taken pins on error

2013-03-20 Thread Richard Genoud
: Richard Genoud --- drivers/pinctrl/pinmux.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 1a00658..917e830 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -409,6 +409,8 @@ int

[PATCH] BUG: pinmux: forbid mux_usecount to be set at UINT_MAX

2013-03-20 Thread Richard Genoud
If pin_free is called on a pin already freed, mux_usecount is set to UINT_MAX which is really a bad idea. This will silently ignore a double call to pin_free Signed-off-by: Richard Genoud --- drivers/pinctrl/pinmux.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a

[PATCH] DTS at91sam9x5cm: add 1-wire chip on CM board

2013-03-20 Thread Richard Genoud
This add the 1-wire chip present on the CM board to the DTS. As the pin is also used by leds, tt's disabled by default. If the board really wants it, it can be enabled in the board DTS. Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5cm.dtsi | 20 1

[PATCH] DTS at91sam9x5ek: i2c1 and i2c2 conflict with macb and lcd

2013-03-20 Thread Richard Genoud
on at91sam9x5ek, macb0 is enabled, so it conflicts with i2c2 (PB4) same for i2c1, (conflicts with LCD). Moreover, only i2c0 is used on this board. Signed-off-by: Richard Genoud --- arch/arm/boot/dts/at91sam9x5ek.dtsi |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git

Re: hv_netvsc: WARNING in softirq.c

2013-03-19 Thread Richard Genoud
2013/3/7 Richard Genoud : > 2013/3/6 Haiyang Zhang : >> I have found a simple way to reproduce this kind of warning: >> 1) reboot the VM (because this warning can be displayed only once.) >> 2) login to the host and open the VM [Settings] >> 3) Temporarily change t

Re: hv_netvsc: WARNING in softirq.c

2013-03-07 Thread Richard Genoud
2013/3/6 Haiyang Zhang : > I have found a simple way to reproduce this kind of warning: > 1) reboot the VM (because this warning can be displayed only once.) > 2) login to the host and open the VM [Settings] > 3) Temporarily change the Network adapter's option [Virtual Switch] to "Not > connected"

Re: Bug in mtd_get_device_size()?

2013-03-01 Thread Richard Genoud
2013/3/1 Velykokhatko, Sergey : > Hi Richard, > >>And if you want to tweak the BEB_LIMIT for each of your UBI partition, it's >>possible, via the ubiattach call ( get the master branchof of >>git://git.infradead.org/mtd-utils.git ) cf >>http://git.infradead.org/mtd-utils.git/commit/878e06ea555ba

Re: Bug in mtd_get_device_size()?

2013-03-01 Thread Richard Genoud
2013/3/1 Velykokhatko, Sergey : > Hi Richard, > > Thanks a lot for your explanations. Now at least I understand your logic. And > it seems to be reasonable. Your start point that all bad blocks for flash > chip could be placed in single MTD. This is really worst worst case, but... > Theoreticall

Re: Bug in mtd_get_device_size()?

2013-03-01 Thread Richard Genoud
2013/3/1 Velykokhatko, Sergey : > Hi Brian, > > Thanks for your answer. Ok, I have nothing against that my interpretation of > mtd_get_device_size() purpose is wrong. But what you mean under: "Because > your BEB_LIMIT=100, you are reserving 100*size/1024 (that is 9.8% of your > total size, or 40

Re: hv_netvsc: WARNING in softirq.c

2013-03-01 Thread Richard Genoud
2013/2/28 Haiyang Zhang : > We will look into this. And further info around the time will also be helpful. > > Thanks, > - Haiyang The only thing the admin sys could think about is a rsync process between the windows host and ANOTHER linux guest that ends at 22h30 more or less. (the other linux gu

hv_netvsc: WARNING in softirq.c

2013-02-28 Thread Richard GENOUD
Hi, Here is the kernel trace I got this morning (kern.log): Feb 27 22:32:59 devlabo kernel: [10688.187062] hv_vmbus: child device vmbus_0_8 unregistered Feb 27 22:34:37 devlabo kernel: [10688.187196] [ cut here ] Feb 27 22:34:37 devlabo kernel: [10688.187203] WARNING: at

Re: [v4 PATCH 06/12] spi/atmel_spi: add dmaengine support

2013-01-23 Thread Richard Genoud
ou.y...@atmel.com: fix DMA: OOPS if buffer > 4096 bytes] > Signed-off-by: Wenyou Yang > Cc: grant.lik...@secretlab.ca > Cc: spi-devel-gene...@lists.sourceforge.net > Cc: richard.gen...@gmail.com > --- > This patch is based on the original patch from Nicolas >

Re: [v4 PATCH 00/12] atmel spi controller with dmaengine and device tree support

2013-01-18 Thread Richard Genoud
DMA: when enable both spi0 AND spi1, the spi0 doesn't work > BUG. > > 4./ Rebase v3.7-rc8. > > Best Regards, > Wenyou Yang. > > Nicolas Ferre (5): > spi/atmel_spi: add physical base address > spi/atmel_spi: call unmapping on transfers buffers > sp

Re: [PATCH 4/4] UBI: replace MTD_UBI_BEB_LIMIT with user-space parameter

2012-08-20 Thread Richard Genoud
2012/8/20 Artem Bityutskiy : > On Mon, 2012-08-20 at 08:55 +0200, Richard Genoud wrote: >> Hi Artem, >> 2012/8/19 Artem Bityutskiy : >> > Yeah, I wanted to make it 1..256 but forgot, will do now. 0..256 would >> > need some more work to avoid division by 0. &

Re: [PATCH 6/8] UBI: replace MTD_UBI_BEB_LIMIT with module parameter

2012-08-20 Thread Richard Genoud
2012/8/20 Richard Genoud : > 2012/8/19 Shmulik Ladkani : >> Hi Richard, >> >> On Fri, 17 Aug 2012 16:35:22 +0200 Richard Genoud >> wrote: >>> + "MTD devices may be specified by their number, name, or >

Re: [PATCH 6/8] UBI: replace MTD_UBI_BEB_LIMIT with module parameter

2012-08-20 Thread Richard Genoud
2012/8/19 Shmulik Ladkani : > Hi Richard, > > On Fri, 17 Aug 2012 16:35:22 +0200 Richard Genoud > wrote: >> + "MTD devices may be specified by their number, name, or >> path to the MTD character device node.\n" >> +

Re: [PATCH 4/4] UBI: replace MTD_UBI_BEB_LIMIT with user-space parameter

2012-08-19 Thread Richard Genoud
Hi Artem, 2012/8/19 Artem Bityutskiy : > Yeah, I wanted to make it 1..256 but forgot, will do now. 0..256 would > need some more work to avoid division by 0. Division by 0 is handled in the get_bad_peb_limit() function, I don't see another dangerous place. So, I think that we can change back the ra

Re: [PATCH 5/8] UBI: check max_beb_per1024 value in ubi_attach_mtd_dev

2012-08-19 Thread Richard Genoud
Hi Shmulik, 2012/8/19 Shmulik Ladkani : > Hi Richard, > > On Fri, 17 Aug 2012 16:35:21 +0200 Richard Genoud > wrote: >> + /* >> + * A value of 0 is forced to the default value to keep the same >> + * behavior between ubiattach command and module pa

[PATCH 2/4] sync include/mtd/ubi-user.h: add max_beb_per1024 parameter

2012-08-17 Thread Richard Genoud
Signed-off-by: Richard Genoud --- include/mtd/ubi-user.h | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/include/mtd/ubi-user.h b/include/mtd/ubi-user.h index 123951f..32771cf 100644 --- a/include/mtd/ubi-user.h +++ b/include/mtd/ubi-user.h @@ -222,6

[PATCH 4/4] ubiattach: introduce max_beb_per1024 in UBI_IOCATT

2012-08-17 Thread Richard Genoud
appear every where on a flash device, in the worst case scenario they can all appear in one MTD partition. So the maximum number of expected erase blocks given by the NAND manufacturer should be reserve on each MTD partition. Signed-off-by: Richard Genoud --- tests/fs-tests/integrity/integck.c

[PATCH 3/4] sync include/mtd/ubi-user.h: DROP CONFIG_MTD_UBI_BEB_LIMIT

2012-08-17 Thread Richard Genoud
Signed-off-by: Richard Genoud --- include/mtd/ubi-user.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/mtd/ubi-user.h b/include/mtd/ubi-user.h index 32771cf..44720d3 100644 --- a/include/mtd/ubi-user.h +++ b/include/mtd/ubi-user.h @@ -259,8 +259,8 @@ enum

[PATCH 1/4] sync include/mtd/ubi-user.h with kernel v3.6-rc1

2012-08-17 Thread Richard Genoud
Signed-off-by: Richard Genoud --- include/mtd/ubi-user.h | 138 +++- 1 files changed, 67 insertions(+), 71 deletions(-) diff --git a/include/mtd/ubi-user.h b/include/mtd/ubi-user.h index 296efae..123951f 100644 --- a/include/mtd/ubi-user.h +++ b

[PATCH 0/4] mtd-utils/ubiattach: introduce max_beb_per1024 in UBI_IOCATT

2012-08-17 Thread Richard Genoud
you can always squash the first 2 or 3 patches into 1). Best Regards, Richard. Richard Genoud (4): sync include/mtd/ubi-user.h with kernel v3.6-rc1 sync include/mtd/ubi-user.h: add max_beb_per1024 parameter sync include/mtd/ubi-user.h: DROP CONFIG_MTD_UBI_BEB_LIMIT ubiattach: introduce

[PATCH 6/8] UBI: replace MTD_UBI_BEB_LIMIT with module parameter

2012-08-17 Thread Richard Genoud
ameter: ubi.mtd=[,[,max_beb_per1024]] Signed-off-by: Richard Genoud --- drivers/mtd/ubi/Kconfig |2 ++ drivers/mtd/ubi/build.c | 38 -- 2 files changed, 26 insertions(+), 14 deletions(-) diff --git a/drivers/mtd/ubi/Kconfig b/drivers/mtd/ubi/Kconfig index f

[PATCH 7/8] UBI: add ioctl for max_beb_per1024

2012-08-17 Thread Richard Genoud
just that via a kernel parameter, now we can also use UBI_IOCATT ioctl: struct ubi_attach_req { __s32 ubi_num; __s32 mtd_num; __s32 vid_hdr_offset; __u8 max_beb_per1024; __s8 padding[11]; }; Signed-off-by: Richard Genoud --- drivers/mtd/ubi/Kconfig |3 +

[PATCH 8/8] UBI: drop CONFIG_MTD_UBI_BEB_LIMIT

2012-08-17 Thread Richard Genoud
This option can be set by a kernel parameter and an ioctl, so we may not need the kernel config option any more. Signed-off-by: Richard Genoud --- arch/arm/configs/sam9_l9260_defconfig |1 - drivers/mtd/ubi/Kconfig | 29 - drivers/mtd/ubi/build.c

[PATCH 5/8] UBI: check max_beb_per1024 value in ubi_attach_mtd_dev

2012-08-17 Thread Richard Genoud
max_beb_per1024 shouldn't be negative, and a 0 value will be treated as the default value. Signed-off-by: Richard Genoud --- drivers/mtd/ubi/build.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index 58

<    1   2   3   4   5   >