Re: [PATCH v4] hwmon: corsair-psu: add support for critical values

2021-03-19 Thread Wilken Gottwalt
On Thu, 18 Mar 2021 12:01:50 -0700 Guenter Roeck wrote: > On Thu, Mar 18, 2021 at 03:17:14PM +0100, Wilken Gottwalt wrote: > > Adds support for reading the critical values of the temperature sensors > > and the rail sensors (voltage and current) once and caches them. Updates

[PATCH v4] hwmon: corsair-psu: add support for critical values

2021-03-18 Thread Wilken Gottwalt
: 8.31 A (crit max = +40.00 A) curr +3.3v:1.62 A (crit max = +40.00 A) Signed-off-by: Wilken Gottwalt --- Changed in v4: - simplified private data structure and collection of critical values and unsupported command check Changes in v3: - introduced a quirk check function to catch non

Re: [PATCH v7 2/2] hwspinlock: add sun6i hardware spinlock support

2021-03-18 Thread Wilken Gottwalt
On Mon, 15 Mar 2021 17:12:20 +0100 Maxime Ripard wrote: > On Sun, Mar 14, 2021 at 10:31:13AM +0100, Wilken Gottwalt wrote: > > Adds the sun6i_hwspinlock driver for the hardware spinlock unit found in > > most of the sun6i compatible SoCs. > > > > This unit pro

[PATCH v3] hwmon: corsair-psu: add support for critical values

2021-03-17 Thread Wilken Gottwalt
: 8.31 A (crit max = +40.00 A) curr +3.3v:1.62 A (crit max = +40.00 A) Signed-off-by: Wilken Gottwalt --- Changes in v3: - introduced a quirk check function to catch non-working commands - split is_visible function into subfunctions - moved the "is value valid" checks into the is_

[PATCH] w1: w1_therm: fix possible NULL pointer dereference

2021-03-17 Thread Wilken Gottwalt
. This one uses the read_byte function provided by the master driver. This is tested against a 1-wire ds1wm bus master with two w1_therm slaves. Fixes: 2f6055c26f19 (w1: w1_therm: Fix conversion result for negative temperatures) Signed-off-by: Wilken Gottwalt --- drivers/w1/slaves/w1_therm.c | 4

Re: [PATCH v2] hwmon: corsair-psu: add support for critical values

2021-03-16 Thread Wilken Gottwalt
On Mon, 15 Mar 2021 11:00:53 -0700 Guenter Roeck wrote: > On 3/15/21 9:55 AM, Wilken Gottwalt wrote: > > On Mon, 15 Mar 2021 08:53:25 -0700 > > Guenter Roeck wrote: > > > >> On 3/15/21 8:02 AM, Wilken Gottwalt wrote: > >>> Adds support for reading the

Re: [PATCH v2] hwmon: corsair-psu: add support for critical values

2021-03-15 Thread Wilken Gottwalt
On Mon, 15 Mar 2021 08:53:25 -0700 Guenter Roeck wrote: > On 3/15/21 8:02 AM, Wilken Gottwalt wrote: > > Adds support for reading the critical values of the temperature sensors > > and the rail sensors (voltage and current) once and caches them. Updates > > the naming of th

[PATCH v2] hwmon: corsair-psu: add support for critical values

2021-03-15 Thread Wilken Gottwalt
:1.62 A (crit max = +40.00 A) This patch changes: - hwmon corsair-psu documentation - hwmon corsair-psu driver Signed-off-by: Wilken Gottwalt --- Changes in v2: - simplified reading/caching of critical values and hwmon_ops_read function - removed unnecessary debug output and comments

[PATCH] hwmon: corsair-psu: add support for critical values

2021-03-14 Thread Wilken Gottwalt
:1.62 A (crit max = +40.00 A) This patch changes: - hwmon corsair-psu documentation - hwmon corsair-psu driver Signed-off-by: Wilken Gottwalt --- Documentation/hwmon/corsair-psu.rst | 13 +- drivers/hwmon/corsair-psu.c | 185 ++-- 2 files changed, 157 insertions

[PATCH v7 1/2] dt-bindings: hwlock: add sun6i_hwspinlock

2021-03-14 Thread Wilken Gottwalt
Adds documentation on how to use the sun6i_hwspinlock driver for sun6i compatible series SoCs. Signed-off-by: Wilken Gottwalt --- Changes in v7: - changed dt documentation to the name of the compatible string Changes in v6: - fixed formating and name issues in dt documentation Changes

[PATCH v7 2/2] hwspinlock: add sun6i hardware spinlock support

2021-03-14 Thread Wilken Gottwalt
. The driver also reports the amount of supported locks via debugfs. Signed-off-by: Wilken Gottwalt --- Changes in v7: - changed probe to use to devm_* and devm_add_action_* function Changes in v6: - changed probe/remove function to use classic functions to better handle failure

[PATCH v7 0/2] hwspinlock: add sun6i hardware spinlock support

2021-03-14 Thread Wilken Gottwalt
_hwspinlock - updates makefiles - hwspinlock dt bindings documentation - updates MAINTAINERS Signed-off-by: Wilken Gottwalt Changes in v7: - changed probe to use to devm_* and devm_add_action_* functions - changed dt documentation to the name of the compatible string Changes in v6: - fixed

Re: [PATCH v6 1/2] dt-bindings: hwlock: add sun6i_hwspinlock

2021-03-06 Thread Wilken Gottwalt
On Tue, 2 Mar 2021 18:22:33 +0100 Maxime Ripard wrote: > On Mon, Mar 01, 2021 at 03:06:35PM +0100, Wilken Gottwalt wrote: > > On Mon, 1 Mar 2021 14:12:44 +0100 > > Maxime Ripard wrote: > > > > > On Sat, Feb 27, 2021 at 02:03:28PM +0100, Wilken Gottwalt wrote: >

Re: [PATCH v6 2/2] hwspinlock: add sun6i hardware spinlock support

2021-03-06 Thread Wilken Gottwalt
On Tue, 2 Mar 2021 18:20:02 +0100 Maxime Ripard wrote: > Hi, > > On Mon, Mar 01, 2021 at 03:06:08PM +0100, Wilken Gottwalt wrote: > > On Mon, 1 Mar 2021 14:13:05 +0100 > > Maxime Ripard wrote: > > > > > On Sat, Feb 27, 2021 at 02:03:54PM +0100,

Re: [PATCH v6 1/2] dt-bindings: hwlock: add sun6i_hwspinlock

2021-03-01 Thread Wilken Gottwalt
On Mon, 1 Mar 2021 14:12:44 +0100 Maxime Ripard wrote: > On Sat, Feb 27, 2021 at 02:03:28PM +0100, Wilken Gottwalt wrote: > > Adds documentation on how to use the sun6i_hwspinlock driver for sun6i > > compatible series SoCs. > > > > Signed-off-by: Wilken Gottwalt

Re: [PATCH v6 2/2] hwspinlock: add sun6i hardware spinlock support

2021-03-01 Thread Wilken Gottwalt
On Mon, 1 Mar 2021 14:13:05 +0100 Maxime Ripard wrote: > On Sat, Feb 27, 2021 at 02:03:54PM +0100, Wilken Gottwalt wrote: > > Adds the sun6i_hwspinlock driver for the hardware spinlock unit found in > > most of the sun6i compatible SoCs. > > > > This unit pro

[PATCH v6 2/2] hwspinlock: add sun6i hardware spinlock support

2021-02-27 Thread Wilken Gottwalt
. The driver also reports the amount of supported locks via debugfs. Signed-off-by: Wilken Gottwalt --- Changes in v6: - changed probe/remove function to use classic functions to better handle failure situations Changes in v5: - changed symbols to the earliest known supported SoC (sun6i

[PATCH v6 1/2] dt-bindings: hwlock: add sun6i_hwspinlock

2021-02-27 Thread Wilken Gottwalt
Adds documentation on how to use the sun6i_hwspinlock driver for sun6i compatible series SoCs. Signed-off-by: Wilken Gottwalt --- Changes in v6: - fixed formating and name issues in dt documentation Changes in v5: - changed binding to earliest known supported SoC sun6i-a31 - dropped

[PATCH v6 0/2] hwspinlock: add sun6i hardware spinlock support

2021-02-27 Thread Wilken Gottwalt
_hwspinlock - updates makefiles - hwspinlock dt bindings documentation - updates MAINTAINERS Signed-off-by: Wilken Gottwalt Changes in v6: - fixed formating and name issues in dt documentation - changed probe/remove function to use classic functions to better handle failure situations

[PATCH] hwmon: corsair-psu: update calculation of LINEAR11 values

2021-02-27 Thread Wilken Gottwalt
Doan Signed-off-by: Wilken Gottwalt --- drivers/hwmon/corsair-psu.c | 30 -- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c index 99494056f4bd..b0953eeeb2d3 100644 --- a/drivers/hwmon/corsair-psu.c

Re: [PATCH v5 1/2] dt-bindings: hwlock: add sun6i_hwspinlock

2021-02-07 Thread Wilken Gottwalt
On Wed, 23 Dec 2020 15:49:19 -0700 Rob Herring wrote: > On Wed, Dec 23, 2020 at 4:34 AM Wilken Gottwalt > wrote: > > > > Adds documentation on how to use the sun6i_hwspinlock driver for sun6i > > compatible SoCs. > > Please resend to DT list so that automated che

Re: [PATCH v5 2/2] hwspinlock: add sun6i hardware spinlock support

2021-01-08 Thread Wilken Gottwalt
On Thu, 7 Jan 2021 11:43:48 -0600 Bjorn Andersson wrote: > On Wed 23 Dec 05:35 CST 2020, Wilken Gottwalt wrote: > > > Adds the sun6i_hwspinlock driver for the hardware spinlock unit found in > > most of the sun6i compatible SoCs. > > > > This unit provides at

Re: [PATCH v5 2/2] hwspinlock: add sun6i hardware spinlock support

2021-01-07 Thread Wilken Gottwalt
On Wed, 6 Jan 2021 11:15:42 +0100 Maxime Ripard wrote: > On Wed, Dec 23, 2020 at 12:35:10PM +0100, Wilken Gottwalt wrote: > > Adds the sun6i_hwspinlock driver for the hardware spinlock unit found in > > most of the sun6i compatible SoCs. > > > > This unit pro

Re: [PATCH v5 1/2] dt-bindings: hwlock: add sun6i_hwspinlock

2021-01-07 Thread Wilken Gottwalt
On Wed, 6 Jan 2021 11:14:36 +0100 Maxime Ripard wrote: > Hi, > > On Wed, Dec 23, 2020 at 03:49:19PM -0700, Rob Herring wrote: > > On Wed, Dec 23, 2020 at 4:34 AM Wilken Gottwalt > > wrote: > > > > > > Adds documentation on how to use the sun6i_hwspinlock

[PATCH v5 2/2] hwspinlock: add sun6i hardware spinlock support

2020-12-23 Thread Wilken Gottwalt
. The driver also reports the amount of supported locks via debugfs. Signed-off-by: Wilken Gottwalt --- Changes in v5: - changed symbols to the earliest known supported SoC (sun6i/a31) - changed init back to classic probe/remove callbacks Changes in v4: - further simplified driver - fixed

[PATCH v5 1/2] dt-bindings: hwlock: add sun6i_hwspinlock

2020-12-23 Thread Wilken Gottwalt
Adds documentation on how to use the sun6i_hwspinlock driver for sun6i compatible SoCs. Signed-off-by: Wilken Gottwalt --- Changes in v5: - changed binding to earliest known supported SoC sun6i-a31 - dropped unnecessary entries Changes in v4: - changed binding to sun8i-a33-hwpinlock

[PATCH v5 0/2] hwspinlock: add sun6i hardware spinlock support

2020-12-23 Thread Wilken Gottwalt
_hwspinlock - updates makefiles - hwspinlock dt bindings documentation - updates MAINTAINERS Signed-off-by: Wilken Gottwalt Changes in v5: - changed symbols to earliest known supported SoC (A31) - simplified dt documentation - fixed several types - updated test description - changed init b

Re: [PATCH v4 2/2] hwspinlock: add sun8i hardware spinlock support

2020-12-11 Thread Wilken Gottwalt
On Fri, 11 Dec 2020 10:03:12 +0100 Maxime Ripard wrote: > Hi, > > On Fri, Dec 11, 2020 at 09:24:15AM +0100, Wilken Gottwalt wrote: > > Adds the sun8i_hwspinlock driver for the hardware spinlock unit found in > > most of the sun8i compatible SoCs. > > > &g

Re: [PATCH v4 1/2] dt-bindings: hwlock: add sun8i_hwspinlock

2020-12-11 Thread Wilken Gottwalt
On Fri, 11 Dec 2020 09:57:57 +0100 Maxime Ripard wrote: > Hi, > > On Fri, Dec 11, 2020 at 09:23:48AM +0100, Wilken Gottwalt wrote: > > Adds documentation on how to use the sun8i_hwspinlock driver for sun8i > > compatible SoCs. > > > > Signed-off-by: Wilken Go

[PATCH v4 1/2] dt-bindings: hwlock: add sun8i_hwspinlock

2020-12-11 Thread Wilken Gottwalt
Adds documentation on how to use the sun8i_hwspinlock driver for sun8i compatible SoCs. Signed-off-by: Wilken Gottwalt --- Changes in v4: - changed binding to sun8i-a33-hwpinlock - added changes suggested by Maxime Ripard Changes in v3: - changed symbols from sunxi to sun8i Changes in v2

[PATCH v4 2/2] hwspinlock: add sun8i hardware spinlock support

2020-12-11 Thread Wilken Gottwalt
devices. The driver also reports the amount of supported locks via debugfs. Signed-off-by: Wilken Gottwalt --- Changes in v4: - further simplified driver - fixed an add_action_and_reset_ function issue - changed bindings from sun8i-hwspinlock to sun8i-a33-hwspinlock Changes in v3: - moved

[PATCH v4 0/2] hwspinlock: add sun8i hardware spinlock support

2020-12-11 Thread Wilken Gottwalt
t #1 succeded This patch adds: - hwspinlock driver suni8i_hwspinlock - updates makefiles - hwspinlock dt bindings documentation - updates MAINTAINERS Signed-off-by: Wilken Gottwalt Changes in v4: - changed binding from sun8i-hwspinlock to sun8i-a33-hwspinlock - fixed several issues

Re: [PATCH v3 1/2] dt-bindings: hwlock: add sun8i_hwspinlock documentation

2020-12-07 Thread Wilken Gottwalt
On Mon, 7 Dec 2020 21:22:23 -0600 Samuel Holland wrote: > On 12/7/20 10:12 AM, Maxime Ripard wrote: > > Hi, > > > > On Mon, Dec 07, 2020 at 05:05:03PM +0100, Wilken Gottwalt wrote: > >> Adds documentation on how to use the sun8i_hwspinlock driver for sun8i > >

[PATCH v3 2/2] hwspinlock: add sun8i hardware spinlock support

2020-12-07 Thread Wilken Gottwalt
devices. The driver also reports the amount of supported locks via debugfs. Signed-off-by: Wilken Gottwalt --- Changes in v3: - moved test description to cover letter - changed name and symbols from sunxi to sun8i - improved driver description - further simpliefied driver - fully switched

[PATCH v3 0/2] hwspinlock: add sun8i hardware spinlock support

2020-12-07 Thread Wilken Gottwalt
st]+++ attempt #1 succeded This patch adds: - hwspinlock driver suni8i_hwspinlock - updates makefiles - hwspinlock dt bindings documentation - updates MAINTAINERS Signed-off-by: Wilken Gottwalt Changes in v3: - moved test description to cover letter - changed name and symbols from s

[PATCH v3 1/2] dt-bindings: hwlock: add sun8i_hwspinlock documentation

2020-12-07 Thread Wilken Gottwalt
Adds documentation on how to use the sun8i_hwspinlock driver for sun8i compatible SoCs. Signed-off-by: Wilken Gottwalt --- .../bindings/hwlock/sun8i-hwspinlock.yaml | 63 +++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwlock/sun8i

Re: [PATCH v2 2/2] hwspinlock: add sunxi hardware spinlock support

2020-12-04 Thread Wilken Gottwalt
On Fri, 4 Dec 2020 17:21:17 +0100 Maxime Ripard wrote: > On Fri, Dec 04, 2020 at 04:35:12PM +0100, Wilken Gottwalt wrote: > > Adds the sunxi_hwspinlock driver for the hardware spinlock unit found in > > most of the sun8i and sun50i based SoCs. > > > > This unit pro

Re: [PATCH v2 2/2] hwspinlock: add sunxi hardware spinlock support

2020-12-04 Thread Wilken Gottwalt
On Fri, 4 Dec 2020 17:21:17 +0100 Maxime Ripard wrote: > On Fri, Dec 04, 2020 at 04:35:12PM +0100, Wilken Gottwalt wrote: > > Adds the sunxi_hwspinlock driver for the hardware spinlock unit found in > > most of the sun8i and sun50i based SoCs. > > > > This unit pro

[PATCH v2 2/2] hwspinlock: add sunxi hardware spinlock support

2020-12-04 Thread Wilken Gottwalt
_0011__ [ 439.303502] [sreg] after untake 0000_0010__ [ 439.309774] [test]+++ attempt #1 succeded Signed-off-by: Wilken Gottwalt --- Changes in v2: - added suggestions from Bjorn Andersson and Maxime Ripard - provided better driver and test

[PATCH v2 1/2] dt-bindings: hwlock: sunxi: add sunxi_hwspinlock documentation

2020-12-04 Thread Wilken Gottwalt
Adds documentation on how to use the sunxi_hwspinlock driver for the sun8i and sun50i based SoCs. Signed-off-by: Wilken Gottwalt --- Changes in v2: - fixed memory ranges --- .../bindings/hwlock/sunxi-hwspinlock.yaml | 64 +++ 1 file changed, 64 insertions(+) create mode

[PATCH v2 0/2] hwspinlock: add sunxi hardware spinlock support

2020-12-04 Thread Wilken Gottwalt
documentation - updates MAINTAINERS Signed-off-by: Wilken Gottwalt Changes in v2: - redone coverletter - fixed ranges in the device tree description - added suggestions from Bjorn Andersson and Maxime Ripard to the driver - provided better driver and test description Wilken Gottwalt (2): dt

Re: [PATCH] hwmon: corsair-psu: update supported devices

2020-11-30 Thread Wilken Gottwalt
On Mon, 30 Nov 2020 18:25:30 +0200 Backlund Thomas wrote: > Den 30.11.2020 kl. 16:49, skrev Wilken Gottwalt: > > On Mon, 30 Nov 2020 14:43:44 +0200 > > Thomas Backlund wrote: > > > >> Den 28.11.2020 kl. 12:35, skrev Wilken Gottwalt: > >>> On Sat, 28

Re: [PATCH] hwmon: corsair-psu: update supported devices

2020-11-30 Thread Wilken Gottwalt
On Mon, 30 Nov 2020 14:43:44 +0200 Thomas Backlund wrote: > Den 28.11.2020 kl. 12:35, skrev Wilken Gottwalt: > > On Sat, 28 Nov 2020 02:37:38 -0300 > > Jonas Malaco wrote: > > > >> On Thu, Nov 26, 2020 at 8:43 AM Wilken Gottwalt > >> wrote: > >&

Re: [PATCH] hwmon: corsair-psu: update supported devices

2020-11-30 Thread Wilken Gottwalt
On Mon, 30 Nov 2020 07:53:48 -0300 Jonas Malaco wrote: > On Mon, Nov 30, 2020 at 2:22 AM Wilken Gottwalt > wrote: > > > > On Sun, 29 Nov 2020 13:59:33 -0800 > > Guenter Roeck wrote: > > > > > On Sun, Nov 29, 2020 at 04:54:43PM +0100, Wilken Gottwalt wrot

Re: [PATCH] hwmon: corsair-psu: update supported devices

2020-11-29 Thread Wilken Gottwalt
On Sun, 29 Nov 2020 13:59:33 -0800 Guenter Roeck wrote: > On Sun, Nov 29, 2020 at 04:54:43PM +0100, Wilken Gottwalt wrote: > > On Sun, 29 Nov 2020 05:00:49 -0800 > > Guenter Roeck wrote: > > > > > On Sun, Nov 29, 2020 at 07:36:18AM +0100, Wilken Gottwalt wrote:

Re: [PATCH] hwmon: corsair-psu: update supported devices

2020-11-29 Thread Wilken Gottwalt
On Sun, 29 Nov 2020 05:00:49 -0800 Guenter Roeck wrote: > On Sun, Nov 29, 2020 at 07:36:18AM +0100, Wilken Gottwalt wrote: > > On Sat, 28 Nov 2020 17:21:40 -0300 > > Jonas Malaco wrote: > > > > > On Sat, Nov 28, 2020 at 7:35 AM Wilken Gottwalt > > > wro

Re: [PATCH] hwmon: corsair-psu: update supported devices

2020-11-28 Thread Wilken Gottwalt
On Sat, 28 Nov 2020 17:21:40 -0300 Jonas Malaco wrote: > On Sat, Nov 28, 2020 at 7:35 AM Wilken Gottwalt > wrote: > > > > On Sat, 28 Nov 2020 02:37:38 -0300 > > Jonas Malaco wrote: > > > > > On Thu, Nov 26, 2020 at 8:43 AM Wilken Gottwalt > > >

Re: [PATCH] hwmon: corsair-psu: update supported devices

2020-11-28 Thread Wilken Gottwalt
On Sat, 28 Nov 2020 02:37:38 -0300 Jonas Malaco wrote: > On Thu, Nov 26, 2020 at 8:43 AM Wilken Gottwalt > wrote: > > > > Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, > > AX1500i and AX1600i. The first 3 power supplies are supported through

Re: [PATCH 2/2] hwspinlock: add sunxi hardware spinlock support

2020-11-26 Thread Wilken Gottwalt
On Tue, 24 Nov 2020 08:54:25 -0600 Bjorn Andersson wrote: > On Mon 23 Nov 12:17 CST 2020, Wilken Gottwalt wrote: > > > On Sat, 21 Nov 2020 23:19:00 -0600 > > Bjorn Andersson wrote: > > > > +static int hwlocks_inuse_show(struct seq_file *seqf, void *unused) >

Re: [PATCH 2/2] hwspinlock: add sunxi hardware spinlock support

2020-11-26 Thread Wilken Gottwalt
On Mon, 23 Nov 2020 21:35:52 -0600 Samuel Holland wrote: > On 11/23/20 12:32 PM, Wilken Gottwalt wrote: > > On Sat, 21 Nov 2020 17:44:18 +0100 > > Maxime Ripard wrote: > > > >> On Sat, Nov 21, 2020 at 08:22:55PM +0800, fuyao wrote: > >>> On Fri, Nov 2

[PATCH] hwmon: corsair-psu: update supported devices

2020-11-26 Thread Wilken Gottwalt
in the driver and updates the hwmon documentation. This patch adds: - hwmon/corsair-psu documentation update - corsair-psu driver update Signed-off-by: Wilken Gottwalt --- Documentation/hwmon/corsair-psu.rst | 10 + drivers/hwmon/Kconfig | 7 +++--- drivers/hwmon/corsair

Re: [PATCH 2/2] hwspinlock: add sunxi hardware spinlock support

2020-11-23 Thread Wilken Gottwalt
On Sat, 21 Nov 2020 17:44:18 +0100 Maxime Ripard wrote: > On Sat, Nov 21, 2020 at 08:22:55PM +0800, fuyao wrote: > > On Fri, Nov 20, 2020 at 05:42:31PM +0100, Maxime Ripard wrote: > > > Hi, > > > > > > On Thu, Nov 19, 2020 at 11:13:43AM +0100, Wilken Gottwal

Re: [PATCH 2/2] hwspinlock: add sunxi hardware spinlock support

2020-11-23 Thread Wilken Gottwalt
> > + > > + return 0; > > +} > > + > > +static const struct of_device_id sunxi_hwspinlock_ids[] = { > > + { .compatible = "allwinner,sun8i-hwspinlock", }, > > + { .compatible = "allwinner,sun50i-hwspinlock", }, > > + {}, > > +}; > > +MODULE_DEVICE_TABLE(of, sunxi_hwspinlock_ids); > > + > > +static struct platform_driver sunxi_hwspinlock_driver = { > > + .probe = sunxi_hwspinlock_probe, > > + .remove = sunxi_hwspinlock_remove, > > + .driver = { > > + .name = DRIVER_NAME, > > + .of_match_table = of_match_ptr(sunxi_hwspinlock_ids), > > Please avoid of_match_ptr, as this will cause warnings about unused > variables when COMPILE_TEST without OF. So did you mean to leave it out completely? Thanks for looking through this, this really helps a lot. :-) greetings, Wilken > Regards, > Bjorn > > > + }, > > +}; > > + > > +static int __init sunxi_hwspinlock_init(void) > > +{ > > + return platform_driver_register(_hwspinlock_driver); > > +} > > +postcore_initcall(sunxi_hwspinlock_init); > > + > > +static void __exit sunxi_hwspinlock_exit(void) > > +{ > > + platform_driver_unregister(_hwspinlock_driver); > > +} > > +module_exit(sunxi_hwspinlock_exit); > > + > > +MODULE_LICENSE("GPL"); > > +MODULE_DESCRIPTION("SUNXI hardware spinlock driver"); > > +MODULE_AUTHOR("Wilken Gottwalt "); > > -- > > 2.29.2 > >

Re: [PATCH 2/2] hwspinlock: add sunxi hardware spinlock support

2020-11-19 Thread Wilken Gottwalt
On Thu, 19 Nov 2020 08:15:23 +0100 Maxime Ripard wrote: > > can you help me here a bit? I still try to figure out how to do patch sets > > properly. Some kernel submitting documentation says everything goes into the > > coverletter and other documentation only tells how to split the patches. So >

Re: [PATCH 2/2] hwspinlock: add sunxi hardware spinlock support

2020-11-18 Thread Wilken Gottwalt
Hi Maxime, On Wed, 18 Nov 2020 16:37:33 +0100 Maxime Ripard wrote: > Hi Wilken, > > On Wed, Nov 18, 2020 at 11:02:40AM +0100, Wilken Gottwalt wrote: > > Adds the sunxi_hwspinlock driver and updates makefiles/maintainers. > > > > Signed-off-by: Wilken Gottwalt >

[PATCH 2/2] hwspinlock: add sunxi hardware spinlock support

2020-11-18 Thread Wilken Gottwalt
Adds the sunxi_hwspinlock driver and updates makefiles/maintainers. Signed-off-by: Wilken Gottwalt --- MAINTAINERS | 6 + drivers/hwspinlock/Kconfig| 9 + drivers/hwspinlock/Makefile | 1 + drivers/hwspinlock/sunxi_hwspinlock.c | 282

[PATCH 1/2] dt-bindings: hwlock: sunxi: add sunxi_hwspinlock documentation

2020-11-18 Thread Wilken Gottwalt
Adds documentation on how to use/enable the sunxi_hwspinlock driver. Signed-off-by: Wilken Gottwalt --- .../bindings/hwlock/sunxi-hwspinlock.yaml | 64 +++ 1 file changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwlock/sunxi-hwspinlock.yaml

[PATCH 0/2] hwspinlock: add sunxi hardware spinlock support

2020-11-18 Thread Wilken Gottwalt
). This patch adds: - hwspinlock driver sunxi_hwspinlock - hwspinlock dt bindings documentation - updates MAINTAINERS Signed-off-by: Wilken Gottwalt Wilken Gottwalt (2): dt-bindings: hwlock: sunxi: add sunxi_hwspinlock documentation hwspinlock: add sunxi hardware spinlock support

[PATCH] hwmon: fix corsair-psu fan rpm calculation

2020-11-13 Thread Wilken Gottwalt
The correct fan rpm value is also a LINEAR11 value but without a factor. Verified by using the fan test button on the psu to let the fan spin up to maximum for some seconds. Fixes: 933222c98445 ("hwmon: (corsair-psu) fix unintentional sign extension issue") Signed-off-by: Wilke

[PATCH] documentation: arm: sunxi: add Allwinner H616 documents

2020-11-08 Thread Wilken Gottwalt
Add the current and cleaned Allwinner H616 datasheet and user manual. Signed-off-by: Wilken Gottwalt --- Documentation/arm/sunxi.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/arm/sunxi.rst b/Documentation/arm/sunxi.rst index 0c536ae1d7c2..b85d1e2f2d47 100644

Re: [PATCH][next] hwmon: corsair-psu: fix unintentional sign extension issue

2020-11-05 Thread Wilken Gottwalt
On Thu, 5 Nov 2020 06:15:49 -0800 Guenter Roeck wrote: > On Thu, Nov 05, 2020 at 01:32:33PM +0100, Wilken Gottwalt wrote: > > On Thu, 5 Nov 2020 11:50:19 + > > Colin King wrote: > > > > > From: Colin Ian King > > > > > > The shifting

Re: [PATCH][next] hwmon: corsair-psu: fix unintentional sign extension issue

2020-11-05 Thread Wilken Gottwalt
On Thu, 5 Nov 2020 11:50:19 + Colin King wrote: > From: Colin Ian King > > The shifting of the u8 integer data[3] by 24 bits to the left will > be promoted to a 32 bit signed int and then sign-extended to a > long. In the event that the top bit of data[3] is set then all > then all the

Re: [RESEND PATCH v3] hwmon: add Corsair PSU HID controller driver

2020-10-30 Thread Wilken Gottwalt
On Fri, 30 Oct 2020 10:33:23 -0700 Guenter Roeck wrote: > On Fri, Oct 30, 2020 at 06:38:31AM +0100, Wilken Gottwalt wrote: > > The Corsair digital power supplies of the series RMi, HXi and AXi include > > a small micro-controller with a lot of sensors attached. The sensors can

[RESEND PATCH v3] hwmon: add Corsair PSU HID controller driver

2020-10-29 Thread Wilken Gottwalt
not support configuring these devices, because there would be many ways to misconfigure or even damage the PSU. This patch adds: - hwmon driver corsair-psu - hwmon documentation - updates MAINTAINERS Signed-off-by: Wilken Gottwalt --- Changes in v3: - changed the email addresses because of serious email

[PATCH v3] hwmon: add Corsair PSU HID controller driver

2020-10-27 Thread Wilken Gottwalt
not support configuring these devices, because there would be many ways to misconfigure or even damage the PSU. This patch adds: - hwmon driver corsair-psu - hwmon documentation - updates MAINTAINERS Signed-off-by: Wilken Gottwalt --- Changes in v3: - changed the email addresses because of serious email

[PATCH v2] documentation: arm: sunxi: add Allwinner H6 documents

2020-10-27 Thread Wilken Gottwalt
Add the current Allwinner H6 datasheet and user manual. Signed-off-by: Wilken Gottwalt --- Changes in v2: - changed email because of serious problems between my old email provider and the lkml --- Documentation/arm/sunxi.rst | 10 ++ 1 file changed, 10 insertions

[PATCH 1/1] hwmon: add Corsair PSU HID controller driver

2020-10-25 Thread Wilken Gottwalt
Adds a driver for the Corsair PSU HID protocol, currently supporting all power supplies of the HXi/RMi series. Signed-off-by: Wilken Gottwalt --- Documentation/hwmon/corsair-psu.rst | 78 Documentation/hwmon/index.rst | 1 + MAINTAINERS | 7 + drivers

[PATCH 0/1] hwmon: add Corsair PSU HID controller driver

2020-10-25 Thread Wilken Gottwalt
configuring these devices, because there would be many ways to misconfigure or even damage the PSU. This patch adds: - hwmon driver corsair-psu - hwmon documentation - updates MAINTAINERS Wilken Gottwalt (1): hwmon: add Corsair PSU HID controller driver Documentation/hwmon/corsair-psu.rst | 78

[tip: perf/urgent] USB: serial: option: add Cellient MPL200 card

2020-10-19 Thread tip-bot2 for Wilken Gottwalt
The following commit has been merged into the perf/urgent branch of tip: Commit-ID: a016619f0587848b1bd7178e935956d95b41e07e Gitweb: https://git.kernel.org/tip/a016619f0587848b1bd7178e935956d95b41e07e Author:Wilken Gottwalt AuthorDate:Sat, 03 Oct 2020 11:40:29 +02:00

[PATCH] watchdog: via_wdt: add VX900 support

2020-10-10 Thread Wilken Gottwalt
Adds watchdog support for the VIA VX900 chip-set, which is fully backwards compatible to the older VIA chip-set watchdogs. Signed-off-by: Wilken Gottwalt --- drivers/watchdog/via_wdt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/via_wdt.c b/drivers/watchdog/via_wdt.c

[PATCH v2 2/2] usb: serial: option: add Cellient MPL200 card

2020-10-08 Thread Wilken Gottwalt
Add usb ids of the Cellient MPL200 card. Signed-off-by: Wilken Gottwalt --- drivers/usb/serial/option.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 0c6f160a214a..a65e620b2277 100644 --- a/drivers/usb/serial/option.c

[PATCH v2 1/2] net: usb: qmi_wwan: add Cellient MPL200 card

2020-10-08 Thread Wilken Gottwalt
Add usb ids of the Cellient MPL200 card. Signed-off-by: Wilken Gottwalt --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 07c42c0719f5..5ca1356b8656 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b

[PATCH v2 0/2] add Cellient MPL200 card

2020-10-08 Thread Wilken Gottwalt
Add the Cellient MPL200 card to usb/qmi_wwan and serial/option. The serial/option patch got already applied. Changes v2: Picked proper subject for qmi_wwan patch, moved the MPL200 device to the section of the combined devices and changed the comment about the device to be more precise. Wilken

Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card

2020-10-08 Thread Wilken Gottwalt
On Tue, 6 Oct 2020 09:02:01 +0200 Johan Hovold wrote: > On Mon, Oct 05, 2020 at 02:07:23PM +0200, Wilken Gottwalt wrote: > > On Mon, 5 Oct 2020 18:36:36 +0700 Lars Melin wrote: > > > On 10/5/2020 18:06, Johan Hovold wrote: > > > > > Do you remember the interfa

Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card

2020-10-05 Thread Wilken Gottwalt
On Mon, 5 Oct 2020 18:36:36 +0700 Lars Melin wrote: > On 10/5/2020 18:06, Johan Hovold wrote: > > On Mon, Oct 05, 2020 at 01:01:34PM +0200, Wilken Gottwalt wrote: > >> On Mon, 5 Oct 2020 10:20:45 +0200 > >> Johan Hovold wrote: > >> > >>> On Sat, O

Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card

2020-10-05 Thread Wilken Gottwalt
On Mon, 5 Oct 2020 13:06:38 +0200 Johan Hovold wrote: > On Mon, Oct 05, 2020 at 01:01:34PM +0200, Wilken Gottwalt wrote: > > On Mon, 5 Oct 2020 10:20:45 +0200 > > Johan Hovold wrote: > > > > > On Sat, Oct 03, 2020 at 11:40:29AM +0200, Wilken Gottwalt wrote: >

Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card

2020-10-05 Thread Wilken Gottwalt
On Mon, 5 Oct 2020 10:20:45 +0200 Johan Hovold wrote: > On Sat, Oct 03, 2020 at 11:40:29AM +0200, Wilken Gottwalt wrote: > > Add usb ids of the Cellient MPL200 card. > > > > Signed-off-by: Wilken Gottwalt > > --- > > drivers/usb/serial/option.c | 3 +++

Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card

2020-10-04 Thread Wilken Gottwalt
On Sun, 04 Oct 2020 17:29:38 +0200 Bjørn Mork wrote: > Wilken Gottwalt writes: > > > Add usb ids of the Cellient MPL200 card. > > > > Signed-off-by: Wilken Gottwalt > > --- > > drivers/net/usb/qmi_wwan.c | 1 + > > 1 file changed, 1 inserti

[PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card

2020-10-03 Thread Wilken Gottwalt
Add usb ids of the Cellient MPL200 card. Signed-off-by: Wilken Gottwalt --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 07c42c0719f5..0bf2b19d5d54 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b

[PATCH 2/2] usb: serial: option: add Cellient MPL200 card

2020-10-03 Thread Wilken Gottwalt
Add usb ids of the Cellient MPL200 card. Signed-off-by: Wilken Gottwalt --- drivers/usb/serial/option.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 0c6f160a214a..a65e620b2277 100644 --- a/drivers/usb/serial/option.c

[PATCH 0/2] add Cellient MPL200 card

2020-10-03 Thread Wilken Gottwalt
Add the Cellient MPL200 card to usb/qmi_wwan and serial/option. Wilken Gottwalt (2): usb: serial: qmi_wwan: add Cellient MPL200 card usb: serial: option: add Cellient MPL200 card drivers/net/usb/qmi_wwan.c | 1 + drivers/usb/serial/option.c | 3 +++ 2 files changed, 4 insertions

[PATCH] net: usb: ax88179_178a: add MCT usb 3.0 adapter

2020-09-28 Thread Wilken Gottwalt
Adds the driver_info and usb ids of the AX88179 based MCT U3-A9003 USB 3.0 ethernet adapter. Signed-off-by: Wilken Gottwalt --- drivers/net/usb/ax88179_178a.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c

[PATCH v2] net: usb: ax88179_178a: fix missing stop entry in driver_info

2020-09-28 Thread Wilken Gottwalt
Adds the missing .stop entry in the Belkin driver_info structure. Signed-off-by: Wilken Gottwalt --- Changes in v2: - reposted to proper mailing list --- drivers/net/usb/ax88179_178a.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb

[PATCH v2] net: usb: ax88179_178a: add Toshiba usb 3.0 adapter

2020-09-25 Thread Wilken Gottwalt
Adds the driver_info and usb ids of the AX88179 based Toshiba USB 3.0 ethernet adapter. Signed-off-by: Wilken Gottwalt --- Changes in v2: - reposted to proper mailing list with correct commit message as suggested by Jakub Kicinski --- drivers/net/usb/ax88179_178a.c | 17

[PATCH] net: usb: ax88179_178a: add Toshiba usb 3.0 adapter

2020-09-24 Thread Wilken Gottwalt
Reposted and added netdev as suggested by Jakub Kicinski. --- Adds the driver_info and usb ids of the AX88179 based Toshiba USB 3.0 ethernet adapter. Signed-off-by: Wilken Gottwalt --- drivers/net/usb/ax88179_178a.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers

[PATCH] net: usb: ax88179_178a: add Toshiba usb 3.0 adapter

2020-09-23 Thread Wilken Gottwalt
Adds the driver_info and usb ids of the AX88179 based Toshiba USB 3.0 ethernet adapter. Signed-off-by: Wilken Gottwalt --- drivers/net/usb/ax88179_178a.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index

[PATCH] net: usb: ax88179_178a fix missing stop entry in belkin product

2020-09-23 Thread Wilken Gottwalt
Added the missing .stop entry in the driver_info of the Belking device. Signed-off-by: Wilken Gottwalt --- drivers/net/usb/ax88179_178a.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index a38e868e44d4..ac7bc436da33 100644

[PATCH v3] documentation: arm: sunxi: Allwinner H2+/H3 update

2020-09-23 Thread Wilken Gottwalt
Replaced the link to the datasheet by a link to the current version. Signed-off-by: Wilken Gottwalt --- Changes in v3: - removed the description of the H2+/H3 differences Changes in v2: - addressed comments/proposals from Maxime --- Documentation/arm/sunxi.rst | 2 +- 1 file

[PATCH v2] documentation: arm: sunxi: Allwinner H2+/H3 update

2020-09-13 Thread Wilken Gottwalt
Updated information about H2+ and H3 differences and added a link to a slightly newer datasheet. Signed-off-by: Wilken Gottwalt --- Changes in v2: - addressed comments/proposals from Maxime --- Documentation/arm/sunxi.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

Re: [PATCH] dt-bindings: arm: sunxi: update H2+/H3 cpu clocks

2020-09-13 Thread Wilken Gottwalt
On Wed, 9 Sep 2020 17:53:07 +0200 Maxime Ripard wrote: > On Wed, Sep 09, 2020 at 03:54:46PM +0200, Wilken Gottwalt wrote: > > On Wed, 9 Sep 2020 14:08:59 +0200 > > Maxime Ripard wrote: > > > Hi! > > > > > > Thanks for contributing > > > &

Re: [PATCH] dt-bindings: arm: sunxi: update H2+/H3 cpu clocks

2020-09-09 Thread Wilken Gottwalt
L. Thanks for the correction. > On Thu, Sep 03, 2020 at 12:07:08PM +0200, Wilken Gottwalt wrote: > > Change H2+/H3 clocks to 8 steps from 528 MHz up to 1200 MHz to support a > > more fine-grained powersave setup. The SoCs are made for 1296 MHz, so > > these clocks are still i

[PATCH] documentation: arm: sunxi: Allwinner H2+/H3 update

2020-09-08 Thread Wilken Gottwalt
Updated information about H2+ and H3 difference and added a link to a slightly newer datasheet. Signed-off-by: Wilken Gottwalt --- Documentation/arm/sunxi.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/arm/sunxi.rst b/Documentation/arm/sunxi.rst index b037428aee98

[PATCH] dt-bindings: arm: sunxi: update H2+/H3 cpu clocks

2020-09-03 Thread Wilken Gottwalt
Change H2+/H3 clocks to 8 steps from 528 MHz up to 1200 MHz to support a more fine-grained powersave setup. The SoCs are made for 1296 MHz, so these clocks are still in a safe range. Tested on a NanoPi Duo and OrangePi Zero. Signed-off-by: Wilken Gottwalt --- arch/arm/boot/dts/sun8i-h3.dtsi