Hi, Jiaxun,
1, To describe CPU I prefer "loongson" to "ls" because "ls" is confusing, and
in future we will use ls2h/ls7a to describe Loongson's bridge.
2, I think it is better to use loongson64c/loongson64g than
loongson2ef/loongson64. As we disscussed, we will use
Hi, Greg,
Patch for 4.9 (and below 4.9) is here:
https://patchwork.linux-mips.org/patch/21375/
Huacai
-- Original --
From: "陈华才";
Date: Thu, Mar 14, 2019 06:55 AM
To: "gregkh";
Cc: "linux-kernel";
"stable"; &
vectors) is correct.
There may be similar problems except nvme.
Huacai
-- Original --
From: "Thomas Gleixner";
Date: Thu, Feb 14, 2019 09:31 PM
To: "陈华才";
Cc: "Keith Busch"; "Bjorn Helgaas";
"Jens Axboe"; &
I'll test next week, but 4.19 has the same problem, how to fix that for 4.19?
Huacai
-- Original --
From: "Thomas Gleixner";
Date: Thu, Feb 14, 2019 04:50 PM
To: "Keith Busch";
Cc: "Bjorn Helgaas"; "Jens Axboe"; "Sagi
Grimberg"; "linux-pci";
"LKML";
陈华才
江苏中科梦兰电子科技有限公司/自主安全事业部/软件部
江苏常熟虞山镇梦兰村
-- Original --
From: "Thomas Gleixner";
Date: Wed, Jan 16, 2019 05:26 PM
To: "陈华才";
Cc: "linux-kernel"; "Fuxin
Zhang"; "wuzhangjin";
"stable"; &qu
Hi, Thomas,
I'm not removing all return NULL of irq_create_affinity_masks(), so the memory
allocation failure still return NULL. I just handle the case that there are not
enough irq vectors. E.g. in nvme driver, the caller may call
irq_create_affinity_masks() with
Hi,
It seems the patch below can solve many problems after switched to NO_BOOTMEM,
because the memory allocation behavior is more similar as before.
diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index 070234b..7a449d9 100644
--- a/arch/mips/kernel/setup.c
+++
Hi,
It seems the patch below can solve many problems after switched to NO_BOOTMEM,
because the memory allocation behavior is more similar as before.
diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index 070234b..7a449d9 100644
--- a/arch/mips/kernel/setup.c
+++
Hi, Sudeep,
I use MIPS, and there is no "size" in
/sys/devices/system/cpu/cpuX/cache/indexX/ file after your patch. Because the
DT node only has "next-level-cache = <>;" but has no "size" information.
Huacai
-- Original --
From: "Sudeep Holla";
Date: Thu,
Hi, Sudeep,
I use MIPS, and there is no "size" in
/sys/devices/system/cpu/cpuX/cache/indexX/ file after your patch. Because the
DT node only has "next-level-cache = <>;" but has no "size" information.
Huacai
-- Original --
From: "Sudeep Holla";
Date: Thu,
Hi, Paul,
SFB can improve the memory bandwidth as much as 30%, and we are planning to
enable SFB by default. So, we want to control cpu_relax() under
CONFIG_CPU_LOONGSON3, not under CONFIG_LOONGSON3_ENHANCEMENT.
Huacai
-- Original --
From: "Paul Burton";
Hi, Paul,
SFB can improve the memory bandwidth as much as 30%, and we are planning to
enable SFB by default. So, we want to control cpu_relax() under
CONFIG_CPU_LOONGSON3, not under CONFIG_LOONGSON3_ENHANCEMENT.
Huacai
-- Original --
From: "Paul Burton";
19
Huacai
-- Original --
From: "Greg Kroah-Hartman";
Date: Tue, Jul 17, 2018 03:20 PM
To: "陈华才";
Cc: "linux-kernel";
"stable"; "Paul Burton"; "James
Hogan";
Subject: Re: [PATCH 4.9 03/32] MIPS: Use
asy
19
Huacai
-- Original --
From: "Greg Kroah-Hartman";
Date: Tue, Jul 17, 2018 03:20 PM
To: "陈华才";
Cc: "linux-kernel";
"stable"; "Paul Burton"; "James
Hogan";
Subject: Re: [PATCH 4.9 03/32] MIPS: Use
asy
Hi, Greg,
I have backported and tested it to 4.9 and 4.4:
https://patchwork.linux-mips.org/patch/19862/
https://patchwork.linux-mips.org/patch/19863/
Huacai
-- Original --
From: "Greg Kroah-Hartman";
Date: Tue, Jul 17, 2018 02:34 AM
To: "陈华
Hi, Greg,
I have backported and tested it to 4.9 and 4.4:
https://patchwork.linux-mips.org/patch/19862/
https://patchwork.linux-mips.org/patch/19863/
Huacai
-- Original --
From: "Greg Kroah-Hartman";
Date: Tue, Jul 17, 2018 02:34 AM
To: "陈华
Just change "call_single_data_t" to "struct call_single_data" and everything is
OK.
Huacai
-- Original --
From: "Greg Kroah-Hartman";
Date: Mon, Jul 16, 2018 05:40 PM
To: "陈华才";
Cc: "linux-kernel";
&quo
Just change "call_single_data_t" to "struct call_single_data" and everything is
OK.
Huacai
-- Original --
From: "Greg Kroah-Hartman";
Date: Mon, Jul 16, 2018 05:40 PM
To: "陈华才";
Cc: "linux-kernel";
&quo
Hi, Greg,
kernel-4.9 doesn't have call_single_data_t, we should use struct
call_single_data instead.
Huacai
-- Original --
From: "Greg Kroah-Hartman";
Date: Mon, Jul 16, 2018 03:36 PM
To: "linux-kernel";
Cc: "Greg Kroah-Hartman";
"stable"; "Paul Burton";
Hi, Greg,
kernel-4.9 doesn't have call_single_data_t, we should use struct
call_single_data instead.
Huacai
-- Original --
From: "Greg Kroah-Hartman";
Date: Mon, Jul 16, 2018 03:36 PM
To: "linux-kernel";
Cc: "Greg Kroah-Hartman";
"stable"; "Paul Burton";
Hi, Peter,
I'm afraid that you have missing something..
Firstly, our previous conclusion (READ_ONCE need a barrier to avoid 'reads
prioritised over writes') is totally wrong. So define cpu_relax() to smp_mb()
like ARM11MPCore is incorrect, even if it can 'solve' Loongson's problem.
Hi, Peter,
I'm afraid that you have missing something..
Firstly, our previous conclusion (READ_ONCE need a barrier to avoid 'reads
prioritised over writes') is totally wrong. So define cpu_relax() to smp_mb()
like ARM11MPCore is incorrect, even if it can 'solve' Loongson's problem.
ads prioritised over writes",
which is caused by SFB's weak ordering and similar to ARM11MPCore (mentioned by
Will Deacon).
Huacai
-- Original --
From: "Peter Zijlstra";
Date: Tue, Jun 19, 2018 03:22 PM
To: "陈华才";
Cc: "Paul Burton&
ads prioritised over writes",
which is caused by SFB's weak ordering and similar to ARM11MPCore (mentioned by
Will Deacon).
Huacai
-- Original --
From: "Peter Zijlstra";
Date: Tue, Jun 19, 2018 03:22 PM
To: "陈华才";
Cc: "Paul Burton&
Hi, Paul,
First of all, could you please check why linux-mips reject e-mails from
lemote.com? Of course I can send e-mails by gmail, but my gmail can't receive
e-mails from linux-mips since March, 2018.
I have already read Documentation/memory-barriers.txt, but I don't think we
should define
Hi, Paul,
First of all, could you please check why linux-mips reject e-mails from
lemote.com? Of course I can send e-mails by gmail, but my gmail can't receive
e-mails from linux-mips since March, 2018.
I have already read Documentation/memory-barriers.txt, but I don't think we
should define
Allwinner devices are OK, Exynos devices (except 4210) are OK.
-- Original --
From: "Tony Lindgren"<t...@atomide.com>;
Date: Mon, Mar 26, 2018 11:37 PM
To: "陈华才"<che...@lemote.com>;
Cc: "Andrew Morton"<a...@
Allwinner devices are OK, Exynos devices (except 4210) are OK.
-- Original --
From: "Tony Lindgren";
Date: Mon, Mar 26, 2018 11:37 PM
To: "陈华才";
Cc: "Andrew Morton"; "Fabio
Estevam"; "Stephen Rothwell"
Hi, Tony and Fabio,
Could you please upload your kernel binary to somewhere for me? I don't
understand why some ARM boards is OK while others are broken.
Huacai
-- Original --
From: "Andrew Morton";
Date: Sat, Mar 24, 2018 03:15 AM
Hi, Tony and Fabio,
Could you please upload your kernel binary to somewhere for me? I don't
understand why some ARM boards is OK while others are broken.
Huacai
-- Original --
From: "Andrew Morton";
Date: Sat, Mar 24, 2018 03:15 AM
To: "Fabio Estevam";
Cc:
But in b44_init(), there is no device instances.
-- Original --
From: "Christoph Hellwig";
Date: Fri, Nov 10, 2017 08:30 PM
To: "Huacai Chen";
Cc: "Christoph Hellwig"; "Marek
But in b44_init(), there is no device instances.
-- Original --
From: "Christoph Hellwig";
Date: Fri, Nov 10, 2017 08:30 PM
To: "Huacai Chen";
Cc: "Christoph Hellwig"; "Marek
Szyprowski"; "Robin Murphy";
"Andrew Morton"; "Fuxin Zhang";
"linux-kernel";
Only patch 4 can be merged to stable, please ignore cc-stable in the rest.
-- Original --
From: "Christoph Hellwig"<h...@lst.de>;
Date: Fri, Nov 3, 2017 01:14 PM
To: "陈华才"<che...@lemote.com>;
Cc: "Marek Szyprowski&q
Only patch 4 can be merged to stable, please ignore cc-stable in the rest.
-- Original --
From: "Christoph Hellwig";
Date: Fri, Nov 3, 2017 01:14 PM
To: "陈华才";
Cc: "Marek Szyprowski"; "Christoph
Hellwig"; "
Why this is still un-merged? Should I remove the cc-stable and resend this
series?
Huacai
-- Original --
From: "陈华才"<che...@lemote.com>;
Date: Thu, Oct 26, 2017 02:33 PM
To: "Marek Szyprowski"<m.szyprow...@samsung.com>;
Why this is still un-merged? Should I remove the cc-stable and resend this
series?
Huacai
-- Original --
From: "陈华才";
Date: Thu, Oct 26, 2017 02:33 PM
To: "Marek Szyprowski"; "Christoph
Hellwig";
Cc: "Robin Murp
Maybe my first version is suitable for stable.
Huacai
-- Original --
From: "Marek Szyprowski"<m.szyprow...@samsung.com>;
Date: Wed, Oct 25, 2017 03:21 PM
To: "陈华才"<che...@lemote.com>; "Christoph Hellwig"<
Maybe my first version is suitable for stable.
Huacai
-- Original --
From: "Marek Szyprowski";
Date: Wed, Oct 25, 2017 03:21 PM
To: "陈华才"; "Christoph Hellwig";
Cc: "Robin Murphy"; "Andrew
Morton&quo
Hi, Marek
Patch3 is needed for stable, but Patch3 depend on Patch1 and Patch2.
Huacai
-- Original --
From: "Marek Szyprowski";
Date: Tue, Oct 24, 2017 09:30 PM
To: "Huacai Chen"; "Christoph Hellwig";
Hi, Marek
Patch3 is needed for stable, but Patch3 depend on Patch1 and Patch2.
Huacai
-- Original --
From: "Marek Szyprowski";
Date: Tue, Oct 24, 2017 09:30 PM
To: "Huacai Chen"; "Christoph Hellwig";
Cc: "Robin Murphy"; "Andrew
Morton"; "Fuxin Zhang";
Hi, Matt,
I found that 4ee34ea3a12396f35b26d90a094c75db ("libata: Align ata_device's id
on a cacheline") can resolve everything. Because the size of id[ATA_ID_WORDS]
is already aligned and devslp_timing needn't to be aligned. So, In V9 of this
series I will drop this patch. Why I had problems
Hi, Matt,
I found that 4ee34ea3a12396f35b26d90a094c75db ("libata: Align ata_device's id
on a cacheline") can resolve everything. Because the size of id[ATA_ID_WORDS]
is already aligned and devslp_timing needn't to be aligned. So, In V9 of this
series I will drop this patch. Why I had problems
Hi, Marek,
Yes, I know in include/linux/slab.h, there is
#define KMALLOC_MIN_SIZE ARCH_DMA_MINALIGN
But I observed that the req/resp isn't aligned to ARCH_DMA_MINALIGN and I don't
know why.
Problems I experienced is: In non-coherent mode, mvsas with an expander cannot
detect any disks.
Hi, Marek,
Yes, I know in include/linux/slab.h, there is
#define KMALLOC_MIN_SIZE ARCH_DMA_MINALIGN
But I observed that the req/resp isn't aligned to ARCH_DMA_MINALIGN and I don't
know why.
Problems I experienced is: In non-coherent mode, mvsas with an expander cannot
detect any disks.
Hi, Sergei,
Without this patch, in non-coherent mode, ata_do_set_mode() return with "no PIO
support", and disk detection fails.
Huacai
-- Original --
From: "Sergei Shtylyov";
Date: Tue, Oct 17, 2017 05:43 PM
To: "Huacai
Hi, Sergei,
Without this patch, in non-coherent mode, ata_do_set_mode() return with "no PIO
support", and disk detection fails.
Huacai
-- Original --
From: "Sergei Shtylyov";
Date: Tue, Oct 17, 2017 05:43 PM
To: "Huacai Chen"; "Christoph Hellwig";
Cc:
Hi, Christoph,
Can I put the declaration in asm/dma-coherence.h?
And, last time you said it is OK to pass a NULL to dma_get_cache_alignment()
and cc all driver maintainers. I have do so.
Huacai
-- Original --
From: "Christoph Hellwig";
Date: Mon,
Hi, Christoph,
Can I put the declaration in asm/dma-coherence.h?
And, last time you said it is OK to pass a NULL to dma_get_cache_alignment()
and cc all driver maintainers. I have do so.
Huacai
-- Original --
From: "Christoph Hellwig";
Date: Mon, Sep 25, 2017
Hi, Robin,
Can ARM/ARM64 use the same implementation as MIPS? Or I just do MIPS things is
OK?
Huacai
-- Original --
From: "Robin Murphy";
Date: Mon, Sep 25, 2017 08:57 PM
To: "Huacai Chen"; "Christoph
Hi, Robin,
Can ARM/ARM64 use the same implementation as MIPS? Or I just do MIPS things is
OK?
Huacai
-- Original --
From: "Robin Murphy";
Date: Mon, Sep 25, 2017 08:57 PM
To: "Huacai Chen"; "Christoph Hellwig";
Cc: "Marek Szyprowski"; "Andrew
Morton";
Hi, Robin,
Before 2.6.36 dma_get_cache_alignment is arch-dependent, and it is unified in
commit 4565f0170dfc849b3629c27d7 ("dma-mapping: unify dma_get_cache_alignment
implementations"). Should we revert to the old implementation?
Huacai
-- Original --
From:
Hi, Robin,
Before 2.6.36 dma_get_cache_alignment is arch-dependent, and it is unified in
commit 4565f0170dfc849b3629c27d7 ("dma-mapping: unify dma_get_cache_alignment
implementations"). Should we revert to the old implementation?
Huacai
-- Original --
From:
Hi, Christoph,
I have changed dma_get_cache_alignment's return value, and I don't know whether
those drivers want to return ARCH_DMA_MINALIGN unconditionally. So I pass a
NULL for those drivers, in order to keep their old behavior.
Huacai
-- Original --
From:
Hi, Christoph,
I have changed dma_get_cache_alignment's return value, and I don't know whether
those drivers want to return ARCH_DMA_MINALIGN unconditionally. So I pass a
NULL for those drivers, in order to keep their old behavior.
Huacai
-- Original --
From:
Oh, I know, I've make a mistake, dmapool doesn't need to change.
Huacai
-- Original --
From: "Christoph Hellwig";
Date: Mon, Sep 18, 2017 11:51 PM
To: "Robin Murphy";
Cc: "Huacai Chen"; "Andrew
Oh, I know, I've make a mistake, dmapool doesn't need to change.
Huacai
-- Original --
From: "Christoph Hellwig";
Date: Mon, Sep 18, 2017 11:51 PM
To: "Robin Murphy";
Cc: "Huacai Chen"; "Andrew
Morton"; "Fuxin Zhang";
"linux-mm"; "linux-kernel";
Hi, Christoph,
I don't think dma_get_cache_alignment is the "absolute minimum alignment" in
all cases. At least on MIPS/Loongson, if we use I/O coherent mode (Cached DMA
mode), align block queue to 4Bytes is enough. If we align block queue to
dma_get_cache_alignment in I/O coherent mode,
Hi, Christoph,
I don't think dma_get_cache_alignment is the "absolute minimum alignment" in
all cases. At least on MIPS/Loongson, if we use I/O coherent mode (Cached DMA
mode), align block queue to 4Bytes is enough. If we align block queue to
dma_get_cache_alignment in I/O coherent mode,
Hi, Christoph,
Maybe you missed something.
1, pool_alloc_page() use dma_alloc_coherent() to allocate pool pages, and of
course these pages are aligned to ARCH_DMA_MINALIGN.
2, dma_pool_alloc() is the element allocator, but it doesn't use
dma_alloc_coherent(). Elements only align to pool->size,
Hi, Christoph,
Maybe you missed something.
1, pool_alloc_page() use dma_alloc_coherent() to allocate pool pages, and of
course these pages are aligned to ARCH_DMA_MINALIGN.
2, dma_pool_alloc() is the element allocator, but it doesn't use
dma_alloc_coherent(). Elements only align to pool->size,
Hi, Andrew,
It will cause data corruption, at least on MIPS:
step 1, dma_map_single
step 2, cache_invalidate (no writeback)
step 3, dma_from_device
step 4, dma_unmap_single
If a DMA buffer and a kernel structure share a same cache line, and if the
kernel structure has dirty data,
Hi, Andrew,
It will cause data corruption, at least on MIPS:
step 1, dma_map_single
step 2, cache_invalidate (no writeback)
step 3, dma_from_device
step 4, dma_unmap_single
If a DMA buffer and a kernel structure share a same cache line, and if the
kernel structure has dirty data,
Hi, Christoph
I think we cannot modify dma_get_cache_alignment(), because existing callers
may want to unconditionally return ARCH_DMA_MINALIGN.
Huacai
-- Original --
From: "Christoph Hellwig";
Date: Mon, Sep 11, 2017 03:39 PM
To:
Hi, Christoph
I think we cannot modify dma_get_cache_alignment(), because existing callers
may want to unconditionally return ARCH_DMA_MINALIGN.
Huacai
-- Original --
From: "Christoph Hellwig";
Date: Mon, Sep 11, 2017 03:39 PM
To: "Huacai Chen";
Cc:
Hi,
I have already told Sasha that "MIPS: Reserve nosave data for hibernation"
should not be backported to 4.1/3.18. But he has no response.
Huacai
-- Original --
From: "Guenter Roeck";
Date: Mon, Aug 1, 2016 07:57 AM
To: "Sasha
Hi,
I have already told Sasha that "MIPS: Reserve nosave data for hibernation"
should not be backported to 4.1/3.18. But he has no response.
Huacai
-- Original --
From: "Guenter Roeck";
Date: Mon, Aug 1, 2016 07:57 AM
To: "Sasha Levin";
Cc: "stable";
Hi,
Could you please remove the line "#define cpu_hwrena_impl_bits0xc000"
in arch/mips/include/asm/mach-loongson64/cpu-feature-overrides.h and try
again?Thanks.
Huacai
-- Original --
From: "Guenter Roeck";
Date: Wed, Apr 20, 2016
Hi,
Could you please remove the line "#define cpu_hwrena_impl_bits0xc000"
in arch/mips/include/asm/mach-loongson64/cpu-feature-overrides.h and try
again?Thanks.
Huacai
-- Original --
From: "Guenter Roeck";
Date: Wed, Apr 20, 2016 10:54 AM
To:
Acked-by: Huacai Chen
-- Original --
From: "Guenter Roeck";
Date: Fri, Aug 7, 2015 01:57 PM
To: "Ralf Baechle";
Cc: "Huacai Chen"; "linux-mips";
"linux-kernel"; "Guenter
Roeck";
Subject: [PATCH] mips: Fix console output for Fulong2e system
Commit
Acked-by: Huacai Chen che...@lemote.com
-- Original --
From: Guenter Roeckli...@roeck-us.net;
Date: Fri, Aug 7, 2015 01:57 PM
To: Ralf Baechler...@linux-mips.org;
Cc: Huacai Chenche...@lemote.com; linux-mipslinux-m...@linux-mips.org;
Reviewed-off-by: Huacai Chen
-- Original --
From: "weiyj_lk";
Date: Tue, Aug 12, 2014 08:26 PM
To: "Ralf Baechle"; "Huacai Chen";
Cc: "Wei Yongjun";
"linux-mips";
"linux-kernel";
Subject: [PATCH -next] MIPS: Remove duplicated include from numa.c
From:
Reviewed-off-by: Huacai Chen che...@lemote.com
-- Original --
From: weiyj_lkweiyj...@163.com;
Date: Tue, Aug 12, 2014 08:26 PM
To: Ralf Baechler...@linux-mips.org; Huacai Chenche...@lemote.com;
Cc: Wei Yongjunyongjun_...@trendmicro.com.cn;
> On Wed, 30 Oct 2013, "陈华才" wrote:
>
>> I use a Loongson-3(MIPS-series CPU) machine, there is a serial port
>> integrated in the CPU (but it iss buggy), and it use handle_percpu_irq()
>> as the irq handler. Maybe I should move the checking into
>>
I use a Loongson-3(MIPS-series CPU) machine, there is a serial port
integrated in the CPU (but it iss buggy), and it use handle_percpu_irq()
as the irq handler. Maybe I should move the checking into
handle_percpu_irq()?
Huacai
> On Sat, 28 Sep 2013, Huacai Chen wrote:
>
>> Some devices (e.g.
I use a Loongson-3(MIPS-series CPU) machine, there is a serial port
integrated in the CPU (but it iss buggy), and it use handle_percpu_irq()
as the irq handler. Maybe I should move the checking into
handle_percpu_irq()?
Huacai
On Sat, 28 Sep 2013, Huacai Chen wrote:
Some devices (e.g. serial
On Wed, 30 Oct 2013, 陈华才 wrote:
I use a Loongson-3(MIPS-series CPU) machine, there is a serial port
integrated in the CPU (but it iss buggy), and it use handle_percpu_irq()
as the irq handler. Maybe I should move the checking into
handle_percpu_irq()?
Why is a device interrupt using
build_r4000_tlb_modify_handler();
> + if (!cpu_has_local_ebase)
> + build_r4000_tlb_refill_handler();
> run_once++;
> }
> - build_r4000_tlb_refill_handler();
> + if (c
--
江苏中科梦兰电子科技有限公司
软件部 陈华才
E-mail: che...@lemote.com
Web: http://www.lemote.com/
Add: 江苏省常熟市虞山镇梦兰工业园
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
John, for patch 3 reworking, please tell me whether my
understanding is correct? (make cpu_has_coherent_cache
as a runtime option rather than config option), thank
you very much.
> Hi,
>
> ok, i dropped the series for now from my tree
>
> John
>
--
To unsubscribe from this list: send
John, for patch 3 reworking, please tell me whether my
understanding is correct? (make cpu_has_coherent_cache
as a runtime option rather than config option), thank
you very much.
Hi,
ok, i dropped the series for now from my tree
John
--
To unsubscribe from this list: send the
#ifndef cpu_has_coherent_cache
#define cpu_has_coherent_cache (cpu_data[0].options &
MIPS_CPU_INCLUSIVE_CACHES)
#endif
Besides, the SMP code has a bug to fix (IPI sending) and
patch 3, patch 6 need to update. So I think a V9 is needed :(
> On 25/01/13 01:15, 陈华才 wrote:
>> ok, I'
#ifndef cpu_has_coherent_cache
#define cpu_has_coherent_cache (cpu_data[0].options
MIPS_CPU_INCLUSIVE_CACHES)
#endif
Besides, the SMP code has a bug to fix (IPI sending) and
patch 3, patch 6 need to update. So I think a V9 is needed :(
On 25/01/13 01:15, 陈华才 wrote:
ok, I'll prepare v9
> http://patchwork.linux-mips.org/patch/4547/ has a few comments. Please
> prepare a patch asap to address those so i can fold it into the series.
>
> John
>
--
江苏中科梦兰电子科技有限公司
软件部 陈华才
E-mail: che...@lemote.com
Web: http://www.lemote.com/
Add: 江苏省常熟市虞山镇梦兰工业园
--
To unsub
-john.git;a=shortlog;h=refs/heads/mips-next-3.9
I cleaned up a few minor whitespace errors while merging.
http://patchwork.linux-mips.org/patch/4547/ has a few comments. Please
prepare a patch asap to address those so i can fold it into the series.
John
--
江苏中科梦兰电子科技有限公司
软件部 陈华才
E
> On Wed, 2012-10-24 at 20:34 +0800, 陈华才 wrote:
>> I see, this is an arch-specific bug, sorry for my carelessness and thank
>> you for your tips.
>
> What arch are you using? And what exactly did the arch do wrong? Most of
> the code involved seems to b
> On Wed, 2012-10-24 at 17:25 +0800, Huacai Chen wrote:
>> We found poweroff sometimes fails on our computers, so we have the
>> lock debug options configured. Then, when we do poweroff or take a
>> cpu down via cpu-hotplug, kernel complain as below. To resove this,
>> we modify
On Wed, 2012-10-24 at 17:25 +0800, Huacai Chen wrote:
We found poweroff sometimes fails on our computers, so we have the
lock debug options configured. Then, when we do poweroff or take a
cpu down via cpu-hotplug, kernel complain as below. To resove this,
we modify sched_ttwu_pending(),
On Wed, 2012-10-24 at 20:34 +0800, 陈华才 wrote:
I see, this is an arch-specific bug, sorry for my carelessness and thank
you for your tips.
What arch are you using? And what exactly did the arch do wrong? Most of
the code involved seems to be common code.
Going by c0_compare_interrupt
So I still think that "sched: Add missing call to calc_load_exit_idle()"
should be reverted in 3.5 branch...
> On 10/06/2012 01:23 AM, Peter Zijlstra wrote:
>> On Fri, 2012-10-05 at 10:10 -0700, Jonathan Nieder wrote:
>>> Peter Zijlstra wrote:
On Thu, 2012-10-04 at 15:27 -0700, Greg
So I still think that sched: Add missing call to calc_load_exit_idle()
should be reverted in 3.5 branch...
On 10/06/2012 01:23 AM, Peter Zijlstra wrote:
On Fri, 2012-10-05 at 10:10 -0700, Jonathan Nieder wrote:
Peter Zijlstra wrote:
On Thu, 2012-10-04 at 15:27 -0700, Greg Kroah-Hartman wrote:
pling load muck
>> and calling calc_load_exit_idle() from there is bound to confuse state.
>>
>> I hope.. damn this code ;-)
>>
>> I can't find wtf went wrong either, the initial patch 5167e8d5417bf5c
>> contains both hunks, but in that case the fixup 749c8814
, but in that case the fixup 749c8814f0 doesn't make
sense, not can I find anything in merge commits using:
git log -S calc_load_exit_idle kernel/time/tick-sched.c
/me puzzled
I'm puzzled as well. Any ideas if I should do anything here or not?
greg k-h
--
江苏中科梦兰电子科技有限公司
软件部 陈华才
E
92 matches
Mail list logo