-by: David Cohen daco...@gmail.com
---
drivers/media/i2c/Kconfig |8 -
drivers/media/i2c/Makefile |1 -
drivers/media/i2c/tcm825x.c | 937
---
drivers/media/i2c/tcm825x.h | 200 -
4 files changed, 0 insertions(+), 1146 deletions
Hi Laurent,
On 07/17/2012 04:24 AM, Laurent Pinchart wrote:
Hi David,
Thanks for the review.
You're welcome.
On Monday 16 July 2012 02:17:43 David Cohen wrote:
On 07/05/2012 11:38 PM, Laurent Pinchart wrote:
Instead of forcing all soc-camera drivers to go through the mid-layer to
handle
Hi Laurent,
On 07/17/2012 02:45 AM, Laurent Pinchart wrote:
Hi David,
Thank you for the review.
You're welcome.
On Monday 16 July 2012 01:24:37 David Cohen wrote:
On 07/05/2012 11:38 PM, Laurent Pinchart wrote:
Powering off a device is a best effort task: failure to execute one
);
+ v4l2_ctrl_handler_free(priv-handler);
+ media_entity_cleanup(sd-entity);
+ mutex_destroy(priv-lock);
For debugging purpose, maybe mutex_destroy() could be first one.
Kind regards.
David Cohen
+ kfree(priv);
+
+ return 0;
+}
+
+static const struct i2c_device_id s5k4ecgx_id
? If any earlier error happened but this last step is
fine, IMO we should not return 0.
Kind regards,
David Cohen
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
sets it back to true afterwards. So, in case you want
to have no functional change, it seems to me you should call
soc_camera_power_off() after that variable has its original value set
back.
In this case, even if you don't like my suggestion, you still need to
swap those 2 lines above. :)
Br,
David
Hi Antti,
On 04/04/2012 02:59 PM, Antti Palosaari wrote:
On 04.04.2012 14:47, Gianluca Gennari wrote:
Add several new USB IDs extracted from the Windows and Linux drivers
published
by the manufacturers (Terratec and AVerMedia).
+ [AF9035_07CA_0867] = {
+ USB_DEVICE(USB_VID_AVERMEDIA,
Hi,
On 04/03/2012 12:05 PM, Michael Büsch wrote:
Now that i2c transfers are fixed, 3 retries are enough.
Signed-off-by: Michael Bueschm...@bues.ch
---
Index: linux/drivers/media/common/tuners/fc0011.c
===
---
On 04/03/2012 01:07 PM, Michael Büsch wrote:
On Tue, 03 Apr 2012 12:58:16 +0300
David Cohendavid.a.co...@linux.intel.com wrote:
- while (!(vco_cal FC11_VCOCAL_OK) vco_retries 6) {
+ while (!(vco_cal FC11_VCOCAL_OK) vco_retries 3) {
Do we need to retry at all?
It is
it was triggered (like the statistic ones mentioned above),
instead of a bool empty flag, it may contain a counter. Then a
duplicated event will be raised and will still inform how many
intermediate events were lost. After event is dequeued once, the
counter could be reset.
Regards,
David Cohen
E.g. supposed
Hi Hans, Laurent,
On Tue, Jun 7, 2011 at 3:20 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On Tuesday, June 07, 2011 13:51:38 David Cohen wrote:
Hi Hans,
On Tue, Jun 7, 2011 at 2:29 PM, Hans Verkuil hverk...@xs4all.nl wrote:
While working on the control events I realized that the way we
On Tue, Jun 7, 2011 at 3:46 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On Tuesday, June 07, 2011 14:30:38 Sakari Ailus wrote:
Laurent Pinchart wrote:
Hi Hans and David,
On Tuesday 07 June 2011 13:51:38 David Cohen wrote:
On Tue, Jun 7, 2011 at 2:29 PM, Hans Verkuil hverk...@xs4all.nl
Hi Laurent,
On Thu, May 19, 2011 at 3:14 PM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi Sakari,
On Thursday 19 May 2011 12:41:14 Sakari Ailus wrote:
Hi,
This patchset implements RFC v4 of V4L2 API for flash devices [1], with
minor modifications, and adds the adp1653 flash
On Mon, Apr 18, 2011 at 1:43 PM, Bastian Hecht hec...@googlemail.com wrote:
2011/4/16 David Cohen daco...@gmail.com:
Hi Bastian,
On Thu, Apr 14, 2011 at 1:36 PM, Bastian Hecht hec...@googlemail.com wrote:
Yeah!
S... when I initialized the the camera (loading a 108 bytes
register
with last ongoing data. So, it
should have no ongoing data afterwards. Was that your question?
Br,
David Cohen
If you decide it should, I will gladly help you find out more, just
ask. It worked on an OMAP3530 before, but I do not know if it is the
hardware or isp software that changed
talked directly,
IMO (1 0), (1 1), ... could have a better readability to expose
how you want to define an expand these macros.
Br,
David Cohen
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Wed, Mar 30, 2011 at 5:18 PM, Sakari Ailus
sakari.ai...@maxwell.research.nokia.com wrote:
Laurent Pinchart wrote:
Hi Sakari,
Heippa,
Hello,
My 2 cents below.
On Wednesday 30 March 2011 14:44:25 Sakari Ailus wrote:
Laurent Pinchart wrote:
On Tuesday 29 March 2011 11:35:19 Sakari Ailus
On Wed, Mar 9, 2011 at 9:43 AM, Sakari Ailus
sakari.ai...@maxwell.research.nokia.com wrote:
David Cohen wrote:
ISP doesn't consider 0x0 as a valid address, so it should explicitly
exclude first page from allowed 'da' range.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/mach
an ambiguous situation. This patch set moves
fixed 'da' check to the input flags.
Br,
David Cohen
---
David Cohen (1):
omap: iovmm: don't check 'da' to set IOVMF_DA_FIXED flag
Michael Jones (1):
omap: iovmm: disallow mapping NULL address when IOVMF_DA_ANON is set
arch/arm/plat-omap/include
From: Michael Jones michael.jo...@matrix-vision.de
commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping the NULL
address if da_start==0, which would then not get unmapped. Disallow
this again if IOVMF_DA_ANON is set. And spell variable 'alignment'
correctly.
Signed-off-by: Michael
now
come from the user throught 'flags' parameter when mapping memory.
As IOVMF_DA_ANON and IOVMF_DA_FIXED are mutually exclusive, IOVMF_DA_ANON
can be removed. The driver will now check internally if IOVMF_DA_FIXED
is set or not.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/plat-omap
Hi Fernando,
On Tue, Mar 8, 2011 at 11:13 AM, Sakari Ailus
sakari.ai...@maxwell.research.nokia.com wrote:
Guzman Lugo, Fernando wrote:
On Mon, Mar 7, 2011 at 1:19 PM, David Cohen daco...@gmail.com wrote:
On Mon, Mar 7, 2011 at 9:17 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Mon
for ISP IOMMU instance.
David Cohen (2):
omap3: change ISP's IOMMU da_start address
omap: iovmm: don't check 'da' to set IOVMF_DA_FIXED/IOVMF_DA_ANON
flags
Michael Jones (1):
omap: iovmm: disallow mapping NULL address
arch/arm/mach-omap2/omap-iommu.c |2 +-
arch/arm/plat-omap/iovmm.c
ISP doesn't consider 0x0 as a valid address, so it should explicitly
exclude first page from allowed 'da' range.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/mach-omap2/omap-iommu.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/omap
From: Michael Jones michael.jo...@matrix-vision.de
commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping
the NULL address if da_start==0, which would then not get unmapped.
Disallow this again. And spell variable 'alignment' correctly.
Signed-off-by: Michael Jones
now
come from the user. IOVMF_DA_ANON will be automatically set if
IOVMF_DA_FIXED isn't set.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/plat-omap/iovmm.c | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat
Hi Sakari,
On Tue, Mar 8, 2011 at 4:06 PM, Sakari Ailus
sakari.ai...@maxwell.research.nokia.com wrote:
David Cohen wrote:
ISP doesn't consider 0x0 as a valid address, so it should explicitly
exclude first page from allowed 'da' range.
Signed-off-by: David Cohen daco...@gmail.com
---
arch
IOVMF_DA_FIXED/IOVMF_DA_ANON flags
Date: Tue, 8 Mar 2011 11:59:43 -0600
On Tue, Mar 8, 2011 at 6:46 AM, David Cohen daco...@gmail.com wrote:
Currently IOVMM driver sets IOVMF_DA_FIXED/IOVMF_DA_ANON flags according
to input 'da' address when mapping memory:
da == 0: IOVMF_DA_ANON
da != 0
On Tue, Mar 8, 2011 at 8:06 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Tue, Mar 8, 2011 at 6:46 AM, David Cohen daco...@gmail.com wrote:
From: Michael Jones michael.jo...@matrix-vision.de
commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping
the NULL address
better.
Br,
David Cohen
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Mar 8, 2011 at 9:46 PM, David Cohen daco...@gmail.com wrote:
[snip]
- flags |= (da ? IOVMF_DA_FIXED : IOVMF_DA_ANON);
+ if (~flags IOVMF_DA_FIXED)
+ flags |= IOVMF_DA_ANON;
could we use only one? both are mutual exclusive, what happen if flag
On Tue, Mar 8, 2011 at 9:53 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Tue, Mar 8, 2011 at 1:06 PM, David Cohen daco...@gmail.com wrote:
On Tue, Mar 8, 2011 at 8:06 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Tue, Mar 8, 2011 at 6:46 AM, David Cohen daco...@gmail.com
On Tue, Mar 8, 2011 at 10:04 PM, David Cohen daco...@gmail.com wrote:
*** BLURB HERE ***
Sorry for this garbage :/
Br,
David
David Cohen (2):
omap3: change ISP's IOMMU da_start address
omap: iovmm: don't check 'da' to set IOVMF_DA_FIXED flag
Michael Jones (1):
omap: iovmm: disallow
for ISP IOMMU instance.
Br,
David Cohen
---
David Cohen (2):
omap3: change ISP's IOMMU da_start address
omap: iovmm: don't check 'da' to set IOVMF_DA_FIXED flag
Michael Jones (1):
omap: iovmm: disallow mapping NULL address when IOVMF_DA_ANON is set
arch/arm/mach-omap2/omap-iommu.c
From: Michael Jones michael.jo...@matrix-vision.de
commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping the NULL
address if da_start==0, which would then not get unmapped. Disallow
this again if IOVMF_DA_ANON is set. And spell variable 'alignment'
correctly.
Signed-off-by: Michael
ISP doesn't consider 0x0 as a valid address, so it should explicitly
exclude first page from allowed 'da' range.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/mach-omap2/omap-iommu.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/omap
now
come from the user throught 'flags' parameter when mapping memory.
As IOVMF_DA_ANON and IOVMF_DA_FIXED are mutually exclusive, IOVMF_DA_ANON
can be removed. The driver will now check internally if IOVMF_DA_FIXED
is set or not.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/plat-omap
On Tue, Mar 8, 2011 at 10:31 PM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi David,
On Monday 07 March 2011 22:35:31 David Cohen wrote:
On Mon, Mar 7, 2011 at 11:19 PM, Laurent Pinchart wrote:
On Monday 07 March 2011 20:41:21 David Cohen wrote:
On Mon, Mar 7, 2011 at 9:25
On Mon, Mar 7, 2011 at 9:17 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Mon, Mar 7, 2011 at 7:10 AM, Michael Jones
michael.jo...@matrix-vision.de wrote:
From e7dbe4c4b64eb114f9b0804d6af3a3ca0e78acc8 Mon Sep 17 00:00:00 2001
From: Michael Jones michael.jo...@matrix-vision.de
Date:
On Mon, Mar 7, 2011 at 9:25 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Mon, Mar 7, 2011 at 1:19 PM, David Cohen daco...@gmail.com wrote:
On Mon, Mar 7, 2011 at 9:17 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Mon, Mar 7, 2011 at 7:10 AM, Michael Jones
michael.jo
On Mon, Mar 7, 2011 at 11:19 PM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi David,
Hi Laurent,
On Monday 07 March 2011 20:41:21 David Cohen wrote:
On Mon, Mar 7, 2011 at 9:25 PM, Guzman Lugo, Fernando wrote:
On Mon, Mar 7, 2011 at 1:19 PM, David Cohen wrote:
On Mon, Mar
.
Antti Koskipaa (1):
v4l: v4l2_subdev userspace crop API
David Cohen (1):
omap3isp: Statistics
Laurent Pinchart (36):
v4l: Share code between video_usercopy and video_ioctl2
v4l: subdev: Don't require core operations
v4l: subdev: Add device node support
Hi,
[snip]
Sorry, I should've mentioned: I'm using your media-0005-omap3isp branch
based on 2.6.38-rc5. I didn't have the problem with 2.6.37, either.
It's actually not related to mis-configuring the ISP pipeline like I
thought at first- it also happens after I have successfully captured
[snip]
From 2712f2fd087ca782e964c912c7f1973e7d84f2b7 Mon Sep 17 00:00:00 2001
From: Michael Jones michael.jo...@matrix-vision.de
Date: Fri, 4 Mar 2011 15:09:48 +0100
Subject: [PATCH] omap: iovmm: disallow mapping NULL address
commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping
)
are available in the git repository at:
git://linuxtv.org/pinchartl/media.git media-2.6.39-0005-omap3isp
The branch has been rebased on top of the latest for_v2.6.39 branch, with the
v4l2-ioctl.c conflict resolved.
Antti Koskipaa (1):
v4l: v4l2_subdev userspace crop API
David
Hi Mauro,
On Sat, Mar 5, 2011 at 12:16 AM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Hi Laurent,
Em 17-02-2011 13:06, Laurent Pinchart escreveu:
Hi Mauro,
The following changes since commit 85e2efbb1db9a18d218006706d6e4fbeb0216213:
Linux 2.6.38-rc5 (2011-02-15 19:23:45 -0800)
On Sat, Mar 5, 2011 at 12:43 AM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Em 04-03-2011 19:33, David Cohen escreveu:
Hi Mauro,
On Sat, Mar 5, 2011 at 12:16 AM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Hi Laurent,
Em 17-02-2011 13:06, Laurent Pinchart escreveu:
Hi Mauro
On Sat, Mar 5, 2011 at 1:49 AM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Em 04-03-2011 19:49, David Cohen escreveu:
On Sat, Mar 5, 2011 at 12:43 AM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Em 04-03-2011 19:33, David Cohen escreveu:
Hi Mauro,
On Sat, Mar 5, 2011 at 12:16 AM
On Mon, Feb 21, 2011 at 7:27 PM, Oleg Nesterov o...@redhat.com wrote:
On 02/21, Oleg Nesterov wrote:
On 02/21, Peter Zijlstra wrote:
afaict its needed because struct signal_struct and struct sighand_struct
include a wait_queue_head_t. The inclusion seems to come through
completion.h,
wake_up*() macros are used.
Signed-off-by: David Cohen daco...@gmail.com
---
include/linux/sched.h | 61 +-
include/linux/task_sched.h | 64
include/linux/wait.h |1 +
3 files changed, 66
: *** [drivers] Error 2
This file defines macros wake_up*() which use TASK_* defined on linux/sched.h.
But sched.h cannot be included on wait.h due to a circular dependency between
both files. This patch fixes such compilation and the circular dependency
problem.
Br,
David
---
David Cohen (1):
headers
On Mon, Feb 21, 2011 at 9:36 AM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Sat, Feb 19, 2011 at 06:04:58PM +0200, David Cohen wrote:
I have to disagree. The fundamental problem is the circular dependency
between those two files:
sched.h uses wait_queue_head_t defined in wait.h
wait.h
On Mon, Feb 21, 2011 at 1:05 PM, Alexey Dobriyan adobri...@gmail.com wrote:
On Mon, Feb 21, 2011 at 12:20 PM, David Cohen daco...@gmail.com wrote:
Currently sched.h and wait.h have circular dependency between both.
wait.h defines macros wake_up*() which use macros TASK_* defined by
sched.h
On Mon, Feb 21, 2011 at 3:57 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Mon, Feb 21, 2011 at 03:51:25PM +0200, Alexey Dobriyan wrote:
I rather have the split done and kill the circular dependency.
It's not circular for starters.
how come ? wait.h depends on sched and sched.h depends on
: *** [drivers] Error 2
This file defines macros wake_up*() which use TASK_* defined on linux/sched.h.
But sched.h cannot be included on wait.h due to a circular dependency between
both files. This patch fixes such compilation and the circular dependency
problem.
Br,
David
---
David Cohen (1):
headers
wake_up*() macros are used.
Signed-off-by: David Cohen daco...@gmail.com
---
include/linux/sched.h | 58 +-
include/linux/task_state.h | 61
include/linux/wait.h |1 +
3 files changed, 63
On Mon, Feb 21, 2011 at 5:54 PM, Peter Zijlstra pet...@infradead.org wrote:
On Mon, 2011-02-21 at 16:38 +0200, David Cohen wrote:
Currently sched.h and wait.h have circular dependency between both.
wait.h defines macros wake_up*() which use macros TASK_* defined by
sched.h. But as sched.h
On Sun, Feb 20, 2011 at 10:47 AM, Hans Verkuil hverk...@xs4all.nl wrote:
Hi David,
Hi Hans,
On Saturday, February 19, 2011 17:35:46 David Cohen wrote:
Hi,
This is the first patch (set) version to remove V4L2 internal device
interface.
I have converted tcm825x VGA sensor to V4L2 sub
Hi Sakari and Felipe,
On Tue, Feb 15, 2011 at 2:17 PM, Sakari Ailus
sakari.ai...@maxwell.research.nokia.com wrote:
Felipe Balbi wrote:
Hi,
On Tue, Feb 15, 2011 at 12:50:12PM +0100, Thomas Weber wrote:
Hello Felipe,
in include/linux/wait.h
#define wake_up(x) __wake_up(x,
On Sat, Feb 19, 2011 at 5:00 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Sat, Feb 19, 2011 at 01:35:09PM +0200, David Cohen wrote:
aha, now I get it, so shouldn't the real fix be including linux/sched.h
on linux/wait.h, I mean, it's linuux/wait.h who uses a symbol
defined in linux/sched.h
omap24xxcam driver.
- Define a new interface to handle xclk. OMAP3 ISP could be used as base.
- Use some base platform (probably N8X0) to add board code and test them.
- Remove V4L2 int device. :)
Br,
David
---
David Cohen (1):
tcm825x: convert driver to V4L2 sub device interface
drivers/media
This patch converts Toshiba TCM825X VGA camera sersor driver to V4L2 sub
device interface.
Signed-off-by: David Cohen daco...@gmail.com
---
drivers/media/video/tcm825x.c | 369 -
drivers/media/video/tcm825x.h |6 +-
2 files changed, 109 insertions
On Mon, Feb 14, 2011 at 3:50 PM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi Felipe,
Hello,
On Monday 14 February 2011 14:41:16 Felipe Balbi wrote:
On Mon, Feb 14, 2011 at 02:19:24PM +0100, Laurent Pinchart wrote:
On Monday 14 February 2011 13:35:59 Felipe Balbi wrote:
On Mon, Feb 14, 2011 at 3:18 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
Hi
On Mon, Feb 14, 2011 at 02:07:08PM +0100, Laurent Pinchart wrote:
diff --git a/arch/arm/mach-omap2/devices.h
b/arch/arm/mach-omap2/devices.h new file mode 100644
index 000..12ddb8a
--- /dev/null
+++
.
These patches are intended to 2.6.38.
Br,
David Cohen
---
David Cohen (2):
ov9640: use macro to request OmniVision OV9640 sensor private data
ov9640: fix OmniVision OV9640 sensor driver's priv data retrieving
drivers/media/video/ov9640.c | 19 +--
1 files changed, 9 insertions
This cleanup patch creates macro to request OmniVision OV9640 private
data, which increases readability.
Signed-off-by: David Cohen daco...@gmail.com
---
drivers/media/video/ov9640.c | 13 +
1 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/media/video/ov9640.c
OmniVision OV9640 driver wasn't requesting properly its private data
on I2C remove and video_probe functions. It was retrieving the V4L2
subdev struct address instead of priv struct's one. This patch fixes
such problem.
Signed-off-by: David Cohen daco...@gmail.com
---
drivers/media/video/ov9640
Hi,
On Tue, Dec 7, 2010 at 11:52 PM, Guennadi Liakhovetski
g.liakhovet...@gmx.de wrote:
Hi David
On Fri, 3 Dec 2010, David Cohen wrote:
OmniVision OV9640 driver wasn't deallocating properly its private data
as it was requesting the V4L2 subdev struct address instead of the priv
struct's
OmniVision OV9640 driver wasn't deallocating properly its private data
as it was requesting the V4L2 subdev struct address instead of the priv
struct's one. This patch fixes such problem.
Signed-off-by: David Cohen daco...@gmail.com
---
drivers/media/video/ov9640.c |3 ++-
1 files changed, 2
On Wed, Dec 8, 2010 at 1:15 AM, Guennadi Liakhovetski
g.liakhovet...@gmx.de wrote:
On Wed, 8 Dec 2010, David Cohen wrote:
OmniVision OV9640 driver wasn't deallocating properly its private data
as it was requesting the V4L2 subdev struct address instead of the priv
struct's one. This patch
Hi,
These patches fix OV9640 driver's I2C remove function.
Despite the patches are simple, they haven't been tested yet as I don't
have the hw.
Br,
David Cohen
---
David Cohen (2):
ov9640: use macro to request OmniVision OV9640 sensor private data
ov9640: fix OmniVision OV9640 sensor
This cleanup patch creates macro to request OmniVision OV9640 private
data, which increases readability.
Signed-off-by: David Cohen daco...@gmail.com
---
drivers/media/video/ov9640.c | 13 +
1 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/media/video/ov9640.c
OmniVision OV9640 driver wasn't deallocating properly its private data
as it was requesting the V4L2 subdev struct address instead of the priv
struct's one. This patch fixes such problem.
Signed-off-by: David Cohen daco...@gmail.com
---
drivers/media/video/ov9640.c |3 ++-
1 files changed, 2
if we'll like to know main ISP
regdump.
Comments are welcome. More cleanups for better subdevice isolation
are on the way.
Regards,
Sergio
Changelog:
v2:
- Improved logic in isp subdevs clock control (Thanks David Cohen)
- Renamed ispccdc_lsc_wait_prefetch - isp_ccdc_* to be clear
On Mon, Nov 22, 2010 at 04:19:42PM +0100, ext Aguirre, Sergio wrote:
Hi,
-Original Message-
From: David Cohen [mailto:david.co...@nokia.com]
Sent: Saturday, November 20, 2010 4:49 AM
To: ext Laurent Pinchart
Cc: Aguirre, Sergio; linux-media@vger.kernel.org
Subject: Re
Hi Laurent and Sergio,
On Mon, Nov 22, 2010 at 04:31:09PM +0100, ext Aguirre, Sergio wrote:
-Original Message-
From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com]
Sent: Saturday, November 20, 2010 11:31 AM
To: David Cohen
Cc: Aguirre, Sergio; linux-media
On Sat, Nov 20, 2010 at 12:10:11AM +0100, ext Aguirre, Sergio wrote:
-Original Message-
From: Aguirre, Sergio
Sent: Friday, November 19, 2010 9:44 AM
To: 'David Cohen'
Cc: Laurent Pinchart; linux-media@vger.kernel.org
Subject: RE: [omap3isp][PATCH v2 8/9] omap3isp: ccp2
On Fri, Nov 19, 2010 at 11:58:32PM +0100, ext Aguirre, Sergio wrote:
-Original Message-
From: Aguirre, Sergio
Sent: Friday, November 19, 2010 9:46 AM
To: 'David Cohen'
Cc: Laurent Pinchart; linux-media@vger.kernel.org
Subject: RE: [omap3isp][PATCH v2 7/9] omap3isp: Cleanup
On Sat, Nov 20, 2010 at 11:34:04AM +0100, ext Laurent Pinchart wrote:
Hi,
On Saturday 20 November 2010 11:00:30 David Cohen wrote:
On Sat, Nov 20, 2010 at 12:10:11AM +0100, ext Aguirre, Sergio wrote:
On Friday, November 19, 2010 9:44 AM Aguirre, Sergio wrote:
On Friday, November 19
On Sat, Nov 20, 2010 at 11:45:21AM +0100, Cohen David (Nokia-MS/Helsinki) wrote:
On Fri, Nov 19, 2010 at 11:58:32PM +0100, ext Aguirre, Sergio wrote:
-Original Message-
From: Aguirre, Sergio
Sent: Friday, November 19, 2010 9:46 AM
To: 'David Cohen'
Cc: Laurent
= 0x10,
I'm fine with this way, but (1 0), (1 1), ... has a better readability.
Br,
David Cohen
+};
+
enum isp_interface_type {
ISP_INTERFACE_PARALLEL,
ISP_INTERFACE_CSI2A_PHY2,
@@ -262,6 +270,7 @@ struct isp_device {
struct isp_csiphy isp_csiphy2;
unsigned
it
to isp_hist_dma_done could be a good cleanup as well.
But this is my opinion only. :)
Br,
David Cohen
+{
+ unsigned int wait;
+
+ isp_reg_writel(isp, IRQ0STATUS_CCDC_LSC_PREF_COMP_IRQ,
+OMAP3_ISP_IOMEM_MAIN, ISP_IRQ0STATUS);
+
+ /* timeout 1 ms */
+ for (wait = 0
Hi Sergio,
On Sat, Nov 20, 2010 at 12:23:47AM +0100, ext Sergio Aguirre wrote:
Hi,
These are some patches to make these operations more generic:
- Clock control is being controlled in a very crude manner by
subdevices, it should be centralized in isp.c.
- LSC prefetch wait check is
From: Cohen David (Nokia-MS/Helsinki) david.co...@nokia.com
The ISP core doesn't support pipelines with multiple video outputs. Revisit
this when it will be implemented, and return -EBUSY for now.
Signed-off-by: David Cohen david.co...@nokia.com
---
drivers/media/video/isp/ispccdc.c| 26
ISPCCP2_SYSCONFIG_MSTANDBY_MODE_NO \
+ (0x1 ISPCCP2_SYSCONFIG_MSTANDBY_MODE_SHIFT)
+#define ISPCCP2_SYSCONFIG_MSTANDBY_MODE_SMART\
+ (0x2 ISPCCP2_SYSCONFIG_MSTANDBY_MODE_SHIFT)
You can add some ISPCCP2_SYSCONFIG_MSTANDY_MODE_MASK, as 2 bits must be
always set together.
Regards,
David
Hi Sergio,
Thanks for the patch.
On Mon, Nov 15, 2010 at 03:29:59PM +0100, ext Sergio Aguirre wrote:
1. Get rid of CSI2 / CCP2 power settings, as they are controlled
in the receivers code anyways.
CCP2 is not correctly handling this. It's setting SMART STANDBY mode one
when reading from
to remove the registers from header file. We're not using them
on current version, but it doesn't mean we won't use ever. :)
Br,
David Cohen
/* CCDC module register offset */
#define ISPCCDC_PID (0x000)
--
1.7.0.4
--
To unsubscribe from this list: send the line unsubscribe
OMAP3 ISP driver does not support pipeline with multiple video outputs yet.
Driver must return -EBUSY in this case.
Signed-off-by: David Cohen david.co...@nokia.com
---
drivers/media/video/isp/ispccdc.c| 26 --
drivers/media/video/isp/ispcsi2.c| 19
Hi Lane,
On Thu, Nov 18, 2010 at 12:17:21AM +0100, ext Lane Brooks wrote:
On 11/17/2010 04:09 PM, Laurent Pinchart wrote:
Hi Lane,
On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
Laurent,
I am getting iommu translation errors when I try to use the CCDC output
after using
On Fri, Nov 19, 2010 at 02:23:54PM +0100, Cohen David (Nokia-MS/Helsinki) wrote:
OMAP3 ISP driver does not support pipeline with multiple video outputs yet.
Driver must return -EBUSY in this case.
Signed-off-by: David Cohen david.co...@nokia.com
---
drivers/media/video/isp/ispccdc.c
On Fri, Nov 19, 2010 at 03:16:41PM +0100, ext Lane Brooks wrote:
On 11/19/2010 07:13 AM, Laurent Pinchart wrote:
On Friday 19 November 2010 15:08:38 Lane Brooks wrote:
On 11/19/2010 06:29 AM, David Cohen wrote:
On Thu, Nov 18, 2010 at 12:17:21AM +0100, ext Lane Brooks wrote:
On Wednesday
On Fri, Nov 19, 2010 at 04:07:27PM +0100, ext Laurent Pinchart wrote:
Hi David,
On Friday 19 November 2010 16:06:21 David Cohen wrote:
On Fri, Nov 19, 2010 at 03:16:41PM +0100, ext Lane Brooks wrote:
On 11/19/2010 07:13 AM, Laurent Pinchart wrote:
On Friday 19 November 2010 15:08:38
On Fri, Nov 19, 2010 at 04:54:01PM +0100, ext Aguirre, Sergio wrote:
Hi Laurent and David,
Hi Sergio,
-Original Message-
From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com]
Sent: Friday, November 19, 2010 4:33 AM
To: David Cohen
Cc: Aguirre, Sergio; linux-media
not need to be contiguous.
Signed-off-by: David Cohen david.co...@nokia.com
---
drivers/media/video/videobuf-dma-sg.c | 17 +
1 files changed, 9 insertions(+), 8 deletions(-)
Hi Mauro,
Any comments?
Br,
David Cohen
diff --git a/drivers/media/video/videobuf-dma-sg.c
b
videobuf_dma_map()
(i.e. 256Kib for 8MP sensor).
In such situations, kmalloc() could face some problem to find the
required free memory. vmalloc() is a safer solution instead, as the
allocated memory does not need to be contiguous.
Signed-off-by: David Cohen david.co...@nokia.com
---
drivers/media
95 matches
Mail list logo
