Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-21 Thread Dirk Behme
...@vger.kernel.org; 'Steve Sakoman' Subject: Re: MMC_CAP_SDIO_IRQ for omap 3430 Madhusudhan wrote: Hi John, So does the SDIO card interrupt mode work fine now? (wrong attachment in previous mail :( sorry) If somebody likes to test, my updated patch v2 in attachment. Compile tested only, testing and comments

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-21 Thread Dirk Behme
Sakoman' Subject: Re: MMC_CAP_SDIO_IRQ for omap 3430 Madhusudhan wrote: Hi John, So does the SDIO card interrupt mode work fine now? (wrong attachment in previous mail :( sorry) If somebody likes to test, my updated patch v2 in attachment. Compile tested only, testing and comments are welcome

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-20 Thread John Rigby
*To:* Woodruff, Richard *Cc:* Dirk Behme; Chikkature Rajashekar, Madhusudhan; linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Steve Sakoman *Subject:* Re: MMC_CAP_SDIO_IRQ for omap 3430 Ok I was going to ask where you found that but I just rechecked the TRM and there it is in plain

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-20 Thread Steve Sakoman
 -- *From:* John Rigby [mailto:jcri...@gmail.com] *Sent:* Sunday, October 18, 2009 7:24 PM *To:* Woodruff, Richard *Cc:* Dirk Behme; Chikkature Rajashekar, Madhusudhan; linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Steve Sakoman *Subject:* Re: MMC_CAP_SDIO_IRQ

RE: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-20 Thread Madhusudhan
Sakoman' Subject: Re: MMC_CAP_SDIO_IRQ for omap 3430 Madhusudhan wrote: Hi John, So does the SDIO card interrupt mode work fine now? (wrong attachment in previous mail :( sorry) If somebody likes to test, my updated patch v2 in attachment. Compile tested only, testing and comments

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-20 Thread John Rigby
...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Dirk Behme Sent: Monday, October 19, 2009 1:17 PM To: linux-omap@vger.kernel.org Cc: Madhusudhan; 'John Rigby'; 'Woodruff, Richard'; linux- m...@vger.kernel.org; 'Steve Sakoman' Subject: Re: MMC_CAP_SDIO_IRQ for omap 3430 Madhusudhan

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-19 Thread Dirk Behme
Woodruff, Richard wrote: From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Dirk Behme Sent: Sunday, October 18, 2009 11:45 AM It would be funny if the TRM was wrong and the CIRQ bit is really cleared by writing 1 to it. I'll try that. A while

RE: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-19 Thread Woodruff, Richard
From: Dirk Behme [mailto:dirk.be...@googlemail.com] Sent: Monday, October 19, 2009 9:52 AM To: Woodruff, Richard Do you have any idea about MMCHS_HCTL.IBG? Not off the top of my head. I was working with someone who hit issues so I did a quick spec read and came up with previous list. For

RE: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-19 Thread Madhusudhan
: MMC_CAP_SDIO_IRQ for omap 3430 Ok I was going to ask where you found that but I just rechecked the TRM and there it is in plain site: When this bit is set to 1, the host controller automatically disables all the input buffers except the buffer of mmci_dat[1] outside of a transaction in order to detect

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-19 Thread Dirk Behme
18, 2009 7:24 PM To: Woodruff, Richard Cc: Dirk Behme; Chikkature Rajashekar, Madhusudhan; linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Steve Sakoman Subject: Re: MMC_CAP_SDIO_IRQ for omap 3430 Ok I was going to ask where you found that but I just rechecked the TRM

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-19 Thread John Rigby
From: John Rigby [mailto:jcri...@gmail.com] Sent: Sunday, October 18, 2009 7:24 PM To: Woodruff, Richard Cc: Dirk Behme; Chikkature Rajashekar, Madhusudhan; linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Steve Sakoman Subject: Re: MMC_CAP_SDIO_IRQ

RE: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-19 Thread Woodruff, Richard
From: John Rigby [mailto:jcri...@gmail.com] Sent: Monday, October 19, 2009 8:13 PM It is not perfect yet, I am still polling in sdio_irq.c because sometimes the card irq does get dropped. I suspect that is why the davinci driver had extra checks and calls in various places. Maybe. Do

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-19 Thread Dirk Behme
:* John Rigby [mailto:jcri...@gmail.com] *Sent:* Sunday, October 18, 2009 7:24 PM *To:* Woodruff, Richard *Cc:* Dirk Behme; Chikkature Rajashekar, Madhusudhan; linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Steve Sakoman *Subject:* Re: MMC_CAP_SDIO_IRQ for omap 3430 Ok I was going to ask

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-18 Thread John Rigby
Richard, MMCHS_CON.CPTL = 1 Don't disable input buffer on DAT1 after completion to allow seeing SDIO interrupt Sounds exactly like what we need. Thanks John On Sun, Oct 18, 2009 at 5:12 PM, Woodruff, Richard r-woodru...@ti.com wrote: From: linux-omap-ow...@vger.kernel.org

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-17 Thread Dirk Behme
:28 PM To: Madhusudhan Chikkature Cc: linux-...@vger.kernel.org; John Rigby; linux-omap@vger.kernel.org; Steve Sakoman Subject: Re: MMC_CAP_SDIO_IRQ for omap 3430 Madhusudhan Chikkature wrote: Hi Dirk, I am inlining the patch so that it helps review. ... @@ -1165,8 +1178,15 @@ static void

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-17 Thread John Rigby
...@googlemail.com] Sent: Friday, October 16, 2009 2:28 PM To: Madhusudhan Chikkature Cc: linux-...@vger.kernel.org; John Rigby; linux-omap@vger.kernel.org; Steve Sakoman Subject: Re: MMC_CAP_SDIO_IRQ for omap 3430 Madhusudhan Chikkature wrote: Hi Dirk, I am inlining the patch so that it helps review

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-17 Thread Dirk Behme
Message- From: Dirk Behme [mailto:dirk.be...@googlemail.com] Sent: Friday, October 16, 2009 2:28 PM To: Madhusudhan Chikkature Cc: linux-...@vger.kernel.org; John Rigby; linux-omap@vger.kernel.org; Steve Sakoman Subject: Re: MMC_CAP_SDIO_IRQ for omap 3430 Madhusudhan Chikkature wrote: Hi Dirk, I

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-17 Thread Dirk Behme
, October 16, 2009 2:28 PM To: Madhusudhan Chikkature Cc: linux-...@vger.kernel.org; John Rigby; linux-omap@vger.kernel.org; Steve Sakoman Subject: Re: MMC_CAP_SDIO_IRQ for omap 3430 Madhusudhan Chikkature wrote: Hi Dirk, I am inlining the patch so that it helps review. ... @@ -1165,8 +1178,15

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread Dirk Behme
John Rigby wrote: I have seen several discussions about lack of sdio irq support in the hsmmc driver but no patches. Has anyone on this list implemented this and/or can anyone point me to patches? What a coincidence ;) I'm currently working on this. See attachment what I currently have. It

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread Dirk Behme
John, John Rigby wrote: Dirk, Many thanks, after sending the request yesterday I made my own attempt which failed miserably. My patch looks like a subset of yours so that is to be expected. I'll try yours out today and report back my experience. I got already some (private) feedback

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread John Rigby
Dirk, Thanks for the update. After looking more closely at your patch I found that the only thing my attempt was missing was the IBG setting. I added that to mine with the result that the system hangs on loading the libertas modules. The last thing i see is the firmware request message. I will

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread Dirk Behme
John Rigby wrote: Dirk, Thanks for the update. After looking more closely at your patch I found that the only thing my attempt was missing was the IBG setting. I added that to mine with the result that the system hangs on loading the libertas modules. On which board are you working? libertas

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread Madhusudhan Chikkature
Hi Dirk, I am inlining the patch so that it helps review. Subject: [PATCH][RFC] OMAP HSMMC: Add SDIO interrupt support Form: Dirk Behme dirk.be...@googlemail.com At the moment, OMAP HSMMC driver supports only SDIO polling, resulting in poor performance. Add support for SDIO interrupt

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread John Rigby
First the disclaimers: The board is new board that has had hardware mmc/sdio problems before. It is based closely on beagle but uses a different package which has some package specific issues. We think we have found them all but who knows. My kernel is a few months old 2.6.29. Ok, given the

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread Dirk Behme
Madhusudhan Chikkature wrote: Hi Dirk, I am inlining the patch so that it helps review. ... @@ -1165,8 +1178,15 @@ static void omap_hsmmc_set_ios(struct mm break; case MMC_BUS_WIDTH_4: OMAP_HSMMC_WRITE(host-base, CON, con ~DW8); -

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread Dirk Behme
John Rigby wrote: First the disclaimers: The board is new board that has had hardware mmc/sdio problems before. It is based closely on beagle but uses a different package which has some package specific issues. We think we have found them all but who knows. My kernel is a few months old

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread John Rigby
cc'ing list after responding only to Dirk. On Fri, Oct 16, 2009 at 2:37 PM, John Rigby jcri...@gmail.com wrote: On Fri, Oct 16, 2009 at 1:55 PM, Dirk Behme dirk.be...@googlemail.com wrote: John Rigby wrote: First the disclaimers: The board is new board that has had hardware mmc/sdio problems

RE: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread Madhusudhan
-Original Message- From: Dirk Behme [mailto:dirk.be...@googlemail.com] Sent: Friday, October 16, 2009 2:28 PM To: Madhusudhan Chikkature Cc: linux-...@vger.kernel.org; John Rigby; linux-omap@vger.kernel.org; Steve Sakoman Subject: Re: MMC_CAP_SDIO_IRQ for omap 3430 Madhusudhan

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread John Rigby
: linux-...@vger.kernel.org; John Rigby; linux-omap@vger.kernel.org; Steve Sakoman Subject: Re: MMC_CAP_SDIO_IRQ for omap 3430 Madhusudhan Chikkature wrote: Hi Dirk, I am inlining the patch so that it helps review. ... @@ -1165,8 +1178,15 @@ static void omap_hsmmc_set_ios(struct mm