Re: [PATCH] opensm/osm_state_mgr.c: force heavy sweep when fabric consists of single switch

2009-11-11 Thread Yevgeny Kliteynik
Eli Dorfman (Voltaire) wrote: Yevgeny Kliteynik wrote: Eli Dorfman (Voltaire) wrote: Yevgeny Kliteynik wrote: Eli Dorfman (Voltaire) wrote: Yevgeny Kliteynik wrote: Yevgeny Kliteynik wrote: Line Holen wrote: On 11/ 4/09 04:54 PM, Yevgeny Kliteynik wrote: Line Holen wrote: On 11/ 4/09 10:

Re: back to back RDMA read fail?

2009-11-11 Thread Dotan Barak
Hi. how do you connect the QPs? via CM/CMA or by sockets (and you actually call the ibv_modify_qp)? Dotan neutron wrote: Hi Paul, thanks a lot for your quick reply! In my test, client informs the server of its local memory (rkey, addr, size) by sending 4 back to back messages, each message

Re: [PATCH RDMA] Fixup IPv6 support and IPv4 routing corner cases for RDMA CM

2009-11-11 Thread Or Gerlitz
Sean Hefty wrote: I'll compare my final patches against the ones submitted by David to see if anything got missed Are Jason's patches a superset of David's patches? or they need to be applied and only then David's work can be re-reviewed/merged, etc? Or. -- To unsubscribe from this list: s

Re: SRPT and SCST

2009-11-11 Thread Vladislav Bolkhovitin
Arend Dittmer, on 11/11/2009 03:33 AM wrote: To Bart's earlier question ... we apologize for not being able to come up with a time and date when the initiators lost contact with the target. We have not been able to test with an initiator from a vanilla kernel. We only tested with the initiator th

[PATCH] opensm/partition: keep multicast group pointer

2009-11-11 Thread Sasha Khapyorsky
Instead of MLID value (which may refer to more than one MGIDs) keep pointer to related multicast group object in partition structure. Signed-off-by: Sasha Khapyorsky --- opensm/include/opensm/osm_partition.h | 11 ++- opensm/opensm/osm_prtn.c |6 +++--- opensm/opensm/

Re: [PATCH] OpenSM: Fix unused variable compiler warning.

2009-11-11 Thread Sasha Khapyorsky
On 10:41 Tue 10 Nov , Ira Weiny wrote: > > From: Ira Weiny > Date: Tue, 10 Nov 2009 10:39:47 -0800 > Subject: [PATCH] OpenSM: Fix unused variable compiler warning. > > > Signed-off-by: Ira Weiny Applied. Thanks. Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdm

[PATCH] librdmacm/mckey: add notifications on events

2009-11-11 Thread Or Gerlitz
add notifications on multicast error and address change events which can take place while traffic is running. Signed-off-by: Or Gerlitz Index: librdmacm/examples/mckey.c === --- librdmacm.orig/examples/mckey.c +++ librdmacm/examples

Re: back to back RDMA read fail?

2009-11-11 Thread neutron
On Wed, Nov 11, 2009 at 4:52 AM, Dotan Barak wrote: > Hi. > > how do you connect the QPs? > via CM/CMA or by sockets (and you actually call the ibv_modify_qp)? > I exchange the initial QP infortion (lid, qpn, psn) via sockets. No CM is used. I manually take are of everything. Thanks! > Dotan >

RE: [PATCH RDMA] Fixup IPv6 support and IPv4 routing corner cases for RDMA CM

2009-11-11 Thread Sean Hefty
>Are Jason's patches a superset of David's patches? or they need to be >applied and only then David's work can be re-reviewed/merged, etc? I believe that Jason's patches are a superset of David's. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to

[Patch] Init ipoib_neigh.dgid

2009-11-11 Thread David J. Wilder
Ipoib can miss a change in dgid under some conditions. The problem is caused when ipoib_neigh->dgid contains a stale address. The fix is to set ipoib_neigh->dgid to zero in ipoib_neigh_alloc(). Detail description: A systems using bonding on its ipoib interface has switched it active slave interf

Re: strong ordering for data registered memory

2009-11-11 Thread Roland Dreier
> Some time ago there was an email sent to this group with the subject > "weak ordering for data registered memory". I don't recall any action > resulting from this thread. So, I have a question. If a bit were > defined to specify "strong ordering", perhaps as a "access" flag (see > ibv_ac

Re: back to back RDMA read fail?

2009-11-11 Thread Dotan Barak
I have 2 questions: 1) if you change the opcode to RDMA Write, do you still experience this problem? (assuming that the permissions allow RDMA Write; if not, fix this issue) 2) what are the values of the the outstanding RDMA Read/Atomic in both QPs (as initiator and as target)? Dotan neu

Re: strong ordering for data registered memory

2009-11-11 Thread Richard Frank
Today apps are forced to assume that all transports can not provide strong ordering.. and hence must implement solutions to work around this. There are specific optimizations an app might make if it knows the underpinning transport can make these guarantees.. It would be useful if "strong ord

RE: [PATCH] RDMA/addr: Use appropriate locking with for_each_netdev()

2009-11-11 Thread Sean Hefty
>for_each_netdev() should be used with RTNL or dev_base_lock held, >or risk a crash. > >Signed-off-by: Eric Dumazet Thanks - I'm working on a patch set in this area. Roland, I can merge Eric's changes into that patch set if it makes things easier. > drivers/infiniband/core/addr.c |9 +++

Re: [PATCH] RDMA/addr: Use appropriate locking with for_each_netdev()

2009-11-11 Thread Roland Dreier
> >for_each_netdev() should be used with RTNL or dev_base_lock held, > >or risk a crash. > > > >Signed-off-by: Eric Dumazet > > Thanks - I'm working on a patch set in this area. Roland, I can merge Eric's > changes into that patch set if it makes things easier. Would it be possible for

[PATCH] opensm/osm_mcast_mgr.c: fix return value on alloc_mfts() failures

2009-11-11 Thread Sasha Khapyorsky
When alloc_mfts() fails and multicast routing calculation interrupted return -1 value to a caller. Signed-off-by: Sasha Khapyorsky --- opensm/opensm/osm_mcast_mgr.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/opensm/opensm/osm_mcast_mgr.c b/opensm/opensm/osm_mcast_

[PATCH] IB/core: export struct ib_port

2009-11-11 Thread Ralph Campbell
This patch moves the definition of struct ib_port from sysfs.c to ib_verbs.h so that HCAs can create files in /sys/class/infiniband//ports// Signed-off-by: Ralph Campbell --- diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c index 158a214..e01f3e7 100644 --- a/driver

Re: [PATCH] IB/core: export struct ib_port

2009-11-11 Thread Roland Dreier
> This patch moves the definition of struct ib_port from > sysfs.c to ib_verbs.h so that HCAs can create files in > /sys/class/infiniband//ports// um, maybe, but we need to see how it gets used first. How do you get the to struct ib_port in driver code? Maybe it would make more sense to add

Re: [PATCH] IB/core: export struct ib_port

2009-11-11 Thread Ralph Campbell
On Wed, 2009-11-11 at 11:19 -0800, Roland Dreier wrote: > > This patch moves the definition of struct ib_port from > > sysfs.c to ib_verbs.h so that HCAs can create files in > > /sys/class/infiniband//ports// > > um, maybe, but we need to see how it gets used first. How do you get > the to stru

Re: [PATCH] opensm/osm_mcast_mgr.c: fix return value on alloc_mfts() failures

2009-11-11 Thread Hal Rosenstock
On Wed, Nov 11, 2009 at 1:33 PM, Sasha Khapyorsky wrote: > > When alloc_mfts() fails and multicast routing calculation interrupted > return -1 value to a caller. Yes, that fixes the return value but nothing (at least currently) takes advantage of that. Is that the next step ? -- Hal > > Signed-

Re: [PATCH] IB/core: export struct ib_port

2009-11-11 Thread Roland Dreier
> It is used by the new ib_qib driver to expose the SL to VL table > since the user level MPI library (libpsm) constructs packets including > the IB header. After the driver calls ib_register_device(), > it calls device_create_file() to create the files in > /sys/class/infiniband/qib0/. Then

RE: [PATCH] RDMA/addr: Use appropriate locking with for_each_netdev()

2009-11-11 Thread Sean Hefty
>Would it be possible for you to take Eric's patch as the first in your >set (keeping his From: of course) and base your fixes on top of that? Will do. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH] IB/core: export struct ib_port

2009-11-11 Thread Dave Olson
On Wed, 11 Nov 2009, Roland Dreier wrote: | > It is used by the new ib_qib driver to expose the SL to VL table | > since the user level MPI library (libpsm) constructs packets including | > the IB header. After the driver calls ib_register_device(), | > it calls device_create_file() to create t

Re: ipath now and then (was [PATCH] IB/core: export struct ib_port)

2009-11-11 Thread Or Gerlitz
On Wed, Nov 11, 2009 at 11:06 PM, Dave Olson wrote: > And yes, the ib_ipath is being fully deprecated.  The "full set" of > patches that adds ib_qib upstream will include a subset that drops > ib_ipath.   All the bug fixes and feature work have been done for ib_qib It was brought up in few occasi

Re: ipath now and then (was [PATCH] IB/core: export struct ib_port)

2009-11-11 Thread Ralph Campbell
On Wed, 2009-11-11 at 13:18 -0800, Or Gerlitz wrote: > On Wed, Nov 11, 2009 at 11:06 PM, Dave Olson wrote: > > And yes, the ib_ipath is being fully deprecated. The "full set" of > > patches that adds ib_qib upstream will include a subset that drops > > ib_ipath. All the bug fixes and feature wo

Re: strong ordering for data registered memory

2009-11-11 Thread David Brean
I decided to minimize the impact of an API change on the class of applications that use the current verbs interface because those applications can safely run on platforms that deliver optimal performance using weak ordering for data buffers. New binaries aren't required for this class of appli

Re: strong ordering for data registered memory

2009-11-11 Thread David Brean
Yes, there are HCAs that provide strong ordering. And an application such as OpenMPI checks the HCA model and if appropriate enables a mechanism called "eager RDMA" that depends on it. -David Richard Frank wrote: Today apps are forced to assume that all transports can not provide strong orde

Re: strong ordering for data registered memory

2009-11-11 Thread Richard Frank
Would anyone like to through out the list of HCAs that do this... I can guess at a few... and can ask the vendors directly.. if not.. . It would be much nicer to not hardcode names of adapters.. but that won't stop us.. :) David Brean wrote: Yes, there are HCAs that provide strong ordering. An

Re: strong ordering for data registered memory

2009-11-11 Thread Roland Dreier
> I decided to minimize the impact of an API change on the class of > applications that use the current verbs interface because those > applications can safely run on platforms that deliver optimal > performance using weak ordering for data buffers. New binaries aren't > required for this cl

Re: strong ordering for data registered memory

2009-11-11 Thread Jason Gunthorpe
On Wed, Nov 11, 2009 at 05:44:59PM -0500, Richard Frank wrote: > Would anyone like to through out the list of HCAs that do this... I > can guess at a few... and can ask the vendors directly.. if not.. . > > It would be much nicer to not hardcode names of adapters.. but that won't > stop us.. :)

Re: [PATCH] IB/core: export struct ib_port

2009-11-11 Thread Roland Dreier
> | Hmm, maybe we should just add a vls directory with sl0 ... sl15 or > | something like that in generic code? I don't see why this needs to be > | driver-specific code. > > No particular reason, it just didn't seem likely to be useful on other > HCA drivers. I can redo the patches that

Re: [PATCH] IB/core: export struct ib_port

2009-11-11 Thread Ralph Campbell
On Wed, 2009-11-11 at 15:02 -0800, Roland Dreier wrote: > > | Hmm, maybe we should just add a vls directory with sl0 ... sl15 or > > | something like that in generic code? I don't see why this needs to be > > | driver-specific code. > > > > No particular reason, it just didn't seem likely to

Re: [PATCH] IB/core: export struct ib_port

2009-11-11 Thread Roland Dreier
> While this is true for SLtoVL, we create other files which are > device specific under the port directory too. > It seems like we might need to introduce a callback into the driver to > create the port specific sysfs files. Umm, you could have said there were other things initially! Anyway

Re: [PATCH] IB/core: export struct ib_port

2009-11-11 Thread Jason Gunthorpe
On Wed, Nov 11, 2009 at 03:22:50PM -0800, Ralph Campbell wrote: > While this is true for SLtoVL, we create other files which are > device specific under the port directory too. > It seems like we might need to introduce a callback into the driver to > create the port specific sysfs files. Maybe g

Re: [ofa-general] [PATCH 1/2 v4] opensm: Storage organization for multicast groups

2009-11-11 Thread Sasha Khapyorsky
Hi Slava, This patch is outdated (it was outdated at date of posting to the list), in particular I cleaned up already a needs to resolve multicast group by mlid for SA PathRecord queries with multicast destination and some others. On 15:53 Tue 29 Sep , Slava Strebkov wrote: > Main purpose is

[PATCH] opensm/osm_mgrp_new(): add subnet db insertion

2009-11-11 Thread Sasha Khapyorsky
Add insertion of mgrp into subnet DB in osm_mgrp_new() function code. This consolidation makes a code cleaner and will help us to add MGID to MLID compression model where mgrp will not be mapped directly to mlids but using additional structure. Signed-off-by: Sasha Khapyorsky --- opensm/include

[PATCH] osm_mlid_box: infrastructure for mgid compression

2009-11-11 Thread Sasha Khapyorsky
Now each MLID value is represented by collection of multicast groups - osm_mgrp_box object. All multicast routing calculation and setup operations are performed using those MLID indexed objects. Multicast groups are kept as linked list in osm_mgrp_box and as before are globally indexed by its MGID

Re: [PATCH] IB/core: export struct ib_port

2009-11-11 Thread Roland Dreier
> Maybe give some thought to using a syscall interface through uverbs > for some of this? Actually I think for exposing SL-to-VL and other things like that, sysfs is pretty good. Having something usable from both scripts and programs seems pretty useful, and having an opaque uverbs interface i

Re: [PATCH] IB/core: export struct ib_port

2009-11-11 Thread Jason Gunthorpe
On Wed, Nov 11, 2009 at 04:04:10PM -0800, Roland Dreier wrote: > > > Maybe give some thought to using a syscall interface through uverbs > > for some of this? > > Actually I think for exposing SL-to-VL and other things like that, sysfs > is pretty good. Having something usable from both script

RE: [PATCH] librdmacm/mckey: add notifications on events

2009-11-11 Thread Sean Hefty
>add notifications on multicast error and address change events which >can take place while traffic is running. mckey is intended to be a fairly simple send/receive multicast test program. What's the reasoning behind adding the event handling? - Sean -- To unsubscribe from this list: send the li

Re: [PATCH] opensm/osm_mcast_mgr.c: fix return value on alloc_mfts() failures

2009-11-11 Thread Sasha Khapyorsky
On 15:25 Wed 11 Nov , Hal Rosenstock wrote: > > Yes, that fixes the return value but nothing (at least currently) > takes advantage of that. Is that the next step ? Yes, it should be done this way. Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of

Re: [PATCH] opensm - remove useless goto

2009-11-11 Thread Sasha Khapyorsky
On 15:07 Mon 09 Nov , Stan C. Smith wrote: > > Signed-off-by: stan smith Applied. Thanks. Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] opensm/osm_link_mgr.c: Fix IBA reference for PortInfo attribute

2009-11-11 Thread Sasha Khapyorsky
On 15:42 Fri 06 Nov , Hal Rosenstock wrote: > > Signed-off-by: Hal Rosenstock Applied. Thanks. Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.h

Re: [PATCH] infiniband-diags/saquery.c: Change lids and port numbers to decimal

2009-11-11 Thread Sasha Khapyorsky
On 15:32 Fri 06 Nov , Hal Rosenstock wrote: > > rather than hex > > Signed-off-by: Hal Rosenstock Applied. Thanks. Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel

Re: strong ordering for data registered memory

2009-11-11 Thread Dave Olson
On Wed, 11 Nov 2009, Jason Gunthorpe wrote: | On Wed, Nov 11, 2009 at 05:44:59PM -0500, Richard Frank wrote: | | > Would anyone like to through out the list of HCAs that do this... I | > can guess at a few... and can ask the vendors directly.. if not.. . | > | > It would be much nicer to not ha

Re: [PATCH] IB/core: export struct ib_port

2009-11-11 Thread Dave Olson
On Wed, 11 Nov 2009, Roland Dreier wrote: | | > While this is true for SLtoVL, we create other files which are | > device specific under the port directory too. | > It seems like we might need to introduce a callback into the driver to | > create the port specific sysfs files. | | Umm, you c

Re: [PATCH] opensm/osm_state_mgr.c: force heavy sweep when fabric consists of single switch

2009-11-11 Thread Eli Dorfman (Voltaire)
Yevgeny Kliteynik wrote: > Eli Dorfman (Voltaire) wrote: >> Yevgeny Kliteynik wrote: >>> Eli Dorfman (Voltaire) wrote: Yevgeny Kliteynik wrote: > Eli Dorfman (Voltaire) wrote: >> Yevgeny Kliteynik wrote: >>> Yevgeny Kliteynik wrote: Line Holen wrote: > On 11/ 4/09