[PATCHv3 TRIVIAL] IB/core: Documentation fix to ib_mad_snoop_handler in the MAD header file

In ib_mad.h, ib_mad_snoop_handler uses send_buf rather than send_wr Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- Change since v2: Changed title to use "higher" language Change since v1: Fixed typo in patch description diff --git a/include/rdma/ib_mad.h b/include/rdm

[PATCHv4 TRIVIAL] IB/core: Documentation fix to the snoop handler in the MAD header file

In ib_mad.h, ib_mad_snoop_handler uses send_buf rather than send_wr Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- Change since v3: Fixed title to not include function name Change since v2: Changed title to use "higher" language Change since v1: Fixed typo in patch d

Re: [PATCHv3 TRIVIAL] IB/core: Documentation fix to ib_mad_snoop_handler in the MAD header file

On 1/5/2016 12:38 PM, Hefty, Sean wrote: >> In ib_mad.h, ib_mad_snoop_handler uses send_buf rather than send_wr > > The MAD snooping should be removed from the mad stack. This last discussed on linux-rdma list back in late September when Ira posted a partial RFC patch to do this. > There are

[PATCHv2 TRIVIAL] IB/core: ib_mad.h ib_mad_snoop_handler documentation fix

ib_mad_snoop_handler uses send_buf rather than send_wr Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- Change since v1: Fixed typo in patch description diff --git a/include/rdma/ib_mad.h b/include/rdma/ib_mad.h index ec9b44d..2b3573d 100644 --- a/include/rdma/ib_mad.h +++ b/includ

Re: [PATCH] IB/sysfs: Fix sparse warning on attr_id

> > Reported-by: Bart Van Assche <bart.vanass...@sandisk.com> > Signed-off-by: Ira Weiny <ira.we...@intel.com> Reviewed-by: Hal Rosenstock <h...@mellanox.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to m

Re: [PATCH 1/2] IB/mad: pass ib_mad_send_buf explicitly to the recv_handler

On 1/4/2016 8:15 AM, Christoph Hellwig wrote: > Stop abusing wr_id and just pass the parameter explicitly. > > Signed-off-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Hal Rosenstock <h...@mellanox.com> > --- > drivers/infiniband/core/cm.c | 1 + >

Re: [PATCH 2/2] IB/mad: use CQ abstraction

On 1/4/2016 9:16 AM, Christoph Hellwig wrote: > Remove the local workqueue to process mad completions and use the CQ API > instead. > > Signed-off-by: Christoph Hellwig <h...@lst.de> Reviewed-by: Hal Rosenstock <h...@mellanox.com> -- To unsubscribe from this list: se

[PATCH TRIVIAL] IB/core: ib_mad.h ib_mad_snoop_handler documentation fix

ib_mad_snoop_handler ues send_buf rather than send_wr Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- diff --git a/include/rdma/ib_mad.h b/include/rdma/ib_mad.h index ec9b44d..2b3573d 100644 --- a/include/rdma/ib_mad.h +++ b/include/rdma/ib_mad.h @@ -424,11 +424,11 @@ typede

Re: [PATCH v2] IB/core: sysfs.c: Fix PerfMgt ClassPortInfo handling

On 12/29/2015 7:21 AM, Or Gerlitz wrote: > On 12/29/2015 12:43 PM, Hal Rosenstock wrote: >> This handles issue pointed out by Matan Barak <mat...@dev.mellanox.co.il> >> >> Fixes: 145d9c541032 ('IB/core: Display extended counter set if >> available') >&

[PATCH v2] IB/core: sysfs.c: Fix PerfMgt ClassPortInfo handling

the ClassPortInfo attribute. This handles issue pointed out by Matan Barak <mat...@dev.mellanox.co.il> Fixes: 145d9c541032 ('IB/core: Display extended counter set if available') Signed-off-by: Hal Rosenstock <h...@mellanox.com> Acked-by: Matan Barak <mat...@mellanox.com> A

[PATCH] IB/core: sysfs.c: Fix PerfMgt ClassPortInfo handling

the ClassPortInfo attribute. This handles issue pointed out by Matan Barak <mat...@dev.mellanox.co.il> Signed-off-by: Hal Rosenstock <h...@mellanox.com> Acked-by: Matan Barak <mat...@mellanox.com> --- diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sys

Re: [PATCH v2 for-next 5/7] IB/mlx4: Add IB counters table

On 12/24/2015 11:09 AM, Matan Barak wrote: > On Thu, Dec 24, 2015 at 4:07 PM, Matan Barak > wrote: >> On Thu, Dec 24, 2015 at 2:38 PM, Or Gerlitz wrote: >>> On 12/24/2015 12:42 PM, Sagi Grimberg wrote: >> This patch seems to

Re: [PATCH v2 for-next 5/7] IB/mlx4: Add IB counters table

On 12/25/2015 9:50 AM, Hal Rosenstock wrote: > On 12/24/2015 11:09 AM, Matan Barak wrote: >> On Thu, Dec 24, 2015 at 4:07 PM, Matan Barak <mat...@dev.mellanox.co.il> >> wrote: >>> On Thu, Dec 24, 2015 at 2:38 PM, Or Gerlitz <ogerl...@mellanox.com> wrote: >&g

Re: [PATCH 3/3] Display extended counter set if available

if so >> create the proper extended and additional counters. >> >> Reviewed-by: Hal Rosenstock <h...@mellanox.com> >> Signed-off-by: Christoph Lameter <c...@linux.com> >> --- >> drivers/infiniband/core/sysfs.c | 104 >> +++

Re: [PATCH 3/3] Display extended counter set if available

On 12/21/2015 2:47 PM, ira.weiny wrote: > On Mon, Dec 21, 2015 at 01:31:31PM -0600, Christoph Lameter wrote: >> On Mon, 21 Dec 2015, Hal Rosenstock wrote: >> >>>> Don't we need to change all the sysfs_remove_groups to use >>>> get_counter_table as >>&

Re: [PATCH 3/3] Display extended counter set if available

e the proper extended and additional counters. >> >> Reviewed-by: Hal Rosenstock <h...@mellanox.com> >> Signed-off-by: Christoph Lameter <c...@linux.com> >> --- >> drivers/infiniband/core/sysfs.c | 104 >> +++- &

Re: [PATCH 3/3] IB core: Display 64 bit counters from the extended set

On 12/20/2015 5:10 AM, Matan Barak wrote: > On Mon, Dec 14, 2015 at 6:06 PM, Christoph Lameter wrote: >> On Mon, 14 Dec 2015, Matan Barak wrote: >> No idea what the counter is doing. Saw another EXT counter implementation use 0 so I thought that was fine. >>> >>> It

Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

On 12/18/2015 8:39 AM, Christoph Lameter wrote: > On Thu, 17 Dec 2015, Hal Rosenstock wrote: > >>> + if (cpi.capability_mask && IB_PMA_CLASS_CAP_EXT_WIDTH) { >>> + /* We have extended counters */ >>> + >>> + if (cpi.ca

Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

> For that we need a special table and create a function that > returns the table address. > > Signed-off-by: Christoph Lameter <c...@linux.com> Reviewed-by: Hal Rosenstock <h...@mellanox.com> -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 3/3] IB core: Display 64 bit counters from the extended set

On 12/16/2015 2:34 PM, Christoph Lameter wrote: > On Wed, 16 Dec 2015, Christoph Lameter wrote: > >> DRAFT: This is missing the check if this device supports >> extended counters. > > Found some time and here is the patch with the detection of the extended > attribute through sending a mad

Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

On 12/17/2015 2:52 PM, Christoph Lameter wrote: > Check if the extended counters are available and if so > create the proper extended and additional counters. > > Signed-off-by: Christoph Lameter > > Index: linux/drivers/infiniband/core/sysfs.c >

Re: [PATCH 3/3] IB core: Display 64 bit counters from the extended set

On 12/17/2015 1:54 PM, Christoph Lameter wrote: > On Thu, 17 Dec 2015, Hal Rosenstock wrote: >> ClassPortInfo is per class not per class per port so need to indicate to >> get_mad whether a port is supplied or not or conditionalize based on >> attr ID. > > I though

Re: [PATCH 3/3] IB core: Display 64 bit counters from the extended set

On 12/17/2015 2:21 PM, Christoph Lameter wrote: > On Thu, 17 Dec 2015, Hal Rosenstock wrote: > >>> I thought a port is always supplied since we get the info for a particular >>> port and the directory only exists if there is a port? >> >> Yes, but

Re: [PATCH 1/3] IB Core: Create get_perf_mad function in sysfs.c

On 12/17/2015 2:52 PM, Christoph Lameter wrote: > Create a new function to retrieve performance management > data from the existing code in get_pma_counter(). > > Signed-off-by: Christoph Lameter <c...@linux.com> Reviewed-by: Hal Rosenstock <h...@mellanox.com> -- To un

Re: [PATCH 2/3] IB core counters: Specify attribute_id in port_table_attribute

On 12/17/2015 2:52 PM, Christoph Lameter wrote: > Add the attr_id on port_table_attribute since we will have to add > a different port_table_attribute for the extended attribute soon. > > Signed-off-by: Christoph Lameter <c...@linux.com> Reviewed-by: Hal Rosenstock

Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

On 12/17/2015 4:28 PM, Christoph Lameter wrote: > So port_check_extended_counters need to return another value for this. > The IETF ones are the uni/mcast xxx counters? Yes -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to

Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

On 12/17/2015 5:50 PM, Christoph Lameter wrote: > On Thu, 17 Dec 2015, Hal Rosenstock wrote: > >> On 12/17/2015 4:28 PM, Christoph Lameter wrote: >>> So port_check_extended_counters need to return another value for this. >>> The IETF ones are the uni/mcast x

Re: [PATCH 3/3] IB core: Display 64 bit counters from the extended set

On 12/15/2015 2:55 PM, Jason Gunthorpe wrote: > On Tue, Dec 15, 2015 at 01:51:35PM -0600, Christoph Lameter wrote: >> On Mon, 14 Dec 2015, Hal Rosenstock wrote: >> >>>> Mellanox should really confirm this for their hardware matrix. >>> >>> I am try

Re: [PATCH 3/3] IB core: Display 64 bit counters from the extended set

On 12/15/2015 4:20 PM, Jason Gunthorpe wrote: >> The unicast/multicast extended counters are not always supported - >> > depends on setting of PerfMgt ClassPortInfo >> > CapabilityMask.IsExtendedWidthSupportedNoIETF (bit 10). > Yes.. certainly this proposed patch needs to account for that and >

Re: [PATCH 3/3] IB core: Display 64 bit counters from the extended set

On 12/11/2015 7:00 PM, Jason Gunthorpe wrote: >> qib, mlx4 are fine. mlx5 should be as well I would think (I don't have that >> hardware.) I'm not 100% sure but I don't think that mthca supports the PortCountersExtended attribute. > I have no specifics to add, but I keep running into systems,

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On 12/8/2015 12:33 PM, kaike@intel.com wrote: > From: Kaike Wan > > In an insecure IB fabric, the default pkey in a port is 0x, where each > node is allowed to talk to any other node in the fabric, including the SA > node. However, in a secure fabric, to limit member

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On 12/8/2015 7:26 PM, Hefty, Sean wrote: >>> +* Determine the default pkey for parsing address file as well. >>> +* order of preference: first full-member non-management pkey, >>> +* 0x, first pkey. >>> +*/ >> >> This really should just be the 0 index pkey, which exactly

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On 12/8/2015 4:21 PM, Jason Gunthorpe wrote: > On Tue, Dec 08, 2015 at 12:33:02PM -0500, kaike@intel.com wrote: >> From: Kaike Wan >> >> In an insecure IB fabric, the default pkey in a port is 0x, where each >> node is allowed to talk to any other node in the fabric,

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On 12/9/2015 10:04 AM, Wan, Kaike wrote: > I mean that the user needs to investigate why the fabric is not working out > of box. My point is that an educated admin should _know_ to configure in these cases and that debug is only when things are broken not by default in these more complex cases.

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On 12/9/2015 8:24 AM, Wan, Kaike wrote: >> From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] >> Sent: Wednesday, December 09, 2015 7:50 AM >> To: Wan, Kaike; Hefty, Sean >> Cc: linux-rdma@vger.kernel.org >> Subject: Re: [PATCH 1/1] Ibacm: default pkey for partitio

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On 12/9/2015 8:55 AM, Wan, Kaike wrote: > This is the best effort and it should work for most common configurations, > but may not work for more complicated cases. Right, there are various scenarios where it will not work. This was one of them but there are others I can think of. > Any other

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

>> Unfortunately not. It comes down to whether the out of box cases outweigh >> the debug when it's an exception case. The premise of this patch is that >> that's the case. > > I would argue that it does. Without this patch, ibacm will not work on secure > fabric out of box > (where "default"

Re: [PATCH 1/1] Ibacm: default pkey for partitioned fabrics

On 12/9/2015 11:26 AM, Hefty, Sean wrote: >>> I mean that the user needs to investigate why the fabric is not working >> out of box. >> >> My point is that an educated admin should _know_ to configure in these >> cases and that debug is only when things are broken not by default in >> these more

Re: [PATCH] IB/mad: In validate_mad, validate CM method and attribute

On 11/12/2015 5:57 PM, Hefty, Sean wrote: >> IIRC responding to Get(CPI) is mandatory? > > Maybe the drivers are responding? I don't believe that the CM does. Sorry for the confusion. linux kernel CM does not respond to Get(CPI). I was just trying to add the validation code in for that since it

Re: [PATCH] IB/mad: In validate_mad, validate CM method and attribute

IOn 11/12/2015 5:13 PM, Jason Gunthorpe wrote: > On Thu, Nov 12, 2015 at 08:30:55PM +, Hefty, Sean wrote: + /* CM attributes other than ClassPortInfo only use Send method >>> */ + if (mad_hdr->mgmt_class == IB_MGMT_CLASS_CM) { + if

Re: [PATCH] IB/mad: In validate_mad, validate CM method and attribute

On 11/12/2015 1:13 PM, ira.weiny wrote: > On Thu, Nov 12, 2015 at 01:48:50PM +0200, Hal Rosenstock wrote: >> >> Receipt of CM MAD with response method for other than ClassPortInfo >> attribute is invalid. >> >> CM attributes other than ClassPortInfo use send me

[PATCH v2] IB/mad: In validate_mad, validate CM send method for attributes other than ClassPortInfo

to the incoming GetResp of CM REQ as if it was a valid incoming Send of CM REQ rather than tossing this on the floor. It also causes the MAD layer not to retransmit the original REQ even though it has not received a REP. Reviewed-by: Sagi Grimberg <sa...@mellanox.com> Signed-off-by: Hal Rosenst

Re: [PATCH] IB/mad: In validate_mad, validate CM method and attribute

On 11/12/2015 3:30 PM, Hefty, Sean wrote: >>> + /* CM attributes other than ClassPortInfo only use Send method >> */ >>> + if (mad_hdr->mgmt_class == IB_MGMT_CLASS_CM) { >>> + if (mad_hdr->attr_id != IB_MGMT_CLASSPORTINFO_ATTR_ID) { >>> +

[PATCH] IB/mad: In validate_mad, validate CM method and attribute

. Reviewed-by: Sagi Grimberg <sa...@mellanox.com> Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- drivers/infiniband/core/mad.c |8 include/rdma/ib_mad.h |2 ++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/core/mad

[PATCH infiniband-diags] ibportstate.c: Fix unsigned comparison warnings

ned expression < 0 is always false Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- diff --git a/src/ibportstate.c b/src/ibportstate.c index 47e9133..cb47aa9 100644 --- a/src/ibportstate.c +++ b/src/ibportstate.c @@ -447,40 +447,40 @@ int main(int argc, char **argv)

[PATCH infiniband-diags] Remove unused pisize parameter from dump_portinfo in ibdiag_common

src/ibdiag_common.c: In function ?dump_portinfo?: src/ibdiag_common.c:856: warning: unused parameter ?pisize? Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- diff --git a/include/ibdiag_common.h b/include/ibdiag_common.h index af5b3c4..21b0522 100644 --- a/include/ibdiag_common.h

[PATCH infiniband-diags] ibsendtrap.c: Eliminate unused parameter from send_trap

src/ibsendtrap.c: In function ?send_trap?: src/ibsendtrap.c:124: warning: unused parameter ?name? Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- diff --git a/src/ibsendtrap.c b/src/ibsendtrap.c index 46fd6e7..659f2d2 100644 --- a/src/ibsendtrap.c +++ b/src/ibsendtrap.c @@ -121,8

Re: [PATCH libibcm] cmpost.c: Handle ibv_get_device_list returning no IB devices in init()

On 11/5/2015 7:46 PM, Hefty, Sean wrote: > Merged - thanks. > > This is the first patch against the libibcm in over 4 years. Is there a > reason why this is being used instead of the librdmacm? I ask because I > assumed that the libibcm was basically deprecated. The last release was over >

[PATCH libibcm] cmpost.c: Handle ibv_get_device_list returning no IB devices in init()

Also, print message when init fails Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- diff --git a/examples/cmpost.c b/examples/cmpost.c index 1b0edf8..f7833f5 100644 --- a/examples/cmpost.c +++ b/examples/cmpost.c @@ -447,6 +447,8 @@ static int init(void) test.disconnect

Re: [PATCH rdma-RC] IB/cm: Fix sleeping while atomic when creating AH from WC

On 10/20/2015 11:57 AM, Hefty, Sean wrote: >> Today, cm assumes paths are reversible primary_path->reversible = 1. > > I can't quickly find a link, but I believe all CM MADs are reversible, per > the spec. Spec citation for this is: C12-5.1.3: All responses generated by the CM protocol shall

Re: [PATCH] OpenSM: LFT update breaks if IB_SMP_DATA_SIZE changes

On 10/13/2015 9:25 AM, Jens Domke wrote: > This is only a precautionary patch for a theoretical > bug which would arise if someone redefines IB_SMP_DATA_SIZE > to a values !=64. > > ucast_mgr_pipeline_fwd_tbl() calculates the max. number of > blocks to update using 64 explicitly, while

[PATCH infiniband-diags] perfquery.c: Fix smp_query_via return value checks

ter with integer zero src/perfquery.c:928: warning: ordered comparison of pointer with integer zero Reported-by: David Binderman <dcb...@hotmail.com> Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- Fix for OFA Bugzilla #2572 diff --git a/src/perfquery.c b/src/perfquery.c index 9e3a307.

[PATCH TRIVIAL infiniband-diags] ibdiag_common.c: Move static to beginning of get_build_version declaration

Eliminate compiler warning: src/ibdiag_common.c:85: warning: ?static? is not at beginning of declaration Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- diff --git a/src/ibdiag_common.c b/src/ibdiag_common.c index e09623d..5424845 100644 --- a/src/ibdiag_common.c +++ b/src/ibdiag_co

Re: [PATCH 0/5 RFC] IB/mad: Add kernel trace to umad/mad

On 10/1/2015 12:51 AM, ira.we...@intel.com wrote: > From: Ira Weiny > > This has mild testing and still has some FIXMEs etc. I'm submitting to help > decide if we wish to remove the MAD snooping infrastructure. I think this has a ways to go before it has equivalent

Re: [PATCH RFC] IB/mad: remove obsolete snoop interface

On 9/30/2015 12:32 PM, Weiny, Ira wrote: >> >> On 9/30/2015 2:01 AM, ira.we...@intel.com wrote: >>> From: Ira Weiny >>> >>> This interface has no current users and is obsolete. >> >> There are no in tree users of this but there is Sean's madeye tool (which is >> out >> of

[PATCH TRIVIAL] ib_pack.h: Fix commentary IBA reference for CNP in IB opcode enum

IBA spec is now 1.3 not 3.1 and vol 1 should be mentioned as there is also vol 2. Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- diff --git a/include/rdma/ib_pack.h b/include/rdma/ib_pack.h index 709a533..e99d8f9 100644 --- a/include/rdma/ib_pack.h +++ b/include/rdma/ib_pack.h @@

[PATCH librdmacm] rstream.c: Use proper define for ai_flags before getaddrinfo call in client_connect

even though both have same value Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- diff --git a/examples/rstream.c b/examples/rstream.c index d93e9aa..ba5e449 100644 --- a/examples/rstream.c +++ b/examples/rstream.c @@ -421,7 +421,7 @@ static int client_connec

Re: [PATCH RFC] IB/mad: remove obsolete snoop interface

On 9/30/2015 2:01 AM, ira.we...@intel.com wrote: > From: Ira Weiny > > This interface has no current users and is obsolete. There are no in tree users of this but there is Sean's madeye tool (which is out of tree). This is still a useful debug tool for MADs. >

[PATCH librdmacm] examples: Use gai_strerror rather than perror for [rdma_]getaddrinfo failures

[rdma_]getaddrinfo error codes are decoded by gai_strerror (and not set in errno) so replace perror calls following these failed calls. Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- diff --git a/examples/cmatose.c b/examples/cmatose.c index ab3e746..d7bd92d 100644 --- a/ex

[PATCH librdmacm] examples/r[io]stream.c: Better handling of rpoll errors during client async rconnect

Rather than silently exiting when connection is refused by server, print error message (Connection refused) during async rconnect at client. Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- diff --git a/examples/riostream.c b/examples/riostream.c index c12dd0d..b6c9f86 100644 --- a/ex

[PATCH infiniband-diags] saquery.c: Fix saquery -D option

adimir Koushnir <vladim...@mellanox.com> Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- src/saquery.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/saquery.c b/src/saquery.c index 4343e33..db863f2 100644 --- a/src/saquery.c +++ b/src/saquery.c

Re: [PATCH 2/2] IB/core: Move SM class defines from ib_mad.h to ib_smi.h

mi.h instead. > > Fixes: d4ab347005fb ("IB/core: Add core header changes needed for OPA") > Signed-off-by: Ira Weiny <ira.we...@intel.com> Reviewed-by: Hal Rosenstock <h...@mellanox.com> A couple of comment nits below. > --- > drivers/infiniband/hw/qib

Re: [PATCH 1/2] IB/core: Remove unnecessary defines from ib_mad.h

removed instead. > > Fixes: d4ab347005fb ("IB/core: Add core header changes needed for OPA") > Signed-off-by: Ira Weiny <ira.we...@intel.com> Reviewed-by: Hal Rosenstock <h...@mellanox.com> -- To unsubscribe from this list: send the line "unsubscribe linux-r

[PATCH infiniband-diags] perfquery: Fix timeout on nodes supporting RS_FEC capability

to 0, so that ExtendedSpeedCounters GMP is sent to wrong destination. Signed-off-by: Dan Ben Yosef <da...@mellanox.com> Signed-off-by: Hal Rosenstock <h...@mellanox.com> --- src/perfquery.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/perfquery.c b/src/perfquery.c i

Re: [PATCH 2/2] IB/ipoib: Suppress warning for send only join failures

On 8/27/2015 7:34 PM, Jason Gunthorpe wrote: On Wed, Aug 26, 2015 at 05:41:08AM -0400, Hal Rosenstock wrote: On 8/25/2015 12:28 PM, Jason Gunthorpe wrote: On Tue, Aug 25, 2015 at 08:59:13AM -0400, Hal Rosenstock wrote: - if (mcast-logcount++ 20) { - if (status

Re: [PATCH 2/2] IB/ipoib: Suppress warning for send only join failures

On 8/25/2015 12:28 PM, Jason Gunthorpe wrote: On Tue, Aug 25, 2015 at 08:59:13AM -0400, Hal Rosenstock wrote: - if (mcast-logcount++ 20) { - if (status == -ETIMEDOUT || status == -EAGAIN) { + bool silent_fail = + test_bit

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

On 8/21/2015 7:34 PM, Jason Gunthorpe wrote: Even though we don't expect the group to be created by the SM we sill need to provide all the parameters to force the SM to validate they are correct. Out of curiosity, has it been observed that there was inconsistency in these additional IPoIB

Re: [PATCH 2/2] IB/ipoib: Suppress warning for send only join failures

On 8/21/2015 7:34 PM, Jason Gunthorpe wrote: We expect send only joins to fail, it just means there are no listeners for the group. The correct thing to do is silently drop the packet at source. Eg avahi will full join 224.0.0.251 which causes a send only IGMP packet to 224.0.0.22, and then

[PATCHv3 infiniband-diags] iblinkinfo.c: Close additional file descriptor in advance

Additional file descriptor for SMP MADs should be closed before running ibnd_discover_fabric() to avoid parallel usage of two SMP file descriptors Signed-off-by: Vladimir Koushnir vladim...@mellanox.com Signed-off-by: Hal Rosenstock h...@mellanox.com --- Change since v2: Only SMP query

Re: [PATCH v2 2/4 infiniband-diags] ibqueryerrors: Close global file descriptor before running ibnd_discover_fabric

On 7/3/2015 11:24 AM, ira.weiny wrote: On Sun, Apr 26, 2015 at 03:33:50PM -0400, Hal Rosenstock wrote: From: Vladimir Koushnir vladim...@mellanox.com Date: Sun, 26 Apr 2015 12:24:06 +0300 Global file descriptor for SMPs and GMPs should be closed before running ibnd_discover_fabric() to avoid

[PATCHv2 infiniband-diags] iblinkinfo.c: Close additional file descriptor inadvance

Additional file descriptor for SMP MADs should be closed before running ibnd_discover_fabric() to avoid parallel usage of two SMP file descriptors Signed-off-by: Vladimir Koushnir vladim...@mellanox.com Signed-off-by: Hal Rosenstock h...@mellanox.com --- Change since v1: Per Ira's comment, moved

[PATCH] IB: Add rdma_cap_ib_switch helper and use where appropriate

...@obsidianresearch.com Reviewed-by: Ira Weiny ira.we...@intel.com Tested-by: Ira Weiny ira.we...@intel.com Signed-off-by: Hal Rosenstock h...@mellanox.com --- Identical to RFCv2 patch with additional Reviewed and Tested by lines diff --git a/drivers/infiniband/core/agent.c b/drivers/infiniband

Re: [PATCHv2 RFC] IB: Add rdma_cap_ib_switch helper and use where appropriate

On 6/22/2015 4:20 PM, Jason Gunthorpe wrote: On Thu, Jun 18, 2015 at 07:25:32PM -0400, Hal Rosenstock wrote: Persuant to Liran's comments on node_type on linux-rdma mailing list: In an effort to reform the RDMA core and ULPs to minimize use of node_type in struct ib_device, an additional bit

Re: [PATCHv2 RFC] IB: Add rdma_cap_ib_switch helper and use where appropriate

On 6/22/2015 6:40 PM, Hefty, Sean wrote: Note that there still remain a couple of node type checks in the kernel that we may want to remove. There's an IB CA check in cma.c:rdma_notify This should check for rdma_cap_ib_cm() IB, RoCE, and OPA ports have the RDMA_CORE_CAP_IB_CM set so this

Re: [PATCH 14/14] IB/mad: Add final OPA MAD processing

On 6/18/2015 5:00 PM, Doug Ledford wrote: There is *zero* functional difference between node_type == OPA or node_type == IB_CA and link_layer == OPA. An application has *exactly* what they need We have neither of these things in the kernel today. Also, if I interpreted what was written by

[PATCH RFC] IB: Add rdma_cap_ib_switch helper and use where appropriate

) as well as (IPoIB and SRP) ULPs are updated where appropriate to use this new helper. Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/drivers/infiniband/core/agent.c b/drivers/infiniband/core/agent.c index c7dcfe4..0429040 100644 --- a/drivers/infiniband/core/agent.c +++ b/drivers

Re: [PATCH RFC] IB: Add rdma_cap_ib_switch helper and use where appropriate

On 6/18/2015 4:25 PM, Jason Gunthorpe wrote: Ira had patch that made some functions related to this public, not sure if it is applied yet.. Which patch from Ira are you referring to ? -- Hal -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to

[PATCHv2 RFC] IB: Add rdma_cap_ib_switch helper and use where appropriate

) as well as (IPoIB and SRP) ULPs are updated where appropriate to use this new helper. In some cases, the helper is now used under the covers of using rdma_[start end]_port rather than the open coding previously used. Signed-off-by: Hal Rosenstock h...@mellanox.com --- Changes since v1: Per Jason

Re: [PATCH v2 01/49] IB/core: Add OPA Port header definitions

On 6/17/2015 8:08 AM, Marciniszyn, Mike wrote: include/rdma/opa_port_info.h | 433 This matches the current code structure, but is this the best location for this file? Do you have a suggestion? Couldn't it be a header in the hfi1 driver directory ? Isn't it OPA specific ? -- Hal

Re: [PATCH acm] acme.c: Fix IPv6 address handling in inet_any_pton

On 6/17/2015 1:50 AM, Hefty, Sean wrote: Thanks - applied manually Thanks. acm/src/acme.c |2 +- Path? diff --git a/acm/src/acme.c b/acm/src/acme.c index 9bf7557..d54c8b9 100644 --- a/acm/src/acme.c +++ b/acm/src/acme.c @@ -787,7 +787,7 @@ static int inet_any_pton(char *addr,

Re: [PATCH v3 01/49] IB/core: Add header definitions

On 6/17/2015 8:28 AM, Mike Marciniszyn wrote: From: Ira Weiny ira.we...@intel.com Add common OPA header definitions for driver build: - opa_port_info.h - opa_smi.h - hfi1_user.sh Additionally, ib_mad.h, has additional definitions that are common to ib_drivers including: - trap support

[PATCH acm] acme.c: Fix IPv6 address handling in inet_any_pton

From: Ilya Nelkenbaum il...@mellanox.com In inet_any_pton() routine, src_addr was used by mistake instead of addr argument. Signed-off-by: Ilya Nelkenbaum il...@mellanox.com Signed-off-by: Hal Rosenstock h...@mellanox.com --- acm/src/acme.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH v4 1/1] ibacm: Add support for pathrecord query through netlink

On 6/9/2015 10:57 AM, kaike@intel.com wrote: From: Kaike Wan kaike@intel.com This patch enables ibacm to process pathrecord queries through netlink. Since ibacm can cache pathrecords, this implementation provides an easy pathrecord cache for kernel components and therefore offers

Re: [PATCH v4 1/1] ibacm: Add support for pathrecord query through netlink

On 6/11/2015 10:25 AM, Wan, Kaike wrote: +static void acm_nl_process_resolve(struct acmc_client *client, + struct acm_nl_msg *acmnlmsg) +{ + struct acm_msg msg; + struct nlattr *attr; + int payload_len; + int rem; + int total_attr_len; + +

Re: [PATCH v4 4/4] IB/sa: Route SA pathrecord query through netlink

On 6/11/2015 8:54 AM, Wan, Kaike wrote: From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] Sent: Thursday, June 11, 2015 8:24 AM To: Weiny, Ira Cc: Jason Gunthorpe; Wan, Kaike; linux-rdma@vger.kernel.org; Fleck, John Subject: Re: [PATCH v4 4/4] IB/sa: Route SA pathrecord query through

Re: [PATCH v4 4/4] IB/sa: Route SA pathrecord query through netlink

On 6/10/2015 5:09 PM, Weiny, Ira wrote: On 6/10/2015 3:10 PM, Jason Gunthorpe wrote: On Wed, Jun 10, 2015 at 01:47:36PM -0400, Hal Rosenstock wrote: On 6/9/2015 10:57 AM, kaike@intel.com wrote: From: Kaike Wan kaike@intel.com This patch routes a SA pathrecord query to netlink first

Re: [PATCH 14/14] IB/mad: Add final OPA MAD processing

On 6/11/2015 5:00 PM, Hefty, Sean wrote: cap_is_switch_smi would be a nice refinement to let us drop nodetype. Exactly, we need a bit added to the immutable data bits, and a new cap_ helper, and then nodetype is ready to be retired. Add a bit, drop a u8 ;-) I agree that the node type enum

Re: [PATCH 14/14] IB/mad: Add final OPA MAD processing

On 6/11/2015 7:52 PM, Hefty, Sean wrote: I agree that the node type enum isn't particularly useful and should be retired. Are you referring to kernel space or user space or both ? Short term, kernel space. User space needs to keep something around for backwards compatibility. But the

Re: [PATCH v4 0/4] Sending kernel pathrecord query to user cache server

On 6/9/2015 10:57 AM, kaike@intel.com wrote: From: Kaike Wan kaike@intel.com A SA cache is undeniably critical for fabric scalability and performance. In user space, the ibacm application provides a good example of pathrecord cache for address and route resolution. With the recent

Re: rdmacm issue

On 6/9/2015 9:52 PM, Bob Ciotti wrote: We have an issue where lustre servers and clients cannot talk to each other. There are about 11,000 clients all trying to connect to a server that just been rebooted (nbp6-oss3 in this example) pfe21 is a lustre client thats trying to remount the

Re: [PATCH v4 0/4] Sending kernel pathrecord query to user cache server

On 6/10/2015 10:22 AM, Wan, Kaike wrote: -Original Message- From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] Sent: Wednesday, June 10, 2015 9:37 AM A SA cache is undeniably critical for fabric scalability and performance. In user space, the ibacm application provides a good

Re: [PATCH v4 0/4] Sending kernel pathrecord query to user cache server

On 6/10/2015 11:21 AM, Hefty, Sean wrote: While this appears to address the current upstream use model for ACM with it's multicast overlay backend where PRs are static, it does not appear to address PR changes. Although this ties into ibacm, from the viewpoint of the kernel, there's no

Re: [PATCH v4 0/4] Sending kernel pathrecord query to user cache server

On 6/10/2015 11:49 AM, Wan, Kaike wrote: A SA cache is undeniably critical for fabric scalability and performance. In user space, the ibacm application provides a good example of pathrecord cache for address and route resolution. With the recent implementation of the provider architecture,

Re: [PATCH v4 4/4] IB/sa: Route SA pathrecord query through netlink

On 6/10/2015 3:10 PM, Jason Gunthorpe wrote: On Wed, Jun 10, 2015 at 01:47:36PM -0400, Hal Rosenstock wrote: On 6/9/2015 10:57 AM, kaike@intel.com wrote: From: Kaike Wan kaike@intel.com This patch routes a SA pathrecord query to netlink first Should only unicast PRs be done

Re: [PATCH v4 0/4] Sending kernel pathrecord query to user cache server

On 6/10/2015 1:04 PM, Hefty, Sean wrote: Not in the patches themselves but in the general issue when a PR changes. Do you think this needs addressing or are things fine as they are now ? IMO, I think it needs addressing in terms of can the proposed netlink architecture and design

Re: [PATCH v4 1/4] IB/netlink: Add defines for local service requests through netlink

On 6/10/2015 2:31 PM, Wan, Kaike wrote: From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] Sent: Wednesday, June 10, 2015 1:47 PM On 6/9/2015 10:57 AM, kaike@intel.com wrote: From: Kaike Wan kaike@intel.com This patch adds netlink defines for SA client, local service group

Re: [PATCH v4 4/4] IB/sa: Route SA pathrecord query through netlink

On 6/9/2015 10:57 AM, kaike@intel.com wrote: From: Kaike Wan kaike@intel.com This patch routes a SA pathrecord query to netlink first Should only unicast PRs be done in this manner or should API support enabling for unicast and/or multicast ? AFAIK kernel doesn't query multicast PRs

Re: [PATCH v4 0/4] Sending kernel pathrecord query to user cache server

On 6/10/2015 11:07 AM, Wan, Kaike wrote: -Original Message- From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] Sent: Wednesday, June 10, 2015 10:40 AM -Original Message- From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] Sent: Wednesday, June 10, 2015 9:37 AM

Re: [PATCH] Removed *p_ftree from function *sw_create().

Hi Vangelis, On 6/4/2015 8:12 AM, Vangelis wrote: ftree_fabric_t *p_ftree is not used anywhere in OpenSM's function sw_create(). --- opensm/osm_ucast_ftree.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) This looks fine to me. Please send me your S-O-B line for this. Thanks.

[PATCH opensm] Add cleanup of SA cache after handover

of potential issues with ServiceRecords (not being reregistered), dropping of those is also controlled by this option. Signed-off-by: Alex Netes ale...@mellanox.com Signed-off-by: Ilya Nelkenbaum il...@mellanox.com Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/include/opensm

  1   2   3   4   5   6   7   8   9   10   >