Re: [PATCH v2 01/10] ARM: EXYNOS: Make exynos machine_ops as static

2014-04-25 Thread Pankaj Dubey
HI Tomasz, Thanks for review and suggestions. On Sat, Apr 26, 2014 at 6:05 AM, Tomasz Figa wrote: > Hi Pankaj, > > > On 25.04.2014 14:32, Pankaj Dubey wrote: >> >> As machine function ops are used only in this file let's make >> them static. >> >> Signed-off-by: Pankaj Dubey >> --- >> arch/ar

Re: [PATCH v2 10/10] ARM: EXYNOS: Add device tree based initialization support for PMU.

2014-04-25 Thread Pankaj Dubey
HI Tomasz, Thanks for review. On Sat, Apr 26, 2014 at 7:40 AM, Tomasz Figa wrote: > Hi, > > > On 25.04.2014 14:32, Pankaj Dubey wrote: >> >> This patch adds device tree based initialization for PMU and modifies >> PMU initialization implementation in following way: >> >> 1: Let's initialize PMU

Re: [PATCH v2 05/10] ARM: EXYNOS: Remove regs-pmu.h header dependency from pm_domain

2014-04-25 Thread Pankaj Dubey
HI Tomasz, On Sat, Apr 26, 2014 at 6:19 AM, Tomasz Figa wrote: > Hi, > > > On 25.04.2014 14:32, Pankaj Dubey wrote: >> >> From: Young-Gun Jang >> >> Current "pm_domain.c" file uses "S5P_INT_LOCAL_PWR_EN" definition from >> "regs-pmu.h" and hence needs to include this header file. As there is >>

Re: [PATCH v2 08/10] ARM: EXYNOS: Refactored code for using PMU address via DT

2014-04-25 Thread Pankaj Dubey
Hi Tomasz, Thanks for review. On Sat, Apr 26, 2014 at 7:19 AM, Tomasz Figa wrote: > Hi, > > > On 25.04.2014 14:32, Pankaj Dubey wrote: >> >> Under "arm/mach-exynos" many files are using PMU register offsets. >> Since we have added support for accessing PMU base address via DT, >> now we can remo

Re: [PATCH 1/4] ARM: dts: exynos4: add PMU syscon node

2014-04-25 Thread Pankaj Dubey
Hi Tomasz, On Sat, Apr 26, 2014 at 8:52 AM, Tomasz Figa wrote: > Hi Vikas, > > > On 25.04.2014 10:05, Vikas Sajjan wrote: >> >> Hi, >> >> >> On Thu, Apr 24, 2014 at 9:37 PM, Tomasz Figa wrote: >>> >>> Hi Chanho, >>> >>> >>> On 14.04.2014 14:48, Chanho Park wrote: This patch adds a

Re: [PATCH v2 00/10] ARM: Exynos: PMU cleanup and refactoring for using DT

2014-04-25 Thread Pankaj Dubey
Hi Tomasz, On Sat, Apr 26, 2014 at 7:43 AM, Tomasz Figa wrote: > > Hi Pankaj, > > Just a small note - please refrain from sending next versions of series in > reply to previous version. With threading applied, it gets hard to notice > that a new version was posted, because the first message of

Re: [PATCHv4 7/7] ARM: dts: Add device tree sources for Exynos3250

2014-04-25 Thread Tomasz Figa
Hi Chanwoo, On 25.04.2014 03:16, Chanwoo Choi wrote: From: Tomasz Figa This patch add new exynos3250.dtsi to support Exynos3250 SoC based on Cortex-A7 dual core and includes following dt nodes: - GIC interrupt controller - Pinctrl to control GPIOs - Clock controller - CPU information (Cortex-

Re: [PATCHv4 2/7] ARM: EXYNOS: Support secondary CPU boot of Exynos4212

2014-04-25 Thread Tomasz Figa
Hi, On 25.04.2014 03:16, Chanwoo Choi wrote: From: Kyungmin Park This patch fix the offset of CPU boot address and change parameter of smc call of SMC_CMD_CPU1BOOT command for Exynos4212. Signed-off-by: Kyungmin Park Signed-off-by: Chanwoo Choi --- arch/arm/mach-exynos/firmware.c | 15 +++

Re: [PATCHv4 5/7] clk: samsung: exynos3250: Add clocks using common clock framework

2014-04-25 Thread Tomasz Figa
Hi Chanwoo, On 25.04.2014 03:16, Chanwoo Choi wrote: From: Tomasz Figa This patch add new the clock drvier of Exynos3250 SoC based on Cortex-A7 using common clock framework. The CMU (Clock Management Unit) of Exynos3250 control PLLs(Phase Locked Loops) and generate system clocks for CPU, buses

Re: [PATCHv4 1/7] ARM: EXYNOS: Add Exynos3250 SoC ID

2014-04-25 Thread Tomasz Figa
Hi Chanwoo, On 25.04.2014 03:16, Chanwoo Choi wrote: This patch add Exynos3250's SoC ID. Exynos 3250 is System-On-Chip(SoC) that is based on the 32-bit RISC processor for Smartphone. Exynos3250 uses Cortex-A7 dual cores and has a target speed of 1.0GHz. Signed-off-by: Chanwoo Choi Acked-by: Ky

Re: [PATCHv4 4/7] ARM: EXYNOS: Enter a15 lowpower mode for Exynos3250 based on Cortex-a7

2014-04-25 Thread Russell King - ARM Linux
On Sat, Apr 26, 2014 at 02:25:03AM +0200, Tomasz Figa wrote: > On 25.04.2014 03:16, Chanwoo Choi wrote: >> This patch decide proper lowpower mode of either a15 or a9 according to own >> ID >> from Main ID register. >> >> Cc: Arnd Bergmann >> Cc: Marc Zynigier >> Signed-off-by: Chanwoo Choi >> A

Re: [PATCHv4 4/7] ARM: EXYNOS: Enter a15 lowpower mode for Exynos3250 based on Cortex-a7

2014-04-25 Thread Tomasz Figa
Hi Chanwoo, On 25.04.2014 03:16, Chanwoo Choi wrote: This patch decide proper lowpower mode of either a15 or a9 according to own ID from Main ID register. Cc: Arnd Bergmann Cc: Marc Zynigier Signed-off-by: Chanwoo Choi Acked-by: Kyungmin Park --- arch/arm/mach-exynos/hotplug.c | 19 ++

Re: [PATCHv2 1/4] ARM: dts: exynos4: add PMU syscon node

2014-04-25 Thread Tomasz Figa
Hi Chanho, On 25.04.2014 08:59, Chanho Park wrote: This patch adds a PMU(Power Management Unit) syscon node. This should be required for USB Phy syscon regmap I/F. Cc: Kamil Debski Signed-off-by: Chanho Park Reviewed-by: Tomasz Figa --- Documentation/devicetree/bindings/arm/samsung/pmu.txt

Re: [PATCH 1/4] ARM: dts: exynos4: add PMU syscon node

2014-04-25 Thread Tomasz Figa
Hi Vikas, On 25.04.2014 10:05, Vikas Sajjan wrote: Hi, On Thu, Apr 24, 2014 at 9:37 PM, Tomasz Figa wrote: Hi Chanho, On 14.04.2014 14:48, Chanho Park wrote: This patch adds a PMU(Power Management Unit) syscon node. This should be required for USB Phy syscon regmap I/F. Cc: Tomasz Figa

Re: [PATCH v5] clk: Exynos5250: Add clocks for G3D

2014-04-25 Thread Tomasz Figa
Hi Arun, On 24.04.2014 16:49, Arun Kumar K wrote: This patch adds the required clocks for ARM Mali IP in Exynos5250. Signed-off-by: Arun Kumar K --- This patch somehow got missed getting merged long time back after Acks by Mike and Kukjin and review done by Tomasz and Doug. Sorry for this, I

Re: [PATCH] ARM: dts: Remove mau_pd node for Exynos5420

2014-04-25 Thread Tomasz Figa
On 24.04.2014 13:03, Tushar Behera wrote: On 04/24/2014 03:36 PM, Tomasz Figa wrote: On 24.04.2014 11:07, Tushar Behera wrote: On 04/23/2014 03:43 PM, Kukjin Kim wrote: Tushar Behera wrote: On 22 April 2014 13:08, Alim Akhtar wrote: Hi Tushar On Tue, Apr 22, 2014 at 11:09 AM, Tushar Beh

Re: [PATCH] ARM: exynos: register sched_clock callback

2014-04-25 Thread Tomasz Figa
Hi Vincent, On 24.04.2014 11:21, Vincent Guittot wrote: Use the clocksource mct-frc for sched_clock Signed-off-by: Vincent Guittot --- drivers/clocksource/exynos_mct.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_m

Re: [PATCH v6 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-25 Thread Tomasz Figa
Hi Vivek, I have reviewed v5 without noticing this one, but I think most of the comments still apply. Best regards, Tomasz On 22.04.2014 13:24, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact

Re: [PATCH v8 1/3] ARM: EXYNOS: Add support for EXYNOS5410 SoC

2014-04-25 Thread Tomasz Figa
Hi Kevin, On 26.04.2014 00:52, Kevin Hilman wrote: Tarek Dakhran writes: EXYNOS5410 is SoC in Samsung's Exynos5 SoC series. Add initial support for this SoC. Signed-off-by: Tarek Dakhran Signed-off-by: Vyacheslav Tyrtov Reviewed-by: Tomasz Figa [...] diff --git a/arch/arm/mach-exynos/

Re: [PATCH v5 1/2] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-25 Thread Tomasz Figa
Hi Vivek, On 22.04.2014 10:03, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact with DWC3 controller present on Exynos5 series of SoCs. Thereby, removing old phy-samsung-usb3 driver and related cod

Re: [PATCH v8 0/3] Exynos 5410 support

2014-04-25 Thread Kevin Hilman
Tarek Dakhran writes: > The series of patches represent support of Exynos 5410 SoC > > The Exynos 5410 is the first Samsung SoC based on bigLITTLE architecture > > Patches add new platform description, support of clock controller and device > tree for Exynos 5410. > > Has been build on Linux Kern

Re: [PATCH v8 1/3] ARM: EXYNOS: Add support for EXYNOS5410 SoC

2014-04-25 Thread Kevin Hilman
Tarek Dakhran writes: > EXYNOS5410 is SoC in Samsung's Exynos5 SoC series. > Add initial support for this SoC. > > Signed-off-by: Tarek Dakhran > Signed-off-by: Vyacheslav Tyrtov > Reviewed-by: Tomasz Figa [...] > diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c >

Re: [PATCH 2/4] ARM: EXYNOS: Fix core ID used by platsmp and hotplug code

2014-04-25 Thread Tomasz Figa
Hi Chander, On 20.04.2014 09:23, Chander Kashyap wrote: Hi Tomasz, On 18 April 2014 20:12, Tomasz Figa wrote: When CPU topology is specified in device tree, cpu_logical_map() does not return core ID anymore, but rather full MPIDR value. This breaks existing calculation of PMU register offset

Re: [PATCH v2 00/10] ARM: Exynos: PMU cleanup and refactoring for using DT

2014-04-25 Thread Tomasz Figa
Hi Pankaj, Just a small note - please refrain from sending next versions of series in reply to previous version. With threading applied, it gets hard to notice that a new version was posted, because the first message of the thread is always v1. Also it makes threads unnecessarily long. Best

Re: [PATCH v2 10/10] ARM: EXYNOS: Add device tree based initialization support for PMU.

2014-04-25 Thread Tomasz Figa
Hi, On 25.04.2014 14:32, Pankaj Dubey wrote: This patch adds device tree based initialization for PMU and modifies PMU initialization implementation in following way: 1: Let's initialize PMU based on device tree compatibility string. 2: Obtain PMU regmap handle using "syscon_early_regmap_lookup

Re: [PATCH v2 08/10] ARM: EXYNOS: Refactored code for using PMU address via DT

2014-04-25 Thread Tomasz Figa
Hi, On 25.04.2014 14:32, Pankaj Dubey wrote: Under "arm/mach-exynos" many files are using PMU register offsets. Since we have added support for accessing PMU base address via DT, now we can remove PMU mapping from exynosX_iodesc. Let's convert all these access using either of "get_exynos_pmuaddr

Re: [PATCH v2 07/10] ARM: EXYNOS: Remove "linux/bug.h" from pmu.c

2014-04-25 Thread Tomasz Figa
Hi, On 25.04.2014 14:32, Pankaj Dubey wrote: From: Young-Gun Jang This patch removes unnecessary header file inclusion from pmu.c. Signed-off-by: Young-Gun Jang --- arch/arm/mach-exynos/pmu.c |1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-

Re: [PATCH v2 06/10] ARM: EXYNOS: Add support for mapping PMU base address via DT

2014-04-25 Thread Tomasz Figa
Hi, On 25.04.2014 14:32, Pankaj Dubey wrote: From: Young-Gun Jang Add support for mapping Samsung Power Management Unit (PMU) base address from device tree. Code will use existing samsung pmu binding information. This patch also adds two helper functions as "get_exynos_pmuregmap" and "get_exyn

Re: [PATCH v2 05/10] ARM: EXYNOS: Remove regs-pmu.h header dependency from pm_domain

2014-04-25 Thread Tomasz Figa
Hi, On 25.04.2014 14:32, Pankaj Dubey wrote: From: Young-Gun Jang Current "pm_domain.c" file uses "S5P_INT_LOCAL_PWR_EN" definition from "regs-pmu.h" and hence needs to include this header file. As there is no other user of "S5P_INT_LOCAL_PWR_EN" definition other than pm_domain, to remove "reg

Re: [PATCH v2 04/10] ARM: EXYNOS: Remove file path from comment section

2014-04-25 Thread Tomasz Figa
Hi Pankaj, On 25.04.2014 14:32, Pankaj Dubey wrote: Many files under "arm/mach-exynos" are having file path in file comment section which is invalid now. So for better code maintainability let's remove them. Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/headsmp.S |2 --

Re: [PATCH v2 03/10] ARM: EXYNOS: Move SYSREG definition into sys-reg specific file.

2014-04-25 Thread Tomasz Figa
Hi Pankaj, On 25.04.2014 14:32, Pankaj Dubey wrote: From: Young-Gun Jang While making PMU implementation to be device tree based, there are few register offsets related with SYSREG present in regs-pmu.h, so let's make a new header file "regs-sys.h" to keep all such SYSREG related register offs

Re: [PATCH v2 01/10] ARM: EXYNOS: Make exynos machine_ops as static

2014-04-25 Thread Tomasz Figa
Hi Pankaj, On 25.04.2014 14:32, Pankaj Dubey wrote: As machine function ops are used only in this file let's make them static. Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/exynos.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-exynos/exyn

Re: [PATCH v2 02/10] ARM: EXYNOS: Cleanup "mach-exynos/common.h" file

2014-04-25 Thread Tomasz Figa
Hi Pankaj, On 25.04.2014 14:32, Pankaj Dubey wrote: Remove unused and unwanted declarations from "mach-exynos/common.h" Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/common.h |6 -- 1 file changed, 6 deletions(-) diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exy

Re: [PATCH v2 1/5] ARM: dts: Add syscon handle in pmu node for exynos5250

2014-04-25 Thread Tomasz Figa
Hi Pankaj, On 25.04.2014 13:54, Pankaj Dubey wrote: Add "samsung,syscon-phandle" property pointing to PMU node to access PMU register via PMU regmap handle. Signed-off-by: Pankaj Dubey --- arch/arm/boot/dts/exynos5250.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot

Re: [PATCH] ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

2014-04-25 Thread Tomasz Figa
On 25.04.2014 22:30, Javi Merino wrote: On Fri, Apr 25, 2014 at 09:16:30PM +0100, Tomasz Figa wrote: Hi Javi, On 25.04.2014 22:11, Javi Merino wrote: d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board) added the vmmc-supply to nodes mmc@1220 and mmc@1222 of the DT.

Re: [PATCH] ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

2014-04-25 Thread Javi Merino
On Fri, Apr 25, 2014 at 09:16:30PM +0100, Tomasz Figa wrote: > Hi Javi, > > On 25.04.2014 22:11, Javi Merino wrote: > > d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board) > > added the vmmc-supply to nodes mmc@1220 and mmc@1222 of the > > DT. However, this makes the ker

[PATCH v5 2/8] cpufreq: Use cpufreq_for_each_* macros for frequency table iteration

2014-04-25 Thread Stratos Karafotis
The cpufreq core now supports the cpufreq_for_each_entry and cpufreq_for_each_valid_entry macros helpers for iteration over the cpufreq_frequency_table, so use them. It should have no functional changes. Signed-off-by: Stratos Karafotis --- drivers/cpufreq/acpi-cpufreq.c | 9 +++--- driv

Re: [PATCH] ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

2014-04-25 Thread Tomasz Figa
Hi Javi, On 25.04.2014 22:11, Javi Merino wrote: d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board) added the vmmc-supply to nodes mmc@1220 and mmc@1222 of the DT. However, this makes the kernel fail to boot on the arndale-octa spews: [5.06] dwmmc_exynos 1220

[PATCH] ARM: dts: Remove vmmc-supply for mmc@12220000 on arndale-octa board

2014-04-25 Thread Javi Merino
d726ca2d3316 (ARM: dts: Add vmmc-supply to MMC on arndale-octa board) added the vmmc-supply to nodes mmc@1220 and mmc@1222 of the DT. However, this makes the kernel fail to boot on the arndale-octa spews: [5.06] dwmmc_exynos 1220.mmc: num-slots property not found, assuming 1

Re: [PATCH V2 2/9] drm/panel: add pre_enable and post_disable routines

2014-04-25 Thread Ajay kumar
On Fri, Apr 25, 2014 at 11:34 AM, Ajay kumar wrote: > On Friday, April 25, 2014, Thierry Reding wrote: >> >> On Thu, Apr 24, 2014 at 12:56:02AM +0530, Ajay kumar wrote: >> > Thierry, >> > >> > On Wed, Apr 23, 2014 at 1:12 PM, Thierry Reding >> > wrote: >> > > On Wed, Apr 23, 2014 at 09:29:15AM +

Re: [PATCH 5/5] iio: exynos_adc: do a reinit_completion before the conversion

2014-04-25 Thread Doug Anderson
Naveen On Fri, Apr 25, 2014 at 3:14 AM, Naveen Krishna Chatradhi wrote: > Add reinit_completion() before the wait_for_completion_timeout in > raw_read() call. > > Change-Id: I70fa00841bc49eba838a5bd6779015844297dfdb Again, remove Change-Id (in the previous patch, too). > Signed-off-by: Naveen K

Re: [PATCH 4/5] iio: exynos_adc: do a soft reset in case of timeout

2014-04-25 Thread Doug Anderson
Naveen, On Fri, Apr 25, 2014 at 3:14 AM, Naveen Krishna Chatradhi wrote: > Do a soft reset software if a timeout happens. > This is applicable only for ADC_V2. > > Change-Id: I939eaa06254e0b246dd636df9470f2eb392c2be1 > Signed-off-by: Naveen Krishna Chatradhi > --- > This change is a part of the

Re: [PATCH 3/5] iio: exynos_adc: reduce timeout and use wait_for_completion_timeout

2014-04-25 Thread Doug Anderson
Naveen, On Fri, Apr 25, 2014 at 3:14 AM, Naveen Krishna Chatradhi wrote: > ADC module on Exynos5 SoCs runs at 600KSPS. At this conversion rate, > waiting for 1000 msecs is wasteful (incase of h/w failure). > > Hence, reduce the time out to 100msecs and use > wait_for_completion_timeout() instead

Re: [PATCH 2/5] iio: exynos_adc: rearrange clock and regulator enable/disable calls

2014-04-25 Thread Doug Anderson
Naveen, On Fri, Apr 25, 2014 at 3:14 AM, Naveen Krishna Chatradhi wrote: > From: Naveen Krishna Ch > > This patch maintains the following order in > probe(), remove(), resume() and suspend() calls > > regulator enable, clk prepare enable > ... > clk disable unprepare, regulator disable > > While

Re: [PATCH 1/5] iio: exynos_adc: use indio_dev->dev structure to handle child nodes

2014-04-25 Thread Doug Anderson
Naveen, Thanks for sending this. Given that Jonathan Cameron was involved in the previous discussion, it probably would have been wise to include him on the CC list. On Fri, Apr 25, 2014 at 3:14 AM, Naveen Krishna Chatradhi wrote: > From: Naveen Krishna Ch > > Using pdev->dev with device_for_e

Re: [PATCH v4 2/8] cpufreq: Use cpufreq_for_each_* macros for frequency table iteration

2014-04-25 Thread Stratos Karafotis
Hi Prabhakar, On 25/04/2014 03:31 μμ, Prabhakar Lad wrote: > Hi Stratos, > > Thanks for the patch. > > On Tue, Apr 22, 2014 at 4:30 AM, Stratos Karafotis > wrote: >> The cpufreq core now supports the cpufreq_for_each_entry and >> cpufreq_for_each_valid_entry macros helpers for iteration over th

RE: [PATCH 0/8] i.MX6 PCIe binding change and MSI support

2014-04-25 Thread hong-xing....@freescale.com
> -Original Message- > From: Bjorn Helgaas [mailto:bhelg...@google.com] > Sent: Friday, April 25, 2014 10:40 PM > To: Lucas Stach > Cc: Zhu Richard-R65037; Jingoo Han; Shawn Guo; linux-...@vger.kernel.org; > linux-arm; linux-samsung-soc@vger.kernel.org; devicet...@vger.kernel.org; Sean > C

Re: [PATCH v8 2/2] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-04-25 Thread Alan Stern
On Fri, 25 Apr 2014, Vivek Gautam wrote: > From: Kamil Debski > > Add the phy provider, supplied by new Exynos-usb2phy using > Generic phy framework. > Keeping the support for older USB phy intact right now, in order > to prevent any functionality break in absence of relevant > device tree side

Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support

2014-04-25 Thread Bjorn Helgaas
On Fri, Apr 25, 2014 at 4:21 AM, Lucas Stach wrote: > Am Donnerstag, den 24.04.2014, 11:58 -0600 schrieb Bjorn Helgaas: >> On Fri, Mar 28, 2014 at 05:52:51PM +0100, Lucas Stach wrote: >> > While working on MSI support for the i.MX6 PCIe host driver >> > it has been discovered that the binding for

Re: [PATCH v2 1/2] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-25 Thread Alan Stern
On Fri, 25 Apr 2014, Vivek Gautam wrote: > Add support to consume phy provided by Generic phy framework. > Keeping the support for older usb-phy intact right now, in order > to prevent any functionality break in absence of relevant > device tree side change for ohci-exynos. > Once we move to new p

Re: [PATCH RFC 3/3] drm/exynos: use pending_components for components tracking

2014-04-25 Thread Andrzej Hajda
On 04/23/2014 07:13 PM, Russell King - ARM Linux wrote: > On Wed, Apr 23, 2014 at 05:43:28PM +0100, Russell King - ARM Linux wrote: >> So, maybe you would like to finally address *my* point about TDA998x >> and your solution in a way that provides a satisfactory answer. *Show* >> how it can be don

[RFC PATCH v2 3/3] drivers: mfd: Add support for Exynos PMU driver

2014-04-25 Thread Pankaj Dubey
This patch moves Exynos PMU driver implementation from "arm/mach-exynos" to "drivers/mfd". This driver is mainly used for setting misc bits of register from PMU IP of Exynos SoC which will be required to configure before Suspend/Resume. Currently all these settings are done in "arch/arm/mach-exynos

[RFC PATCH v2 1/3] ARM: EXYNOS: Move PMU specific definitions from common.h

2014-04-25 Thread Pankaj Dubey
From: Younggun Jang This patch moves PMU specific definitions into a new file as exynos-pmu.h. This will help in making PMU implementation independent of common.h header. Signed-off-by: Young-Gun Jang Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/common.h | 17 -

[RFC PATCH v2 2/3] ARM: EXYNOS: Move pmu specific header files under "linux/mfd/samsung"

2014-04-25 Thread Pankaj Dubey
Moving Exynos PMU specific header file into "include/linux/mfd/samsung" thus updated affected files under "mach-exynos" to use new location of these header files. CC: Sangbeom Kim CC: Samuel Ortiz CC: Lee Jones Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/cpuidle.c |4

[RFC PATCH v2 0/3] Add support for Exynos PMU driver

2014-04-25 Thread Pankaj Dubey
This patch series moves PMU implementation from "mach-exynos/pmu.c" to "drivers/mfd/exynos-pmu.c". Patch v1 was posted as RFC [1]. In case of ARM32 we had machine folder such as "mach-exynos" but moving forward with ARM64 SoC support we can not have any more such machine folders, keeping that in

Re: [PATCH v4 2/8] cpufreq: Use cpufreq_for_each_* macros for frequency table iteration

2014-04-25 Thread Prabhakar Lad
Hi Stratos, Thanks for the patch. On Tue, Apr 22, 2014 at 4:30 AM, Stratos Karafotis wrote: > The cpufreq core now supports the cpufreq_for_each_entry and > cpufreq_for_each_valid_entry macros helpers for iteration over the > cpufreq_frequency_table, so use them. > > It should have no functional

[PATCH v2 01/10] ARM: EXYNOS: Make exynos machine_ops as static

2014-04-25 Thread Pankaj Dubey
As machine function ops are used only in this file let's make them static. Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/exynos.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index b32a907..2388e

[PATCH v2 00/10] ARM: Exynos: PMU cleanup and refactoring for using DT

2014-04-25 Thread Pankaj Dubey
This patch series, does some minor cleanup and modifies Exynos PMU related code for mapping and initialization of Exynos Power Management Unit (PMU) base address from device tree. This is also preparation for moving PMU related code out of machine folder and moving into a "drivers/mfd", so that ARM

[PATCH v2 10/10] ARM: EXYNOS: Add device tree based initialization support for PMU.

2014-04-25 Thread Pankaj Dubey
This patch adds device tree based initialization for PMU and modifies PMU initialization implementation in following way: 1: Let's initialize PMU based on device tree compatibility string. 2: Obtain PMU regmap handle using "syscon_early_regmap_lookup_by_phandle" so that we can reduce dependency ov

[PATCH v2 03/10] ARM: EXYNOS: Move SYSREG definition into sys-reg specific file.

2014-04-25 Thread Pankaj Dubey
From: Young-Gun Jang While making PMU implementation to be device tree based, there are few register offsets related with SYSREG present in regs-pmu.h, so let's make a new header file "regs-sys.h" to keep all such SYSREG related register offsets and remove them from "regs-pmu.h" Signed-off-by: Y

[PATCH v2 08/10] ARM: EXYNOS: Refactored code for using PMU address via DT

2014-04-25 Thread Pankaj Dubey
Under "arm/mach-exynos" many files are using PMU register offsets. Since we have added support for accessing PMU base address via DT, now we can remove PMU mapping from exynosX_iodesc. Let's convert all these access using either of "get_exynos_pmuaddr" or "get_exynos_regmap". This will help us in r

[PATCH v2 05/10] ARM: EXYNOS: Remove regs-pmu.h header dependency from pm_domain

2014-04-25 Thread Pankaj Dubey
From: Young-Gun Jang Current "pm_domain.c" file uses "S5P_INT_LOCAL_PWR_EN" definition from "regs-pmu.h" and hence needs to include this header file. As there is no other user of "S5P_INT_LOCAL_PWR_EN" definition other than pm_domain, to remove "regs-pmu.h" header file dependency from "pm_domain.

[PATCH v2 07/10] ARM: EXYNOS: Remove "linux/bug.h" from pmu.c

2014-04-25 Thread Pankaj Dubey
From: Young-Gun Jang This patch removes unnecessary header file inclusion from pmu.c. Signed-off-by: Young-Gun Jang --- arch/arm/mach-exynos/pmu.c |1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos/pmu.c index 05c7ce1..4c3453a 100644 --- a/a

[PATCH v2 06/10] ARM: EXYNOS: Add support for mapping PMU base address via DT

2014-04-25 Thread Pankaj Dubey
From: Young-Gun Jang Add support for mapping Samsung Power Management Unit (PMU) base address from device tree. Code will use existing samsung pmu binding information. This patch also adds two helper functions as "get_exynos_pmuregmap" and "get_exynos_pmuaddr". "get_exynos_pmuregmap" returns a re

[PATCH v2 09/10] ARM: EXYNOS: Move "mach/map.h" inclusion from regs-pmu.h to platsmp.c

2014-04-25 Thread Pankaj Dubey
As we have removed static mappings from "regs-pmu.h" it does not need map.h anymore. But "platsmp.c" needed this and till now it got included indirectly. So lets move header inclusion of "mach/map.h" from "regs-pmu.h" to "platsmp.c". Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/platsmp.c

[PATCH v2 04/10] ARM: EXYNOS: Remove file path from comment section

2014-04-25 Thread Pankaj Dubey
Many files under "arm/mach-exynos" are having file path in file comment section which is invalid now. So for better code maintainability let's remove them. Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/headsmp.S |2 -- arch/arm/mach-exynos/hotplug.c |3 +--

[PATCH v2 02/10] ARM: EXYNOS: Cleanup "mach-exynos/common.h" file

2014-04-25 Thread Pankaj Dubey
Remove unused and unwanted declarations from "mach-exynos/common.h" Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/common.h |6 -- 1 file changed, 6 deletions(-) diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h index 9ef3f83..31c5964 100644 --- a/arch/arm

[PATCH v2 4/5] arm: dts: Add syscon handle in pmu node for exynos5420

2014-04-25 Thread Pankaj Dubey
Add "samsung,syscon-phandle" property pointing to PMU node to access PMU register via PMU regmap handle. Signed-off-by: Pankaj Dubey --- arch/arm/boot/dts/exynos5420.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi

[PATCH v2 2/5] ARM: dts: Add PMU node to exynos4210

2014-04-25 Thread Pankaj Dubey
This patch adds pmu regnode to exynos4210 dtsi to handle PMU register access via DT. Signed-off-by: Pankaj Dubey --- arch/arm/boot/dts/exynos4210.dtsi |6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi index cacf614

[PATCH v2 5/5] Documentation: update samsung pmu binding information

2014-04-25 Thread Pankaj Dubey
This patch updates samsung pmu (power management unit) binding information. CC: Leela Krishna Amudala CC: Guenter Roeck CC: Rob Landley Signed-off-by: Pankaj Dubey --- Documentation/devicetree/bindings/arm/samsung/pmu.txt |7 +++ 1 file changed, 7 insertions(+) diff --git a/Documenta

[PATCH v2 1/5] ARM: dts: Add syscon handle in pmu node for exynos5250

2014-04-25 Thread Pankaj Dubey
Add "samsung,syscon-phandle" property pointing to PMU node to access PMU register via PMU regmap handle. Signed-off-by: Pankaj Dubey --- arch/arm/boot/dts/exynos5250.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi

[PATCH v2 3/5] ARM: dts: Add PMU node to exynos4212 and exynos4412

2014-04-25 Thread Pankaj Dubey
This patch adds pmu regnode to exynos4212 and exynos4412 dtsi to handle PMU register access via DT. Signed-off-by: Pankaj Dubey --- arch/arm/boot/dts/exynos4212.dtsi |6 ++ arch/arm/boot/dts/exynos4412.dtsi |6 ++ 2 files changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/

[PATCH v2 0/5] Add PMU node for Exynos SoCs

2014-04-25 Thread Pankaj Dubey
This patch series adds new property in samsung PMU binding as "samsung,syscon-phandle" to get PMU regmap handle in PMU driver implementation and "mach-exynos/exynos.c". This patch also updates Exynos4210, Exynos4412 and Exynos4212 dtsi files for adding PMU (Power Management Unit) reg node. Updated

[PATCH v7 1/2] ARM: dts: Add sysreg sytem controller node to exynos5250 and exynos5420

2014-04-25 Thread Vivek Gautam
This patch adds sysreg-syscon node to exynos5250 and exynos5420 device tree, to access System Register's registers using syscon driver. Signed-off-by: Kamil Debski [gautam.vi...@samsung.com: Split this syreg-syscon dts entry from dts: Add usb2phy to Exynos 5250 patch] [gautam.vi...@samsung.com: a

[PATCH v7 2/2] ARM: dts: Add usb2phy to Exynos 5250

2014-04-25 Thread Vivek Gautam
From: Kamil Debski Add support to PHY of USB2 of the Exynos 5250 SoC. Signed-off-by: Kamil Debski [gautam.vi...@samsung.com: Split the usb phy entries from syscon entries from earlier patch: dts: Add usb2phy to Exynos 5250] [gautam.vi...@samsung.com: Added phy entry for OHCI also along with EHC

[PATCH v7 0/2] dts: Add usb2phy to Exynos 5250

2014-04-25 Thread Vivek Gautam
Next version of patch for Kamil's patch: [PATCH v6 4/8] dts: Add usb2phy to Exynos 5250 https://lkml.org/lkml/2014/1/29/302 Based on 'for-next' branch of Kgene's linux-samsung tree. Tested with driver side patches: [PATCH 0/2] usb: ehci/ohci-exynos: Move to generic phy framework https://www.mail-a

[PATCH v8 2/2] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-04-25 Thread Vivek Gautam
From: Kamil Debski Add the phy provider, supplied by new Exynos-usb2phy using Generic phy framework. Keeping the support for older USB phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ehci-exynos. Once we move to new phy in the d

[PATCH 0/2] usb: ehci/ohci-exynos: Move to generic phy framework

2014-04-25 Thread Vivek Gautam
Added required support for getting phy-provider from generic phy framework Based and tested on 'usb-next' branch of Greg's usb tree, with relevant device tree patches (which i will sending soon). Patch: usb: ehci-exynos: Change to use phy provided by the generic phy framework is the patch from Ka

[PATCH v7 2/2] usb: ehci-exynos: Change to use phy provided by the generic phy framework

2014-04-25 Thread Vivek Gautam
From: Kamil Debski Add the phy provider, supplied by new Exynos-usb2phy using Generic phy framework. Keeping the support for older USB phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ehci-exynos. Once we move to new phy in the d

[PATCH v2 1/2] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

2014-04-25 Thread Vivek Gautam
Add support to consume phy provided by Generic phy framework. Keeping the support for older usb-phy intact right now, in order to prevent any functionality break in absence of relevant device tree side change for ohci-exynos. Once we move to new phy in the device nodes for ohci, we can remove the s

[PATCH 4/5] iio: exynos_adc: do a soft reset in case of timeout

2014-04-25 Thread Naveen Krishna Chatradhi
Do a soft reset software if a timeout happens. This is applicable only for ADC_V2. Change-Id: I939eaa06254e0b246dd636df9470f2eb392c2be1 Signed-off-by: Naveen Krishna Chatradhi --- This change is a part of the patch reviewed at https://lkml.org/lkml/2013/11/5/92 drivers/iio/adc/exynos_adc.c |

[PATCH 0/5] iio: exynos_adc: fix minor nits in the driver

2014-04-25 Thread Naveen Krishna Chatradhi
This patchset fixes the 1. bug causing a crash during module removal for exynos_adc.ko. -> The bug was seen by Doug, while trying to compile the whole IIO subsystem as module @ https://lkml.org/lkml/2014/4/21/481 from Doug. 2. rearrange the clock and regulator enable/disable calls during pr

Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support

2014-04-25 Thread Lucas Stach
Am Donnerstag, den 24.04.2014, 11:58 -0600 schrieb Bjorn Helgaas: > On Fri, Mar 28, 2014 at 05:52:51PM +0100, Lucas Stach wrote: > > While working on MSI support for the i.MX6 PCIe host driver > > it has been discovered that the binding for this host controller > > is broken in many ways (refer to

[PATCH 2/5] iio: exynos_adc: rearrange clock and regulator enable/disable calls

2014-04-25 Thread Naveen Krishna Chatradhi
From: Naveen Krishna Ch This patch maintains the following order in probe(), remove(), resume() and suspend() calls regulator enable, clk prepare enable ... clk disable unprepare, regulator disable While at it, 1. enable the regulator before the iio_device_register() 2. handle the return values

[PATCH 3/5] iio: exynos_adc: reduce timeout and use wait_for_completion_timeout

2014-04-25 Thread Naveen Krishna Chatradhi
ADC module on Exynos5 SoCs runs at 600KSPS. At this conversion rate, waiting for 1000 msecs is wasteful (incase of h/w failure). Hence, reduce the time out to 100msecs and use wait_for_completion_timeout() instead of wait_for_completion_interruptible_timeout() Also, handle the return values in ex

[PATCH 5/5] iio: exynos_adc: do a reinit_completion before the conversion

2014-04-25 Thread Naveen Krishna Chatradhi
Add reinit_completion() before the wait_for_completion_timeout in raw_read() call. Change-Id: I70fa00841bc49eba838a5bd6779015844297dfdb Signed-off-by: Naveen Krishna Chatradhi --- drivers/iio/adc/exynos_adc.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/adc/exynos_adc.c b/d

[PATCH 1/5] iio: exynos_adc: use indio_dev->dev structure to handle child nodes

2014-04-25 Thread Naveen Krishna Chatradhi
From: Naveen Krishna Ch Using pdev->dev with device_for_each_child() would iterate over all of the children of the platform device and delete them. Thus, causing crashes during module unload. We should be using the indio_dev->dev structure for registering/unregistering child nodes. Signed-off-b

Re: [PATCH 0/5] ARM: dts: enable display for peach-pit and snow boards

2014-04-25 Thread Arun Kumar K
Hi, Tested this whole series on peach-pit board. Tested-by : Arun Kumar K On Sun, Apr 20, 2014 at 5:18 PM, Rahul Sharma wrote: > From: Rahul Sharma > > Add nodes for fimd and dp controller for exynos5250 based snow > and exynos5420 based peach-pit board. > > This series is based on Kukjin Kims

[PATCH 5/5] devfreq: exynos5: Use devm_devfreq_* function using device resource management

2014-04-25 Thread Chanwoo Choi
This patch uses devm_devfreq_add_device()/devm_devfreq_register_opp_notifier() to control automatically the resource of devfreq. Signed-off-by: Chanwoo Choi Cc: Kukjin Kim Cc: Sachin Kamat Cc: Bartlomiej Zolnierkiewicz Cc: Manish Badarkhe Cc: Abhilash Kesavan Cc: linux-arm-ker...@lists.infra

[PATCH 4/5] devfreq: exynos4: Use devm_devfreq_* function using device resource management

2014-04-25 Thread Chanwoo Choi
This patch uses devm_devfreq_add_device()/devm_devfreq_register_opp_notifier() to control automatically the resource of devfreq. Signed-off-by: Chanwoo Choi Cc: Kukjin Kim Cc: Bartlomiej Zolnierkiewicz Cc: Wei Yongjun Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.o

Re: [PATCHv2 0/4] Enable usbphy and hsotg for exynos4

2014-04-25 Thread Tomasz Figa
Hi Chanho, On 25.04.2014 08:59, Chanho Park wrote: > This patchset enables a exynos4 usbphy and hsotg DT node for exynos4. The usb > phy node uses generic exynos phy driver. The driver uses PMU syscon and SYSREG > syscon phandles. > > Changes from v1: Applied Tomasz Figa's comments > - Document

Re: [PATCH 1/4] ARM: dts: exynos4: add PMU syscon node

2014-04-25 Thread Vikas Sajjan
Hi, On Thu, Apr 24, 2014 at 9:37 PM, Tomasz Figa wrote: > Hi Chanho, > > > On 14.04.2014 14:48, Chanho Park wrote: >> >> This patch adds a PMU(Power Management Unit) syscon node. This >> should be required for USB Phy syscon regmap I/F. >> >> Cc: Tomasz Figa >> Cc: Kamil Debski >> Signed-off-b

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-25 Thread Vivek Gautam
Hi, On Fri, Apr 25, 2014 at 1:27 PM, Tushar Behera wrote: > On 04/14/2014 08:07 PM, Sylwester Nawrocki wrote: >> On 08/04/14 16:36, Vivek Gautam wrote: >>> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt >>> b/Documentation/devicetree/bindings/phy/samsung-phy.txt >>> index 28

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-25 Thread Tushar Behera
On 04/14/2014 08:07 PM, Sylwester Nawrocki wrote: > On 08/04/14 16:36, Vivek Gautam wrote: >> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt >> b/Documentation/devicetree/bindings/phy/samsung-phy.txt >> index 28f9edb..6d99ba9 100644 >> --- a/Documentation/devicetree/bindings/ph

Re: [PATCH] Exynos4: cpuidle: support dual CPUs with AFTR state

2014-04-25 Thread Daniel Lezcano
On 04/24/2014 07:42 PM, Tomasz Figa wrote: Hi Daniel, Please see my comments inline. Hi Tomasz, Btw. Please fix your e-mail composer to properly wrap your messages around 7xth column, as otherwise they're hard to read. Well it is already set to the 71th column. On 04.04.2014 11:48, Danie

[PATCHv2 2/4] ARM: dts: exynos4: add exynos_usbphy node

2014-04-25 Thread Chanho Park
This patch enables a exynos_usbphy node for exynos4 SoCs. A exynos4x12 usb phy node is almost same with 4210's one except compatible string and pmu syscon. Cc: Tomasz Figa Cc: Kamil Debski Signed-off-by: Chanho Park --- arch/arm/boot/dts/exynos4.dtsi| 10 ++ arch/arm/boot/dts/exyno

[PATCHv2 1/4] ARM: dts: exynos4: add PMU syscon node

2014-04-25 Thread Chanho Park
This patch adds a PMU(Power Management Unit) syscon node. This should be required for USB Phy syscon regmap I/F. Cc: Kamil Debski Signed-off-by: Chanho Park Reviewed-by: Tomasz Figa --- Documentation/devicetree/bindings/arm/samsung/pmu.txt | 2 ++ arch/arm/boot/dts/exynos4.dtsi

[PATCHv2 4/4] ARM: dts: exynos4412-trats2: enable usb nodes

2014-04-25 Thread Chanho Park
This patch enables exynos_usbphy and hsotg device nodes. Cc: Tomasz Figa Cc: Kamil Debski Cc: Marek Szyprowski Signed-off-by: Chanho Park --- arch/arm/boot/dts/exynos4412-trats2.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch

[PATCHv2 3/4] ARM: dts: exynos4: add hsotg device node

2014-04-25 Thread Chanho Park
This patch adds a hsotg node for exynos4 USB2.0 device controller. Cc: Tomasz Figa Cc: Kamil Debski Cc: Marek Szyprowski Signed-off-by: Chanho Park --- arch/arm/boot/dts/exynos4.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boo

[PATCHv2 0/4] Enable usbphy and hsotg for exynos4

2014-04-25 Thread Chanho Park
This patchset enables a exynos4 usbphy and hsotg DT node for exynos4. The usb phy node uses generic exynos phy driver. The driver uses PMU syscon and SYSREG syscon phandles. Changes from v1: Applied Tomasz Figa's comments - Document PMU syscon compatibles for exynos4210/4x12 - Use clock macro in

  1   2   >