On Fri, 2015-06-26 at 09:14 +, Amit Khatri wrote:
Hi Johannes,
Subject: [PATCH 4/4] iw:In case of memory allocation failure by
nlmsg_alloc()
cqm will pass to NLA_PUT_U32. it should not happen.
Same here - use a single-line subject such as
iw: check nlmsg_allocation()
and put more
On Fri, 2015-06-26 at 09:12 +, Amit Khatri wrote:
Hi Johannes,
Subject: [PATCH 3/4] iw: Static analyser report that attr may be NULL
so
either we can remove condition check statement or add goto at end of
this
function.
That's far far too much for the subject.
Please submit
On Thu, 2015-07-30 at 14:35 -0700, Filipe Brandenburger wrote:
Hi,
I'm working on including iw on Android AOSP eng builds and it turns
out we
need some fixes to Android.mk to make it build on a current AOSP
tree.
We have a very similar patch internally as well (that I was still
On Wed, 2015-08-05 at 15:38 +0200, Bertold Van den Bergh wrote:
The current implementation in ocb.c can cause a kernel oops when the
interface is up, but no ocb has been joined. When data is received
with the broadcast BSSID rx_no_sta is called. This function uses
uninitialized variables
On Thu, 2015-07-30 at 14:14 +0200, Felix Fietkau wrote:
This ensures that mac80211 generated management frames and beacons
are aligned before being passed to the driver
I'm not convinced this is appropriate. Drivers may or may not require
alignment, so I don't really see why we should in
On Fri, 2015-06-26 at 09:10 +, Amit Khatri wrote:
Hi Johannes,
Subject: [PATCH 2/4] iw: Avoid possible memory leak for cb. cb got
memory from
nl_cb_alloc() but not doing free
Please fix your submission process to not mangle patches. I've applied
patch 1 in this series and fixed it up
From: Johannes Berg johannes.b...@intel.com
Having the EWMA parameters stored in the runtime struct imposes
memory requirements for the constant values that could just be
inlined in the code. This particularly makes sense if there are
a lot of such structs, for example in mac80211 in the station
From: Johannes Berg johannes.b...@intel.com
According to firmware engineers, the firmware has never required
these fields and the values have always been calculated, they were
just leftovers from a previous implementation.
Therefore remove the unnecessary calculation.
Reviewed-by: Emmanuel
On Fri, 2015-07-17 at 15:43 +0200, Johannes Berg wrote:
On Wed, 2015-07-08 at 15:41 +0300, Emmanuel Grumbach wrote:
From: Johannes Berg johannes.b...@intel.com
The iwlwifi driver was the only driver that used this, but as
it turns out it never needed it, so we can remove it.
I'm not
Michal Kazior michal.kaz...@tieto.com writes:
If firmware did not have any feature flags set the
var would be left with values found on the stack
(i.e. garbage) yielding print string like this:
(...) features \xffa6m:^R\xfffbԂ\xffc4^E
Fixes: b27bc5a40f91 (ath10k: dump fw
Raja Mani rm...@qti.qualcomm.com writes:
Existing phyerr event handlers directly uses phyerr header format
(ie, struct wmi_phyerr and struct wmi_phyerr_event) in the code
exactly on how firmware packs it. This is the problem in 10.4 fw
specific phyerr event handling where it uses different
Vivek Natarajan natar...@qti.qualcomm.com writes:
qca61x4 uses the vdev param as a sole sufficient configuration
for txbf while qca99x0 enables txbf during peer assoc by
combining the vdev param value with peer assoc's vht capabilities
This patch gets the appropriate txbf configuration
Michal Kazior michal.kaz...@tieto.com writes:
Commit 1010ba4c5d1c (ath10k: unregister and
remove frag_threshold callback) didn't remove all
instances of (futile) fragmentation threshold
configuration. No known firmware supports the
parameter so don't even bother setting it.
Signed-off-by:
value of attr may be NULL so check before passing
to function.
Signed-off-by: Amit Khatri amit.kha...@samsung.com
Signed-off-by: Rahul Jain rahul.j...@samsung.com
---
event.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/event.c b/event.c
index 5fb5afc..5d0bfde 100644
Hi,
I just pushed the first qca6174 hw2.1 firmware to ath10k-firmware.git:
https://github.com/kvalo/ath10k-firmware/commit/7f7e7dda33676ced293de477b03711199ffe5256
Please test and provide feedback.
--
Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
Michal Kazior michal.kaz...@tieto.com writes:
When WoWLAN resume fails with retval 1 mac80211
will attempt to reconfig the device in a similar
manner when hw restart is requested. This wasn't
handled properly and yielded call trace warnings
and the device ended up not working.
In case of memory allocation failure by nlmsg_alloc() cqm will pass to
NLA_PUT_U32.
it should not happen
Signed-off-by: Amit Khatri amit.kha...@samsung.com
Signed-off-by: Rahul Jain rahul.j...@samsung.com
---
cqm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/cqm.c b/cqm.c
index
cb got memory from nl_cb_alloc() but not doing free
during error case and use same lable to go out from function.
Signed-off-by: Amit Khatri amit.kha...@samsung.com
Signed-off-by: Rahul Jain rahul.j...@samsung.com
---
iw.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
Michal Kazior michal.kaz...@tieto.com writes:
If peer creation failed during offchannel Tx the
driver attempted to delete the peer nonetheless.
This caused the ar-num_peers counter to be
incorrectly decremented. This subsequently could
cause the counter to drop below 0 and also
eventually
On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote:
+static const char *rfkill_types[NUM_RFKILL_TYPES] = {
+ [RFKILL_TYPE_WLAN] = wlan,
+ [RFKILL_TYPE_BLUETOOTH] = bluetooth,
+ [RFKILL_TYPE_UWB] = ultrawideband,
+ [RFKILL_TYPE_WIMAX] = wimax,
+
On Mon, 2015-07-27 at 11:11 +0300, Dan Carpenter wrote:
The outside if statement checks that IEEE80211_TX_INTFL_MLME_CONN_TX
is
set so this condition is always true. Checking twice upsets the
static
checkers.
Yeah, this was left over in some refactoring - thanks, applied.
johannes
--
On Sun, Aug 2, 2015 at 8:00 PM, Hauke Mehrtens ha...@hauke-m.de wrote:
From: Linus Walleij linus.wall...@linaro.org
This switches the BCMA GPIO driver to use GPIOLIB_IRQCHIP to
handle its interrupts instead of rolling its own copy of the
irqdomain handling etc.
Signed-off-by: Linus Walleij
Kalle Valo kv...@qca.qualcomm.com writes:
Raja Mani rm...@qti.qualcomm.com writes:
Existing phyerr event handlers directly uses phyerr header format
(ie, struct wmi_phyerr and struct wmi_phyerr_event) in the code
exactly on how firmware packs it. This is the problem in 10.4 fw
specific
Return type of wait_for_completion_timeout is unsigned long not int.
As time_left is exclusively used for wait_for_completion_timeout here its
type is simply changed to unsigned long.
API conformance testing for completions with coccinelle spatches are being
used to locate API usage
Commit e996db69833a (rtlwifi: rtl8192c: Add init codes for fw_version
and fw_subversion) added initialization for fw_version, but failed to
note that the variable in the firmware header is little-endian. The
following Sparse warning results:
CHECK
This adds additional 0x0041 PCI Device ID
definition to ath10k for QCA6164 which is a 1
spatial stream sibling of the QCA6174 (which is 2
spatial stream chip).
The QCA6164 needs a dedicated board.bin file which
is different than the one used for QCA6174. If the
board.bin is wrong the device will
Hi,
On Thu, Aug 13, 2015 at 11:27:46AM +0200, Johannes Berg wrote:
On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote:
+static const char *rfkill_types[NUM_RFKILL_TYPES] = {
+ [RFKILL_TYPE_WLAN] = wlan,
+ [RFKILL_TYPE_BLUETOOTH] = bluetooth,
+ [RFKILL_TYPE_UWB]
On Thu, 2015-07-30 at 08:55 +0300, Emmanuel Grumbach wrote:
On Thu, Jul 30, 2015 at 8:18 AM, Fu, Zhonghui
zhonghui...@linux.intel.com wrote:
Enable wiphy device to suspend/resume asynchronously. This can
improve
system suspend/resume speed.
How will that impact the timing with
On Tue, 2015-07-28 at 10:30 +0200, Adrien Schildknecht wrote:
At the last iteration of the loop, j may equal zero and thus
tp_list[j - 1] causes an invalid read.
Changed the logic of the loop so that j - 1 is always = 0.
Signed-off-by: Adrien Schildknecht adrien+...@schischi.me
Applied, I
From: Zhaoyang Liu li...@marvell.com
This patch adds support for 8997 chipset to mwifiex
with SDIO/PCIe/USB interface.
The corresponding firmware image files are located in:
mrvl/sd8997_uapsta.bin
mrvl/pcie8997_uapsta.bin
mrvl/usb8997_uapsta.bin
Signed-off-by: Zhaoyang Liu
On Fri, 2015-07-17 at 15:28 +0200, Matthias May wrote:
The goal of this patch is to improve regd handling of quarter and
half rates.
The original assumption of 20MHz wide channels is with the
introduction of
quarter and half rates no longer true.
With this patch we no longer disable all
On Wed, 2015-08-05 at 16:02 +0200, Bertold Van den Bergh wrote:
Create a new STA when requested to unicast a frame to an unknown
station.
This is needed to make ratecontrol work in the case where data is
sent
from sta A to B and sta B never replies. Currently, sta B will stay
unknown
to
On Wed, 2015-08-05 at 16:02 +0200, Bertold Van den Bergh wrote:
To make mac80211 accept the multicast rate requested by the user the
rate control should be told that it is operating in BSS mode.
Without this, the default rate is selected in rate_control_send_low
(!pubsta and !txrc-bss)
Return type of wait_for_completion_timeout is unsigned long not int.
As time_left is exclusively used for wait_for_completion_timeout here its
type is simply changed to unsigned long.
API conformance testing for completions with coccinelle spatches are being
used to locate API usage
This patch doesn't look correct - in the case that 'cb' fails to
allocate, the existing code is actually correct. In the case that s_cb
fails to allocate, it's clearly incorrect, but that means the two
conditions need to be disentangled, no?
Also, I've applied the other two patches despite them
There's already a generic implementation so use that instead.
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Fri, 2015-08-07 at 16:54 +0800, Su Kang Yin wrote:
During hwsim_init_netlink(), we should call genl_unregister_family()
if failed on netlink_register_notifier() since the genetlink is
already registered.
Applied.
johannes
--
To unsubscribe from this list: send the line unsubscribe
On Wed, 2015-08-05 at 16:02 +0200, Bertold Van den Bergh wrote:
Perform the BSS_CHANGED_BSSID action when joining an OCB network.
This is required to set the broadcast BSSID in some network drivers.
Also applied 4 and 5.
johannes
--
To unsubscribe from this list: send the line unsubscribe
Return type of wait_for_completion_timeout is unsigned long not int.
As time_left is exclusively used for wait_for_completion_timeout here its
type is simply changed to unsigned long.
API conformance testing for completions with coccinelle spatches are being
used to locate API usage
Return type of wait_for_completion_timeout is unsigned long not int.
As time_left is exclusively used for wait_for_completion_timeout here its
type is simply changed to unsigned long.
API conformance testing for completions with coccinelle spatches are being
used to locate API usage
On Tue, Aug 11, 2015 at 03:29:55PM +0200, Xose Vazquez Perez wrote:
Resolución 127, 2011 - Reglamento Banda 2,4 GHz.:
http://www.mincom.gob.cu/sites/default/files/marcoregulatorio/R%20127-11%20Reglamento%20banda%202,4%20GHz.pdf
Cc: Seth Forshee seth.fors...@canonical.com
Cc:
Header format of 10.4 firmware phyerr event is not alligned
with pre 10.4 firmware. Introduce new wmi handlers to parse
10.4 firmware specific phyerror event header.
With changes covered in this patch, radar detection works on
qca9x0 hw 2.0 which uses 10.4 firmware.
Signed-off-by: Raja Mani
On Thu, Aug 13, 2015 at 01:41:23PM +0900, Tony Cho wrote:
+static u32 get_id_from_handler(tstrWILC_WFIDrv *handler)
+{
+ u32 id;
+
+ if (!handler)
+ return 0;
+
+ for (id = 0; id NUM_CONCURRENT_IFC; id++) {
+ if (wfidrv_list[id] == handler) {
+
On 13 August 2015 at 19:17, Hans de Goede hdego...@redhat.com wrote:
I'm trying to help a Fedora user to get his wifi to work on a
Lenovo Yoga 3 14, ad currently we are stuck with the
b43 driving giving the error from $subject,
is there anyone who can help with this ?
Well, the $subject says
Hi Johannes,
On Thu, Aug 13, 2015 at 2:01 AM, Johannes Berg
johan...@sipsolutions.net wrote:
We have a very similar patch internally as well (that I was still
evualating/reviewing) but it was less complete, so I've applied this
despite Arik's objections.
Thank you!
I think that if anyone
On Thu, 2015-08-13 at 09:55 -0700, Filipe Brandenburger wrote:
Long term, considering this is in AOSP and is part of eng/userdebug
builds, it's likely to be automatically available in future versions
of Android.
Yeah, but most vendors don't actually build/run/ship AOSP nor
necessarily an
From: Oleksij Rempel external.oleksij.rem...@de.bosch.com
current code will handle -ETIMEDOUT as success which is probalbly wrong.
According to this comment I assume it is safe to handle -ETIMEDOUT as false:
drivers/net/wireless/ath/ath9k/calib.c
290 /*
291 * We timed out
I'd like to be able to set the channel information on a per-packet
basis during monitor-mode injection. Specifically, I would like to be
able to change the channel bandwidth down to half and quarter rates
(my PHY supports this) based on the radiotap header information.
Additionally, if its
From: Linus Walleij linus.wall...@linaro.org
This switches the BCMA GPIO driver to use GPIOLIB_IRQCHIP to
handle its interrupts instead of rolling its own copy of the
irqdomain handling etc.
Signed-off-by: Linus Walleij linus.wall...@linaro.org
Signed-off-by: Hauke Mehrtens ha...@hauke-m.de
---
From: Johannes Berg johan...@sipsolutions.net
Date: Thu, 13 Aug 2015 11:11:48 +0200
From: Johannes Berg johannes.b...@intel.com
Having the EWMA parameters stored in the runtime struct imposes
memory requirements for the constant values that could just be
inlined in the code. This
Both loops of this function compare data from the 'chan' array and then
check if the index is valid.
The 2 conditions should be inverted to avoid an out-of-bounds access.
Signed-off-by: Adrien Schildknecht adrien+...@schischi.me
---
drivers/net/wireless/iwlwifi/iwl-eeprom-parse.c | 4 ++--
1
On 08/13/2015 01:35 PM, s prasad wrote:
Hi Ben,
did you get a chance to look into this issue(injecting frames when
device in monitor mode).
Injection works in a limited fashion in my latest firmware.
I'd like to figure out how to pass rate-ctrl (and other info?) down to the
firmware on a
On Wed, Aug 12, 2015 at 11:05:58PM +0530, Chandra S Gorentla wrote:
- if (copy_from_user(buffer, buf, count)) {
+ ret = simple_write_to_buffer(buffer, sizeof(buffer), ppos, buf, count);
This part doesn't make sense. Use copy_from_user(). Also it's not NUL
terminated so it leads to a
Hi,
On 08/14/2015 03:36 AM, Adrien Schildknecht wrote:
Both loops of this function compare data from the 'chan' array and then
check if the index is valid.
The 2 conditions should be inverted to avoid an out-of-bounds access.
Was that found by a static analyzer or any other automated
current code will handle -ETIMEDOUT as success which is probalbly wrong.
According to this comment I assume it is safe to handle -ETIMEDOUT as false:
drivers/net/wireless/ath/ath9k/calib.c
290 /*
291 * We timed out waiting for the noisefloor to load, probably due to
an
292
Opps wrong email address. I'll resend the patch
Am 13.08.2015 um 20:21 schrieb Oleksij Rempel:
From: Oleksij Rempel external.oleksij.rem...@de.bosch.com
current code will handle -ETIMEDOUT as success which is probalbly wrong.
According to this comment I assume it is safe to handle
Current kernel support only one fw name with theoretically only one
fw version located in “firmware/htc_[9271|7010].fw”. Which is ok so far we have
only one fw version (1.3). After we realised new fw 1.4, we faced compatibility
problem which was decided to solve by firmware name and location:
-
On Thu, 2015-08-13 at 12:48 -0700, enh wrote:
i think you misunderstand what AOSP is. this code is currently in
AOSP master, and thus in internal master, and thus in a future
release.
Great, but as I understand it, vendors are under no obligation to
actually ship that code on their
On Thu, 2015-08-13 at 13:44 -0700, enh wrote:
but given that our iw is your iw anyway... i don't understand the
situation in which they'd be inconvenienced here?
But it's not. We can reasonably expect everyone who actually cares to
have local modifications to iw that they aren't publishing
Thank you Ben for immediate response,
Don't mind, could you please share your firmware path.
Sorry I didn't change old subject line.
Thanks Regards,
S Prasad
On Aug 13, 2015, at 4:43 PM, Ben Greear gree...@candelatech.com wrote:
On 08/13/2015 01:35 PM, s prasad wrote:
Hi Ben,
did you
WMI 10.4 uses the same command interface as QCA988X for addba/delba
debug wmi commands. Fill wmi_10_4_ops table with the functions used
for QCA988X for these commands.
With this change, the following debugfs entries can be used to
configure the aggregation mode and to send addba request,
addba
61 matches
Mail list logo
