Re: [Linuxwacom-devel] [PATCH 2/5] Support crop mark LEDs

2014-04-06 Thread Chris Bagwell
On Fri, Mar 28, 2014 at 11:37 AM, Paul A. Tessier wrote: > From: "Paul A. Tessier" > > adds sysfs attribute wacom_led/crop_marks_luminance > adds support for crop marks in led control message > adds script to exercise LEDs > > Signed-off-by: Paul A. Tessier > --- > 3.7/wacom.h | 1 + > 3.7

Re: [Linuxwacom-devel] [PATCH v2 5/5] Export wireless tablet's device match info to sysfs

2014-04-06 Thread Chris Bagwell
On Fri, Mar 28, 2014 at 2:20 PM, Paul A. Tessier wrote: > From: "Paul A. Tessier" > > adds new sysfs ro attribute dev_match to wireless interfaces > > This will be need by libwacom to know which actual tablet is connected > to the wireless kit > > Changes since v1: > - fixed bad attribute permis

Re: [Linuxwacom-devel] [PATCH 3/5] Support LEDs with wireless kit

2014-04-05 Thread Chris Bagwell
Hi Paul. First up, welcome to the Wacom project. Your patches have looked great. I'm hoping we can all help assist you in getting this in both Linux kernel as well as input-wacom. I've had this patch series sitting in my inbox for a long time trying to find time to test the patches out. I hav

Re: [Linuxwacom-devel] [PATCH] Add an option to disable pressure recalibration

2014-02-14 Thread Chris Bagwell
On Fri, Feb 14, 2014 at 4:07 AM, Egbert Eich wrote: > Jason Gerecke writes: > > On Thu, Feb 13, 2014 at 2:10 PM, Peter Hutterer > > wrote: > > > On Wed, Feb 12, 2014 at 08:04:07PM +0100, Egbert Eich wrote: > > >> From: Egbert Eich > > >> > > >> If the initial pressure of a device is != 0 t

Re: [Linuxwacom-devel] [input-wacom PATCH 01/10] Scan all children connected to the parent hub

2013-09-29 Thread Chris Bagwell
Chris Bagwell Chris On Fri, Sep 27, 2013 at 1:32 PM, Jason Gerecke wrote: > On Fri, Sep 27, 2013 at 10:35 AM, Chris Bagwell > wrote: > > Hi Jason, > > > > I'd be happy to review these patches if you want it but can you give a > > little more context for th

Re: [Linuxwacom-devel] [input-wacom PATCH 01/10] Scan all children connected to the parent hub

2013-09-27 Thread Chris Bagwell
Hi Jason, I'd be happy to review these patches if you want it but can you give a little more context for the series on them? For example, a version of this patch seems to be in linux kernel but uses usb_hub_for_each_child(). Can patch be aligned with linux? Are other patches in linux kernel as

Re: [Linuxwacom-devel] Supporting Wacom pen tablet model CTL-471

2013-08-14 Thread Chris Bagwell
On Wed, Aug 14, 2013 at 12:05 PM, Arjuna Rao Chavala wrote: > Hi, > > I recently purchased CTL-471/K Wacom Pen Tablet (Bamboo One) (Sl.No > 3CFP002700). The active area size is 152*94 mm (6*3.7in) and the tablet has > stylus with rocker switch. The device is identified as with lsusb > Bus 003 Devi

Re: [Linuxwacom-devel] [PATCH 1/2] Update MAX_CHANNELS definition

2013-02-28 Thread Chris Bagwell
On Tue, Feb 26, 2013 at 3:07 PM, Ping Cheng wrote: > Make room to report pen and touch events simultaneously > > Signed-off-by: Ping Cheng > --- > src/xf86WacomDefs.h |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/xf86WacomDefs.h b/src/xf86WacomDefs.h > in

Re: [Linuxwacom-devel] [PATCH 2/2] Clean up device_type initialization for tool on tablet

2013-02-28 Thread Chris Bagwell
dled that case. So I'll at least give: Acked-by: Chris Bagwell > --- > src/wcmUSB.c | 72 > -- > 1 file changed, 5 insertions(+), 67 deletions(-) > > diff --git a/src/wcmUSB.c b/src/wcmUSB.c > index 75caa6b..980dac3

Re: [Linuxwacom-devel] Improve support for Bamboo Fun CTH-661/L

2013-01-24 Thread Chris Bagwell
On Wed, Jan 23, 2013 at 8:08 AM, Pander wrote: > Hi all, > > I would like to improve the support for Bamboo Fun CTH-661-SE-NL which > is also known as CTH-661/L with USB ID 056a:00db. It is a special > edition and the NL in the name stands for Netherlands. > > An image and English specifications c

Re: [Linuxwacom-devel] finger lag on Wacom ISDv4 E6

2013-01-13 Thread Chris Bagwell
My guess is your at close to the expected rate; based on those numbers. 100 Hz, 133 Hz, and 200 Hz are some common sample rates used by digitizers. If I recall correctly, Microsoft established 133 Hz as minimum. The alternating 8/12ms is throwing me so I'm not sure if your HW is trying for 100 Hz

Re: [Linuxwacom-devel] [PATCH 1/4 v2] Remove channel duplication code for generic devices

2012-12-17 Thread Chris Bagwell
> > On Sun, Dec 16, 2012 at 2:56 PM, Chris Bagwell wrote: > >> >> On Thu, Dec 13, 2012 at 2:16 PM, Ping Cheng wrote: >> >>> We use true MT protocol for MT devices in kernel now. This code >>> was introduced to deal with ABS_TOOL_*TAP events loss issue

Re: [Linuxwacom-devel] [PATCH 3/4 v2] Send generic PAD events before other events

2012-12-17 Thread Chris Bagwell
On Sun, Dec 16, 2012 at 11:35 PM, Ping Cheng wrote: > On Sunday, December 16, 2012, Ping Cheng wrote: > >> On Sunday, December 16, 2012, Chris Bagwell wrote: >> >>> >>> On Sun, Dec 16, 2012 at 7:17 PM, Ping Cheng wrote: >>> >>>

Re: [Linuxwacom-devel] [PATCH 3/4 v2] Send generic PAD events before other events

2012-12-16 Thread Chris Bagwell
On Sun, Dec 16, 2012 at 7:17 PM, Ping Cheng wrote: > On Sun, Dec 16, 2012 at 1:40 PM, Chris Bagwell wrote: > >> >> >> >> On Thu, Dec 13, 2012 at 2:18 PM, Ping Cheng wrote: >> >>> If we wait until we finish other verifications, we could miss >&g

Re: [Linuxwacom-devel] [PATCH 1/4 v2] Remove channel duplication code for generic devices

2012-12-16 Thread Chris Bagwell
On Thu, Dec 13, 2012 at 2:16 PM, Ping Cheng wrote: > We use true MT protocol for MT devices in kernel now. This code > was introduced to deal with ABS_TOOL_*TAP events loss issue. It > is uncessary any more. And its existence makes it hard to support > generic PAD cleanly. > > I can't think of an

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-16 Thread Chris Bagwell
I haven't been able to contribute much to the project. I'll send some comments to the patches separately. Chris > > Ping > > On Fri, Dec 14, 2012 at 2:58 PM, Chris Bagwell wrote: > >> >> On Thu, Dec 13, 2012 at 9:37 PM, Peter Hutterer > > wrote: >>

Re: [Linuxwacom-devel] [PATCH 3/4 v2] Send generic PAD events before other events

2012-12-16 Thread Chris Bagwell
On Thu, Dec 13, 2012 at 2:18 PM, Ping Cheng wrote: > If we wait until we finish other verifications, we could miss > PAD events since they will be filtered out when there are no > motion events sent simultaneously. > > Signed-off-by: Ping Cheng > Acked-by: Jason Gerecke > --- > src/wcmUSB.c

Re: [Linuxwacom-devel] [PATCH 4/4 v2] BTN_TOOL_FINGER is not for PAD if MT is supported

2012-12-16 Thread Chris Bagwell
ith MT. If this is true then probably all the checks for WCM_PROTOCOL_GENERIC in wcmUSB.c need to be reviewed. Reviewed-by: Chris Bagwell --- > src/wcmUSB.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/src/wcmUSB.c b/src/wcmUSB.c > in

Re: [Linuxwacom-devel] [PATCH 2/4 v2] Initialize wcmBTNChannel in usbWcmInitPadState()

2012-12-16 Thread Chris Bagwell
On Thu, Dec 13, 2012 at 2:18 PM, Ping Cheng wrote: > wcmBTNChannel is only used by generic PAD device. > And it is statically assigned to PAD_CHANNEL. No > need to reassign it for every packet. > > Signed-off-by: Ping Cheng > Acked-by: Jason Gerecke > Revie

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-14 Thread Chris Bagwell
On Thu, Dec 13, 2012 at 9:37 PM, Peter Hutterer wrote: > On Wed, Dec 12, 2012 at 11:08:17AM -0800, Ping Cheng wrote: > > On Wed, Dec 12, 2012 at 10:54 AM, Jason Gerecke >wrote: > > > > > It certainly doesn't hurt :) I think my biggest problem is that I never > > > really understood exactly when t

Re: [Linuxwacom-devel] [PATCH libwacom] Drop AM_MAINTAINER_MODE

2012-10-15 Thread Chris Bagwell
le that muck with configure.ac scripts already know you need to run autoreconf after modifying it and the Makefile will now have working rules to rerun configure after modifying Makefile.am. Reviewed-by: Chris Bagwell > --- > configure.ac | 1 - > 1 file changed, 1 deletion(-) >

Re: [Linuxwacom-devel] [PATCH 0/9] Multitouch support patches

2012-10-02 Thread Chris Bagwell
roduce problems for tablets > that don't have touch, and I'd appreciate any Tested-By tags I can > get (especially on Protocol 4 [Bamboo] and Generic Protocol devices). > If my line-by-line review does come before much longer, feel free to take this and commit: Tested-by: Chris

Re: [Linuxwacom-devel] [RFC PATCH 9/9]: Always allow single finger gestures

2012-10-02 Thread Chris Bagwell
going to work and I thought there was reasonable chance it would require us to stop sending all button presses. I think this patch is good idea and if issue arise we can add a touchscreen specific touch disable property. Acked-by: Chris Bagwell > > man/wacom.man| 6 +++--- &g

Re: [Linuxwacom-devel] [PATCH 0/9] Multitouch support patches

2012-09-30 Thread Chris Bagwell
On Sat, Sep 29, 2012 at 6:58 PM, Jason Gerecke wrote: > This set of patches adds multitouch support to the driver. The new > API made available in XI2.2 is used to report the location of all > contacts, allowing applications to work with the touch points themselves. > This is added as a new gestur

Re: [Linuxwacom-devel] [PATCH] Input: wacom - Mark Intuos5 pad as in-prox when touching buttons

2012-09-22 Thread Chris Bagwell
ics, we make being touched a sufficient condition to > signal proximity. Seems like easiest solution to prevent invalid event sequencies. Reviewed-by: Chris Bagwell > > https://bugs.freedesktop.org/show_bug.cgi?id=54250 > > Reported-by: Timo Aaltonen > Signed-off-by: Jason G

Re: [Linuxwacom-devel] [PATCH] Pre-allocate the tap timer

2012-08-26 Thread Chris Bagwell
On Wed, Aug 22, 2012 at 8:06 PM, Peter Hutterer wrote: > wcmSingleFingerTap() is called during SIGIO, calling TimerSet(NULL, ...) > will malloc inside the signal handler and hang the box. > > Signed-off-by: Peter Hutterer I haven't seen the lockup but makes sense. Acked-

Re: [Linuxwacom-devel] [PATCH 3/3] release.sh: support other modules (i.e. libwacom and input-wacom)

2012-07-09 Thread Chris Bagwell
on my other comment. For the series: Reviewed-by: Chris Bagwell Chris > --- > release.sh | 24 ++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/release.sh b/release.sh > index 2d6f1d4..4a403a7 100755 > --- a/release.sh &g

Re: [Linuxwacom-devel] [PATCH input-wacom] configure.ac: disable tar.gz tarballs, bz2 is enough

2012-07-09 Thread Chris Bagwell
On Mon, Jul 9, 2012 at 7:05 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > configure.ac |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I also put a release.sh in input-wacom. Its a copy of the xf86-input-wacom one and uploaded both versions. So before next RC or

Re: [Linuxwacom-devel] [PATCH] Don't init the rotation property on the pad

2012-07-04 Thread Chris Bagwell
On Thu, Jun 28, 2012 at 8:19 PM, Peter Hutterer wrote: > Rotation doesn't do a lot on a device without usable axes > > Signed-off-by: Peter Hutterer Acked-by: Chris Bagwell > --- >  src/wcmXCommand.c |    4 +++- >  1 file changed, 3 insertions(+), 1 deletion(

Re: [Linuxwacom-devel] [PATCH] Find mouse buttons on pad devices if no 'usual' buttons found

2012-06-18 Thread Chris Bagwell
isTouch() or isPad() was returned based on hotpug order). A tablet with zero padkey_codes and no MOUSE PUCK seems safe enough to always assume Mice buttons are really pad buttons; without worry about the isPad() part. > > Signed-off-by: Jason Gerecke Acked-by: Chris Bagwell Chris >

Re: [Linuxwacom-devel] EETI eGalax Touchscreen using an old kernel

2012-06-14 Thread Chris Bagwell
On Wed, Jun 13, 2012 at 4:50 AM, Go Oz wrote: > Hi Guys, > > I have a custom ARM9 board and trying to use EETI eGalax touchscreen with > it. Single touch is good enough for me. (Controller: > PCAP7200_DUAL_42X54_B_IC - EXC205442CBG) > I am using tslib (1.0-106-gf6c499a) and Qt 4.8.0. My kernel ver

Re: [Linuxwacom-devel] [PATCH libwacom 1/3] data: define button positions for Bamboos

2012-06-06 Thread Chris Bagwell
On Wed, Jun 6, 2012 at 11:30 AM, Jason Gerecke wrote: > On Wed, Jun 6, 2012 at 6:04 AM, Bastien Nocera wrote: >> On Tue, 2012-05-29 at 15:28 +1000, Peter Hutterer wrote: >>> On Tue, May 29, 2012 at 02:25:11PM +1000, Peter Hutterer wrote: >>> > Signed-off-by: Peter Hutterer >>> >>> yikes. after r

Re: [Linuxwacom-devel] [PATCH 01/14] Fix warning: Remove superflous casts in getScrollDelta

2012-05-26 Thread Chris Bagwell
the wrong warning here? In other patches, I do not know 100% that ""->NULL is OK but seems reasonable. For all in series: Reviewed-by: Chris Bagwell > > Signed-off-by: Jason Gerecke > --- >  src/wcmCommon.c |    6 +++--- >  1 file changed, 3 insertions(+), 3 deletions

Re: [Linuxwacom-devel] [PATCH] Re-enable relative wheel scrolling from pad devices

2012-05-26 Thread Chris Bagwell
Reviewed-by: Chris Bagwell On Fri, May 25, 2012 at 12:30 PM, Jason Gerecke wrote: > Commit 477a261e does not handle the case where relative wheel events > come from a pad device. The Graphire4 produces such events, with the > result that scrolling with one has been broken ever since. &

Re: [Linuxwacom-devel] [PATCH 1/1] Add support for the DTI-520

2012-05-17 Thread Chris Bagwell
On Thu, May 17, 2012 at 6:38 PM, Adam Nielsen wrote: >>> just wondering if the DTI-520 gives you serial numbers for the styli or if >>> this device uses generic serials. >> >> DTI-520 is a protocol 4 (V4) device. It does not support serial number >> and tool IDs. > > What does "protocol 4" refer t

Re: [Linuxwacom-devel] Waltop class?

2012-05-01 Thread Chris Bagwell
On Tue, May 1, 2012 at 7:56 AM, Nikolai Kondrashov wrote: > On 05/01/2012 03:44 PM, Nikolai Kondrashov wrote: > > I would very much like to have a single class for generic tablets > instead. > > They're all very similar and the evdev interface is capable of providing > all > > the required informa

Re: [Linuxwacom-devel] Bamboo wireless support on Ubuntu 12.04

2012-04-25 Thread Chris Bagwell
What kernel version does 12.04 use? The wireless support has been queued up for kernel 3.4 so once its released and put in 12.04, it will work. I hope to submit to input-wacom soon so people can follow instructions on wacom wiki to get working. Chris On Wed, Apr 25, 2012 at 1:21 AM, Thierry Mun

Re: [Linuxwacom-devel] [PATCH] Fix off-by-one error in xsetwacom's button handling

2012-04-03 Thread Chris Bagwell
Seems reasonable a zero based offset should check >= nitems value and aligns with similar check in get_actions(). Reviewed-by: Chris Bagwell On Tue, Apr 3, 2012 at 5:00 PM, Jason Gerecke wrote: > > Signed-off-by: Jason Gerecke > --- > tools/xsetwacom.c |2 +- >

Re: [Linuxwacom-devel] [PATCH input-wacom 1/2] backport: add support for Cintiq 24HD

2012-03-29 Thread Chris Bagwell
On Thu, Mar 29, 2012 at 10:36 AM, Jason Gerecke wrote: > On Thu, Mar 29, 2012 at 6:54 AM, Chris Bagwell wrote: >> On Wed, Mar 28, 2012 at 12:31 PM, Ping Cheng wrote: >>> On Wed, Mar 28, 2012 at 9:29 AM, Jason Gerecke wrote: >>>> Based on upstream commit 803296b678

Re: [Linuxwacom-devel] [PATCH input-wacom 1/2] backport: add support for Cintiq 24HD

2012-03-29 Thread Chris Bagwell
On Wed, Mar 28, 2012 at 12:31 PM, Ping Cheng wrote: > On Wed, Mar 28, 2012 at 9:29 AM, Jason Gerecke wrote: >> Based on upstream commit 803296b678a43005e3bc0aaa1951d211bd76a054 >> >> Signed-off-by: Jason Gerecke > > Acked-by: Ping Cheng for the set. > > Ping Are you going to commit patches you

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-03-29 Thread Chris Bagwell
On Thu, Mar 29, 2012 at 2:22 AM, Nikolai Kondrashov wrote: > Hi Chris, > > > On 03/23/2012 07:20 PM, Nikolai Kondrashov wrote: >> >> On 03/23/2012 07:00 PM, Chris Bagwell wrote: >>> >>> On Thu, Mar 22, 2012 at 2:37 PM, Nikolai Kondrashov >>> wrot

Re: [Linuxwacom-devel] [PATCH 1/1] Use kernel-reported tilt range and resolution

2012-03-23 Thread Chris Bagwell
On Thu, Mar 22, 2012 at 2:37 PM, Nikolai Kondrashov wrote: > Use tilt range and, optionally, resolution reported by the kernel for event > devices. > > Temporarily center the range on zero until kernel is fixed to do this. > > Use resolution, if present, to determine the physical range and clamp/e

Re: [Linuxwacom-devel] [PATCH 1/3] HID: wacom: Remove CONFIG_HID_WACOM_POWER_SUPPLY option

2012-03-19 Thread Chris Bagwell
support" > -       depends on HID_WACOM > -       select POWER_SUPPLY These depends and select lines need to move up to HID_WACOM. Other than that: Reviewed-by: Chris Bagwell > -       ---help--- > -         Say Y here if you want to enable power supply status monitoring for >

Re: [Linuxwacom-devel] [PATCH 3/3] HID: wacom: Add battery/ac reporting for Intuos4 WL

2012-03-19 Thread Chris Bagwell
Reviewed-by: Chris Bagwell On Mon, Mar 19, 2012 at 10:16 AM, Przemo Firszt wrote: > This patch adds battery/ac reporting for Intuos4 WL. It uses existing > sysfs code, but the device reports battery capacity in more fine-grained way, > so there has to be a separate lookup tabl

Re: [Linuxwacom-devel] [PATCH ver.2 1/2] HID: wacom: Refactor battery/ac reporting for Graphire

2012-03-18 Thread Chris Bagwell
ue reported by wacom graphire previously. Power supply state is now stored > in a separate variable - it used to be calculated on-the-fly in > wacom_ac_get_property function. The raw value has to be stored as well to be > able to determine if it has changed. > > Signed-off-by: Przemo

Re: [Linuxwacom-devel] [PATCH ver.2 2/2] HID: wacom: Add battery/ac reporting for Intuos4 WL

2012-03-18 Thread Chris Bagwell
On Sun, Mar 18, 2012 at 2:27 PM, Przemo Firszt wrote: > This patch adds battery/ac reporting for Intuos4 WL. It uses existing > sysfs code, but the device reports battery capacity in more fine-grained way, > so there has to be a separate lookup table (called batcap_i4). > > Signed-off-by: Przemo F

Re: [Linuxwacom-devel] [PATCH 2/2] HID: wacom: Add battery/ac reporting for Intuos4 WL

2012-03-18 Thread Chris Bagwell
On Sun, Mar 18, 2012 at 2:08 PM, Przemo Firszt wrote: > Dnia 2012-03-18, nie o godzinie 13:38 -0500, Chris Bagwell pisze: >> On Sun, Mar 18, 2012 at 11:24 AM, Przemo Firszt wrote: >> > This patch adds battery/ac reporting for Intuos4 WL. It uses existing >> > sysfs c

Re: [Linuxwacom-devel] [PATCH 2/2] HID: wacom: Add battery/ac reporting for Intuos4 WL

2012-03-18 Thread Chris Bagwell
On Sun, Mar 18, 2012 at 11:24 AM, Przemo Firszt wrote: > This patch adds battery/ac reporting for Intuos4 WL. It uses existing > sysfs code, but the device reports battery capacity in more fine-grained way, > so there has to be a separate lookup table (called batcap_i4). > > Signed-off-by: Przemo

Re: [Linuxwacom-devel] [PATCH 1/2] HID: wacom: Refactor battery/ac reporting for Graphire

2012-03-18 Thread Chris Bagwell
On Sun, Mar 18, 2012 at 11:24 AM, Przemo Firszt wrote: > This patch doesn't change the way battery/ac is reported, but the changes are > required to facilitate battery reporting for Intuos4 WL. > wdata->battery_capacity now stores actual battery capacity as opposed to raw > value reported by wacom

Re: [Linuxwacom-devel] [PATCH] input: wacom: Fix physical size calculation for 3rd-gen Bamboo

2012-03-12 Thread Chris Bagwell
t; code performs a multiplication. This doesn't pose a problem for the > 3rd-gen Bamboo since the resolution and scale factor happen to be > identical, but will produce an incorrect result for other cases. > > Signed-off-by: Jason Gerecke Reviewed-by: Chris Bagwell > --- >

Re: [Linuxwacom-devel] [PATCH v2 4/4] input: wacom: Intuos5 multitouch sensor support

2012-03-12 Thread Chris Bagwell
ues are used during setup. > > Signed-off-by: Jason Gerecke > --- > Changes from v1: >  * Fixed calculation of x_phy and y_phy (logic for the 3rd-gen Bamboo >   which I copied is incorrect! Patch on the way.) Thanks for catching. For patches 1, 2, and 4 in this series: Reviewed-by

Re: [Linuxwacom-devel] [PATCH] Add support for the Intuos5

2012-03-12 Thread Chris Bagwell
Reviewed-by: Chris Bagwell On Mon, Mar 12, 2012 at 5:22 PM, Jason Gerecke wrote: > > Signed-off-by: Jason Gerecke > --- >  src/wcmUSB.c            |    7 +++ >  src/wcmValidateDevice.c |    5 + >  2 files changed, 12 insertions(+), 0 deletions(-) > > diff --

Re: [Linuxwacom-devel] [PATCH] HID: wacom: Add reporting of wheel for Intuos4 WL

2012-03-09 Thread Chris Bagwell
On Fri, Mar 9, 2012 at 2:27 PM, Przemo Firszt wrote: > This patch adds reporting of ABS_WHEEL event. Raported walues are 0..71 > and are related to absolute location of the finger on the wheel. > > Signed-off-by: Przemo Firszt > Reviewed-by: Jason Gerecke > --- >  drivers/hid/hid-wacom.c |   25

Re: [Linuxwacom-devel] Tilt value meaning

2012-03-08 Thread Chris Bagwell
On Thu, Mar 8, 2012 at 12:06 PM, Jason Gerecke wrote: > On Thu, Mar 8, 2012 at 4:14 AM, Nikolai Kondrashov wrote: > >> Can you suggest a way to test the tilt with a real-world application, not >> just "xinput test" or "xev"? >> > > I usually use gimp for real-world testing, though I think you'll

Re: [Linuxwacom-devel] Tilt value meaning

2012-03-07 Thread Chris Bagwell
On Wed, Mar 7, 2012 at 2:18 PM, Nikolai Kondrashov wrote: > Hi everyone, > > Today I've started implementing a driver for Waltop Sirius Battery Free > tablet. As it turns out, it reports pen tilting, which is a rare thing for > non-Wacom tablets! > > Could someone please explain what ABS_TILT_X an

Re: [Linuxwacom-devel] [I4 WL] Pen buttons works, but not trigger right/middle button action.

2012-02-24 Thread Chris Bagwell
On Fri, Feb 24, 2012 at 9:38 AM, Przemo Firszt wrote: > Device Intuos4 WL on bluetooth, using hid-wacom.c driver. > For stylus: > > [  1945.611] (II) /dev/input/event8 (10:wcmEvent): c=0 i=1050626 t=1 > s=343955190 x=23562 y=8781 b=0 p=0 rz=0 tx=0 ty=0 aw=0 aw2=0 rw=0 > t=0 px=0 st=0 cs=4 > > chan

Re: [Linuxwacom-devel] [PATCH] HID: wacom: set ABS_MISC bit for Intuos4 WL

2012-02-24 Thread Chris Bagwell
On Fri, Feb 24, 2012 at 7:32 AM, Przemo Firszt wrote: > Dnia 2012-02-23, czw o godzinie 21:19 -0600, Chris Bagwell pisze: >> On Wed, Feb 22, 2012 at 3:21 PM, Przemo Firszt wrote: >> [..] > >>            __set_bit(ABS_MISC, input->absbit); >> >> So in your

Re: [Linuxwacom-devel] [PATCH] HID: wacom: set ABS_MISC bit for Intuos4 WL

2012-02-23 Thread Chris Bagwell
nyways so I guess its not worth looking into. For both patches: Reviewed-by: Chris Bagwell >                input_set_abs_params(input, ABS_X, 0, 40640, 4, 0); >                input_set_abs_params(input, ABS_Y, 0, 25400, 4, 0); >  

Re: [Linuxwacom-devel] Protocol for Intuos4 WL?

2012-02-23 Thread Chris Bagwell
On Wed, Feb 22, 2012 at 1:55 PM, Przemo Firszt wrote: > I'm trying to track down a probem with Intuos4 WL. Connected by USB > works OK: > [  3182.316] (II) /dev/input/event8 (10:wcmEvent): c=0 i=1050626 t=1c > s=343955190 x=18061 y=9959 b=0 p=0 rz=0 tx=28 ty=32 aw=0 aw2=0 rw=0 t=0 > px=1 st=0 cs=4

Re: [Linuxwacom-devel] [PATCH] Export current tool ID in the property too

2012-02-22 Thread Chris Bagwell
I believe I get it. I was thinking about advertising the old value change but this instead looks like it advertises missing device ID change which indirectly covers all the cases were old values need updating... and old values only get updated on demand. Reviewed-by: Chris Bagwell On Wed, Feb

Re: [Linuxwacom-devel] [PATCH] HID: wacom: fix proximity tool release

2012-02-21 Thread Chris Bagwell
Reviewed-by: Chris Bagwell On Sun, Feb 19, 2012 at 2:20 PM, Przemo Firszt wrote: > Don't zero the current tool before reporting its release to the input > subsystem. > > Signed-off-by: Aristeu Rozanski > Tested-by: Przemo Firszt > --- >  drivers/hid/hid-wacom.c |    

Re: [Linuxwacom-devel] Tool ID not updating

2012-02-20 Thread Chris Bagwell
On Mon, Feb 20, 2012 at 11:39 AM, Bastien Nocera wrote: > Heya, > > I'm having a bit of trouble with this code: > http://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/common/gsd-input-helper.c#n292 > > It's supposed to send the last used tool ID, except that it doesn't seem > to update w

Re: [Linuxwacom-devel] Issues with DTI-520

2012-02-19 Thread Chris Bagwell
On Sun, Feb 19, 2012 at 2:33 AM, Adam Nielsen wrote: > > So far everything works fine in evdev, but I am still having problems > getting the X driver to pick up the device. > > Currently the interface with the buttons works (the L and R buttons on the > tablet work as left and right mouse buttons)

Re: [Linuxwacom-devel] [PATCH] Extend length of wheel_actions array to 6

2012-02-18 Thread Chris Bagwell
vious. So maybe call it a #define for both arrays WCM_MAX_WHEEL_UP_DOWN? But it seems an obvious bug so if you need to submit ASAP: Reviewed-by: Chris Bagwell On Fri, Feb 17, 2012 at 11:21 AM, Jason Gerecke wrote: > This array was apparently overlooked when adding support for the > second

Re: [Linuxwacom-devel] Issues with DTI-520

2012-02-18 Thread Chris Bagwell
On Sat, Feb 18, 2012 at 7:32 PM, Adam Nielsen wrote: > Hi Chris, > > A couple more questions... > > >>> This worked quite well.  I do however get two identical devices appearing >>> (both tablets with buttons) rather than one tablet and one set of buttons >>> as >>> I think would be more logical.

Re: [Linuxwacom-devel] [PATCH] HID: wacom: Force new name for Wacom Intuos4 WL PTK-540WL

2012-02-18 Thread Chris Bagwell
re that it's > a Wacom device. > > Signed-off-by: Przemo Firszt > --- Its worth noting this aligns naming of device to same used when this device is plugged into USB port and controlled by USB wacom driver; and thus helps align userland logic to route to apps like xf86-input-wacom

Re: [Linuxwacom-devel] [PATCH] HID: wacom: Force Wacom PTK-540WL name for Intuos4 WL

2012-02-13 Thread Chris Bagwell
On Mon, Feb 13, 2012 at 3:20 PM, Przemo Firszt wrote: > The name reported by Inutos4 WL connected by bluetooth is "PTK-540WL" and > to make it consistent with other Wacom devices it has to be converted to > "Wacom PTK-540WL". It also makes userland applications aware that it's a Wacom > device. >

Re: [Linuxwacom-devel] [PATCH] HID: wacom: Force Wacom PTK-540WL name for Intuos4 WL

2012-02-13 Thread Chris Bagwell
On Mon, Feb 13, 2012 at 3:26 PM, Przemo Firszt wrote: > Please comment if you're OK with the name or it should be rather "Wacom > Intuos4 WL" or maybe something else. Here is what I thinking. You current code is geared that it can easily be reused for new versions of HW as long as the continue t

Re: [Linuxwacom-devel] Issues with DTI-520

2012-02-13 Thread Chris Bagwell
On Mon, Feb 13, 2012 at 4:26 AM, Adam Nielsen wrote: >>> Unfortunately once I reached this point the X driver stopped working.  It >>> detects the device but "xinput test" doesn't report any output.  I'm a bit >>> stumped at this because I haven't changed anything in the X driver and the >>> event

Re: [Linuxwacom-devel] Issues with DTI-520

2012-02-12 Thread Chris Bagwell
On Sun, Feb 12, 2012 at 5:53 AM, Adam Nielsen wrote: > Well, I seem to have had some success! > >> Yes, that is all I mean.  Based on your later info, it means there >> would be some code that looks like this: >> >> if (packet_size == 8&&  data[0] == 2) >>   // Do pen processing >> else if (packet

Re: [Linuxwacom-devel] Issues with DTI-520

2012-02-11 Thread Chris Bagwell
On Sat, Feb 11, 2012 at 8:42 PM, Adam Nielsen wrote: >> For the buttons, none of the wacom drivers currently support anything >> quite like this.  I see in the USB report that the device has 2 >> interfaces.  Normally, we only see this on touchscreens where the >> second interface reports touch ev

Re: [Linuxwacom-devel] Issues with DTI-520

2012-02-11 Thread Chris Bagwell
On Sat, Feb 11, 2012 at 6:23 PM, Adam Nielsen wrote: > Hi Chris, > > Thanks for the quick response! > > >> Hi, I googled this model and I see its a stand alone screen with built >> in Wacom digitizer. > > > Yes that's correct.  For the record, it also has a built in USB hub which > works fine: > >

Re: [Linuxwacom-devel] Intuos4 WL is handled by evdev - what's wrong?

2012-02-11 Thread Chris Bagwell
On Sat, Feb 11, 2012 at 7:52 AM, Peter Hutterer wrote: > On Sat, Feb 11, 2012 at 11:24:15AM +, Przemo Firszt wrote: >> Wacom4 WL on usb cable - "Wacom" is part of the name, but ID_VENDOR >> field contains "Tablet" 8-): >> >> P: /devices/pci:00/:00:1d.0/usb2/2-1/2-1:1.0/input/input10 >>

Re: [Linuxwacom-devel] Issues with DTI-520

2012-02-11 Thread Chris Bagwell
On Sat, Feb 11, 2012 at 2:21 AM, Adam Nielsen wrote: > Hi all, > > I recently got hold of a second-hand DTI-520 and I'd like to get it working > under Linux.  It seems it is not yet supported, so I am trying to add support > for it. > > > Some of the code I added to the kernel module is: > > stat

Re: [Linuxwacom-devel] Intuos4 WL is handled by evdev - what's wrong?

2012-02-10 Thread Chris Bagwell
On Fri, Feb 10, 2012 at 1:23 PM, Przemo Firszt wrote: > Dnia 2012-02-10, pią o godzinie 12:39 -0600, Chris Bagwell pisze: > [..] >> It would be better to have a new rule that matches Vendor name. >> >> Section "InputClass" >>       Identifier "Wa

Re: [Linuxwacom-devel] [PATCH] Add Wacom Intuos4 Wireless to 50-wacom.conf

2012-02-10 Thread Chris Bagwell
On Fri, Feb 10, 2012 at 1:11 PM, Przemo Firszt wrote: > Dnia 2012-02-10, pią o godzinie 12:44 -0600, Chris Bagwell pisze: >> On Fri, Feb 10, 2012 at 12:27 PM, Peter Hutterer >> wrote: >> > On Fri, Feb 10, 2012 at 05:55:16PM +, Przemo Firszt wrote: >> >> In

Re: [Linuxwacom-devel] [PATCH] Add Wacom Intuos4 Wireless to 50-wacom.conf

2012-02-10 Thread Chris Bagwell
On Fri, Feb 10, 2012 at 12:27 PM, Peter Hutterer wrote: > On Fri, Feb 10, 2012 at 05:55:16PM +, Przemo Firszt wrote: >> Intuos4 Wireless doesn't match list of devices in 50-wacom.conf, so evdev was >> taking over. This patch fixes it, so now wacom driver is used fo Intuoe4 WL >> PTK-540WL >> >

Re: [Linuxwacom-devel] Intuos4 WL is handled by evdev - what's wrong?

2012-02-10 Thread Chris Bagwell
On Fri, Feb 10, 2012 at 11:54 AM, Przemo Firszt wrote: > Dnia 2012-02-11, sob o godzinie 03:27 +1000, Peter Hutterer pisze: >> On Fri, Feb 10, 2012 at 04:56:11PM +, Przemo Firszt wrote: >> > I was trying to find out why "xsetwacom --list devices" shows nothing >> > and I found that my tablet i

Re: [Linuxwacom-devel] GNOME Wacom panel implementation questions

2012-02-08 Thread Chris Bagwell
On Wed, Feb 8, 2012 at 9:28 AM, Peter Hutterer wrote: > On Thu, Feb 02, 2012 at 06:54:23PM +, Bastien Nocera wrote: >> Heya, >> >> Instead of hitting just Peter with this sort of question[1], I'm >> guessing that there are quite a few people on the list that could answer >> my questions (or po

Re: [Linuxwacom-devel] [PATCH] HID: wacom: Fix invalid power_supply_powers calls

2012-02-05 Thread Chris Bagwell
Looks good. Do you know if this has made it into a released kernel or only in an RC? If the former, you'll probably want to Cc: the stable email address in addition to linux-input; but I forget what that address is right now. But I think this is only in RC's. Chris On Sun, Feb 5, 2012 at 1:23 P

Re: [Linuxwacom-devel] [PATCH] HID: wacom: Exclude battery reporting for Intuos4 WL

2012-02-05 Thread Chris Bagwell
On Sun, Feb 5, 2012 at 1:15 PM, Przemo Firszt wrote: > Dnia 2012-02-04, sob o godzinie 10:52 -0600, Chris Bagwell pisze: >> I've been monitoring battery topics lately (no pun intended :-) ) >> because I'm adding adding similar logic to wacom_wac for wireless.  I

Re: [Linuxwacom-devel] [PATCH] HID: wacom: Exclude battery reporting for Intuos4 WL

2012-02-05 Thread Chris Bagwell
On Sun, Feb 5, 2012 at 8:08 AM, Przemo Firszt wrote: > Dnia 2012-02-04, sob o godzinie 10:52 -0600, Chris Bagwell pisze: > Chris, > irst of all - thanks for your comments! >> I've been monitoring battery topics lately (no pun intended :-) ) >> because I'm adding ad

Re: [Linuxwacom-devel] [PATCH] Move some usb-specific keys to wcmUSBData.

2012-02-04 Thread Chris Bagwell
And today I'm less dizzy. Thanks! Reviewed-by: Chris Bagwell On Sat, Feb 4, 2012 at 3:23 AM, Peter Hutterer wrote: > nbuttons and npadkeys is only used for USB-specific parsing, move them > there. > > Signed-off-by: Peter Hutterer > --- > No functional change > >

Re: [Linuxwacom-devel] [PATCH] HID: wacom: Exclude battery reporting for Intuos4 WL

2012-02-04 Thread Chris Bagwell
I've been monitoring battery topics lately (no pun intended :-) ) because I'm adding adding similar logic to wacom_wac for wireless. I know that the function power_supply_powers() that is in stack trace is brand new (not in official kernel) and associates a power supply to a specific device (nice

Re: [Linuxwacom-devel] [PATCH] Initialize button action properties for the correct button number (#45557)

2012-02-03 Thread Chris Bagwell
r both patches: Reviewed-by: Chris Bagwell On Fri, Feb 3, 2012 at 3:31 AM, Peter Hutterer wrote: > Previous code had the number of properties for button actions hardcoded to > 16 (WCM_MAX_MOUSE_BUTTONS). Drop that define and instead initialize the same > number of properties that we hav

Re: [Linuxwacom-devel] libwacom

2012-02-02 Thread Chris Bagwell
On Thu, Feb 2, 2012 at 3:32 PM, Jason Gerecke wrote: > On Thu, Feb 2, 2012 at 12:09 PM, Chris Bagwell wrote: >> On Thu, Feb 2, 2012 at 12:31 PM, Bastien Nocera wrote: >>> On Thu, 2012-02-02 at 11:55 -0600, Favux ... wrote: >>>> Hi Bastien, >>>&g

Re: [Linuxwacom-devel] libwacom

2012-02-02 Thread Chris Bagwell
On Thu, Feb 2, 2012 at 12:31 PM, Bastien Nocera wrote: > On Thu, 2012-02-02 at 11:55 -0600, Favux ... wrote: >> Hi Bastien, >> >> Thanks for reviewing the wiki page. >> >> On Thu, Feb 2, 2012 at 10:31 AM, Bastien Nocera wrote: >> >> > I think the information about filling in the definition files

Re: [Linuxwacom-devel] [PATCH] hid-wacom: add support to Intuos4 pad buttons and dial

2012-02-02 Thread Chris Bagwell
On Thu, Feb 2, 2012 at 10:34 AM, Bastien Nocera wrote: > On Thu, 2012-02-02 at 11:08 -0500, Aristeu Rozanski wrote: >> > I do not know if these Bluetooth Intuos4 support mouse pucks. > > From what I've read (before stupidly buying the USB-only version), plug > in the Intuos4 WL via USB and it's th

Re: [Linuxwacom-devel] [PATCH] hid-wacom: add support to Intuos4 pad buttons and dial

2012-02-02 Thread Chris Bagwell
On Thu, Feb 2, 2012 at 10:08 AM, Aristeu Rozanski wrote: > On Thu, Feb 02, 2012 at 09:32:03AM -0600, Chris Bagwell wrote: >> Hi Aristeu, >> >> I'm sure people will be happy to see this patch.  I've a question for you >> below. >> >> On Wed,

Re: [Linuxwacom-devel] [PATCH] hid-wacom: add support to Intuos4 pad buttons and dial

2012-02-02 Thread Chris Bagwell
When I mention ABS_MISC, it should really be MSC_SERIAL. But the link I sent tells it all better. Chris On Thu, Feb 2, 2012 at 9:32 AM, Chris Bagwell wrote: > Hi Aristeu, > > I'm sure people will be happy to see this patch.  I've a question for you > below. > > On

Re: [Linuxwacom-devel] [PATCH] hid-wacom: add support to Intuos4 pad buttons and dial

2012-02-02 Thread Chris Bagwell
Hi Aristeu, I'm sure people will be happy to see this patch. I've a question for you below. On Wed, Feb 1, 2012 at 11:23 AM, Aristeu Rozanski wrote: > This patch adds support for the pad buttons and dial in the bluetooth version > of Intuos4. > > Signed-off-by: Aristeu Rozanski > > --- >  driv

Re: [Linuxwacom-devel] Touchpad?

2012-01-22 Thread Chris Bagwell
On Sun, Jan 22, 2012 at 3:38 AM, Cedric Sodhi wrote: > On Sat, Jan 21, 2012 at 06:15:35PM -0600, Chris Bagwell wrote: >> On Sat, Jan 21, 2012 at 2:31 PM, Cedric Sodhi wrote: >> > On Sat, Jan 21, 2012 at 11:14:37PM +0700, Alexey Osipov wrote: >> >> Okay, I think I se

Re: [Linuxwacom-devel] Touchpad?

2012-01-21 Thread Chris Bagwell
On Sat, Jan 21, 2012 at 2:31 PM, Cedric Sodhi wrote: > On Sat, Jan 21, 2012 at 11:14:37PM +0700, Alexey Osipov wrote: >> Okay, I think I see the problem. >> >> You have a touchscreen device, not a touchpad, right? >> >> Touchscreen and touchpad behaviours are different in xf86-input-wacom. >> >> T

Re: [Linuxwacom-devel] GIMP doesn't recognise pen and eraser.

2012-01-19 Thread Chris Bagwell
On Thu, Jan 19, 2012 at 2:22 PM, Przemo Firszt wrote: > Dnia 2012-01-19, czw o godzinie 14:12 -0600, Chris Bagwell pisze: >> What version of hid-wacom.c is being used?  The version in Linus's try >> doesn't report ABS_MISC for anything. >> >> The values for

Re: [Linuxwacom-devel] GIMP doesn't recognise pen and eraser.

2012-01-19 Thread Chris Bagwell
What version of hid-wacom.c is being used? The version in Linus's try doesn't report ABS_MISC for anything. The values for ABS_MISC look invalid to me. If the driver advertises itself as a Protocol 4 or 5 device and sends invalid ABS_MISC's, xf86-input-wacom used to discard those packets. Not su

Re: [Linuxwacom-devel] [PATCH v2] Enable LED status change through xsetwacom

2012-01-18 Thread Chris Bagwell
Well, this showed up just in time for me to be conflicted. I've completed support for monitoring the battery on wireless bamboo's and thinking about adding support to control powersavings timeout period like Windows driver has. Its kinda a waste unless there is a GUI to go with it though. Since

Re: [Linuxwacom-devel] Changing to freedesktop bugzilla?

2012-01-14 Thread Chris Bagwell
On Thu, Jan 12, 2012 at 4:22 PM, Peter Hutterer wrote: > On Thu, Jan 12, 2012 at 11:30:08AM +0100, Timo Aaltonen wrote: >> 12.01.2012 04:25, Peter Hutterer kirjoitti: >> > Trawling through my xorg bugs yesterday I found a few that were filed >> > against the Input/wacom component at bugs.freedeskt

Re: [Linuxwacom-devel] Boogie Board Rip

2012-01-14 Thread Chris Bagwell
On Sat, Jan 14, 2012 at 5:55 PM, wrote: >  Hello Everyone, >  This is my first involvement in this project so please let me know if >  I'm posting in the wrong place or anything. >  My name's Mark Johnson, I'm mainly a web developer but dabble quite a >  bit. > >  The reason for my posting is tha

Re: [Linuxwacom-devel] [PATCH] lib: Don't export private symbols

2012-01-11 Thread Chris Bagwell
This uses a gnu-ish. Not sure if this matters or if any of the other xf86-input-* do this type stuff. Once upon a time, there was a port of xf86-input-wacom to Solaris using non-GNU linker. Chris On Wed, Jan 11, 2012 at 9:38 AM, Robert Ancell wrote: > Attached patch stops private symbols from

Re: [Linuxwacom-devel] [PATCH 2/2] Add a new property: WACOM_PROP_ENABLE_MT

2012-01-09 Thread Chris Bagwell
On Mon, Jan 9, 2012 at 3:02 PM, Ping Cheng wrote: > On Mon, Jan 9, 2012 at 7:22 AM, Chris Bagwell wrote: >> >> >> I'd like to understand this better if ya don't mind. >> >> First up, is this usecase for absolute or relative mode? > > > Very g

  1   2   3   4   5   6   7   >