Re: [lng-odp] Code review and discussion on mailing list only

On 2 October 2017 at 17:53, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > Hi, > > Let's stop using Github for code review and design discussions. Mailing > list is far more flexible and robust for human-to-human interaction than a > web-based tool. We can continue to

Re: [lng-odp] [PATCH] linux-gen: barrier: Use correct memory ordering

Merged. Sorry for delay. Maxim. On 09/06/17 19:37, Brian Brooks wrote: > ping > > On Sat, Aug 26, 2017 at 9:52 AM, Bill Fischofer > wrote: >> On Sat, Aug 26, 2017 at 12:40 AM, Brian Brooks wrote: >> >>> Memory accesses that happen-before, in

Re: [lng-odp] Supporting ODP_PKTIO_OP_MT_SAFE

with > one pktin/one pktout? > > Best regards, > Bogdan > I think - yes, there should not be limitation. Maxim. > > On 11 September 2017 at 11:33, Maxim Uvarov <maxim.uva...@linaro.org> > wrote: > > On 11 September 2017 at 06:26, Brian Brooks <brian.bro...@

Re: [lng-odp] Supporting ODP_PKTIO_OP_MT_SAFE

On 11 September 2017 at 06:26, Brian Brooks wrote: > Honnappa, > > Could your proposal be simplified to: MT-safe pktio should be > deprecated because it is not a common use case. Applications will > either use MT-unsafe pktio or the MT-safe scheduler. > > > 1) Polling

[lng-odp] Fwd: Cunit configuration error

Forwarded Message Subject: Cunit configuration error Date: Tue, 5 Sep 2017 09:11:32 -0700 From: Bala Manoharan <bala.manoha...@linaro.org> To: Maxim Uvarov <maxim.uva...@linaro.org> Hi, I got this error from latest api-next in github. Anything I am missing? I ha

Re: [lng-odp] Regarding github pull (RE: [Linaro/odp] [PATCH API-NEXT v12] comp: compression spec (#102))

Shally, you need to prepare commits manually. Github will not squash them. By prepare I mean: 1. isolate api patch. it has to have api: prefix and be the first patch. That patch needs Petri's review. 2. put all other patches behind it. Split them as reasonable but keep bisectability working.

Re: [lng-odp] Compiler Barrier API

On 09/04/17 18:09, Andriy Berestovskyy wrote: > Hey guys, > There are few __asm__ volatile("" ::: "memory") in the generic ODP code, > but seems like there is no API for the compiler barrier. > > Shall we add one to the api/sync.h? > > Andriy Hello Andriy, Do you have use case for that? In my

Re: [lng-odp] api-next broken?

-latomic is not installed and ./configure did not detect that. Can you please write compiler version? On 31 August 2017 at 13:25, shally verma wrote: > I was trying api-next from linaro/odp as of today and am seeing this > error. Am I missing anything here? > > I

Re: [lng-odp] Regarding github pull request

>> >> >> On Thu, Aug 3, 2017 at 12:40 AM, shally verma <shallyvermacav...@gmail.com> >> wrote: >> >> On Wed, Aug 2, 2017 at 10:04 PM, shally verma >> >> <shallyvermacav...@gmail.com> wrote: >>> On Wed, Aug 2, 2017 at 6:03 PM,

[lng-odp] v1.11.0.1_monarch was tagged

Hello, update for Monarch release was published under v1.11.0.1 tag: https://github.com/Linaro/odp/releases/tag/v1.11.0.1_monarch Please find changes in it's changelog: https://github.com/Linaro/odp/blob/monarch_lts/CHANGELOG Best regards, Maxim.

Re: [lng-odp] [PATCH v2 0/3] Pktrefs opt

that can be applied, does anybody have objections? Maxim. On 08/15/17 01:00, Github ODP bot wrote: > Optimizations to the zero-copy packet reference code to partially address > issues raised in > https://bugs.linaro.org/show_bug.cgi?id=3201 > > github >

Re: [lng-odp] [PATCH API-NEXT v6 0/1] API:IPSEC: IPSEC events may be reported synchronously

Petri, please add your review to API patch. On 15 August 2017 at 08:00, Github ODP bot wrote: > IPSEC events may be delivered synchronous or ansynchrous > depending on implementation. Application will know based on > return value of odp_ipsec_sa_disable API. > Signed-off-by:

Re: [lng-odp] [PATCH API-NEXT v5 1/1] API:IPSEC: IPSEC events may be reported synchronously.

replay to test github scripts.

Re: [lng-odp] [PATCH API-NEXT v5 1/1] API:IPSEC: IPSEC events may be reported synchronously.

On 08/15/17 07:42, Peltonen, Janne (Nokia - FI/Espoo) wrote: > Aside to Maxim: the GitHub to mailing list path has been working well but the > mailing list to GitHub return path is not. Any idea what's needed to enable > that path? Alternatively, Janne, you might want to reply via GitHub to

Re: [lng-odp] [PATCH v1 1/6] Initialize pktio configuration structure

this patch has to be: linux-gen: pktio:

Re: [lng-odp] [EXT] Re: ODP1.15 buffer alignment issue

dp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of shally >> verma >> Sent: Friday, August 11, 2017 8:05 AM >> To: Maxim Uvarov <maxim.uva...@linaro.org> >> Cc: Elo, Matias (Nokia - FI/Espoo) <matias@nokia.com>; Petri Savolainen >> <petri.savola

Re: [lng-odp] [EXT] Re: ODP1.15 buffer alignment issue

quot;buffer data alignment". Please give me some time to double check with community that we all understand this api definition right. Thank you, Maxim. > -Original Message- > From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] > Sent: Thursday, August 10, 2017 19:45 > To:

Re: [lng-odp] ODP1.15 buffer alignment issue

On 08/08/17 09:49, Liron Himi wrote: > Hi, > > See comments inline > > Regards, > Liron > > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim > Uvarov > Sent: Monday, August 07, 2017 23:21 > To: lng-odp@

Re: [lng-odp] ODP1.15 buffer alignment issue

it's implementation specific. Full code is: + offset = pool->headroom; + + /* move to correct align */ + while (((uintptr_t)[offset]) % pool->align != 0) + offset++; + + /* Pointer to data start (of the first segment)

[lng-odp] topic for Connect presentation wanted!

Hello ODP community, As you probably know at the end of September we will have Linaro Connect conference. There will be several presentations related to different ODP topics. If you have some topic in mind of wish something to be described more detail please let us know. Presentation will be

Re: [lng-odp] Regarding github pull request

On 2 August 2017 at 14:05, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > On 02/08/17 13:56, shally verma wrote: > > On Wed, Aug 2, 2017 at 4:15 PM, Maxim Uvarov <maxim.uva...@linaro.org> > wrote: > >> > >> > >> On 2

Re: [lng-odp] Regarding github pull request

On 2 August 2017 at 13:56, shally verma <shallyvermacav...@gmail.com> wrote: > On Wed, Aug 2, 2017 at 4:15 PM, Maxim Uvarov <maxim.uva...@linaro.org> > wrote: > > > > > > On 2 August 2017 at 13:35, shally verma <shallyvermacav...@gmail.com> > wrot

Re: [lng-odp] Regarding github pull request

On 2 August 2017 at 13:35, shally verma wrote: > Hi > > Based on discussion in yesterday's odp public call, I was trying to > exercise github pull request feature for patch submission. But running > into some doubts. > > -Should I create a pull request from a main

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

On 2 August 2017 at 09:03, shally verma <shallyvermacav...@gmail.com> wrote: > On Wed, Aug 2, 2017 at 1:39 AM, Maxim Uvarov <maxim.uva...@linaro.org> > wrote: > > On 08/01/17 15:02, Bill Fischofer wrote: > >> Correct tag for this should be --subject-prefix="

Re: [lng-odp] [PATCH CLOUD-DEV v3 3/3] odp: add modular framework

On 08/01/17 13:00, Github ODP bot wrote: > + > +int odp_module_install(void *dso, bool active) > +{ > + /* Bottom halves of the registration, context exclusion > + * is guaranteed by module_loader_start() > + */ > + if (0 == odp_rwlock_write_trylock()) { > +

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api:pktio: add MAC address and MTU set functions.

On 08/01/17 15:02, Bill Fischofer wrote: > Correct tag for this should be --subject-prefix="API-NEXT PATCHv2" > > Every time a revision of a patch is submitted, increment the version. This > is done automatically if you use a GitHub pull request, but must be done > manually if you submit the

Re: [lng-odp] odp_buffer_t and odp_packet_t

They are not linked. Packet might be different than buffers. Conversion with event is not really clear in implementation and has to check event type match. I.e. only ODP_EVENT_BUFFER type event can be created from buffer. If you need create packet, then alloc it and copy data to it with

Re: [lng-odp] [API-NEXT PATCHv7 1/4] api: timer: add odp_timer_capability() api

Merged. On 07/25/17 04:26, Bill Fischofer wrote: > On Wed, Jul 19, 2017 at 10:43 PM, Kevin Wang wrote: > >> Currently, user needs to decide the timer resolution before creating >> a timer pool. But sometimes it will cause timer overrun as the system >> can't support such

Re: [lng-odp] [PATCHv1] test: classification: fix: update odp_pktin_queue_param_t

test also should test case if flag is false. Maxim. On 07/27/17 16:26, Balasubramanian Manoharan wrote: > classifier_enable field in odp_pktin_queue_param_t has to set to true > for classification test suite to function correctly. > > Signed-off-by: Balasubramanian Manoharan

Re: [lng-odp] merge master to api-next

Merged. On 07/20/2017 08:15 PM, Brian Brooks wrote: On 07/27 14:04:24, Maxim Uvarov wrote: Looks like everything is fine: https://github.com/Linaro/odp/pull/71 Brian do you want to add your review to final patch? If no more objection I'm merging this and will work on merging other patches

Re: [lng-odp] merge master to api-next

but in script logic to check merges. git format-patch generates big number of patches if merge is seen. It was before and we did not fix it yet. On 27 July 2017 at 14:50, Bill Fischofer <bill.fischo...@linaro.org> wrote: > > > On Thu, Jul 27, 2017 at 6:04 AM, Maxim Uv

Re: [lng-odp] merge master to api-next

Looks like everything is fine: https://github.com/Linaro/odp/pull/71 Brian do you want to add your review to final patch? If no more objection I'm merging this and will work on merging other patches in the queue. Maxim. On 26 July 2017 at 22:33, Maxim Uvarov <maxim.uva...@linaro.org>

Re: [lng-odp] merge master to api-next

mitry.ereminsoleni...@linaro.org>> wrote: >> >> Brian, >> >> >> On 20 July 2017 at 00:23, Brian Brooks <brian.bro...@arm.com >> <mailto:brian.bro...@arm.com>> wrote: >> > On 07/26 10:29:41, Dmitry Eremin-Solenikov wrote: >>

Re: [lng-odp] ODP initialization: instance and multiple processes

On 07/26/2017 02:48 PM, Stanisław Kardach wrote: Hi all, I have been working on implementing a certain ODP platform that may allow users to create applications constructed from multiple processes (without a single parent) that would "join" together and start working as a single instance with a

[lng-odp] merge master to api-next

Merge request is: https://github.com/Linaro/odp/pull/71 2 arm build fails with errors. 1. https://travis-ci.org/muvarov/odp/jobs/257478037 CC odp_rwlock.lo :1:2: error: instruction requires: armv8 sevl 2. https://travis-ci.org/muvarov/odp/jobs/257478036 CC

Re: [lng-odp] PKTIO and classification

On 07/25/17 22:54, Liron Himi wrote: > Hi, > > I have a few questions/clarifications regarding classification in PKTIO: > > 1. As part of the 'odp_pktin_queue_param_t' application should set > 'classifier_enable' to '1' if classification support is wanted. Is that > correct? > > 2.

Re: [lng-odp] Issues with scalable scheduler

test after init_main_log test hangs forever. also a lot of compilation issues in: ipsec_test_in.c:52:2: warning: missing initializer for field ‘type’ of ‘odp_ipsec_tunnel_param_t’ Is not reproducible locally? On 25 July 2017 at 10:01, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org>

Re: [lng-odp] [PATCH] doc: userguide: add portability and usage info for odp time apis

Merged as discussed today. Maxim. On 06/30/17 00:07, Bill Fischofer wrote: > On Thu, Jun 22, 2017 at 4:50 PM, Brian Brooks <brian.bro...@arm.com> wrote: >> On 06/29 16:21:47, Maxim Uvarov wrote: >>> Hello Bill, >>> >>> patch is good. Please se

Re: [lng-odp] Monarch_lts tagging

thanks, applied. Maxim. On 21 July 2017 at 10:36, Elo, Matias (Nokia - FI/Espoo) < matias@nokia.com> wrote: > Hi Bill, > > I took a look at the patches in monarch_lts and as far as I can see the > only fix missing, from the issues our guys have reported, is the > "linux-gen: pktio: fix

Re: [lng-odp] [PATCH 0/6] dpdk pktio: enable hardware checksum support

> > -Matias > > > On 20 Jul 2017, at 23:16, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > > > > Krishna, Matias, please review dpdk changes. > > > > Maxim. > > > > On 07/19/17 16:35, Bogdan Pricope wrote: > >> Ping? > >> > &g

Re: [lng-odp] [PATCH 0/6] dpdk pktio: enable hardware checksum support

Krishna, Matias, please review dpdk changes. Maxim. On 07/19/17 16:35, Bogdan Pricope wrote: > Ping? > > We still want this for odp-linux or we should implement it on odp-dpdk > only (as soon as repository is updated)? > > /B > > On 20 June 2017 at 12:20, Bogdan Pricope

Re: [lng-odp] [PATCH v3 9/10] linux-generic: ipc: cannot share references across ipc

On 07/20/17 21:00, Github ODP bot wrote: > From: Bill Fischofer > > When attempting to send a reference via IPC, make a copy of the packet as > reference sharing is only supported within a single ODP instance. > > Signed-off-by: Bill Fischofer

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

On 19 July 2017 at 01:13, Bill Fischofer <bill.fischo...@linaro.org> wrote: > > > On Tue, Jul 18, 2017 at 2:42 PM, Maxim Uvarov <maxim.uva...@linaro.org> > wrote: > >> On 07/18/17 21:24, Bill Fischofer wrote: >> > >> > >> > On Tue, Jul

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

On 07/18/17 21:24, Bill Fischofer wrote: > > > On Tue, Jul 18, 2017 at 11:52 AM, Maxim Uvarov <maxim.uva...@linaro.org > <mailto:maxim.uva...@linaro.org>> wrote: > > On 07/18/17 19:20, Bill Fischofer wrote: > > As agreed during today's ODP Publi

Re: [lng-odp] [PATCH v1 0/9] update for monarch lts branch

If there is no objection that looks like it can be merged to monarch_lts and released. Maxim. On 07/14/17 12:59, Github ODP bot wrote: > Update for Monarch_lts release. I included Bills fixes for gcc 7 and added > Travis checks. > > github > /** Email

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

On 07/18/17 19:20, Bill Fischofer wrote: > As agreed during today's ODP Public call: > > APIs for MTU capability and setting OK. Applications should remember that > in most cases they will not be authorized to set the MTU since this relates > to physical properties of the interface. > >

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: add warning status event

Merged, Maxim. On 07/18/17 07:54, Nikhil Agarwal wrote: > Reviewed-by: Nikhil Agarwal > > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Petri > Savolainen > Sent: Friday, July 14, 2017 6:14 PM > To:

Re: [lng-odp] [PATCH API-NEXT v3 1/1] linux-gen: pktio: loop: reset packet subtype on loopback

On 07/12/17 12:00, Github ODP bot wrote: > From: Dmitry Eremin-Solenikov > > loop interface can get any kind of packets, but should output only basic > packets. Reset packet subtype on loopback. > > Signed-off-by: Dmitry Eremin-Solenikov

Re: [lng-odp] [PATCH v2 0/8] dpdk zero-copy pktio

Merged. Maxim. On 07/14/17 13:59, Github ODP bot wrote: > V2: > > Simplify mbuf_pool_create() arguments (Krishna) > Fix bug in dpdk_send() (Krishna) > Add Travis test (Maxim) > Destroy dpdk memory pool using a callback in odp_pool_destroy(). Fixes a bug > detected by Travis. > > This patch set

Re: [lng-odp] [PATCH API-NEXT v3 0/4] Crypto API updates

Merged. Maxim. On 14 July 2017 at 11:24, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > Reviewed-by: Petri Savolainen > > Maxim, could you merge this ASAP since patch 1/4 fixes broken api-next > build (when using gcc 4.8.4) > > > >

Re: [lng-odp] [PATCH API-NEXT v2 0/4] Crypto API updates

On 07/13/17 13:59, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Dmitry, Maxim, > > I think it's OK to merge v1 of this ASAP since it fixes e.g. api-next build > break. I did send my review yesterday. V2 just adds 4/4 patch on top. > > -Petri > > I'm ok to merge. checkpatch needs to be fixed

Re: [lng-odp] [PATCH v2 1/3] linux-gen: buffer: change buffer handle to pointer

Merged with review from v1. Maxim. On 07/13/17 15:58, Petri Savolainen wrote: > Changed buffer, event and timeout handles to be pointers. > Packet handles are already pointers. This enabled code > optimization as some conversions may be removed and remaining > once are just type casts. > >

Re: [lng-odp] [API-NEXT PATCH v3 1/9] api: ipsec: add salt parameter

Merged. On 07/13/17 17:30, Bala Manoharan wrote: > For the series: > Reviewed-by: Balasubramanian Manoharan > > > On 12 July 2017 at 19:24, Petri Savolainen > wrote: > >> Added a parameter for passing salt/nonce for algorithms that >>

Re: [lng-odp] [PATCH v1 1/1] pktio APIs to modify the MAC address or the MTU size of the given packet IO handler.

I remember that we previously added mac addr change. Then removed as supported on many systems. Since we have capability there it make reasonable now to add this api. Please send patch thought github pull request. It will do bunch of automatic tests. Thanks, Maxim. On 07/13/17 15:10,

Re: [lng-odp] [PATCH API-NEXT v4 1/1] api: ipsec: add retain header capability

Merged. Maxim. On 07/13/17 12:58, Dmitry Eremin-Solenikov wrote: > On 13.07.2017 12:00, Github ODP bot wrote: >> From: Nikhil Agarwal >> >> Signed-off-by: Nikhil Agarwal > > Reviewed-by: Dmitry Eremin-Solenikov > >> --- >> /** Email

Re: [lng-odp] [MONARCH_LTS PATCH 1/2] build: GCC 7 fixes

On 07/12/17 00:18, Bill Fischofer wrote: > From: Brian Brooks > > The GCC 7 series introduces changes that expose ODP compilation > issues. These include case statement fall through warnings, and > stricter checks on potential string overflows and other semantic > analysis.

Re: [lng-odp] [PATCH API-NEXT v9 0/10] Crypto API rework

Merged, Maxim.

Re: [lng-odp] [PATCH 7/7] linux-gen: dpdk: enable zero-copy operation

On 07/07/17 16:46, Elo, Matias (Nokia - FI/Espoo) wrote: > >> On 7 Jul 2017, at 0:21, Maxim Uvarov <maxim.uva...@linaro.org> wrote: >> >> On 07/03/17 15:01, Matias Elo wrote: >>> +zero_copy=0 >>> +AC_ARG_ENABLE([dpdk-zero-copy], >>> +[

Re: [lng-odp] [API-NEXT PATCH 1/4] linux-gen: sched: remove schedule interface depedency to qentry

Hello Honnappa, it looks like there is no blocker issue to merge these patches. Improvements can be done later and clean up can go in now. Do you agree? Maxim. On 7 July 2017 at 09:46, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > >> typedef struct schedule_fn_t

Re: [lng-odp] [PATCH 7/7] linux-gen: dpdk: enable zero-copy operation

On 07/03/17 15:01, Matias Elo wrote: > +zero_copy=0 > +AC_ARG_ENABLE([dpdk-zero-copy], > +[ --enable-dpdk-zero-copy enable experimental zero-copy DPDK pktio > mode], > +[if test x$enableval = xyes; then > +zero_copy=1 > +fi]) > + please add corresponding check to his to

Re: [lng-odp] [PATCH v4 3/9] linux-gen: stop poisoning CPPFLAGS/LDFLAGS with DPDK flags

Petri, are you ok with that serries? Patch 9/9 is the major goal for odp packaging. p.s. as for me I don't have objections to merge it. Maxim. On 4 July 2017 at 23:07, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > On 04.07.2017 16:43, Savolainen, Petri (Nokia -

Re: [lng-odp] [API-NEXT PATCH] api: system_info: add function for fetching all supported huge page sizes

Matias, I would change it from unsigned. That allows to reuse on variable for all return code. int ret; re t= odp_init_global() if (ret) .. ret = odp_packet()... if (ret) ret = odp_sys_huge_page_size_all() <- here in your case we will need additional cast to unsigned if (ret) ... return ret;

Re: [lng-odp] [PATCH CLOUD-DEV v1] [RFC 1/2] odp: add modular framework

yes, we can not use GPL code in ODP it has to be pure BSD license. Please be very careful about back ports from any other not BSD projects. Maxim. On 5 July 2017 at 07:28, Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> wrote: > Hi Yi, > scalable scheduler added a lock-less (for

Re: [lng-odp] travis image update debug issues

On 07/04/17 23:11, Dmitry Eremin-Solenikov wrote: > On 04.07.2017 18:12, Maxim Uvarov wrote: >> Hello, >> >> I have ssh to travis machines for some limited time to debug what is >> wrong with pktio tap test after image update. >> >> I wrote more detail infor

[lng-odp] travis image update debug issues

Hello, I have ssh to travis machines for some limited time to debug what is wrong with pktio tap test after image update. I wrote more detail information here: https://bugs.linaro.org/show_bug.cgi?id=3099 In few words packets do not go thought bridged tap device. Network device counters are not

Re: [lng-odp] [PATCH] doc: userguide: add portability and usage info for odp time apis

Hello Bill, patch is good. Please see my notes bellow which I think reasonable. On 02/14/17 01:47, Bill Fischofer wrote: > Clarify and expand on portability and performance considerations > regarding the use of the ODP time APIs in fulfillment of JIRA fulfilment > issue

Re: [lng-odp] [API-NEXT PATCH v10 0/6] A scalable software scheduler

Merged. Maxim. On 06/26/17 12:03, Yi He wrote: > Hi, Maxim and team, for this patch series, I reviewed and tested on > x86-64 platform with doxygen, check and distcheck matrix (gcc/clang x > default/scalable scheduler), please see if this is good to be merged. > > Reviewed-and-tested-by: Yi

Re: [lng-odp] [PATCH v1 2/2] travis: add cross-compilation checks

On 28 June 2017 at 00:54, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > On 27.06.2017 18:51, Maxim Uvarov wrote: > > On 06/27/17 16:17, Dmitry Eremin-Solenikov wrote: > >> On 27.06.2017 16:15, Maxim Uvarov wrote: > >>> On

Re: [lng-odp] [EXT] Re: [lng-check-odp] PKTIO statistics validation test

> > Regards, > Liron > > > -Original Message- > From: lng-check-odp [mailto:lng-check-odp-boun...@lists.linaro.org] On > Behalf Of Maxim Uvarov > Sent: Tuesday, June 27, 2017 17:48 > To: lng-check-...@lists.linaro.org > Subject: [EXT] Re: [lng-check-od

Re: [lng-odp] [lng-check-odp] PKTIO validation test - Loopback mode

- check-odp list (which is for test in odp-check,git scripts only) + main odp mailing list I think we did not test single interface. And it's not tested with make check. Patch is looks ok. It would be nice to make it work under 'make check' execution. Can you please send patches via github merge

Re: [lng-odp] [PATCH] build: fix 64-bit atomics detection

On 27 June 2017 at 22:58, Brian Brooks wrote: > Use uint64_t instead of int type. > > This resolves ipfragreass build breakage with clang on 32-bit systems. > > Change-Id: I23b9b6a46cbfaeff99116dac9c22e86629cbdf24 > looks ok for me, but please remove change-id and add

Re: [lng-odp] [PATCH v1 2/2] travis: add cross-compilation checks

On 06/27/17 16:17, Dmitry Eremin-Solenikov wrote: > On 27.06.2017 16:15, Maxim Uvarov wrote: >> On 06/27/17 16:00, Github ODP bot wrote: >>> + - env echo -e 'Provides\x3a multiarch-support, >>> debconf, debconf-2.0' > dummy >> typo > > Where? > what is "\x3a" ? Maxim.

Re: [lng-odp] [PATCH v1 2/2] travis: add cross-compilation checks

On 06/27/17 16:18, Dmitry Eremin-Solenikov wrote: > On 27.06.2017 16:13, Maxim Uvarov wrote: >> On 06/27/17 16:00, Github ODP bot wrote: >>> -- ./bootstrap >>> -- ./configure --enable-debug --enable-automated --enable-basic >>> --enable-con

Re: [lng-odp] [PATCH v1 2/2] travis: add cross-compilation checks

On 06/27/17 16:00, Github ODP bot wrote: > + - env echo -e 'Provides\x3a multiarch-support, > debconf, debconf-2.0' > dummy typo

Re: [lng-odp] [PATCH v1 2/2] travis: add cross-compilation checks

On 06/27/17 16:00, Github ODP bot wrote: > -- ./bootstrap > -- ./configure --enable-debug --enable-automated --enable-basic > --enable-console --enable-examples --enable-test > +- libtoolize --force --copy > +- aclocal > +- autoheader > +- automake

Re: [lng-odp] [PATCH v1 1/2] build: better atomics detection

On 06/27/17 16:00, Github ODP bot wrote: > From: Brian Brooks > > Do not optimize away the result of an atomic operation > during atomics detection in configure stage of build. > > This resolves ipfragreass build breakage with clang on > 32-bit systems. > > [DES: fix

Re: [lng-odp] [PATCH] build: better atomics detection

maybe return something like (prev & 0xff) ? On 27 June 2017 at 10:51, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Brian > > Brooks > > Sent: Monday, June

Re: [lng-odp] [API-NEXT PATCH v10 0/6] A scalable software scheduler

017 at 20:37, Maxim Uvarov <maxim.uva...@linaro.org > <mailto:maxim.uva...@linaro.org>> wrote: > > On 06/26/17 12:03, Yi He wrote: > > Hi, Maxim and team, for this patch series, I reviewed and tested on > > x86-64 platform with doxygen, check and dis

Re: [lng-odp] [API-NEXT PATCH v10 0/6] A scalable software scheduler

On 06/26/17 12:03, Yi He wrote: > Hi, Maxim and team, for this patch series, I reviewed and tested on > x86-64 platform with doxygen, check and distcheck matrix (gcc/clang x > default/scalable scheduler), please see if this is good to be merged. > > Reviewed-and-tested-by: Yi He

Re: [lng-odp] [API-NEXT PATCH v4] timer: allow timer processing to run on worker cores

t; pass NULL, and thus timer polling is kept disabled by default. > > When contributing to a central piece of data plane code, it would be really > important to measure packet rate before and after the change... > > > -Petri > Thank Petri, I opened bug to track this: htt

Re: [lng-odp] [PATCH v4] example: add IPv4 fragmentation/reassembly example

On 06/23/17 23:32, Brian Brooks wrote: > On 06/23 22:50:09, Maxim Uvarov wrote: >> clang -m32 on x86 failed. > > On 32-bit machines -latomic is needed when compiling with > Clang. It is not needed with GCC. > > I suspect the atomics checking in > /platform/linux-generi

Re: [lng-odp] [PATCH v4] example: add IPv4 fragmentation/reassembly example

clang -m32 on x86 failed. Joe, do you want to take a look at it? [...truncated 76.24 KB...] cc: clang cc version: 3.5.0 cppflags: am_cppflags:

Re: [lng-odp] [API-NEXT PATCH v4] timer: allow timer processing to run on worker cores

Merged to api-next. I think this patch is clean and we can do further improvements / tuning later. Regards, Maxim. On 22 June 2017 at 21:48, Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> wrote: > On 22 June 2017 at 10:30, Maxim Uvarov <maxim.uva...@linaro.org> wrote:

Re: [lng-odp] [API-NEXT PATCHv7 1/5] api: feature: add odp feature bits

Merged. On 06/13/17 16:16, Savolainen, Petri (Nokia - FI/Espoo) wrote: > For the entire patch set: > > Reviewed-by: Petri Savolainen > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill >> Fischofer >>

Re: [lng-odp] [PATCH] build: fix conditional compilation of sources

On 06/22/17 19:54, Brian Brooks wrote: > On 06/22 19:44:45, Maxim Uvarov wrote: >> On 06/22/17 19:19, Brian Brooks wrote: >>> On 06/22 19:06:01, Maxim Uvarov wrote: >>>> On 06/22/17 17:17, Brian Brooks wrote: >>>>> On 06/22 11:13:57, Maxim Uvarov

Re: [lng-odp] [PATCH] build: fix conditional compilation of sources

On 06/22/17 19:19, Brian Brooks wrote: > On 06/22 19:06:01, Maxim Uvarov wrote: >> On 06/22/17 17:17, Brian Brooks wrote: >>> On 06/22 11:13:57, Maxim Uvarov wrote: >>>> On 22 June 2017 at 06:24, Brian Brooks <brian.bro...@arm.com> wrote: >>>> >

Re: [lng-odp] [PATCH] build: fix conditional compilation of sources

On 06/22/17 17:17, Brian Brooks wrote: > On 06/22 11:13:57, Maxim Uvarov wrote: >> On 22 June 2017 at 06:24, Brian Brooks <brian.bro...@arm.com> wrote: >> >>> Explicitly add all arch//* files to respective _SOURCES >>> variables instead of using @ARCH_DIR@

Re: [lng-odp] [MONARCH_LTS PATCH] linux-gen: socket: remove limits for maximum RX/TX burst size

added to monarch_lts branch. And also added monarch_lts branch to github. Which looks like I forgot to add and nobody noticed. Best regards, Maxim. On 06/20/17 10:13, Matias Elo wrote: > Remove unnecessary limits for maximum RX/TX burst size. > > Fixes:

Re: [lng-odp] [API-NEXT PATCH v4] timer: allow timer processing to run on worker cores

sharing > [2] http://connect.linaro.org/resource/bud17/bud17-320/ > 1) we have all adjustable configs here ./platform/linux-generic/include/odp_config_internal.h that might be also needs to be there. 2) Do we need something special in CI to check different config values? 3) Why it's compile ti

Re: [lng-odp] [PATCH v2 0/9] Rework the way ODP links with other libraries

Hello Matias, was your commend addressed in v2? Thank you, Maxim. On 06/14/17 00:59, Github ODP bot wrote: > Currently configure tests add all libraries to AM_LDFLAGS or LIBS, thus > making all libraries link against everything. For example libodp-linux ends > up depending on libcunit.

Re: [lng-odp] [PATCH v2] linux-gen: time: fix ARM compile for GCC 4.8

just merged it with Brians review. Tested ifdefs yesterday. Maxim. On 22 June 2017 at 15:49, Bill Fischofer wrote: > On Thu, Jun 22, 2017 at 4:17 AM, Petri Savolainen > wrote: > > Use __aarch64__ instead of __ARM_ARCH, since it's

Re: [lng-odp] [API-NEXT PATCH v4] timer: allow timer processing to run on worker cores

Petri, do you want to test performance before patch inclusion? Maxim. On 21 June 2017 at 21:52, Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> wrote: > We have not run any performance application. In our Linaro connect > meeting, we presented numbers on how it improves the timer

Re: [lng-odp] [PATCH] build: fix conditional compilation of sources

On 22 June 2017 at 06:24, Brian Brooks wrote: > Explicitly add all arch//* files to respective _SOURCES > variables instead of using @ARCH_DIR@ substitution. > > This patch fixes the broken build for ARM, PPC, and MIPS > introduced by [1] and the similar issue reported

Re: [lng-odp] Need to standardize tools version

weekly public > call. > if using a travis CI a way to go then it will be helpful if could be > documented as minimum acceptance criteria for patches with bit of > pointers on how to use it to help novice user like me. > > Thanks > Shally > > > > On 21 J

Re: [lng-odp] [PATCH] linux-gen: time: fix ARM compile for GCC 4.8

On 06/21/17 23:30, Brian Brooks wrote: > #if -> #ifdef > ifdef works. > On Wed, Jun 21, 2017 at 3:27 PM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: >> odp check with ARCH=arm fails after this patch: >> >> CC arch/arm/odp_cpu_arch.lo >

Re: [lng-odp] [PATCH] linux-gen: time: fix ARM compile for GCC 4.8

odp check with ARCH=arm fails after this patch: CC arch/arm/odp_cpu_arch.lo arch/arm/odp_cpu_arch.c: In function 'cpu_global_time': arch/arm/odp_cpu_arch.c:71:5: error: "__aarch64__" is not defined [-Werror=undef] #if __aarch64__ ^ arch/arm/odp_cpu_arch.c: In function

Re: [lng-odp] [API-NEXT PATCH v9 3/6] linux-gen: sched scalable: add a bitset

On 06/21/17 23:00, Dmitry Eremin-Solenikov wrote: > On 21.06.2017 21:14, Ola Liljedahl wrote: >> >> On 20/06/2017, 15:04, "Savolainen, Petri (Nokia - FI/Espoo)" >> wrote: >> >>> >>> +++ b/platform/linux-generic/include/odp_bitset.h @@ -0,0 +1,210 @@ +/*

Re: [lng-odp] [PATCH API-NEXT v1 1/1] linux-generic: queue: modular queue interface

On 06/19/17 08:00, Github ODP bot wrote: > log| 1269 > log has not be a part of patch. Maxim.

Re: [lng-odp] Need to standardize tools version

it's very hard to standardize tools and compiler version. For now to validate patches we use Linaro CI (odp-check scripts) and Travis CI which is based on some stable ubuntu version. Also we really want that all people can download odp, compile it and run. It's very rare case if different tools

Re: [lng-odp] [API-NEXT PATCH v9 4/6] linux-gen: sched scalable: add a concurrent queue

.org> wrote: >>> Hi Maxim, >>> This is a new file added by us. Hence the ARM copyright. >>> Thanks, >>> Honnappa >>> >>> On 21 June 2017 at 09:06, Maxim Uvarov <maxim.uva...@linaro.org> wrote: >>>> On 06/19/17 22:12, Br

<    1   2   3   4   5   6   7   8   9   10   >